Hi Peter,
Thank you for the clarification.
On 08/19/2013 04:00 PM, Peter Zijlstra wrote:
On Mon, Aug 19, 2013 at 09:47:47AM +0530, Preeti U Murthy wrote:
Hi Peter,
On 08/16/2013 03:42 PM, Peter Zijlstra wrote:
I have a few comments and clarification to seek.
1. How are you ensuring from
Hi Ben
On 08/22/2013 08:40 AM, Benjamin Herrenschmidt wrote:
On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote:
-static irqreturn_t unused_action(int irq, void *data)
+static irqreturn_t timer_action(int irq, void *data)
{
- /* This slot is unused and hence available for use
Hi Ben,
On 08/22/2013 08:57 AM, Benjamin Herrenschmidt wrote:
On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote:
static irqreturn_t timer_action(int irq, void *data)
{
-timer_interrupt();
+decrementer_timer_interrupt();
return IRQ_HANDLED;
}
I don't completely
Hi Ben,
On 08/22/2013 08:58 AM, Benjamin Herrenschmidt wrote:
On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote:
This patch hooks into the existing broadcast framework along with the support
that this patchset introduces for ppc, and the cpuidle driver backend
for powernv(posted out
interrupt is called on the cpu
in deep idle state to handle the local events.
The current design and implementation of the timer offload framework supports
the ONESHOT tick mode but not the PERIODIC mode.
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h
efficiently.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |3 ++-
arch/powerpc/kernel/smp.c | 19 +++
arch/powerpc/platforms/cell/interrupt.c |2
...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2 +-
arch/powerpc/platforms/ps3/smp.c|2 +-
4 files changed, 8
on powernv
Patch[5/6]: Dynamically pick a broadcast CPU
Patch[6/6]: Remove the constraint of having to disable tickless idle on the
broadcast cpu, by queueing a hrtimer exclusively to do broadcast handling.
---
Preeti U Murthy (4):
cpuidle/ppc: Add timer offload framework to support deep idle
just wakeup, the new broadcast CPU has to restart
the hrtimer on itself so as to continue broadcast handling.
Signed-off-by: Preeti U Murthypre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h |5 ++
arch/powerpc/kernel/time.c | 47
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h |1
arch/powerpc/kernel/time.c | 10 ++--
arch/powerpc/platforms/powernv/processor_idle.c | 56 +++
3 files changed, 53 insertions(+), 14 deletions
sleep on ppc.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/platforms/powernv/processor_idle.c | 48 +++
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/processor_idle.c
b/arch/powerpc/platforms
into the scheduler is being done because the scheduler can
call the frequency driver at times *complimenting* load balancing,
unlike now.
Also adding Rafael to the cc list.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Hi Morten,
On 07/12/2013 07:18 PM, Morten Rasmussen wrote:
On Thu, Jul 11, 2013 at 12:34:49PM +0100, Preeti U Murthy wrote:
Hi Morten,
I have a few quick comments.
I am concerned too about scheduler making its load balancing decisions
based on the cpu frequency for the reason that it could
there was no significant change in the observation.
I will try patch V2 and let you know the results.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
for all their comments and suggestions so far.
---
Preeti U Murthy (4):
cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt
handling routines
cpuidle/ppc: Add basic infrastructure to support the broadcast framework
on ppc
cpuidle/ppc: Introduce the deep idle
...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2 +-
arch/powerpc/platforms/ps3/smp.c|2 +-
4 files changed, 8
() into routines performed during regular
interrupt handling and __timer_interrupt(), which takes care of running local
timers and collecting time related stats. Now on a broadcast ipi, call
__timer_interrupt().
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/time.c
-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[Changelog modified by pre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |3 ++-
arch/powerpc/include/asm/time.h |1 +
arch/powerpc/kernel/smp.c
the broadcast ipi, set the
decrementers_next_tb
to now before calling __timer_interrupt().
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/Kconfig|1 +
arch/powerpc/include/asm/time.h |1 +
arch/powerpc/kernel/time.c | 69
cycle repeats.
Protect the region of nomination,de-nomination and check for existence of
broadcast
cpu with a lock to ensure synchronization between them.
[1] tick_handle_oneshot_broadcast() or tick_handle_periodic_broadcast().
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch
was about to fire on it. Therefore the newly nominated broadcast cpu
should set the broadcast hrtimer on itself to expire immediately so as to not
miss wakeups under such scenarios.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h |1 +
arch
Hi Soren,
On 09/13/2013 03:50 PM, Preeti Murthy wrote:
Hi,
So the patch that Daniel points out http://lwn.net/Articles/566270/ ,
enables broadcast functionality
without using an external global clock device. It uses one of the per cpu
clock devices to enable the broadcast functionality
, but
the low level handling of the entry into idle states should be taken
care of by the architecture.
Your recent patch :
cpuidle: add freescale e500 family porcessors idle support IMO should
hook onto the backend cpuidle driver that this patchset provides.
Regards
Preeti U Murthy
--
To unsubscribe
Hi Dongsheng,
On 07/31/2013 11:16 AM, Wang Dongsheng-B40534 wrote:
Hi Preeti,
-Original Message-
From: Preeti U Murthy [mailto:pre...@linux.vnet.ibm.com]
Sent: Wednesday, July 31, 2013 12:00 PM
To: Wang Dongsheng-B40534
Cc: Deepthi Dharwar; b...@kernel.crashing.org; daniel.lezc
+ * is eligible for doing load balancing at this and above domains.
+ */
+ return balance_cpu != env-dst_cpu;
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
not convey this immediately.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On 08/02/2013 02:35 PM, 김준수 wrote:
-Original Message-
From: Preeti U Murthy [mailto:pre...@linux.vnet.ibm.com]
Sent: Friday, August 02, 2013 1:23 PM
To: Joonsoo Kim
Cc: Ingo Molnar; Peter Zijlstra; linux-kernel@vger.kernel.org; Mike
Galbraith; Paul Turner; Alex Shi; Vincent
notifiers from
other architectures into the cpuidle framework as well?
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
Hi Soren,
On 09/13/2013 09:53 PM, Sören Brinkmann wrote:
Hi Preeti,
Thanks for the explanation but now I'm a little confused. That's a lot of
details and I'm lacking the in depth knowledge to fully understand
everything.
Is it correct to say, that your patch series enables per cpu devices
...@linux.vnet.ibm.com
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2
.
2. Remove the constraint of having to disable tickless idle on the broadcast
CPU by queueing a hrtimer dedicated to do broadcast.
V1 posting: https://lkml.org/lkml/2013/7/25/740.
1. Added the infrastructure to wakeup CPUs in deep idle states in which the
local timers stop.
---
Preeti U Murthy
-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[Functions renamed to tick_broadcast* and Changelog modified by
Preeti U. Murthypre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch
idle state.
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com
[Changelog modified by Preeti U. Murthy pre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/processor.h |1 +
arch/powerpc/kernel/exceptions-64s.S | 10
timers to
directly call into __timer_interupt(). One of the use cases of this is the
tick broadcast IPI handling in which the sleeping CPUs need to handle the local
timers that have expired.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/time.c | 73
methods.
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/opal.h|2 ++
arch/powerpc/kernel/exceptions-64s.S |2 +-
arch/powerpc/kernel/idle_power7.S
repeats.
Protect the region of nomination,de-nomination and check for existence of
broadcast
CPU with a lock to ensure synchronization between them.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h |1
arch/powerpc/kernel/time.c
Add deep idle states such as nap and fast sleep to the cpuidle state table
only if they are discovered from the device tree during cpuidle initialization.
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-powerpc-book3s.c | 81
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/Kconfig|2 +
arch/powerpc/include/asm/time.h |1 +
arch/powerpc/kernel/time.c | 58 ++-
3 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/Kconfig b/arch
so as to not
miss wakeups under such scenarios.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h |1 +
arch/powerpc/kernel/time.c |1 +
drivers/cpuidle/cpuidle-powerpc-book3s.c | 22 ++
3 files
Hi Thomas,
On 11/29/2013 08:09 PM, Thomas Gleixner wrote:
On Fri, 29 Nov 2013, Preeti U Murthy wrote:
+static enum hrtimer_restart handle_broadcast(struct hrtimer *hrtimer)
+{
+struct clock_event_device *bc_evt = bc_timer;
+ktime_t interval, next_bc_tick, now;
+
+now
Hi Thomas,
On 11/29/2013 05:28 PM, Thomas Gleixner wrote:
On Fri, 29 Nov 2013, Preeti U Murthy wrote:
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index b44b52c..cafa788 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -129,6 +129,8 @@ config PPC
select
stable power driver.
Regards
Preeti U Murthy
Also, how does this proposal deal with cpufreq's fundamental broken
approach to SMP? Afaict nothing considers the effect of one cpu upon
another -- something which isn't true at all.
In fact, I don't see anything except a random bunch of hooks
Hi,
On 11/13/2013 04:53 PM, Srikar Dronamraju wrote:
* Preeti Murthy preeti.l...@gmail.com [2013-11-13 16:22:37]:
Hi Srikar,
update_group_power() is called only during load balancing during
update_sg_lb_stats().
Load balancing begins at the base domain of the CPU,rq(cpu)-sd
Hi Peter,
On 11/14/2013 02:00 PM, Peter Zijlstra wrote:
On Thu, Nov 14, 2013 at 11:36:27AM +0530, Preeti U Murthy wrote:
However I was thinking that a better fix would be to reorder the way we call
update_group_power() and cpu_attach_domain(). Why do we need to do
update_group_power
On 03/12/2014 01:14 PM, Vincent Guittot wrote:
On 12 March 2014 05:42, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
On 03/11/2014 06:48 PM, Vincent Guittot wrote:
On 11 March 2014 11:08, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
On 03/05/2014 12:48 PM, Vincent Guittot
On 03/12/2014 04:34 PM, Dietmar Eggemann wrote:
On 12/03/14 07:44, Vincent Guittot wrote:
On 12 March 2014 05:42, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
On 03/11/2014 06:48 PM, Vincent Guittot wrote:
On 11 March 2014 11:08, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent
() call is wrong.
So I would suggest the patch at the end of this mail as the alternative
to this one so as to get around the patching conflict.
Thanks
Regards
Preeti U Murthy
Thomas, Ingo, how do we go about solving this sched/core vs timers/core
conflict?
---
# git log 6990566..tip
are there drivers which can return an error code when we call into
the enter function of the idle states? If not, you can probably avoid
checking the error code return value of cpuidle_enter() altogether and
make it simpler. Its not being checked in the current code too.
Thanks
Regards
Preeti U
these three functions to implement the main
idle entry function.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Acked-by: Nicolas Pitre n...@linaro.org
---
ChangeLog:
V3:
* moved broadcast timer outside of cpuidle_enter() as suggested by
Preeti U Murthy.
https
get_mp_bus_to_node(int busnum);
extern void set_mp_bus_to_node(int busnum, int node);
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
___
Linuxppc-dev mailing list
linuxppc-...@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
() },
+#endif
+ { cpu_cpu_mask, SD_INIT_NAME(DIE) },
+ { NULL, },
+};
Regards
Preeti U Murthy
Signed-off-by: Vincent Guittot vincent.guit...@linaro.org
---
arch/powerpc/kernel/smp.c | 35 +++
kernel/sched/core.c |6 --
2 files changed, 27
On 03/11/2014 06:48 PM, Vincent Guittot wrote:
On 11 March 2014 11:08, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
On 03/05/2014 12:48 PM, Vincent Guittot wrote:
Create a dedicated topology table for handling asymetric feature.
The current proposal creates a new level which
the menu governor criteria to be chosen as the
next idle state.
This patch adds the code to indicate that a valid cpu idle state could not be
chosen by the menu governor and reports back to arch so that it can take some
default action.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Hi Srivatsa,
On 01/14/2014 12:30 PM, Srivatsa S. Bhat wrote:
On 01/14/2014 11:35 AM, Preeti U Murthy wrote:
On PowerPC, in a particular test scenario, all the cpu idle states were
disabled.
Inspite of this it was observed that the idle state count of the shallowest
idle state, snooze
On 01/14/2014 01:07 PM, Srivatsa S. Bhat wrote:
On 01/14/2014 12:30 PM, Srivatsa S. Bhat wrote:
On 01/14/2014 11:35 AM, Preeti U Murthy wrote:
On PowerPC, in a particular test scenario, all the cpu idle states were
disabled.
Inspite of this it was observed that the idle state count
Hi,
On 02/13/2014 01:15 PM, Alex Shi wrote:
On 02/11/2014 07:11 PM, Daniel Lezcano wrote:
On 02/10/2014 10:24 AM, Preeti Murthy wrote:
HI Daniel,
Isn't the only scenario where another cpu can put an idle task on
our runqueue,
Well, I am not sure to understand what you meant, but I assume
Hi Daniel,
On 02/11/2014 05:37 PM, Daniel Lezcano wrote:
On 02/10/2014 11:04 AM, Preeti Murthy wrote:
Hi Daniel,
On Fri, Feb 7, 2014 at 4:40 AM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
The idle_balance modifies the idle_stamp field of the rq, making this
information to be shared
Hi Nicolas,
You will have to include the below patch with yours. You
could squash the two I guess, I have added the changelog
just for clarity. And you also might want to change the subject to
cpuidle/powernv. It gives a better picture.
Thanks
Regards
Preeti U Murthy
cpuidle/powernv: Add
On 02/19/2014 12:10 AM, Thomas Gleixner wrote:
On Tue, 18 Feb 2014, Preeti Murthy wrote:
Hi Thomas,
With regard to the patch: tick: Clear broadcast pending bit when
switching to oneshot
isn't BROADCAST_EXIT called atleast after initializing the high
resolution timers while
handling
Hi Daniel,
Thank you very much for the review.
On 02/11/2014 03:46 PM, Daniel Lezcano wrote:
On 02/07/2014 09:06 AM, Preeti U Murthy wrote:
From: Thomas Gleixner t...@linutronix.de
On some architectures, in certain CPU deep idle states the local
timers stop.
An external clock device
/cpuidle-pseries.c
the cleanup caused by the commit c0c4301c54adde05:pseries/cpuidle:
Remove redundant call to ppc64_runlatch_off() in cpu idle routines
now needs to be introduced in part.
Below is the patch which should fix this. This is based on top of tip-tree.
Thanks
Regards
Preeti U Murthy
the governor an opportunity to reflect on the outcome */
- if (cpuidle_curr_governor-reflect)
- cpuidle_curr_governor-reflect(dev, entered_state);
+ cpuidle_reflect(dev, entered_state);
return 0;
}
Thanks
Regards
Preeti U Murthy
--
To unsubscribe from this list: send
the
governor and driver to take better decisions about entry and exit into
idle states. Is this the advantage we hope to begin with?
Thanks
Regards
Preeti U Murthy
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Acked-by: Nicolas Pitre nicolas.pi...@linaro.org
---
--
To unsubscribe from
comments in the
cpuidle_idle_call() function as currently being done in Patch[5/5], to
clarify what each function is meant to do.
So IMO, Patches[1/5] and [2/5] by themselves are sufficient to increase
the proximity between scheduler and cpuidle.
Thanks
Regards
Preeti U Murthy
= sd_init(tl, cpu);
if (!sd)
return child;
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
; /* ~15% */
- sd-flags |= arch_sd_sibling_asym_packing();
} else if (sd-flags SD_SHARE_PKG_RESOURCES) {
sd-imbalance_pct = 117;
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
either in sd_init() or in
default_topology[]. Should not the default_topology[] flag setting
routines set this flag at every level of sched domain along with other
topology flags, unless the arch wants to override it?
Regards
Preeti U Murthy
This flag is part of the topology flags that can be set
On 03/18/2014 05:14 PM, Kirill Tkhai wrote:
18.03.2014, 15:08, Preeti Murthy preeti.l...@gmail.com:
On Sat, Mar 15, 2014 at 3:44 AM, Kirill Tkhai tk...@yandex.ru wrote:
{inc,dec}_rt_tasks used to count entities which are directly queued
on rt_rq. If an entity was not a task (i.e
On 03/19/2014 03:22 PM, Vincent Guittot wrote:
On 19 March 2014 07:21, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
On 03/18/2014 11:26 PM, Vincent Guittot wrote:
A new flag SD_SHARE_POWERDOMAIN is created to reflect whether groups of CPUs
in a sched_domain level can
Hi Vincent,
On 03/19/2014 09:52 PM, Vincent Guittot wrote:
Set the power domain dependency at SMT level of Power8 but keep the flag
clear at CPU level. The goal is to consolidate tasks on the threads of a
core up to a level as explained by Preeti:
On powerpc we would want to clear
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
the scheduler well in
sync with the eco system, then the patches posted so far will achieve
their goals more easily and with very few regressions because they are
well informed decisions.
Regards
Preeti U Murthy
Best regards.
--
Catalin
--
To unsubscribe from this list: send the line
Hi Rafael,
On 06/08/2013 07:32 PM, Rafael J. Wysocki wrote:
On Saturday, June 08, 2013 12:28:04 PM Catalin Marinas wrote:
On Fri, Jun 07, 2013 at 07:08:47PM +0100, Preeti U Murthy wrote:
On 06/07/2013 08:21 PM, Catalin Marinas wrote:
I think you are missing Ingo's point. It's not about
Hi Catalin,
On 06/08/2013 04:58 PM, Catalin Marinas wrote:
On Fri, Jun 07, 2013 at 07:08:47PM +0100, Preeti U Murthy wrote:
On 06/07/2013 08:21 PM, Catalin Marinas wrote:
I think you are missing Ingo's point. It's not about the scheduler
complying with decisions made by various governors
Hi David,
On 06/07/2013 11:06 PM, David Lang wrote:
On Fri, 7 Jun 2013, Preeti U Murthy wrote:
Hi Catalin,
On 06/07/2013 08:21 PM, Catalin Marinas wrote:
SNIP
Take the cpuidle example, it uses the load average of the CPUs,
however this load average is currently controlled
are in a position to judge what would be the next move in this
direction and make that move soon.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
-avg.decay_count = 0)) {
se-avg.last_runnable_update = rq_of(cfs_rq)-clock_task;
Reviewed-by:Preeti U Murthy
Thanks
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
Hi Alex,
You can add my Reviewed-by for the below patch.
Thanks
Regards
Preeti U Murthy
On 04/04/2013 07:30 AM, Alex Shi wrote:
The cpu's utilization is to measure how busy is the cpu.
util = cpu_rq(cpu)-avg.runnable_avg_sum * SCHED_POEWR_SCALE
/ cpu_rq(cpu
Hi Alex,
You can add my Reviewed-by for the below patch.
Thanks
Regards
Preeti U Murthy
On 04/04/2013 07:30 AM, Alex Shi wrote:
In power aware scheduling, we don't want to balance 'prefer_sibling'
groups just because local group has capacity.
If the local group has no tasks at the time
Hi Alex,
You might want to do the below for struct sched_entity also?
AFAIK,struct sched_entity has struct sched_avg under CONFIG_SMP.
Regards
Preeti U Murthy
On 05/06/2013 07:15 AM, Alex Shi wrote:
The following variables were covered under CONFIG_SMP in struct cfs_rq.
but similar runnable
regression.
The below patch is a substitute for patch 7.
---
sched: Modify effective_load() to use runnable load average
From: Preeti U Murthy pre...@linux.vnet.ibm.com
The runqueue weight distribution should update
think?
Thanks
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
scheduler does not see that somebody
else is taking instructions from it and comes back to give different
instructions!
Therefore I think among other things, this is one fundamental issue that
we need to resolve in the steps towards better power savings through
scheduler.
Regards
Preeti U Murthy
.
Thanks,
Morten
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
the following points again.
Thanks
Regards
Preeti U Murthy
On 04/23/2013 01:27 AM, Vincent Guittot wrote:
On Monday, 22 April 2013, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
On 04/05/2013 04:38 PM, Vincent Guittot wrote:
Peter,
After some toughts about your comments,I can
Hi Alex,
I have one point below.
On 04/23/2013 07:53 AM, Alex Shi wrote:
Thanks you, Preeti and Vincent to talk the power aware scheduler for
details! believe this open discussion is helpful to conduct a a more
comprehensive solution. :)
Hi Preeti,
I have had a look at Alex patches but i
Hi Peter,
On 04/26/2013 03:48 PM, Peter Zijlstra wrote:
On Wed, Mar 27, 2013 at 03:51:51PM +0530, Preeti U Murthy wrote:
Hi,
On 03/26/2013 05:56 PM, Peter Zijlstra wrote:
On Fri, 2013-03-22 at 13:25 +0100, Vincent Guittot wrote:
+static bool is_buddy_busy(int cpu)
+{
+ struct rq *rq
scheduler improving power efficiency of
the scheduler or a compromise on the power efficiency but definitely a
decrease in power consumption, since it is the user who has decided to
prioritise lower power consumption over performance* ?
Regards
Preeti U Murthy
--
To unsubscribe from this list
tasks according to cpu_power
not current group_weight.
Yes we could try the patch using group_capacity and observe the results
for power efficiency, before we decide to compromise on power efficiency
for decrease in power.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line
Hi Peter,
On 10/28/2013 07:20 PM, Peter Zijlstra wrote:
On Thu, Oct 24, 2013 at 01:37:38PM +0530, Preeti U Murthy wrote:
kernel/sched/core.c |5 +
kernel/sched/fair.c | 38 --
kernel/sched/sched.h |1 +
3 files changed, 26 insertions
Hi Peter,
On 10/28/2013 09:23 PM, Peter Zijlstra wrote:
On Mon, Oct 21, 2013 at 05:15:02PM +0530, Vaidyanathan Srinivasan wrote:
From: Preeti U Murthy pre...@linux.vnet.ibm.com
The current logic in load balance is such that after picking the
busiest group, the load is attempted to be moved
domain-sd_busy where it is relevant.
3. Introduce sd_asym to represent the sched domain where asymmetric load
balancing has to be done.
---
Preeti U Murthy (1):
sched: Remove un-necessary iteration over sched domains to update
nr_busy_cpus
Vaidyanathan Srinivasan (1):
sched: Fix
at the sd_busy domain level alone and not the base domain level of a
CPU.
This will unify the concept of busy cpus at just one level of sched domain
where it is currently used.
Signed-off-by: Preeti U Murthypre...@linux.vnet.ibm.com
---
kernel/sched/core.c |6 ++
kernel/sched/fair.c
cpumask_first_and() will not yield any set bits if this domain
has no idle cpu.
Hence, nr_busy check against group weight can be removed.
Reported-by: Michael Neuling michael.neul...@au1.ibm.com
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre
The changelog has missed mentioning the introduction of sd_asym per_cpu sched
domain.
Apologies for this. The patch with the changelog including mention of sd_asym is
pasted below.
Regards
Preeti U Murthy
---
sched: Remove un-necessary iteration over sched domains to update
Hi Kamalesh,
On 10/30/2013 02:53 PM, Kamalesh Babulal wrote:
Hi Preeti,
nr_busy_cpus parameter is used by nohz_kick_needed() to find out the number
of busy cpus in a sched domain which has SD_SHARE_PKG_RESOURCES flag set.
Therefore instead of updating nr_busy_cpus at every level of sched
machine, there will be a CPU domain encompassing the
socket and the MC domain will encompass a core. nohz_idle load balancer
will kick in if both the threads in the core have tasks running on them.
This is fair enough because the threads share the resources of the core.
Regards
Preeti U Murthy
the scalability issue. We also don't need to get to
sd-parent to get the nr_busy parameter for the sake of nohz_kick_needed().
What do you think?
Regards
Preeti U Murthy
This nohz stuff really needs to be re-thought and made more scalable --
its a royal pain :/
kernel/sched/core.c | 4
On 10/23/2013 09:30 AM, Preeti U Murthy wrote:
Hi Peter,
On 10/23/2013 03:41 AM, Peter Zijlstra wrote:
On Mon, Oct 21, 2013 at 05:14:42PM +0530, Vaidyanathan Srinivasan wrote:
kernel/sched/fair.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git
. sd_busy therefore is irrelevant for asymmetric load
balancing.
Regards
Preeti U Murthy
START_PATCH---
sched: Fix nohz_kick_needed()
---
kernel/sched/core.c |4
kernel/sched/fair.c | 40 ++--
kernel/sched
201 - 300 of 1331 matches
Mail list logo
