Re: [PATCH 4.19 000/110] 4.19.6-stable review

2018-11-29 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.4 00/86] 4.4.166-stable review

2018-11-29 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 3.18 00/83] 3.18.128-stable review

2018-11-29 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.18.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.9 00/92] 4.9.142-stable review

2018-11-29 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 000/100] 4.14.85-stable review

2018-11-29 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH] selftests/ftrace: Fix invalid SPDX identifiers

2018-11-29 Thread shuah
: Masami Hiramatsu Cc: Shuah Khan (Samsung OSG) Hi Masami, I am pulling this in for 4.21-rc1. thanks, -- Shuah

Re: [PATCH] cpupower : Auto-completion for cpupower tool

2018-12-05 Thread shuah
k out nice. Shuah: Can you pick this up for next cpupower submission round, please. Thanks, Thomas Thanks Thomas. Patch applied to git.kernel.org/pub/scm/linux/kernel/git/shuah/linux cpupower branch to be included in the next pull request to Rafael. thanks, -- Shuah

Re: [PATCH 4.14 000/146] 4.14.86-stable review

2018-12-05 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.9 00/50] 4.9.143-stable review

2018-12-05 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 000/139] 4.19.7-stable review

2018-12-05 Thread shuah
/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH] selftests: gpio: Find libmount with pkg-config if available

2018-12-05 Thread shuah
someone wise, like Shuah Khan or Anders Roxell (Anders has been using the GPIO selftests) that this is the direction we want to go. Yes this makes sense and its already in linux-next. Linus, Great. I pulled this in last week into kselftest next for 4.21-rc1 thinking that this is a good direction

Re: [PATCH 4.19 00/41] 4.19.8-stable review

2018-12-06 Thread shuah
/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.9 000/101] 4.9.144-stable review

2018-12-06 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 00/55] 4.14.87-stable review

2018-12-06 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

[GIT PULL] cpupower update for Linux 4.20-rc4

2018-11-20 Thread shuah
=true from Konstantin Khlebnikov. diff is attached. thanks, -- Shuah The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository

Re: [PATCH 4.18 000/171] 4.18.20-stable review

2018-11-19 Thread shuah
and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 000/124] 4.14.82-stable review

2018-11-19 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 000/205] 4.19.3-stable review

2018-11-19 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.9 00/83] 4.9.138-stable review

2018-11-19 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.4 000/160] 4.4.164-stable review

2018-11-19 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 3.18 00/90] 3.18.126-stable review

2018-11-19 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.18.y and the diffstat can be found below. thanks, greg k-h Compiled and booted ob my test system. No dmesg regressions. thanks, -- Shuah

Re: linux-next: Signed-off-by missing for commit in the kselftest tree

2018-11-27 Thread shuah
On 11/27/18 1:36 PM, Stephen Rothwell wrote: Hi Shuah, Commit 623ea0df7083 ("selftests: firmware: remove use of non-standard diff -Z option") is missing a Signed-off-by from its author. Thanks for catching this. I will fix it. This is the result of change log content

Re: [PATCH 4.9 00/46] 4.9.141-stable review

2018-11-26 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 000/118] 4.19.5-stable review

2018-11-26 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 00/62] 4.14.84-stable review

2018-11-26 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 3.18 00/24] 3.18.127-stable review

2018-11-26 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.18.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.4 00/70] 4.4.165-stable review

2018-11-26 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: linux-next: Fixes tag needs some work in the kselftest tree

2019-09-04 Thread shuah
xpected Thanks. I fixed the one in the commit log. I will fix this one as well. thanks, -- Shuah

Re: [PATCH v14 01/18] kunit: test: add KUnit test runner core

2019-08-23 Thread shuah
. + * + * Example: Can you fix these line continuations. It makes it very hard to read. Sorry for this late comment. These comments lines are longer than 80 and wrap. There are several comment lines in the file that are way too long. thanks, -- Shuah

Re: [PATCH v14 09/18] kunit: test: add support for test abort

2019-08-23 Thread shuah
I recall discussion on this. What's the point in keeping thie BUG() around when it doesn't even reach? It can even be a WARN_ON() in that case right? thanks, -- Shuah

Re: [PATCH v14 01/18] kunit: test: add KUnit test runner core

2019-08-23 Thread shuah
On 8/23/19 10:48 AM, Brendan Higgins wrote: On Fri, Aug 23, 2019 at 8:33 AM shuah wrote: Hi Brendan, On 8/20/19 5:20 PM, Brendan Higgins wrote: Add core facilities for defining unit tests; this provides a common way to define test cases, functions that execute code which is under test

Re: [PATCH v14 09/18] kunit: test: add support for test abort

2019-08-23 Thread shuah
On 8/23/19 10:56 AM, Brendan Higgins wrote: On Fri, Aug 23, 2019 at 8:36 AM shuah wrote: Hi Brendan, On 8/20/19 5:20 PM, Brendan Higgins wrote: Add support for aborting/bailing out of test cases, which is needed for implementing assertions. An assertion is like an expectation, but bails

Re: [PATCH v14 01/18] kunit: test: add KUnit test runner core

2019-08-23 Thread shuah
On 8/23/19 11:27 AM, Brendan Higgins wrote: On Fri, Aug 23, 2019 at 10:05 AM shuah wrote: On 8/23/19 10:48 AM, Brendan Higgins wrote: On Fri, Aug 23, 2019 at 8:33 AM shuah wrote: Hi Brendan, On 8/20/19 5:20 PM, Brendan Higgins wrote: Add core facilities for defining unit tests

Re: [PATCH v14 01/18] kunit: test: add KUnit test runner core

2019-08-23 Thread shuah
On 8/23/19 11:54 AM, Brendan Higgins wrote: On Fri, Aug 23, 2019 at 10:34 AM shuah wrote: On 8/23/19 11:27 AM, Brendan Higgins wrote: On Fri, Aug 23, 2019 at 10:05 AM shuah wrote: On 8/23/19 10:48 AM, Brendan Higgins wrote: On Fri, Aug 23, 2019 at 8:33 AM shuah wrote: Hi Brendan

Re: [PATCH 5.2 000/135] 5.2.10-stable review

2019-08-23 Thread shuah
his posted? or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.2.y and the diffstat can be found below. thanks, -- Shuah

Re: [PATCH 5.2 000/135] 5.2.10-stable review

2019-08-24 Thread shuah
On 8/23/19 8:38 PM, Greg KH wrote: On Fri, Aug 23, 2019 at 12:41:03PM -0600, shuah wrote: On 8/22/19 11:05 AM, Sasha Levin wrote: This is the start of the stable review cycle for the 5.2.10 release. There are 135 patches in this series, all will be posted as a response to this one. If anyone

Re: [PATCH 5.2 000/135] 5.2.10-stable review

2019-08-24 Thread shuah
On 8/24/19 9:33 AM, Greg KH wrote: On Sat, Aug 24, 2019 at 09:21:53AM -0600, shuah wrote: On 8/23/19 8:38 PM, Greg KH wrote: On Fri, Aug 23, 2019 at 12:41:03PM -0600, shuah wrote: On 8/22/19 11:05 AM, Sasha Levin wrote: This is the start of the stable review cycle for the 5.2.10 release

Re: [PATCH 4.19 00/85] 4.19.68-stable review

2019-08-24 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 00/71] 4.14.140-stable review

2019-08-24 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.9 000/103] 4.9.190-stable review

2019-08-24 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.4 00/78] 4.4.190-stable review

2019-08-24 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 5.2 000/135] 5.2.10-stable review

2019-08-24 Thread shuah
On 8/24/19 12:14 PM, Greg KH wrote: On Sat, Aug 24, 2019 at 11:01:19AM -0600, shuah wrote: On 8/24/19 9:33 AM, Greg KH wrote: On Sat, Aug 24, 2019 at 09:21:53AM -0600, shuah wrote: On 8/23/19 8:38 PM, Greg KH wrote: On Fri, Aug 23, 2019 at 12:41:03PM -0600, shuah wrote: On 8/22/19 11:05 AM

Re: [PATCH 5.2 000/135] 5.2.10-stable review

2019-08-24 Thread shuah
On 8/24/19 11:01 AM, shuah wrote: On 8/24/19 9:33 AM, Greg KH wrote: On Sat, Aug 24, 2019 at 09:21:53AM -0600, shuah wrote: On 8/23/19 8:38 PM, Greg KH wrote: On Fri, Aug 23, 2019 at 12:41:03PM -0600, shuah wrote: On 8/22/19 11:05 AM, Sasha Levin wrote: This is the start of the stable

Re: Kernel 5.2.8 - au0828 - Tuner Is Busy

2019-08-26 Thread shuah
On 8/20/19 7:56 AM, shuah wrote: On 8/20/19 12:58 AM, Nathan Royce wrote: While your mention of quirks-table.h certainly had possibilities, I'm afraid adding the "AU0828_DEVICE(0x05e1, 0x0400, "Hauppauge", "Woodbury")," entry for my tuner did not make any differenc

Re: [PATCH 4.14 000/293] 4.14.135-stable review

2019-07-30 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 000/113] 4.19.63-stable review

2019-07-30 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 5.2 000/215] 5.2.5-stable review

2019-07-30 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.2.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 1/3] test_firmware: add support for request_firmware_into_buf

2019-08-19 Thread shuah
request_firmware_into_buf and support has not been added to test such api in test_firmware until now. Signed-off-by: Scott Branden Thanks for the patch! Acked-by: Luis Chamberlain Luis Greg! Pls let me know if you would like me to take this throough my tree. If not, Acked-by: Shuah Khan thanks

Re: [PATCH 2/3] selftest: firmware: Add request_firmware_into_buf tests

2019-08-19 Thread shuah
Luis Greg! Pls let me know if you would like me to take this throough my tree. If not, Acked-by: Shuah Khan

Re: Kernel 5.2.8 - au0828 - Tuner Is Busy

2019-08-19 Thread shuah
les". Hi Nathan, Just catching up with this thread. Let me know what you find. Can you build your own kernel and see what you can find? thanks, -- Shuah

Re: Kernel 5.2.8 - au0828 - Tuner Is Busy

2019-08-19 Thread shuah
On 8/19/19 2:49 PM, shuah wrote: On 8/16/19 7:15 PM, Nathan Royce wrote: On Fri, Aug 16, 2019 at 1:42 PM Greg Kroah-Hartman wrote: If you revert that one commit, does things start working again? thanks, greg k-h Hey Greg, I just got finished building it after running "$ git r

Re: Kernel 5.2.8 - au0828 - Tuner Is Busy

2019-08-20 Thread shuah
could explain the ENODEV you are seeing. thanks, -- Shuah

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-07 Thread shuah
/selftests/kvm/config new file mode 100644 index ..63ed533f73d6 --- /dev/null +++ b/tools/testing/selftests/kvm/config @@ -0,0 +1,3 @@ +CONFIG_KVM=y +CONFIG_KVM_INTEL=y +CONFIG_KVM_AMD=y That being said, it is up to Paolo to decide a call on this patch. thanks, -- Shuah

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-07 Thread shuah
On 8/7/19 10:19 AM, Paolo Bonzini wrote: On 07/08/19 17:52, shuah wrote: On 8/7/19 7:58 AM, Naresh Kamboju wrote: selftests kvm test cases need pre-required kernel configs for the test to get pass. Can you elaborate and add more information on which tests fail without these configs. I am

Re: [PATCH v5 1/2] usbip: Skip DMA mapping and unmapping for urb at vhci

2019-08-08 Thread shuah
ct hc_driver vhci_hc_driver = { .get_frame_number = vhci_get_frame_number, + .map_urb_for_dma = vhci_map_urb_for_dma, + .unmap_urb_for_dma = vhci_unmap_urb_for_dma, + .hub_status_data = vhci_hub_status, .hub_control= vhci_hub_control, .bus_suspend= vhci_bus_suspend,

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-08 Thread shuah
dex ..63ed533f73d6 --- /dev/null +++ b/tools/testing/selftests/kvm/config @@ -0,0 +1,3 @@ +CONFIG_KVM=y +CONFIG_KVM_INTEL=y +CONFIG_KVM_AMD=y Acked-by: Shuah Khan thanks, -- Shuah

Re: [RFC PATCH] hugetlbfs: Add hugetlb_cgroup reservation limits

2019-08-08 Thread shuah
it lot easier to review. thanks, -- Shuah

Re: [PATCH 5.2 00/56] 5.2.8-stable review

2019-08-08 Thread shuah
/linux/kernel/git/stable/linux-stable-rc.git linux-5.2.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 00/45] 4.19.66-stable review

2019-08-08 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 00/33] 4.14.138-stable review

2019-08-08 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH for 5.2] rseq/selftests: Fix Thumb mode build failure on arm32

2019-07-08 Thread shuah
e 5.2 branch ? I will apply it to selftests and send it for 5.3-rc1 and mark it for stable. thanks, -- Shuah

Re: [PATCH 5.1 00/96] 5.1.17-stable review

2019-07-08 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.1.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 00/90] 4.19.58-stable review

2019-07-08 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 00/56] 4.14.133-stable review

2019-07-08 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.9 000/102] 4.9.185-stable review

2019-07-08 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.4 00/73] 4.4.185-stable review

2019-07-08 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCHv6 30/36] selftest/timens: Add Time Namespace test for supported clocks

2019-08-15 Thread shuah
TARGETS += sync TARGETS += sysctl +TARGETS += timens How long does this test run for? Does this test need to be run as root? If yes, please add a root check and skip the test. What does the test output looks like for skip and pass/fail cases? thanks, -- Shuah

Re: [PATCHv6 35/36] selftests/timens: Add a simple perf test for clock_gettime()

2019-08-15 Thread shuah
uct timespec tp, start; + long i = 0; + const int timeout = 3; + +#ifndef TEST_SYSCALL + vdso_clock_gettime(clockid, ); +#else + syscall(__NR_clock_gettime, clockid, ); +#endif Hmm. This doesn't look right. Does this test need to be compiled with TEST_SYSCALL. Please find a way to do this without ifdef. thanks, -- Shuah

Re: [PATCH 5.2 000/144] 5.2.9-stable review

2019-08-15 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.2.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 00/91] 4.19.67-stable review

2019-08-15 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 00/69] 4.14.139-stable review

2019-08-15 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 5.1 000/405] 5.1.6-stable review

2019-05-30 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.1.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 5.0 000/346] 5.0.20-stable review

2019-05-30 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.0.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 000/276] 4.19.47-stable review

2019-05-30 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 5.0 000/346] 5.0.20-stable review

2019-05-30 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.0.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 000/193] 4.14.123-stable review

2019-05-30 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Complied and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.9 000/128] 4.9.180-stable review

2019-05-30 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 5.1 000/155] 5.1.10-stable review

2019-06-13 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.1.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 000/118] 4.19.51-stable review

2019-06-13 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 00/81] 4.14.126-stable review

2019-06-13 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH v4 1/9] hugetlb_cgroup: Add hugetlb_cgroup reservation counter

2019-09-16 Thread shuah
printf(cft->name, MAX_CFTYPE_NAME, "%s.reservation_failcnt", buf); + cft->private = MEMFILE_PRIVATE(idx, HUGETLB_RES_RESERVATION_FAILCNT); cft->write = hugetlb_cgroup_reset; cft->read_u64 = hugetlb_cgroup_read_u64; /* NULL terminate the last cft */ - cft = >cgroup_files[4]; + cft = >cgroup_files[HUGETLB_RES_NULL]; memset(cft, 0, sizeof(*cft)); WARN_ON(cgroup_add_legacy_cftypes(_cgrp_subsys, -- 2.23.0.162.g0b9fbb3734-goog thanks, -- Shuah

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-16 Thread shuah
eab71e210f ("kunit: fix failure to build without printk") of https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next v2: Squashed [1] and [2], and update commit description as discussed in [3]. [1] https://patchwork.kernel.org/patch/1113

Re: [PATCH v4 2/9] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations

2019-09-16 Thread shuah
), + ret = page_counter_set_max(hugetlb_cgroup_get_counter(h_cg, idx, + reserved), nr_pages); mutex_unlock(_limit_mutex); break; -- 2.23.0.162.g0b9fbb3734-goog thanks, -- Shuah

Re: [PATCH v4 8/9] hugetlb_cgroup: Add hugetlb_cgroup reservation tests

2019-09-16 Thread shuah
quot;); + } + break; + case MMAP_MAP_HUGETLB: + printf("Allocating using MAP_HUGETLB.\n"); + ptr = mmap(NULL, size, + PROT_READ | PROT_WRITE, + (private ? (MAP_PRIVATE | MAP_ANONYMOUS) : MAP_SHARED) | + MAP_HUGETLB | (populate ? + MAP_POPULATE : 0), + -1, 0); + + if (ptr == MAP_FAILED) + err(1, "mmap"); + + printf("Returned address is %p\n", ptr); + break; + case SHM: + printf("Allocating using SHM.\n"); + shmid = shmget(key, size, SHM_HUGETLB | IPC_CREAT | SHM_R | + SHM_W); + if (shmid < 0) { + shmid = shmget(++key, size, SHM_HUGETLB | IPC_CREAT | + SHM_R | SHM_W); + if (shmid < 0) + err(1, "shmget"); + + } + printf("shmid: 0x%x, shmget key:%d\n", shmid, key); + + shmaddr = shmat(shmid, NULL, 0); + if (shmaddr == (char *)-1) { + perror("Shared memory attach failure"); + shmctl(shmid, IPC_RMID, NULL); + exit(2); + } + printf("shmaddr: %p\n", shmaddr); + + break; + default: + errno = EINVAL; + err(1, "Invalid method."); + } + + if (write) { + printf("Writing to memory.\n"); + if (method != SHM) { + memset(ptr, 1, size); + } else { + printf("Starting the writes:\n"); + for (i = 0; i < size; i++) { + shmaddr[i] = (char)(i); + if (!(i % (1024 * 1024))) + printf("."); + } + printf("\n"); + + printf("Starting the Check..."); + for (i = 0; i < size; i++) + if (shmaddr[i] != (char)i) { + printf("\nIndex %lu mismatched\n", i); + exit(3); + } + printf("Done.\n"); + + + } + } + + if (want_sleep) { + /* Signal to caller that we're done. */ + printf("DONE\n"); + + /* Hold memory until external kill signal is delivered. */ + while (1) + sleep(100); Please don't add sleeps. This will hold up the kselftest run. + } + + close(fd); Is this close() necessary in all cases? Looks like MMAP_MAP_HUGETLB is the only case that opens it. I am not sure if the error legs are correct. + + return 0; +} -- 2.23.0.162.g0b9fbb3734-goog thanks, -- Shuah

Re: [PATCH v4 9/9] hugetlb_cgroup: Add hugetlb_cgroup reservation docs

2019-09-16 Thread shuah
l allowed to in case it sees +some use for it. What would be the scenarios where setting both could be useful? Please explain. -- 2.23.0.162.g0b9fbb3734-goog thanks, -- Shuah

Re: [PATCH] selftests/net: replace AF_MAX with INT_MAX in socket.c

2019-09-17 Thread shuah
to suit older kernel needs. This definitely isn't a change that is good to make. We have to come with a better way to solve this. Could you please send me the errors you are seeing so I can help you find a better solution. thanks, -- Shuah

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread shuah
On 9/17/19 8:54 AM, Eugeniu Rosca wrote: Shuah, On Mon, Sep 16, 2019 at 07:19:35PM -0600, shuah wrote: On 9/16/19 12:49 PM, George G. Davis wrote: As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92 ("selftests: watchdog: Add optional file argument") is that arbit

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread shuah
On 9/17/19 10:54 AM, Eugeniu Rosca wrote: Shuah, On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: [..] I want two patches and the first one with Fixes tag. These two patches need to be separate. The first one is a fix and the second is an enhancement. Please send two patches

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread shuah
On 9/17/19 11:50 AM, Eugeniu Rosca wrote: On Tue, Sep 17, 2019 at 11:44:45AM -0600, shuah wrote: On 9/17/19 10:54 AM, Eugeniu Rosca wrote: Shuah, On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: [..] I want two patches and the first one with Fixes tag. These two patches need

Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

2019-09-18 Thread shuah
On 9/18/19 5:33 AM, Eugeniu Rosca wrote: Hi Shuah, On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote: From: "George G. Davis" The newly added optional file argument does not validate if the file is indeed a watchdog, e.g.: ./watchdog-test -f /dev/zero Watchdog Ti

Re: [PATCH 5.2 00/85] 5.2.16-stable review

2019-09-18 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.2.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 00/50] 4.19.74-stable review

2019-09-18 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 00/45] 4.14.145-stable review

2019-09-18 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH] cpupower : Handle set and info subcommands for powerpc

2019-09-11 Thread shuah
quot;"); textdomain(PACKAGE); thanks, -- Shuah

Re: [PATCH 5.6 000/194] 5.6.14-rc1 review

2020-05-19 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.6.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. I see rc2, I will test that and let you know the results. thanks, -- Shuah

Re: [PATCH 5.4 000/147] 5.4.42-rc1 review

2020-05-19 Thread shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.19 00/80] 4.19.124-rc1 review

2020-05-19 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.14 000/114] 4.14.181-rc1 review

2020-05-19 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 4.9 00/90] 4.9.224-rc1 review

2020-05-19 Thread shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah

Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()

2020-05-19 Thread shuah
a blank line after declarations #150: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:42: + long ret = get_cpu(, , 0); + if (ret == 0) { Please send v2 for this one. thanks, -- Shuah

  1   2   3   4   5   6   7   8   9   10   >