[PATCH 3/4] clk: qcom: Add support to LPASS AUDIO_CC Glitch Free Mux clocks

GFM Muxes in AUDIO_CC control clocks to LPASS WSA and RX Codec Macros. This patch adds support to these muxes. Signed-off-by: Srinivas Kandagatla --- drivers/clk/qcom/Kconfig| 7 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/lpass-gfm-sm8250.c | 235

[PATCH 4/4] clk: qcom: Add support to LPASS AON_CC Glitch Free Mux clocks

LPASS Always ON Clock controller has one GFM mux to control VA and TX clocks to codec macro on LPASS. This patch adds support to this mux. Signed-off-by: Srinivas Kandagatla --- drivers/clk/qcom/lpass-gfm-sm8250.c | 61 + 1 file changed, 61 insertions(+) diff --git

[PATCH 2/4] dt-bindings: clock: Add support for LPASS Always ON Controller

Always ON Clock controller is a block inside LPASS which controls 1 Glitch free muxes to LPASS codec Macros. Signed-off-by: Srinivas Kandagatla --- .../bindings/clock/qcom,aoncc-sm8250.yaml | 58 +++ .../clock/qcom,sm8250-lpass-aoncc.h | 11 2 files changed

[PATCH 0/4] clk: qcom : add sm8250 LPASS GFM drivers

Muxes, however it should be easy to add more clock support when required. Srinivas Kandagatla (4): dt-bindings: clock: Add support for LPASS Audio Clock Controller dt-bindings: clock: Add support for LPASS Always ON Controller clk: qcom: Add support to LPASS AUDIO_CC Glitch Free Mux clocks clk

[PATCH v4 0/3] soundwire: qcom: fix IP version v1.5.1 support

I found a regression due to move to REG_FIELD, which patch 1 fixes it! thanks, srini Change since v3: - use u32p_replace_bits instead of u32_replace_bits Srinivas Kandagatla (3): soundwire: qcom: clear BIT FIELDs before value set. soundwire: qcom: add support to block packing mode

[PATCH v4 3/3] soundwire: qcom: get max rows and cols info from compatible

currently the max rows and cols values are hardcoded. In reality these values depend on the IP version. So get these based on device tree compatible strings. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 46 +++- 1 file changed, 31

[PATCH v4 1/3] soundwire: qcom: clear BIT FIELDs before value set.

p_replace_bits() to clear and set the values. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index d7aabdaffee3..c1bb35884182 100644 --- a/drivers/soundwire/qcom.c

[PATCH v4 2/3] soundwire: qcom: add support to block packing mode

This patch adds support to block pack mode, which is required on Qcom soundwire controllers v1.5.x on few ports! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/qcom.c b

[PATCH v3 2/3] soundwire: qcom: add support to block packing mode

This patch adds support to block pack mode, which is required on Qcom soundwire controllers v1.5.x on few ports! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/qcom.c b

[PATCH v3 3/3] soundwire: qcom: get max rows and cols info from compatible

currently the max rows and cols values are hardcoded. In reality these values depend on the IP version. So get these based on device tree compatible strings. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 46 +++- 1 file changed, 31

[PATCH] bitfield.h: annotate type_replace_bits functions with __must_check

usage of apis like u32_replace_bits() without actually catching the return value could hide problems without any warning! Found this with recent usage of this api in SoundWire! Having __must_check annotation would really catch this issues in future! Signed-off-by: Srinivas Kandagatla

Re: [PATCH v2 3/3] soundwire: qcom: get max rows and cols info from compatible

On 16/09/2020 13:49, Vinod Koul wrote: On 16-09-20, 10:21, Srinivas Kandagatla wrote: currently the max rows and cols values are hardcoded. In reality these values depend on the IP version. So get these based on device tree compatible strings. Signed-off-by: Srinivas Kandagatla

[PATCH v3 1/3] soundwire: qcom: clear BIT FIELDs before value set.

2_replace_bits() to clear and set the values. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index d7aabdaffee3..0036d3248fb4 100644 --- a/drivers/soundwire/qcom.c

[PATCH v3 0/3] soundwire: qcom: fix IP version v1.5.1 support

I found a regression due to move to REG_FIELD, which patch 1 fixes it! thanks, srini Changes since v2: - updated to use u32_replace_bits(). - wrapped up in single lines as suggested by vkoul. Srinivas Kandagatla (3): soundwire: qcom: clear BIT FIELDs before value set. soundwire: qcom: add

Re: [PATCH] bitfield.h: annotate type_replace_bits functions with __must_check

On 16/09/2020 16:20, Greg KH wrote: On Wed, Sep 16, 2020 at 04:03:33PM +0100, Srinivas Kandagatla wrote: usage of apis like u32_replace_bits() without actually catching the return value could hide problems without any warning! Found this with recent usage of this api in SoundWire! Having

[PATCH v2 2/3] soundwire: qcom: add support to block packing mode

This patch adds support to block pack mode, which is required on Qcom soundwire controllers v1.5.x on few ports! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/qcom.c b

[PATCH v2 0/3] soundwire: qcom: fix IP version v1.5.1 support

I found a regression due to move to REG_FIELD, which patch 1 fixes it! thanks, srini Changes since v1: - rebased on top of REG_FILED patch or soundwire-next branch - udated qcom_swrm_data to use u32 instead of int as suggested by VKoul Srinivas Kandagatla (3): soundwire: qcom: clear BIT

[PATCH v2 3/3] soundwire: qcom: get max rows and cols info from compatible

currently the max rows and cols values are hardcoded. In reality these values depend on the IP version. So get these based on device tree compatible strings. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 50 1 file changed, 35

[PATCH v2 1/3] soundwire: qcom: clear BIT FIELDs before value set.

register mask before setting it up! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index d7aabdaffee3..5d26361ab4f6 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/so

Re: [PATCH] nvmem: core: fix missing of_node_put() in of_nvmem_device_get()

On 15/09/2020 22:48, Vadym Kochan wrote: of_parse_phandle() returns device_node with incremented ref count which needs to be decremented by of_node_put() when device_node is not used. Fixes: e2a5402ec7c6 ("nvmem: Add nvmem_device based consumer apis.") Signed-off-by: Vadym Kochan ---

Re: [PATCH] nvmem: switch to simpler IDA interface

On 08/09/2020 14:27, Bartosz Golaszewski wrote: From: Bartosz Golaszewski We don't need to specify any ranges when allocating IDs so we can switch to ida_alloc() and ida_free() instead of the ida_simple_ counterparts. ida_simple_get(ida, 0, 0, gfp) is equivalent to ida_alloc_range(ida, 0,

Re: [PATCH v9 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

K48000 Looks like ^ is Not used! Overall the driver looks much cleaner now! Also to make progress on this patch, may be you add define for HDMI with a comment! Once unused remove, pl feel free to add ! Reviewed-by: Srinivas Kandagatla --srini +#define DEFAULT_MCLK_RATE

[PATCH 1/2] ASoC: q6afe: dt-bindings: add q6afe clock bindings

q6afe exposes various lpass clocks controls via q6dsp q6afe commands. This patch adds bindings required for this clock controller. Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/sound/qcom,q6afe.txt | 23 ++ include/dt-bindings/sound/qcom,q6afe.h| 74

[PATCH 2/2] ASoC: q6afe-clocks: add q6afe clock controller

. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 4 + sound/soc/qcom/qdsp6/Makefile | 1 + sound/soc/qcom/qdsp6/q6afe-clocks.c | 270 3 files changed, 275 insertions(+) create mode 100644 sound/soc/qcom/qdsp6/q6afe-clocks.c

[PATCH 0/2] ASoC: q6afe: add clocks support

q6afe already exposes clocks using apis, but not as proper clock controller driver. This patch puts those clocks in to a proper clock controller so that other drivers that depend on those clocks can be properly expressed. Srinivas Kandagatla (2): ASoC: q6afe: dt-bindings: add q6afe clock

[PATCH 4/8] ASoC: q6dsp: q6afe: add global q6afe waitqueue

In some cases like clocks q6afe would have to process commands without an associated q6afe port, in such cases waitqueue is required at global level to wait for the command to finish. This patch also adds the command result to go with this waitqueue. Signed-off-by: Srinivas Kandagatla --- sound

[PATCH 3/8] ASoC: q6dsp: q6afe: prepare afe_apr_send_pkt to take response opcode

Update afe_apr_send_pkt() to take response opcode that it should wait for. This is helpful in cases where we expect response other than the actual command opcode. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions

[PATCH 5/8] ASoC: q6dsp: q6afe: add lpass hw voting support

Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe.c | 99 sound/soc/qcom/qdsp6/q6afe.h | 8 +++ 2 files changed, 107 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index 2a8e3c3acb10..51c94dd9998d

[PATCH 7/8] ASoC: q6dsp: q6afe: add codec lpass clocks

LPASS now has integrated codec control whose clocks are controlled by Q6DSP. This patch adds support to those clocks. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe.c | 24 sound/soc/qcom/qdsp6/q6afe.h | 11 +++ 2 files changed, 35 insertions

[PATCH 6/8] ASoC: q6dsp: q6afe: update q6afe_set_param to support global clocks

-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index 51c94dd9998d..9ed5537ee58e 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound

[PATCH 2/8] ASoC: q6dsp: q6routing: add support to Codec DMA ports

Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6routing.c | 121 ++- 1 file changed, 120 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index 25d23e0266c7..b12539fae6ed 100644 --- a/sound

[PATCH 8/8] ASoC: q6dsp: q6afe-dai: add support to Codec DMA ports

Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 229 +++ 1 file changed, 229 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c index 0168af849272..d58b86a98114 100644 --- a/sound/soc/qcom/qdsp6

[PATCH 1/8] ASoC: q6dsp: q6afe: add support to Codec DMA ports

New LPASS supports various codec macros, DSP firmware already has support to those ports. Add corresponding configuration support to those ports in adsp drivers. Signed-off-by: Srinivas Kandagatla --- include/dt-bindings/sound/qcom,q6afe.h | 22 + sound/soc/qcom/qdsp6/q6afe.c

[PATCH 0/8] ASoC: q6dsp: Add support to Codec Ports.

with Soundwire and WSA8815 Codec. Thanks, srini Srinivas Kandagatla (8): ASoC: q6dsp: q6afe: add support to Codec DMA ports ASoC: q6dsp: q6routing: add support to Codec DMA ports ASoC: q6dsp: q6afe: prepare afe_apr_send_pkt to take response opcode ASoC: q6dsp: q6afe: add global q6afe waitqueue

Re: [PATCH 2/2] soundwire: qcom: get max rows and cols info from compatible

On 10/09/2020 07:39, Vinod Koul wrote: On 09-09-20, 17:09, Srinivas Kandagatla wrote: currently the max rows and cols values are hardcoded. In reality these values depend on the IP version. So get these based on device tree compatible strings. Signed-off-by: Srinivas Kandagatla

[PATCH 0/2] soundwire: qcom: fix IP version v1.5.1 support

/5/220 ("[PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master") patchset I was able to test 2 WSA speakers! This patchset depends on this above patchset! thanks, srini Srinivas Kandagatla (2): soundwire: qcom: add support to block packing mode soundwire: qcom: ge

[PATCH 2/2] soundwire: qcom: get max rows and cols info from compatible

currently the max rows and cols values are hardcoded. In reality these values depend on the IP version. So get these based on device tree compatible strings. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 46 +++- 1 file changed, 31

[PATCH 1/2] soundwire: qcom: add support to block packing mode

This patch adds support to block pack mode, which is required on Qcom soundwire controllers v1.5.x on few ports! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/qcom.c b

Re: [PATCH] soundwire: bus: add enumerated slave to device list

On 09/09/2020 14:37, Pierre-Louis Bossart wrote: On 9/9/20 3:27 AM, Srinivas Kandagatla wrote: Currently slave devices are only added either from device tree or acpi entries. However lets say, there is wrong or no entry of a slave device in DT that is enumerated, then there is no way

Re: [PATCH] soundwire: bus: add enumerated slave to device list

On 09/09/2020 15:39, Pierre-Louis Bossart wrote: Currently slave devices are only added either from device tree or acpi entries. However lets say, there is wrong or no entry of a slave device in DT that is enumerated, then there is no way for user to know all the enumerated devices on the

[PATCH] soundwire: bus: add enumerated slave to device list

if there is no matching dt or acpi entry, so that we can see this in sysfs entry. In my case I had a wrong address entry in DT, However I had no way to know what devices are actually enumerated on the bus! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/bus.c | 1 + drivers/soundwire/bus.h

Re: [PATCH] misc: fastrpc: add ioctl for attaching to sensors pd

On 07/09/2020 15:02, Jonathan Marek wrote: Srini do you have any suggestions for how to name these values? These are domain id corresponding to each core. you can use SDSP_DOMAIN_ID in here! these are already defined in the file as: #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1)

Re: [PATCH] misc: fastrpc: add ioctl for attaching to sensors pd

On 01/09/2020 01:32, Jonathan Marek wrote: -#define FASTRPC_IOCTL_MMAP _IOWR('R', 6, struct fastrpc_req_mmap) -#define FASTRPC_IOCTL_MUNMAP_IOWR('R', 7, struct fastrpc_req_munmap) +#define FASTRPC_IOCTL_MMAP _IOWR('R', 6, struct fastrpc_req_mmap) +#define

Re: [PATCH] misc: fastrpc: add ioctl for attaching to sensors pd

On 07/09/2020 14:47, Jonathan Marek wrote: On 9/7/20 8:36 AM, Srinivas Kandagatla wrote: On 01/09/2020 01:32, Jonathan Marek wrote: -#define FASTRPC_IOCTL_MMAP  _IOWR('R', 6, struct fastrpc_req_mmap) -#define FASTRPC_IOCTL_MUNMAP    _IOWR('R', 7, struct

Re: [PATCH] misc: fastrpc: add ioctl for attaching to sensors pd

On 07/09/2020 14:51, Jonathan Marek wrote: @@ -1477,7 +1477,10 @@ static long fastrpc_device_ioctl(struct file *file, unsigned int cmd,   err = fastrpc_invoke(fl, argp);   break;   case FASTRPC_IOCTL_INIT_ATTACH: -    err = fastrpc_init_attach(fl); +    err =

Re: [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master

: Srinivas Kandagatla Tested-by: Srinivas Kandagatla Thanks, srini .../bindings/soundwire/qcom,sdw.txt | 1 + drivers/soundwire/Kconfig | 2 +- drivers/soundwire/qcom.c | 38 +-- 3 files changed, 36 insertions(+), 5 deletions(-)

Re: [PATCH] nvmem: core: Use kobj_to_dev() instead of container_of()

On 20/08/2020 10:28, Tian Tao wrote: Use kobj_to_dev() instead of container_of() Signed-off-by: Tian Tao Applied thanks, --srini --- drivers/nvmem/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index

Re: [PATCH v3 3/5] ASoC: qcom: Add support for lpass hdmi driver

On 04/09/2020 12:21, Srinivasa Rao Mandadapu wrote: Before going into detail review, I see real issue in the overall approach here to add new interface to exiting lpass!! Intention of struct lpass_variant is to address differences between SoCs or different lpass versions. But you should

Re: [PATCH v3] nvmem: mtk-efuse: Remove EFUSE register write support

On 26/08/2020 09:39, Chih-En Hsu wrote: This patch is to remove function "mtk_reg_write" since Mediatek EFUSE hardware only supports read functionality for NVMEM consumers. Fixes: ba360fd040e3 ("nvmem: mtk-efuse: remove nvmem regmap dependency") Signed-off-by: Chih-En Hsu ---

Re: [PATCH v3 2/3] nvmem: add ONIE NVMEM cells support

On 31/08/2020 02:55, Vadym Kochan wrote: ONIE is a small operating system, pre-installed on bare metal network switches, that provides an environment for automated provisioning. This system requires that NVMEM (EEPROM) device holds various system information (mac address, platform name, etc)

Re: [PATCH v3 1/3] nvmem: core: allow to register cells during nvmem registration

Hi Vadym, Thanks for the patch, On 31/08/2020 02:55, Vadym Kochan wrote: Add NVMEM_PRE_ADD notification step which is called before any cells binding - from lookup table or config, this allows to register cells in some specific layout (tlv) which should be parsed first and then registered. So

Re: [PATCH v3 3/5] ASoC: qcom: Add support for lpass hdmi driver

On 31/08/2020 07:39, Srinivasa Rao Mandadapu wrote: From: V Sujith Kumar Reddy Upadate lpass cpu and platform driver to support audio over dp. Also add lpass-hdmi.c and lpass-hdmi.h. Signed-off-by: Srinivasa Rao Signed-off-by: V Sujith Kumar Reddy --- sound/soc/qcom/Kconfig |

Re: [PATCH v3 2/5] ASoC: dt-bindings: Add dt binding for lpass hdmi

On 31/08/2020 07:39, Srinivasa Rao Mandadapu wrote: From: V Sujith Kumar Reddy Adds bindings for lpass hdmi interface which can support audio path over dp. Signed-off-by: Srinivasa Rao Signed-off-by: V Sujith Kumar Reddy --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 51

[PATCH v2 2/2] ASoC: q6routing: add dummy register read/write function

qdsp6: q6routing: Add q6routing driver") Signed-off-by: Srinivas Kandagatla --- Changes since v1: - added reg write callback sound/soc/qcom/qdsp6/q6routing.c | 16 1 file changed, 16 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q

[PATCH v2 1/2] ASoC: q6afe-dai: mark all widgets registers as SND_SOC_NOPM

ore, every register read/write failures are reported very verbosely. Prior to this fails to reads are totally ignored, so we never saw any error messages. Reported-by: John Stultz Fixes: 24c4cbcfac09 ("ASoC: qdsp6: q6afe: Add q6afe dai driver") Signed-off-by: Srinivas Kandagatla

Re: [PATCH 1/2] ASoC: q6afe-dai: add dummy register read function

On 11/08/2020 12:04, Stephan Gerhold wrote: On Tue, Aug 11, 2020 at 11:25:51AM +0100, Srinivas Kandagatla wrote: Most of the DAPM widgets for DSP ASoC components reuse reg field of the widgets for its internal calculations, however these are not real registers. So read/writes

[PATCH] ASoC: qcom: add a dedicated menuconfig

Currently list of Qualcomm drivers is growing, so put them in to a proper menu so that it does not mix up with other ASOC configs in menuconfig. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc

[PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset

For some reason interrupt set and clear register offsets are not set correctly. This patch corrects them! Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec") Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/msm8916-wcd-analog.c | 4 ++-- 1 file changed, 2 insert

[PATCH 1/2] ASoC: q6afe-dai: add dummy register read function

q6afe: Add q6afe dai driver") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c index 2a5302f1db98..492bdbaf13c4 100644 --- a

[PATCH 2/2] ASoC: q6routing: add dummy register read function

qdsp6: q6routing: Add q6routing driver") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6routing.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index eaa95b5a7b66..fb7c4b266d19 100644 --- a/sound/soc/

Re: [GIT PULL] sound updates for 5.9

Hi John, Thanks for reporting this. On 08/08/2020 01:23, John Stultz wrote: q6routing remoteproc-adsp:glink-edge:apr:apr-service@8:routing: ASoC: error at soc_component_read_no_lock on remoteproc-adsp:glink-edge:apr:: -5 This is an -EIO error which is reported when the ASoC component driver

Re: [PATCH] nvmem: core: add sanity check in nvmem_device_read()

On 04/08/2020 10:58, Sakari Ailus wrote: Hi Bingbu, Thank you for the patch. On Tue, Aug 04, 2020 at 05:13:56PM +0800, Bingbu Cao wrote: nvmem_device_read() could be called directly once nvmem device registered, the sanity check should be done before call nvmem_reg_read() as cell and sysfs

[PATCH v3 05/10] ASoC: q6asm: add support to remove intial and trailing silence

This patch adds support to ASM_DATA_CMD_REMOVE_INITIAL_SILENCE and ASM_DATA_CMD_REMOVE_TRAILING_SILENCE q6asm command to support compressed metadata for gapless playback. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm.c | 53 sound/soc

[PATCH v3 04/10] ASoC: q6asm: add length to write command token

Add length to write command packet token so that we can track exactly how many bytes are consumed by DSP in the command reply. This is useful in some use-cases where the end of the file/stream is not aligned with period size. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm

[PATCH v3 02/10] ASoC: q6asm: make commands specific to streams

multiple streams to open on a single session, This is useful for gapless playback cases. Now the dai driver can specify which stream id for each command. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 79 +-- sound/soc/qcom/qdsp6/q6asm.c | 92

[PATCH v3 10/10] ASoC: q6asm-dai: add support to copy callback

During gapless playback, its possible for previous track to end at unaligned boundary, starting next track on the same boundary can lead to unaligned address exception in dsp. So implement copy callback for finer control on the buffer offsets. Signed-off-by: Srinivas Kandagatla --- sound/soc

[PATCH v3 03/10] ASoC: q6asm: use flags directly from q6asm-dai

use flags set by q6asm-dais directly! This will be useful gapless case where write needs a special flag to indicate that last buffer. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 8 sound/soc/qcom/qdsp6/q6asm.c | 5 + sound/soc/qcom/qdsp6/q6asm.h

[PATCH v3 07/10] ASoC: q6asm-dai: add next track metadata support

This patch adds support to metadata required to do a gapless playback. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c

[PATCH v3 01/10] ASoC: q6asm: rename misleading session id variable

Each q6asm session can have multiple streams, mixing usage of these names in variable are bit misleading to reader, so rename them accordingly. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v3 06/10] ASoC: q6asm: add support to gapless flag in q6asm open

This patch adds support to gapless flag to q6asm_open_write(). Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 4 ++-- sound/soc/qcom/qdsp6/q6asm.c | 4 +++- sound/soc/qcom/qdsp6/q6asm.h | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH v3 09/10] ASoC: q6asm-dai: add gapless support

Add support to gapless playback by implementing metadata, next_track, drain and partial drain support. Gapless on Q6ASM is implemented by opening 2 streams in a single q6asm stream and toggling them on next track. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 103

[PATCH v3 08/10] ASoC: q6asm-dai: prepare set params to accept profile change

rearrange code so that it will be easy to change the codec profile at runtime. This means moving exiting set_params to an internal wrapper which can be called when codec profile changes. This is also preparing the code for easy to use in gapless cases. Signed-off-by: Srinivas Kandagatla

[PATCH v3 00/10] ASoC: qdsp6: add gapless compressed audio support

of one patch. - add comments to clarify valid stream_ids Srinivas Kandagatla (10): ASoC: q6asm: rename misleading session id variable ASoC: q6asm: make commands specific to streams ASoC: q6asm: use flags directly from q6asm-dai ASoC: q6asm: add length to write command token ASoC: q6asm

Re: [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant

ndings: sound: lpass-cpu: Move to yaml format Tested this on Dragon Board 410c! Tested-by: Srinivas Kandagatla --srini .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 79 .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 185 ++ include/dt-bindings/sound/

Re: [PATCH v4 06/12] ASoC: qcom: lpass-cpu: fix concurrency issue

: 80beab8e1d86 ("ASoC: qcom: Add LPASS CPU DAI driver") Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-cpu.c | 16 1 file changed, 16 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 6b86f16..5d84

Re: [PATCH v4 04/12] ASoC: qcom: lpass-platform: fix memory leak

On 22/07/2020 11:31, Rohit kumar wrote: lpass_pcm_data is never freed. Free it in close ops to avoid memory leak. Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage") Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-

Re: [PATCH v4 10/12] ASoC: qcom: lpass-cpu: Use platform_get_resource

On 22/07/2020 11:31, Rohit kumar wrote: platform_get_resource_byname() is used when there is list of reg entries. As lpass-cpu node has only one reg entry, use platform_get_resource() instead. Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-cpu.c

[PATCH 08/14] nvmem: qfprom: use NVMEM_DEVID_AUTO for multiple instances

-by: Srinivas Kandagatla Tested-by: Shawn Guo --- drivers/nvmem/qfprom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index 8a91717600be..8b425f8d847d 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -31,6 +31,7 @@ static struct

[PATCH 06/14] nvmem: core: Add nvmem_cell_read_u8()

Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 15 +++ include/linux/nvmem-consumer.h | 1 + 2 files changed, 16 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 95bed31391cd..d6bacc878500 100644 --- a/drivers/nvmem/core.c +++ b/drivers

[PATCH 09/14] dt-bindings: nvmem: qfprom: Convert to yaml

From: Ravi Kumar Bokka This switches the bindings over from txt to yaml. Signed-off-by: Ravi Kumar Bokka Signed-off-by: Douglas Anderson Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../bindings/nvmem/qcom,qfprom.yaml | 50 +++ .../devicetree

[PATCH 11/14] nvmem: qfprom: Add fuse blowing support

From: Ravi Kumar Bokka This patch adds support for blowing fuses to the qfprom driver if the required properties are defined in the device tree. [Srini: Fixed merge conflict with AUTO ID] Signed-off-by: Ravi Kumar Bokka Signed-off-by: Douglas Anderson Signed-off-by: Srinivas Kandagatla

[PATCH 02/14] MAINTAINERS: Add git tree for NVMEM FRAMEWORK

From: Tiezhu Yang There is no git tree for NVMEM FRAMEWORK in MAINTAINERS, it is not convinent to rebase, add it. Signed-off-by: Tiezhu Yang Signed-off-by: Srinivas Kandagatla --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 68f21d46614c

[PATCH 04/14] nvmem: sc27xx: add sc2730 efuse support

From: Freeman Liu Add support to the new efuse IP which is integrated in the SC2730 which includes multiple blocks in a single chip. Signed-off-by: Freeman Liu Signed-off-by: Chunyan Zhang Reviewed-by: Baolin Wang Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sc27xx-efuse.c | 27

[PATCH 12/14] nvmem: update Kconfig description

From: Matteo Croce nvmem can't be built as module anymore, update its Kconfig description. Fixes: 2a37ce25d9f2 ("nvmem: disallow modular CONFIG_NVMEM") Signed-off-by: Matteo Croce Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/Kconfig | 3 --- 1 file changed, 3 deletions(-)

[PATCH 13/14] dt-bindings: nvmem: SID: add binding for A100's SID controller

From: Yangtao Li Add a binding for A100's SID controller. Signed-off-by: Yangtao Li Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../nvmem/allwinner,sun4i-a10-sid.yaml| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[PATCH 05/14] nvmem: core: Grammar fixes for help text

From: Andreas Färber It's "an unsigned" but "a U". Similarly, "an entry" but "a binary entry". While at it, also drop superfluous articles for negative and zero. Signed-off-by: Andreas Färber Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/cor

[PATCH 07/14] nvmem: core: add support to auto devid

NVMEM_DEVID_AUTO for providers to be able to allow core to assign id and append it to provier name. Reported-by: Shawn Guo Signed-off-by: Srinivas Kandagatla Tested-by: Shawn Guo --- drivers/nvmem/core.c | 10 -- include/linux/nvmem-provider.h | 3 +++ 2 files changed, 11

[PATCH 10/14] dt-bindings: nvmem: Add properties needed for blowing fuses

in the kernel. Signed-off-by: Ravi Kumar Bokka Signed-off-by: Douglas Anderson Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../bindings/nvmem/qcom,qfprom.yaml | 50 ++- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/Documentation

[PATCH 14/14] nvmem: qcom-spmi-sdam: Enable multiple devices

UTO as the NVMEM config ID to fix the issue. Signed-off-by: Guru Das Srinagesh Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/qcom-spmi-sdam.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c index 8682cda44

[PATCH 01/14] nvmem: sprd: Fix return value of sprd_efuse_probe()

From: Tiezhu Yang When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support") Signed-off-by: Tiezhu Yang Signed-off-by: Srinivas

[PATCH 00/14] nvmem: patches (set 1) for 5.9

: Enable multiple devices Matteo Croce (1): nvmem: update Kconfig description Ravi Kumar Bokka (3): dt-bindings: nvmem: qfprom: Convert to yaml dt-bindings: nvmem: Add properties needed for blowing fuses nvmem: qfprom: Add fuse blowing support Srinivas Kandagatla (2): nvmem: core: add

[PATCH 03/14] nvmem: Enforce nvmem stride in the sysfs interface

data first and then write it back. To keep it symmetric we'll just disallow it in both cases. Reported-by: Ravi Kumar Bokka Signed-off-by: Douglas Anderson Reviewed-by: Ravi Kumar Bokka Tested-by: Ravi Kumar Bokka Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 6 ++ 1 file

Re: [PATCH v2 1/1] nvmem: qcom-spmi-sdam: Enable multiple devices

On 21/07/2020 20:46, Guru Das Srinagesh wrote: Using pdev->id as the nvmem's config ID (which, by default, is NVMEM_DEVID_NONE) prevents multiple instances of this driver from probing because of the following error: sysfs: cannot create duplicate filename '/bus/nvmem/devices/spmi_sdam'

Re: [PATCH v2 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

On 21/07/2020 11:44, Cheng-Yi Chiang wrote: Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 130 ++ 1 file changed, 130 insertions(+) create mode 100644

Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

Few comments apart from Tzung-Bi comments, On 21/07/2020 11:44, Cheng-Yi Chiang wrote: From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by:

Re: [PATCH v2 2/9] ASoC: q6asm: make commands specific to streams

Thanks Pierre for review, On 21/07/2020 20:31, Pierre-Louis Bossart wrote: diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c index 941f3216399c..fb0488e7beb9 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -67,6 +67,8

Re: [PATCH v2 8/9] ASoC: qdsp6-dai: add gapless support

Thanks Pierre for quick review! On 21/07/2020 20:53, Pierre-Louis Bossart wrote:   case ASM_CLIENT_EVENT_CMD_EOS_DONE: -    prtd->state = Q6ASM_STREAM_STOPPED; +    spin_lock_irqsave(>lock, flags); +    if (prtd->notify_on_drain) { +    if (substream->partial_drain)

Re: [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters

On 21/07/2020 21:05, Pierre-Louis Bossart wrote: On 7/21/20 12:00 PM, Srinivas Kandagatla wrote: For gapless playback it is possible that each track can have different codec profile with same decoder, for example we have WMA album, we may have different tracks as WMA v9, WMA v10 and so

Re: [RFC PATCH v2 6/6] ASoC: q6asm-dai: add support to set_codec_params

Thanks Pierre for quick review. On 21/07/2020 21:09, Pierre-Louis Bossart wrote: On 7/21/20 12:00 PM, Srinivas Kandagatla wrote: Make use of new set_codec_params callback to allow decoder switching during gapless playback. Signed-off-by: Srinivas Kandagatla ---   sound/soc/qcom/qdsp6

[RFC PATCH v2 0/6] ALSA: compress: add support to change codec profile in gapless playback

codec profile, either for gapless or cross fade usecase. thanks, srini Changes since v1: - split patch into smaller chuncks, - bump up the version - added flags in compress capablity structure - added user for this new functionality. - add this new call in Documentation. Srinivas Kandagatla (6

<    1   2   3   4   5   6   7   8   9   10   >