Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-06-01 Thread Srinivas Kandagatla
On 26/05/2020 23:31, Doug Anderson wrote: Hi, On Fri, May 22, 2020 at 4:18 AM Srinivas Kandagatla wrote: On 21/05/2020 22:28, Doug Anderson wrote: Hi, On Thu, May 21, 2020 at 8:56 AM Srinivas Kandagatla wrote: On 21/05/2020 16:10, Doug Anderson wrote: On 20/05/2020 23:48, Doug

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-01 Thread Srinivas Kandagatla
On 01/06/2020 10:03, Vadym Kochan wrote: + + nvmem = of_nvmem_device_get(np, NULL); + if (IS_ERR(nvmem)) + return PTR_ERR(nvmem); + TBH, this looks completely incorrect way to do this and misuse of nvmem consumer interface. Ideally nvmem provider driver should

Re: [PATCH] nvmem: Enforce nvmem stride in the sysfs interface

2020-06-01 Thread Srinivas Kandagatla
On 29/05/2020 00:53, Douglas Anderson wrote: The 'struct nvmem_config' has a stride attribute that specifies the needed alignment for accesses into the nvmem. This is used in nvmem_cell_info_to_nvmem_cell() but not in the sysfs read/write functions. If the alignment is important in one

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-01 Thread Srinivas Kandagatla
On 30/05/2020 00:04, Vadym Kochan wrote: ONIE is a small operating system, pre-installed on bare metal network switches, that provides an environment for automated provisioning. This system requires that NVMEM (EEPROM) device holds various system information (mac address, platform name, etc)

Re: [PATCH 0/2] Fix some issues about NVMEM

2020-05-22 Thread Srinivas Kandagatla
On 22/05/2020 08:50, Tiezhu Yang wrote: This patch series is based on the latest Linus' tree. Tiezhu Yang (2): nvmem: sprd: Fix return value of sprd_efuse_probe() MAINTAINERS: Add git tree for NVMEM FRAMEWORK MAINTAINERS| 1 + drivers/nvmem/sprd-efuse.c | 4 ++-- 2

[PATCH] nvmem: qfprom: remove incorrect write support

2020-05-22 Thread Srinivas Kandagatla
corrected address space regions at the moment. Fixes: 4ab11996b489 ("nvmem: qfprom: Add Qualcomm QFPROM support.") Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/qfprom.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfpr

Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-05-22 Thread Srinivas Kandagatla
On 21/05/2020 22:28, Doug Anderson wrote: Hi, On Thu, May 21, 2020 at 8:56 AM Srinivas Kandagatla wrote: On 21/05/2020 16:10, Doug Anderson wrote: On 20/05/2020 23:48, Doug Anderson wrote: Is this only applicable for corrected address space? I guess I was proposing a two dts-node / two

Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-05-21 Thread Srinivas Kandagatla
On 21/05/2020 16:10, Doug Anderson wrote: On 20/05/2020 23:48, Doug Anderson wrote: Is this only applicable for corrected address space? I guess I was proposing a two dts-node / two drive approach here. dts node #1:just covers the memory range for accessing the FEC-corrected data driver

Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-05-21 Thread Srinivas Kandagatla
On 20/05/2020 23:48, Doug Anderson wrote: Is this only applicable for corrected address space? I guess I was proposing a two dts-node / two drive approach here. dts node #1:just covers the memory range for accessing the FEC-corrected data driver #1: read-only and reads the FEC-corrected

Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-05-20 Thread Srinivas Kandagatla
On 18/05/2020 19:31, Doug Anderson wrote: Hi, On Mon, May 18, 2020 at 3:45 AM Srinivas Kandagatla wrote: On 18/05/2020 11:39, Ravi Kumar Bokka (Temp) wrote: Based on the compatible, do i need to separate probe function for qfprom-efuse and maintain separate nvmem object to register

Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-05-18 Thread Srinivas Kandagatla
On 18/05/2020 11:39, Ravi Kumar Bokka (Temp) wrote: Based on the compatible, do i need to separate probe function for qfprom-efuse and maintain separate nvmem object to register nvmem framework. Is this what you are suggesting to implementing this in to one existing driver? Yes for

Re: [PATCH v2 4/7] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-05-18 Thread Srinivas Kandagatla
On 14/05/2020 17:38, Ajit Pandey wrote: I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Instead of adding extra overhead for calculating masks and shifts for newer variants registers layout we changed the approach to use regmap_field_write()

Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header

2020-05-18 Thread Srinivas Kandagatla
On 14/05/2020 17:38, Ajit Pandey wrote: Add header defining dai-id and mclk id for SC7180 lpass soc. Signed-off-by: Ajit Pandey --- include/dt-bindings/sound/sc7180-lpass.h | 10 ++ Why not reuse or rename include/dt-bindings/sound/apq8016-lpass.h to

Re: [PATCH v2 2/7] ASoC: qcom: Add common array to initialize soc based core clocks

2020-05-18 Thread Srinivas Kandagatla
On 14/05/2020 17:38, Ajit Pandey wrote: AHB-I/X bus clocks inside LPASS coreis not a mandatory clocks for SC7180 soc lpass variants, hence make it an optional one. Signed-off-by: Ajit Pandey --- For some reason patch subject seems messed up! I see two patches with same subject "[PATCH v2

Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-05-15 Thread Srinivas Kandagatla
On 14/05/2020 13:26, Ravi Kumar Bokka (Temp) wrote: Hi Srinivas, Thanks for your feedback by giving review comments. Please find my inline comments. Regards, Ravi Kumar.B On 5/13/2020 6:50 PM, Srinivas Kandagatla wrote: On 12/05/2020 19:17, Ravi Kumar Bokka wrote: This patch adds new

Re: [PATCH v2 4/6] nvmem: add support for the Khadas MCU Programmable User Memory

2020-05-15 Thread Srinivas Kandagatla
On 13/05/2020 13:33, Neil Armstrong wrote: On 13/05/2020 12:34, Srinivas Kandagatla wrote: On 12/05/2020 14:26, Neil Armstrong wrote: The new Khadas VIM2, VIM3 and Edge boards embeds an on-board microcontroller offering a 56bytes User Programmable NVMEM array. This array needs a password

Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-05-13 Thread Srinivas Kandagatla
On 12/05/2020 19:17, Ravi Kumar Bokka wrote: This patch adds new driver for QTI qfprom-efuse controller. This driver can access the raw qfprom regions for fuse blowing. QTI? The current existed qfprom driver is only supports for cpufreq, thermal sensors drivers by read out calibration

Re: [PATCH v2 4/6] nvmem: add support for the Khadas MCU Programmable User Memory

2020-05-13 Thread Srinivas Kandagatla
On 12/05/2020 14:26, Neil Armstrong wrote: The new Khadas VIM2, VIM3 and Edge boards embeds an on-board microcontroller offering a 56bytes User Programmable NVMEM array. This array needs a password to be writable, thus a password sysfs file has been added on the device node to unlock the

[PATCH v2] misc: fastrpc: fix potential fastrpc_invoke_ctx leak

2020-05-12 Thread Srinivas Kandagatla
->refcount.refcount.ref.counter' not decremented on lines: 990. Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context") Reported-by: Dan Carpenter Signed-off-by: Srinivas Kandagatla --- Changes since v1: moved fastrpc_context_put to fastrpc_invoke_send() drivers/misc/fastrpc.c | 9

Re: [PATCH] misc: fastrpc: fix potential fastrpc_invoke_ctx leak

2020-05-12 Thread Srinivas Kandagatla
On 12/05/2020 02:18, Bjorn Andersson wrote: On Mon 11 May 09:29 PDT 2020, Srinivas Kandagatla wrote: fastrpc_invoke_ctx can have refcount of 2 in error path where rpmsg_send() fails to send invoke message. decrement the refcount properly in the error path to fix this leak. This also fixes

[PATCH] misc: fastrpc: fix potential fastrpc_invoke_ctx leak

2020-05-11 Thread Srinivas Kandagatla
->refcount.refcount.ref.counter' not decremented on lines: 990. Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context") Reported-by: Dan Carpenter Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/m

[PATCH v2] misc: fastrpc: Fix an incomplete memory release in fastrpc_rpmsg_probe()

2020-05-11 Thread Srinivas Kandagatla
fastrpc_channel_ctx is not freed if misc_register() fails, this would lead to a memory leak. Fix this leak by adding kfree in misc_register() error path. Fixes: 278d56f970ae ("misc: fastrpc: Reference count channel context") Signed-off-by: Srinivas Kandagatla --- Change

[PATCH 1/2] slimbus: core: Set fwnode for a device when setting of_node

2020-05-11 Thread Srinivas Kandagatla
: removed unnecessary NULL check from other patch] Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 526e3215d8fe..1f3beee74fdf 100644 --- a/drivers/slimbus/core.c

[PATCH 2/2] slimbus: core: Fix mismatch in of_node_get/put

2020-05-11 Thread Srinivas Kandagatla
From: Saravana Kannan Adding missing corresponding of_node_put Fixes: 7588a511bdb4 ("slimbus: core: add support to device tree helper") Signed-off-by: Saravana Kannan [Srini: added fixes tag, removed NULL check and updated log] Signed-off-by: Srinivas Kandagatla --- drivers/slim

[PATCH 0/2] slimbus: patches for 5.8

2020-05-11 Thread Srinivas Kandagatla
Hi Greg, Here are two slimbus patches for 5.8, Can you please queue them up for 5.8. Thanks, srini Saravana Kannan (2): slimbus: core: Set fwnode for a device when setting of_node slimbus: core: Fix mismatch in of_node_get/put drivers/slimbus/core.c | 6 +++--- 1 file changed, 3

[PATCH 3/3] nvmem: jz4780-efuse: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-11 Thread Srinivas Kandagatla
From: Samuel Zou Fixes coccicheck warning: drivers/nvmem/jz4780-efuse.c:214:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/jz4780-efuse.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH 1/3] nvmem: imx-ocotp: Improve logic to save many code lines

2020-05-11 Thread Srinivas Kandagatla
From: Anson Huang Several logic improvements to save many code lines: - no need to use goto; - no need to assign return value; - combine different conditions of return value into one line. Signed-off-by: Anson Huang Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 9

[PATCH 2/3] nvmem: ensure sysfs writes handle write-protect pin

2020-05-11 Thread Srinivas Kandagatla
the sysfs attribute to invoke nvmme_reg_read/nvmem_reg_write helpers which handle this, rather than calling reg_read/reg_write directly. Fixes: 2a127da461a9 ("nvmem: add support for the write-protect pin") Signed-off-by: Michael Auchter Signed-off-by: Srinivas Kandagatla

[PATCH 0/3] nvmem: patches for 5.8

2020-05-11 Thread Srinivas Kandagatla
Hi Greg, Here are some nvmem patches for 5.8 which includes two trivial code cleanups and one fix to drive write-protect pin for all usecases. Can you please queue them up for 5.8. Thanks, srini Anson Huang (1): nvmem: imx-ocotp: Improve logic to save many code lines Michael Auchter (1):

Re: [PATCH v3 2/2] nvmem: core: skip nodes with compatibles other than "nvmem-cell"

2020-05-11 Thread Srinivas Kandagatla
On 28/04/2020 12:18, Ahmad Fatoum wrote: The nvmem cell binding used to apply to all objects which match "^.*@[0-9a-f]+$", without taking a compatible into account, which precluded extension of EEPROMs by child nodes other than nvmem. A previous commit changed the binding, so that nvmem

[PATCH] misc: fastrpc: fix memory leak

2020-04-29 Thread Srinivas Kandagatla
if misc_register() fails, previously allocated data is left without freeing, this could result in memory leak. So fix it! Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc

Re: [PATCH] nvmem: ensure sysfs writes handle write-protect pin

2020-04-28 Thread Srinivas Kandagatla
On 27/04/2020 19:39, Michael Auchter wrote: Commit 2a127da461a9d8d97782d6e82b227041393eb4d2 added support for handling write-protect pins to the nvmem core, and commit 1c89074bf85068d1b86f2e0f0c2110fdd9b83c9f retrofitted the at24 driver to use this support. These changes broke write() on the

Re: [PATCH][next] thermal: qcom: tsens-v1: fix kfree of a non-pointer value

2019-10-22 Thread Srinivas Kandagatla
On 22/10/2019 14:06, Amit Kucheria wrote: On Tue, Oct 22, 2019 at 4:48 PM Colin King wrote: From: Colin Ian King Currently the kfree of pointer qfprom_cdata is kfreeing an error value that has been cast to a pointer rather than a valid address. Fix this by removing the kfree. Hmm, we

Re: [PATCH 1/2] dt-bindings: nvmem: add binding for Rockchip OTP controller

2019-10-22 Thread Srinivas Kandagatla
On 25/09/2019 19:49, Heiko Stuebner wrote: Newer Rockchip SoCs use a different IP for accessing special one- time-programmable memory, so add a binding for these controllers. Signed-off-by: Heiko Stuebner Applied both, thanks, srini --- .../bindings/nvmem/rockchip-otp.txt |

Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-21 Thread Srinivas Kandagatla
On 21/10/2019 12:45, Lee Jones wrote: On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: Thanks Lee for taking time to review. I agree with most of the style related comments, will fix them in next version. For others I have replied it inline. [...] +static int wcd934x_slim_status(struct

Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-21 Thread Srinivas Kandagatla
Thanks Lee for taking time to review. I agree with most of the style related comments, will fix them in next version. For others I have replied it inline. On 21/10/2019 11:46, Lee Jones wrote: On Fri, 18 Oct 2019, Srinivas Kandagatla wrote: Qualcomm WCD9340/WCD9341 Codec is a standalone Hi

Re: [PATCH v2 05/11] ASoC: wcd934x: add playback dapm widgets

2019-10-21 Thread Srinivas Kandagatla
Thanks Rojewski for taking time to review. On 20/10/2019 21:05, Cezary Rojewski wrote: On 2019-10-18 02:18, Srinivas Kandagatla wrote: +static int wcd934x_codec_enable_slim(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *kc, +   int event

Re: [PATCH 2/2] ASoC: msm8916-wcd-analog: Add earpiece

2019-10-21 Thread Srinivas Kandagatla
On 20/10/2019 16:30, Stephan Gerhold wrote: PM8916 supports an earpiece as another (small) speaker. The earpiece is routed through RX MIX1 similarly to the headphones, except that RDAC2 MUX is set to RX1. Signed-off-by: Stephan Gerhold Looks good to me. Acked-by: Srinivas Kandagatla

Re: [PATCH 1/2] ASoC: msm8916-wcd-analog: Fix RX1 selection in RDAC2 MUX

2019-10-21 Thread Srinivas Kandagatla
it with "RX1" to fix this. Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec") Signed-off-by: Stephan Gerhold Thanks for the patch, Nice catch! Acked-by: Srinivas Kandagatla --- sound/soc/codecs/msm8916-wcd-analog.c | 4 ++-- 1 file changed, 2 insertion

[PATCH v2 03/11] ASoC: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-17 Thread Srinivas Kandagatla
basic support for playback and capture via the interpolators and ADC respectively. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/wcd934x.c | 1582 3 files changed, 1594

[PATCH v2 05/11] ASoC: wcd934x: add playback dapm widgets

2019-10-17 Thread Srinivas Kandagatla
This patch adds required dapm widgets for playback. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wcd934x.c | 1562 1 file changed, 1562 insertions(+) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 7303851b4f5d

[PATCH v2 01/11] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec

2019-10-17 Thread Srinivas Kandagatla
This patch adds bindings for wcd9340/wcd9341 audio codec which can support both SLIMbus and I2S/I2C interface. Signed-off-by: Srinivas Kandagatla --- .../bindings/sound/qcom,wcd934x.yaml | 169 ++ 1 file changed, 169 insertions(+) create mode 100644 Documentation

[PATCH v2 09/11] pinctrl: qcom-wcd934x: Add support to wcd934x pinctrl driver.

2019-10-17 Thread Srinivas Kandagatla
From: Yeleswarapu Nagaradhesh This patch adds support to wcd934x pinctrl block found in WCD9340/WC9341 Audio codecs. [Srini: multiple cleanups to the code] Signed-off-by: Yeleswarapu Nagaradhesh Signed-off-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/Kconfig| 7

[PATCH v2 07/11] ASoC: wcd934x: add audio routings

2019-10-17 Thread Srinivas Kandagatla
This patch adds audio routing for both playback and capture. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wcd934x.c | 290 + 1 file changed, 290 insertions(+) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 9eb45820d670

[PATCH v2 08/11] dt-bindings: pinctrl: qcom-wcd934x: Add bindings for gpio

2019-10-17 Thread Srinivas Kandagatla
Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated gpio controller to control 5 gpios on the chip. This patch adds required device tree bindings for it. Signed-off-by: Srinivas Kandagatla --- .../pinctrl/qcom,wcd934x-pinctrl.yaml | 51 +++ 1 file

[PATCH v2 10/11] ASoC: dt-bindings: Add compatible for DB845c and Lenovo Yoga

2019-10-17 Thread Srinivas Kandagatla
This patch adds compatible strings for DB845c and Lenovo Yoga C630 soundcard. Based on this compatible strings common machine driver will be in better position to setup board specific configuration. Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/sound/qcom,sdm845.txt

[PATCH v2 04/11] ASoC: wcd934x: add basic controls

2019-10-17 Thread Srinivas Kandagatla
This patch adds basic controls found in wcd934x codec. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wcd934x.c | 509 + 1 file changed, 509 insertions(+) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 2840ad1cb636

[PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-17 Thread Srinivas Kandagatla
Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-Fi audio codec IC. This codec has integrated SoundWire controller, pin controller and interrupt controller. Signed-off-by: Srinivas Kandagatla --- drivers/mfd/Kconfig | 8 + drivers/mfd/Makefile | 1

[PATCH v2 06/11] ASoC: wcd934x: add capture dapm widgets

2019-10-17 Thread Srinivas Kandagatla
This patch adds required dapm widgets for capture path. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wcd934x.c | 1275 1 file changed, 1275 insertions(+) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index e4a43ea14dce

[PATCH v2 11/11] ASoC: qcom: sdm845: add support to DB845c and Lenovo Yoga

2019-10-17 Thread Srinivas Kandagatla
This patch adds support to Lenovo Yoga c630 compatible strings and related setup to the sound machine driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/sdm845.c | 71 - 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/sound/soc

[PATCH v2 00/11] ASoC: Add support to WCD9340/WCD9341 codec

2019-10-17 Thread Srinivas Kandagatla
changes in this series - bindings converted to yaml. Srinivas Kandagatla (10): ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec mfd: wcd934x: add support to wcd9340/wcd9341 codec ASoC: wcd934x: add support to wcd9340/wcd9341 codec ASoC: wcd934x: add basic controls ASoC

Re: [PATCH v3 1/2] dt-bindings: soundwire: add bindings for Qcom controller

2019-10-15 Thread Srinivas Kandagatla
On 15/10/2019 12:35, Rob Herring wrote: On Mon, Oct 14, 2019 at 12:34 PM Srinivas Kandagatla wrote: Thanks Rob for taking time to review, On 14/10/2019 18:12, Rob Herring wrote: On Fri, Oct 11, 2019 at 04:44:22PM +0100, Srinivas Kandagatla wrote: This patch adds bindings for Qualcomm

Re: [PATCH v3 1/2] dt-bindings: soundwire: add bindings for Qcom controller

2019-10-14 Thread Srinivas Kandagatla
Thanks Rob for taking time to review, On 14/10/2019 18:12, Rob Herring wrote: On Fri, Oct 11, 2019 at 04:44:22PM +0100, Srinivas Kandagatla wrote: This patch adds bindings for Qualcomm soundwire controller. Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either

Re: [PATCH v3 2/2] soundwire: qcom: add support for SoundWire controller

2019-10-14 Thread Srinivas Kandagatla
Thanks Pierre for taking time to review the patch. On 11/10/2019 18:50, Pierre-Louis Bossart wrote: +static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *ctrl, u8 cmd_data, + u8 dev_addr, u16 reg_addr) +{ +    DECLARE_COMPLETION_ONSTACK(comp); +    unsigned long

[PATCH v3 1/2] dt-bindings: soundwire: add bindings for Qcom controller

2019-10-11 Thread Srinivas Kandagatla
This patch adds bindings for Qualcomm soundwire controller. Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD audio codecs via slimbus or as part of SOC I/O. Signed-off-by: Srinivas Kandagatla --- .../bindings/soundwire/qcom,sdw.txt

[PATCH v3 2/2] soundwire: qcom: add support for SoundWire controller

2019-10-11 Thread Srinivas Kandagatla
amplifiers. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/Kconfig | 9 + drivers/soundwire/Makefile | 4 + drivers/soundwire/qcom.c | 935 + 3 files changed, 948 insertions(+) create mode 100644 drivers/soundwire/qcom.c diff --git a/drivers

[PATCH v3 0/2] soundwire: Add support to Qualcomm SoundWire master

2019-10-11 Thread Srinivas Kandagatla
is rework of Qualcomm downstream drivers used in Andriod. Credits to Banajit Goswami and Patrick Lai's Team. TODO: Test and add PCM support. Thanks, srini Changes since v2: - Added support to set_sdw_stream Srinivas Kandagatla (2): dt-bindings: soundwire: add bindings for Qcom controller

Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-10-11 Thread Srinivas Kandagatla
On 10/10/2019 16:49, Pierre-Louis Bossart wrote: I still need to figure out prefixing multiple instances of this Amplifier controls with "Left" and "Right" FWIW we use the "snd_codec_conf" stuff to add a prefix for each amplifier, so that the controls are not mixed up between instances

Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-10-10 Thread Srinivas Kandagatla
On 10/10/2019 15:01, Pierre-Louis Bossart wrote: It's been a while since this thread started, and I still don't quite get the concepts or logic. First, I don't understand what the problem with "aux" devices is. All the SoundWire stuff is based on the concept of DAI, so I guess I am That

Re: [PATCH v7 2/2] ASoC: codecs: add wsa881x amplifier support

2019-10-10 Thread Srinivas Kandagatla
On 10/10/2019 14:23, Mark Brown wrote: On Thu, Oct 10, 2019 at 10:28:04AM +0100, Srinivas Kandagatla wrote: On 09/10/2019 17:35, Mark Brown wrote: On Wed, Oct 09, 2019 at 09:51:08AM +0100, Srinivas Kandagatla wrote: +static const u8 wsa881x_reg_readable[WSA881X_CACHE_SIZE] = { +static

Re: [PATCH v7 2/2] ASoC: codecs: add wsa881x amplifier support

2019-10-10 Thread Srinivas Kandagatla
Thanks Mark for taking time to review this patch. On 09/10/2019 17:35, Mark Brown wrote: On Wed, Oct 09, 2019 at 09:51:08AM +0100, Srinivas Kandagatla wrote: +static const u8 wsa881x_reg_readable[WSA881X_CACHE_SIZE] = { +static bool wsa881x_readable_register(struct device *dev, unsigned

Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-10-10 Thread Srinivas Kandagatla
On 09/10/2019 19:53, Pierre-Louis Bossart wrote: On 10/9/19 11:01 AM, Srinivas Kandagatla wrote: On 09/10/2019 15:29, Pierre-Louis Bossart wrote: On 10/9/19 3:32 AM, Srinivas Kandagatla wrote: Hi Pierre, On 14/08/2019 15:09, Pierre-Louis Bossart wrote: On 8/13/19 11:11 PM, Vinod

Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-10-09 Thread Srinivas Kandagatla
On 09/10/2019 15:29, Pierre-Louis Bossart wrote: On 10/9/19 3:32 AM, Srinivas Kandagatla wrote: Hi Pierre, On 14/08/2019 15:09, Pierre-Louis Bossart wrote: On 8/13/19 11:11 PM, Vinod Koul wrote: On 13-08-19, 20:58, Mark Brown wrote: On Tue, Aug 13, 2019 at 02:38:53PM -0500, Pierre

[PATCH v3 2/5] misc: fastrpc: fix memory leak from miscdev->name

2019-10-09 Thread Srinivas Kandagatla
x24/0x2c Signed-off-by: Srinivas Kandagatla Reviewed-by: Bjorn Andersson --- drivers/misc/fastrpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index aa1249bb581a..c0fe3419c685 100644 --- a/drivers/misc/fastrpc.c ++

[PATCH v3 4/5] misc: fastrpc: handle interrupted contexts

2019-10-09 Thread Srinivas Kandagatla
-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 666c431380ce..eef2cdc00672 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc

[PATCH v3 5/5] misc: fastrpc: revert max init file size back to 2MB

2019-10-09 Thread Srinivas Kandagatla
-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index eef2cdc00672..b6420aae45b9 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c

[PATCH v3 1/5] misc: fastrpc: add mmap/unmap support

2019-10-09 Thread Srinivas Kandagatla
-Ortiz Reviewed-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 181 include/uapi/misc/fastrpc.h | 15 +++ 2 files changed, 196 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index

[PATCH v3 3/5] misc: fastrpc: do not interrupt kernel calls

2019-10-09 Thread Srinivas Kandagatla
. If such a use-case becomes necessary, this timeout will need to be revisited. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/misc

[PATCH v3 0/5] misc: fastrpc: fixes and map/unmap support

2019-10-09 Thread Srinivas Kandagatla
support misc: fastrpc: do not interrupt kernel calls misc: fastrpc: handle interrupted contexts misc: fastrpc: revert max init file size back to 2MB Srinivas Kandagatla (1): misc: fastrpc: fix memory leak from miscdev->name drivers/misc/fastrpc.c |

Re: [PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-09 Thread Srinivas Kandagatla
On 08/10/2019 16:14, Stephen Boyd wrote: 3) As my use case does not use device tree, it is hard for ASoC machine to access nvmem device. I am wondering if I can use nvm_cell_lookup so machine driver can find the nvmem device using a con_id. But currently the cell lookup API requires a matched

[PATCH] ASoC: msm8916-wcd-digital: add missing MIX2 path for RX1/2

2019-10-09 Thread Srinivas Kandagatla
rted-by: Stephan Gerhold Signed-off-by: Srinivas Kandagatla Tested-by: Stephan Gerhold --- sound/soc/codecs/msm8916-wcd-digital.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/sound/soc/codecs/msm8916-wcd-digital.c b/sound/soc/codecs/msm8916-wcd-digital.c index 9fa5d44fd

[RFC PATCH] ASoC: soc-dapm: Skip suspending widgets with ignore flag

2019-10-09 Thread Srinivas Kandagatla
Papothi Signed-off-by: Srinivas Kandagatla --- sound/soc/soc-dapm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 13544f7c850b..4ecfd32e59b8 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -303,6 +303,8 @@ void

[RFC PATCH] ASoC: soc-dapm: Invalidate DAPM path during dapm addition of routes

2019-10-09 Thread Srinivas Kandagatla
into codec loopback failure. Change is to remove the sound card instantiation check condition in dapm add paths, so widgets get invalidated whenever they are added. Signed-off-by: Sudheer Papothi Signed-off-by: Srinivas Kandagatla --- sound/soc/soc-dapm.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v7 1/2] dt-bindings: ASoC: Add WSA881x bindings

2019-10-09 Thread Srinivas Kandagatla
This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker Amplifier. This Amplifier also has a simple thermal sensor for over temperature and speaker protection. Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../bindings/sound/qcom,wsa881x.yaml | 62

[PATCH v7 0/2] ASoC: codecs: Add WSA881x Smart Speaker amplifier support

2019-10-09 Thread Srinivas Kandagatla
Pierre and Rob - Removed udelay argument as suggested by Pierre. - Added device id for WSA8815 - rebased on sound-next Srinivas Kandagatla (2): dt-bindings: ASoC: Add WSA881x bindings ASoC: codecs: add wsa881x amplifier support .../bindings/sound/qcom,wsa881x.yaml

[PATCH v7 2/2] ASoC: codecs: add wsa881x amplifier support

2019-10-09 Thread Srinivas Kandagatla
-by: Srinivas Kandagatla Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/wsa881x.c | 1113 3 files changed, 1125 insertions(+) create mode 100644 sound/soc/codecs/wsa881x.c diff --git

Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-10-09 Thread Srinivas Kandagatla
Hi Pierre, On 14/08/2019 15:09, Pierre-Louis Bossart wrote: On 8/13/19 11:11 PM, Vinod Koul wrote: On 13-08-19, 20:58, Mark Brown wrote: On Tue, Aug 13, 2019 at 02:38:53PM -0500, Pierre-Louis Bossart wrote: Indeed. I don't have a full understanding of that part to be honest, nor why we

[PATCH] nvmem: imx: scu: fix dependency in Kconfig

2019-10-01 Thread Srinivas Kandagatla
Fix below error by adding HAVE_ARM_SMCCC dependency in Kconfig ERROR: "__arm_smccc_smc" [drivers/nvmem/nvmem-imx-ocotp-scu.ko] undefined! Reported-by: kbuild test robot Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 2/2] nvmem: add Rockchip OTP driver

2019-10-01 Thread Srinivas Kandagatla
On 25/09/2019 19:49, Heiko Stuebner wrote: From: Finley Xiao Newer Rockchip socs like the px30 use a different one-time-programmable memory controller for things like cpu-id and leakage information, so add the necessary driver for it. Signed-off-by: Finley Xiao [ported from vendor 4.4,

Re: [PATCH v2 1/2] dt-bindings: nvmem: Add Spreadtrum eFuse controller documentation

2019-10-01 Thread Srinivas Kandagatla
On 10/09/2019 06:52, Baolin Wang wrote: From: Freeman Liu This patch adds the binding documentation for Spreadtrum eFuse controller. Signed-off-by: Freeman Liu Signed-off-by: Baolin Wang Reviewed-by: Rob Herring --- Applied both, Thanks, srini Changes from v1: - Add reviewed tag

Re: [PATCH V2 1/2] nvmem: imx: scu: support hole region check

2019-10-01 Thread Srinivas Kandagatla
On 27/09/2019 03:23, Peng Fan wrote: From: Peng Fan Introduce HOLE/ECC_REGION flag and in_hole helper to ease the check of hole region. The ECC_REGION is also introduced here which is preparing for programming support. ECC_REGION could only be programmed once, so need take care.

Re: [PATCH] nvmem: sc27xx: Change to use devm_hwspin_lock_request_specific() to request one hwlock

2019-10-01 Thread Srinivas Kandagatla
On 27/09/2019 04:12, Baolin Wang wrote: Change to use devm_hwspin_lock_request_specific() to help to simplify the cleanup code for drivers requesting one hwlock. Thus we can remove the redundant sc27xx_efuse_remove() and platform_set_drvdata(). Signed-off-by: Baolin Wang ---

Re: [PATCH 0/6] rpmsg: glink stability fixes

2019-09-19 Thread Srinivas Kandagatla
++- 1 file changed, 42 insertions(+), 8 deletions(-) Thanks for the fixes. Tested-by: Srinivas Kandagatla --srini

Re: [PATCH v6 3/4] dt-bindings: ASoC: Add WSA881x bindings

2019-09-19 Thread Srinivas Kandagatla
Hi Mark, On 29/08/2019 17:35, Srinivas Kandagatla wrote: This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker Amplifier. This Amplifier also has a simple thermal sensor for over temperature and speaker protection. Signed-off-by: Srinivas Kandagatla Bindings for the codec have

[PATCH] rpmsg: glink: Fix channel memory leak

2019-09-19 Thread Srinivas Kandagatla
[] ret_from_fork+0x10/0x18 [] 0x unreferenced object 0xffc02cf5ed80 (size 128): Signed-off-by: Srinivas Kandagatla --- drivers/rpmsg/qcom_glink_native.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg

Re: [PATCH] nvmem: core: fix nvmem_cell_write inline function

2019-09-17 Thread Srinivas Kandagatla
Nandor Cc: Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org Signed-off-by: Sebastian Reichel I still see the issue in linux-next, did this get dropped by accident? I just pushed it to nvmem tree, should be fixed in next soon! --srini Arnd

[PATCH] soc: qcom: socinfo: add sdm845 and sda845 soc ids

2019-09-12 Thread Srinivas Kandagatla
This patch adds missing soc ids for sdm845 and sda845 Signed-off-by: Srinivas Kandagatla --- drivers/soc/qcom/socinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c index 855353bed19e..8dc86a74559b 100644 --- a/drivers/soc/qcom

[PATCH] soc: qcom: socinfo: add missing soc_id sysfs entry

2019-09-12 Thread Srinivas Kandagatla
looks like SoC ID is not exported to sysfs for some reason. This patch adds it! This is mostly used by userspace libraries like SNPE. Signed-off-by: Srinivas Kandagatla --- drivers/soc/qcom/socinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc

Re: [PATCH 2/2] nvmem: imx: scu: support write

2019-09-06 Thread Srinivas Kandagatla
On 06/09/2019 07:57, Peng Fan wrote: Subject: [PATCH 2/2] nvmem: imx: scu: support write Ping.. Thanks for your patience! I normally do not take patches after rc5 for nvmem. These will be applied after rc1 is released! Thanks, srini Thanks, Peng. From: Peng Fan The fuse programming

Re: [PATCH v2 5/5] misc: fastrpc: free dma buf scatter list

2019-09-05 Thread Srinivas Kandagatla
On 05/09/2019 06:11, Stephen Boyd wrote: Quoting Srinivas Kandagatla (2019-08-29 02:29:26) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index eee2bb398947..47ae84afac2e 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -550,6 +550,7 @@ static void

Re: [PATCH v2 4/5] dt-bindings: soundwire: add bindings for Qcom controller

2019-08-30 Thread Srinivas Kandagatla
Hi Rob, On 23/08/2019 08:28, Vinod Koul wrote: On 13-08-19, 09:35, Srinivas Kandagatla wrote: This patch adds bindings for Qualcomm soundwire controller. Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD audio codecs via slimbus or as part

[PATCH v6 3/4] dt-bindings: ASoC: Add WSA881x bindings

2019-08-29 Thread Srinivas Kandagatla
This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker Amplifier. This Amplifier also has a simple thermal sensor for over temperature and speaker protection. Signed-off-by: Srinivas Kandagatla --- .../bindings/sound/qcom,wsa881x.yaml | 62 +++ 1 file

[PATCH v6 2/4] soundwire: core: add device tree support for slave devices

2019-08-29 Thread Srinivas Kandagatla
This patch adds support to parsing device tree based SoundWire slave devices. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/bus.c | 2 ++ drivers/soundwire/bus.h | 1 + drivers/soundwire/slave.c | 52 +++ 3 files changed, 55 insertions

[PATCH v6 0/4] ASoC: codecs: Add WSA881x Smart Speaker amplifier support

2019-08-29 Thread Srinivas Kandagatla
slave bindings with proper licencing and fixed up examples. Srinivas Kandagatla (4): dt-bindings: soundwire: add slave bindings soundwire: core: add device tree support for slave devices dt-bindings: ASoC: Add WSA881x bindings ASoC: codecs: add wsa881x amplifier support .../bindings/sound

[PATCH v6 4/4] ASoC: codecs: add wsa881x amplifier support

2019-08-29 Thread Srinivas Kandagatla
-by: Srinivas Kandagatla --- sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/wsa881x.c | 1134 3 files changed, 1146 insertions(+) create mode 100644 sound/soc/codecs/wsa881x.c diff --git a/sound/soc/codecs/Kconfig b/sound/soc

[PATCH v6 1/4] dt-bindings: soundwire: add slave bindings

2019-08-29 Thread Srinivas Kandagatla
This patch adds bindings for Soundwire Slave devices that includes how SoundWire enumeration address and Link ID are used to represented in SoundWire slave device tree nodes. Signed-off-by: Srinivas Kandagatla --- .../soundwire/soundwire-controller.yaml | 82 +++ 1 file

Re: [PATCH v5 3/4] dt-bindings: ASoC: Add WSA881x bindings

2019-08-29 Thread Srinivas Kandagatla
Thanks for the review! On 29/08/2019 16:46, Rob Herring wrote: On Thu, Aug 29, 2019 at 9:45 AM Srinivas Kandagatla wrote: This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker Amplifier. This Amplifier also has a simple thermal sensor for over temperature and speaker protection

Re: [PATCH v5 1/4] dt-bindings: soundwire: add slave bindings

2019-08-29 Thread Srinivas Kandagatla
On 29/08/2019 16:42, Rob Herring wrote: On Thu, Aug 29, 2019 at 9:45 AM Srinivas Kandagatla wrote: This patch adds bindings for Soundwire Slave devices that includes how SoundWire enumeration address and Link ID are used to represented in SoundWire slave device tree nodes. Signed-off

[PATCH v5 2/4] soundwire: core: add device tree support for slave devices

2019-08-29 Thread Srinivas Kandagatla
This patch adds support to parsing device tree based SoundWire slave devices. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/bus.c | 2 ++ drivers/soundwire/bus.h | 1 + drivers/soundwire/slave.c | 52 +++ 3 files changed, 55 insertions

[PATCH v5 3/4] dt-bindings: ASoC: Add WSA881x bindings

2019-08-29 Thread Srinivas Kandagatla
This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker Amplifier. This Amplifier also has a simple thermal sensor for over temperature and speaker protection. Signed-off-by: Srinivas Kandagatla --- .../bindings/sound/qcom,wsa881x.yaml | 41 +++ 1 file

<    3   4   5   6   7   8   9   10   11   12   >