[PATCH 0/4] nvmem: patches for 4.19

2018-07-11 Thread Srinivas Kandagatla
Hi Greg, This patchset adds support to imx6sll to existing imx nvmem provider and a new sc27xx nvmem provider. Can you please pick them up for 4.19. thanks, srini Anson Huang (2): dt-bindings: nvmem: imx-ocotp: add compatible string for imx6sll nvmem: imx-ocotp: add support for imx6sll Bao

[PATCH 2/4] nvmem: Add Spreadtrum SC27XX efuse support

2018-07-11 Thread Srinivas Kandagatla
From: Freeman Liu This patch add the efuse driver which is embeded in Spreadtrum SC27XX series PMICs. The sc27xx efuse contains 32 blocks and each block's data width is 16 bits. Signed-off-by: Freeman Liu Signed-off-by: Baolin Wang Signed-off-by: Srinivas Kandagatla --- drivers/

[PATCH 4/4] nvmem: imx-ocotp: add support for imx6sll

2018-07-11 Thread Srinivas Kandagatla
From: Anson Huang i.MX6SLL is a new SoC of i.MX6 family, enable ocotp driver support for this SoC. Signed-off-by: Anson Huang Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem

[PATCH 3/4] dt-bindings: nvmem: imx-ocotp: add compatible string for imx6sll

2018-07-11 Thread Srinivas Kandagatla
From: Anson Huang Add new compatible string for i.MX6SLL SOC. Signed-off-by: Anson Huang Acked-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation

[PATCH 1/4] dt-bindings: nvmem: Add Spreadtrum SC27XX efuse controller documentation

2018-07-11 Thread Srinivas Kandagatla
From: Baolin Wang This patch adds the binding documentation for Spreadtrum SC27XX series PMICs efuse controller device. Signed-off-by: Baolin Wang Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/nvmem/sc27xx-efuse.txt | 52

Re: [PATCH 1/2] slimbus: stream: add stream support

2018-06-25 Thread Srinivas Kandagatla
Thanks Stephen for review, On 25/06/18 17:12, Stephen Boyd wrote: Quoting Srinivas Kandagatla (2018-06-21 06:40:08) new file mode 100644 index ..f8af9474d286 --- /dev/null +++ b/drivers/slimbus/stream.c @@ -0,0 +1,493 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2018

Re: [PATCH 1/2] slimbus: stream: add stream support

2018-06-25 Thread Srinivas Kandagatla
On 25/06/18 17:21, Vinod wrote: +/* + * slim_stream_enable() - Enable a prepared SLIMbus Stream Do you want to check if it is already prepared ..? Yep, I think most of the code needs similar state machine check, I will add this in next version. so if you are tying to snd stream states then

[PATCH v2 07/12] ASoC: qdsp6: q6afe-dai: support dt based module loading

2018-06-26 Thread Srinivas Kandagatla
This patch uses new compatible string to make DT based module loading work. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c index 5002dd05bf27

[PATCH v2 01/12] ASoC: q6adm: dt-bindings: add compatible string to routing

2018-06-26 Thread Srinivas Kandagatla
Add compatible string to routing so that it can support DT based module autoloading. Signed-off-by: Srinivas Kandagatla Acked-by: Niklas Cassel --- Documentation/devicetree/bindings/sound/qcom,q6adm.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v2 05/12] ASoC: qdsp6: q6asm: use of_platform_populate/depopulate()

2018-06-26 Thread Srinivas Kandagatla
Now that the child nodes have there own compatible strings, Use of_platform_populate/depopulate() instead of less common of_platform_device_create()/destroy(). Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm.c | 16 ++-- 1 file changed, 2 insertions(+), 14

[PATCH v2 11/12] ASoC: qdsp6: q6routing: add proper error check

2018-06-26 Thread Srinivas Kandagatla
q6adm_open can return error pointer or a null in error cases. Fix the return handling. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6routing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c

[PATCH v2 12/12] ASoC: qdsp6: q6asm: remove unused struct q6asm member

2018-06-26 Thread Srinivas Kandagatla
pcmdev in struct q6asm seems be left over and unused, so just remove it. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index c4fd28f168d5..2b2c7233bb5f 100644

[PATCH v2 06/12] ASoC: qdsp6: q6afe: use of_platform_populate/depopulate()

2018-06-26 Thread Srinivas Kandagatla
Now that the child nodes have there own compatible strings, Use of_platform_populate/depopulate() instead of less common of_platform_device_create()/destroy(). Signed-off-by: Srinivas Kandagatla Acked-by: Niklas Cassel --- sound/soc/qcom/qdsp6/q6afe.c | 16 ++-- 1 file changed, 2

[PATCH v2 10/12] ASoC: qcom: apq8096: remove redundant owner assignment

2018-06-26 Thread Srinivas Kandagatla
module owner is already set in platform_driver_register(), so remove this redundant assignment. Signed-off-by: Srinivas Kandagatla Acked-by: Niklas Cassel --- sound/soc/qcom/apq8096.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c index

[PATCH v2 08/12] ASoC: qdsp6: q6asm-dai: support dt based module loading

2018-06-26 Thread Srinivas Kandagatla
This patch uses new compatible string to make DT based module loading work. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c index 349c6a883c63

[PATCH v2 09/12] ASoC: qdsp6: q6routing: support dt based module loading

2018-06-26 Thread Srinivas Kandagatla
This patch uses new compatible string to make DT based module loading work. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6routing.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index 593f66b8622f

[PATCH v2 04/12] ASoC: qdsp6: q6adm: use of_platform_populate/depopulate()

2018-06-26 Thread Srinivas Kandagatla
Now that the child nodes have there own compatible strings, Use of_platform_populate/depopulate() instead of less common of_platform_device_create()/destroy(). Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6adm.c | 16 ++-- 1 file changed, 2 insertions(+), 14

[PATCH v2 03/12] ASoC: q6afe: dt-bindings: add compatible string to dais

2018-06-26 Thread Srinivas Kandagatla
Add compatible string to dais so that it can support DT based module autoloading. Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/sound/qcom,q6afe.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt b

[PATCH v2 02/12] ASoC: q6asm: dt-bindings: add compatible string to dais

2018-06-26 Thread Srinivas Kandagatla
Add compatible string to dais so that it can support DT based module autoloading. Signed-off-by: Srinivas Kandagatla Acked-by: Niklas Cassel --- Documentation/devicetree/bindings/sound/qcom,q6asm.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v2 00/12] ASoC: qdsp6: Fix dt based module loading and minor fixes

2018-06-26 Thread Srinivas Kandagatla
trivial fixes which is removing redundant owner, remove unused struct member and fix a error check in q6routing. Changes since v1: - Addressed few trivial comments from Niklas Thanks, srini Srinivas Kandagatla (12): ASoC: q6adm: dt-bindings: add compatible string to routing ASoC: q6asm: dt

Re: [PATCH v2 00/12] ASoC: qdsp6: Fix dt based module loading and minor fixes

2018-06-26 Thread Srinivas Kandagatla
On 26/06/18 10:43, Niklas Cassel wrote: If the code is bisectable with the current ordering of the patches, then feel free to ignore this review comment. Ofcourse the code is bisectable with the current series as it. thanks, srini

[PATCH] nvmem: core: remove unused nvmem_device ncells member

2018-06-26 Thread Srinivas Kandagatla
nvmem ncells can be over written by calling nvmem_add_cells() multiple times. I see there is no real point of maintaining count of cells when we have a list of cell. Remove this to avoid any confusion! Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 2 -- 1 file changed, 2

[PATCH v2 0/2] slimbus: Add QCOM SLIMBus NGD driver

2018-05-25 Thread Srinivas Kandagatla
://git.linaro.org/people/srinivas.kandagatla/linux.git/log/?h=slimbus-ngd Srinivas Kandagatla (2): slimbus: ngd: dt-bindings: Add slim ngd dt bindings slimbus: ngd: Add qcom SLIMBus NGD driver .../bindings/slimbus/slim-ngd-qcom-ctrl.txt| 84 ++ drivers/slimbus/Kconfig

[PATCH v2 1/2] slimbus: ngd: dt-bindings: Add slim ngd dt bindings

2018-05-25 Thread Srinivas Kandagatla
management Signed-off-by: Srinivas Kandagatla --- .../bindings/slimbus/slim-ngd-qcom-ctrl.txt| 84 ++ 1 file changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings/slimbus/slim-ngd-qcom-ctrl.txt diff --git a/Documentation/devicetree/bindings

[PATCH v2 2/2] slimbus: ngd: Add qcom SLIMBus NGD driver

2018-05-25 Thread Srinivas Kandagatla
and data-channel management Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 11 + drivers/slimbus/Makefile|3 + drivers/slimbus/qcom-ngd-ctrl.c | 1342 +++ drivers/slimbus/slimbus.h |8 + 4 files changed, 1364

[PATCH 0/2] regmap: slimbus: minor fixes.

2018-05-25 Thread Srinivas Kandagatla
Here are 2 minor fixes for regmap slimbus. Thanks, srini Srinivas Kandagatla (2): regmap: add missing prototype for devm_init_slimbus regmap: slimbus: allow register offsets up to 16 bits drivers/base/regmap/regmap-slimbus.c | 2 +- include/linux/regmap.h | 18

[PATCH 2/2] regmap: slimbus: allow register offsets up to 16 bits

2018-05-25 Thread Srinivas Kandagatla
As per SLIMBus specs Value Elements and Information Elements address map ranges from 0x000 - 0xFFF. So allow register addresses up to 16 bits Fixes: 7d6f7fb053ad ("regmap: add SLIMbus support") Signed-off-by: Srinivas Kandagatla --- drivers/base/regmap/regmap-slimbus.c | 2 +- 1 fi

[PATCH 1/2] regmap: add missing prototype for devm_init_slimbus

2018-05-25 Thread Srinivas Kandagatla
; was not declared. Should it be static? regmap-slimbus.c:65:16: warning: no previous prototype for '__devm_regmap_init_slimbus' [-Wmissing-prototypes] Fixes: 7d6f7fb053ad ("regmap: add SLIMbus support") Signed-off-by: Srinivas Kandagatla --- include/linux/regmap.h | 18

[PATCH v3 5/8] slimbus: messaging: initialize completion correctly

2018-05-25 Thread Srinivas Kandagatla
slim_val_inf can contain random value from stack, make sure the completion is initialized to NULL while filling the msg. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus

[PATCH v3 2/8] slimbus: core: add need_tid flag to slim_msg_txn

2018-05-25 Thread Srinivas Kandagatla
Add need_tid flag to txn, this flag can be set before start of transcation. Having this flag would avoid calling slim_tid_txn() multiple times on the same txn. Also it is handy for controller drivers too. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/slimbus.h | 2 ++ 1 file changed, 2

[PATCH v3 4/8] slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy

2018-05-25 Thread Srinivas Kandagatla
There seems to be a multiple calls to pm_runtime_mark_last_busy(), which looks like a typo. Fix this by properly adding pm_runtime_put_autosuspend to put controller in auto suspend state. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion

[PATCH v3 8/8] slimbus: core: add of_slim_device_get() helper

2018-05-25 Thread Srinivas Kandagatla
. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 39 +++ include/linux/slimbus.h | 2 ++ 2 files changed, 41 insertions(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 7ddfc675b131..88248a4ecad9 100644 --- a/drivers/slimbus

[PATCH v3 7/8] slimbus: messaging: add slim_prepare_txn() helper function

2018-05-25 Thread Srinivas Kandagatla
This patch adds slim_prepare_txn() to allow controllers to prepare controller specific transaction. If not each controllers will duplicate the same code from core. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 84 ++--- drivers

[PATCH v3 6/8] slimbus: qcom: remove redundant depends in Kconfig

2018-05-25 Thread Srinivas Kandagatla
QCOM SLIMBus controller is already under a 'if SLIMBUS' in Kconfig, having depends on SLIMBUS is totally redundant. Just remove it. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/slimbus/Kconfig b/drivers/slimb

[PATCH v3 1/8] slimbus: core: rearrange slim_eaddr structure

2018-05-25 Thread Srinivas Kandagatla
Rearrange struct slim_eaddr so that the structure is packed correctly to be able to send in SLIMBus messages. Signed-off-by: Srinivas Kandagatla --- include/linux/slimbus.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/slimbus.h b/include/linux

[PATCH v3 3/8] slimbus: messaging: pass correct wbuf

2018-05-25 Thread Srinivas Kandagatla
There seems to be a typo while filling msg for slim_write, wbuf is set to NULL instead of rbuf. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index

[PATCH v3 0/8] slimbus: fixes and some helpers

2018-05-25 Thread Srinivas Kandagatla
thanks, Srini Srinivas Kandagatla (8): slimbus: core: rearrange slim_eaddr structure slimbus: core: add need_tid flag to slim_msg_txn slimbus: messaging: pass correct wbuf slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy slimbus: messaging: initialize completion

[PATCH 1/8] drivers: nvmem: Export nvmem_add_cells()

2018-05-11 Thread Srinivas Kandagatla
config structure. Signed-off-by: Andrew Lunn Reviewed-by: Andrey Smirnov Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 24 +--- include/linux/nvmem-provider.h | 11 +++ 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 8/8] nvmem: properly handle returned value nvmem_reg_read

2018-05-11 Thread Srinivas Kandagatla
t but not used [-Wunused-but-set-variable] Signed-off-by: Mathieu Malaterre Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 36361044ddbe..b5b0cdc21d01 100644 --- a/drivers/nv

[PATCH 7/8] nvmem: core: describe add missing dev function parameter

2018-05-11 Thread Srinivas Kandagatla
/core.c:615: warning: Function parameter or member 'dev' not described in 'devm_nvmem_unregister' Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index b1c95ef78544..363610

[PATCH 6/8] nvmem: meson-efuse: add write support

2018-05-11 Thread Srinivas Kandagatla
From: Jerome Brunet Add write support to the meson-gx efuse driver. Beware, this efuse is one time programmable ! Reviewed-by: Kevin Hilman Signed-off-by: Jerome Brunet Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/meson-efuse.c | 9 - 1 file changed, 8 insertions(+), 1

[PATCH 4/8] nvmem: meson-efuse: remove econfig global

2018-05-11 Thread Srinivas Kandagatla
From: Jerome Brunet Having a global structure holding a reference to the device structure is not very nice. Allocate the econfig instead and fill the nvmem information as before Reviewed-by: Kevin Hilman Signed-off-by: Jerome Brunet Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/meson

[PATCH 5/8] nvmem: meson-efuse: simplify read callback

2018-05-11 Thread Srinivas Kandagatla
From: Jerome Brunet Most of the code and variables in the read callback is not necessary. Keep only what is required. Signed-off-by: Jerome Brunet Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/meson-efuse.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git

[PATCH 0/8] nvmem: patches for v4.18

2018-05-11 Thread Srinivas Kandagatla
driver nvmem: Add RAVE SP EEPROM driver Jerome Brunet (3): nvmem: meson-efuse: remove econfig global nvmem: meson-efuse: simplify read callback nvmem: meson-efuse: add write support Mathieu Malaterre (1): nvmem: properly handle returned value nvmem_reg_read Srinivas Kandagatla (1): nvmem

[PATCH 3/8] nvmem: Add RAVE SP EEPROM driver

2018-05-11 Thread Srinivas Kandagatla
From: Andrey Smirnov Add driver providing access to EEPROMs connected to RAVE SP devices Cc: Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org Cc: Chris Healy Cc: Lucas Stach Cc: Aleksander Morgado Signed-off-by: Andrey Smirnov Signed-off-by: Srinivas Kandagatla --- drivers/nvmem

[PATCH 2/8] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver

2018-05-11 Thread Srinivas Kandagatla
From: Andrey Smirnov Add Device Tree bindings for RAVE SP EEPROM driver - an MFD cell of parent RAVE SP driver (documented in Documentation/devicetree/bindings/mfd/zii,rave-sp.txt). Cc: Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org Cc: Chris Healy Cc: Lucas Stach Cc: Aleksander

[PATCH] slimbus: qcom: remove unused variable

2018-05-11 Thread Srinivas Kandagatla
This patch fixes below warning when driver is compiled with W=1 qcom-ctrl.c: In function 'qcom_slim_rxwq': qcom-ctrl.c:442:13: warning: variable 'len' set but not used [-Wunused-but-set-variable] len seems to be unused in this function, so remove it. Signed-off-by:

[PATCH] dmaengine: qcom: bam_dma: check if the runtime pm enabled

2018-05-14 Thread Srinivas Kandagatla
sable runtime pm on remote controlled") Signed-off-by: Srinivas Kandagatla --- drivers/dma/qcom/bam_dma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index d29275b97e84..5f4babebc508 100644 --- a/driver

[PATCH 0/3] rpmsg: glink: fix W=1 warnings.

2018-06-18 Thread Srinivas Kandagatla
Hi Bjorn, Here are few patches for warnings which I hit while building kernel with W=1 flag. thanks, srini Srinivas Kandagatla (3): rpmsg: glink: correctly annotate intent members rpmsg: glink: Fix various kerneldoc warnings. rpmsg: smd: fix kerneldoc warnings drivers/rpmsg

[PATCH 2/3] rpmsg: glink: Fix various kerneldoc warnings.

2018-06-18 Thread Srinivas Kandagatla
m_glink_advertise_intent' qcom_glink_native.c:604: warning: Excess function parameter 'size' description in 'qcom_glink_advertise_intent' qcom_glink_native.c:710: warning: Function parameter or member 'glink' not described in 'qcom_glink_handle_intent_req' qcom_g

[PATCH 3/3] rpmsg: smd: fix kerneldoc warnings

2018-06-18 Thread Srinivas Kandagatla
not described in 'qcom_smd_channel' qcom_smd.c:222: warning: Function parameter or member 'state_change_event' not described in 'qcom_smd_channel' qcom_smd.c:222: warning: Function parameter or member 'drvdata' not described in 'qcom_smd_channe

[PATCH 1/3] rpmsg: glink: correctly annotate intent members

2018-06-18 Thread Srinivas Kandagatla
qcom_glink_native.c:618:18:got restricted __le32 [usertype] Fix this by correctly annotating them. Signed-off-by: Srinivas Kandagatla --- drivers/rpmsg/qcom_glink_native.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b

[PATCH] nvmem: Don't let a NULL cell_id for nvmem_cell_get() crash us

2018-06-18 Thread Srinivas Kandagatla
"phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips") Signed-off-by: Douglas Anderson Signed-off-by: Srinivas Kandagatla --- Hi Greg, Can you please pick this one for next possible rc. thanks, srini drivers/nvmem/core.c | 4 1 file changed, 4 insertions(+) diff --git a/dr

Re: [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Srinivas Kandagatla
Thanks Rohit for the patch! On 18/06/18 12:16, Rohit kumar wrote: This patch adds sdm845 audio machine driver support. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,sdm845.txt | 87 sound/soc/qcom/Kconfig | 9 + sound/soc/qcom/Ma

Re: [PATCH v2 5/7] ASoC: qdsp6: Add depends on OF

2018-06-19 Thread Srinivas Kandagatla
On 18/06/18 21:53, Rob Herring wrote: On Mon, Jun 18, 2018 at 2:08 PM, Niklas Cassel wrote: On Mon, Jun 18, 2018 at 08:48:32AM -0600, Rob Herring wrote: On Mon, Jun 18, 2018 at 6:39 AM, Niklas Cassel wrote: On Mon, Jun 18, 2018 at 12:06:42PM +0100, Mark Brown wrote: On Thu, Jun 14, 2018

[PATCH 2/4] slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy

2018-06-19 Thread Srinivas Kandagatla
There seems to be a multiple calls to pm_runtime_mark_last_busy(), which looks like a typo. Fix this by properly adding pm_runtime_put_autosuspend to put controller in auto suspend state. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion

[PATCH 0/4] slimbus: fixes for v4.18

2018-06-19 Thread Srinivas Kandagatla
Hi Greg, Here are few trivial slimbus fixes, Could you please take them for next possible rc. Thanks, srini Srinivas Kandagatla (4): slimbus: messaging: pass correct wbuf slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy slimbus: messaging: initialize completion

[PATCH 3/4] slimbus: messaging: initialize completion correctly

2018-06-19 Thread Srinivas Kandagatla
slim_val_inf can contain random value from stack, make sure the completion is initialized to NULL while filling the msg. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus

[PATCH 4/4] slimbus: qcom: remove redundant depends in Kconfig

2018-06-19 Thread Srinivas Kandagatla
QCOM SLIMBus controller is already under a 'if SLIMBUS' in Kconfig, having depends on SLIMBUS is totally redundant. Just remove it. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/slimbus/Kconfig b/drivers/slimb

[PATCH 1/4] slimbus: messaging: pass correct wbuf

2018-06-19 Thread Srinivas Kandagatla
There seems to be a typo while filling msg for slim_write, wbuf is set to NULL instead of rbuf. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index

[PATCH v4 0/5] slimbus: Add QCOM SLIMBus NGD driver

2018-06-19 Thread Srinivas Kandagatla
slim_prepare_txn with slim_alloc/free_txn_tid() - fixed runtime pm issue for ngd device. Srinivas Kandagatla (5): slimbus: core: add of_slim_device_get() helper slimbus: core: rearrange slim_eaddr structure slimbus: messaging: add slim_alloc/free_txn_tid() slimbus: ngd: dt-bindings: Add slim ngd dt

[PATCH v4 5/5] slimbus: ngd: Add qcom SLIMBus NGD driver

2018-06-19 Thread Srinivas Kandagatla
and data-channel management Based on intial work from Karthikeyan Ramasubramanian and Sagar Dharia Signed-off-by: Srinivas Kandagatla Tested-by: Craig Tatlor Reviewed-by: Vinod Koul --- drivers/slimbus/Kconfig | 11 + drivers/slimbus/Makefile|3 + drivers/slimbus/qcom

[PATCH v4 1/5] slimbus: core: add of_slim_device_get() helper

2018-06-19 Thread Srinivas Kandagatla
. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 39 +++ include/linux/slimbus.h | 2 ++ 2 files changed, 41 insertions(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 7ddfc675b131..88248a4ecad9 100644 --- a/drivers/slimbus

[PATCH v4 3/5] slimbus: messaging: add slim_alloc/free_txn_tid()

2018-06-19 Thread Srinivas Kandagatla
to track the transactions back during debug. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 74 +++-- drivers/slimbus/slimbus.h | 2 ++ 2 files changed, 54 insertions(+), 22 deletions(-) diff --git a/drivers/slimbus/messaging.c b

[PATCH v4 4/5] slimbus: ngd: dt-bindings: Add slim ngd dt bindings

2018-06-19 Thread Srinivas Kandagatla
management Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring Tested-by: Craig Tatlor Reviewed-by: Vinod Koul --- .../bindings/slimbus/slim-ngd-qcom-ctrl.txt| 84 ++ 1 file changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v4 2/5] slimbus: core: rearrange slim_eaddr structure

2018-06-19 Thread Srinivas Kandagatla
Rearrange struct slim_eaddr so that the structure is packed correctly to be able to send in SLIMBus messages. Signed-off-by: Srinivas Kandagatla --- include/linux/slimbus.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/slimbus.h b/include/linux

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-20 Thread Srinivas Kandagatla
On 20/06/18 10:31, Vinod wrote: Here clock will be enabled twice but disable will be called only once when count = 0. This will make the clock always enabled. So, I think we should keep either mutex lock or atomic variable to synchronize this. we are using DPCM here right? We should probab

[PATCH v3 0/2] slimbus: Add QCOM SLIMBus NGD driver

2018-06-01 Thread Srinivas Kandagatla
prepare. Thanks, srini [1] https://git.linaro.org/people/srinivas.kandagatla/linux.git/log/?h=slimbus-ngd Srinivas Kandagatla (2): slimbus: ngd: dt-bindings: Add slim ngd dt bindings slimbus: ngd: Add qcom SLIMBus NGD driver .../bindings/slimbus/slim-ngd-qcom-ctrl.txt| 84

[PATCH v3 2/2] slimbus: ngd: Add qcom SLIMBus NGD driver

2018-06-01 Thread Srinivas Kandagatla
and data-channel management Based on initial work from Karthikeyan Ramasubramanian and Sagar Dharia Signed-off-by: Srinivas Kandagatla Tested-by: Craig Tatlor Reviewed-by: Vinod Koul --- drivers/slimbus/Kconfig | 11 + drivers/slimbus/Makefile|3 + drivers/slimbus/qcom

[PATCH v3 1/2] slimbus: ngd: dt-bindings: Add slim ngd dt bindings

2018-06-01 Thread Srinivas Kandagatla
management Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring Tested-by: Craig Tatlor Reviewed-by: Vinod Koul --- .../bindings/slimbus/slim-ngd-qcom-ctrl.txt| 84 ++ 1 file changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH] ASoC: dapm: delete dapm_kcontrol_data paths entry before freeing

2018-06-01 Thread Srinivas Kandagatla
e+0xbc/0xf8 dev_attr_store+0x18/0x28 sysfs_kf_write+0x3c/0x50 kernfs_fop_write+0x118/0x1e0 __vfs_write+0x18/0x110 vfs_write+0xa4/0x1a8 ksys_write+0x48/0xb0 sys_write+0xc/0x18 el0_svc_naked+0x30/0x34 Signed-off-by: Srinivas Kandagatla --- sound/soc/soc-dapm.c | 2 ++ 1 file changed, 2 inse

[PATCH] of: platform: stop accessing invalid dev in of_platform_device_destroy

2018-06-01 Thread Srinivas Kandagatla
8b400c21 f9800031 9ac32043 (c85f7c22) ---[ end trace 32020935775616a2 ]--- Signed-off-by: Srinivas Kandagatla --- drivers/of/platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index c00d81dfac0b..78c32b93c0e7 100644 --- a/drivers/of

Re: [PATCH] of: platform: stop accessing invalid dev in of_platform_device_destroy

2018-06-01 Thread Srinivas Kandagatla
On 01/06/18 23:58, Srinivas Kandagatla wrote: - of_node_clear_flag(dev->of_node, OF_POPULATED); - of_node_clear_flag(dev->of_node, OF_POPULATED_BUS); This change seems to have a side effect during re-probing. I will dig in bit more to see how best it can be fixed. thanks, srini

[PATCH] rpmsg: smd: do not use mananged resources for endpoints and channels

2018-06-01 Thread Srinivas Kandagatla
kzalloc for allocating channel->name and channel which is then freed in qcom_smd_edge_release(). Without this patch restarting a remoteproc would crash the system. Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend") Cc: Signed-off-by: Srinivas Kandagatla --- drivers/rpmsg/qc

[PATCH v2] of: platform: stop accessing invalid dev in of_platform_device_destroy

2018-06-01 Thread Srinivas Kandagatla
8b400c21 f9800031 9ac32043 (c85f7c22) Signed-off-by: Srinivas Kandagatla --- Changes since v1: - fixed issue while reprobing. drivers/of/platform.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index c00d81dfac0b

[PATCH 0/6] ASoC: qdsp6: Add missing slimbus capture support

2018-07-04 Thread Srinivas Kandagatla
, srini Srinivas Kandagatla (6): ASoC: qdsp6: q6afe: Add missing slimbus capture ports ASoC: qdsp6: q6afe-dai: add support to slim tx dais ASoC: qdsp6: q6routing: add slim rx routings ASoC: qdsp6: q6afe-dai: Do not overwrite slim dai num_channels ASoC: qdsp6: q6afe-dai: do not close port if

[PATCH 6/6] ASoC: qdsp6: q6asm-dai: do not close port if its not opened

2018-07-04 Thread Srinivas Kandagatla
asm ports are open as part of prepare, so for use cases like "aplay sample.wav" were sample.wav is not present. This would call port close eventhough port was never opened. DSP would return errors for such use cases. Avoid doing this by checking the port state. Signed-off-by: Srinivas

[PATCH 5/6] ASoC: qdsp6: q6afe-dai: do not close port if its not opened

2018-07-04 Thread Srinivas Kandagatla
afe ports are open as part of prepare, so for use cases like "aplay sample.wav" were sample.wav is not present. This would call port close eventhough port was never opened. DSP would return errors for such use cases. Avoid doing this by checking the port state. Signed-off-by: Srinivas

[PATCH 3/6] ASoC: qdsp6: q6routing: add slim rx routings

2018-07-04 Thread Srinivas Kandagatla
This patch add routings mixer controls for slim rx ports. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6routing.c | 28 1 file changed, 28 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index

[PATCH 2/6] ASoC: qdsp6: q6afe-dai: add support to slim tx dais

2018-07-04 Thread Srinivas Kandagatla
This patch adds support to SLIMbus TX dais in AFE module. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 175 +++ 1 file changed, 161 insertions(+), 14 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom

[PATCH 1/6] ASoC: qdsp6: q6afe: Add missing slimbus capture ports

2018-07-04 Thread Srinivas Kandagatla
Existing code already has support for SLIMbus TX and RX, only thing that was missing from TX side was mapping between virtual to actual DSP port ids. This patch adds those mappings. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe.c | 21 + 1 file changed

[PATCH 4/6] ASoC: qdsp6: q6afe-dai: Do not overwrite slim dai num_channels

2018-07-04 Thread Srinivas Kandagatla
num_channels for slim dais are aready set int set_channel_map, do not overwrite them in hw_params. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c index

[PATCH] regmap: slimbus: add support to raw read/writes

2018-07-05 Thread Srinivas Kandagatla
SLIMbus supports upto 16 bytes in value management messages, so add support to raw read/writes upto 16 bytes. Also useful for paged register access on SLIMbus interfaced codecs. Signed-off-by: Srinivas Kandagatla --- drivers/base/regmap/regmap-slimbus.c | 23 +-- 1 file

[PATCH v2 0/2] slimbus: Add Stream Support

2018-07-05 Thread Srinivas Kandagatla
et/Articles/758100/): - removed redundant state machine checks for audio usecases, suggested by Vinod. - fixed few typos. - removed irqsave/restore spinlock variant spotted by Vinod. - general cleanups suggested by Stephen and Vinod. thanks, srini Srinivas Kandagatla (2):

[PATCH v2 1/2] slimbus: stream: add stream support

2018-07-05 Thread Srinivas Kandagatla
pis. Currently it only supports Isochronous and Push/Pull transport protocols, which are sufficient for audio use cases. Signed-off-by: Srinivas Kandagatla --- Documentation/driver-api/slimbus.rst | 5 + drivers/slimbus/Makefile | 2 +- drivers/slimbus/core.c |

[PATCH v2 2/2] slimbus: ngd: add stream support

2018-07-05 Thread Srinivas Kandagatla
This patch adds support to stream support, this involve implementing user specific implementation of Data channel management and channel management SLIMbus messages. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 149 +++- 1 file

Re: [PATCH] regmap: slimbus: add support to raw read/writes

2018-07-05 Thread Srinivas Kandagatla
On 05/07/18 16:08, Mark Brown wrote: On Thu, Jul 05, 2018 at 12:37:00PM +0100, Srinivas Kandagatla wrote: SLIMbus supports upto 16 bytes in value management messages, so add support to raw read/writes upto 16 bytes. That's not what raw access is. It's unmediated access t

Re: [PATCH] regmap: slimbus: add support to raw read/writes

2018-07-05 Thread Srinivas Kandagatla
On 05/07/18 17:50, Mark Brown wrote: On Thu, Jul 05, 2018 at 05:13:21PM +0100, Srinivas Kandagatla wrote: All am trying to do is support paged registers, which seems to be only possible via read/write support at bus level. Could you explain what you mean by paged registers? There&#

Re: [PATCH] regmap: slimbus: add support to raw read/writes

2018-07-05 Thread Srinivas Kandagatla
On 05/07/18 18:30, Mark Brown wrote: On Thu, Jul 05, 2018 at 06:20:50PM +0100, Srinivas Kandagatla wrote: Access to codec registers is done in 2 steps. 1> Write page number in page register. 2> access register within the page. This seems to exactly what struct regmap_range_cfg

[PATCH v2] regmap: slimbus: add support to multi read/write

2018-07-06 Thread Srinivas Kandagatla
SLIMbus supports upto 16 bytes in value management messages, so add support to read/writes upto 16 bytes. This also removes redundant single register reg_read/reg_write. Also useful for paged register access on SLIMbus interfaced codecs. Signed-off-by: Srinivas Kandagatla --- drivers/base

Re: [PATCH v3 4/5] ASoC: dt-bindings: Update dt binding name for apq8096

2018-07-06 Thread Srinivas Kandagatla
insertions(+), 2 deletions(-) Acked-by: Srinivas Kandagatla

Re: [PATCH v3 2/5] ASoC: qcom: Add support to parse common audio device nodes

2018-07-06 Thread Srinivas Kandagatla
r snd card module auto-loading! Also patch 5/5 can go with this. Other than that it looks good. Once these 2 fixed you can add my Ack Acked-by: Srinivas Kandagatla --srini create mode 100644 sound/soc/qcom/common.h

[PATCH] arm64: dts: apq8096-db820c: disable uart0 by default

2018-06-12 Thread Srinivas Kandagatla
Access to UART0 is disabled by bootloaders. By leaving it enabled by default would reboot the board. Disable this for now, this would alteast give a board which boots. Signed-off-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-12 Thread Srinivas Kandagatla
GICR_WAKER can be a secured register, check this before accessing it as its done in power management code. Without this patch Qualcomm DB820c board crashes. Signed-off-by: Srinivas Kandagatla --- drivers/irqchip/irq-gic-v3.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions

Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-12 Thread Srinivas Kandagatla
On 12/06/18 16:24, Sudeep Holla wrote: On Tue, Jun 12, 2018 at 3:55 PM, Srinivas Kandagatla wrote: GICR_WAKER can be a secured register, check this before accessing it as its done in power management code. Without this patch Qualcomm DB820c board crashes. Are you sure this is the one

Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-13 Thread Srinivas Kandagatla
On 12/06/18 17:34, Marc Zyngier wrote: I suggest you find out how the GIC has been integrated on this platform. If you take a fault on accessing this register, this very much looks like an integration bug, and it should be quirked as such. Thanks for the suggestion, This is a bug in the firmwa

Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-13 Thread Srinivas Kandagatla
On 13/06/18 09:45, Sudeep Holla wrote: On Wed, Jun 13, 2018 at 9:21 AM, Srinivas Kandagatla wrote: On 12/06/18 17:34, Marc Zyngier wrote: I suggest you find out how the GIC has been integrated on this platform. If you take a fault on accessing this register, this very much looks like an

[RFC PATCH] irqchip/gic-v3: Add quirk for msm8996 secured registers

2018-06-13 Thread Srinivas Kandagatla
based on MSM8996. Without this patch Qualcomm DB820c board reboots when GICR_WAKER is written to. Signed-off-by: Srinivas Kandagatla --- drivers/irqchip/irq-gic-v3.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers

Re: [PATCH v3 17/27] bindings: nvmem/zii: Fix location of nvmem.txt

2018-06-14 Thread Srinivas Kandagatla
On 14/06/18 17:09, Mauro Carvalho Chehab wrote: The location pointed there is missing "bindings/" on its path. Signed-off-by: Mauro Carvalho Chehab Acked-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt | 2 +- 1 file changed, 1

Re: [RFC PATCH] irqchip/gic-v3: Add quirk for msm8996 secured registers

2018-06-14 Thread Srinivas Kandagatla
Thanks for the review! On 13/06/18 13:59, Marc Zyngier wrote: On 13/06/18 12:43, Srinivas Kandagatla wrote: Access to GICR_WAKER is restricted on msm8996 SoC. Its been more Restricted by what? Firmware? Hypervisor? (most likely the later). Yes, its the Hypervisor (TZ firmware) than 2

<    1   2   3   4   5   6   7   8   9   10   >