Re: [PATCH v5 10/11] nvmem: sunxi: Move the SID driver to the nvmem framework

2015-06-18 Thread Srinivas Kandagatla
On 17/06/15 00:04, Stephen Boyd wrote: On 05/21/2015 09:45 AM, Srinivas Kandagatla wrote: diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile index caea611..cc46791 100644 --- a/drivers/nvmem/Makefile +++ b/drivers/nvmem/Makefile @@ -9,3 +9,5 @@ nvmem_core-y

Re: [PATCH v5 08/11] nvmem: qfprom: Add Qualcomm QFPROM support.

2015-06-18 Thread Srinivas Kandagatla
On 17/06/15 00:00, Stephen Boyd wrote: On 05/21/2015 09:44 AM, Srinivas Kandagatla wrote: diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index f157b6d..e665e23 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig @@ -8,3 +8,18 @@ menuconfig NVMEM from both the

Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

2015-06-18 Thread Srinivas Kandagatla
Hi Sagar, On 14/06/15 06:49, Sagar Dharia wrote: SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI (Mobile Industry Processor Interface) alliance. SLIMbus is a 2-wire implementation, which is used to communicate with peripheral components like audio-codec. SLIMb

Re: [PATCH V2 1/6] SLIMbus: Device management on SLIMbus

2015-06-18 Thread Srinivas Kandagatla
On 17/06/15 02:45, Sagar Dharia wrote: SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI (Mobile Industry Processor Interface) alliance. SLIMbus is a 2-wire implementation, which is used to communicate with peripheral components like audio-codec. SLIMbus uses T

Re: [PATCH v5 06/11] nvmem: Add bindings for simple nvmem framework

2015-06-19 Thread Srinivas Kandagatla
On 19/06/15 11:36, maitysancha...@gmail.com wrote: Hello Srinivas, On 15-05-21 17:44:12, Srinivas Kandagatla wrote: This patch adds bindings for simple nvmem framework which allows nvmem consumers to talk to nvmem providers to get access to nvmem cell data. Signed-off-by: Maxime Ripard

Re: [RESEND PATCH] PCI: qcom: add runtime pm support to pcie_port

2018-05-23 Thread Srinivas Kandagatla
On 23/05/18 07:15, Vinod wrote: On 18-05-18, 00:07, Bjorn Andersson wrote: diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c index 5897af7d3355..3f35098b71b1 100644 --- a/drivers/pci/dwc/pcie-qcom.c +++ b/drivers/pci/dwc/pcie-qcom.c @@ -1088,6 +1088,8 @@ static int qcom_p

[PATCH v2] PCI: qcom: add runtime pm support to pcie_port

2018-05-23 Thread Srinivas Kandagatla
power domain associated with the bus driver. Signed-off-by: Srinivas Kandagatla Signed-off-by: Bjorn Andersson --- drivers/pci/dwc/pcie-qcom.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c index 5897af7d3355

Re: [PATCH -next] slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew()

2018-05-23 Thread Srinivas Kandagatla
On 22/05/18 12:46, Wei Yongjun wrote: platform_get_resource() may fail and return NULL, so we should better check it's return value to avoid a NULL pointer dereference a bit later in the code. This is detected by Coccinelle semantic patch. @@ expression pdev, res, n, t, e, e1, e2; @@ res = p

Re: [PATCH 1/2] slimbus: ngd: dt-bindings: Add slim ngd dt bindings

2018-05-23 Thread Srinivas Kandagatla
Thanks Rob for review, On 23/05/18 17:40, Rob Herring wrote: On Wed, May 16, 2018 at 05:51:17PM +0100, Srinivas Kandagatla wrote: This patch adds bindings for Qualcomm SLIMBus NGD controller found in all new SoCs starting from B family. SLIMBus NGD controller is a light-weight driver

Re: [PATCH 1/2] slimbus: ngd: dt-bindings: Add slim ngd dt bindings

2018-05-23 Thread Srinivas Kandagatla
On 23/05/18 17:40, Rob Herring wrote: + +- qcom,ngd-id + Usage: required + Value type: + Definition: ngd instance id in the controller Why do you need this? Please ignore my comment from previous reply. There are more than one instances of ngd in this slim controller. We

Re: [PATCH 1/2] slimbus: ngd: dt-bindings: Add slim ngd dt bindings

2018-05-23 Thread Srinivas Kandagatla
On 23/05/18 20:28, Rob Herring wrote: On Wed, May 23, 2018 at 1:11 PM, Srinivas Kandagatla wrote: On 23/05/18 17:40, Rob Herring wrote: + +- qcom,ngd-id + Usage: required + Value type: + Definition: ngd instance id in the controller Why do you need this? Please

Re: [PATCH v3 01/25] dt-bindings: soc: qcom: Add bindings for APR bus

2018-02-28 Thread Srinivas Kandagatla
On 22/02/18 10:03, Srinivas Kandagatla wrote: Also the versions of each service are independent to each other. Not sure I follow the last statement. Meaning firmware updates change the services? Sorry for not being clear, so the services like AFE, ASM, ADM have different version numbers for

Re: [PATCH v6 04/24] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings

2018-04-27 Thread Srinivas Kandagatla
Thanks for the review. On 27/04/18 15:13, Rob Herring wrote: On Thu, Apr 26, 2018 at 10:45:46AM +0100, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch add DT bindings for AFE (Audio Frontend) DSP module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by

Re: [PATCH v6 04/24] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings

2018-04-27 Thread Srinivas Kandagatla
On 27/04/18 19:32, Rob Herring wrote: + += AFE DAIs (Digial Audio Interface) +"dais" subnode of the AFE node represents dai specific configuration + +- #sound-dai-cells + Usage: required + Value type: + Definition: Must be 1 + +- reg It's not clear here these are in a grand

Re: [PATCH v6 02/24] soc: qcom: Add APR bus driver

2018-04-28 Thread Srinivas Kandagatla
Thanks Bjorn for the review comments. On 28/04/18 05:51, Bjorn Andersson wrote: On Thu 26 Apr 02:45 PDT 2018, Srinivas Kandagatla wrote: diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c [..] +int apr_send_pkt(struct apr_device *adev, void *buf) Sorry, but I think we have

[PATCH v7 00/24] ASoC: qcom: Add support to QDSP based Audio

2018-05-01 Thread Srinivas Kandagatla
kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/?h=for-next Srinivas Kandagatla (24): soc: qcom dt-bindings: Add APR bus bindings soc: qcom: Add APR bus driver ASoC: qdsp6: dt-bindings: Add q6core dt bindings ASoC: qdsp6: dt-bindings: Add q6afe dt bindings ASoC: qdsp6: dt-binding

[PATCH v7 04/24] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings

2018-05-01 Thread Srinivas Kandagatla
This patch add DT bindings for AFE (Audio Frontend) DSP module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,q6afe.txt | 104 + include/dt-bindings/sound/qcom,q6afe.h | 31 ++ 2 files

[PATCH v7 15/24] ASoC: qdsp6: q6asm: Add support to memory map and unmap

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to memory map and unmap regions commands in q6asm module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6asm.c | 349 +++ sound/soc/qcom/qdsp6/q6asm.h | 5 + 2 files changed

[PATCH v7 24/24] MAINTAINERS: Add myself as co-maintainer of qcom audio

2018-05-01 Thread Srinivas Kandagatla
Add myself as co-maintainer of qcom audio drivers Signed-off-by: Srinivas Kandagatla --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4340b783ab80..527e2658cfe4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11531,6 +11531,7 @@ F: drivers

[PATCH v7 23/24] ASoC: qcom: apq8096: Add db820c machine driver

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to DB820c machine driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 9 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/apq8096.c | 238 +++ 3 files changed, 249 insertions(+) create mode 100644

[PATCH v7 13/24] ASoC: qdsp6: q6adm: Add q6adm driver

2018-05-01 Thread Srinivas Kandagatla
dynamic COPP services for device-related audio processing as needed. This patch adds basic support to ADM. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig| 4 + sound/soc/qcom/qdsp6/Makefile | 1 + sound/soc/qcom/qdsp6/q6adm.c | 636

[PATCH v7 22/24] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-05-01 Thread Srinivas Kandagatla
Add devicetree bindings documentation file for Qualcomm apq8096 sound card. Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../devicetree/bindings/sound/qcom,apq8096.txt | 109 + 1 file changed, 109 insertions(+) create mode 100644 Documentation

[PATCH v7 21/24] ASoC: qdsp6: q6asm: Add q6asm dai driver

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to q6asm dai driver which configures Q6ASM streams to pass pcm data. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig | 4 + sound/soc/qcom/qdsp6/Makefile| 1 + sound/soc/qcom/qdsp6/q6asm-dai.c | 628

[PATCH v7 19/24] ASoC: qdsp6: q6routing: Add support to MI2S Mixers

2018-05-01 Thread Srinivas Kandagatla
This patch add support to MI2S mixers required to select path between ASM stream and AFE ports. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6routing.c | 329 +++ 1 file changed, 329 insertions(+) diff

[PATCH v7 14/24] ASoC: qdsp6: q6asm: Add q6asm driver

2018-05-01 Thread Srinivas Kandagatla
also provides POPP dynamic services. This patch adds support to basic features to allow hdmi playback. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig| 4 + sound/soc/qcom/qdsp6/Makefile | 1 + sound/soc/qcom/qdsp6/q6asm.c | 215

[PATCH v7 18/24] ASoC: qdsp6: q6routing: Add support to all SLIMBus Mixers

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to SLIMBus related mixers to control mux between ASM stream and AFE port. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6routing.c | 261 +++ 1 file changed, 261 insertions(+) diff

[PATCH v7 20/24] ASoC: qdsp6: q6afe: Add q6afe dai driver

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to q6afe backend dais driver. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig | 4 + sound/soc/qcom/qdsp6/Makefile| 1 + sound/soc/qcom/qdsp6/q6afe-dai.c | 752 +++ 3

[PATCH v7 17/24] ASoC: qdsp6: q6routing: Add q6routing driver

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to q6 routing driver which configures route between ASM and AFE module using ADM apis. This driver uses dapm widgets to setup the matrix between AFE ports and ASM streams. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig

[PATCH v7 16/24] ASoC: qdsp6: q6asm: Add support to audio stream apis

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to open, write and media format commands in the q6asm module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6asm.c | 839 ++- sound/soc/qcom/qdsp6/q6asm.h | 49 +++ 2 files

[PATCH v7 12/24] ASoC: qdsp6: q6afe: Add support to MI2S sysclks

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to LPASS Bit clock, LPASS Digital core clock and OSR clock. These clocks are required for both MI2S and PCM setup. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6afe.c | 171

[PATCH v7 02/24] soc: qcom: Add APR bus driver

2018-05-01 Thread Srinivas Kandagatla
services on QDSP like Audio and others. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar Acked-by: Andy Gross --- drivers/soc/qcom/Kconfig| 9 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/apr.c | 378

[PATCH v7 11/24] ASoC: qdsp6: q6afe: Add support to MI2S ports

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to 4 MI2S ports on LPASS. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6afe.c | 224 +++ sound/soc/qcom/qdsp6/q6afe.h | 13 +++ 2 files changed, 237 insertions(+) diff --git a

[PATCH v7 10/24] ASoC: qdsp6: qdafe: Add SLIMBus port Support

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to 6 SLIMBus AFE ports, which are used as backend dais. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6afe.c | 129 +++ sound/soc/qcom/qdsp6/q6afe.h | 14 + 2 files changed

[PATCH v7 09/24] ASoC: qdsp6: q6afe: Add q6afe driver

2018-05-01 Thread Srinivas Kandagatla
hardware devices like codec, hdmi, slimbus, i2s and so on. AFE services include starting, stopping, and if needed, any configurations of the ports. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig| 4 + sound/soc/qcom/qdsp6/Makefile | 1

[PATCH v7 03/24] ASoC: qdsp6: dt-bindings: Add q6core dt bindings

2018-05-01 Thread Srinivas Kandagatla
This patch add DT bindings for Q6CORE DSP module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar Reviewed-by: Rob Herring --- .../devicetree/bindings/sound/qcom,q6core.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644

[PATCH v7 07/24] ASoC: qdsp6: q6common: Add qdsp6 helper functions

2018-05-01 Thread Srinivas Kandagatla
This patch adds some common helper functions like translating dsp error to linux error codes and channel mappings etc. These functions are used in all the following qdsp6 drivers. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig

[PATCH v7 06/24] ASoC: qdsp6: dt-bindings: Add q6asm dt bindings

2018-05-01 Thread Srinivas Kandagatla
This patch add DT bindings for ASM (Audio Stream Manager) DSP module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar Reviewed-by: Rob Herring --- .../devicetree/bindings/sound/qcom,q6asm.txt | 33 ++ include/dt-bindings/sound/qcom,q6asm.h

[PATCH v7 08/24] ASoC: qdsp6: q6core: Add q6core driver

2018-05-01 Thread Srinivas Kandagatla
This patch adds support to core apr service, which is used to query status of other static and dynamic services on the dsp. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig| 4 + sound/soc/qcom/qdsp6/Makefile | 1 + sound/soc/qcom

[PATCH v7 05/24] ASoC: qdsp6: dt-bindings: Add q6adm dt bindings

2018-05-01 Thread Srinivas Kandagatla
This patch add DT bindings for ADM (Audio Device Manager) DSP module. This module implements mixer controls to setup the connections between AFE ports and ASM streams. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar Reviewed-by: Rob Herring --- .../devicetree/bindings

[PATCH v7 01/24] soc: qcom dt-bindings: Add APR bus bindings

2018-05-01 Thread Srinivas Kandagatla
This patch add dt bindings for Qualcomm APR (Asynchronous Packet Router) bus driver. This bus is used for communicating with DSP which provides audio and various other services to cpu. Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../devicetree/bindings/soc/qcom/qcom,apr.txt

Re: [PATCH v3 2/2] nvmem: Add RAVE SP EEPROM driver

2018-05-01 Thread Srinivas Kandagatla
On 01/05/18 06:29, Andrey Smirnov wrote: +// SPDX-License-Identifier: GPL-2.0+ ... +MODULE_LICENSE("GPL"); I think this should be MODULE_LICENSE("GPL v2"); --srini

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-05-01 Thread Srinivas Kandagatla
On 18/04/18 14:34, Alban wrote: On Wed, 18 Apr 2018 13:53:56 +0100 Srinivas Kandagatla wrote: On 18/04/18 13:32, Alban wrote: I was also suggesting you to use nvmem-cell subnode, but make it a proper nvmem provider device, rather than reusing its parent device. You would end up some thing

Re: [PATCH v3 2/2] nvmem: Add RAVE SP EEPROM driver

2018-05-02 Thread Srinivas Kandagatla
On 01/05/18 19:35, Andrey Smirnov wrote: On Tue, May 1, 2018 at 8:33 AM, Srinivas Kandagatla wrote: On 01/05/18 06:29, Andrey Smirnov wrote: +// SPDX-License-Identifier: GPL-2.0+ ... +MODULE_LICENSE("GPL"); I think this should be MODULE_LICENSE("GPL v2"); With

[PATCH 0/6] ASoC: qdsp6: Add support to TDM ports

2018-05-29 Thread Srinivas Kandagatla
-bindings, afe port prepare support in afe, afe-dais support and adding tdm routing update. These patches have been tested by Rohit on SDM845. Thanks, Srini Srinivas Kandagatla (6): ASoC: qdsp6: dt-bindings: Add q6afe tdm dt binding ASoC: qdsp6: qdafe: add support to tdm ports ASoC: qdsp6

[PATCH 5/6] ASoC: qdsp6: q6routing: Add macros for mixers

2018-05-29 Thread Srinivas Kandagatla
40 tdm dais. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6routing.c | 631 ++- 1 file changed, 97 insertions(+), 534 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index 08c25c26adf4..a4e74cac491b

[PATCH 4/6] ASoC: qdsp6: q6afe-dai: add support to tdm dais

2018-05-29 Thread Srinivas Kandagatla
This patch adds support to 40 TDM ports supported in AFE. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 574 ++- 1 file changed, 573 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6

[PATCH 6/6] ASoC: qdsp6: q6routing: Add support to all TDM Mixers

2018-05-29 Thread Srinivas Kandagatla
This patch adds TX and RX TDM mixers for 40 TDM ports. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6routing.c | 455 ++- 1 file changed, 454 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6

[PATCH 1/6] ASoC: qdsp6: dt-bindings: Add q6afe tdm dt binding

2018-05-29 Thread Srinivas Kandagatla
This patch adds bindings required for TDM ports on AFE. Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/sound/qcom,q6afe.txt | 68 ++ include/dt-bindings/sound/qcom,q6afe.h | 80 ++ 2 files changed, 148 insertions(+) diff

[PATCH 2/6] ASoC: qdsp6: qdafe: add support to tdm ports

2018-05-29 Thread Srinivas Kandagatla
This patch adds support to tdm ports in AFE. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe.c | 429 ++- sound/soc/qcom/qdsp6/q6afe.h | 20 +- 2 files changed, 447 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/qdsp6

[PATCH 3/6] ASoC: qdsp6: q6afe-dai: use q6afe_dai_prepare() for MI2S

2018-05-29 Thread Srinivas Kandagatla
Use common q6afe_dai_prepare() for MI2S dais, this will remove some code duplication. Also make the if statement to switch to make the code look neater. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 53 ++-- 1 file changed, 18

Re: [PATCH] rpmsg: smd: do not use mananged resources for endpoints and channels

2018-06-04 Thread Srinivas Kandagatla
On 04/06/18 01:49, Bjorn Andersson wrote: On Fri 01 Jun 16:32 PDT 2018, Srinivas Kandagatla wrote: @@ -1380,11 +1380,13 @@ static void qcom_smd_edge_release(struct device *dev) { struct qcom_smd_channel *channel; struct qcom_smd_edge *edge = to_smd_edge(dev); + struct

[PATCH v2] rpmsg: smd: do not use mananged resources for endpoints and channels

2018-06-04 Thread Srinivas Kandagatla
kzalloc for allocating channel->name and channel which is then freed in qcom_smd_edge_release(). Without this patch restarting a remoteproc would crash the system. Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend") Cc: Signed-off-by: Srinivas Kandagatla --- drivers/rpmsg/qc

Re: [PATCH] ASoC: dapm: delete dapm_kcontrol_data paths entry before freeing

2018-06-04 Thread Srinivas Kandagatla
On 04/06/18 11:45, Mark Brown wrote: On Fri, Jun 01, 2018 at 11:53:34PM +0100, Srinivas Kandagatla wrote: Below is the kernel BUG with SLAB Poisoning = BUG kmalloc-128 (Tainted: GW): Poison

[PATCH v2] ASoC: dapm: delete dapm_kcontrol_data paths list before freeing it

2018-06-04 Thread Srinivas Kandagatla
enabled build, kernel crashes with "BUG kmalloc-128 (Tainted: GW): Poison overwritten" Signed-off-by: Srinivas Kandagatla --- Changes since v1: -remove unnecessary very long bug trace. sound/soc/soc-dapm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sou

Re: [PATCH v2] of: platform: stop accessing invalid dev in of_platform_device_destroy

2018-06-04 Thread Srinivas Kandagatla
On 04/06/18 14:44, Rob Herring wrote: On Fri, Jun 1, 2018 at 7:03 PM, Srinivas Kandagatla wrote: Immediately after the platform_device_unregister() the device will be cleaned up. Accessing the freed pointer immediately after that will crash the system. Found this bug when kernel is built

[PATCH v3] of: platform: stop accessing invalid dev in of_platform_device_destroy

2018-06-04 Thread Srinivas Kandagatla
+0x30/0x34 Code: d2800022 8b400c21 f9800031 9ac32043 (c85f7c22) ---[ end trace 32020935775616a2 ]--- Signed-off-by: Srinivas Kandagatla --- Changes since v2: Move the calls to of_node_clear_flag just before unregister, suggested by Rob. drivers/of/platform.c | 5 +++-- 1 file changed, 3

Re: [PATCH] ASoC: qcom: apq8096: set card as device drvdata

2018-06-06 Thread Srinivas Kandagatla
On 06/06/18 09:55, Rohit kumar wrote: snd_soc_card is retrieved as device drvdata during unbind(). Set it as drvdata during bind() to avoid memory corruption during unbind(). Signed-off-by: Rohit kumar Thanks for the patch, Acked-by: Srinivas Kandagatla --- sound/soc/qcom/apq8096.c

Re: [PATCH] nvmem: Don't let a NULL cell_id for nvmem_cell_get() crash us

2018-05-16 Thread Srinivas Kandagatla
l fix. Fixes: ca04d9d3e1b1 ("phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips") Signed-off-by: Douglas Anderson --- drivers/nvmem/core.c | 4 1 file changed, 4 insertions(+) Looks good to me, Kishon if you want to queue this one from your tree, you can add my Acked-by:

[PATCH 5/7] slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy

2018-05-16 Thread Srinivas Kandagatla
There seems to be a multiple calls to pm_runtime_mark_last_busy(), which looks like a typo. Fix this by properly adding pm_runtime_put_autosuspend to put controller in auto suspend state. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion

[PATCH 7/7] slimbus: messaging: initialize completion correctly

2018-05-16 Thread Srinivas Kandagatla
slim_val_inf can contain random value from stack, make sure the completion is initialized to NULL while filling the msg. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus

[PATCH 0/7] slimbus: fixes and some helpers

2018-05-16 Thread Srinivas Kandagatla
Hi Greg, Here is set of patches for slimbus, there are 5 fixes and two helper functions. Most of these issues were found while testing QCOM NGD SLIMBus controller with WCD9335 codec. thanks, Srini Srinivas Kandagatla (7): slimbus: core: add of_slim_device_get() helper slimbus: core

[PATCH 6/7] slimbus: messaging: add slim_prepare_txn() helper function

2018-05-16 Thread Srinivas Kandagatla
This patch adds slim_prepare_txn() to allow controllers to prepare controller specific transaction. If not each controllers will duplicate the same code from core. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 89 ++--- drivers

[PATCH 4/7] slimbus: messaging: pass correct wbuf

2018-05-16 Thread Srinivas Kandagatla
There seems to be a typo while filling msg for slim_write, wbuf is set to NULL instead of rbuf. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index

[PATCH 2/7] slimbus: core: rearrange slim_eaddr structure

2018-05-16 Thread Srinivas Kandagatla
Rearrange struct slim_eaddr so that the structure is packed correctly to be able to send in SLIMBus messages. Signed-off-by: Srinivas Kandagatla --- include/linux/slimbus.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/slimbus.h b/include/linux

[PATCH 3/7] slimbus: core: add need_tid flag to slim_msg_txn

2018-05-16 Thread Srinivas Kandagatla
Add need_tid flag to txn, this flag can be set before start of transcation. Having this flag would avoid calling slim_tid_txn() multiple times on the same txn. Also it is handy for controller drivers too. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/slimbus.h | 1 + 1 file changed, 1

[PATCH 1/7] slimbus: core: add of_slim_device_get() helper

2018-05-16 Thread Srinivas Kandagatla
. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 39 +++ include/linux/slimbus.h | 2 ++ 2 files changed, 41 insertions(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 7ddfc675b131..88248a4ecad9 100644 --- a/drivers/slimbus

[PATCH 0/2] slimbus: Add QCOM SLIMBus NGD driver

2018-05-16 Thread Srinivas Kandagatla
component residing on ADSP for bandwidth and data-channel management. Tested this patchset on DB820c with WCD9335 codec. I have pushed my working branch to [1] incase someone want to try. Thanks, srini [1] https://git.linaro.org/people/srinivas.kandagatla/linux.git/log/?h=slimbus-ngd Srinivas

[PATCH 1/2] slimbus: ngd: dt-bindings: Add slim ngd dt bindings

2018-05-16 Thread Srinivas Kandagatla
residing on ADSP for bandwidth and data-channel management Signed-off-by: Srinivas Kandagatla --- .../bindings/slimbus/slim-ngd-qcom-ctrl.txt| 70 ++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/slimbus/slim-ngd-qcom-ctrl.txt diff

[PATCH 2/2] slimbus: ngd: Add qcom SLIMBus NGD driver

2018-05-16 Thread Srinivas Kandagatla
and data-channel management Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 10 + drivers/slimbus/Makefile|3 + drivers/slimbus/qcom-ngd-ctrl.c | 1298 +++ drivers/slimbus/slimbus.h |8 + 4 files changed, 1319

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-24 Thread Srinivas Kandagatla
Thanks for the review. On 24/04/18 17:25, Rob Herring wrote: On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla Add devicetree bindings documentation file for Qualcomm apq8096 sound card. Signed-off-by: Srinivas Kandagatla

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-25 Thread Srinivas Kandagatla
On 25/04/18 16:04, Rob Herring wrote: I can list the values for the HDMI playback use-case, but the list would grow as we start adding wcd9335 codec support. If you don't have the values, then how does one validate a DT is correct? I can list all the sources and sinks wired on the board in n

[PATCH v6 10/24] ASoC: qdsp6: qdafe: Add SLIMBus port Support

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to 6 SLIMBus AFE ports, which are used as backend dais. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6afe.c | 129 +++ sound/soc/qcom/qdsp6/q6afe.h

[PATCH v6 03/24] ASoC: qdsp6: dt-bindings: Add q6core dt bindings

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch add DT bindings for Q6CORE DSP module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,q6core.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644

[PATCH v6 02/24] soc: qcom: Add APR bus driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support toi APR bus (Asynchronous Packet Router) driver. ARP driver is made as a bus driver so that the apr devices can added removed more dynamically depending on the state of the services on the dsp. APR is used for communication between application

[PATCH v6 00/24] ASoC: qcom: Add support to QDSP based Audio

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla Thankyou everyone for providing feedback and testing v5 patchset. This patchset aims to provide a basic version of QCOM DSP based audio support which is available in downstream andriod kernels. This patchset support audio playback on HDMI-RX, MI2S, SLIMBus and will add

[PATCH v6 09/24] ASoC: qdsp6: q6afe: Add q6afe driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to Q6AFE (Audio Front End) module on Q6DSP. AFE module sits right at the other end of cpu where the codec/audio devices are connected. AFE provides abstraced interfaces to both hardware and virtual devices. Each AFE tx/rx port can be configured

[PATCH v6 11/24] ASoC: qdsp6: q6afe: Add support to MI2S ports

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to 4 MI2S ports on LPASS. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6afe.c | 228 +++ sound/soc/qcom/qdsp6/q6afe.h | 13 +++ 2 files changed, 241

[PATCH v6 21/24] ASoC: qdsp6: q6asm: Add q6asm dai driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to q6asm dai driver which configures Q6ASM streams to pass pcm data. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig | 4 + sound/soc/qcom/qdsp6/Makefile| 1 + sound/soc/qcom

[PATCH v6 24/24] MAINTAINERS: Add myself as co-maintainer of qcom audio

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla Add myself as co-maintainer of qcom audio drivers Signed-off-by: Srinivas Kandagatla --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index dd66ae9a847e..8a67b0c61bad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11531,6

[PATCH v6 20/24] ASoC: qdsp6: q6afe: Add q6afe dai driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to q6afe backend dais driver. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig | 4 + sound/soc/qcom/qdsp6/Makefile| 1 + sound/soc/qcom/qdsp6/q6afe-dai.c | 752

[PATCH v6 19/24] ASoC: qdsp6: q6routing: Add support to MI2S Mixers

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch add support to MI2S mixers required to select path between ASM stream and AFE ports. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6routing.c | 329 +++ 1 file changed

[PATCH v6 17/24] ASoC: qdsp6: q6routing: Add q6routing driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to q6 routing driver which configures route between ASM and AFE module using ADM apis. This driver uses dapm widgets to setup the matrix between AFE ports and ASM streams. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar

[PATCH v6 18/24] ASoC: qdsp6: q6routing: Add support to all SLIMBus Mixers

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to SLIMBus related mixers to control mux between ASM stream and AFE port. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6routing.c | 261 +++ 1 file

[PATCH v6 22/24] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla Add devicetree bindings documentation file for Qualcomm apq8096 sound card. Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/sound/qcom,apq8096.txt | 109 + 1 file changed, 109 insertions(+) create mode 100644 Documentation

[PATCH v6 14/24] ASoC: qdsp6: q6asm: Add q6asm driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds basic support to Q6 ASM (Audio Stream Manager) module on Q6DSP. ASM supports up to 8 concurrent streams. each stream can be setup as playback/capture. ASM provides top control functions like Pause/flush/resume for playback and record. ASM can Create

[PATCH v6 15/24] ASoC: qdsp6: q6asm: Add support to memory map and unmap

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to memory map and unmap regions commands in q6asm module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6asm.c | 340 +++ sound/soc/qcom/qdsp6/q6asm.h

[PATCH v6 23/24] ASoC: qcom: apq8096: Add db820c machine driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to DB820c machine driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 9 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/apq8096.c | 238 +++ 3 files changed, 249

[PATCH v6 12/24] ASoC: qdsp6: q6afe: Add support to MI2S sysclks

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to LPASS Bit clock, LPASS Digital core clock and OSR clock. These clocks are required for both MI2S and PCM setup. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6afe.c | 211

[PATCH v6 16/24] ASoC: qdsp6: q6asm: Add support to audio stream apis

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to open, write and media format commands in the q6asm module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6asm.c | 760 ++- sound/soc/qcom/qdsp6

[PATCH v6 13/24] ASoC: qdsp6: q6adm: Add q6adm driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to Q6ADM (Audio Device Manager) module in q6dsp. ADM performs routing between audio streams and AFE ports. It does Rate matching for streams going to devices driven by different clocks, it handles volume ramping, Mixing with channel and bit-width

[PATCH v6 04/24] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch add DT bindings for AFE (Audio Frontend) DSP module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,q6afe.txt | 88 ++ include/dt-bindings/sound/qcom,q6afe.h

[PATCH v6 07/24] ASoC: qdsp6: q6common: Add qdsp6 helper functions

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds some common helper functions like translating dsp error to linux error codes and channel mappings etc. These functions are used in all the following qdsp6 drivers. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc

[PATCH v6 06/24] ASoC: qdsp6: dt-bindings: Add q6asm dt bindings

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch add DT bindings for ASM (Audio Stream Manager) DSP module. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,q6asm.txt | 33 ++ include/dt-bindings/sound/qcom,q6asm.h

[PATCH v6 05/24] ASoC: qdsp6: dt-bindings: Add q6adm dt bindings

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch add DT bindings for ADM (Audio Device Manager) DSP module. This module implements mixer controls to setup the connections between AFE ports and ASM streams. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- .../devicetree/bindings

[PATCH v6 08/24] ASoC: qdsp6: q6core: Add q6core driver

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to core apr service, which is used to query status of other static and dynamic services on the dsp. Signed-off-by: Srinivas Kandagatla Reviewed-and-tested-by: Rohit kumar --- sound/soc/qcom/Kconfig| 4 + sound/soc/qcom/qdsp6

[PATCH v6 01/24] soc: qcom dt-bindings: Add APR bus bindings

2018-04-26 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch add dt bindings for Qualcomm APR (Asynchronous Packet Router) bus driver. This bus is used for communicating with DSP which provides audio and various other services to cpu. Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/soc/qcom/qcom

Re: [PATCH v6 02/24] soc: qcom: Add APR bus driver

2018-04-26 Thread Srinivas Kandagatla
On 26/04/18 12:39, Mark Brown wrote: On Thu, Apr 26, 2018 at 10:45:44AM +0100, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support toi APR bus (Asynchronous Packet Router) driver. ARP driver is made as a bus driver so that the apr devices can added

Re: [PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-16 Thread Srinivas Kandagatla
On 16/04/2019 10:34, Mika Westerberg wrote: On Tue, Apr 16, 2019 at 10:49:22AM +0530, Gaurav Kohli wrote: Hi Srinivas, Thanks for the patch, By default NVMEM_SYSFS should be set true, those whose don't want they can disable the same. If we go with disable option, there are chances of eeprom

[PATCH v2] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-16 Thread Srinivas Kandagatla
reboots. This patch adds new NVMEM_SYSFS Kconfig to make binary sysfs entry an optional one. This provision will give more flexibility to users. This patch also moves existing sysfs code to a new file so that its not compiled in when its not really required. Signed-off-by: Srinivas Kandagatla

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Srinivas Kandagatla
Hi Marc, On 13/03/2019 11:45, Marc Gonzalez wrote: We don't need to fudge the device class in qcom_pcie_rd_own_conf() because dw_pcie_setup_rc() already does the right thing: /* Program correct class for RC */ dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI);

<    4   5   6   7   8   9   10   11   12   13   >