On Thu, Nov 19, 2020 at 9:31 AM Matthew Wilcox wrote:
>
> On Thu, Nov 19, 2020 at 09:19:35AM -0500, Willem de Bruijn wrote:
> > But for epoll, this is inefficient: in ep_set_mstimeout it calls
> > ktime_get_ts64 to convert timeout to an offset from current time
On Thu, Nov 19, 2020 at 10:45 AM Arnd Bergmann wrote:
>
> On Thu, Nov 19, 2020 at 3:31 PM Matthew Wilcox wrote:
> >
> > On Thu, Nov 19, 2020 at 09:19:35AM -0500, Willem de Bruijn wrote:
> > > But for epoll, this is inefficient: in ep_set_mstimeout it calls
> > &g
On Fri, Nov 13, 2020 at 7:00 AM kernel test robot wrote:
>
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: 0b726f6b318a07644b6c2388e6e44406740f4754 ("[PATCH v3 net] net: udp:
> fix Fast/frag0 UDP GRO")
> url:
>
On Wed, Oct 21, 2020 at 8:00 AM Michael S. Tsirkin wrote:
>
> This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8.
>
> When control vq is not negotiated, that commit causes a crash:
>
> [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667!
> [ 72.230266] invalid opcode: [#1]
1172] Modules linked in:
> [ 72.269563] ---[ end trace a6ebc4afea0e6cb1 ]---
>
> The reason is that virtnet_set_features now calls virtnet_set_guest_offloads
> unconditionally, it used to only call it when there is something
> to configure.
>
> If device does not have a co
From: Willem de Bruijn
Resctrl takes an extra kernfs ref on directory entries, to access
the entry on cleanup in rdtgroup_kn_unlock after removing the entire
subtree with kfree_remove.
But the path takes an extra ref both on mkdir and on rmdir.
The kernfs_get on mkdir causes a memleak
From: Willem de Bruijn
The underlying hrtimer is programmed with nanosecond resolution.
Use cases such as datacenter networking operate on timescales well
below milliseconds. Setting shorter timeouts bounds tail latency.
Add epoll_create1 flag EPOLL_NSTIMEO. When passed, this changes
On Mon, Oct 26, 2020 at 12:24 PM Reinette Chatre
wrote:
>
> +Xiaochen
>
> Hi Willem,
>
> As you described in the report you sent directly to us there are indeed
> more issues than the one described here surrounding the kernfs node
> reference counting in resctrl. Xiao
On Mon, Oct 26, 2020 at 11:11 AM Aleksandr Nogikh
wrote:
>
> From: Aleksandr Nogikh
>
> Remote KCOV coverage collection enables coverage-guided fuzzing of the
> code that is not reachable during normal system call execution. It is
> especially helpful for fuzzing networking subsystems, where it
On Tue, Oct 27, 2020 at 8:31 AM Aleksandr Nogikh wrote:
>
> On Mon, Oct 26, 2020 at 7:57 PM Willem de Bruijn
> wrote:
> [...]
> > If the handle does not need to be set if zero, why then set it if the
> > skb has extensions?
>
> The point of that condition is to
On Thu, Oct 29, 2020 at 7:53 PM Xie He wrote:
>
> On Thu, Oct 29, 2020 at 10:24 AM Willem de Bruijn
> wrote:
> >
> > > Also add skb_reset_mac_header before we pass an skb (received on normal
> > > PVC devices) to upper layers. Because we don't use header_ops
On Thu, Oct 29, 2020 at 8:49 PM Xie He wrote:
>
> On Thu, Oct 29, 2020 at 4:53 PM Xie He wrote:
> >
> > > Does it make sense to define a struct snap_hdr instead of manually
> > > casting all these bytes?
> >
> > > And macros or constant integers to self document these kinds of fields.
> >
> >
uld not be visible to upper layer code when sending, so the header
> shouldn't be visible to upper layer code when receiving, either.
>
> Cc: Willem de Bruijn
> Cc: Krzysztof Halasa
> Signed-off-by: Xie He
Acked-by: Willem de Bruijn
Should this go to net if a bugfix though?
On Thu, Oct 29, 2020 at 10:33 PM Xie He wrote:
>
> 1.
> Change the skb->len check from "<= 4" to "< 4".
> At first we only need to ensure a 4-byte header is present. We indeed
> normally need the 5th byte, too, but it'd be more logical and cleaner
> to check its existence when we actually need
the fr_rx function, the code that parses the long (10-byte)
> header only recognizes a few Ethertype values and drops frames with other
> Ethertype values. This patch replaces this code to make fr_rx support
> any Ethertype. This patch also creates a new function fr_snap_parse as
> part o
On Thu, Oct 29, 2020 at 10:31 PM Xie He wrote:
>
> 1.
> When the fr_rx function drops a received frame (because the protocol type
> is not supported, or because the PVC virtual device that corresponds to
> the DLCI number and the protocol type doesn't exist), the function frees
> the skb and
On Fri, Oct 30, 2020 at 4:02 PM Xie He wrote:
>
> On Fri, Oct 30, 2020 at 9:35 AM Willem de Bruijn
> wrote:
> >
> > In general we try to avoid changing counter behavior like that, as
> > existing users
> > may depend on current behavior, e.g., in dashboards o
On Fri, Oct 30, 2020 at 3:21 PM Xie He wrote:
>
> On Fri, Oct 30, 2020 at 9:31 AM Willem de Bruijn
> wrote:
> >
> > > Add an fh->ea2 check to the initial checks in fr_rx. fh->ea2 == 1 means
> > > the second address byte is the final address byte. We only s
On Fri, Oct 30, 2020 at 3:29 PM Xie He wrote:
>
> On Fri, Oct 30, 2020 at 9:33 AM Willem de Bruijn
> wrote:
> >
> > Should this still check data[5] == FR_PAD?
>
> No, the 6th byte (data[5]) is not a padding field. It is the first
> byte of the SNAP header. T
On Fri, Oct 30, 2020 at 4:08 PM Xie He wrote:
>
> On Fri, Oct 30, 2020 at 9:30 AM Willem de Bruijn
> wrote:
> >
> > Acked-by: Willem de Bruijn
>
> Thanks for your ack!
>
> > Should this go to net if a bugfix though?
>
> Yes, this should theo
On Fri, Oct 30, 2020 at 5:49 PM Xie He wrote:
>
> On Fri, Oct 30, 2020 at 2:28 PM Willem de Bruijn
> wrote:
> >
> > Yes, it might require holding off the other patches until net is
> > merged into net-next.
> >
> > Packet sockets are likely not
On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin wrote:
>
> Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a support
> for fraglist UDP L4 and fraglist GSO not only for local traffic, but also
> for forwarding. This works well on simple setups, but when any logical
> netdev
On Fri, Oct 30, 2020 at 2:45 PM Xiaochen Shen wrote:
>
> Willem reported growing of kernfs_node_cache entries in slabtop when
> repeatedly creating and removing resctrl subdirectories as well as when
> repeatedly mounting and unmounting resctrl filesystem.
>
> On resource grou
On Fri, Nov 20, 2020 at 3:13 AM Arnd Bergmann wrote:
>
> On Thu, Nov 19, 2020 at 9:13 PM Willem de Bruijn
> wrote:
> > On Thu, Nov 19, 2020 at 10:45 AM Arnd Bergmann wrote:
> > > On Thu, Nov 19, 2020 at 3:31 PM Matthew Wilcox
> > > wrote:
> > > The ri
On Fri, Nov 20, 2020 at 2:23 PM Arnd Bergmann wrote:
>
> On Fri, Nov 20, 2020 at 5:01 PM Willem de Bruijn
> wrote:
> >
> > On Fri, Nov 20, 2020 at 3:13 AM Arnd Bergmann wrote:
> > >
> > > On Thu, Nov 19, 2020 at 9:13 PM Willem de Bruijn
> > >
From: Willem de Bruijn
Make epoll more consistent with select/poll: pass along the timeout as
timespec64 pointer.
In anticipation of additional changes affecting all three polling
mechanisms:
- add epoll_pwait2 syscall with timespec semantics,
and share poll_select_set_timeout implementation
From: Willem de Bruijn
Add syscall epoll_pwait2, an epoll_wait variant with nsec resolution
that replaces int timeout with struct timespec. It is equivalent
otherwise.
int epoll_pwait2(int fd, struct epoll_event *events,
int maxevents,
const struct
From: Willem de Bruijn
Code coverage for the epoll_pwait2 syscall.
epoll62: Repeat basic test epoll1, but exercising the new syscall.
epoll63: Pass a timespec and exercise the timeout wakeup path.
Changes
v4:
- fix sys_epoll_pwait2 to take __kernel_timespec (Arnd).
- fix sys_epoll_pwait2
From: Willem de Bruijn
Split off from prev patch in the series that implements the syscall.
Signed-off-by: Willem de Bruijn
---
arch/alpha/kernel/syscalls/syscall.tbl | 1 +
arch/arm/tools/syscall.tbl | 1 +
arch/arm64/include/asm/unistd.h | 2 +-
arch/arm64
From: Willem de Bruijn
Enable nanosecond timeouts for epoll.
Analogous to pselect and ppoll, introduce an epoll_wait syscall
variant that takes a struct timespec instead of int timeout.
See patch 2 for more details.
patch 1: pre patch cleanup: convert internal epoll to timespec64
patch 2: add
From: Willem de Bruijn
Enable nanosecond timeouts for epoll.
Analogous to pselect and ppoll, introduce an epoll_wait syscall
variant that takes a struct timespec instead of int timeout.
See patch 1 for more details.
patch 1: new syscall
patch 2: selftest
Willem de Bruijn (2):
epoll: add
From: Willem de Bruijn
Code coverage for the epoll_pwait2 syscall.
epoll62: Repeat basic test epoll1, but exercising the new syscall.
epoll63: Pass a timespec and exercise the timeout wakeup path.
Signed-off-by: Willem de Bruijn
---
.../filesystems/epoll/epoll_wakeup_test.c | 70
From: Willem de Bruijn
Add syscall epoll_pwait2, an epoll_wait variant with nsec resolution
that replaces int timeout with struct timespec. It is equivalent
otherwise.
int epoll_pwait2(int fd, struct epoll_event *events,
int maxevents,
const struct
From: Willem de Bruijn
Expand the epoll_wait page with epoll_pwait2, an epoll_wait variant
that takes a struct timespec to enable nanosecond resolution timeout.
int epoll_pwait2(int fd, struct epoll_event *events,
int maxevents,
const struct
On Wed, Nov 18, 2020 at 10:00 AM Matthew Wilcox wrote:
>
> On Wed, Nov 18, 2020 at 09:46:15AM -0500, Willem de Bruijn wrote:
> > -static inline struct timespec64 ep_set_mstimeout(long ms)
> > +static inline struct timespec64 ep_set_nstimeout(s64 timeout)
> > {
> > -
On Wed, Nov 18, 2020 at 9:46 AM Willem de Bruijn
wrote:
>
> From: Willem de Bruijn
>
> Add syscall epoll_pwait2, an epoll_wait variant with nsec resolution
> that replaces int timeout with struct timespec. It is equivalent
> otherwise.
>
> int epoll_pwait2(int fd, st
e typically used. UDP even has an inline helper that makes use of
> > them, udp_gro_udphdr(). Use that instead of troublemaking udp_hdr()
> > to get rid of the out-of-order delivers.
> >
> > Present since the introduction of plain UDP GRO in 5.0-rc1.
> >
> &
On Mon, Nov 16, 2020 at 8:07 AM Alexander Lobakin wrote:
>
> From: Willem de Bruijn
> Date: Fri, 13 Nov 2020 10:51:36 -0500
>
> Hi!
>
> > On Fri, Nov 13, 2020 at 7:00 AM kernel test robot
> > wrote:
> >>
> >>
> >> Greeting,
> &g
From: Willem de Bruijn
Add epoll_create1 flag EPOLL_NSTIMEO. When passed, this changes the
interpretation of argument timeout in epoll_wait from msec to nsec.
Use cases such as datacenter networking operate on timescales well
below milliseconds. Shorter timeouts bounds their tail latency
On Mon, Nov 16, 2020 at 11:19 AM Matthew Wilcox wrote:
>
> On Mon, Nov 16, 2020 at 11:10:01AM -0500, Willem de Bruijn wrote:
> > diff --git a/include/uapi/linux/eventpoll.h b/include/uapi/linux/eventpoll.h
> > index 8a3432d0f0dc..f6ef9c9f8ac2 100644
> > --- a/includ
On Mon, Nov 16, 2020 at 12:11 PM David Laight wrote:
>
> From: Willem de Bruijn
> > Sent: 16 November 2020 17:01
> >
> > On Mon, Nov 16, 2020 at 11:19 AM Matthew Wilcox wrote:
> > >
> > > On Mon, Nov 16, 2020 at 11:10:01AM -0500, Willem de Bruijn wrot
On Mon, Nov 16, 2020 at 3:04 PM Andrew Morton wrote:
>
> On Mon, 16 Nov 2020 11:10:01 -0500 Willem de Bruijn
> wrote:
>
> > From: Willem de Bruijn
> >
> > Add epoll_create1 flag EPOLL_NSTIMEO. When passed, this changes the
> > interpretation of argument tim
On Mon, Nov 16, 2020 at 6:36 PM Willem de Bruijn
wrote:
>
> On Mon, Nov 16, 2020 at 3:04 PM Andrew Morton
> wrote:
> >
> > On Mon, 16 Nov 2020 11:10:01 -0500 Willem de Bruijn
> > wrote:
> >
> > > From: Willem de Bruijn
> > >
>
On Mon, Nov 16, 2020 at 7:37 PM Andrew Morton wrote:
>
> On Mon, 16 Nov 2020 18:51:16 -0500 Willem de Bruijn
> wrote:
>
> > On Mon, Nov 16, 2020 at 6:36 PM Willem de Bruijn
> > wrote:
> > >
> > > On Mon, Nov 16, 2020 at 3:04 PM Andrew Morton
> &
On Thu, Nov 26, 2020 at 3:19 AM Marco Elver wrote:
>
> On Wed, 25 Nov 2020 at 21:43, Jakub Kicinski wrote:
> >
> > On Wed, 25 Nov 2020 18:34:36 +0100 Marco Elver wrote:
> > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> > > index ffe3dcc0ebea..070b1077d976 100644
> > > ---
f the proposed solution, let's just set
> status = 0.
>
> Reported-by: syzbot
> Reported-by: Willem de Bruijn
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/media/usb/dvb-usb/gp8psk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
On Fri, Nov 27, 2020 at 7:26 AM Marco Elver wrote:
>
> On Thu, 26 Nov 2020 at 17:35, Willem de Bruijn
> wrote:
> > On Thu, Nov 26, 2020 at 3:19 AM Marco Elver wrote:
> [...]
> > > Will send v2.
> >
> > Does it make more sense to revert the patch that
On Sat, Nov 7, 2020 at 8:11 PM Alexander Lobakin wrote:
>
> While testing UDP GSO fraglists forwarding through driver that uses
> Fast GRO (via napi_gro_frags()), I was observing lots of out-of-order
> iperf packets:
>
> [ ID] Interval Transfer Bitrate Jitter
> [SUM]
er delivers.
>
> Present since the introduction of plain UDP GRO in 5.0-rc1.
>
> Since v1 [1]:
> - added a NULL pointer check for "uh" as suggested by Willem.
>
> [1]
> https://lore.kernel.org/netdev/yazu6gezbdpyzmdmwjirxdx7b4sualpdg68adzy...@cp4-web-034.plabs.ch
>
UDP even has an inline helper that makes use of
> > them, udp_gro_udphdr(). Use that instead of troublemaking udp_hdr()
> > to get rid of the out-of-order delivers.
> >
> > Present since the introduction of plain UDP GRO in 5.0-rc1.
> >
> > Since v1 [1]:
> &g
On Mon, Nov 9, 2020 at 1:54 PM Eric Dumazet wrote:
>
>
>
> On 11/9/20 7:28 PM, Willem de Bruijn wrote:
> > On Mon, Nov 9, 2020 at 12:37 PM Eric Dumazet wrote:
> >>
> >>
> >>
> >> On 11/9/20 5:56 PM, Alexander Lobakin wrote:
> >
sible malfunction of {,__}udp{4,6}_lib_lookup_skb() with
>Fast/frag0 due to ip{,v6}_hdr() usage (Willem).
>
> Since v1 [2]:
> - added a NULL pointer check for "uh" as suggested by Willem.
>
> [1]
> https://lore.kernel.org/netdev/0eag8xtbtky1dekctkububgic9qa
> > Does this device support stacked VLAN?
> I am not familiar with stacked VLAN.
> Our HW for sure there is no support. can the SW stack handle it for me?
> Does it mean that the packets can be larger?
If the device does not support it, I believe it's fine to leave it to S/W.
> > Is this
On Fri, Sep 4, 2020 at 3:09 PM Wang Hai wrote:
>
> BPDU_TYPE_TCN is never used after it was introduced.
> So better to remove it.
This comment does not cover the patch contents. Otherwise the patch
looks good to me.
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
> ---
>
On Tue, Sep 1, 2020 at 9:54 PM Murali Karicheri wrote:
>
> This patch add support for creating vlan interfaces
> over hsr/prp interface.
>
> Signed-off-by: Murali Karicheri
> ---
> net/hsr/hsr_device.c | 4
> net/hsr/hsr_forward.c | 16 +---
> 2 files changed, 13
On Thu, Sep 3, 2020 at 12:30 AM Murali Karicheri wrote:
>
> All,
>
> On 9/2/20 12:14 PM, Murali Karicheri wrote:
> > All,
> >
> > On 9/1/20 3:54 PM, Murali Karicheri wrote:
> >> This series add support for creating VLAN interface over HSR or
> >> PRP interface. Typically industrial networks uses
On Sat, Sep 5, 2020 at 10:53 AM Wang Hai wrote:
>
> BLOCK_PRIV is never used after it was introduced.
> So better to remove it.
>
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
Acked-by: Willem de Bruijn
On Wed, Sep 2, 2020 at 2:18 PM Huazhong Tan wrote:
>
> In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled
> separately, for example, checksum offload, so add new GSO type
> SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands
> for UDPv4.
This is in preparation for hardware
On Wed, Sep 2, 2020 at 5:37 PM Vadym Kochan wrote:
>
> Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
> wireless SMB deployment.
>
> The current implementation supports only boards designed for the Marvell
>
On Wed, Sep 2, 2020 at 5:07 PM Vadym Kochan wrote:
>
> The following features are supported:
>
> - VLAN-aware bridge offloading
> - VLAN-unaware bridge offloading
> - FDB offloading (learning, ageing)
> - Switchport configuration
>
> Currently there are some limitations like:
>
>
399281] lapb_data_request+0x76/0xc0 [lapb]
> [ 168.399283] lapbeth_xmit+0x56/0x90 [lapbether]
> [ 168.399286] dev_hard_start_xmit+0x91/0x1f0
> [ 168.399289] ? irq_init_percpu_irqstack+0xc0/0x100
> [ 168.399291] __dev_queue_xmit+0x721/0x8e0
> [ 168.399295] ? packet_parse_
On Thu, Aug 6, 2020 at 1:48 PM linmiaohe wrote:
>
> From: Miaohe Lin
>
> We could be trapped in deadloop when we try to copy userspace skb frags
> buffers to kernel with a cloned skb:
>
> [kbox] catch panic event, panic reason:kernel stack overflow
> [kbox] catch panic event, start logging.
>
On Sun, Sep 6, 2020 at 1:21 AM Xie He wrote:
>
> On Sat, Sep 5, 2020 at 3:24 PM Xie He wrote:
> >
> > Hi Willem,
> >
> > I have a question about the function dev_validate_header used in
> > af_packet.c. Can you help me? Thanks!
> >
> > I
gt; >
> > Changes since RFC V2:
> > - modifies the timing of setting UDP GSO type when doing UDP GRO in #1.
> >
> > Changes since RFC V1:
> > - updates NETIF_F_GSO_LAST suggested by Willem de Bruijn.
> > and add NETIF_F_GSO_UDPV6_L4 feature for each
454f7a895b8 ("mwifiex: set needed_headroom, not hard_header_len")
> According to the discussion about it at:
> https://patchwork.kernel.org/patch/11407493/
> The author tried to set the WiFi driver's hard_header_len to the Ethernet
> header length, and request additional header space int
On Mon, Sep 7, 2020 at 3:38 PM tanhuazhong wrote:
>
>
>
> On 2020/9/7 17:22, Willem de Bruijn wrote:
> > On Sun, Sep 6, 2020 at 8:42 PM Jakub Kicinski wrote:
> >>
> >> On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote:
> >>> There are two upd
On Tue, Sep 8, 2020 at 4:32 AM tanhuazhong wrote:
>
>
>
> On 2020/9/7 23:35, Willem de Bruijn wrote:
> > On Mon, Sep 7, 2020 at 3:38 PM tanhuazhong wrote:
> >>
> >>
> >>
> >> On 2020/9/7 17:22, Willem de Bruijn wrote:
>
On Mon, Sep 7, 2020 at 11:17 PM Xie He wrote:
>
> On Mon, Sep 7, 2020 at 2:06 AM Willem de Bruijn
> wrote:
> >
> > The CAP_SYS_RAWIO exception indeed was requested to be able to
> > purposely test devices against bad inputs. The gmane link
> &
On Tue, Sep 8, 2020 at 2:07 AM Xie He wrote:
>
> Thank you for your comment!
>
> On Mon, Sep 7, 2020 at 2:41 AM Willem de Bruijn
> wrote:
> >
> > On Sun, Sep 6, 2020 at 5:18 AM Xie He wrote:
> > >
> > > This comment is outdated and
On Tue, Sep 8, 2020 at 1:04 PM Xie He wrote:
>
> On Tue, Sep 8, 2020 at 1:41 AM Willem de Bruijn
> wrote:
> >
> > The intent is to bypass such validation to be able to test device
> > drivers. Note that removing that may cause someone's test to start
> > failin
On Tue, Sep 8, 2020 at 6:23 PM Xie He wrote:
>
> On Tue, Sep 8, 2020 at 4:53 AM Willem de Bruijn
> wrote:
> >
> > On Tue, Sep 8, 2020 at 1:04 PM Xie He wrote:
> > >
> > > I was recently looking at some drivers, and I felt that if af_packet.c
> > >
On Tue, Sep 8, 2020 at 6:39 PM Murali Karicheri wrote:
>
> Hi Willem,
>
> Thanks for the response!
> On 9/4/20 11:45 AM, Willem de Bruijn wrote:
> > On Tue, Sep 1, 2020 at 9:54 PM Murali Karicheri wrote:
> >>
> >> This patch add support for creating vlan
On Tue, Sep 8, 2020 at 6:55 PM Murali Karicheri wrote:
>
> Hi Willem,
>
> On 9/4/20 11:52 AM, Willem de Bruijn wrote:
> > On Thu, Sep 3, 2020 at 12:30 AM Murali Karicheri
> > wrote:
> >>
> >> All,
> >>
> >> On 9/2/20 12:14 PM, Mura
On Fri, Aug 14, 2020 at 9:20 AM linmiaohe wrote:
>
> Willem de Bruijn wrote:
> >On Thu, Aug 13, 2020 at 2:16 PM Miaohe Lin wrote:
> >>
> >> If the skb is zcopied, we should increase the skb_uarg refcount before
> >> we involve skb_release_data()
On Fri, Aug 14, 2020 at 10:17 AM linmiaohe wrote:
>
> Willem de Bruijn wrote:
> >On Thu, Aug 13, 2020 at 1:59 PM Miaohe Lin wrote:
> >>
> >> The var extra_uref is introduced to pass the initial reference taken
> >> in sock_zerocopy_alloc to the f
> >> + /* We program at most 6 source or destination resource group
> >> limits */
> >> + BUILD_BUG_ON(IPA_RESOURCE_GROUP_SRC_MAX > 6);
> >> +
> >> group_count = ipa_resource_group_src_count(ipa->version);
> >> - if (!group_count)
> >> + if (!group_count ||
pair limits to this function. If a resource group is
> not supported, pass a null pointer to ipa_resource_config_common()
> for that group and have that function write zeroes in that case.
>
> Fixes: cdf2e9419dd91 ("soc: qcom: ipa: main code")
> Tested-by: Sujit Kautkar
> Signed-off-by: Alex Elder
Acked-by: Willem de Bruijn
On Wed, Oct 28, 2020 at 10:12 PM Xie He wrote:
>
> The eth_type_trans function is called when we receive frames carrying
> Ethernet frames. This function expects a non-NULL pointer as an argument,
> and assigns it directly to skb->dev.
>
> However, the code handling other types of frames first
On Wed, Oct 28, 2020 at 6:01 PM Xie He wrote:
>
> When the fr_rx function drops a received frame (because the protocol type
> is not supported, or because the PVC virtual device that corresponds to
> the DLCI number and the protocol type doesn't exist), the function frees
> the skb and returns.
>
On Wed, Oct 28, 2020 at 9:13 PM Brian Norris wrote:
>
> On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto wrote:
> >
> > To make the ps_mode (power_save) control easier, this commit adds a new
> > module parameter allow_ps_mode and set it false (disallowed) by default.
This sounds like some form of
On Wed, Oct 28, 2020 at 6:58 PM Xie He wrote:
>
> Change the fr_rx function to make this driver support any Ethertype
> when receiving skbs on normal (non-Ethernet-emulating) PVC devices.
> (This driver is already able to handle any Ethertype when sending.)
>
> Originally in the fr_rx function,
> > > static int rvu_devlink_info_get(struct devlink *devlink, struct
> > devlink_info_req *req,
> > > struct netlink_ext_ack *extack) { @@
> > > -53,7 +483,8 @@ int rvu_register_dl(struct rvu *rvu)
> > > rvu_dl->dl = dl;
> > > rvu_dl->rvu = rvu;
>
On Tue, Nov 3, 2020 at 12:43 PM George Cherian wrote:
>
> Hi Willem,
>
>
> > -Original Message-
> > From: Willem de Bruijn
> > Sent: Tuesday, November 3, 2020 7:21 PM
> > To: George Cherian
> > Cc: Network Development ; linux-kernel > ke
2 bytes, the control field and the protocol field would not be the 3rd
> and 4th byte as we assume. (Say it is 3 bytes, then the control field
> and the protocol field would be the 4th and 5th byte instead.)
>
> Cc: Willem de Bruijn
> Cc: Krzysztof Halasa
> Signed-off-by: Xie He
Acked-by: Willem de Bruijn
skb and returns.
>
> The code for freeing the skb and returning is repeated several times, this
> patch uses "goto rx_drop" to replace them so that the code looks cleaner.
>
> Cc: Willem de Bruijn
> Cc: Krzysztof Halasa
> Signed-off-by: Xie He
> ---
> driv
On Sat, Oct 31, 2020 at 6:31 AM Alexander Lobakin wrote:
>
> On Saturday, 31 October 2020, 2:12, Willem de Bruijn
> wrote:
>
> Hi Willem,
>
> > On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote:
> >
> > > Commit 9fd1ff5d2ac7 (&quo
> >> I think it is fine to reenable this again, now that UDP sockets will
> >> segment unexpected UDP GSO packets that may have looped. We previously
> >> added general software support in commit 83aa025f535f ("udp: add gso
> >> support to virtual devices"). Then reduced its scope to egress only
On Sat, Oct 31, 2020 at 12:02 PM Xie He wrote:
>
> On Sat, Oct 31, 2020 at 8:18 AM Xie He wrote:
> >
> > > Especially without that, I'm not sure this and the follow-on patch add
> > > much value. Minor code cleanups complicate backports of fixes.
> >
> > To me this is necessary, because I feel
On Mon, Nov 2, 2020 at 12:07 AM George Cherian
wrote:
>
> Add devlink support to AF driver. Basic devlink support is added.
> Currently info_get is the only supported devlink ops.
>
> devlink ouptput looks like this
> # devlink dev
> pci/0002:01:00.0
> # devlink dev info
> pci/0002:01:00.0:
>
On Mon, Nov 2, 2020 at 12:07 AM George Cherian
wrote:
>
> Add health reporters for RVU NPA block.
> Only reporter dump is supported
>
> Output:
> # devlink health
> pci/0002:01:00.0:
>reporter npa
> state healthy error 0 recover 0
> # devlink health dump show pci/0002:01:00.0
llback mode.
> We can safely add them to NETIF_F_GSO_SOFTWARE to allow logical/virtual
> netdevs to forward these types of skbs up to the real drivers.
>
> Signed-off-by: Alexander Lobakin
Acked-by: Willem de Bruijn
On Sat, Oct 31, 2020 at 11:56 AM Alexander Lobakin wrote:
>
> From: Willem de Bruijn
> Date: Sat, 31 Oct 2020 11:26:24 -0400
>
> >>>> I think it is fine to reenable this again, now that UDP sockets will
> >>>> segment unexpected UDP GSO packets that m
t does not apply to dummy or IFB. I guess dummy is fine, because
xmit is a black hole, and IFB because ingress can safely handle these
packets? How did you arrive at the choice of changing these two, of
all virtual devices?
>
> Suggested-by: Willem de Bruijn
> Signed-off-by: Ale
On Mon, Nov 2, 2020 at 2:26 PM Alexander Lobakin wrote:
>
> From: Willem de Bruijn
> Date: Mon, 2 Nov 2020 11:30:17 -0500
>
> Hi!
> Thanks for the Ack.
>
> > On Sun, Nov 1, 2020 at 8:17 AM Alexander Lobakin wrote:
> >>
> >> Virtual netdevs should
On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote:
>
>
> On 2021/1/13 上午7:47, Willem de Bruijn wrote:
> > On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich
> > wrote:
> >> On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich
> >> wrote:
> >>&g
gested-by: Jiapeng Zhong
> Signed-off-by: Abaci Team
Signed-off-by lines need to have a real name. See
Documentation/process/submitting-patches.rst
With that change
Acked-by: Willem de Bruijn
);
>
> without all the casting.
>
> Fixes: 6b8c7574a5f8 ("rtlwifi: fix build warning")
> Fixes: d3ccc14dfe95 ("rtlwifi/rtw88: convert tasklets to use new
> tasklet_setup() API")
> Signed-off-by: Emil Renner Berthing
Since the current code works, this could target net-next without Fixes tags.
Acked-by: Willem de Bruijn
++--
> drivers/net/ipa/ipa_cmd.h | 24 ++-
> drivers/net/ipa/ipa_endpoint.c | 79 ++
> drivers/net/ipa/ipa_main.c | 1 +
> 5 files changed, 109 insertions(+), 42 deletions(-)
For netdrv
Acked-by: Willem de Bruijn
On Fri, Jan 29, 2021 at 2:56 PM Sven Van Asbroeck wrote:
>
> From: Sven Van Asbroeck
>
> Multi-buffer packets enable us to use rx ring buffers smaller than
> the mtu. This will allow us to change the mtu on-the-fly, without
> having to stop the network interface in order to re-size the rx
> ring
On Fri, Jan 29, 2021 at 6:03 PM Sven Van Asbroeck wrote:
>
> Hoi Willem, thanks a lot for reviewing this patch, much appreciated !!
>
> On Fri, Jan 29, 2021 at 5:11 PM Willem de Bruijn
> wrote:
> >
> > > +static struct sk_buff *
> > > +lan743x_rx_trim_sk
301 - 400 of 633 matches
Mail list logo
