drivers/watchdog/bcm_kona_wdt.c | 108
+--
3 files changed, 115 insertions(+), 4 deletions(-)
This patch was added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi Sekhar,
> On Friday 29 November 2013 01:44 PM, Sekhar Nori wrote:
> > Wim,
> >
> > On Thursday 28 November 2013 06:29 PM, Guenter Roeck wrote:
> >> On 11/27/2013 10:04 PM, Sekhar Nori wrote:
> >>> On Wednesday 27 November 2013 09:27 PM, Guenter
Hi Sekhar,
On Friday 29 November 2013 01:44 PM, Sekhar Nori wrote:
Wim,
On Thursday 28 November 2013 06:29 PM, Guenter Roeck wrote:
On 11/27/2013 10:04 PM, Sekhar Nori wrote:
On Wednesday 27 November 2013 09:27 PM, Guenter Roeck wrote:
On 11/27/2013 06:00 AM, Sekhar Nori wrote
divisions by divisor up to give us extra time.
>
> At the same time we can avoid a for loop by just doing the right math.
>
> Signed-off-by: Doug Anderson
> ---
> Changes in v2:
> - Avoid a for loop as per Guenter.
Patch added to linux-watchdog-next.
Kind regards,
W
ser common clock framework.
>
> Signed-off-by: Doug Anderson
> ---
> Changes in v2:
> - Use the updated config name.
Patch added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messag
...@chromium.org
---
Changes in v2:
- Use the updated config name.
Patch added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
diand...@chromium.org
---
Changes in v2:
- Avoid a for loop as per Guenter.
Patch added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
cm_kona_wdt *wdt)
{
wdt->debugfs = bcm_kona_wdt_debugfs_init(wdt,
_kona_wdt_wdd);
}
...
#else /* !CONFIG_BCM_KONA_WDT_DEBUG */
static void bcm_kona_wdt_debug_init(struct bcm_kona_wdt *wdt) {}
...
#endif /* CONFIG_BCM_KONA_WDT_DEBUG */
Goal i
void bcm_kona_wdt_debug_init(struct bcm_kona_wdt *wdt) {}
...
#endif /* CONFIG_BCM_KONA_WDT_DEBUG */
Goal is to have as little #ifdef's as possible and to improve readability of
the code.
So can you do the necessary?
Thanks in advance,
Wim.
--
To unsubscribe from this list: send
watchdog tree ?
> >> Do let me know if you want us to prepare a git branch
> >> to pull from.
> >>
> > ping..
> >
> I haven't heard anything on this yet from you Wim.
>
> Guenter,
> I have seen you actively reviewing the $subject patch series.
&g
driver to use WDT core
switched off CONFIG_WATCHDOG_NOWAYOUT option
Can you please apply the series to your watchdog tree ?
Do let me know if you want us to prepare a git branch
to pull from.
ping..
I haven't heard anything on this yet from you Wim.
Guenter,
I have seen you
-by: Alan Cox
Reviewed-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
Partially-Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=53991
commit 9539210e17dc09ea1472076c297d461c7507a5bb
Author: Guenter Roeck
Date: Tue Nov 19 13:26:17 2013 -0800
watchdog: Drop
properly.
Signed-off-by: Alan Cox a...@linux.intel.com
Reviewed-by: Guenter Roeck li...@roeck-us.net
Signed-off-by: Wim Van Sebroeck w...@iguana.be
Partially-Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=53991
commit 9539210e17dc09ea1472076c297d461c7507a5bb
Author
.
Request memory region only when needed, and use request_muxed_region().
This lets other devices (hwmon, gpio) use the same region.
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
commit ac461103c57ac46cd6778f1fd0352ff0e4a2d38e
Author: Guenter Roeck
Date: Sat Aug 17 13
registers.
Request memory region only when needed, and use request_muxed_region().
This lets other devices (hwmon, gpio) use the same region.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Signed-off-by: Wim Van Sebroeck w...@iguana.be
commit
t; + watchdog_init_timeout(_dev, timeout, NULL);
> + watchdog_set_nowayout(_dev, nowayout);
> +
> + w83627hf_init(_dev);
>
> ret = register_reboot_notifier(_notifier);
> if (ret != 0) {
> @@ -364,28 +248,25 @@ static int __init wdt_init(void)
>
nsky
> Signed-off-by: Taras Kondratiuk
This was added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
This was added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
);
-MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
I will add this patch with above two small corrections to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
nk that such enhancements
> should really start with a conversion to the watchdog infrastructure.
> That is just my personal opinion, of course.
I think the enhancement might be worthwhile, but not in it's present form.
I agree that it would be nice to have the conversion also, but it's two
t; > 2) patches that I am reviewing or are on my radar:
> > w83627hf-patches
> > Orion-patches
> > f81865_gpio.c
> > [PATCH V2 0/4] Add watchdog DT nodes and parse it to read PMU registers
> > addresses (Exynos+s3c2410_wdt)
> > [PATCH v4 4/4] ARM: bcm47
he timer has been running.
>
> I'll send a new patch fixing those issues.
> I hope it won't bother you :-(.
No problem :-). Just sent me the fixes when they are ready.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
t; [PATCH] Documentation/watchdog: Update node name in samsung-wdt example
And also:
[PATCH v3] Enhanced support for MPC8xx/8xxx watchdog
And the winbond mfd patches from Guenter and Myself.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
] Documentation/watchdog: Update node name in samsung-wdt example
So if something is still missing: please let it know.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
pendency) can't even be unloaded!
>
> If defining char-major-10-130 is needed then it should happen in
> user-space.
>
> Signed-off-by: Jean Delvare
> Cc: Wim Van Sebroeck
> Cc: Stephen Warren
> Cc: Mike Frysinger
> Cc: Wan ZongShun
> Cc: Ben Dooks
> Cc:
/dts/at91sam9g45.dtsi |5 +
> arch/arm/boot/dts/at91sam9n12.dtsi |5 +
> arch/arm/boot/dts/at91sam9x5.dtsi |5 +
> arch/arm/boot/dts/kizbox.dts |6 +
> arch/arm/boot/dts/sama5d3.dtsi |5 +
)
>
> Signed-off-by: Michal Simek
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel
> Cc: Pawel Moll
> Cc: Mark Rutland
> Cc: Stephen Warren
> Cc: Ian Campbell
> Cc: Rob Landley
> Cc: Wim Van Sebroeck
> Cc: Guenter Roeck
> ---
> .../bindings/{gpio => watchdog}/men-a021-wdt.txt |0
> 1 file changed, 0 insertions(+), 0 deletions(-
12 deletions(-)
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
l */ }
> };
> +MODULE_DEVICE_TABLE(of, imx2_wdt_dt_ids);
>
> static struct platform_driver imx2_wdt_driver = {
> .remove = __exit_p(imx2_wdt_remove),
This has been added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscri
2 files changed, 36 insertions(+), 13 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/watchdog/snps-dw-apb-wdt.txt
patches 1 and 2 have been added to linux-watchdog-next.
Patch 3 has been replaced with Dinh Nguyen's patch (watchdog: dw: Enable OF
support for DW watchdog t
Let me review the other patches still before we do any re-sending.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info
the other patches still before we do any re-sending.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
mode 100644
Documentation/devicetree/bindings/watchdog/snps-dw-apb-wdt.txt
patches 1 and 2 have been added to linux-watchdog-next.
Patch 3 has been replaced with Dinh Nguyen's patch (watchdog: dw: Enable OF
support for DW watchdog timer).
Kind regards,
Wim.
--
To unsubscribe from this list
(of, imx2_wdt_dt_ids);
static struct platform_driver imx2_wdt_driver = {
.remove = __exit_p(imx2_wdt_remove),
This has been added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Herring rob.herr...@calxeda.com
Cc: Pawel Moll pawel.m...@arm.com
Cc: Mark Rutland mark.rutl...@arm.com
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: Ian Campbell ian.campb...@citrix.com
Cc: Rob Landley r...@landley.net
Cc: Wim Van Sebroeck w...@iguana.be
Cc: Guenter Roeck li...@roeck-us.net
michal.si...@xilinx.com
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
|5 +
drivers/watchdog/at91sam9_wdt.c| 309
++--
9 files changed, 287 insertions(+), 88 deletions(-)
These 4 patches have been added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
then it should happen in
user-space.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Wim Van Sebroeck w...@iguana.be
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: Mike Frysinger vapier@gmail.com
Cc: Wan ZongShun mcuos@gmail.com
Cc: Ben Dooks ben-li...@fluff.org
Cc: Kukjin Kim kgene
] Documentation/watchdog: Update node name in samsung-wdt example
So if something is still missing: please let it know.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
: Update node name in samsung-wdt example
And also:
[PATCH v3] Enhanced support for MPC8xx/8xxx watchdog
And the winbond mfd patches from Guenter and Myself.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
fixing those issues.
I hope it won't bother you :-(.
No problem :-). Just sent me the fixes when they are ready.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
+s3c2410_wdt)
[PATCH v4 4/4] ARM: bcm4760: Add restart hook
[PATCH] Documentation/watchdog: Update node name in samsung-wdt example
So if something is still missing: please let it know.
Hi Wim,
thanks a lot for getting this all done.
No problem :-). Thanks also for your reviews and testing
, of course.
I think the enhancement might be worthwhile, but not in it's present form.
I agree that it would be nice to have the conversion also, but it's two
seperate things for the moment..
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
G_TIMEOUT) ".");
>
> -static bool nowayout = WATCHDOG_NOWAYOUT;
> -module_param(nowayout, bool, 0);
> -MODULE_PARM_DESC(nowayout,
> - "Watchdog cannot be stopped once started (default="
> - __MODULE_STRING(WATCHDOG_NO
);
-MODULE_PARM_DESC(nowayout,
- Watchdog cannot be stopped once started (default=
- __MODULE_STRING(WATCHDOG_NOWAYOUT) ));
-
Why do you remove the nowayout module param?
Kind regards,
Wim.
/*
* Kernel methods.
*/
@@ -110,7 +98,7 @@ static void
e.
>
> Signed-off-by: Jonas Jensen
Added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info
Jensen jonas.jen...@gmail.com
Added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
Hi Guenter,
> Looks like the diffs don't match the description.
> Are those possibly the diffs from your previous pull request ?
>From a 3.6 pull request to be precisely :-( I use the old mail
as template and apparently forgot to change the diff...
The correct diff here below.
Th
()
The variable sunxi_wdt_driver references
the function __init sunxi_wdt_probe()
Signed-off-by: Maxime Ripard
Reviewed-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
commit 4c4e45669de475573b15d968a6dca8d00124c9ad
Author: Jingoo Han
Date: Mon Sep 23 19:16:57 2013
.init.text:sunxi_wdt_probe()
The variable sunxi_wdt_driver references
the function __init sunxi_wdt_probe()
Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com
Reviewed-by: Guenter Roeck li...@roeck-us.net
Signed-off-by: Wim Van Sebroeck w...@iguana.be
commit
Hi Guenter,
Looks like the diffs don't match the description.
Are those possibly the diffs from your previous pull request ?
From a 3.6 pull request to be precisely :-( I use the old mail
as template and apparently forgot to change the diff...
The correct diff here below.
Thanks,
Wim
device. All auxilary iLO devices will have a
subsystem device ID set to 0x1979 in order for hpwdt to differentiate
between
the two types.
Signed-off-by: Thomas Mingarelli
Tested-by: Lisa Mitchell
Signed-off-by: Wim Van Sebroeck
For completeness, I added the overal diff
-off-by: Wim Van Sebroeck w...@iguana.be
For completeness, I added the overal diff below.
Greetings,
Wim.
commit 0821f20d49d19f49e53b05ef6727e010c4b1f11d
Author: Mingarelli, Thomas thomas.mingare...@hp.com
Date: Fri
;\) }
... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
e = devm_ioremap_resource(e1, res);
//
Signed-off-by: Julia Lawall
Reviewed-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
commit 8ecc7d2b2207ed9642e3d0140bfaa8c93a6ea47f
Author: Julia
l;\|return ret;\) }
... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
e = devm_ioremap_resource(e1, res);
// /smpl
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Reviewed-by: Guenter Roeck li...@roeck-us.net
Signed-off-by: Wim Van Sebroeck
estarted git but apparently it didn't do anything anymore.
I just restarted it and saw a pull coming in again. So it is fixed now.
Thanks for pointing it out.
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.o
but apparently it didn't do anything anymore.
I just restarted it and saw a pull coming in again. So it is fixed now.
Thanks for pointing it out.
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
you plan to keep the set of patches together in one tree?
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
together in one tree?
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
as_match_tbl,
> + .name = "palmas-wdt",
> + },
> +};
> +
> +module_platform_driver(palmas_wdt_driver);
> +
> +MODULE_AUTHOR("Graeme Gregory ");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:palmas-wdt");
> +M
);
+MODULE_ALIAS(platform:palmas-wdt);
+MODULE_DEVICE_TABLE(of, of_palmas_match_tbl);
--
1.7.0.4
If you can add the devicetree bindings Documentation and the Kconfig patch
together with the revised version of this patch into a single patch then we can
complete the review.
Kind regards,
Wim
Hi Stephen,
> On Thu, 11 Jul 2013 22:34:24 +0200 Wim Van Sebroeck wrote:
> >
> > Please pull from 'master' branch of
> > git://www.linux-watchdog.org/linux-watchdog.git
>
> This was all rebased in the last day from what has been in linux-next for
> some time.
Hi Stephen,
On Thu, 11 Jul 2013 22:34:24 +0200 Wim Van Sebroeck w...@iguana.be wrote:
Please pull from 'master' branch of
git://www.linux-watchdog.org/linux-watchdog.git
This was all rebased in the last day from what has been in linux-next for
some time. All the patches
/softdog.c |1 -
> 1 file changed, 1 deletion(-)
Patch added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kerne
-
1 file changed, 1 deletion(-)
Patch added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
by: Johannes Thumshirn
I will not add this patch and put it in my waiting queue.
Reason: we should first do the sysfs stuff for the wwatchdog_core (since
active and nowayout are parameters that will be in the sysfs watchdog core).
Kind regards,
Wim.
--
To unsubscribe from this list: send the line
inux-watchdog-next.
I am still thinking about wether or not we shouldn't add a timer to this
watchdog device driver. But that's something we can change later on.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ma
d indeed be fixed because they poke in the hardware
directly and can't be really detected.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
detection
mechanism we should indeed remove them. The rest should be evaluated
afterwards on a case by case basis. Certain intel based drivers should
(like advantechwdt) should indeed be fixed because they poke in the hardware
directly and can't be really detected.
Kind regards,
Wim.
--
To unsubscribe
added this patch to linux-watchdog-next.
I am still thinking about wether or not we shouldn't add a timer to this
watchdog device driver. But that's something we can change later on.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
.
Reason: we should first do the sysfs stuff for the wwatchdog_core (since
active and nowayout are parameters that will be in the sysfs watchdog core).
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
well, although the
> respective maintainers can safely carry them as they all have a Kconfig
> dependency on MFD_KEMPLD. So it's up to them.
> If I have to take them, I'd need Wolfram's ACK for the i2c one and Wim's
> for the watchdog one. Linus already ACKed the GPIO one.
Acked-by
Hi Lubomir,
> This adds a driver for watchdog timer hardware present on Broadcom BCM2835
> SoC,
> used in Raspberry Pi and Roku 2 devices.
>
> Signed-off-by: Lubomir Rintel
> Tested-by: Stephen Warren
> Cc: Stephen Warren
> Cc: Wim Van Sebroeck
> Cc: Guenter
s than or equal to 1 second(basically small values).
>
> As suggested by Wim Van Sebroeck & Guenter Roeck we should
> add this functionality of individual watchdog drivers in the core
> watchdog core.
Have you considered the effect this change has on all watchdog drivers
that don't n
> 1 file changed, 11 insertions(+), 20 deletions(-)
Both patches added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel
patches added to linux-watchdog-next.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
second(basically small values).
As suggested by Wim Van Sebroeck Guenter Roeck we should
add this functionality of individual watchdog drivers in the core
watchdog core.
Have you considered the effect this change has on all watchdog drivers
that don't need a timer?
Kind regards,
Wim
Hi Lubomir,
This adds a driver for watchdog timer hardware present on Broadcom BCM2835
SoC,
used in Raspberry Pi and Roku 2 devices.
Signed-off-by: Lubomir Rintel lkund...@v3.sk
Tested-by: Stephen Warren swar...@wwwdotorg.org
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: Wim Van Sebroeck
it's up to them.
If I have to take them, I'd need Wolfram's ACK for the i2c one and Wim's
for the watchdog one. Linus already ACKed the GPIO one.
Acked-by: Wim Van Sebroeck w...@iguana.be
I'm OK that itgoes via the MFD tree.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line
it anyway is
> > buggy
> > > > and should be fixed.
> > >
> > > I fully understand your points and 100% agree with you
> > > 1. the application is broken and should be fixed
> > > 2. also the kernel shouldn't fix any problem with stupi
Hi Johannes,
> Ok I'll do. Should I repost this as a change of this patch or the "add driver"
> patch?
the add driver patch.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kern
Hi Guenter,
> On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote:
> > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote:
> > [...]
> > > > + watchdog_set_drvdata(_wdt, drv);
> > >
> > > I am missing the initia
>
> > From the watchdog-kernel-api documentation:
> > * parent: set this to the parent device (or NULL) before calling
> > watchdog_register_device.
> >
> Hi Wim,
>
> unfortunately that only works if the driver is instantiated as platform
> d
Hi Johannes,
> On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote:
> [...]
> > > + watchdog_set_drvdata(_wdt, drv);
> >
> > I am missing the initialisation of the watchdog's timeout value here...
>
> This watchdog only knows two timeout value
>
> > From the watchdog-kernel-api documentation:
> > * parent: set this to the parent device (or NULL) before calling
> > watchdog_register_device.
> >
> Hi Wim,
>
> We live and learn ... thanks a lot for the hint!
If it's about learning: the old way was vi
:
* parent: set this to the parent device (or NULL) before calling
watchdog_register_device.
Hi Wim,
We live and learn ... thanks a lot for the hint!
If it's about learning: the old way was via miscdevice.parent ... I think some
old
drivers still do this.
Kind regards,
Wim
Hi Johannes,
On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote:
[...]
+ watchdog_set_drvdata(a21_wdt, drv);
I am missing the initialisation of the watchdog's timeout value here...
This watchdog only knows two timeout values, 1s and 30s with the constraint
that you
:
* parent: set this to the parent device (or NULL) before calling
watchdog_register_device.
Hi Wim,
unfortunately that only works if the driver is instantiated as platform
driver,
PCI driver, or similar, where a parent device exists. Some drivers are,
however,
instantiated directly
Hi Guenter,
On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote:
On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote:
[...]
+ watchdog_set_drvdata(a21_wdt, drv);
I am missing the initialisation of the watchdog's timeout value here
Hi Johannes,
Ok I'll do. Should I repost this as a change of this patch or the add driver
patch?
the add driver patch.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
device and behaviour of the driver will be correct
according to documentation which I copied to this thread.
If Wim says that if device doesn't support setting timeout in HW
then this ioctl can't be implemented in this way I am definitely OK with
it.
And I will remove this patch and will also
other external alarm not a reboot */
#define WDIOF_KEEPALIVEPING 0x8000 /* Keep alive ping reply */
(Example driver: wdt_pci.c )).
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
: set this to the parent device (or NULL) before calling
watchdog_register_device.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
gt; +err_register_wd:
> + mutex_destroy(>lock);
> +
> + return ret;
> +}
> +
> +static int a21_wdt_remove(struct platform_device *pdev)
> +{
> + struct a21_wdt_drv *drv = dev_get_drvdata(>dev);
> +
> + dev_warn(>dev,
> + "Unreg
Hi Johannes,
> Of cause I'll do, but unfortunately I probably won't be able to do it today,
> mind if you get the patch tomorrow?
I don't mind. There is no rush. Just take the time you need to change the code
and do your testing.
Kind regards,
wim.
--
To unsubscribe from this list
Hi Johannes,
Of cause I'll do, but unfortunately I probably won't be able to do it today,
mind if you get the patch tomorrow?
I don't mind. There is no rush. Just take the time you need to change the code
and do your testing.
Kind regards,
wim.
--
To unsubscribe from this list: send
= a21_wdt_ids,
+ },
+};
+
+module_platform_driver(a21_wdt_driver);
+
+MODULE_AUTHOR(MEN Mikro Elektronik);
+MODULE_DESCRIPTION(MEN A21 Watchdog);
+MODULE_LICENSE(GPL);
+MODULE_ALIAS(platform:a21-watchdog);
--
1.7.9.5
For the rest this looks OK.
Kind regards,
wim.
--
To unsubscribe
in the /sys/class/... tree. In iTCO_wdt.c you have the following code
that does that: iTCO_wdt_watchdog_dev.parent = dev-dev.parent;
From the watchdog-kernel-api documentation:
* parent: set this to the parent device (or NULL) before calling
watchdog_register_device.
Kind regards,
Wim
501 - 600 of 937 matches
Mail list logo
