On 2019/3/14 14:27, Naoya Horiguchi wrote:
> Hi,
>
> On Wed, Mar 13, 2019 at 12:03:20AM +0800, zhong jiang wrote:
> ...
>> Minchan has changed the conditon check from BUG_ON to WARN_ON_ONCE in
>> try_to_unmap_one.
>> However, It is still an abnormal condition wh
.
Because page is locked , Its page flags should not be changed except for
PageSwapBacked.
Thanks,
zhong jiang
[ 16.918386] random: sshd: uninitialized urandom read (32 bytes read)
[ 17.159274] random: fast init done
[ 18.025596] urandom_read: 1 callbacks suppressed
[ 18.025610] random
On 2019/3/6 10:05, Andrea Arcangeli wrote:
> Hello everyone,
>
> [ CC'ed Mike and Peter ]
>
> On Tue, Mar 05, 2019 at 02:42:00PM +0800, zhong jiang wrote:
>> On 2019/3/5 14:26, Dmitry Vyukov wrote:
>>> On Mon, Mar 4, 2019 at 4:32 PM zhong jiang wrote:
>>>&
On 2019/3/7 2:29, Andrea Arcangeli wrote:
> Hello Zhong,
>
> On Wed, Mar 06, 2019 at 09:07:00PM +0800, zhong jiang wrote:
>> The patch use call_rcu to delay free the task_struct, but It is possible to
>> free the task_struct
>> ahead of get_mem_cgroup_from_mm. is it
On 2019/3/6 16:12, Peter Xu wrote:
> On Wed, Mar 06, 2019 at 03:41:06PM +0800, zhong jiang wrote:
>> On 2019/3/6 14:26, Mike Rapoport wrote:
>>> Hi,
>>>
>>> On Wed, Mar 06, 2019 at 01:53:12PM +0800, zhong jiang wrote:
>>>> On 2019/3/6 10:
On 2019/3/6 14:26, Mike Rapoport wrote:
> Hi,
>
> On Wed, Mar 06, 2019 at 01:53:12PM +0800, zhong jiang wrote:
>> On 2019/3/6 10:05, Andrea Arcangeli wrote:
>>> Hello everyone,
>>>
>>> [ CC'ed Mike and Peter ]
>>>
>>> On Tue, Mar 05, 2019
On 2019/3/6 10:05, Andrea Arcangeli wrote:
> Hello everyone,
>
> [ CC'ed Mike and Peter ]
>
> On Tue, Mar 05, 2019 at 02:42:00PM +0800, zhong jiang wrote:
>> On 2019/3/5 14:26, Dmitry Vyukov wrote:
>>> On Mon, Mar 4, 2019 at 4:32 PM zhong jiang wrote:
>>>&
On 2019/3/5 14:26, Dmitry Vyukov wrote:
> On Mon, Mar 4, 2019 at 4:32 PM zhong jiang wrote:
>> On 2019/3/4 22:11, Dmitry Vyukov wrote:
>>> On Mon, Mar 4, 2019 at 3:00 PM zhong jiang wrote:
>>>> On 2019/3/4 15:40, Dmitry Vyukov wrote:
>>>>> On S
On 2019/3/5 5:51, Matthew Wilcox wrote:
> On Mon, Mar 04, 2019 at 12:19:32AM +0800, zhong jiang wrote:
>> I also hit the following issue. but it fails to reproduce the issue by the
>> log.
>>
>> it seems to the case that we access the mm->owner and deference
On 2019/3/4 22:11, Dmitry Vyukov wrote:
> On Mon, Mar 4, 2019 at 3:00 PM zhong jiang wrote:
>> On 2019/3/4 15:40, Dmitry Vyukov wrote:
>>> On Sun, Mar 3, 2019 at 5:19 PM zhong jiang wrote:
>>>> Hi, guys
>>>>
>>>> I also hit th
On 2019/3/4 15:40, Dmitry Vyukov wrote:
> On Sun, Mar 3, 2019 at 5:19 PM zhong jiang wrote:
>> Hi, guys
>>
>> I also hit the following issue. but it fails to reproduce the issue by the
>> log.
>>
>> it seems to the case that we access the mm->owner a
Thanks,
zhong jiang
On 2018/12/4 23:43, syzbot wrote:
> syzbot has found a reproducer for the following crash on:
>
> HEAD commit:0072a0c14d5b Merge tag 'media/v4.20-4' of git://git.kernel..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=11
On 2019/3/1 15:29, Naoya Horiguchi wrote:
> On Tue, Feb 26, 2019 at 10:34:32PM +0800, zhong jiang wrote:
>> On 2019/2/26 21:51, Kirill A. Shutemov wrote:
>>> On Tue, Feb 26, 2019 at 07:18:00PM +0800, zhong jiang wrote:
>>>> From: zhongjiang
>>>>
>>
On 2019/2/26 21:51, Kirill A. Shutemov wrote:
> On Tue, Feb 26, 2019 at 07:18:00PM +0800, zhong jiang wrote:
>> From: zhongjiang
>>
>> When soft_offline_in_use_page() runs on a thp tail page after pmd is plit,
> s/plit/split/
>
>> we trigger the following VM_BU
From: zhongjiang
When soft_offline_in_use_page() runs on a thp tail page after pmd is plit,
we trigger the following VM_BUG_ON_PAGE():
Memory failure: 0x3755ff: non anonymous thp
__get_any_page: 0x3755ff: unknown zero refcount page type 2f8000
Soft offlining pfn 0x34d805 at process
to call for ideas.
Have you hit the really issue or just review the code ?
I did hit the issue and fixed in the upstream patch unpredictably by the
following patch.
e5d9998f3e09 ("slub: make ->cpu_partial unsigned int")
Thanks,
zhong jiang
> Signed-off-by: Wengang Wang
> ---
>
to call for ideas.
Have you hit the really issue or just review the code ?
I did hit the issue and fixed in the upstream patch unpredictably by the
following patch.
e5d9998f3e09 ("slub: make ->cpu_partial unsigned int")
Thanks,
zhong jiang
> Signed-off-by: Wengang Wang
> ---
>
+LKML
I can not find the possibility when I check the code. because the mmap_sem and
spin_lock will
protect the concurrence.
I will be appreciated if anyone has some clue.
Thanks,
zhong jiang
On 2018/11/8 23:01, zhong jiang wrote:
> Hi,
>
> Recently, I hit the following issue
+LKML
I can not find the possibility when I check the code. because the mmap_sem and
spin_lock will
protect the concurrence.
I will be appreciated if anyone has some clue.
Thanks,
zhong jiang
On 2018/11/8 23:01, zhong jiang wrote:
> Hi,
>
> Recently, I hit the following issue
tx_empty is not used after setting its value. It is safe to remove
the unused variable.
Signed-off-by: zhong jiang
---
drivers/tty/serial/pch_uart.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index cb85002..9ed121f 100644
tx_empty is not used after setting its value. It is safe to remove
the unused variable.
Signed-off-by: zhong jiang
---
drivers/tty/serial/pch_uart.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index cb85002..9ed121f 100644
tocuse is not used after setting its value. It is safe to remove
the unused variable.
Signed-off-by: zhong jiang
---
drivers/cdrom/gdrom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index 757e85b..b45c543 100644
tocuse is not used after setting its value. It is safe to remove
the unused variable.
Signed-off-by: zhong jiang
---
drivers/cdrom/gdrom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index 757e85b..b45c543 100644
It is not safe to dereference an object before a null test. It is
not needed and just remove them. Ftrace can be used instead.
Signed-off-by: zhong jiang
---
drivers/misc/cxl/guest.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index
It is not safe to dereference an object before a null test. It is
not needed and just remove them. Ftrace can be used instead.
Signed-off-by: zhong jiang
---
drivers/misc/cxl/guest.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index
On 2018/10/4 12:38, Greg KH wrote:
> On Thu, Oct 04, 2018 at 10:56:48AM +0800, zhong jiang wrote:
>> It is safe to dereference an object below a NULL test. For the sake
>> of debugging. Just delete the call of possible null pointer dereference.
>>
>> Signed-off-by: zhon
On 2018/10/4 12:38, Greg KH wrote:
> On Thu, Oct 04, 2018 at 10:56:48AM +0800, zhong jiang wrote:
>> It is safe to dereference an object below a NULL test. For the sake
>> of debugging. Just delete the call of possible null pointer dereference.
>>
>> Signed-off-by: zhon
It is safe to dereference an object below a NULL test. For the sake
of debugging. Just delete the call of possible null pointer dereference.
Signed-off-by: zhong jiang
---
drivers/misc/cxl/guest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/guest.c b
It is safe to dereference an object below a NULL test. For the sake
of debugging. Just delete the call of possible null pointer dereference.
Signed-off-by: zhong jiang
---
drivers/misc/cxl/guest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/guest.c b
On 2018/10/3 6:55, Greg KH wrote:
> On Wed, Sep 26, 2018 at 07:41:12PM +0800, zhong jiang wrote:
>> It is safe to move a deference below a NULL test.
>>
>> Signed-off-by: zhong jiang
>> Acked-by: Andrew Donnellan
>> ---
>> drivers/misc/cxl/guest.c | 4 ++--
On 2018/10/3 6:55, Greg KH wrote:
> On Wed, Sep 26, 2018 at 07:41:12PM +0800, zhong jiang wrote:
>> It is safe to move a deference below a NULL test.
>>
>> Signed-off-by: zhong jiang
>> Acked-by: Andrew Donnellan
>> ---
>> drivers/misc/cxl/guest.c | 4 ++--
Cc: # 4.4.x
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
Signed-off-by: zhong jiang
---
include/linux/slub_def.h | 3 ++-
mm/slub.c| 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
in
Cc: # 4.4.x
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
Signed-off-by: zhong jiang
---
include/linux/slub_def.h | 3 ++-
mm/slub.c| 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
in
Fix the following compile warning:
sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
but not used [-Wunused-function]
sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not
used [-Wunused-function]
Signed-off-by: zhong jiang
---
v1->v2:
- M
Fix the following compile warning:
sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
but not used [-Wunused-function]
sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not
used [-Wunused-function]
Signed-off-by: zhong jiang
---
v1->v2:
- M
On 2018/9/30 10:17, Joe Perches wrote:
> On Sun, 2018-09-30 at 09:45 +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
>> but not used [-Wunused-function]
>> sound/so
On 2018/9/30 10:17, Joe Perches wrote:
> On Sun, 2018-09-30 at 09:45 +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
>> but not used [-Wunused-function]
>> sound/so
Fix the following compile warning:
sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
but not used [-Wunused-function]
sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not
used [-Wunused-function]
Signed-off-by: zhong jiang
---
sound/soc
Fix the following compile warning:
sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
but not used [-Wunused-function]
sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not
used [-Wunused-function]
Signed-off-by: zhong jiang
---
sound/soc
These codes can be replaced with new inline vmf_error().
Signed-off-by: zhong jiang
---
fs/dax.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index b68ce48..e732f70 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1311,9 +1311,8 @@ static vm_fault_t
These codes can be replaced with new inline vmf_error().
Signed-off-by: zhong jiang
---
fs/dax.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index b68ce48..e732f70 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1311,9 +1311,8 @@ static vm_fault_t
On 2018/9/27 23:46, Greg KH wrote:
> On Thu, Sep 27, 2018 at 10:43:40PM +0800, zhong jiang wrote:
>> From: Alexey Dobriyan
>>
>> /*
>> * cpu_partial determined the maximum number of objects
>> * kept in the per cpu partial lists of a proc
On 2018/9/27 23:46, Greg KH wrote:
> On Thu, Sep 27, 2018 at 10:43:40PM +0800, zhong jiang wrote:
>> From: Alexey Dobriyan
>>
>> /*
>> * cpu_partial determined the maximum number of objects
>> * kept in the per cpu partial lists of a proc
On 2018/9/27 22:47, Stefan Schmidt wrote:
> Hello.
>
> On 19/09/2018 16:41, zhong jiang wrote:
>> The local variable 'i' is never used after being assigned.
>> hence it should be redundant adn can be removed.
>>
>> Signed-off-by: zhong jiang
>> ---
>>
On 2018/9/27 22:47, Stefan Schmidt wrote:
> Hello.
>
> On 19/09/2018 16:41, zhong jiang wrote:
>> The local variable 'i' is never used after being assigned.
>> hence it should be redundant adn can be removed.
>>
>> Signed-off-by: zhong jiang
>> ---
>>
tch is a effective
bugfix.
It should go into stable.
Signed-off-by: Alexey Dobriyan
Acked-by: Christoph Lameter
Cc: Pekka Enberg
Cc: David Rientjes
Cc: Joonsoo Kim
Cc: sta...@vger.kernel.org
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
Signed-off-by: zhong jiang
---
incl
tch is a effective
bugfix.
It should go into stable.
Signed-off-by: Alexey Dobriyan
Acked-by: Christoph Lameter
Cc: Pekka Enberg
Cc: David Rientjes
Cc: Joonsoo Kim
Cc: sta...@vger.kernel.org
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
Signed-off-by: zhong jiang
---
incl
delay.h and dma-mapping.h have duplicated include. hence just remove
redundant file.
Signed-off-by: zhong jiang
---
v1->v2:
- modify the subject
drivers/misc/genwqe/card_utils.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/gen
delay.h and dma-mapping.h have duplicated include. hence just remove
redundant file.
Signed-off-by: zhong jiang
---
v1->v2:
- modify the subject
drivers/misc/genwqe/card_utils.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/gen
On 2018/9/26 11:05, zhong jiang wrote:
> dma-mapping.h and delay.h have included twice. It is unnecessary. Meanwhile,
> Arrange header files in alphabetical sequence to improve readability.
>
> Signed-off-by: zhong jiang
> ---
> drivers/misc/genwqe/card_utils.c | 22 +
On 2018/9/26 11:05, zhong jiang wrote:
> dma-mapping.h and delay.h have included twice. It is unnecessary. Meanwhile,
> Arrange header files in alphabetical sequence to improve readability.
>
> Signed-off-by: zhong jiang
> ---
> drivers/misc/genwqe/card_utils.c | 22 +
On 2018/9/26 22:22, Michal Suchánek wrote:
> On Wed, 26 Sep 2018 19:46:08 +0800
> zhong jiang wrote:
>
>> It is safe to move dereference below a NULL test.
>>
>> Signed-off-by: zhong jiang
>> ---
>> arch/powerpc/kernel/cacheinfo.c | 5 ++---
>>
On 2018/9/26 22:22, Michal Suchánek wrote:
> On Wed, 26 Sep 2018 19:46:08 +0800
> zhong jiang wrote:
>
>> It is safe to move dereference below a NULL test.
>>
>> Signed-off-by: zhong jiang
>> ---
>> arch/powerpc/kernel/cacheinfo.c | 5 ++---
>>
On 2018/9/26 22:03, Andy Shevchenko wrote:
> On Wed, Sep 26, 2018 at 08:30:50PM +0800, zhong jiang wrote:
>> The dev is impossible is NULL. hence the check is redundant. We
>> never will hit it.
>>
> Reviewed-by: Andy Shevchenko
Thanks.
>> Signed-off-by:
On 2018/9/26 22:03, Andy Shevchenko wrote:
> On Wed, Sep 26, 2018 at 08:30:50PM +0800, zhong jiang wrote:
>> The dev is impossible is NULL. hence the check is redundant. We
>> never will hit it.
>>
> Reviewed-by: Andy Shevchenko
Thanks.
>> Signed-off-by:
It is safe to move a deference below a NULL test.
Signed-off-by: zhong jiang
---
drivers/misc/cxl/guest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index 3bc0c15..559e835 100644
--- a/drivers/misc/cxl/guest.c
It is safe to move a deference below a NULL test.
Signed-off-by: zhong jiang
---
drivers/misc/cxl/guest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index 3bc0c15..559e835 100644
--- a/drivers/misc/cxl/guest.c
dma-mapping.h and delay.h have included twice. It is unnecessary. Meanwhile,
Arrange header files in alphabetical sequence to improve readability.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff
dma-mapping.h and delay.h have included twice. It is unnecessary. Meanwhile,
Arrange header files in alphabetical sequence to improve readability.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff
On 2018/9/26 2:20, Greg KH wrote:
> On Thu, Sep 20, 2018 at 01:04:02PM +0800, zhong jiang wrote:
>> delay.h and dma-mapping.h have duplicated include. hence just remove
>> redundant file.
>>
>> Signed-off-by: zhong jiang
>> ---
>> drivers/misc/genwqe/ca
On 2018/9/26 2:20, Greg KH wrote:
> On Thu, Sep 20, 2018 at 01:04:02PM +0800, zhong jiang wrote:
>> delay.h and dma-mapping.h have duplicated include. hence just remove
>> redundant file.
>>
>> Signed-off-by: zhong jiang
>> ---
>> drivers/misc/genwqe/ca
On 2018/9/22 0:22, Mark Brown wrote:
> On Fri, Sep 21, 2018 at 06:24:58PM +0800, zhong jiang wrote:
>> We include wait.h twice in q6adm.c. it is unnecessary. hence remove
>> it. Further, order the include files as alphabet.
> Please use subject lines matching the style
On 2018/9/22 0:22, Mark Brown wrote:
> On Fri, Sep 21, 2018 at 06:24:58PM +0800, zhong jiang wrote:
>> We include wait.h twice in q6adm.c. it is unnecessary. hence remove
>> it. Further, order the include files as alphabet.
> Please use subject lines matching the style
Commit-ID: 8e6b65a1b6cd1711d3acd2aa5c60d38c3e15dabb
Gitweb: https://git.kernel.org/tip/8e6b65a1b6cd1711d3acd2aa5c60d38c3e15dabb
Author: zhong jiang
AuthorDate: Thu, 13 Sep 2018 10:49:45 +0800
Committer: Borislav Petkov
CommitDate: Sat, 15 Sep 2018 14:57:05 +0200
x86/CPU: Fix unused
Commit-ID: 8e6b65a1b6cd1711d3acd2aa5c60d38c3e15dabb
Gitweb: https://git.kernel.org/tip/8e6b65a1b6cd1711d3acd2aa5c60d38c3e15dabb
Author: zhong jiang
AuthorDate: Thu, 13 Sep 2018 10:49:45 +0800
Committer: Borislav Petkov
CommitDate: Sat, 15 Sep 2018 14:57:05 +0200
x86/CPU: Fix unused
On 2018/9/21 22:26, Maxime Ripard wrote:
> On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote:
>> On 2018/9/19 16:47, Maxime Ripard wrote:
>>> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
>>>> Fix the following compile warning:
>>>&g
On 2018/9/21 22:26, Maxime Ripard wrote:
> On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote:
>> On 2018/9/19 16:47, Maxime Ripard wrote:
>>> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
>>>> Fix the following compile warning:
>>>&g
kfree has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree.
Signed-off-by: zhong jiang
---
drivers/devfreq/devfreq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq
kfree has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree.
Signed-off-by: zhong jiang
---
drivers/devfreq/devfreq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq
kcalloc should be sizeof(*cpu_groups) instead of sizeof(cpu_groups).
Signed-off-by: zhong jiang
---
drivers/firmware/psci_checker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/psci_checker.c b/drivers/firmware/psci_checker.c
index 3469436..26afabc 100644
kcalloc should be sizeof(*cpu_groups) instead of sizeof(cpu_groups).
Signed-off-by: zhong jiang
---
drivers/firmware/psci_checker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/psci_checker.c b/drivers/firmware/psci_checker.c
index 3469436..26afabc 100644
We include wait.h twice in q6adm.c. it is unnecessary. hence remove
it. Further, order the include files as alphabet.
Signed-off-by: zhong jiang
---
sound/soc/qcom/qdsp6/q6adm.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/sound/soc/qcom/qdsp6/q6adm.c b
We include wait.h twice in q6adm.c. it is unnecessary. hence remove
it. Further, order the include files as alphabet.
Signed-off-by: zhong jiang
---
sound/soc/qcom/qdsp6/q6adm.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/sound/soc/qcom/qdsp6/q6adm.c b
debugfs_remove_recursive has taken the null pointer into account.
just remove the null check before debugfs_remove_recursive.
Acked-by: Masami Hiramatsu
Signed-off-by: zhong jiang
---
kernel/fail_function.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel
debugfs_remove_recursive has taken the null pointer into account.
just remove the null check before debugfs_remove_recursive.
Acked-by: Masami Hiramatsu
Signed-off-by: zhong jiang
---
kernel/fail_function.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel
Hi Jiri
Can you pick up the patch?
Thanks
zhong jiang
On 2018/9/13 15:41, zhong jiang wrote:
> Fix the following compile warning:
>
> drivers/hid/hid-logitech-hidpp.c: In function 'hi_res_scroll_enable':
> drivers/hid/hid-logitech-hidpp.c:2714:54: warning: 'multiplier'
Hi Jiri
Can you pick up the patch?
Thanks
zhong jiang
On 2018/9/13 15:41, zhong jiang wrote:
> Fix the following compile warning:
>
> drivers/hid/hid-logitech-hidpp.c: In function 'hi_res_scroll_enable':
> drivers/hid/hid-logitech-hidpp.c:2714:54: warning: 'multiplier'
kfree_skb has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree_skb.
Signed-off-by: zhong jiang
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +--
drivers/infiniband/hw/cxgb4/qp.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions
kfree_skb has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree_skb.
Signed-off-by: zhong jiang
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +--
drivers/infiniband/hw/cxgb4/qp.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions
module.h has duplicated include. hence just remove
redundant include file.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card_ddcb.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
module.h has duplicated include. hence just remove
redundant include file.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card_ddcb.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
delay.h and dma-mapping.h have duplicated include. hence just remove
redundant file.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index f0961ec..3fcb9a2
delay.h and dma-mapping.h have duplicated include. hence just remove
redundant file.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index f0961ec..3fcb9a2
The function should return -EFAULT when copy_from_user fails. Even
though the caller does not distinguish them. but we should keep backward
compatibility.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff
The function should return -EFAULT when copy_from_user fails. Even
though the caller does not distinguish them. but we should keep backward
compatibility.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff
On 2018/9/19 17:52, zhong jiang wrote:
> FIELD_SIZEOF is defined as a macro to calculate the specified vaule.
> Therefore,
> We prefer to use the macro rather than calculating its vaule.
s/vaule/value . will resend .
Thanks,
zhong jiang
> Signed-off-by: zhong jiang
>
On 2018/9/19 17:52, zhong jiang wrote:
> FIELD_SIZEOF is defined as a macro to calculate the specified vaule.
> Therefore,
> We prefer to use the macro rather than calculating its vaule.
s/vaule/value . will resend .
Thanks,
zhong jiang
> Signed-off-by: zhong jiang
>
On 2018/9/19 16:47, Maxime Ripard wrote:
> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be used
>> uninitialized in this function [-Wm
On 2018/9/19 16:47, Maxime Ripard wrote:
> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be used
>> uninitialized in this function [-Wm
zed
in this function [-Wmaybe-uninitialized]
return ret < 0 ? 0 : le16_to_cpu(ent.len);
drivers/soc/qcom/cmd-db.c:269:24: warning: ent.addr may be used uninitialized
in this function [-Wmaybe-uninitialized]
addr = le32_to_cpu(ent.addr);
Signed-off-by: zhong jiang
---
drivers/soc/qcom/cmd-db
zed
in this function [-Wmaybe-uninitialized]
return ret < 0 ? 0 : le16_to_cpu(ent.len);
drivers/soc/qcom/cmd-db.c:269:24: warning: ent.addr may be used uninitialized
in this function [-Wmaybe-uninitialized]
addr = le32_to_cpu(ent.addr);
Signed-off-by: zhong jiang
---
drivers/soc/qcom/cmd-db
I find the following warning when compiling the kernel.
kernel/sched/psi.c:639:13: warning: 'rq' may be used uninitialized in this
function [-Wmaybe-uninitialized]
struct rq *rq;
Signed-off-by: zhong jiang
---
kernel/sched/psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
I find the following warning when compiling the kernel.
kernel/sched/psi.c:639:13: warning: 'rq' may be used uninitialized in this
function [-Wmaybe-uninitialized]
struct rq *rq;
Signed-off-by: zhong jiang
---
kernel/sched/psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 2018/9/19 1:17, Andy Gross wrote:
> On Tue, Sep 18, 2018 at 01:06:48PM +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> drivers/soc/qcom/cmd-db.c:194:38: warning: 'ent.addr' may be used
>> uninitialized in this function [-Wmaybe-uninitializ
On 2018/9/19 1:17, Andy Gross wrote:
> On Tue, Sep 18, 2018 at 01:06:48PM +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> drivers/soc/qcom/cmd-db.c:194:38: warning: 'ent.addr' may be used
>> uninitialized in this function [-Wmaybe-uninitializ
kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.
Signed-off-by: zhong jiang
---
drivers/media/usb/dvb-usb-v2/gl861.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2
kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.
Signed-off-by: zhong jiang
---
drivers/media/usb/dvb-usb-v2/gl861.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2
On 2018/9/18 23:10, Greg KH wrote:
> On Tue, Sep 18, 2018 at 11:00:37PM +0800, zhong jiang wrote:
>> Hi, Greg
>>
>> Can you pick up the patch?
> Nope, sorry, as before, work with the maintainers please.
Thank you for your reply timely .:-)
Sincerely,
zhong jiang
> greg k-h
>
> .
>
On 2018/9/18 23:10, Greg KH wrote:
> On Tue, Sep 18, 2018 at 11:00:37PM +0800, zhong jiang wrote:
>> Hi, Greg
>>
>> Can you pick up the patch?
> Nope, sorry, as before, work with the maintainers please.
Thank you for your reply timely .:-)
Sincerely,
zhong jiang
> greg k-h
>
> .
>
Hi, Greg
Can you pick up the patch?
Thanks,
zhong jiang
On 2018/8/23 19:38, zhong jiang wrote:
> On 2018/8/13 22:20, don.br...@microchip.com wrote:
>>> -Original Message-
>>> From: zhong jiang [mailto:zhongji...@huawei.com]
>>> Sent: Monday, August 1
101 - 200 of 759 matches
Mail list logo
