Hi Jiri,
Thanks for your good coding review for this patch, it helps us a lot!
> From: Jiri Slaby
> Sent: Tuesday, July 14, 2020 5:34 PM
> To: Johnson CH Chen (陳昭勳) ; Greg
> Kroah-Hartman
> Cc: linux-kernel@vger.kernel.org; linux-ser...@vger.kernel.org
> Subject: Re: [PA
Add am335x-moxa-uc-8100-common.dtsi for many products of MOXA UC-8100
series, and remove common nodes from am335x-moxa-uc-8100-me-t.dts.
Signed-off-by: Johnson Chen
---
.../boot/dts/am335x-moxa-uc-8100-common.dtsi | 427 ++
.../arm/boot/dts/am335x-moxa-uc-8100-me-t.dts | 404
Hi Greg,
Thanks for your detailed good review!
> From: Greg Kroah-Hartman
> Sent: Tuesday, July 14, 2020 3:12 PM
> To: Johnson CH Chen (陳昭勳)
> Cc: Jiri Slaby ; linux-kernel@vger.kernel.org;
> linux-ser...@vger.kernel.org
> Subject: Re: [PATCH] tty: Add MOXA NPort Real TTY
Hi Greg,
Thanks for your response!
> > > > + unsigned long flag;
> > > > + unsigned char cmd_buffer[84];
> > > > + unsigned char rsp_buffer[84];
> > >
> > > You seem to have two "static" buffers here, for your device, that
> > > you semi-randomly write to all over the place,
Hi Alexandre,
> > v4->v5:
> > - Fix reported build error by replacing RTC_DRV_DS1374_WDT with
> > WATCHDOG_CORE
> >
>
> This is not the correct solution as this will remove the alarm functionality
> for
> anyone enabling WATCHDOG. I already submitted a proper fix.
>
It's an appropriate and
Let ds1374 watchdog use watchdog core functions. It also includes
improving watchdog timer setting and nowayout, and just uses ioctl()
of watchdog core.
Signed-off-by: Johnson Chen
Reported-by: Randy Dunlap
---
v4->v5:
- Fix reported build error by replacing RTC_DRV_DS1374_WDT with
Hi Stephen,
> From: Stephen Rothwell
> Sent: Saturday, July 18, 2020 9:39 AM
> To: Randy Dunlap
> Cc: Linux Next Mailing List ; Linux Kernel Mailing
> List ; linux-...@vger.kernel.org; Alessandro
> Zummo ; Alexandre Belloni
> ; Scott Wood ;
> Johnson CH Chen (陳昭勳)
&
Hi Greg,
Thanks for detailed and good suggestions!
> From: linux-serial-ow...@vger.kernel.org
> On Behalf Of Greg Kroah-Hartman
> Sent: Tuesday, July 14, 2020 3:36 PM
> To: Johnson CH Chen (陳昭勳)
> Cc: Jiri Slaby ; linux-kernel@vger.kernel.org;
> linux-ser...@vger.kernel
This driver supports tty functions for all of MOXA's NPort series
with v5.0. Using this driver, host part can use tty to connect NPort
device server by ethernet.
The following Moxa products are supported:
* CN2600 Series
* CN2500 Series
* NPort DE Series
* NPort 5000A-M12 Series
* NPort 5100
Dear Alexandre Belloni,
> From: Guenter Roeck On Behalf Of Guenter Roeck
> Sent: Thursday, July 9, 2020 11:28 PM
> To: Johnson CH Chen (陳昭勳) ;
> linux-kernel@vger.kernel.org; linux-...@vger.kernel.org;
> linux-watch...@vger.kernel.org
> Cc: Wim Van Sebroeck ; a.
Let ds1374 watchdog use watchdog core functions. It also includes
improving watchdog timer setting and nowayout, and just uses ioctl()
of watchdog core.
Signed-off-by: Johnson Chen
---
v3->v4:
- Fix coding styles
- Remove dev_info() in ds1374_wdt_settimeout()
- Fix missing error check
v2->v3:
Hi,
> Subject: Re: [PATCH 2/2] ARM: dts: am335x: add support for Moxa
> UC-8100A-ME open platform
>
> * Johnson CH Chen (陳昭勳) [200707 03:24]:
> > UC-8100A-ME is advanced of UC-8100-ME-T, and UC-8100-ME-T is
> deprecated.
> >
> > UC-8100A-ME provides larger R
Hello all,
UC-8100A-ME is advanced of UC-8100-ME-T, and UC-8100-ME-T is deprecated.
UC-8100A-ME provides larger RAM and eMMC, better input current than
UC-8100-ME-T's, and it supports selectable LTE module for US/EU/APAC.
1. Replace UC-8100-ME-T with UC-8100A-ME for dt-bindings
2. add dts
UC-8100-ME-T is deprecated, and UC-8100A-ME is advanced of UC-8100-ME-T,
so replace UC-8100-ME-T with UC-8100A-ME.
Signed-off-by: Johnson Chen
---
Documentation/devicetree/bindings/arm/omap/omap.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
UC-8100A-ME is advanced of UC-8100-ME-T, and UC-8100-ME-T is deprecated.
UC-8100A-ME provides larger RAM and eMMC, better input current than
UC-8100-ME-T's, and it supports selectable LTE module for US/EU/APAC.
UC-8100A-ME computing platform is designed for embedded data acquisition
industrial
Let ds1374 watchdog use watchdog core functions. It also includes
improving watchdog timer setting and nowayout, and just uses ioctl()
of watchdog core.
Signed-off-by: Johnson Chen
Reported-by: kernel test robot
v2->v3:
- Fix a problem reported by WATCHDOG_CORE if WATCHDOG
- Remove save_client
Hi,
> > > > + ret = devm_watchdog_register_device(>dev, >wdt);
> > > > if (ret) {
> > > > - misc_deregister(_miscdev);
> > > > + dev_err(>dev, "failed to register DS1374
> > > > watchdog
> > > > +device\n");
>
> There was no error message before, I
Hi,
Thanks for your good suggestions!
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index
> > b54d87d45c89..5e2444af5657 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -282,6 +282,7 @@ config RTC_DRV_DS1374 config
> RTC_DRV_DS1374_WDT
> > bool
Let ds1374 watchdog use watchdog core functions. It also includes
improving watchdog timer setting and nowayout, and just uses ioctl()
of watchdog core.
Signed-off-by: Johnson Chen
Reported-by: kernel test robot
v1->v2:
- Use ds1374_wdt_settimeout() before registering the watchdog
- Remove
Hi,
> > diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c index
> > 9c51a12cf70f..25b28f7546ff 100644
> > --- a/drivers/rtc/rtc-ds1374.c
> > +++ b/drivers/rtc/rtc-ds1374.c
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /*
> > * RTC client/driver for the
Let ds1374 watchdog use watchdog core. It also includes
improving watchdog timer setting and nowayout, and just uses ioctl()
of watchdog core.
Signed-off-by: Johnson Chen
---
drivers/rtc/rtc-ds1374.c | 257 ++-
1 file changed, 67 insertions(+), 190
Hi,
> On 6/22/20 11:28 PM, Johnson CH Chen (陳昭勳) wrote:
> > Hi,
> >
> > Thanks for your good detailed suggestions!
> >
>
> Other feedback suggests to convert the driver to use the watchdog core in the
> rtc code. I would suggest to follow that suggestion.
>
Hi,
> On 22/06/2020 07:26:56-0700, Guenter Roeck wrote:
> > On Mon, Jun 22, 2020 at 12:14:13PM +0100, Lee Jones wrote:
> > > On Mon, 22 Jun 2020, Johnson CH Chen (陳昭勳) wrote:
> > >
> > > > Dallas/Maxim DS1374 is a counter designed to continuously count
>
Hi,
Thanks for your good detailed suggestions!
> > + * It would be more efficient to use i2c msgs/i2c_transfer directly
> > +but, as
> > + * recommened in .../Documentation/i2c/writing-clients section
> > + * "Sending and receiving", using SMBus level communication is preferred.
> > + */
> > +
>
Hi,
>
> Hi,
>
> On 22/06/2020 10:03:25+, Johnson CH Chen (陳昭勳) wrote:
> > Hello all,
> >
> > This patch set uses MFD structure for DS1374 so that RTC and Watchdog
> > functions can be separately. Therefore, we can add more Watchdog
> > subfuncti
Here provide Watchdog function from rtc-ds1374.c which is in RTC subsystem
originally. Besides, add nowayout and implement Watchdog margin time when
DS1374 Watchdog device is found.
Signed-off-by: Johnson Chen
---
drivers/watchdog/Kconfig | 11 ++
drivers/watchdog/Makefile | 1 +
Move Watchdog function to ds1374_wdt.c which is in the Watchdog
subsystem, and just keep RTC and Alarm function in rtc-ds1374.c.
Besides, Move I2C client to ds1374.c which is in MFD subsystem.
Signed-off-by: Johnson Chen
---
drivers/rtc/Kconfig | 9 +-
drivers/rtc/rtc-ds1374.c | 458
Dallas/Maxim DS1374 is a counter designed to continuously count
time in seconds. It provides an I2C interface to the host to
access RTC clock or Alarm/Watchdog timer.
Add MFD Core driver, supporting the I2C communication to RTC and
Watchdog devices.
Signed-off-by: Johnson Chen
---
Hello all,
This patch set uses MFD structure for DS1374 so that RTC and Watchdog
functions can be separately. Therefore, we can add more Watchdog
subfunctions here.
A DS1374 MFD core driver supports the I2C communication to RTC and
Watchdog devices.
1. Add DS1374 MFD core driver with I2C bus.
29 matches
Mail list logo
