Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Oct 2, 2012 at 6:08 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Oct 01, 2012 at 08:54:23PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 5:39 PM, Mark Brown Why would that be helpful? Most platforms don't support DT at all, and I'm not sure

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 4:31 PM, Sourav Poddar sourav.pod...@ti.com wrote: smsc ece1099 is a keyboard scan or gpio expansion device. The patch create keypad and gpio expander child for this multi function smsc driver. Tested on omap5430 evm with 3.6-rc6 custom kernel. Can we have this

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Oct 01, 2012 at 05:00:06PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 4:31 PM, Sourav Poddar sourav.pod...@ti.com wrote: Delete irrelevant context from your replies, it makes

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 5:39 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Oct 01, 2012 at 05:23:15PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown No, this is not at all sensible - if there's an mfd_remove_devices() function we

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Sun, Sep 30, 2012 at 10:17 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 28-09-2012 14:53, Kishon Vijay Abraham I wrote: Added dwc3 support for dwc3 core and update the documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham

Re: [PATCH v2 1/2] usb: phy: add a new driver for usb3 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Sep 27, 2012 at 7:48 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Sep 27, 2012 at 07:34:07PM +0530, Kishon Vijay Abraham I wrote: +static int omap5_usb_phy_power(struct omap_usb *phy, bool on) +{ + u32 val; + unsigned long rate; + struct clk

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 4:18 AM, Cousson, Benoit b-cous...@ti.com wrote: On 9/27/2012 7:24 AM, Rob Herring wrote: On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring robherri...@gmail.com wrote: On 09/06/2012 09:57 AM, Kishon Vijay

Re: [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:27 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Sep 28, 2012 at 06:23:10PM +0530, Kishon Vijay Abraham I wrote: Used of_platform_populate() to populate dwc3 core platform_device from device tree data. Since now the allocation of unique device id is handled

Re: [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:28 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Sep 28, 2012 at 06:23:11PM +0530, Kishon Vijay Abraham I wrote: Before accessing any register, runtime API's should be invoked to enable the clocks. runtime API's are added here to prevent abort during register

Re: [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:29 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Sep 28, 2012 at 06:23:13PM +0530, Kishon Vijay Abraham I wrote: Add an API in the omap glue layer to write to the mailbox register which can be used by comparator driver(twl). To pass the detection of the

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:32 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Sep 28, 2012 at 06:23:15PM +0530, Kishon Vijay Abraham I wrote: Added dwc3 support for dwc3 core and update the documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 8:42 PM, Cousson, Benoit b-cous...@ti.com wrote: On 9/28/2012 3:07 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Fri, Sep 28, 2012 at 4:18 AM, Cousson, Benoit b-cous...@ti.com wrote: On 9/27/2012 7:24 AM, Rob Herring wrote: On 09/25/2012 05:06 AM, ABRAHAM, KISHON

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-27 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Sep 27, 2012 at 7:54 PM, Rob Herring robherri...@gmail.com wrote: On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring robherri...@gmail.com wrote: On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: All phy related programming

Re: [RFC PATCH] drivers: phy: add generic PHY framework

2012-09-26 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 17, 2012 at 3:03 PM, Marc Kleine-Budde m...@pengutronix.de wrote: On 09/14/2012 03:06 PM, ABRAHAM, KISHON VIJAY wrote: [...] diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c new file mode 100644 index 000..c55446a --- /dev/null +++ b/drivers/phy/phy-core.c

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-26 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 26, 2012 at 11:57 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Sep 26, 2012 at 11:10:48AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi, On Wed, Sep 19, 2012 at 5:26 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring robherri...@gmail.com wrote: On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 19, 2012 at 5:26 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote: usb_otg_ss_refclk960m is needed by usb2 phy present in omap5. For omap4, the clk_get of this clock will fail since it does not have this clock.

Re: [PATCH v3] USB: PHY: Re-organize Tegra USB PHY driver

2012-09-24 Thread ABRAHAM, KISHON VIJAY
Hi, On Sat, Sep 22, 2012 at 2:08 PM, Venu Byravarasu vbyravar...@nvidia.com wrote: -Original Message- From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Friday, September 21, 2012 9:45 PM To: ABRAHAM, KISHON VIJAY Cc: Venu Byravarasu; ba...@ti.com; gre...@linuxfoundation.org

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-09-21 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 19, 2012 at 8:11 PM, Marc Kleine-Budde m...@pengutronix.de wrote: On 09/19/2012 01:30 PM, Kishon Vijay Abraham I wrote: Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. This also includes device tree support for usb3 phy

Re: [PATCH v3] USB: PHY: Re-organize Tegra USB PHY driver

2012-09-21 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 21, 2012 at 5:50 PM, Venu Byravarasu vbyravar...@nvidia.com wrote: NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc. In order to support USB PHY drivers on these SoCs, existing PHY driver is split into SoC agnostic common USB PHY driver and Tegra20-specific USB phy

Re: [RFC PATCH] drivers: phy: add generic PHY framework

2012-09-16 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 17, 2012 at 6:50 AM, Chen Peter-B29397 b29...@freescale.com wrote: The PHY framework provides a set of API's for the PHY drivers to create/remove a PHY and the PHY users to obtain a reference to the PHY using or without using phandle. If the PHY users has to obtain a

Re: [RFC PATCH] drivers: phy: add generic PHY framework

2012-09-14 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 14, 2012 at 5:58 PM, Marc Kleine-Budde m...@pengutronix.de wrote: On 09/14/2012 01:58 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of API's for the PHY drivers to create/remove a PHY and the PHY users to obtain a reference to the PHY using or without

Re: [PATCH v2] USB: PHY: Re-organize Tegra USB PHY driver

2012-09-13 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Sep 13, 2012 at 12:32 PM, Venu Byravarasu vbyravar...@nvidia.com wrote: NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc. In order to support USB PHY drivers on these SoCs, existing PHY driver is split into SoC agnostic common USB PHY driver and Tegra20-specific USB phy

Re: [PATCH v2] arm: omap: hwmod: make *phy_48m* as the main_clk of ocp2scp

2012-09-12 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 12, 2012 at 3:58 AM, Paul Walmsley p...@pwsan.com wrote: Hi Kishon, BenoƮt, On Fri, 7 Sep 2012, Kishon Vijay Abraham I wrote: Made *ocp2scp_usb_phy_phy_48m* as the main_clk for ocp2scp. Since this ocp2scp module does not have any fck but does have a single opt_clock, it is

Re: [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi Benoit, On Tue, Sep 11, 2012 at 1:55 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: No major change from the previous version. Just removed the omap-usb2 dt data and sent that as a separate patch. Well, I think you'd better keep them in

Re: [PATCH] arm/dts: omap: Add omap-usb2 dt data

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 1:53 PM, Benoit Cousson b-cous...@ti.com wrote: Hi Kishon, On 09/11/2012 08:12 AM, Kishon Vijay Abraham I wrote: Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is connected to ocp2scp, omap-usb2 dt data is added as a child node of ocp2scp.

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 10, 2012 at 10:13 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Sep 10, 2012 at 06:17:03PM +0200, Benoit Cousson wrote: On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: The mailbox register for usb otg in omap is present in control module. On detection of any events

Re: [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 2:41 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 10:44 AM, ABRAHAM, KISHON VIJAY wrote: Hi Benoit, On Tue, Sep 11, 2012 at 1:55 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: No major change from

Re: [PATCH v2 1/3] arm/dts: Add twl6030-usb data

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 2:56 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: Add twl6030-usb data node in twl6030 device tree file Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com ---

Re: [PATCH v2 2/3] arm/dts: Add twl4030-usb data

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 3:39 PM, Benoit Cousson b-cous...@ti.com wrote: On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: Add twl4030-usb data node in twl4030 device tree file. IIRC, the usb part on twl4030 was doing more than it does on twl6030. Indeed. twl4030 is the usb phy as

Re: [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 3:23 PM, Vaibhav Hiremath hvaib...@ti.com wrote: On 9/11/2012 2:39 PM, Kishon Vijay Abraham I wrote: Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I

Re: [PATCH v7 1/7] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Aug 6, 2012 at 6:37 PM, Kishon Vijay Abraham I kis...@ti.com wrote: All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related functionality like srp. This also includes device tree

Re: [PATCH] arm: omap: hwmod: make *phy_48m* as the main_clk of ocp2scp

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 2, 2012 at 2:25 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Made *ocp2scp_usb_phy_phy_48m* as the main_clk for ocp2scp. Since this ocp2scp module does not have any fck but does have a single opt_clock, it is added as the main_clk for ocp2scp. Also removed phy_48m as the

Re: [RFC PATCH 2/5] arm: omap: remove ocp2scp_usb_phy_ick clock node

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, May 30, 2012 at 4:26 PM, Kishon Vijay Abraham I kis...@ti.com wrote: ocp2scp_usb_phy_ick clock node was a fake clock node created to control MODULEMODE of ocp2scp. Since the hwmod for ocp2scp is now added (which can be used to control MODULEMODE) this clock node is removed. Cc:

Re: linux-next: Tree for Aug 23 (drivers/bus/omap-ocp2scp.c)

2012-08-23 Thread ABRAHAM, KISHON VIJAY
On Thu, Aug 23, 2012 at 10:09 PM, Randy Dunlap rdun...@xenotime.net wrote: On 08/22/2012 10:22 PM, Stephen Rothwell wrote: Hi all, Changes since 20120822: on i386: CC [M] drivers/bus/omap-ocp2scp.o drivers/bus/omap-ocp2scp.c:70:1: error: '__mod_of_device_table' aliased to

Re: [RESEND PATCH v4 0/2] omap: add ocp2scp as a bus driver

2012-08-22 Thread ABRAHAM, KISHON VIJAY
On Wed, Aug 22, 2012 at 6:04 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 22 August 2012, Kishon Vijay Abraham I wrote: This patch series has been lying here for long. If no one has any comments on this patch series, can someone pick it up? I've added them now as a drivers/ocp2scp

Re: [PATCH 2/9] scripts/modpost: add a exception for USB gadget drivers

2012-08-16 Thread ABRAHAM, KISHON VIJAY
Hi Sebastian, On Thu, Aug 16, 2012 at 1:29 AM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: The driver struct for a gadget driver is named *_driver. On module load, the gadget expects a UDC driver to be loaded and avaiable. If this is not the case = -ENODEV and bye bye. That means

Re: [PATCH 2/9] scripts/modpost: add a exception for USB gadget drivers

2012-08-16 Thread ABRAHAM, KISHON VIJAY
On Thu, Aug 16, 2012 at 6:33 PM, Felipe Balbi ba...@ti.com wrote: On Thu, Aug 16, 2012 at 06:35:07PM +0530, ABRAHAM, KISHON VIJAY wrote: Hi Sebastian, On Thu, Aug 16, 2012 at 1:29 AM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: The driver struct for a gadget driver is named

Re: [PATCH v6 00/11] omap: musb: Add device tree support

2012-08-06 Thread ABRAHAM, KISHON VIJAY
On Mon, Aug 6, 2012 at 2:22 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jul 30, 2012 at 02:39:49PM +0530, Kishon Vijay Abraham I wrote: This patch series adds device tree support for MUSB and device tree support for all the related modules to get MUSB working in OMAP platform. A new

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-06 Thread ABRAHAM, KISHON VIJAY
Hi Felipe, On Mon, Aug 6, 2012 at 2:19 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Aug 03, 2012 at 08:01:44PM +0530, ABRAHAM, KISHON VIJAY wrote: + return 0; +} + +#ifdef CONFIG_PM_RUNTIME + +static int omap_usb2_runtime_suspend(struct device *dev) +{ + struct

Re: [PATCH v2 1/2] drivers: bus: add a new driver for omap-ocp2scp

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:50 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Jul 18, 2012 at 12:00:38PM +0530, Kishon Vijay Abraham I wrote: Adds a new driver *omap-ocp2scp*. This driver takes the responsibility of creating all the devices that is connected to OCP2SCP. In the case of

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:57 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Jul 30, 2012 at 02:39:50PM +0530, Kishon Vijay Abraham I wrote: All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related

Re: [PATCH v6 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:58 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jul 30, 2012 at 02:39:52PM +0530, Kishon Vijay Abraham I wrote: All the PHY configuration other than VBUS, ID GND and OTG SRP are removed from twl6030. The phy configurations are taken care by the dedicated

Re: [PATCH v6 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:59 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Jul 30, 2012 at 02:39:53PM +0530, Kishon Vijay Abraham I wrote: The mailbox register for usb otg in omap is present in control module. On detection of any events VBUS or ID, this register should be written to send

Re: [PATCH v6 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:01 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jul 30, 2012 at 02:39:54PM +0530, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay

Re: [PATCH v6 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:02 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jul 30, 2012 at 02:39:56PM +0530, Kishon Vijay Abraham I wrote: Add device tree support for twl4030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay

Re: [PATCH v6 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:06 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jul 30, 2012 at 02:40:00PM +0530, Kishon Vijay Abraham I wrote: All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbi

Re: [PATCH v6 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:04 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jul 30, 2012 at 02:39:58PM +0530, Kishon Vijay Abraham I wrote: Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti shubhrajy...@ti.com wrote: On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: + writel(~PHY_PD, phy-control_dev); + /* XXX: add proper documentation for this delay */ +

Re: [RFC PATCH] drivers: regulator: add error checks for exported APIs

2012-07-26 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 26, 2012 at 4:40 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Jul 26, 2012 at 04:00:03PM +0530, Kishon Vijay Abraham I wrote: Added error checks for exported APIs in regulator framework so that incorrect use of these APIs does not result in a crash. The

Re: [RFC PATCH] drivers: regulator: add error checks for exported APIs

2012-07-26 Thread ABRAHAM, KISHON VIJAY
On Thu, Jul 26, 2012 at 4:52 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Jul 26, 2012 at 04:49:21PM +0530, ABRAHAM, KISHON VIJAY wrote: On Thu, Jul 26, 2012 at 4:40 PM, Mark Brown Also NULL is a valid regulator (though we don't use it right now). I see a lot

Re: [PATCH v4 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-19 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 19, 2012 at 6:51 PM, Gupta, Ajay Kumar ajay.gu...@ti.com wrote: Hi, Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- Documentation/devicetree/bindings/usb/omap-usb.txt | 34 - drivers/usb/musb/omap2430.c| 55

Re: [PATCH v2 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-17 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 17, 2012 at 5:57 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 17-07-2012 12:10, Kishon Vijay Abraham I wrote: Add omap-usb2 data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm/boot/dts/omap4.dtsi |5

Re: [PATCH 2/2] arm/dts: omap4: Add ocp2scp data

2012-07-17 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 17, 2012 at 6:06 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 16-07-2012 18:13, Kishon Vijay Abraham I wrote: Add ocp2scp data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm/boot/dts/omap4.dtsi |8

Re: [RFC PATCH v2 1/2] drivers: misc: omap: add a new driver for ocp2scp

2012-07-16 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 16, 2012 at 1:42 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jun 25, 2012 at 04:26:08PM +, Arnd Bergmann wrote: On Monday 25 June 2012, Felipe Balbi wrote: Can't this live where the scp drivers live? Actually, where is that at? Do we have scp drivers?

Re: [PATCH 1/2] drivers: bus: add a new driver for omap-ocp2scp

2012-07-16 Thread ABRAHAM, KISHON VIJAY
+Arnd Bergmann On Mon, Jul 16, 2012 at 7:43 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Adds a new driver *omap-ocp2scp*. This driver takes the responsibility of creating all the devices that is connected to OCP2SCP. In the case of OMAP4, USB2PHY is connected to ocp2scp. This also

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak rna...@ti.com wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:16 AM, Rajendra Nayak rna...@ti.com wrote: diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt new file mode 100644 index 000..80a28c9 --- /dev/null +++

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu vbyravar...@nvidia.com wrote: + +#ifdef CONFIG_PM Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? Why? I think we should have CONFIG_PM_SLEEP only when we have *suspend*, *resume* hooks. But this driver has only

Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:32 AM, Rajendra Nayak rna...@ti.com wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. twl4030? My bad. Will fix it. Update the Documentation with device tree binding information.

Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:43 AM, Rajendra Nayak rna...@ti.com wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add twl4030-usb data node in twl4030 device tree file. Signed-off-by: Kishon Vijay Abraham Ikis...@ti.com --- arch/arm/boot/dts/twl4030.dtsi | 21

Re: [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:57 AM, Rajendra Nayak rna...@ti.com wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-board.dts file. Signed-off-by: Kishon

Re: [PATCH v1 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:59 AM, Rajendra Nayak rna...@ti.com wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbiba...@ti.com

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 12:14 PM, Rajendra Nayak rna...@ti.com wrote: On Tuesday 10 July 2012 11:58 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayakrna...@ti.com wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device