Re: [PATCH v3] EDAC: expose per-dimm error counts in sysfs

On 11/4/16, 4:21 AM, "Borislav Petkov" wrote: LGTM. Acked-by: Borislav Petkov Mauro, I'm assuming you're picking up this. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the

Re: [PATCH v3] EDAC: expose per-dimm error counts in sysfs

On 11/4/16, 4:21 AM, "Borislav Petkov" wrote: LGTM. Acked-by: Borislav Petkov Mauro, I'm assuming you're picking up this. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. Did this ever get

[PATCH v3] EDAC: expose per-dimm error counts in sysfs

The old 'csrowX' sysfs directories had per-csrow error counters, but the new 'dimmX' directories do not currently expose error counts. EDAC already keeps these counts, add them to sysfs so per-dimm counts are still available when CONFIG_EDAC_LEGACY_SYSFS=n Signed-off-by: Aaron Miller <aaron

[PATCH v3] EDAC: expose per-dimm error counts in sysfs

The old 'csrowX' sysfs directories had per-csrow error counters, but the new 'dimmX' directories do not currently expose error counts. EDAC already keeps these counts, add them to sysfs so per-dimm counts are still available when CONFIG_EDAC_LEGACY_SYSFS=n Signed-off-by: Aaron Miller --- Notes

Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs

without this patch – only added reads it there shouldn’t be a way to cause an out-of-bounds read with it. On 10/28/16, 6:02 AM, "Borislav Petkov" <b...@alien8.de> wrote: On Thu, Oct 27, 2016 at 02:33:32PM -0700, Aaron Miller wrote: > The old 'csrowX' sysfs directories

Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs

without this patch – only added reads it there shouldn’t be a way to cause an out-of-bounds read with it. On 10/28/16, 6:02 AM, "Borislav Petkov" wrote: On Thu, Oct 27, 2016 at 02:33:32PM -0700, Aaron Miller wrote: > The old 'csrowX' sysfs directories had per-csrow e

Re: [PATCH] EDAC: expose per-dimm error counts in sysfs

Whoops, I meant only the 0th slot in each channel. On 10/27/16, 2:23 PM, "Aaron Miller" <aaronmil...@fb.com> wrote: If your system is like the one I’m testing on, only the channel 0 DIMM slots are populated, and you injected an error for an unpopulated slot, for which no

Re: [PATCH] EDAC: expose per-dimm error counts in sysfs

Whoops, I meant only the 0th slot in each channel. On 10/27/16, 2:23 PM, "Aaron Miller" wrote: If your system is like the one I’m testing on, only the channel 0 DIMM slots are populated, and you injected an error for an unpopulated slot, for which no dimmX directory ge

[PATCH v2] EDAC: expose per-dimm error counts in sysfs

The old 'csrowX' sysfs directories had per-csrow error counters, but the new 'dimmX' directories do not currently expose error counts. EDAC already keeps these counts, add them to sysfs so per-dimm counts are still available when CONFIG_EDAC_LEGACY_SYSFS=n Signed-off-by: Aaron Miller <aaron

[PATCH v2] EDAC: expose per-dimm error counts in sysfs

The old 'csrowX' sysfs directories had per-csrow error counters, but the new 'dimmX' directories do not currently expose error counts. EDAC already keeps these counts, add them to sysfs so per-dimm counts are still available when CONFIG_EDAC_LEGACY_SYSFS=n Signed-off-by: Aaron Miller --- Notes

Re: [PATCH] EDAC: expose per-dimm error counts in sysfs

$ grep . dimm*/*ce_count dimm0/dimm_ce_count:0 dimm3/dimm_ce_count:3 dimm6/dimm_ce_count:0 dimm9/dimm_ce_count:0 On 10/27/16, 11:07 AM, "Borislav Petkov" <b...@alien8.de> wrote: On Tue, Oct 25, 2016 at 04:25:51PM -0700, Aaron Miller wrote: <--- This patch needs a commit

Re: [PATCH] EDAC: expose per-dimm error counts in sysfs

$ grep . dimm*/*ce_count dimm0/dimm_ce_count:0 dimm3/dimm_ce_count:3 dimm6/dimm_ce_count:0 dimm9/dimm_ce_count:0 On 10/27/16, 11:07 AM, "Borislav Petkov" wrote: On Tue, Oct 25, 2016 at 04:25:51PM -0700, Aaron Miller wrote: <--- This patch needs a commit messa

[PATCH] EDAC: expose per-dimm error counts in sysfs

Signed-off-by: Aaron Miller <aaronmil...@fb.com> --- drivers/edac/edac_mc_sysfs.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 4e0f8e720ad9..11440462a3f2 100644 --- a/driver

[PATCH] EDAC: expose per-dimm error counts in sysfs

Signed-off-by: Aaron Miller --- drivers/edac/edac_mc_sysfs.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 4e0f8e720ad9..11440462a3f2 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b