Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Aaron Plattner
On 4/12/21 12:36 PM, Roy Spliet wrote: Hello Aaron, Thanks for your insights. A follow-up query and some observations in-line. Op 12-04-2021 om 20:06 schreef Aaron Plattner: On 4/10/21 1:48 PM, Roy Spliet wrote: Op 10-04-2021 om 20:23 schreef Lukas Wunner: On Sat, Apr 10, 2021 at 04:51

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Aaron Plattner
quirk code: https://github.com/torvalds/linux/blob/master/drivers/pci/quirks.c#L5289 (CC Aaron Plattner) My basic understanding is that the audio function stops responding whenever the graphics function is powered off. So the requirement here is that the audio driver can't try to talk

[PATCH v2] ALSA: hda: Add NVIDIA codec IDs 9a & 9d through a0 to patch table

2020-06-11 Thread Aaron Plattner
These IDs are for upcoming NVIDIA chips with audio functions that are largely similar to the existing ones. Signed-off-by: Aaron Plattner --- sound/pci/hda/patch_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index

Re: [PATCH] ALSA: hda: Add NVIDIA codec IDs 9a & 9d through a0 to patch table

2020-06-10 Thread Aaron Plattner
On 6/6/20 1:00 AM, Takashi Iwai wrote: On Fri, 05 Jun 2020 19:17:07 +0200, Aaron Plattner wrote: Signed-off-by: Aaron Plattner Could you give a bit more information? Hi Takashi. Sorry for the slow reply and the terse commit message. I can't say a whole lot about these but I can say

[PATCH] ALSA: hda: Add NVIDIA codec IDs 9a & 9d through a0 to patch table

2020-06-05 Thread Aaron Plattner
Signed-off-by: Aaron Plattner --- sound/pci/hda/patch_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index fbd7cc6026d8..e2b21ef5d7d1 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -4145,6

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de0082 to snd-hda

2016-03-13 Thread Aaron Plattner
Vendor ID 0x10de0082 is used by a yet-to-be-named GPU chip. This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate here. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- Another day, another new chip with the same stupid bug. The hardware folks still

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de0082 to snd-hda

2016-03-13 Thread Aaron Plattner
Vendor ID 0x10de0082 is used by a yet-to-be-named GPU chip. This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate here. Signed-off-by: Aaron Plattner --- Another day, another new chip with the same stupid bug. The hardware folks still claim they're going to fix

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de0083 to snd-hda

2016-01-28 Thread Aaron Plattner
Vendor ID 0x10de0083 is used by a yet-to-be-named GPU chip. This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate here. Signed-off-by: Aaron Plattner --- The hardware guys identified the problem and claim it will be fixed in a future chip. sound/pci/hda/patch_hdmi.c

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de0083 to snd-hda

2016-01-28 Thread Aaron Plattner
Vendor ID 0x10de0083 is used by a yet-to-be-named GPU chip. This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate here. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- The hardware guys identified the problem and claim it will be fixed in a future chip.

Re: [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda

2015-07-21 Thread Aaron Plattner
On 07/21/2015 12:39 AM, Takashi Iwai wrote: > On Tue, 21 Jul 2015 02:14:14 +0200, > Aaron Plattner wrote: >> >> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip. >> >> Signed-off-by: Aaron Plattner > > Applied, thanks. But... > >> --- >

Re: [PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda

2015-07-21 Thread Aaron Plattner
On 07/21/2015 12:39 AM, Takashi Iwai wrote: On Tue, 21 Jul 2015 02:14:14 +0200, Aaron Plattner wrote: Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner aplatt...@nvidia.com Applied, thanks. But... --- This chip also has the 2-ch audio swapping

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda

2015-07-20 Thread Aaron Plattner
Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner --- This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate here. sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda

2015-07-20 Thread Aaron Plattner
Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate here. sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda

[PATCH] drm/udl: add enable/disable_vblank stubs

2015-02-15 Thread Aaron Plattner
freedesktop.org/archives/dri-devel/2014-December/073652.html Signed-off-by: Aaron Plattner --- Daniel, it looks like your change "[5/5] drm/irq: Don't call ->get_vblank_counter directly from irq_uninstall/cleanup" masks the immediate problem, but it's not clear to me whether that's ju

[PATCH] drm/udl: add enable/disable_vblank stubs

2015-02-15 Thread Aaron Plattner
[ (null)] (null) RSP 8803bc1c7d00 CR2: ---[ end trace e0b184ca053571af ]--- Reported-by: Thomas Meyer tho...@m3y3r.de Link: http://lists.freedesktop.org/archives/dri-devel/2014-December/073652.html Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- Daniel

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de0072 to snd-hda

2015-01-06 Thread Aaron Plattner
Vendor ID 0x10de0072 is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner --- Do you think it would make sense to add some kind of wildcard match for 0x10de* -> patch_nvhdmi? sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de0072 to snd-hda

2015-01-06 Thread Aaron Plattner
Vendor ID 0x10de0072 is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- Do you think it would make sense to add some kind of wildcard match for 0x10de* - patch_nvhdmi? sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: Stupid NVIDIA 3D vgaarb.c patch

2014-09-26 Thread Aaron Plattner
On 09/23/2014 01:29 PM, Benjamin Herrenschmidt wrote: On Mon, 2014-09-22 at 13:43 -0700, Linus Torvalds wrote: Adding proper people and mailing lists.. The PCI_CLASS_DISPLAY_VGA test goes back to the very beginning by BenH, and I have no idea if adding PCI_CLASS_DISPLAY_3D is appropriate, but

Re: Stupid NVIDIA 3D vgaarb.c patch

2014-09-26 Thread Aaron Plattner
On 09/23/2014 01:29 PM, Benjamin Herrenschmidt wrote: On Mon, 2014-09-22 at 13:43 -0700, Linus Torvalds wrote: Adding proper people and mailing lists.. The PCI_CLASS_DISPLAY_VGA test goes back to the very beginning by BenH, and I have no idea if adding PCI_CLASS_DISPLAY_3D is appropriate, but

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de0070 to snd-hda

2014-07-08 Thread Aaron Plattner
Vendor ID 0x10de0070 is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner --- Another day, another Azalia codec ID. I verified that the patch_nvhdmi code is still needed for this chip. sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci

[PATCH] ALSA: hda - Add new GPU codec ID 0x10de0070 to snd-hda

2014-07-08 Thread Aaron Plattner
Vendor ID 0x10de0070 is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- Another day, another Azalia codec ID. I verified that the patch_nvhdmi code is still needed for this chip. sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v2] cpufreq: unlock when failing cpufreq_update_policy()

2014-06-18 Thread Aaron Plattner
rnel-3-15-and-nv-drivers-337-340-failed-to-initialize-the-nvidia-kernel-module-gtx-550-ti-/ Cc: Viresh Kumar Cc: Rafael J. Wysocki Signed-off-by: Aaron Plattner --- v1 of this was tested by the user affected by the problem, but I don't have his email address so I can't add it as a Tested-by line.

Re: [PATCH] cpufreq: unlock when failing cpufreq_update_policy()

2014-06-18 Thread Aaron Plattner
On 06/18/2014 12:40 AM, Viresh Kumar wrote: On 18 June 2014 05:42, Aaron Plattner wrote: Commit bd0fa9bb455d introduced a failure path to cpufreq_update_policy() if cpufreq_driver->get(cpu) returns NULL. However, it jumps to the 'no_policy' label, which exits without unlocking

Re: [PATCH] cpufreq: unlock when failing cpufreq_update_policy()

2014-06-18 Thread Aaron Plattner
On 06/18/2014 12:40 AM, Viresh Kumar wrote: On 18 June 2014 05:42, Aaron Plattner aplatt...@nvidia.com wrote: Commit bd0fa9bb455d introduced a failure path to cpufreq_update_policy() if cpufreq_driver-get(cpu) returns NULL. However, it jumps to the 'no_policy' label, which exits without

[PATCH v2] cpufreq: unlock when failing cpufreq_update_policy()

2014-06-18 Thread Aaron Plattner
-drivers-337-340-failed-to-initialize-the-nvidia-kernel-module-gtx-550-ti-/ Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Rafael J. Wysocki rafael.j.wyso...@intel.com Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- v1 of this was tested by the user affected by the problem, but I don't have his email

[PATCH] cpufreq: unlock when failing cpufreq_update_policy()

2014-06-17 Thread Aaron Plattner
odule-gtx-550-ti-/ Cc: Viresh Kumar Cc: Rafael J. Wysocki Signed-off-by: Aaron Plattner --- I haven't reproduced this problem so I couldn't test it, but the bug and its solution seem obvious enough. drivers/cpufreq/cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH] cpufreq: unlock when failing cpufreq_update_policy()

2014-06-17 Thread Aaron Plattner
: Viresh Kumar viresh.ku...@linaro.org Cc: Rafael J. Wysocki rafael.j.wyso...@intel.com Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- I haven't reproduced this problem so I couldn't test it, but the bug and its solution seem obvious enough. drivers/cpufreq/cpufreq.c | 3 ++- 1 file changed

[PATCH] ALSA: hda - Add new GPU codec ID to snd-hda

2014-05-12 Thread Aaron Plattner
Vendor ID 0x10de0071 is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner Cc: Takashi Iwai Cc: Jaroslav Kysela Cc: Stephen Warren --- I verified that the patch_nvhdmi code is still needed for this chip. sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH] ALSA: hda - Add new GPU codec ID to snd-hda

2014-05-12 Thread Aaron Plattner
Vendor ID 0x10de0071 is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner aplatt...@nvidia.com Cc: Takashi Iwai ti...@suse.de Cc: Jaroslav Kysela pe...@perex.cz Cc: Stephen Warren swar...@nvidia.com --- I verified that the patch_nvhdmi code is still needed for this chip. sound

Re: [PATCH] cpufreq: use cpufreq_cpu_get to avoid cpufreq_get race conditions

2014-03-05 Thread Aaron Plattner
On 03/05/14 17:23, Rafael J. Wysocki wrote: On Tuesday, March 04, 2014 12:42:15 PM Aaron Plattner wrote: If a module calls cpufreq_get while cpufreq is initializing, it's possible for it to be called after cpufreq_driver is set but before cpufreq_cpu_data is written during

Re: [PATCH] cpufreq: use cpufreq_cpu_get to avoid cpufreq_get race conditions

2014-03-05 Thread Aaron Plattner
On 03/05/14 17:23, Rafael J. Wysocki wrote: On Tuesday, March 04, 2014 12:42:15 PM Aaron Plattner wrote: If a module calls cpufreq_get while cpufreq is initializing, it's possible for it to be called after cpufreq_driver is set but before cpufreq_cpu_data is written during

[PATCH] cpufreq: use cpufreq_cpu_get to avoid cpufreq_get race conditions

2014-03-04 Thread Aaron Plattner
or calls the function before cpufreq is initialized, delete the BUG_ON(!policy) and simply return 0. Don't try to return -ENOENT because that's negative and the function returns an unsigned integer. Signed-off-by: Aaron Plattner --- drivers/cpufreq/cpufreq.c | 21 +++-- 1 file changed

[PATCH] cpufreq: use cpufreq_cpu_get to avoid cpufreq_get race conditions

2014-03-04 Thread Aaron Plattner
or calls the function before cpufreq is initialized, delete the BUG_ON(!policy) and simply return 0. Don't try to return -ENOENT because that's negative and the function returns an unsigned integer. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- drivers/cpufreq/cpufreq.c | 21

[PATCH] ALSA: hda - Add new GPU codec ID to snd-hda

2013-07-12 Thread Aaron Plattner
Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip. Reviewed-by: Andy Ritger Signed-off-by: Aaron Plattner --- sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index e12f7a0..486def7 100644

[PATCH] ALSA: hda - Add new GPU codec ID to snd-hda

2013-07-12 Thread Aaron Plattner
Vendor ID 0x10de0060 is used by a yet-to-be-named GPU chip. Reviewed-by: Andy Ritger arit...@nvidia.com Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- sound/pci/hda/patch_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c

Re: [PATCH] [RFC] dma-buf: implement vmap refcounting in the interface logic

2012-12-20 Thread Aaron Plattner
. But this shouldn't be a problem for exporters with statically allocated backing storage, and more dynamic drivers have decent issues already anyway. Inspired by some refactoring patches from Aaron Plattner, who implemented the same idea, but only for drm/prime drivers. v2: Check in dma_buf_release

Re: [PATCH] [RFC] dma-buf: implement vmap refcounting in the interface logic

2012-12-20 Thread Aaron Plattner
. But this shouldn't be a problem for exporters with statically allocated backing storage, and more dynamic drivers have decent issues already anyway. Inspired by some refactoring patches from Aaron Plattner, who implemented the same idea, but only for drm/prime drivers. v2: Check in dma_buf_release

Re: [PATCH] [RFC] dma-buf: implement vmap refcounting in the interface logic

2012-12-19 Thread Aaron Plattner
. But this shouldn't be a problem for exporters with statically allocated backing storage, and more dynamic drivers have decent issues already anyway. Inspired by some refactoring patches from Aaron Plattner, who implemented the same idea, but only for drm/prime drivers. v2: Check in dma_buf_release

Re: [PATCH] [RFC] dma-buf: implement vmap refcounting in the interface logic

2012-12-19 Thread Aaron Plattner
. But this shouldn't be a problem for exporters with statically allocated backing storage, and more dynamic drivers have decent issues already anyway. Inspired by some refactoring patches from Aaron Plattner, who implemented the same idea, but only for drm/prime drivers. v2: Check in dma_buf_release

[PATCH] ALSA: hda - Add new GPU codec ID to snd-hda

2012-07-16 Thread Aaron Plattner
Vendor ID 0x10de0051 is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner Acked-by: Andy Ritger Reviewed-by: Daniel Dadap --- sound/pci/hda/patch_hdmi.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index

[PATCH] ALSA: hda - Add new GPU codec ID to snd-hda

2012-07-16 Thread Aaron Plattner
Vendor ID 0x10de0051 is used by a yet-to-be-named GPU chip. Signed-off-by: Aaron Plattner aplatt...@nvidia.com Acked-by: Andy Ritger arit...@nvidia.com Reviewed-by: Daniel Dadap dda...@nvidia.com --- sound/pci/hda/patch_hdmi.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci