Re: [LSF/MM TOPIC] Page Cache Flexibility for NVM

2019-02-21 Thread Adam Manzanares
On Thu, 2019-02-21 at 19:27 -0500, Jerome Glisse wrote: > On Thu, Feb 21, 2019 at 11:11:51PM +0000, Adam Manzanares wrote: > > Hello, > > > > I would like to attend the LSF/MM Summit 2019. I'm interested in > > several MM topics that are mentioned below as well as Zone

Re: [LSF/MM TOPIC] Page Cache Flexibility for NVM

2019-02-21 Thread Adam Manzanares
Forgot the link. [1] https://github.com/westerndigitalcorporation/hmmap Take care, Adam On Thu, 2019-02-21 at 15:11 -0800, Adam Manzanares wrote: > Hello, > > I would like to attend the LSF/MM Summit 2019. I'm interested in > several MM topics that are mentioned below as well as

Re: [LSF/MM TOPIC] Page Cache Flexibility for NVM

2019-02-21 Thread Adam Manzanares
On Thu, 2019-02-21 at 15:14 -0800, Dave Hansen wrote: > On 2/21/19 3:11 PM, Adam Manzanares wrote: > > I am proposing that as an alternative to using NVMs as a NUMA node > > we expose the NVM through the page cache or a viable alternative > > and > > have userspac

[LSF/MM TOPIC] Page Cache Flexibility for NVM

2019-02-21 Thread Adam Manzanares
Hello, I would like to attend the LSF/MM Summit 2019. I'm interested in several MM topics that are mentioned below as well as Zoned Block Devices and any io determinism topics that come up in the storage track. I have been working on a caching layer, hmmap (heterogeneous memory map) [1], for

[PATCH] io_submit.2: Add IOCB_FLAG_IOPRIO

2018-07-13 Thread adam . manzanares
From: Adam Manzanares The newly added IOCB_FLAG_IOPRIO aio_flag introduces new behaviors and return values. The details of this new feature are posted here: https://lkml.org/lkml/2018/5/22/809 Signed-off-by: Adam Manzanares --- man2/io_submit.2 | 34 +++--- 1 file

[PATCH] io_submit.2: Add IOCB_FLAG_IOPRIO

2018-07-13 Thread adam . manzanares
From: Adam Manzanares The newly added IOCB_FLAG_IOPRIO aio_flag introduces new behaviors and return values. The details of this new feature are posted here: https://lkml.org/lkml/2018/5/22/809 Signed-off-by: Adam Manzanares --- man2/io_submit.2 | 34 +++--- 1 file

Re: [PATCH v7 0/5] AIO add per-command iopriority

2018-05-22 Thread Adam Manzanares
On 5/22/18 11:30 AM, Jens Axboe wrote: > On 5/22/18 12:30 PM, Al Viro wrote: >> On Tue, May 22, 2018 at 11:55:04AM -0600, Jens Axboe wrote: >>> On 5/22/18 11:52 AM, adam.manzana...@wdc.com wrote: >>>> From: Adam Manzanares <adam.manzana...@wdc.com> >

Re: [PATCH v7 0/5] AIO add per-command iopriority

2018-05-22 Thread Adam Manzanares
On 5/22/18 11:30 AM, Jens Axboe wrote: > On 5/22/18 12:30 PM, Al Viro wrote: >> On Tue, May 22, 2018 at 11:55:04AM -0600, Jens Axboe wrote: >>> On 5/22/18 11:52 AM, adam.manzana...@wdc.com wrote: >>>> From: Adam Manzanares >>>> >>>> This i

[PATCH v7 5/5] fs: iomap dio set bio prio from kiocb prio

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb during direct IO. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> Reviewed-by: Jeff Moyer <jmo...@redhat.com> Reviewed-by: Ch

[PATCH v7 5/5] fs: iomap dio set bio prio from kiocb prio

2018-05-22 Thread adam . manzanares
From: Adam Manzanares Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb during direct IO. Signed-off-by: Adam Manzanares Reviewed-by: Jeff Moyer Reviewed-by: Christoph Hellwig --- fs/iomap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs

[PATCH v7 0/5] AIO add per-command iopriority

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call t

[PATCH v7 0/5] AIO add per-command iopriority

2018-05-22 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call to also be used by the aio

[PATCH v7 1/5] block: add ioprio_check_cap function

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient privileges to

[PATCH v7 1/5] block: add ioprio_check_cap function

2018-05-22 Thread adam . manzanares
From: Adam Manzanares Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient privileges to submit IOPRIO_RT commands. This patch

[PATCH v7 4/5] fs: blkdev set bio prio from kiocb prio

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> Reviewed-by: Jeff Moyer <jmo...@redhat.com> --- fs/block_dev.c | 2 ++

[PATCH v7 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assignment. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- fs/aio.c | 2

[PATCH v7 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-22 Thread adam . manzanares
From: Adam Manzanares In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assignment. Signed-off-by: Adam Manzanares --- fs/aio.c | 2 +- include/linux/fs.h | 13 +++-- 2 files changed, 12

[PATCH v7 4/5] fs: blkdev set bio prio from kiocb prio

2018-05-22 Thread adam . manzanares
From: Adam Manzanares Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb. Signed-off-by: Adam Manzanares Reviewed-by: Jeff Moyer --- fs/block_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/block_dev.c b/fs/block_dev.c index

[PATCH v7 3/5] fs: Add aio iopriority support

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. This patch depends on bloc

[PATCH v7 3/5] fs: Add aio iopriority support

2018-05-22 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. This patch depends on block: add ioprio_check_cap function

Re: [PATCH v6 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-22 Thread Adam Manzanares
On 5/22/18 9:30 AM, Jens Axboe wrote: > On 5/22/18 10:24 AM, Goldwyn Rodrigues wrote: >> >> >> On 05/22/2018 10:32 AM, Jens Axboe wrote: >>> On 5/22/18 9:07 AM, adam.manzana...@wdc.com wrote: >>>> From: Adam Manzanares <adam.manzana...@wdc.com>

Re: [PATCH v6 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-22 Thread Adam Manzanares
On 5/22/18 9:30 AM, Jens Axboe wrote: > On 5/22/18 10:24 AM, Goldwyn Rodrigues wrote: >> >> >> On 05/22/2018 10:32 AM, Jens Axboe wrote: >>> On 5/22/18 9:07 AM, adam.manzana...@wdc.com wrote: >>>> From: Adam Manzanares >>>> >>>>

Re: [PATCH v6 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-22 Thread Adam Manzanares
On 5/22/18 8:32 AM, Jens Axboe wrote: > On 5/22/18 9:07 AM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> In order to avoid kiocb bloat for per command iopriority support, rw_hint >> is converted from enum to a

Re: [PATCH v6 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-22 Thread Adam Manzanares
On 5/22/18 8:32 AM, Jens Axboe wrote: > On 5/22/18 9:07 AM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> In order to avoid kiocb bloat for per command iopriority support, rw_hint >> is converted from enum to a u16. Added a guard around ki_hint a

[PATCH v6 3/5] fs: Add aio iopriority support

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. This patch depends on bloc

[PATCH v6 3/5] fs: Add aio iopriority support

2018-05-22 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. This patch depends on block: add ioprio_check_cap function

[PATCH v6 4/5] fs: blkdev set bio prio from kiocb prio

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- fs/block_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/bloc

[PATCH v6 4/5] fs: blkdev set bio prio from kiocb prio

2018-05-22 Thread adam . manzanares
From: Adam Manzanares Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb. Signed-off-by: Adam Manzanares --- fs/block_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/block_dev.c b/fs/block_dev.c index 7ec920e27065..11ba99e79d2a 100644

[PATCH v6 1/5] block: add ioprio_check_cap function

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient privileges to

[PATCH v6 1/5] block: add ioprio_check_cap function

2018-05-22 Thread adam . manzanares
From: Adam Manzanares Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient privileges to submit IOPRIO_RT commands. This patch

[PATCH v6 5/5] fs: iomap dio set bio prio from kiocb prio

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb during direct IO. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> Reviewed-by: Jeff Moyer <jmo...@redhat.com> Reviewed-by: Ch

[PATCH v6 5/5] fs: iomap dio set bio prio from kiocb prio

2018-05-22 Thread adam . manzanares
From: Adam Manzanares Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb during direct IO. Signed-off-by: Adam Manzanares Reviewed-by: Jeff Moyer Reviewed-by: Christoph Hellwig --- fs/iomap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs

[PATCH v6 0/5] AIO add per-command iopriority

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call t

[PATCH v6 0/5] AIO add per-command iopriority

2018-05-22 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call to also be used by the aio

[PATCH v6 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-22 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assignment. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> Reviewed-by: Christoph Hellwig

[PATCH v6 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-22 Thread adam . manzanares
From: Adam Manzanares In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assignment. Signed-off-by: Adam Manzanares Reviewed-by: Christoph Hellwig --- include/linux/fs.h | 13 +++-- 1 file changed

Re: [PATCH v5 4/5] fs: blkdev set bio prio from kiocb prio

2018-05-21 Thread Adam Manzanares
On 5/21/18 2:04 PM, Jeff Moyer wrote: > adam.manzana...@wdc.com writes: > >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> Now that kiocb has an ioprio field copy this over to the bio when it is >> created from the kiocb. >> >> Signed-

Re: [PATCH v5 4/5] fs: blkdev set bio prio from kiocb prio

2018-05-21 Thread Adam Manzanares
On 5/21/18 2:04 PM, Jeff Moyer wrote: > adam.manzana...@wdc.com writes: > >> From: Adam Manzanares >> >> Now that kiocb has an ioprio field copy this over to the bio when it is >> created from the kiocb. >> >> Signed-off-by: Adam Manzanares >> -

Re: [PATCH v5 0/5] AIO add per-command iopriority

2018-05-21 Thread Adam Manzanares
On 5/21/18 1:57 PM, Jeff Moyer wrote: > Hi, Adam, > > adam.manzana...@wdc.com writes: > >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> See the following link for perfor

Re: [PATCH v5 0/5] AIO add per-command iopriority

2018-05-21 Thread Adam Manzanares
On 5/21/18 1:57 PM, Jeff Moyer wrote: > Hi, Adam, > > adam.manzana...@wdc.com writes: > >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> See the following link for performance implications on a SATA HDD: &g

[PATCH v5 4/5] fs: blkdev set bio prio from kiocb prio

2018-05-21 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- fs/block_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/bloc

[PATCH v5 4/5] fs: blkdev set bio prio from kiocb prio

2018-05-21 Thread adam . manzanares
From: Adam Manzanares Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb. Signed-off-by: Adam Manzanares --- fs/block_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/block_dev.c b/fs/block_dev.c index 7ec920e27065..da1e94d2bb75 100644

[PATCH v5 5/5] fs: iomap dio set bio prio from kiocb prio

2018-05-21 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb during direct IO. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- fs/iomap.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v5 5/5] fs: iomap dio set bio prio from kiocb prio

2018-05-21 Thread adam . manzanares
From: Adam Manzanares Now that kiocb has an ioprio field copy this over to the bio when it is created from the kiocb during direct IO. Signed-off-by: Adam Manzanares --- fs/iomap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/iomap.c b/fs/iomap.c index afd163586aa0..65aae194aeca

[PATCH v5 1/5] block: add ioprio_check_cap function

2018-05-21 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to

[PATCH v5 0/5] AIO add per-command iopriority

2018-05-21 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call t

[PATCH v5 1/5] block: add ioprio_check_cap function

2018-05-21 Thread adam . manzanares
From: Adam Manzanares Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to submit IOPRIO_RT commands. This patch

[PATCH v5 0/5] AIO add per-command iopriority

2018-05-21 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call to also be used by the aio

[PATCH v5 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-21 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- include/lin

[PATCH v5 2/5] fs: Convert kiocb rw_hint from enum to u16

2018-05-21 Thread adam . manzanares
From: Adam Manzanares In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares --- include/linux/fs.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions

[PATCH v5 3/5] fs: Add aio iopriority support

2018-05-21 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. We set the blkdev bio iopr

[PATCH v5 3/5] fs: Add aio iopriority support

2018-05-21 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. We set the blkdev bio iopriority unconditionally, so we

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 9:06 AM, Christoph Hellwig wrote: > Looks fine, although I'd split it into a aio and block_dev patch. > > Also please wire this up for the fs/iomap.c direct I/O code, it should > be essentially the same sniplet as in the block_dev.c code. > Will do.

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 9:06 AM, Christoph Hellwig wrote: > Looks fine, although I'd split it into a aio and block_dev patch. > > Also please wire this up for the fs/iomap.c direct I/O code, it should > be essentially the same sniplet as in the block_dev.c code. > Will do.

Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-18 Thread Adam Manzanares
On 5/18/18 9:05 AM, Christoph Hellwig wrote: >> +/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */ > > I don't think this comment is very useful. > >> +static inline u16 ki_hint_valid(enum rw_hint hint) > > I'd call this ki_hint_validate. > >> +{ >> +if (hint >

Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-18 Thread Adam Manzanares
On 5/18/18 9:05 AM, Christoph Hellwig wrote: >> +/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */ > > I don't think this comment is very useful. > >> +static inline u16 ki_hint_valid(enum rw_hint hint) > > I'd call this ki_hint_validate. > >> +{ >> +if (hint >

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 8:14 AM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IOPRIO is set o

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 8:14 AM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set t

Re: [PATCH v4 0/3] AIO add per-command iopriority

2018-05-18 Thread Adam Manzanares
On 5/17/18 7:41 PM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> See the following link for performance imp

Re: [PATCH v4 0/3] AIO add per-command iopriority

2018-05-18 Thread Adam Manzanares
On 5/17/18 7:41 PM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> See the following link for performance implications on a SATA HDD: >> ht

[PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-17 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for

[PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-17 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for an aio request by the block dev

[PATCH v4 0/3] AIO add per-command iopriority

2018-05-17 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call t

[PATCH v4 0/3] AIO add per-command iopriority

2018-05-17 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call to also be used by the aio

[PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-17 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- include/lin

[PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-17 Thread adam . manzanares
From: Adam Manzanares In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares --- include/linux/fs.h | 15 +-- 1 file changed, 13 insertions(+), 2 deletions

[PATCH v4 1/3] block: add ioprio_check_cap function

2018-05-17 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to

[PATCH v4 1/3] block: add ioprio_check_cap function

2018-05-17 Thread adam . manzanares
From: Adam Manzanares Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to submit IOPRIO_RT commands. This patch

Re: [PATCH v3 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-09 Thread Adam Manzanares
On 5/9/18 11:21 AM, Theodore Y. Ts'o wrote: > On Wed, May 09, 2018 at 08:23:00AM -0600, Jens Axboe wrote: >> Streams is essentially the only thing ki_hint is currently used for, >> with the write life time hints mapping to a stream. The idea for the >> user side API was to have other things than

Re: [PATCH v3 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-09 Thread Adam Manzanares
On 5/9/18 11:21 AM, Theodore Y. Ts'o wrote: > On Wed, May 09, 2018 at 08:23:00AM -0600, Jens Axboe wrote: >> Streams is essentially the only thing ki_hint is currently used for, >> with the write life time hints mapping to a stream. The idea for the >> user side API was to have other things than

[PATCH v3 0/3] AIO add per-command iopriority

2018-05-08 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set syste

[PATCH v3 0/3] AIO add per-command iopriority

2018-05-08 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call to also be used by the aio

[PATCH v3 3/3] fs: Add aio iopriority support for block_dev

2018-05-08 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for an aio request by the block dev we set the priority value of t

[PATCH v3 3/3] fs: Add aio iopriority support for block_dev

2018-05-08 Thread adam . manzanares
From: Adam Manzanares When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for an aio request by the block dev we set the priority value of the bio to the user supplied value

[PATCH v3 1/3] block: add ioprio_check_cap function

2018-05-08 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to

[PATCH v3 1/3] block: add ioprio_check_cap function

2018-05-08 Thread adam . manzanares
From: Adam Manzanares Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to submit IOPRIO_RT commands. This patch

[PATCH v3 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-08 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- include/lin

[PATCH v3 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-08 Thread adam . manzanares
From: Adam Manzanares In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares --- include/linux/fs.h | 15 +-- 1 file changed, 13 insertions(+), 2 deletions

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 1:24 PM, Jens Axboe wrote: > On 5/3/18 2:15 PM, Adam Manzanares wrote: >> >> >> On 5/3/18 11:33 AM, Matthew Wilcox wrote: >>> On Thu, May 03, 2018 at 11:21:14AM -0700, adam.manzana...@wdc.com wrote: >>>> If we want to avoid bloating s

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 1:24 PM, Jens Axboe wrote: > On 5/3/18 2:15 PM, Adam Manzanares wrote: >> >> >> On 5/3/18 11:33 AM, Matthew Wilcox wrote: >>> On Thu, May 03, 2018 at 11:21:14AM -0700, adam.manzana...@wdc.com wrote: >>>> If we want to avoid bloating s

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 11:36 AM, Jeff Moyer wrote: > Hi, Adam, Hello Jeff, > > adam.manzana...@wdc.com writes: > >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IO

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 11:36 AM, Jeff Moyer wrote: > Hi, Adam, Hello Jeff, > > adam.manzana...@wdc.com writes: > >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IOPRIO is set on the iocb aio_f

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 11:33 AM, Matthew Wilcox wrote: > On Thu, May 03, 2018 at 11:21:14AM -0700, adam.manzana...@wdc.com wrote: >> If we want to avoid bloating struct kiocb, I suggest we turn the private >> field >> into a union of the private and ki_ioprio field. It seems like the users of >> the private

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 11:33 AM, Matthew Wilcox wrote: > On Thu, May 03, 2018 at 11:21:14AM -0700, adam.manzana...@wdc.com wrote: >> If we want to avoid bloating struct kiocb, I suggest we turn the private >> field >> into a union of the private and ki_ioprio field. It seems like the users of >> the private

[PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for

[PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for an aio request by the block dev

Re: [PATCH 2/2] fs: Add aio priority support for block_dev

2018-05-02 Thread Adam Manzanares
On 5/2/18 10:33 AM, Christoph Hellwig wrote: >> --- a/fs/aio.c >> +++ b/fs/aio.c >> @@ -1603,6 +1603,15 @@ static int io_submit_one(struct kioctx *ctx, struct >> iocb __user *user_iocb, >> goto out_put_req; >> } >> >> +if (req->common.ki_flags & IOCB_IOPRIO) >> +

Re: [PATCH 2/2] fs: Add aio priority support for block_dev

2018-05-02 Thread Adam Manzanares
On 5/2/18 10:33 AM, Christoph Hellwig wrote: >> --- a/fs/aio.c >> +++ b/fs/aio.c >> @@ -1603,6 +1603,15 @@ static int io_submit_one(struct kioctx *ctx, struct >> iocb __user *user_iocb, >> goto out_put_req; >> } >> >> +if (req->common.ki_flags & IOCB_IOPRIO) >> +

Re: [PATCH 1/2] fs: add RWF_IOPRIO

2018-05-02 Thread Adam Manzanares
On 5/2/18 10:32 AM, Christoph Hellwig wrote: > On Mon, Apr 30, 2018 at 09:57:39AM -0700, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> &

Re: [PATCH 1/2] fs: add RWF_IOPRIO

2018-05-02 Thread Adam Manzanares
On 5/2/18 10:32 AM, Christoph Hellwig wrote: > On Mon, Apr 30, 2018 at 09:57:39AM -0700, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When the RWF_IOPRIO flag is set then

[PATCH 0/2] AIO add per-command iopriority

2018-04-30 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This patchset interprets the aio_reqprio field of an iocb as a per-command value iff the RWF_IOPRIO flag is set on the iocb. This feature is implemented for a block device, but could also be leveraged by any consumers of the iocb

[PATCH 1/2] fs: add RWF_IOPRIO

2018-04-30 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When the RWF_IOPRIO flag is set then the aio_reqprio field of the iocb is interpreted as an I/O scheduling class and priority. Signed-off-by: Adam Manzanares <adam.manzana..

[PATCH 0/2] AIO add per-command iopriority

2018-04-30 Thread adam . manzanares
From: Adam Manzanares This patchset interprets the aio_reqprio field of an iocb as a per-command value iff the RWF_IOPRIO flag is set on the iocb. This feature is implemented for a block device, but could also be leveraged by any consumers of the iocb. See the following link for performance

[PATCH 1/2] fs: add RWF_IOPRIO

2018-04-30 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When the RWF_IOPRIO flag is set then the aio_reqprio field of the iocb is interpreted as an I/O scheduling class and priority. Signed-off-by: Adam Manzanares --- include/linux/fs.h | 4 include/uapi

[PATCH 2/2] fs: Add aio priority support for block_dev

2018-04-30 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> When the IOCB_IOPRIO flag is set because the user supplied iocb has the RWF_IOPRIO flag is set then we set the priority value of the kiocb from the iocb. When a bio is created for an aio request by the block dev we set the priority value of t

[PATCH 2/2] fs: Add aio priority support for block_dev

2018-04-30 Thread adam . manzanares
From: Adam Manzanares When the IOCB_IOPRIO flag is set because the user supplied iocb has the RWF_IOPRIO flag is set then we set the priority value of the kiocb from the iocb. When a bio is created for an aio request by the block dev we set the priority value of the bio to the user supplied

Re: [RFC PATCH] fs: block dev aio request priority support

2017-05-23 Thread Adam Manzanares
The 05/23/2017 10:46, Jan Kara wrote: > On Mon 22-05-17 10:19:33, adam.manzana...@wdc.com wrote: > > From: Adam Manzanares <adam.manzana...@wdc.com> > > > > Map the aio_reqprio to the bio priority field at > > the point the bio is created from the aio iocb. >

Re: [RFC PATCH] fs: block dev aio request priority support

2017-05-23 Thread Adam Manzanares
The 05/23/2017 10:46, Jan Kara wrote: > On Mon 22-05-17 10:19:33, adam.manzana...@wdc.com wrote: > > From: Adam Manzanares > > > > Map the aio_reqprio to the bio priority field at > > the point the bio is created from the aio iocb. > > > > The aio_reqpr

[PATCH v2] mpt3sas: Recognize and act on iopriority info

2016-12-12 Thread Adam Manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This patch adds support for request iopriority handling in the mpt3sas layer. This works only when a ATA device is behind the SATL. The ATA device also has to indicate that it supports command priorities in the identify information that is

[PATCH v2] mpt3sas: Recognize and act on iopriority info

2016-12-12 Thread Adam Manzanares
From: Adam Manzanares This patch adds support for request iopriority handling in the mpt3sas layer. This works only when a ATA device is behind the SATL. The ATA device also has to indicate that it supports command priorities in the identify information that is pulled from the SATL. This patch

  1   2   >