RE: [PATCH V2 0/6] PM / devfreq: a few small fixes and improvements

2021-03-23 Thread Aisheng Dong
> From: Chanwoo Choi > Sent: Tuesday, March 23, 2021 12:11 PM > > Hi, > > On 3/23/21 12:25 PM, Dong Aisheng wrote: > > Hi Chanwoo, > > > > On Tue, Mar 23, 2021 at 11:13 AM Dong Aisheng > wrote: > >> > >> A few small fixes and improvements > >> > >> ChangeLog: > >> v1->v2: > >> * squash a few

RE: [PATCH 02/11] i2c: imx-lpi2c: add runtime pm support

2021-03-19 Thread Aisheng Dong
[...] > > > > pm_runtime_set_autosuspend_delay(>dev, > > > I2C_PM_TIMEOUT); > > > > pm_runtime_use_autosuspend(>dev); > > > > - pm_runtime_get_noresume(>dev); > > > > - pm_runtime_set_active(>dev); > > > > pm_runtime_enable(>dev); > > > > > > > > + ret =

RE: [PATCH 04/11] i2c: imx-lpi2c: manage irq resource request/release in runtime pm

2021-03-19 Thread Aisheng Dong
> > > @@ -665,6 +659,14 @@ static int __maybe_unused > > > lpi2c_runtime_resume(struct device *dev) > > > dev_err(dev, "can't enable I2C ipg clock, ret=%d\n", ret); > > > } > > > > > > + ret = devm_request_irq(dev, lpi2c_imx->irq, lpi2c_imx_isr, > > > > I guess unnecessary to use devm

RE: [PATCH 03/11] i2c: imx-lpi2c: add ipg clk for lpi2c driver

2021-03-19 Thread Aisheng Dong
> > > + > > > + lpi2c_imx->clk_ipg = devm_clk_get(>dev, "ipg"); > > > + if (IS_ERR(lpi2c_imx->clk_ipg)) { > > > + dev_err(>dev, "can't get I2C ipg clock\n"); > > > + return PTR_ERR(lpi2c_imx->clk_ipg); > > > } > > > > Will this break exist dts? > > It will not break the build.

RE: [PATCH 11/11] i2c: imx-lpi2c: add edma mode support

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > Add eDMA receive and send mode support. > Support to read and write data larger than 256 bytes in one frame. > > Signed-off-by: Clark Wang > Reviewed-by: Li Jun > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 291

RE: [PATCH 10/11] i2c: imx-lpi2c: fix type char overflow issue when calculating the clock cycle

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > Claim clkhi and clklo as integer type to avoid possible calculation errors > caused > by data overflow. > > Reviewed-by: Fugang Duan > Signed-off-by: Clark Wang Reviewed-by: Dong Aisheng Regards Aisheng > --- >

RE: [PATCH 09/11] i2c: imx-lpi2c: fix i2c timing issue

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > The clkhi and clklo ratio was not very precise before that can make the time > of > START/STOP/HIGH LEVEL out of specification. > > Therefore, the calculation of these times has been modified in this patch. > At the same time,

RE: [PATCH 08/11] i2c: imx-lpi2c: add bus recovery feature

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > Add bus recovery feature for LPI2C. > Need add gpio pinctrl, scl-gpios and sda-gpios configuration in dts. > Pls also update dt-binding first > Signed-off-by: Clark Wang > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 83

RE: [PATCH 07/11] i2c: imx-lpi2c: increase PM timeout to avoid operate clk frequently

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > Switching the clock frequently will affect the data transmission efficiency, > and > prolong the timeout to reduce autosuspend times for lpi2c. > > Acked-by: Fugang Duan > Signed-off-by: Clark Wang Reviewed-by: Dong Aisheng

RE: [PATCH 06/11] i2c: imx-lpi2c: improve i2c driver probe priority

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > use subsys_initcall for i2c driver to improve i2c driver probe priority Will this affect DMA support which will be probed much later compared with subsys_initcall? > > Signed-off-by: Gao Pan Add your sign-off > --- >

RE: [PATCH 05/11] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > add debug message when i2c peripheral clk rate is 0, then directly return > -EINVAL. > > Signed-off-by: Gao Pan > Reviewed-by: Andy Duan Drop old review when patch is changed > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 7

RE: [PATCH 04/11] i2c: imx-lpi2c: manage irq resource request/release in runtime pm

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > Manage irq resource request/release in runtime pm to save irq domain's > power. > > Signed-off-by: Frank Li > Signed-off-by: Fugang Duan > Reviewed-by: Frank Li > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 26

RE: [PATCH 03/11] i2c: imx-lpi2c: add ipg clk for lpi2c driver

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > The lpi2c IP needs two clks: ipg clk and per clk. The old lpi2c driver missed > ipg > clk. This patch adds ipg clk for lpi2c driver. > Pleas also update dt-binding and sent along with this patchset.(before this one) >

RE: [PATCH 02/11] i2c: imx-lpi2c: add runtime pm support

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > Subject: [PATCH 02/11] i2c: imx-lpi2c: add runtime pm support > > - Add runtime pm support to dynamicly manage the clock. > - Put the suspend to suspend_noirq. > - Call .pm_runtime_force_suspend() to force runtime pm suspended > in

RE: [PATCH 01/11] i2c: imx-lpi2c: directly retrun ISR when detect a NACK

2021-03-18 Thread Aisheng Dong
> From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > A NACK flag in ISR means i2c bus error. In such codition, there is no need to > do > read/write operation. It's better to return ISR directly and then stop i2c > transfer. > > Signed-off-by: Gao Pan > Signed-off-by: Clark Wang

RE: [PATCH] firmware: imx: scu-pd: Update comments for single global power domain

2021-03-18 Thread Aisheng Dong
Hi Ulf, > From: Ulf Hansson > Sent: Wednesday, March 17, 2021 5:31 PM > > Since the introduction of the PM domain support for the scu-pd, the genpd > framework has been continuously improved. More preciously, using a single > global power domain can quite easily be deployed for imx platforms. >

RE: [PATCH v9 7/8] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes

2021-03-12 Thread Aisheng Dong
> From: Mirela Rabulea (OSS) > Sent: Thursday, March 11, 2021 8:29 AM > > Add jpeg decoder/encoder nodes, for now on imx8qxp only. > The same should work on imx8qm, but it was not tested. > > Signed-off-by: Mirela Rabulea Please rebase to latest shawn/for-next branch and add the necessary

RE: [PATCH V3 4/5] dt-bindings: mmc: fsl-imx-esdhc: add clock bindings

2021-03-05 Thread Aisheng Dong
> From: Rob Herring > Sent: Friday, March 5, 2021 10:14 PM > > On Fri, Mar 5, 2021 at 8:09 AM Aisheng Dong > wrote: > > > > Hi Rob, > > > > > From: Peng Fan (OSS) > > > Sent: Thursday, February 25, 2021 11:10 AM > > > > > >

RE: [PATCH V3 4/5] dt-bindings: mmc: fsl-imx-esdhc: add clock bindings

2021-03-05 Thread Aisheng Dong
Hi Rob, > From: Peng Fan (OSS) > Sent: Thursday, February 25, 2021 11:10 AM > > From: Peng Fan > > Add clock bindings for fsl-imx-esdhc yaml > > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml| 11 +++ > 1 file changed, 11 insertions(+) > >

RE: [PATCH] imx: select SOC_BUS to fix firmware build

2021-01-17 Thread Aisheng Dong
> From: Randy Dunlap > Sent: Saturday, January 16, 2021 11:33 AM > Subject: [PATCH] imx: select SOC_BUS to fix firmware build Patch title probably is better to be: firmware: imx: x Otherwise: Reviewed-by: Dong Aisheng Regards Aisheng > > Fix build error in firmware/imx/ selecting

RE: [PATCH 1/3] driver core: simply go out if the same device_link is added again

2020-11-19 Thread Aisheng Dong
> From: Rafael J. Wysocki > Sent: Thursday, November 19, 2020 8:12 PM > > On Thu, Nov 19, 2020 at 12:18 PM Dong Aisheng > wrote: > > > > It's possible that the same device link may be added by parsing the > > function dependecy in DT. e.g. clock/gpio/regulators. > > Simply go out for this case.

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-19 Thread Aisheng Dong
> From: Greg Kroah-Hartman > Sent: Thursday, November 19, 2020 10:26 PM > > On Thu, Nov 19, 2020 at 02:09:42PM +0000, Aisheng Dong wrote: > > > From: Greg Kroah-Hartman > > > Sent: Thursday, November 19, 2020 9:10 PM > > > > > > On Thu, Nov

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-19 Thread Aisheng Dong
> From: Greg Kroah-Hartman > Sent: Thursday, November 19, 2020 9:10 PM > > On Thu, Nov 19, 2020 at 04:13:34AM +0000, Aisheng Dong wrote: > > > Long story short, either > > > > > > * Don't care about the power domain in your clock driver. > > &g

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-18 Thread Aisheng Dong
> From: Saravana Kannan > Sent: Thursday, November 19, 2020 6:22 AM > > On Wed, Nov 18, 2020 at 7:40 AM Aisheng Dong > wrote: > > > > > From: Greg Kroah-Hartman > > > Sent: Wednesday, November 18, 2020 6:46 PM > > > > > > On Wed, Nov 18,

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-18 Thread Aisheng Dong
> From: Greg Kroah-Hartman > Sent: Wednesday, November 18, 2020 6:46 PM > > On Wed, Nov 18, 2020 at 10:23:42AM +0000, Aisheng Dong wrote: > > Hi Greg, > > > > > From: Greg Kroah-Hartman > > > Sent: Monday, November 9, 2020 8:48 PM > > > >

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-18 Thread Aisheng Dong
Hi Greg, > From: Greg Kroah-Hartman > Sent: Monday, November 9, 2020 8:48 PM > > On Mon, Nov 09, 2020 at 12:26:55PM +0000, Aisheng Dong wrote: > > > From: Greg Kroah-Hartman > > > Sent: Monday, November 9, 2020 8:05 PM > > > > > > On Mon, Nov

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-09 Thread Aisheng Dong
> From: Greg Kroah-Hartman > Sent: Monday, November 9, 2020 8:05 PM > > On Mon, Nov 09, 2020 at 11:55:46AM +0000, Aisheng Dong wrote: > > > From: Greg Kroah-Hartman > > > Sent: Monday, November 9, 2020 7:41 PM > > > > > > On Mon, Nov 09, 2020 at

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-09 Thread Aisheng Dong
> From: Greg Kroah-Hartman > Sent: Monday, November 9, 2020 7:41 PM > > On Mon, Nov 09, 2020 at 10:57:05AM +0000, Aisheng Dong wrote: > > Hi Greg, > > > > > From: Greg Kroah-Hartman > > > Sent: Monday, November 9, 2020 6:37 PM > > &

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-09 Thread Aisheng Dong
> From: Sudip Mukherjee > Sent: Monday, November 9, 2020 7:19 PM > > Hi Aisheng, > > On Mon, Nov 9, 2020 at 10:57 AM Aisheng Dong > wrote: > > > > Hi Greg, > > > > > From: Greg Kroah-Hartman > > > Sent: Monday, November 9, 2020 6:37

RE: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-09 Thread Aisheng Dong
Hi Greg, > From: Greg Kroah-Hartman > Sent: Monday, November 9, 2020 6:37 PM > Subject: Re: [PATCH RESEND] driver core: export device_is_bound() to fix build > failure > > On Mon, Nov 09, 2020 at 10:14:46AM +, Sudip Mukherjee wrote: > > Hi Greg, > > > > On Sun, Nov 8, 2020 at 8:23 AM Greg

RE: [PATCH] clk: imx: remove redundant assignment to pointer np

2020-10-29 Thread Aisheng Dong
> From: Colin King > Sent: Friday, October 30, 2020 6:40 AM > > Pointer np is being initialized with a value that is never read and it is > being > updated with a value later on. The initialization is redundant and can be > removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by:

RE: [PATCH v2 5/5] soc: imx8: Add the SC SECVIO driver

2020-10-17 Thread Aisheng Dong
> From: Shawn Guo > Sent: Wednesday, August 19, 2020 9:32 PM > > > > The SNVS is a hardware component in the imx8 SoC. One of its function > > is to detect hardware attacks, in which case it creates a SECurity > > VIOlation. > > > > This patch adds the support for the reception of these secvio

RE: [PATCH v2 4/5] dt-bindings: arm: imx: Documentation of the SC secvio driver

2020-10-17 Thread Aisheng Dong
> From: Franck Lenormand (OSS) > Sent: Tuesday, July 21, 2020 11:21 PM > > This patch adds the documentation for the SECurity VIOlation driver using the > SCU on imx8x and imx8q. > > Signed-off-by: Franck LENORMAND > --- > .../bindings/arm/freescale/fsl,imx-sc-secvio.yaml | 34 >

RE: [PATCH v2 3/5] dt-bindings: firmware: imx-scu: Add SECVIO resource

2020-10-17 Thread Aisheng Dong
> From: Franck Lenormand (OSS) > Sent: Tuesday, July 21, 2020 11:21 PM > > The SNVS can trigger interruption when detecting a SECurity VIOlation. > This patch adds the definition of the resource. > Not sure if the uppercase of 'SECurity VIOlation' is intended because it looks strange.

RE: [PATCH v2 2/5] firmware: imx: scu-irq: Add API to retrieve status of IRQ

2020-10-17 Thread Aisheng Dong
> From: Franck Lenormand (OSS) > Sent: Tuesday, July 21, 2020 11:21 PM > > This patch adds the API to retrieve the status of an IRQ. > > It also adds values used to process SECVIO IRQ from the SCU. > > Signed-off-by: Franck LENORMAND > --- > drivers/firmware/imx/imx-scu-irq.c | 37 >

RE: [PATCH v2 1/5] firmware: imx: scu-seco: Add SEcure Controller APIS

2020-10-17 Thread Aisheng Dong
> From: Franck Lenormand (OSS) > Sent: Tuesday, July 21, 2020 11:21 PM > Subject: [PATCH v2 1/5] firmware: imx: scu-seco: Add SEcure Controller APIS Is 'Secure' intended? Not 'Secure'? > > This patch adds the APIs: > - imx_sc_seco_build_info: get commit and sha of SECO > -

RE: [PATCH] opp: Don't always remove static OPPs in _of_add_opp_table_v1()

2020-10-14 Thread Aisheng Dong
e multiple calls for same OPP table in > _of_add_opp_table_v1()") > Reported-by: Aisheng Dong > Signed-off-by: Viresh Kumar Tested-by: Dong Aisheng Regards Aisheng > --- > drivers/opp/of.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/opp/of.c b/

RE: [PATCH V3 1/4] gpio: mxc: Support module build

2020-10-13 Thread Aisheng Dong
Hi Shawn, > From: Anson Huang > Sent: Monday, October 12, 2020 7:36 PM > > Hi, Shawn > > > Subject: Re: [PATCH V3 1/4] gpio: mxc: Support module build > > > > On Thu, Sep 17, 2020 at 7:40 AM Anson Huang > > wrote: > > > > > Change config to tristate, add module device table, module author, >

RE: [PATCH v3] dt-bindings: mailbox: fsl,mu: Add missing power-domains

2020-09-17 Thread Aisheng Dong
> From: Krzysztof Kozlowski > Sent: Friday, September 18, 2020 3:42 AM > > Add quite common property - power-domains - to fix dtbs_check warnings > like: > > arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: > mailbox@5d28: 'power-domains' does not match any of the regexes: >

RE: [PATCH V2 4/4] ARM: imx: cpuidle-imx7ulp: Stop mode disallowed when HSRUN

2020-09-16 Thread Aisheng Dong
> From: Peng Fan > Sent: Wednesday, September 16, 2020 10:49 AM > > When cpu runs in HSRUN mode, cpuidle is not allowed to run into Stop mode. > So add imx7ulp_get_mode to get thr cpu run mode, and use WAIT mode > instead, when cpu in HSRUN mode. > > Signed-off-by: Peng Fan > --- >

RE: [PATCH V2 3/4] ARM: imx: imx7ulp: support HSRUN mode

2020-09-16 Thread Aisheng Dong
> From: Peng Fan > Sent: Wednesday, September 16, 2020 10:49 AM > > Configure PMPROT to let ARM core could run into HSRUN mode. > In LDO-enabled mode, HSRUN mode is not allowed, so add a check before > configure PMPROT. > > Signed-off-by: Peng Fan > --- > arch/arm/mach-imx/pm-imx7ulp.c | 15

RE: [PATCH V2 2/4] ARM: dts: imx7ulp: add pmc node

2020-09-16 Thread Aisheng Dong
> From: Peng Fan > Sent: Wednesday, September 16, 2020 10:49 AM > > Add i.MX7ULP pmc node for m4 and a7. > > Signed-off-by: Peng Fan > --- > arch/arm/boot/dts/imx7ulp.dtsi | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi

RE: [PATCH V2 1/4] dt-bindings: fsl: add i.MX7ULP PMC

2020-09-16 Thread Aisheng Dong
> From: Peng Fan > Sent: Wednesday, September 16, 2020 10:49 AM > > Update fsl,imx7ulp-pm.yaml to include pmc > > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/arm/freescale/fsl,imx7ulp-pm.yaml | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git >

RE: [PATCH v2 0/5] Add support of SECVIO from SNVS on iMX8q/x

2020-09-13 Thread Aisheng Dong
> From: Shawn Guo > Sent: Wednesday, August 19, 2020 9:23 PM > > On Tue, Aug 18, 2020 at 09:52:02AM +0200, Franck LENORMAND (OSS) wrote: > > Hello, > > > > Peng was able to do a firt pass of review on my patchset which led to > > this second version. I hope a maintainer will be able to take a

RE: [PATCH 1/4] dt-bindings: fsl: add i.MX7ULP PMC binding doc

2020-09-11 Thread Aisheng Dong
> From: Peng Fan > Sent: Friday, September 11, 2020 3:45 PM > > > Subject: RE: [PATCH 1/4] dt-bindings: fsl: add i.MX7ULP PMC binding > > doc > > > > > From: Peng Fan > > > Sent: Friday, September 11, 2020 11:31 AM > > > > > > Add i.MX7ULP Power Management Controller binding doc > > > > > >

RE: [PATCH v3 03/14] dt-bindings: clock: imx8mp: Add ids for the audio shared gate

2020-09-11 Thread Aisheng Dong
> From: Abel Vesa > Sent: Tuesday, September 8, 2020 6:25 PM > > All these IDs are for one single HW gate (CCGR101) that is shared between > these > root clocks. > > Signed-off-by: Abel Vesa > Acked-by: Rob Herring Seems missed my tag. So: Reviewed-by: Dong Aisheng Regards Aisheng > ---

RE: [PATCH v3 06/14] dt-bindings: clock: imx8mp: Add hdmi blk_ctl clock IDs

2020-09-11 Thread Aisheng Dong
> From: Abel Vesa > Sent: Tuesday, September 8, 2020 6:25 PM > > These will be used by the imx8mp for blk_ctl driver. > > Signed-off-by: Abel Vesa > Acked-by: Rob Herring Reviewed-by: Dong Aisheng Regards Aisheng > --- > include/dt-bindings/clock/imx8mp-clock.h | 40 >

RE: [PATCH 1/4] dt-bindings: fsl: add i.MX7ULP PMC binding doc

2020-09-11 Thread Aisheng Dong
> From: Peng Fan > Sent: Friday, September 11, 2020 11:31 AM > > Add i.MX7ULP Power Management Controller binding doc > > Signed-off-by: Peng Fan > --- > .../bindings/arm/freescale/imx7ulp-pmc.yaml | 33 +++ > 1 file changed, 33 insertions(+) > create mode 100644 >

RE: [PATCH] ARM: imx7ulp: enable cpufreq

2020-09-11 Thread Aisheng Dong
> From: Peng Fan > Sent: Friday, September 11, 2020 11:32 AM > > > Enable cpufreq for i.MX7ULP when imx cpufreq dt driver enabled. > > Signed-off-by: Peng Fan Reviewed-by: Dong Aisheng Regards Aisheng

RE: [PATCH V4 2/3] pinctrl: imx: Support building SCU pinctrl core driver as module

2020-09-08 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, September 8, 2020 4:12 PM > > Change PINCTR_IMX_SCU to tristate, add module author, description and > license to support building SCU pinctrl core driver as module. > > Signed-off-by: Anson Huang > --- > changes since V3: > - remove the prompt for

RE: [PATCH V4 1/3] pinctrl: imx: Use function callbacks for SCU related functions

2020-09-08 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, September 8, 2020 4:12 PM > > Use function callbacks for SCU related functions in pinctrl-imx.c in order to > support the scenario of PINCTRL_IMX is built in while PINCTRL_IMX_SCU is built > as module, all drivers using SCU pinctrl driver need to initialize

RE: [PATCH V2 3/3] pinctrl: imx: Support building i.MX pinctrl core driver as module

2020-09-07 Thread Aisheng Dong
> From: Anson Huang > Sent: Monday, September 7, 2020 8:33 PM > > Change PINCTRL_IMX to tristate to support loadable module build. > > And i.MX common pinctrl driver should depend on CONFIG_OF to make sure no > build error when i.MX common pinctrl driver is enabled for different > architectures

RE: [PATCH V2 2/3] pinctrl: imx: Support building SCU pinctrl core driver as module

2020-09-07 Thread Aisheng Dong
> From: Anson Huang > Sent: Monday, September 7, 2020 8:33 PM > > Change PINCTR_IMX_SCU to tristate, remove unnecessary #ifdef and add > module author, description and license to support building SCU pinctrl core > driver as module. > > Signed-off-by: Anson Huang > --- > Changes since V1: >

RE: [PATCH V2 1/3] pinctrl: imx: Use function callbacks for SCU related functions

2020-09-07 Thread Aisheng Dong
> From: Anson Huang > Sent: Monday, September 7, 2020 8:33 PM > > Use function callbacks for SCU related functions in pinctrl-imx.c in order to > support the scenario of PINCTRL_IMX is built in while PINCTRL_IMX_SCU is built > as module, all drivers using SCU pinctrl driver need to initialize

RE: [PATCH 2/2] pinctrl: imx: Support building i.MX pinctrl driver as module

2020-09-07 Thread Aisheng Dong
> From: Anson Huang > Sent: Thursday, July 16, 2020 11:07 PM > Subject: [PATCH 2/2] pinctrl: imx: Support building i.MX pinctrl driver as > module > S/pinctrl driver/pinctrl core driver This also applies for Patch 1/2. > Change PINCTRL_IMX to tristate to support loadable module build. > >

RE: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as module

2020-09-07 Thread Aisheng Dong
> From: Anson Huang > Sent: Thursday, July 16, 2020 11:07 PM > Subject: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as > module > > To support building i.MX SCU pinctrl driver as module, below things need to be > changed: > > - Export SCU related functions This line

RE: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as module

2020-09-07 Thread Aisheng Dong
> From: Anson Huang > Sent: Friday, July 17, 2020 5:53 PM > > Hi, Arnd > > > Subject: Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl > > driver as module > > > > On Fri, Jul 17, 2020 at 11:24 AM Anson Huang > > wrote: > > > > Subject: Re: [PATCH 1/2] pinctrl: imx: Support building

RE: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC

2020-08-24 Thread Aisheng Dong
> From: Krzysztof Kozlowski > Sent: Monday, August 24, 2020 12:16 AM > > The USDHC on i.MX 8QXP has its own compatible described in bindings and > used in the driver (with its own quirks). Remove additional fsl,imx7d-usdhc > compatible to fix dtbs_check warnings like: > >

RE: Lockdep warning caused by "driver core: Fix sleeping in invalid context during device link deletion"

2020-08-24 Thread Aisheng Dong
> From: Saravana Kannan > Sent: Saturday, August 22, 2020 2:28 AM > > On Thu, Aug 20, 2020 at 8:50 PM Dong Aisheng > wrote: > > > > Hi ALL, > > > > We met the below WARNING during system suspend on an iMX6Q SDB board > > with the latest linus/master branch (v5.9-rc1+) and next-20200820. > >

RE: [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU

2020-07-13 Thread Aisheng Dong
> From: Vincenzo Frascino > Sent: Monday, July 6, 2020 11:00 PM > > imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only > when CONFIG_PM_SLEEP configuration options is enabled. Having it disabled > triggers the following warning at compile time: > >

RE: [PATCH V4 2/5] clk: imx: Add clock configuration for ARMv7 platforms

2020-07-01 Thread Aisheng Dong
> From: Anson Huang > Sent: Thursday, July 2, 2020 10:15 AM > > Add CONFIG_CLK_xxx for i.MX ARMv7 platforms, and use it as build option > instead of CONFIG_SOC_xxx, the CONFIG_CLK_xxx will be selected by default > according to CONFIG_SOC_xxx. > > Signed-off-by: Anson Huang Reviewed-by: Dong

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-29 Thread Aisheng Dong
> From: Arnd Bergmann > Sent: Monday, June 29, 2020 4:20 PM > > On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng > wrote: > > On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd wrote: > > > Quoting Aisheng Dong (2020-06-23 19:59:09) Why aren't there options > >

RE: [PATCH V3 03/10] ARM: imx: Select MXC_CLK for each SoC

2020-06-29 Thread Aisheng Dong
> From: Anson Huang > Sent: Monday, June 29, 2020 1:54 PM > > i.MX common clock drivers may support module build, so it is NOT selected by > default, for ARCH_MXC ARMv7 platforms, need to select it manually in each SoC > to make build pass. > > Signed-off-by: Anson Huang > --- > Changes since

RE: [PATCH V3] firmware: imx: Move i.MX SCU soc driver into imx firmware folder

2020-06-28 Thread Aisheng Dong
> From: Anson Huang > Sent: Friday, June 26, 2020 5:14 AM > > The i.MX SCU soc driver depends on SCU firmware driver, so it has to use > platform driver model for proper defer probe operation, since it has no device > binding in DT file, a simple platform device is created together inside the >

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-24 Thread Aisheng Dong
> From: Arnd Bergmann > Sent: Wednesday, June 24, 2020 3:47 PM > > On Wed, Jun 24, 2020 at 4:19 AM Aisheng Dong > wrote: > > > Isn't that what we want? > > > > No, if user set MXC_CLK to m, the build will break for i.MX6&7. > > > > > Why

RE: [PATCH V6 0/9] Support i.MX8 SoCs pinctrl drivers built as module

2020-06-24 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 24, 2020 2:24 PM > > There are more and mroe requirements that SoC specific modules should be > built as module in order to support generic kernel image, such as Android GKI > concept. > > This patch series supports i.MX8 SoCs pinctrl drivers to be

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Aisheng Dong
ect: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock > > > driver as module > > > > > > Quoting Aisheng Dong (2020-06-23 02:00:47) > > > > > From: Stephen Boyd > > > > > Sent: Tuesday, June 23, 2020 4:34 PM > > > > > S

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Aisheng Dong
> From: Stephen Boyd > Sent: Wednesday, June 24, 2020 8:58 AM > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Aisheng Dong (2020-06-23 02:00:47) > > > From: Stephen Boyd > > > Sent: Tuesday, June 23, 2020 4:34

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Aisheng Dong
> From: Stephen Boyd > Sent: Tuesday, June 23, 2020 4:34 PM > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Aisheng Dong (2020-06-22 20:42:19) > > > From: Stephen Boyd > > > Sent: Saturday, June 20, 2020 11:28

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-22 Thread Aisheng Dong
> From: Stephen Boyd > Sent: Saturday, June 20, 2020 11:28 AM > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Aisheng Dong (2020-06-17 18:58:51) > > > From: Anson Huang > > > > > +obj-$(CONFIG_MXC_CLK_

RE: [PATCH] mailbox: imx: Mark PM functions as __maybe_unused

2020-06-22 Thread Aisheng Dong
> From: Nathan Chancellor > Sent: Tuesday, June 23, 2020 9:04 AM > > When CONFIG_PM and CONFIG_PM_SLEEP are unset, the following warnings > occur: > > drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume' > defined but not used [-Wunused-function] > 638 | static int

RE: [PATCH] soc: imx-scu: Support module build

2020-06-19 Thread Aisheng Dong
> From: Arnd Bergmann > Sent: Thursday, June 18, 2020 3:21 PM > > On Wed, Jun 17, 2020 at 11:41 AM Anson Huang > wrote: > > > > > > > > > I'm ok with the change. But I'm curious how can this module be > > > > autoloaded without MODULE_DEVICE_TABLE. > > > > Have you tested if it can work? > > >

RE: [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Thursday, June 18, 2020 11:18 AM > > > From: Aisheng Dong > > Sent: 2020年6月18日 11:09 > > > > > From: Anson Huang > > > Sent: Wednesday, June 17, 2020 8:36 PM > > > > > > > Subject: RE: [PATCH V2

RE: [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 17, 2020 8:36 PM > > > Subject: RE: [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC > > > > > From: Anson Huang > > > Sent: Tuesday, June 9, 2020 3:32 PM > > > > > > i.MX common clock drivers may support module build, so it is NOT > > > selected

RE: [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite()

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 17, 2020 8:32 PM > > > Subject: RE: [PATCH V2 1/9] clk: composite: Export > > clk_hw_register_composite() > > > > > From: Anson Huang > > > Sent: Tuesday, June 9, 2020 3:32 PM > > > > > > Export clk_hw_register_composite() to support user built as

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 17, 2020 8:27 PM > > > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock > > driver as module > > > > > From: Anson Huang > > > Sent: Tuesday, June 9, 2020 3:32 PM > > > > > > There are more and more requirements of building SoC

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, June 9, 2020 3:32 PM > > There are more and more requirements of building SoC specific drivers as > modules, add support for building SCU clock driver as module to meet the > requirement. > > Signed-off-by: Anson Huang > --- > Changes since V1: > -

RE: [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, June 9, 2020 3:32 PM > > i.MX common clock drivers may support module build, so it is NOT selected by > default, for ARCH_MXC ARMv7 platforms, need to select it manually to make > build pass. > > Signed-off-by: Anson Huang Can't the original def_xxx work?

RE: [PATCH V5 1/9] pinctrl: imx: Support building SCU pinctrl driver as module

2020-06-17 Thread Aisheng Dong
[...] > > > > > - * @dev: a pointer back to containing device > > > > > - * @base: the offset to the controller in virtual memory > > > > > - */ > > > > > -struct imx_pinctrl { > > > > > - struct device *dev; > > > > > - struct pinctrl_dev *pctl; > > > > > - void __iomem *base; > > >

RE: [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite()

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, June 9, 2020 3:32 PM > > Export clk_hw_register_composite() to support user built as module. > > ERROR: modpost: "clk_hw_register_composite" [drivers/clk/imx/mxc-clk.ko] > undefined! > scripts/Makefile.modpost:111: recipe for target 'Module.symvers' failed >

RE: [PATCH] thermal: imx8mm: Support module autoloading

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 17, 2020 3:48 PM > > Add a missing MODULE_DEVICE_TABLE entry to support module autoloading. > > Signed-off-by: Anson Huang Reviewed-by: Dong Aisheng Regards Aisheng

RE: [PATCH] soc: imx-scu: Support module build

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 17, 2020 12:54 PM > > Change the configuration type to tristate, add module description, author and > license to support module build. > > Signed-off-by: Anson Huang > --- > drivers/soc/imx/Kconfig | 2 +- > drivers/soc/imx/soc-imx-scu.c | 5

RE: [PATCH V5 1/9] pinctrl: imx: Support building SCU pinctrl driver as module

2020-06-16 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, June 16, 2020 6:44 PM > > > Subject: RE: [PATCH V5 1/9] pinctrl: imx: Support building SCU pinctrl > > driver as module > > > > > From: Anson Huang > > > Sent: Thursday, June 11, 2020 7:35 PM > > > > > > To support building i.MX SCU pinctrl driver as module,

RE: [PATCH V5 1/9] pinctrl: imx: Support building SCU pinctrl driver as module

2020-06-16 Thread Aisheng Dong
> From: Anson Huang > Sent: Thursday, June 11, 2020 7:35 PM > > To support building i.MX SCU pinctrl driver as module, below things need to be > changed: > > - Export SCU related functions and use "IS_ENABLED" instead of > "ifdef" to support SCU pinctrl driver user and itself to be >

RE: [PATCH] i2c: imx: Fix external abort on early interrupt

2020-06-15 Thread Aisheng Dong
> From: Wolfram Sang > Sent: Friday, June 12, 2020 9:00 PM > > On Fri, Jun 12, 2020 at 02:18:06PM +0200, Marc Kleine-Budde wrote: > > On 6/12/20 1:51 PM, Wolfram Sang wrote: > > > > > >> This basically kills the concept of devm for interrupts. Some other > > > > > > It only works when you can

RE: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error

2020-06-15 Thread Aisheng Dong
> From: Wolfram Sang > Sent: Sunday, June 14, 2020 5:12 PM > > On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even the > > call returns an error code. Thus a corresponding decrement is needed > > on the error

RE: [PATCH] i2c: busses: Fix a reference count leak.

2020-06-15 Thread Aisheng Dong
> From: Andy Duan > Sent: Monday, June 15, 2020 10:49 AM > > From: wu000...@umn.edu Sent: Sunday, June 14, > 2020 6:12 AM > > From: Qiushi Wu > > > > pm_runtime_get_sync() increments the runtime PM usage counter even > > when it returns an error code. Thus call pm_runtime_put_noidle() if > >

RE: [PATCH V3 0/9] Support i.MX8 SoCs pinctrl drivers built as module

2020-06-10 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, June 9, 2020 10:21 PM > > There are more and mroe requirements that SoC specific modules should be > built as module in order to support generic kernel image, such as Android GKI > concept. > > This patch series supports i.MX8 SoCs pinctrl drivers to be

RE: [PATCH V2] soc: imx8m: Correct i.MX8MP UID fuse offset

2020-06-10 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 10, 2020 6:42 AM > > Correct i.MX8MP UID fuse offset according to fuse map: > > UID_LOW: 0x420 > UID_HIGH: 0x430 > > Fixes: fc40200ebf82 ("soc: imx: increase build coverage for imx8m soc driver") AFAIK "Fixes:" should point to the original patch

RE: [PATCH] soc: imx: scu: use devm_kasprintf

2020-06-04 Thread Aisheng Dong
> From: Peng Fan > Sent: Wednesday, June 3, 2020 5:30 PM > > Use devm_kasprintf to simplify code > > Signed-off-by: Peng Fan Reviewed-by: Dong Aisheng Regards Aisheng

RE: [PATCH V2] dt-bindings: clock: Convert imx7ulp clock to json-schema

2020-06-04 Thread Aisheng Dong
> From: Anson Huang > Sent: Thursday, June 4, 2020 9:33 AM > > Convert the i.MX7ULP clock binding to DT schema format using json-schema, > the original binding doc is actually for two clock modules(SCG and PCC), so > split > it to two binding docs, and the MPLL(mipi PLL) is NOT supposed to be

RE: [PATCH V2 2/3] firmware: imx: add resource management api

2020-06-04 Thread Aisheng Dong
> From: Peng Fan > Sent: Wednesday, June 3, 2020 11:32 AM > > Add resource management API, when we have multiple partition running > together, resources not owned to current partition should not be used. > > Reviewed-by: Leonard Crestez > Signed-off-by: Peng Fan > --- >

RE: [PATCH 2/4] firmware: imx: add resource management api

2020-06-02 Thread Aisheng Dong
> From: Peng Fan > Sent: Tuesday, June 2, 2020 3:48 PM > > > > > From: Peng Fan > > > Sent: Tuesday, June 2, 2020 12:51 PM > > > > > > > > > From: Peng Fan > > > > > Sent: Monday, June 1, 2020 8:40 PM > > > > > > > > > > > > > From: Peng Fan > > > > > > > Sent: Friday, April 24, 2020 9:12 AM >

RE: [PATCH 2/4] firmware: imx: add resource management api

2020-06-02 Thread Aisheng Dong
> From: Peng Fan > Sent: Tuesday, June 2, 2020 12:51 PM > > > > > From: Peng Fan > > > Sent: Monday, June 1, 2020 8:40 PM > > > > > > > > > From: Peng Fan > > > > > Sent: Friday, April 24, 2020 9:12 AM > > > > > > > > > > > > > From: Peng Fan > > > > > > > Sent: Thursday, April 23, 2020 6:57

RE: [PATCH 2/4] firmware: imx: add resource management api

2020-06-02 Thread Aisheng Dong
> From: Peng Fan > Sent: Tuesday, June 2, 2020 1:24 PM > > > Subject: RE: [PATCH 2/4] firmware: imx: add resource management api > > > > > From: Peng Fan > > > Sent: Thursday, April 23, 2020 3:00 PM > > > > > > Add resource management API, when we have multiple partition running > > > together,

RE: [PATCH 2/4] firmware: imx: add resource management api

2020-06-01 Thread Aisheng Dong
> From: Peng Fan > Sent: Thursday, April 23, 2020 3:00 PM > > Add resource management API, when we have multiple partition running > together, resources not owned to current partition should not be used. > > Reviewed-by: Leonard Crestez > Signed-off-by: Peng Fan > --- >

RE: [PATCH 2/4] firmware: imx: add resource management api

2020-06-01 Thread Aisheng Dong
> From: Peng Fan > Sent: Monday, June 1, 2020 8:40 PM > > > > > From: Peng Fan > > > Sent: Friday, April 24, 2020 9:12 AM > > > > > > > > > From: Peng Fan > > > > > Sent: Thursday, April 23, 2020 6:57 PM > > > > > > > From: Peng Fan > > > > > > > Sent: Thursday, April 23, 2020 3:00 PM > > > >

RE: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'

2020-06-01 Thread Aisheng Dong
> From: Christophe JAILLET > Sent: Sunday, May 31, 2020 4:50 AM > > 'pinctrl_unregister()' should not be called to undo > 'devm_pinctrl_register_and_init()', it is already handled by the framework. > > This simplifies the error handling paths of the probe function. > The 'imx_free_resources()'

RE: [PATCH V3 2/3] arm64: dts: imx8m: add mu node

2020-06-01 Thread Aisheng Dong
> From: Peng Fan > Sent: Monday, June 1, 2020 4:20 PM > > Add mu node to let A53 could communicate with M Core. > > Signed-off-by: Peng Fan Reviewed-by: Dong Aisheng Regards Aisheng

RE: [PATCH V2 2/3] arm64: dts: imx8m: add mu node

2020-06-01 Thread Aisheng Dong
> From: Peng Fan > Sent: Monday, June 1, 2020 11:43 AM > > Add mu node to let A53 could communicate with M Core. > > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 9 + > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 9 + >

  1   2   3   4   >