Re: [PATCH 1/2] dt-bindings: rtc: add generic bindings

2018-12-07 Thread Alexandre Belloni
personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] dt-bindings: rtc: sun6i-rtc: Fix register range in example

2018-12-07 Thread Alexandre Belloni
cumentation/devicetree/bindings/rtc/sun6i-rtc.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] rtc: proc: printf using alarm for alrm

2018-12-06 Thread Alexandre Belloni
seq_printf(seq, "**\n"); > > - seq_printf(seq, "alarm_IRQ\t: %s\n", > > + seq_printf(seq, "alarm IRQ\t: %s\n", > > alrm.enabled ? "yes" : "no"); > > - seq_printf(seq, "alrm_pending\t: %s\n", > > + seq_printf(seq, "alarm pending\t: %s\n", > > alrm.pending ? "yes" : "no"); > > seq_printf(seq, "update IRQ enabled\t: %s\n", > > (rtc->uie_rtctimer.enabled) ? "yes" : "no"); -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 2/2] dt-bindings: rtc: Move trivial RTCs to rtc.txt

2018-12-03 Thread Alexandre Belloni
On 03/12/2018 17:45:58-0600, Rob Herring wrote: > On Sun, Nov 11, 2018 at 08:31:14PM +0100, Alexandre Belloni wrote: > > Move trivial RTCs to the rtc generic binding documentation as they all also > > support at least 'start-year'. > > > > Signe

Re: [PATCH 1/4] selftests: timers: move PIE tests out of rtctest

2018-12-01 Thread Alexandre Belloni
Hello, On 29/11/2018 17:57:05-0200, Rafael David Tinoco wrote: > On 4/19/18 9:50 AM, Alexandre Belloni wrote: > > Since commit 6610e0893b8bc ("RTC: Rework RTC code to use timerqueue for > > events"), PIE are completely handled using hrtimers, without actually using > &

Re: [PATCH v4 01/21] nvmem: Mark nvmem_type_str array with __maybe_unused

2018-11-28 Thread Alexandre Belloni
used char * const nvmem_type_str[] = { Hum, it is probably better to move the array to nvmem/core.c. I should have done that from the beginning. > [NVMEM_TYPE_UNKNOWN] = "Unknown", > [NVMEM_TYPE_EEPROM] = "EEPROM", > [NVMEM_TYPE_OTP] = "OTP", > -- > 2.19.2 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

2018-11-28 Thread Alexandre Belloni
s free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > * You should have received a copy of the GNU General Public License > * along with this program. If not, see <http://www.gnu.org/licenses/>. and here. > */ -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

2018-11-28 Thread Alexandre Belloni
hanks. > Do you mean that the plan is to push support for the external RTCs (e.g. the i2c ones) to the M4 firmware? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

2018-11-28 Thread Alexandre Belloni
I would say that most of the i.MX based boards include another RTC because the SoC one consumes way too much power. Note that I don't care too much whether it is enabled by default, I was simply explaining why you may want to disable it by default. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

2018-11-28 Thread Alexandre Belloni
gt; > + compatible = "nxp,imx8qxp-sc-rtc"; > > > + }; > > > }; > > IMO this should be disabled by default. > > This module is NOT depending on any board design, should it be enabled by > default in soc dtsi? > Like wdog etc.. > I guess the poi

Re: [PATCH 3/4] defconfig: arm64: add i.MX system controller RTC support

2018-11-27 Thread Alexandre Belloni
X_SC=y I think this has to be m unless you need the RTC to be able to boot. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 1/4] rtc: add i.MX system controller RTC support

2018-11-27 Thread Alexandre Belloni
gt; + rtc = devm_rtc_device_register(>dev, pdev->name, > + _sc_rtc_ops, THIS_MODULE); Please use devm_rtc_allocate_device and rtc_register_device to register the RTC. If possible, you should also set range_min and range_max. If I understand the code correctly, this should simply be range_max = U32_MAX; -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 2/4] dt-bindings: rtc: add binding doc for i.MX system controller RTC driver

2018-11-27 Thread Alexandre Belloni
..d6e2353 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/rtc-imx-sc.txt > @@ -0,0 +1,10 @@ > +* NXP i.MX System Controller Real Time Clock > + > +Required properties: > +- compatible: should be "nxp,imx8qxp-sc-rtc"; > + > +Example: > + >

Re: DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

2018-11-27 Thread Alexandre Belloni
_channel(); > that leaks kmalloc-32 > Mabe I missed something, but it seems that everything DMA related is > deallocated in atmel_release_{tx,rx}_dma(). > > Is this ringing a bell ? > Yes, this is known issue and it has yet to be worked on. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'

2018-11-22 Thread Alexandre Belloni
and remove Fixes tag. >(not sure if any should be provided, and which one would be the best) > --- > drivers/rtc/rtc-max8997.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] rtc: isl1208: Use i2c block read/write routines

2018-11-22 Thread Alexandre Belloni
On 15/11/2018 18:51:18+, Trent Piepho wrote: > The Linux i2c layer has functions to execute common SMBUS/I2C > transactions. The register access code here is identical to the I2C > read/write block data routines. > > Cc: Alessandro Zummo > Cc: Alexandre Belloni >

Re: [PATCH 2/3] dt-bindings: mfd: atmel-usart: add DMA bindings for SPI mode

2018-11-21 Thread Alexandre Belloni
On 21/11/2018 14:52:29-0600, Rob Herring wrote: > On Wed, Nov 21, 2018 at 10:48 AM Alexandre Belloni > wrote: > > > > Hi Rob, > > > > On 21/11/2018 10:41:01-0600, Rob Herring wrote: > > > > +Optional properties in serial and SPI mode

Re: [PATCH 2/3] dt-bindings: mfd: atmel-usart: add DMA bindings for SPI mode

2018-11-21 Thread Alexandre Belloni
quot;rx"; > > The dma-names should have a defined order. > Why is that? Isn't the purpose of names to get rid of any particular ordering? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] ARM: dts: at91: nattis: initialize the BLON pin as output-low early

2018-11-21 Thread Alexandre Belloni
d of a nasty blink of full > backlight with an uninitialized panel. > > Signed-off-by: Peter Rosin > --- > arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 8 > 1 file changed, 8 insertions(+) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[GIT PULL] ARM: at91: fixes for 4.20

2018-11-21 Thread Alexandre Belloni
for 4.20 - Fix the SMC parent clock Romain Izard (1): ARM: dts: at91: sama5d2: use the divided clock for SMC arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Alexandre Belloni, Bootlin

Re: [PATCH] ARM: dts: at91: sama5d2: use the divided clock for SMC

2018-11-21 Thread Alexandre Belloni
On 20/11/2018 21:40:49+0100, Alexandre Belloni wrote: > On 20/11/2018 19:01:32+0100, Romain Izard wrote: > > Le mar. 20 nov. 2018 à 18:16, Alexandre Belloni > > a écrit : > > > > > > Hello Romain, > > > > > > On 20/11/2018 17:57:37+0100, Romain

Re: [PATCH v3 01/20] lib/vsprintf: Print time and date in human readable format via %pt

2018-11-20 Thread Alexandre Belloni
clk *clk, struct printf_spec spec, > const char *fmt) > @@ -1828,6 +1964,8 @@ char *device_node_string(char *buf, char *end, struct > device_node *dn, > * - 'd[234]' For a dentry name (optionally 2-4 last components) > * - 'D[234]' Same as 'd' but for a struct file > * - 'g' For block_device name (gendisk + partition number) > + * - 't[R][dt][rv]' For time and date as represented: > + * Rstruct rtc_time > * - 'C' For a clock, it prints the name (Common Clock Framework) or address > * (legacy clock framework) of the clock > * - 'Cn' For a clock, it prints the name (Common Clock Framework) or address > @@ -1952,6 +2090,8 @@ char *pointer(const char *fmt, char *buf, char *end, > void *ptr, > return address_val(buf, end, ptr, fmt); > case 'd': > return dentry_name(buf, end, ptr, spec, fmt); > + case 't': > + return timeanddate(buf, end, ptr, spec, fmt); > case 'C': > return clock(buf, end, ptr, spec, fmt); > case 'D': > -- > 2.19.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] ARM: dts: at91: sama5d2: use the divided clock for SMC

2018-11-20 Thread Alexandre Belloni
On 20/11/2018 19:01:32+0100, Romain Izard wrote: > Le mar. 20 nov. 2018 à 18:16, Alexandre Belloni > a écrit : > > > > Hello Romain, > > > > On 20/11/2018 17:57:37+0100, Romain Izard wrote: > > > The SAMA5D2 is different from SAMA5D3 and SAMA5D4,

Re: [PATCH] ARM: dts: at91: sama5d2: use the divided clock for SMC

2018-11-20 Thread Alexandre Belloni
status = "disabled"; > > nand_controller: nand-controller { > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[PATCH] MAINTAINERS: edac: drop bouncing email

2018-11-20 Thread Alexandre Belloni
jetztechnologies.com doesn't exist anymore and emails to Ranganathan are bouncing. Signed-off-by: Alexandre Belloni --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a5b256b25905..424ae080b38a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5292,7

[PATCH] edac: i82975x: fix spelling mistake "reserverd" -> "reserved"

2018-11-20 Thread Alexandre Belloni
Fix a spelling mistake in a register layout description. Signed-off-by: Alexandre Belloni --- drivers/edac/i82975x_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c index 892815eaa97b..40249e9c9d26 100644

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Alexandre Belloni
it hangs. > > So you never said it hangs. The stacktrace helps, but a description of > what actually happens also helps. And i expect Quentin has booted this > code lots of times and not had a hang. So some hits how to reproduce > it would also help. Maybe your kernel config? > > I'm interested because he is using the core mdio locking > primitives. If those are broken, i want to know. > My first intuition is that he mac driver quentin is using does phy_connect when the interface is opened while macb is doing it at probe time. I didn't investigate but maybe this can help :) -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'

2018-11-14 Thread Alexandre Belloni
return 0; > + return ret; > } > > static int max8997_rtc_stop_alarm(struct max8997_rtc_info *info) > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] rtc: m41t80: Complete error propagation from SMBus calls

2018-11-14 Thread Alexandre Belloni
On 14/11/2018 12:05:14+, Maciej W. Rozycki wrote: > On Wed, 14 Nov 2018, Alexandre Belloni wrote: > > > > I'll be posting further patches over the coming weeks, based on my > > > original effort as archived here: <https://lkml.org/lkml/2008/5/12/385>,

Re: [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'

2018-11-14 Thread Alexandre Belloni
n error when needed, as it was > previously. > > Fixes: e115a2bf1426 ("rtc: max77686: stop validating rtc_time in .read_time") > Signed-off-by: Christophe JAILLET > --- > drivers/rtc/rtc-max77686.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, th

Re: [PATCH] rtc: m41t80: Complete error propagation from SMBus calls

2018-11-14 Thread Alexandre Belloni
ct/lkml/list/?series=73524=both> > > However I have just realised they'll need another iteration before I post > them. So for now just these two obvious fixes. > Regarding the persistent part, do you really need more than what is provided? As far as I know, the timekeeping

Re: [PATCH] rtc: m41t80: Complete error propagation from SMBus calls

2018-11-14 Thread Alexandre Belloni
ct/lkml/list/?series=73524=both> > > However I have just realised they'll need another iteration before I post > them. So for now just these two obvious fixes. > > Please apply. > > Maciej > --- > drivers/rtc/rtc-m41t80.c | 13 - > 1 file chang

Re: [PATCH] rtc: m41t80: Correct alarm month range with RTC reads

2018-11-14 Thread Alexandre Belloni
with > earlier revisions of the Broadcom SiByte SWARM board I have been using > this code with. However it should be obvious by code inspection. > > Please apply and backport as appropriate. > > Maciej > --- > drivers/rtc/rtc-m41t80.c |2 +- > 1 file changed,

Re: [PATCH v3 2/7] ARM: dts: at91: sama5d2: switch to new binding

2018-11-13 Thread Alexandre Belloni
On 13/11/2018 09:27:09+0100, Ludovic Desroches wrote: > clock is missing in the title of this patch. > I fixed it up in place and pushed the at91-dt branch. Thanks! > Regards > > Ludovic > > On Mon, Nov 12, 2018 at 02:31:03PM +0100, Alexandre Belloni wrote: >

Re: [PATCH] rtc: clean up indentation issues, remove extraneous space, add missing tabs

2018-11-12 Thread Alexandre Belloni
> drivers/rtc/rtc-rk808.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] rtc: omap: Use define directive for PIN_CONFIG_ACTIVE_HIGH

2018-11-12 Thread Alexandre Belloni
off-by: Nathan Chancellor > --- > drivers/rtc/rtc-omap.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[GIT PULL] RTC fixes for 4.20

2018-11-12 Thread Alexandre Belloni
(-) -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: Re: [PATCH 3/4] dt-bindings: rtc: sd3078: add device tree documentation

2018-11-12 Thread Alexandre Belloni
I found that if I didn't add that statement, when I checkpatch, > I would get the following warning. > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #16: > new file mode 100644 > Can I ignore this warning? > Yes, you can. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 3/4] dt-bindings: rtc: sd3078: add device tree documentation

2018-11-12 Thread Alexandre Belloni
> There is no need to list this file here if it is only done to silence checkpatch. > WIIMOTE HID DRIVER > M: David Herrmann > -- > 1.7.9.5 > > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 2/4] rtc: sd3078: new driver.

2018-11-12 Thread Alexandre Belloni
+ i2c_set_clientdata(client, sd3078); > + > + sd3078->rtc = devm_rtc_allocate_device(>dev); > + if (IS_ERR(sd3078->rtc)) > + return PTR_ERR(sd3078->rtc); > + > + sd3078->rtc->ops = _rtc_ops; > + sd3078->rtc->range_min = RTC_TIM

[PATCH v3 6/7] ARM: dts: at91: at91sam9x5: switch to new clock bindings

2018-11-12 Thread Alexandre Belloni
Switch at91sam9x5 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9g15.dtsi | 4 + arch/arm/boot/dts/at91sam9g25.dtsi | 4 + arch/arm/boot/dts/at91sam9g25ek.dts | 4 +- arch/arm/boot/dts/at91sam9g35.dtsi | 4

[PATCH v3 5/7] ARM: dts: at91: at91sam9263: switch to new clock bindings

2018-11-12 Thread Alexandre Belloni
Switch at91sam9263 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9263.dtsi | 315 +++-- 1 file changed, 30 insertions(+), 285 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts

[PATCH v3 4/7] ARM: dts: at91: at91sam9261: switch to new clock bindings

2018-11-12 Thread Alexandre Belloni
Switch at91sam9261 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9261.dtsi | 287 +++-- 1 file changed, 23 insertions(+), 264 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts

[PATCH v3 1/7] ARM: dts: at91: sama5d4: switch to new clock bindings

2018-11-12 Thread Alexandre Belloni
Switch sama5d4 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91-sama5d4ek.dts | 2 +- arch/arm/boot/dts/sama5d4.dtsi | 535 +++ 2 files changed, 49 insertions(+), 488 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH v3 3/7] ARM: dts: at91: at91sam9260: switch to new clock bindings

2018-11-12 Thread Alexandre Belloni
Switch at91sam9260 and at91sam9g20 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9260.dtsi | 308 +++-- arch/arm/boot/dts/at91sam9g20.dtsi | 23 +-- 2 files changed, 31 insertions(+), 300 deletions(-) diff --git

[PATCH v3 7/7] ARM: dts: at91: at91sam9rl: switch to new clock bindings

2018-11-12 Thread Alexandre Belloni
Switch at91sam9rl boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9rl.dtsi | 239 +++--- 1 file changed, 23 insertions(+), 216 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9rl.dtsi b/arch/arm/boot/dts

[PATCH v3 0/7] clk: at91: Rework DT bindings

2018-11-12 Thread Alexandre Belloni
Hi, This is the remaining part of the clock rework series. I'll convert the remaining SoCs later this cycle. Changes in v3: - Dropped clk patches that have been applied - Rebased on top of v4.20-rc1 Alexandre Belloni (7): ARM: dts: at91: sama5d4: switch to new clock bindings ARM: dts

[PATCH v3 2/7] ARM: dts: at91: sama5d2: switch to new binding

2018-11-12 Thread Alexandre Belloni
Switch sama5d2 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 12 +- arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 2 +- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 4 +- arch/arm/boot/dts/sama5d2.dtsi

[PATCH 1/2] dt-bindings: rtc: add generic bindings

2018-11-11 Thread Alexandre Belloni
Add generic binding documentation for the RTC subsystem. Signed-off-by: Alexandre Belloni --- Documentation/devicetree/bindings/rtc/rtc.txt | 30 +++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/rtc.txt diff --git a/Documentation

[PATCH 2/2] dt-bindings: rtc: Move trivial RTCs to rtc.txt

2018-11-11 Thread Alexandre Belloni
Move trivial RTCs to the rtc generic binding documentation as they all also support at least 'start-year'. Signed-off-by: Alexandre Belloni --- Documentation/devicetree/bindings/rtc/rtc.txt | 34 +++ .../devicetree/bindings/trivial-devices.txt | 24 - 2 files

[PATCH 2/2] rtc: nvmem: remove nvmem from struct rtc_device

2018-11-10 Thread Alexandre Belloni
Using devm_nvmem_register allows to avoid tracking the nvmem pointer in the rtc_device structure. This ultimately allows to register multiple nvmem devices from an RTC driver. Signed-off-by: Alexandre Belloni --- drivers/rtc/nvmem.c | 24 ++-- include/linux/rtc.h | 1 - 2

[PATCH 1/2] rtc: nvmem: use devm_nvmem_register()

2018-11-10 Thread Alexandre Belloni
Use the resource managed variant of nvmem_register(). Signed-off-by: Alexandre Belloni --- drivers/rtc/nvmem.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/rtc/nvmem.c b/drivers/rtc/nvmem.c index 36ab183c42f1..2a7220d8b02d 100644 --- a/drivers/rtc/nvmem.c

[PATCH] rtc: class: remove devm_rtc_device_unregister

2018-11-10 Thread Alexandre Belloni
devm_rtc_device_unregister is not used by any driver and should not be used by any new driver. Signed-off-by: Alexandre Belloni --- drivers/rtc/class.c | 26 -- include/linux/rtc.h | 2 -- 2 files changed, 28 deletions(-) diff --git a/drivers/rtc/class.c b/drivers/rtc

Re: [PATCH 2/3] rtc: sd3078: new driver.

2018-11-10 Thread Alexandre Belloni
tic int sd3078_remove(struct i2c_client *client) > +{ > + return 0; > +} > + This function is useless. > +static const struct i2c_device_id sd3078_id[] = { > + {"sd3078", 0}, > + { } > +}; > +MODULE_DEVICE_TABLE(i2c, sd3078_id); > + > +#ifdef CO

Re: [PATCH 1/3] dt-bindings: define vendor prefix for whwave, Inc.

2018-11-10 Thread Alexandre Belloni
@@ zidoo Shenzhen Zidoo Technology Co., Ltd. > zii Zodiac Inflight Innovations > zte ZTE Corp. > zyxelZyXEL Communications Corp. > +whwave Shenzhen whwave Electronics crop This file must be sorted alphabetically. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[PATCH] power: reset: ocelot: switch the SI to boot mode

2018-11-09 Thread Alexandre Belloni
Switch the SI to boot mode so on a warm reboot, the SI is able to access the flash. Signed-off-by: Alexandre Belloni --- drivers/power/reset/ocelot-reset.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/power/reset/ocelot-reset.c b/drivers/power/reset/ocelot-reset.c

Re: [PATCH v7 0/7] clocksource: rework Atmel TCB timer driver

2018-11-08 Thread Alexandre Belloni
On 08/11/2018 13:43:27+0100, Sebastian Andrzej Siewior wrote: > On 2018-09-25 22:14:56 [+0200], Alexandre Belloni wrote: > > On 22/09/2018 13:29:48+0200, Daniel Lezcano wrote: > > > You say for rt the PIT is not suitable because of the shared irq but in > > > the drive

Re: [PATCH 2/4] power: reset: at91-poweroff: move shdwc related data to one structure

2018-11-07 Thread Alexandre Belloni
On 07/11/2018 14:54:17+, claudiu.bez...@microchip.com wrote: > Hi Alexandre, > > On 06.11.2018 23:09, Alexandre Belloni wrote: > > Hi Claudiu, > > > > On 05/11/2018 11:14:26+, claudiu.bez...@microchip.com wrote: > >> static int __init at91_powerof

Re: [PATCH] rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write

2018-11-07 Thread Alexandre Belloni
0/0x138 > [] rtc_dev_ioctl+0x398/0x610 > [] do_vfs_ioctl+0xb0/0x848 > [] SyS_ioctl+0x8c/0xa8 > [] el0_svc_naked+0x34/0x38 > [] 0x > > Signed-off-by: Xulin Sun > --- > drivers/rtc/rtc-pcf2127.c | 3 +++ > 1 file changed, 3 insertions

Re: [PATCH] rtc: hctosys: Add missing range error reporting

2018-11-07 Thread Alexandre Belloni
a5ac42ab18 ("rtc: hctosys: Ensure system time doesn't overflow > time_t") > Cc: sta...@vger.kernel.org # 4.17+ > --- > drivers/rtc/hctosys.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[PATCH] nvmem: add type attribute

2018-11-07 Thread Alexandre Belloni
Add a type attribute so userspace is able to know how the data is stored as this can help taking the correct decision when selecting which device to use. This will also help program display the proper warnings when burning fuses for example. Signed-off-by: Alexandre Belloni --- drivers/nvmem

Re: [PATCH 2/4] power: reset: at91-poweroff: move shdwc related data to one structure

2018-11-06 Thread Alexandre Belloni
o know whether the driver already probed once. But, the driver will never probe twice as there is only one shutdown controller on the SoC and anyway, If it was to probe twice, it will still work as expected. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race condition and leak

2018-10-31 Thread Alexandre Belloni
;rtc); This appeared in v4.13, this will not compile on v3.18. > + if (err) { > if (alarm) { > menelaus_remove_irq_work(MENELAUS_RTCALM_IRQ); > device_init_wakeup(>client->dev, 0); > -- > 2.17.1 > -- Alexandre Bel

[GIT PULL] RTC for 4.20

2018-10-26 Thread Alexandre Belloni
Alexandre Belloni (32): rtc: rv8803: fix the rv8803 id in the OF table rtc: rv8803: add Epson RX8803 support rtc: mt6397: fix possible race condition rtc: pl030: fix possible race condition rtc: pl031: switch to devm_rtc_allocate_device

Re: [PATCH 5/5] rtc: sc27xx: Always read normal alarm when registering RTC device

2018-10-24 Thread Alexandre Belloni
ered and rtc->aie_timer.enabled and this is a bit fragile. But, on the other hand, I currently don't have anything better to suggest. I was also planning to add an in-kernel API for multiple alarms but I'm not sure it will actually help in your case. Anyway, this is applied. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 0/5] Fix some issues for RTC alarm function

2018-10-24 Thread Alexandre Belloni
1 file changed, 40 insertions(+), 20 deletions(-) > All applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2] rtc: s35390a: Change buf's type to u8 in s35390a_init

2018-10-22 Thread Alexandre Belloni
v1 -> v2: > > * Use u8 instead of unsigned char, as it's clearer that this is an > integer value and it's shorter. > > drivers/rtc/rtc-s35390a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] rtc: ds1307: fix ds1339 wakealarm support

2018-10-22 Thread Alexandre Belloni
On 22/10/2018 16:18:13+0200, Soeren Moch wrote: > Hi, > > Am 22.10.2018 um 15:57 schrieb Alexandre Belloni: > > Hello, > > > > On 22/10/2018 14:38:12+0200, Soeren Moch wrote: > >> Commit 51ed73eb998a1c79a2b0e9bed68f75a8a2c93b9b ("rtc: ds1340: Add support

Re: [PATCH] rtc: ds1307: fix ds1339 wakealarm support

2018-10-22 Thread Alexandre Belloni
"rtc: ds1340: Add support for trickle charger.") > Cc: sta...@vger.kernel.org > Signed-off-by: Soeren Moch > -- > Cc: Andrea Greco > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/

Re: [PATCH] rtc: s35390a: Make buf an unsigned char in s35390a_init

2018-10-19 Thread Alexandre Belloni
o be shorter :) > int ret; > unsigned initcount = 0; > > -- > 2.19.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [Ksummit-discuss] [PATCH v3 1/3] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-17 Thread Alexandre Belloni
hat the professionals that deal with information privacy > could provide better wording for the above list. I am but an > amateur in that field. > > Anything else collected by the project would not be considered public. > For example, an email address provided in an email sent to me

Re: [PATCH] misc: atmel-ssc: Fix section annotation on atmel_ssc_get_driver_data

2018-10-17 Thread Alexandre Belloni
On 17/10/2018 11:20:31-0700, Nathan Chancellor wrote: > On Wed, Oct 17, 2018 at 08:16:25PM +0200, Alexandre Belloni wrote: > > On 17/10/2018 10:09:02-0700, Nathan Chancellor wrote: > > > After building the kernel with Clang, the following section mismatch >

Re: [PATCH] misc: atmel-ssc: Fix section annotation on atmel_ssc_get_driver_data

2018-10-17 Thread Alexandre Belloni
iver_data to get rid of the mismatch. > Reviewed-by: Alexandre Belloni I would add: Fixes: 5c86ac695c7e ("ASoC: atmel-ssc: use module_platform_driver macro") > Signed-off-by: Nathan Chancellor > --- > > Alternatively, ssc_probe could be marked as __init, I don't thi

Re: [PATCH v2 00/22] clk: at91: Rework DT bindings

2018-10-17 Thread Alexandre Belloni
On 17/10/2018 09:50:20-0700, Stephen Boyd wrote: > Quoting Alexandre Belloni (2018-10-16 07:21:38) > > This is the promised rework of the at91 PMC clocks driver. It is mainly > > necessary to remove the DTC warnings but it also complies with the CCF > > rule that there s

[PATCH v2 01/22] clk: at91: audio-pll: fix audio pmc type

2018-10-16 Thread Alexandre Belloni
The allocation for the audio pmc is using the size of struct clk_audio_pad instead of struct clk_audio_pmc. This works fine because the former is larger than the latter but it is safer to be correct. Fixes: ("0865805d82d4 clk: at91: add audio pll clock drivers") Signed-off-by: Alexand

[PATCH v2 07/22] clk: at91: add pmc_data struct and helpers

2018-10-16 Thread Alexandre Belloni
Add a new strut to handle references to all the PMC clocks and implement allocation/free helpers. Signed-off-by: Alexandre Belloni --- drivers/clk/at91/pmc.c | 44 ++ drivers/clk/at91/pmc.h | 17 2 files changed, 61 insertions(+) diff

[PATCH v2 05/22] clk: at91: generated: set audio_pll_allowed in at91_clk_register_generated()

2018-10-16 Thread Alexandre Belloni
ake gclk determine audio_pll rate") Signed-off-by: Alexandre Belloni --- drivers/clk/at91/clk-generated.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c index e709a12269c0.

[PATCH v2 04/22] clk: at91: audio-pll: separate registration from DT parsing

2018-10-16 Thread Alexandre Belloni
Separate registration out of of_sama5d2_clk_audio_pll*_setup to allow other code to use it. Signed-off-by: Alexandre Belloni --- drivers/clk/at91/clk-audio-pll.c | 147 +++ 1 file changed, 109 insertions(+), 38 deletions(-) diff --git a/drivers/clk/at91/clk-audio

[PATCH v2 06/22] clk: at91: allow clock registration from C code

2018-10-16 Thread Alexandre Belloni
Remove static keyword to allow functions to be used from other units. Also move some struct and function declarations to pmc.h Signed-off-by: Alexandre Belloni --- drivers/clk/at91/clk-generated.c| 2 +- drivers/clk/at91/clk-i2s-mux.c | 2 +- drivers/clk/at91/clk-main.c

[PATCH v2 12/22] clk: at91: add at91sam9260 PMC driver

2018-10-16 Thread Alexandre Belloni
Add a driver for the PMC clocks of the at91sam9260, at91sam9261, at91am9263 and at91sam9g20 SoCs. Signed-off-by: Alexandre Belloni --- drivers/clk/at91/Makefile | 1 + drivers/clk/at91/at91sam9260.c | 494 + 2 files changed, 495 insertions(+) create mode

[PATCH v2 10/22] clk: at91: add sama5d4 pmc driver

2018-10-16 Thread Alexandre Belloni
Add a driver for the PMC clocks of the sama5d4 Signed-off-by: Alexandre Belloni --- drivers/clk/at91/Makefile | 1 + drivers/clk/at91/sama5d4.c | 264 + 2 files changed, 265 insertions(+) create mode 100644 drivers/clk/at91/sama5d4.c diff --git a/drivers

[PATCH v2 19/22] ARM: dts: at91: at91sam9261: switch to new clock bindings

2018-10-16 Thread Alexandre Belloni
Switch at91sam9261 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9261.dtsi | 287 +++-- 1 file changed, 23 insertions(+), 264 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts

[PATCH v2 11/22] clk: at91: add sama5d2 PMC driver

2018-10-16 Thread Alexandre Belloni
Add a driver for the PMC clocks of the sama5d2 Signed-off-by: Alexandre Belloni --- drivers/clk/at91/Makefile | 1 + drivers/clk/at91/sama5d2.c | 336 + 2 files changed, 337 insertions(+) create mode 100644 drivers/clk/at91/sama5d2.c diff --git a/drivers

[PATCH v2 14/22] clk: at91: add at91sam9rl PMC driver

2018-10-16 Thread Alexandre Belloni
Add a driver for the PMC clocks of the at91sam9rl SoC. Signed-off-by: Alexandre Belloni --- drivers/clk/at91/Makefile | 2 +- drivers/clk/at91/at91sam9rl.c | 171 ++ 2 files changed, 172 insertions(+), 1 deletion(-) create mode 100644 drivers/clk/at91

[PATCH v2 16/22] ARM: dts: at91: sama5d4: switch to new clock bindings

2018-10-16 Thread Alexandre Belloni
Switch sama5d4 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91-sama5d4ek.dts | 2 +- arch/arm/boot/dts/sama5d4.dtsi | 535 +++ 2 files changed, 49 insertions(+), 488 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH v2 09/22] clk: at91: add new DT lookup function

2018-10-16 Thread Alexandre Belloni
Add a new DT lookup function to lookup for PMC clocks. Note that the #ifndef AT91_PMC_MOSCS section will be removed once all the platforms are converted. Signed-off-by: Alexandre Belloni Acked-by: Rob Herring --- drivers/clk/at91/pmc.c | 34 include

[PATCH v2 18/22] ARM: dts: at91: at91sam9260: switch to new clock bindings

2018-10-16 Thread Alexandre Belloni
Switch at91sam9260 and at91sam9g20 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9260.dtsi | 308 +++-- arch/arm/boot/dts/at91sam9g20.dtsi | 23 +-- 2 files changed, 31 insertions(+), 300 deletions(-) diff --git

[PATCH v2 22/22] ARM: dts: at91: at91sam9rl: switch to new clock bindings

2018-10-16 Thread Alexandre Belloni
Switch at91sam9rl boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9rl.dtsi | 239 +++--- 1 file changed, 23 insertions(+), 216 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9rl.dtsi b/arch/arm/boot/dts

[PATCH v2 21/22] ARM: dts: at91: at91sam9x5: switch to new clock bindings

2018-10-16 Thread Alexandre Belloni
Switch at91sam9x5 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9g15.dtsi | 4 + arch/arm/boot/dts/at91sam9g25.dtsi | 4 + arch/arm/boot/dts/at91sam9g25ek.dts | 4 +- arch/arm/boot/dts/at91sam9g35.dtsi | 4

[PATCH v2 17/22] ARM: dts: at91: sama5d2: switch to new binding

2018-10-16 Thread Alexandre Belloni
Switch sama5d2 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 12 +- arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 2 +- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 4 +- arch/arm/boot/dts/sama5d2.dtsi

[PATCH v2 08/22] dt-bindings: clk: at91: Document new PMC binding

2018-10-16 Thread Alexandre Belloni
Document the new PMC binding with only one PMC node for all the PMC clocks instead of one node per clock as this proved to be problematic. Reviewed-by: Rob Herring Signed-off-by: Alexandre Belloni --- .../devicetree/bindings/clock/at91-clock.txt | 516 +- 1 file changed, 21

[PATCH v2 13/22] clk: at91: add at91sam9x5 PMCs driver

2018-10-16 Thread Alexandre Belloni
Add a driver for the PMC clocks of the at91sam9x5 SoCs Signed-off-by: Alexandre Belloni --- drivers/clk/at91/Makefile | 2 +- drivers/clk/at91/at91sam9x5.c | 309 ++ 2 files changed, 310 insertions(+), 1 deletion(-) create mode 100644 drivers/clk/at91

[PATCH v2 03/22] clk: at91: h32mx: separate registration from DT parsing

2018-10-16 Thread Alexandre Belloni
Separate registration out of of_sama5d4_clk_h32mx_setup to allow other code to use it. Signed-off-by: Alexandre Belloni --- drivers/clk/at91/clk-h32mx.c | 40 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/drivers/clk/at91/clk-h32mx.c b

[PATCH v2 15/22] clk: at91: move DT compatibility code to its own file

2018-10-16 Thread Alexandre Belloni
Move all the DT backward compatibility code to its own file so it can be deleted later. Signed-off-by: Alexandre Belloni --- drivers/clk/at91/Makefile | 2 +- drivers/clk/at91/clk-audio-pll.c| 70 -- drivers/clk/at91/clk-generated.c| 65 -- drivers/clk/at91/clk-h32mx.c

[PATCH v2 20/22] ARM: dts: at91: at91sam9263: switch to new clock bindings

2018-10-16 Thread Alexandre Belloni
Switch at91sam9263 boards to the new PMC clock bindings. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9263.dtsi | 315 +++-- 1 file changed, 30 insertions(+), 285 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts

[PATCH v2 02/22] clk: at91: generated: SSCs don't have a gclk

2018-10-16 Thread Alexandre Belloni
As the SSCs don't have gclk, don't check for their ID to allow them to set the audio pll rate. Signed-off-by: Alexandre Belloni --- drivers/clk/at91/clk-generated.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk

[PATCH v2 00/22] clk: at91: Rework DT bindings

2018-10-16 Thread Alexandre Belloni
and at91sam9rl drivers - use CLK_OF_DECLARE_DRIVER - Add helpers to allocate for the proper number of clocks - Collected Rob's acks Alexandre Belloni (22): clk: at91: audio-pll: fix audio pmc type clk: at91: generated: SSCs don't have a gclk clk: at91: h32mx: separate registration from DT parsing

Re: [PATCH v2] rtc: m41t80: mark expected switch fall-through

2018-10-16 Thread Alexandre Belloni
comment. > > Addresses-Coverity-ID: 1373875 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] rtc: tegra: Propagate errors from platform_get_irq()

2018-10-16 Thread Alexandre Belloni
ff-by: Thierry Reding > --- > drivers/rtc/rtc-tegra.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 00/16] clk: at91: Rework DT bindings

2018-10-12 Thread Alexandre Belloni
On 12/10/2018 11:28:06-0700, Stephen Boyd wrote: > Quoting Stephen Boyd (2018-08-31 10:45:30) > > Quoting Alexandre Belloni (2018-08-16 04:47:55) > > > On 27/07/2018 10:03:22-0700, Stephen Boyd wrote: > > > > Quoting Alexandre Belloni (2018-07-17 15:27:41) > &g

  1   2   3   4   5   6   7   8   9   10   >