[PATCH v4] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-04-04 Thread Amit Pundir
From: Sumit Semwal Enabling the Display panel for beryllium requires DSI labibb regulators and panel dts nodes to be added. It is also required to keep some of the regulators as always-on. Signed-off-by: Sumit Semwal Signed-off-by: Amit Pundir Reviewed-by: Konrad Dybcio --- v4: Added

Re: [PATCH v3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-04-04 Thread Amit Pundir
Hi Angelo, On Thu, 11 Feb 2021 at 00:25, AngeloGioacchino Del Regno wrote: > > Il 10/02/21 09:18, Amit Pundir ha scritto: > > From: Sumit Semwal > > > > Enabling the Display panel for beryllium requires DSI > > labibb regulators and panel dts nodes to be added. &

Re: [PATCH v2 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices

2021-03-18 Thread Amit Pundir
y > configuration. > > Rather than providing some basic set that works on the MTP and then > piecemeal patch this up on the various devices, push the configuration > of these regions out to the individual device dts files. > Smoke tested on sdm845-xiaomi-beryllium. Tested-by: A

Re: [PATCH] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add audio support

2021-03-14 Thread Amit Pundir
On Sun, 14 Mar 2021 at 22:32, Joel Selvaraj wrote: > > This patch adds audio support for Xiaomi Poco F1 phone. Phone's primary > Mic and 3.5mm Headphone jack are handled through the SDM845 sound card > and WCD9340 codec. > Tested-by: Amit Pundir > Signe

Re: [PATCH v3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-16 Thread Amit Pundir
Hi, On Fri, 12 Feb 2021 at 23:11, AngeloGioacchino Del Regno wrote: > > Il 12/02/21 10:24, Amit Pundir ha scritto: > > Hi, > > > > On Thu, 11 Feb 2021 at 00:25, AngeloGioacchino Del Regno > > wrote: > >> > >> Il 10/02/21 09:18,

Re: [PATCH v3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-12 Thread Amit Pundir
Hi, On Thu, 11 Feb 2021 at 00:25, AngeloGioacchino Del Regno wrote: > > Il 10/02/21 09:18, Amit Pundir ha scritto: > > From: Sumit Semwal > > > > Enabling the Display panel for beryllium requires DSI > > labibb regulators and panel dts nodes to be added. > >

Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-10 Thread Amit Pundir
> far default lab/ibb nodes are working fine for us and I'm hesitant to > > tinker around anything regulator related that can potentially damage > > the hardware. Having said that, I do see lab/ibb nodes being set in > > the downstream dts, with relevant soft-start and disch

[PATCH v3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-10 Thread Amit Pundir
From: Sumit Semwal Enabling the Display panel for beryllium requires DSI labibb regulators and panel dts nodes to be added. It is also required to keep some of the regulators as always-on. Signed-off-by: Sumit Semwal Signed-off-by: Amit Pundir --- v3: Addressed Konrad's concerns. Confi

Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-05 Thread Amit Pundir
tinker around anything regulator related that can potentially damage the hardware. Having said that, I do see lab/ibb nodes being set in the downstream dts, with relevant soft-start and discharge-resistor properties and I can try switching to that once the new lab/ibb changes land upstream. Regards,

[PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-04 Thread Amit Pundir
From: Sumit Semwal Enabling the Display panel for beryllium phone (Xiaomi Pocophone F1) requires DSI labibb regulators and panel dts nodes to be added. It is also required to keep some of the regulators as always-on. Signed-off-by: Sumit Semwal Signed-off-by: Amit Pundir --- v2: Rebased to

Re: [PATCH] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-03 Thread Amit Pundir
Argh.. This patch is not formatted on top of mainline. It doesn't apply cleanly. Sorry about that. I'll fix that in the next version. Regards, Amit Pundir On Wed, 3 Feb 2021 at 15:29, Amit Pundir wrote: > > From: Sumit Semwal > > Enabling the Display panel for b

[PATCH] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-03 Thread Amit Pundir
From: Sumit Semwal Enabling the Display panel for beryllium phone (Xiaomi Pocophone F1) requires DSI labibb regulators and panel dts nodes to be added. It is also required to keep some of the regulators as always-on. Signed-off-by: Sumit Semwal Signed-off-by: Amit Pundir --- .../boot/dts

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2021-02-02 Thread Amit Pundir
y version (WLAN.HL.2.0.XXX), used by Dragonboard 845c (which has Wi-Fi working upstream). Regards, Amit Pundir > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v9 0/3] Add Novatek NT36xxx touchscreen driver

2020-11-26 Thread Amit Pundir
vices: > - Sony Xperia 10(SDM630 Ganges Kirin) > - Sony Xperia 10 Plus (SDM636 Ganges Mermaid) > Tested the patch series on Xiaomi Poco F1 (SDM845 Beryllium, Novatek NT36672A IC). For the whole series: Tested-by: Amit Pundir Regards, Amit Pundir > Changes in v2: > - Fixed s

Re: [v1] drm/msm/dpu: consider vertical front porch in the prefill bw calculation

2020-11-25 Thread Amit Pundir
etch is enabled. Use vfp in the prefill calculation > as dpu driver enables prefetch if the blanking is not sufficient > to fill the latency lines. Tested on Xiaomi Poco F1 (sdm845). Tested-by: Amit Pundir > > Signed-off-by: Kalyan Thota > --- > drivers/gpu/drm/msm/di

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-11-24 Thread Amit Pundir
Hi Kalyan, On Tue, 24 Nov 2020 at 18:27, wrote: > > On 2020-11-08 23:25, Amit Pundir wrote: > > On Tue, 4 Aug 2020 at 21:09, Rob Clark wrote: > >> > >> On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota > >> wrote: > >> > > >> > This c

[PATCH v2] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-11-23 Thread Amit Pundir
t it didn't help and neither did building board-2.bin file from stock bdwlan* files. This workaround will be removed once we have a viable fix. Thanks to postmarketOS guys for catching this. Signed-off-by: Amit Pundir --- We dropped this workaround last time in the favor of a generic dts qui

Re: [PATCH v9 0/3] Add Novatek NT36xxx touchscreen driver

2020-11-23 Thread Amit Pundir
vices: > - Sony Xperia 10(SDM630 Ganges Kirin) > - Sony Xperia 10 Plus (SDM636 Ganges Mermaid) Tested the patch series on Xiaomi Poco F1 (SDM845 Beryllium) using Novatek NT36672A IC. May I suggest adding "novatek,nt36672a" in the list of compatible of_device_id{} as well.

Re: [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-11-08 Thread Amit Pundir
ernel.org/dri-devel/20201027102304.945424-1-dmitry.barysh...@linaro.org/ Am I missing any other followup fix? Regards, Amit Pundir

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-11-02 Thread Amit Pundir
Hi Rob, Bjorn, Kalle, On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson wrote: > > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > > There are firmware versions which do not support host capability >

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-30 Thread Amit Pundir
On Wed, 30 Sep 2020 at 00:38, Rob Herring wrote: > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > There are firmware versions which do not support host capability > > QMI request. We suspect either the host cap is not implemented or > > there may be

Re: [PATCH v2 2/3] Input: Add Novatek NT36xxx touchscreen driver

2020-09-29 Thread Amit Pundir
On Tue, 29 Sep 2020 at 03:21, Dmitry Torokhov wrote: > > On Mon, Sep 28, 2020 at 03:18:18PM +0530, Amit Pundir wrote: > > On Sun, 27 Sep 2020 at 18:06, wrote: > > > > > > From: AngeloGioacchino Del Regno > > > > > > This is a driver for the Nov

Re: [PATCH v2 2/3] Input: Add Novatek NT36xxx touchscreen driver

2020-09-28 Thread Amit Pundir
o make a minor change to get it working. The downstream driver and even the github code you linked above use GPIO mapped IRQ, and I had to switch to that to get touchscreen working with your driver https://github.com/pundiramit/linux/commit/0a73eb656c1e80787dc195641ce7b0076fddb38e. I wonder if I'

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-25 Thread Amit Pundir
On Fri, 25 Sep 2020 at 20:57, Bjorn Andersson wrote: > > On Thu 24 Sep 11:31 CDT 2020, Kalle Valo wrote: > > > Amit Pundir writes: > > > > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > > > phone. We get a non-fatal QMI_ERR_M

[PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-25 Thread Amit Pundir
are nor to the ath10k driver and we can still bring up the WiFi services successfully if we just ignore it. Hence introducing this DeviceTree quirk to skip host capability QMI request for the firmware versions which do not support this feature. Suggested-by: Bjorn Andersson Signed-off-by: A

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-21 Thread Amit Pundir
On Thu, 17 Sep 2020 at 21:35, Bjorn Andersson wrote: > > On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote: > > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > > message in ath10k_qmi_host_cap_se

[PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-17 Thread Amit Pundir
t it didn't help and neither did building board-2.bin file from stock bdwlan* files. This workaround will be removed once we have a viable fix. Thanks to postmarketOS guys for catching this. Signed-off-by: Amit Pundir --- Device-tree for Xiaomi Poco F1(Beryllium) got merged in qcom/arm64

[RESEND][PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-09-11 Thread Amit Pundir
that shipped with Android-9 based release. Newer bootloader version do not support switching OFF the display panel at all. Signed-off-by: Amit Pundir --- My WIP tree with a few out-of-tree patches to support display, touchscreen, wifi, audio etc is here: https://github.com/pundiramit/linux/co

Re: [PATCH v3 0/8] iommu/arm-smmu: Support maintaining bootloader mappings

2020-09-11 Thread Amit Pundir
and Rob for the Adreno > SMMU support. It applies cleanly ontop of v16 of their series, which can be > found at > https://lore.kernel.org/linux-arm-msm/20200901164707.2645413-1-robdcl...@gmail.com/ > Boot tested the series on Xiaomi Poco F1 phone (sdm845) Tested-by: Amit Pundir &

Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-09-02 Thread Amit Pundir
ilure Linux will fall back to dummy regulators, which is working fine for me so far. Also I see that vdd-*-supply properties are optional according to Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt, so I assume it is safe to skip them? Regards, Amit Pundir > > Konrad

Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-30 Thread Amit Pundir
Hi Konrad, I couldn't find answer to your question around missing (regulatorname)-supply properties. Need help in figuring out that part. Regards, Amit Pundir On Mon, 31 Aug 2020 at 10:54, Amit Pundir wrote: > > Add initial dts support for Xiaomi Poco F1 (Beryllium). > > Thi

[PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-30 Thread Amit Pundir
that shipped with Android-9 based release. Newer bootloader version do not support switching OFF the display panel at all. Signed-off-by: Amit Pundir --- My WIP tree with a few out-of-tree patches to support display, touchscreen, wifi, audio etc is here: https://github.com/pundiramit/linux/co

Re: [PATCH] staging: ion: remove from the tree

2020-08-27 Thread Amit Pundir
if we > delete this now here, that fork can remain just fine, with the added > benifit of it reducing developer workloads here in-kernel. > > So why wait? Hi, I don't know what is the right thing to do here. I just want to highlight that AOSP's audio (codec2) HAL depends on the ION system heap and it will break AOSP for people who boot mainline on their devices, even for just testing purpose like we do in Linaro. Right now we need only 1 (Android specific out-of-tree) patch to boot AOSP with mainline and Sumit is already trying to upstream that vma naming patch. Removal of in-kernel ION, will just add more to that delta. Regards, Amit Pundir > > thanks, > > greg k-h

Re: [PATCH v5] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-25 Thread Amit Pundir
if necessary. > > > > + * It seems that mmc_test reports errors if drive > > + * strength is not 16 on clk, cmd, and data pins. > > You say that, but then you set "drive-strength = <10>;" for cmd and

[PATCH v5] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-21 Thread Amit Pundir
that shipped with Android-9 based release. Newer bootloader version do not support switching OFF the display panel at all. So we need a few additional smmu patches (under review) from here: https://github.com/pundiramit/linux/commits/beryllium-mainline Signed-off-by: Amit Pundir --- v5: Bumped &a

Re: your mail

2020-08-17 Thread Amit Pundir
g this downstream &removed_region (of size 0x1A0) + previously unreserved downstream memory region (of size 0x20), to align with the starting address of &qseecom_mem? I just gave this &tz_mem change a spin and I do not see any obvious regression in my limited smoke testing

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-08-17 Thread Amit Pundir
t instead, during the shutdown/reboot process. But I'm happy to take a swing at any intermediate/in-progress solution available. Regards, Amit Pundir > > Forcing QCA6390 users to use the userspace qrtr-ns would be bad user > experience, I really would want to avoid that. >

Re: [PATCH v4 0/2] dma-pool fixes

2020-08-14 Thread Amit Pundir
ree patches [1]) and I see no obvious regressions. For both the patches in the series: Tested-by: Amit Pundir [1] https://github.com/pundiramit/linux/commits/beryllium-mainline-display > > --- > Changes since v3: > - Do not use memblock_start_of_DRAM() > > Changes since v2: &

Re:

2020-08-12 Thread Amit Pundir
On Fri, 7 Aug 2020 at 04:02, Konrad Dybcio wrote: > > Subject: Re: [PATCH v4] arm64: dts: qcom: Add support for Xiaomi Poco F1 > (Beryllium) > > >// This removed_region is needed to boot the device > > // TODO: Find out the user of this reserved memory > > removed_regi

Re: [PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

2020-08-12 Thread Amit Pundir
bles belongs to an > early engineering rev of the SoC. > Fix up the OPP tables such that it now matches with the > production rev of sdm845 SoC. > > Fixes: 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup > devices") Fixes BT on Xiaomi Poco F1 phone running AO

Re: [RFC v2 03/11] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state

2020-08-12 Thread Amit Pundir
sue that was also reported on venus [1] because the > clock frequency tables apparently don;t exactly match the achievable clock > frequencies (which we also used to construct the OPP tables) > > Can you try updating the OPP table for QUP to have 10240 instead of the > current 1 and see if that fixes it? That worked. Thanks. Should this change be common to base sdm845.dtsi or platform specific dts? For what it's worth, we see this BT breakage on PocoF1 phone too. Regards, Amit Pundir > > [1] https://lkml.org/lkml/2020/7/27/507 > > > > > thanks > > -john > > > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation

[PATCH v4] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-05 Thread Amit Pundir
that shipped with Android-9 based release. Newer bootloader version do not support switching OFF the display panel at all. So we need a few additional smmu patches (under review) from here to boot to shell: https://github.com/pundiramit/linux/commits/beryllium-mainline Signed-off-by: Amit Pundir -

Re: [PATCH v4] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-05 Thread Amit Pundir
On Wed, 5 Aug 2020 at 16:21, Amit Pundir wrote: > > Add initial dts support for Xiaomi Poco F1 (Beryllium). > > This initial support is based on upstream Dragonboard 845c > (sdm845) device. With this dts, Beryllium boots AOSP up to > ADB shell over USB-C. > > Supported fu

Re: [PATCH v3] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-04 Thread Amit Pundir
On Tue, 4 Aug 2020 at 11:46, Bjorn Andersson wrote: > > On Sat 01 Aug 08:55 PDT 2020, Amit Pundir wrote: > > > Add initial dts support for Xiaomi Poco F1 (Beryllium). > > > > This initial support is based on upstream Dragonboard 845c > > (sdm845) device. With thi

[PATCH v3] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-01 Thread Amit Pundir
that shipped with Android-9 based release. Newer bootloader version do not support switching OFF the display panel at all. So we need a few additional smmu patches (under review) from here to boot to shell: https://github.com/pundiramit/linux/commits/beryllium-mainline Signed-off-by: Amit Pundir -

[PATCH v2] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-07-31 Thread Amit Pundir
that shipped with Android-9 based release. Newer bootloader version do not support switching OFF the display panel at all. So we need a few additional smmu patches (under review) from here to boot to shell: https://github.com/pundiramit/linux/commits/beryllium-mainline Signed-off-by: Amit Pundir -

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-31 Thread Amit Pundir
of_address: Add bus type match for pci ranges parser": OK > v5.8-rc1 + both: BROKEN > > I wanted to test the series to see if this fixes anything. If you would > prefer a different thread for this or further information, please let > me know. Hi Nathan, Here is the patch series: https://lists.linuxfoundation.org/pipermail/iommu/2020-July/047008.html https://lists.linuxfoundation.org/pipermail/iommu/2020-July/047010.html I hope it works for you, it didn't work for me. More details in this thread here: https://lists.linuxfoundation.org/pipermail/iommu/2020-July/047009.html Regards, Amit Pundir > > Cheers, > Nathan

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-24 Thread Amit Pundir
hackish) way to not apply the addressability check for dma-iommu > allocations. Thank you. The below patch worked on today's linux/master (f37e99aca03f). Regards, Amit Pundir > > diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c > index 6bc74a2d51273e..ec5e525d2b9309 100644 >

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-24 Thread Amit Pundir
On Fri, 24 Jul 2020 at 15:06, Nicolas Saenz Julienne wrote: > > Hi Amit, > > On Thu, 2020-07-23 at 10:44 +0530, Amit Pundir wrote: > > Hi Nicolas, > > > > Sorry I got stuck on other things yesterday. > > No worries :) > > > On Tue,

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-22 Thread Amit Pundir
Hi Nicolas, Sorry I got stuck on other things yesterday. On Tue, 21 Jul 2020 at 21:57, Nicolas Saenz Julienne wrote: > > On Tue, 2020-07-21 at 20:52 +0530, Amit Pundir wrote: > > [...] > > > > > > Can you try booting *without* my patch and this in the kernel &g

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-21 Thread Amit Pundir
On Tue, 21 Jul 2020 at 18:15, Nicolas Saenz Julienne wrote: > > On Tue, 2020-07-21 at 17:45 +0530, Amit Pundir wrote: > > On Tue, 21 Jul 2020 at 16:45, Nicolas Saenz Julienne > > wrote: > > > On Tue, 2020-07-21 at 14:24 +0530, Amit Pundir wrote: > > > >

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-21 Thread Amit Pundir
ate from CMA but check the > > address a try? (just because we can..) > > Yes, good idea! > > Amir, could you also test this patch[1] (having reverted the one that > casues trouble) and report on whether it boots or not? Can't boot with that patch either. Regards, A

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-21 Thread Amit Pundir
On Tue, 21 Jul 2020 at 16:45, Nicolas Saenz Julienne wrote: > > On Tue, 2020-07-21 at 14:24 +0530, Amit Pundir wrote: > > On Tue, 21 Jul 2020 at 14:09, Nicolas Saenz Julienne > > wrote: > > > Hi Amit, > > > > Hi Nicolas, > > > > > > >

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-21 Thread Amit Pundir
On Tue, 21 Jul 2020 at 14:09, Nicolas Saenz Julienne wrote: > > Hi Amit, > > On Tue, 2020-07-21 at 12:51 +0530, Amit Pundir wrote: > > On Wed, 8 Jul 2020 at 22:43, Nicolas Saenz Julienne > > wrote: > > > There is no guarantee to CMA's placement, so allocat

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-21 Thread Amit Pundir
g here? I'd be happy to help debug things. For what it's worth, I don't see this regression on other two sdm845 devices (db845c and Pixel 3) I tested on. Regards, Amit Pundir > Reported-by: Jeremy Linton > Signed-off-by: Nicolas Saenz Julienne > --- > > An more cos

[PATCH] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-06-24 Thread Amit Pundir
LZB-1 that shipped with Android-9 based release. Newer bootloader version do not support switching OFF the display panel at all. So we need a couple of additional smmu patches (under review) from here to boot to shell: https://github.com/pundiramit/linux/commits/beryllium-mainline Signed-off-by: Amit P

Re: [PATCH 4.9 00/71] 4.9.134-stable review

2018-10-17 Thread Amit Pundir
finition. It is added in 582e2b4aecda ("MIPS: GIC: Introduce asm/mips-gic.h with accessor functions"), which need to be backported too because it doesn't apply cleanly on linux-4.9.y. Regards, Amit Pundir > > Jann Horn > mm/vmstat.c: fix outdated vmstat_text >

Re: [PATCH 4.14 29/45] cgroup/cpuset: remove circular dependency deadlock

2018-10-16 Thread Amit Pundir
ernel.org/r/1504764252-29091-1-git-send-email-prs...@codeaurora.org This patch applies cleanly to 4.14.y and 4.9.y. But I'm confused if this particular patch alone is good enough for these stable kernels, since the commit message talks about some "recent cpu/hotplug refactoring" dependency(?). Regards, Amit Pundir > > thanks, > > greg k-h > > > > > -- > > Regards > > Sudip

Re: Linux 4.18-rc7

2018-08-02 Thread Amit Pundir
far with current HEAD: 6b4703768268 ("Merge branch 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm"). Thanks. Regards, Amit Pundir

Re: Linux 4.18-rc7

2018-07-30 Thread Amit Pundir
; Amit: Does adding something like (whitespace damaged, apologies): > > index a1a0025..1af6915 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -402,7 +402,8 @@ static int ashmem_mmap(struct file *file, struct > vm_area_struct *vma) > fput(asma->file); > goto out; > } > - } > + } else > + vma_set_anonymous(vma); > > if (vma->vm_file) > fput(vma->vm_file); > This ashmem change ^^ worked too. Regards, Amit Pundir > > Seem to resolve it? (Sorry, I'd test it myself, but I'm away from my > desk for the night). > thanks > -john

Re: Linux 4.18-rc7

2018-07-30 Thread Amit Pundir
On Mon, 30 Jul 2018 at 18:31, Kirill A. Shutemov wrote: > > On Mon, Jul 30, 2018 at 12:17:46PM +0530, Amit Pundir wrote: > > On Mon, 30 Jul 2018 at 03:39, Linus Torvalds > > wrote: > > > > > > So unless something odd happens, this should be the last rc for 4.

Re: Linux 4.18-rc7

2018-07-29 Thread Amit Pundir
0205f /system/lib/libandroid_runtime.so (android::AndroidRuntime::startVm(_JavaVM**, _JNIEnv**, bool)+5038) F DEBUG : #09 pc 2381 /system/lib/libandroid_runtime.so (android::AndroidRuntime::start(char const*, android::Vector const&, bool)+196) F DEBUG : #10 pc 046b /system/bin/app_process32 (main+702) Regards, Amit Pundir

[PATCH v3 4/4] NFC: fdp: Remove __func__ from dev_dbg()

2018-05-03 Thread Amit Pundir
Remove redundant __func__ parameter from dev_dgb() calls and delete empty dev_dbg() trace calls, which are redundant if function tracer is enabled. Signed-off-by: Amit Pundir Reviewed-by: Andy Shevchenko --- v3: Updated commit message. v2: Deleted empty dev_dbg() trace calls, which are

[PATCH v3 2/4] NFC: Fix possible memory corruption when handling SHDLC I-Frame commands

2018-05-03 Thread Amit Pundir
ned-off-by: Amit Pundir Reviewed-by: Andy Shevchenko --- v3..v1: Resend. No changes. net/nfc/hci/core.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c index ac8030c4bcf8..19cb2e473ea6 100644 --- a/net/nfc/hci/core.c +++ b/net/nfc/hci/core.c

[PATCH v3 1/4] NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ

2018-05-03 Thread Amit Pundir
ead from the kernel heap. cc: Stable Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir Reviewed-by: Andy Shevchenko --- v3..v1: Resend. No changes. drivers/nfc/st21nfca/dep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/st21nfca/dep.c b/dri

[PATCH v3 3/4] NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver

2018-05-03 Thread Amit Pundir
From: Suren Baghdasaryan Possible buffer overflow when reading next_read_size bytes into tmp buffer after next_read_size was extracted from a previous packet. cc: Stable Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir Reviewed-by: Andy Shevchenko --- v3: Reset next_read_size to

Re: [PATCH v2 3/3] NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver

2018-05-03 Thread Amit Pundir
On 3 May 2018 at 15:50, Andy Shevchenko wrote: > On Wed, 2018-05-02 at 23:18 +0530, Amit Pundir wrote: >> From: Suren Baghdasaryan >> >> Possible buffer overflow when reading next_read_size bytes into >> tmp buffer after next_read_size was extracted from a previous

[PATCH v2] NFC: fdp: Remove __func__ from dev_dbg()

2018-05-02 Thread Amit Pundir
Remove redundant __func__ parameter from dev_dgb() calls. v2: Deleted empty dev_dbg() trace calls, which are redundant if function tracer is enabled. Signed-off-by: Amit Pundir --- drivers/nfc/fdp/fdp.c | 18 +++--- drivers/nfc/fdp/i2c.c | 17 - 2 files changed, 7

[PATCH] NFC: fdp: Remove __func__ parameter from dev_dbg() call

2018-05-02 Thread Amit Pundir
Remove redundant __func__ parameter from dev_dgb() calls. Signed-off-by: Amit Pundir --- drivers/nfc/fdp/fdp.c | 22 +++--- drivers/nfc/fdp/i2c.c | 20 +--- 2 files changed, 20 insertions(+), 22 deletions(-) diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp

[PATCH v2 1/3] NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ

2018-05-02 Thread Amit Pundir
ead from the kernel heap. Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir --- v2: Resend. No changes. drivers/nfc/st21nfca/dep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/st21nfca/dep.c b/drivers/nfc/st21nfca/dep.c index fd08be2..3420c51 1006

[PATCH v2 2/3] NFC: Fix possible memory corruption when handling SHDLC I-Frame commands

2018-05-02 Thread Amit Pundir
From: Suren Baghdasaryan When handling SHDLC I-Frame commands "pipe" field used for indexing into an array should be checked before usage. If left unchecked it might access memory outside of the array of size NFC_HCI_MAX_PIPES(127). Signed-off-by: Suren Baghdasaryan Signed-off-by: A

[PATCH v2 3/3] NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver

2018-05-02 Thread Amit Pundir
From: Suren Baghdasaryan Possible buffer overflow when reading next_read_size bytes into tmp buffer after next_read_size was extracted from a previous packet. Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir --- v2: Remove redundant __func__ from dev_dgb(). drivers/nfc/fdp/i2c.c

[PATCH v2 0/3] Few NFC fixes from android-4.14 tree

2018-05-02 Thread Amit Pundir
c__ parameter usage in dev_dbg(), so submitting a new patch separately to clean that up. Regards, Amit Pundir [1] https://android.googlesource.com/kernel/common/+log/android-4.14 Suren Baghdasaryan (3): NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ NFC: Fix possible m

Re: [RESEND][PATCH 2/4] NFC: st21nfca: Fix memory OOB and leak issues in connectivity events handler

2018-04-23 Thread Amit Pundir
On 20 April 2018 at 22:15, Mark Greer wrote: > On Fri, Apr 20, 2018 at 03:39:46PM +0300, Andy Shevchenko wrote: >> On Wed, 2018-04-18 at 15:35 +0530, Amit Pundir wrote: >> >> > if (skb->data[transaction->aid_len + 2] != >> > -

Re: [RESEND][PATCH 2/4] NFC: st21nfca: Fix memory OOB and leak issues in connectivity events handler

2018-04-23 Thread Amit Pundir
On 20 April 2018 at 18:09, Andy Shevchenko wrote: > On Wed, 2018-04-18 at 15:35 +0530, Amit Pundir wrote: > >> if (skb->data[transaction->aid_len + 2] != >> - NFC_EVT_TRANSACTION_PARAMS_TAG) >> +

Re: [RESEND][PATCH 4/4] NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver

2018-04-23 Thread Amit Pundir
On 23 April 2018 at 14:46, Greg KH wrote: > On Wed, Apr 18, 2018 at 03:35:04PM +0530, Amit Pundir wrote: >> From: Suren Baghdasaryan >> >> Possible buffer overflow when reading next_read_size bytes into >> tmp buffer after next_read_size was extracted from a previous

[RESEND][PATCH 1/4] NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ

2018-04-18 Thread Amit Pundir
ead from the kernel heap. Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir --- drivers/nfc/st21nfca/dep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/st21nfca/dep.c b/drivers/nfc/st21nfca/dep.c index fd08be2917e6..3420c5104c94 100644 --- a/dri

[RESEND][PATCH 2/4] NFC: st21nfca: Fix memory OOB and leak issues in connectivity events handler

2018-04-18 Thread Amit Pundir
d-off-by: Amit Pundir --- drivers/nfc/st21nfca/se.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c index 4bed9e842db3..acdce231e227 100644 --- a/drivers/nfc/st21nfca/se.c +++ b/drivers/nfc/st21nfca

[RESEND][PATCH 4/4] NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver

2018-04-18 Thread Amit Pundir
From: Suren Baghdasaryan Possible buffer overflow when reading next_read_size bytes into tmp buffer after next_read_size was extracted from a previous packet. Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir --- drivers/nfc/fdp/i2c.c | 10 ++ 1 file changed, 10 insertions

[RESEND][PATCH 0/4] Few NFC fixes from android-4.14 tree

2018-04-18 Thread Amit Pundir
, Amit Pundir [1] https://android.googlesource.com/kernel/common/+log/android-4.14 Suren Baghdasaryan (4): NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ NFC: st21nfca: Fix memory OOB and leak issues in connectivity events handler NFC: Fix possible memory corruption

[RESEND][PATCH 3/4] NFC: Fix possible memory corruption when handling SHDLC I-Frame commands

2018-04-18 Thread Amit Pundir
From: Suren Baghdasaryan When handling SHDLC I-Frame commands "pipe" field used for indexing into an array should be checked before usage. If left unchecked it might access memory outside of the array of size NFC_HCI_MAX_PIPES(127). Signed-off-by: Suren Baghdasaryan Signed-off-by: A

[PATCH] Bluetooth: hci_qca: Avoid missing rampatch failure with userspace fw loader

2018-04-15 Thread Amit Pundir
Hedberg CC: Stable Signed-off-by: Amit Pundir --- drivers/bluetooth/hci_qca.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 05ec530b8a3a..330e9b29e145 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth

[PATCH] usb: f_fs: Prevent gadget unbind if it is already unbound

2018-01-08 Thread Amit Pundir
log] Signed-off-by: Amit Pundir --- drivers/usb/gadget/function/f_fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index b6cf5ab5a0a1..f9bd351637cd 100644 --- a/drivers/usb/gadget/function/f_fs.c

[RFC][PATCH 1/4] NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ

2017-12-20 Thread Amit Pundir
ead from the kernel heap. Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir --- drivers/nfc/st21nfca/dep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/st21nfca/dep.c b/drivers/nfc/st21nfca/dep.c index fd08be2917e6..3420c5104c94 100644 --- a/dri

[RFC][PATCH 3/4] NFC: Fix possible memory corruption when handling SHDLC I-Frame commands

2017-12-20 Thread Amit Pundir
From: Suren Baghdasaryan When handling SHDLC I-Frame commands "pipe" field used for indexing into an array should be checked before usage. If left unchecked it might access memory outside of the array of size NFC_HCI_MAX_PIPES(127). Signed-off-by: Suren Baghdasaryan Signed-off-by: A

[RFC][PATCH 2/4] NFC: st21nfca: Fix memory OOB and leak issues in connectivity events handler

2017-12-20 Thread Amit Pundir
d-off-by: Amit Pundir --- drivers/nfc/st21nfca/se.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c index 4bed9e842db3..acdce231e227 100644 --- a/drivers/nfc/st21nfca/se.c +++ b/drivers/nfc/st21nfca

[RFC][PATCH 4/4] NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver

2017-12-20 Thread Amit Pundir
From: Suren Baghdasaryan Possible buffer overflow when reading next_read_size bytes into tmp buffer after next_read_size was extracted from a previous packet. Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir --- drivers/nfc/fdp/i2c.c | 10 ++ 1 file changed, 10 insertions

[RFC][PATCH 0/4] Few NFC changes from experimental/android-4.14 tree

2017-12-20 Thread Amit Pundir
(removed Android-only tag and internal bug ID) and build tested for arm/arm64 defconfigs, before posting them on the mailing list as is. Really appreciate any concerns or feedback. Regards, Amit Pundir [1] https://android.googlesource.com/kernel/common/+log/experimental/android-4.14 Suren

[PATCH v2 2/2] selftests: firmware: skip unsupported custom firmware fallback tests

2017-11-08 Thread Amit Pundir
Ignore custom firmware loading and cancellation tests on older kernel releases, which do not support this feature. Fixes: 061132d2b9c9 ("test_firmware: add test custom fallback trigger") Reviewed-by: Sumit Semwal Acked-by: Luis R. Rodriguez Acked-by: Greg Kroah-Hartman Signed-of

[PATCH v2 0/2] selftests: firmware: skip testing unsupported features

2017-11-08 Thread Amit Pundir
test scripts. The proposed changes skip/ignore testing the upstream functionality missing in the older kernel releases. v2: Changed the display message to make it consistent across all the firmware test scripts. Added Fixes tag. Regards, Amit Pundir Amit Pundir (2): selftests: firmware: skip

[PATCH v2 1/2] selftests: firmware: skip unsupported async loading tests

2017-11-08 Thread Amit Pundir
Ignore async firmware loading tests on older kernel releases, which do not support this feature. Fixes: 1b1fe542b6f0 ("selftests: firmware: add empty string and async tests") Reviewed-by: Sumit Semwal Acked-by: Luis R. Rodriguez Acked-by: Greg Kroah-Hartman Signed-off-by: Amit Pund

[PATCH 2/2] selftests: firmware: skip unsupported custom firmware fallback tests

2017-11-08 Thread Amit Pundir
Ignore custom firmware loading and cancellation tests on older kernel releases, which do not support this feature. Signed-off-by: Amit Pundir --- tools/testing/selftests/firmware/fw_fallback.sh | 38 + 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/tools

[PATCH 0/2] selftests: firmware: skip testing unsupported features

2017-11-08 Thread Amit Pundir
test scripts. The proposed changes skip/ignore testing the upstream functionality missing in the older kernel releases. Regards, Amit Pundir Amit Pundir (2): selftests: firmware: skip unsupported async loading tests selftests: firmware: skip unsupported custom firmware fallback tests tools

[PATCH 1/2] selftests: firmware: skip unsupported async loading tests

2017-11-08 Thread Amit Pundir
Ignore async firmware loading tests on older kernel releases, which do not support this feature. Signed-off-by: Amit Pundir --- tools/testing/selftests/firmware/fw_filesystem.sh | 34 ++- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests

Re: [PATCH] binder: fix memory corruption in binder_transaction binder

2017-10-03 Thread Amit Pundir
mation loop. I've been bitten by such intermittent AOSP issues before. I also ran binder tests from frameworks/native/libs/binder/tests/ to be sure and found the results mostly inline with android-4.9 kernel. Sorry for all the noise. Regards, Amit Pundir > Thanks, > Martijn > > On

Re: [PATCH] binder: fix memory corruption in binder_transaction binder

2017-09-11 Thread Amit Pundir
el/linaro-android.git/log/?h=test/hikey-llct. I have already reverted this patch in hikey-llct so you have to revert that revert to reproduce this issue on hikey-llct tree. Regards, Amit Pundir > > -Todd > >> On Mon, Sep 11, 2017 at 5:18 AM, Amit Pundir wrote: >>> &g

Re: [PATCH] binder: fix memory corruption in binder_transaction binder

2017-09-11 Thread Amit Pundir
hort boot loops on 2nd and successive boots. It takes about 3-4 iterations to finally come to sane state and boot to UI. I don't see this behaviour if I revert this patch. Regards, Amit Pundir > > Signed-off-by: Xu YiPing > Signed-off-by: Todd Kjos > --- > drivers/android/bi

Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.

2017-07-30 Thread Amit Pundir
i/BT regression reported on 4.13-rc2. Tested-by: Amit Pundir > Signed-off-by: Martijn Coenen > --- > drivers/android/binder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index f7665c31feca.

Re: [PATCH 02/37] binder: use group leader instead of open thread

2017-07-27 Thread Amit Pundir
On 27 July 2017 at 18:53, Greg Kroah-Hartman wrote: > On Thu, Jul 27, 2017 at 02:38:30PM +0530, Amit Pundir wrote: >> Hi, >> >> On 25 July 2017 at 14:43, Martijn Coenen wrote: >> > Hi John, >> > >> > On Mon, Jul 24, 2017 at 11:07 PM, John Stultz

Re: [PATCH 02/37] binder: use group leader instead of open thread

2017-07-27 Thread Amit Pundir
t look right. Is there anything in the kernel log? There is a slight difference in this patch and the one that got pushed in android-4.9[1]. I cherry-picked those changes and got BT/WiFi working again on Hikey with mainline tracking (4.13-rc2) tree. Regards, Amit Pundir [1] https://

  1   2   >