Hi Martin
On 05/12/2020 22:42, Martin Blumenstingl wrote:
Hello Amjad,
On Tue, Dec 1, 2020 at 8:01 PM Amjad Ouled-Ameur
wrote:
reset_control_(de)assert() calls are called on a shared reset line when
reset_control_reset has been used. This is not allowed by the reset
framework.
Use
use of triggered_count sane in the reset
framework, use of reset_control_reset() on shared reset line should
be balanced with reset_control_rearm().
Signed-off-by: Amjad Ouled-Ameur
Reported-by: Jerome Brunet
---
changes since v1: [1]
* Moved reset_control_rearm after clk_disable_unprepare
().
Signed-off-by: Amjad Ouled-Ameur
Reported-by: Jerome Brunet
---
changes since v1: [1]
* None for this driver
IMPORTANT:
This patchset depends on this patch [2], it adds reset_control_rearm() call
to the reset framework API, it has been approved by the maintainer, and
will be applied to reset/next
of triggered_count sane in the reset
framework. Therefore, use of reset_control_reset() on shared reset line
should be balanced with reset_control_rearm().
Signed-off-by: Amjad Ouled-Ameur
Reported-by: Jerome Brunet
---
changes since v1: [1]
* Moved reset_control_rearm after clk_disable_unprepare
l.org/lkml/20201112230043.28987-1-aouledameur@baylib
re.com/
[3]: git://git.pengutronix.de/git/pza/linux.git reset/shared-retrigger
Amjad Ouled-Ameur (3):
phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use
usb: dwc3: meson-g12a: fix shared reset control use
phy: amlogic: meson8b
Hello Felipe and Kevin,
Could you please review this patchset ?
Thank you in advance.
On 13/11/2020 01:05, Amjad Ouled-Ameur wrote:
This patchset fixes a usb suspend warning seen on the libretech-cc by
using reset_control_rearm() call of the reset framework API.
This call allows a reset
driver-api/reset.rst
F:drivers/reset/
F:include/dt-bindings/reset/
F:include/linux/reset-controller.h
Thank you for the documentation, looks good to me !
Reviewed-by: Amjad Ouled-Ameur
Sincerely,
Amjad
Hi Martin,
On 14/11/2020 20:13, Martin Blumenstingl wrote:
Hi Amjad,
On Fri, Nov 13, 2020 at 1:06 AM Amjad Ouled-Ameur
wrote:
[...]
@@ -124,6 +126,7 @@ static int phy_meson_gxl_usb2_exit(struct phy *phy)
{
struct phy_meson_gxl_usb2_priv *priv = phy_get_drvdata(phy
Hi Martin,
Thank you for the review !
On 14/11/2020 20:11, Martin Blumenstingl wrote:
Hi Amjad,
On Fri, Nov 13, 2020 at 1:07 AM Amjad Ouled-Ameur
wrote:
[...]
ret = clk_prepare_enable(priv->clk_usb);
if (ret) {
dev_err(>dev, "Failed to ena
On 13/11/2020 16:04, Philipp Zabel wrote:
On Fri, 2020-11-13 at 00:00 +0100, Amjad Ouled-Ameur wrote:
The current reset framework API does not allow to release what is done by
reset_control_reset(), IOW decrement triggered_count. Add the new
reset_control_rearm() call to do so.
When
Please find in this patchset [0] a use case of the reset_control_rearm() call
on some of meson usb drivers:
[0]
https://lore.kernel.org/lkml/20201113000508.14702-1-aouledam...@baylibre.com/
On 13/11/2020 00:00, Amjad Ouled-Ameur wrote:
The current reset framework API does not allow
().
Signed-off-by: Amjad Ouled-Ameur
Reported-by: Jerome Brunet
---
Important:
Please DO NOT merge before this patch [0] is merged, it adds
reset_control_rearm() call to the reset framework API.
[0] https://lore.kernel.org/lkml/20201112230043.28987-1-aouledameur@baylib
re.com/
drivers/usb/dwc3/dwc3
use of triggered_count sane in the reset
framework, use of reset_control_reset() on shared reset line should
be balanced with reset_control_rearm().
Signed-off-by: Amjad Ouled-Ameur
Reported-by: Jerome Brunet
---
Important:
Please DO NOT merge before this patch [0] is merged, it adds
of triggered_count sane in the reset
framework. Therefore, use of reset_control_reset() on shared reset line
should be balanced with reset_control_rearm().
Signed-off-by: Amjad Ouled-Ameur
Reported-by: Jerome Brunet
---
Important:
Please DO NOT merge before this patch [0] is merged, it adds
commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared reset control
use").
Important:
Please DO NOT merge before this patch [0] is merged, it adds
reset_control_rearm() call to the reset framework API.
[0] https://lore.kernel.org/lkml/20201112230043.28987-1-aouledameur@baylib
re.com/
A
the resource
under the reset is in-use and the reset should not be done again.
reset_control_rearm() would be the way to state that the resource is
no longer used and, that from the caller's perspective, the reset can be
fired again if necessary.
Signed-off-by: Amjad Ouled-Ameur
Reported
Hi everyone,
On 09/11/2020 18:25, Philipp Zabel wrote:
On Mon, 2020-11-09 at 11:21 -0500, Jim Quinlan wrote:
On Mon, Nov 9, 2020 at 5:05 AM Philipp Zabel wrote:
Hi Jim,
On Fri, 2020-11-06 at 14:17 -0500, Jim Quinlan wrote:
Before, only control_reset() was implemented. However, the reset
Hi Philipp,
Thank you very much for the review.
Please find my comments below:
On 02/10/2020 13:14, Philipp Zabel wrote:
Hi Amjad,
Thank you for the patch, comments below:
On Thu, 2020-10-01 at 15:55 +0200, Amjad Ouled-Ameur wrote:
An update on the patch title, since we don't add an API
On 03/10/2020 01:00, Kevin Hilman wrote:
Amjad Ouled-Ameur writes:
The current reset framework API does not allow to release what is done by
reset_control_reset(), IOW decrement triggered_count. Add the new
reset_control_resettable() call to do so.
When reset_control_reset() has been called
An update on the patch title, since we don't add an API but extend it,
The title should rather be: Add a new call to the reset framework
Le jeu. 1 oct. 2020 à 15:28, Amjad Ouled-Ameur
a écrit :
>
> The current reset framework API does not allow to release what is done by
> reset_cont
warning seen on the libretech-cc
related to the shared reset line. This warning was addressed by the
previously reverted commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared
reset control use")
Signed-off-by: Amjad Ouled-Ameur
Reported-by: Jerome Brunet
---
drivers/reset/co
breaking dwc3-meson-g12a USB completely. We will address the warning
issue in another way as a 2nd step.
Signed-off-by: Amjad Ouled-Ameur
Reported-by: Jerome Brunet
---
drivers/usb/dwc3/dwc3-meson-g12a.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers
22 matches
Mail list logo
