Re: [PATCH v2] driver core: platform: Respect return code of platform_device_register_full()

2018-12-06 Thread Andy Shevchenko
On Thu, Dec 6, 2018 at 2:59 PM Greg Kroah-Hartman wrote: > > On Mon, Dec 03, 2018 at 08:21:41PM +0200, Andy Shevchenko wrote: > > The platform_device_register_full() might return an error pointer. If we > > instantiate platform device which is optional we may simplify the rout

Re: [PATCH] platform/x86: intel_ips: Remove unnecessary NULL check before debugfs_remove_recursive

2018-12-05 Thread Andy Shevchenko
y queue. > Signed-off-by: Wen Yang > CC: Darren Hart > CC: Andy Shevchenko > CC: platform-driver-...@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > drivers/platform/x86/intel_ips.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-05 Thread Andy Shevchenko
closer. > Functionality wise, it looks good to me. Thanks. -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 5, 2018 at 3:57 AM Chen Yu wrote: > On 2018/12/5 1:47, Andy Shevchenko wrote: > > On Tue, Dec 4, 2018 at 3:40 AM Chen Yu wrote: > >> On 2018/12/3 17:23, Andy Shevchenko wrote: > >>> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > > &g

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 5, 2018 at 3:47 AM Frank Lee wrote: > On Wed, Dec 5, 2018 at 1:39 AM Andy Shevchenko > wrote: > > On Tue, Dec 4, 2018 at 6:58 PM Frank Lee wrote: > > > $ git remote set-branches --add origin for-next > > > $ git br -vv > > > * for-next 651022

[PATCH v6 17/20] rtc: tegra: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Thierry Reding Cc: Jonathan Hunter Signed-off-by: Andy Shevchenko Acked-by: Thierry Reding --- drivers/rtc/rtc-tegra.c | 30 +++--- 1 file changed, 3 insertions

[PATCH v6 06/20] rtc: m48t59: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-m48t59.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-m48t59.c b/drivers/rtc/rtc-m48t59.c index

[PATCH v6 09/20] rtc: pic32: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pic32.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-pic32.c b/drivers/rtc/rtc-pic32

[PATCH v6 05/20] rtc: m41t80: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-m41t80.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index

[PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r]

2018-12-04 Thread Andy Shevchenko
ake an additional letter for different time representations - make above letter capital to reduce confusion on %ptr vs. %ptR - drop kdb patch since it's a candidate for time64_t support Andy Shevchenko (20): lib/vsprintf: Print time and date in human readable format via %pt rtc: Switch to use %ptR

[PATCH v6 07/20] rtc: mcp795: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-mcp795.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc

[PATCH v6 12/20] rtc: rk808: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rk808.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-rk808.c b/drivers/rtc/rtc

[PATCH v6 10/20] rtc: pm8xxx: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pm8xxx.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc

[PATCH v6 04/20] rtc: at91sam9: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-at91sam9.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc

[PATCH v6 11/20] rtc: puv3: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Guan Xuetao Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-puv3.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-puv3.c b

[PATCH v6 01/20] lib/vsprintf: Print time and date in human readable format via %pt

2018-12-04 Thread Andy Shevchenko
: Ingo Molnar Cc: Jason Wessel Cc: Jonathan Corbet Cc: Jonathan Hunter Cc: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" Cc: Thierry Reding Cc: Petr Mladek Signed-off-by: Andy Shevchenko --- Documentation/core-api/printk-formats.rst | 18 lib/test_printf.c

[PATCH v6 02/20] rtc: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
-off-by: Andy Shevchenko --- drivers/char/rtc.c | 7 +++ drivers/rtc/hctosys.c | 8 ++-- drivers/rtc/interface.c | 8 ++-- drivers/rtc/rtc-proc.c | 36 +--- drivers/rtc/rtc-sysfs.c | 16 ++-- 5 files changed, 18 insertions(+), 57

[PATCH v6 13/20] rtc: rx6110: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rx6110.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c

[PATCH v6 08/20] rtc: pcf50633: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pcf50633.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf50633.c b/drivers/rtc/rtc-pcf50633.c

[PATCH v6 20/20] PM: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: linux...@vger.kernel.org Acked-by: Rafael J. Wysocki Signed-off-by: Andy Shevchenko --- drivers/base/power/trace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v6 15/20] rtc: s3c: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-s3c.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c

[PATCH v6 16/20] rtc: s5m: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Bartlomiej Zolnierkiewicz Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-s5m.c | 27 ++- 1 file changed, 6 insertions(+), 21

[PATCH v6 18/20] Input: hp_sdc_rtc - Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Dmitry Torokhov Signed-off-by: Andy Shevchenko Acked-by: Dmitry Torokhov --- drivers/input/misc/hp_sdc_rtc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v6 19/20] m68k/mac: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Geert Uytterhoeven Cc: linux-m68k Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven --- arch/m68k/mac/misc.c | 8 ++-- 1 file changed, 2

[PATCH v6 14/20] rtc: rx8025: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rx8025.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc

[PATCH v6 03/20] rtc: at91rm9200: Switch to use %ptR

2018-12-04 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-at91rm9200.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Andy Shevchenko
drivers/platform/x86/intel_pmc_core.c > modified: drivers/platform/x86/intel_telemetry_debugfs.c > > no changes added to commit (use "git add" and/or "git commit -a") > Andy,I don't know why. > Is there a problem with my operation? Definitely. -- With Best Regards, Andy Shevchenko

Re: [PATCH v5 02/21] lib/vsprintf: Print time and date in human readable format via %pt

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 04, 2018 at 05:16:58PM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 4, 2018 at 5:12 PM Andy Shevchenko > wrote: > > On Tue, Dec 04, 2018 at 02:30:28PM +0100, Petr Mladek wrote: > > > On Thu 2018-11-29 12:59:40, Andy Shevchenko wrote: > > > > There ar

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 4, 2018 at 5:30 PM Frank Lee wrote: > On Tue, Dec 4, 2018 at 8:40 PM Andy Shevchenko > wrote: > > On Tue, Dec 4, 2018 at 5:59 AM Frank Lee wrote: > > > On Tue, Dec 4, 2018 at 3:09 AM Andy Shevchenko > > > wrote: > > > > On Sat

Re: [PATCH v5 02/21] lib/vsprintf: Print time and date in human readable format via %pt

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 04, 2018 at 02:30:28PM +0100, Petr Mladek wrote: > On Thu 2018-11-29 12:59:40, Andy Shevchenko wrote: > > There are users which print time and date represented by content of > > struct rtc_time in human readable format. > > > > Instead of open coding that

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 4, 2018 at 5:59 AM Frank Lee wrote: > > On Tue, Dec 4, 2018 at 3:09 AM Andy Shevchenko > wrote: > > > > On Sat, Dec 1, 2018 at 5:52 PM Yangtao Li wrote: > > > > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > I lik

Re: [PATCH v5 00/15] i2c-multi-instantiate: Adapt for INT3515 and alike

2018-12-03 Thread Andy Shevchenko
On Wed, Nov 28, 2018 at 01:45:20PM +0200, Andy Shevchenko wrote: > Currently i2c-multi-instantiate driver does not support the case > of INT3515 USB PD device, where: > > - Interrupt() is used instead of GpioInt() > - All slaves may be the same from IP point of view > - The

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
by: Takashi Iwai > > But, you don't need to rush too much. Instead, better to test your > own patches and make sure that they really work before submitting the > final version. Yes, I will wait couple of days for v10 in hope it will be tested carefully. -- With Best Regards, Andy Shevchenko

Re: [PATCH] platform/x86: intel_ips: NULL check before some freeing functions is not needed.

2018-12-03 Thread Andy Shevchenko
debugfs_remove_recursive(ips->debug_root); > + debugfs_remove_recursive(ips->debug_root); > return; > } > -- With Best Regards, Andy Shevchenko

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread Andy Shevchenko
err("pss_sample_info debugfs register failed\n"); > goto out; > @@ -968,7 +938,7 @@ static int __init telemetry_debugfs_init(void) > > f = debugfs_create_file("ioss_info", S_IFREG | S_IRUGO, > debugfs_conf->telemetry_dbg_dir, NULL, > - _ioss_ops); > + _ioss_states_fops); > if (!f) { > pr_err("ioss_sample_info debugfs register failed\n"); > goto out; > @@ -976,7 +946,7 @@ static int __init telemetry_debugfs_init(void) > > f = debugfs_create_file("soc_states", S_IFREG | S_IRUGO, > debugfs_conf->telemetry_dbg_dir, > - NULL, _socstate_ops); > + NULL, _soc_states_fops); > if (!f) { > pr_err("ioss_sample_info debugfs register failed\n"); > goto out; > -- > 2.17.0 > -- With Best Regards, Andy Shevchenko

Re: [PATCH -next] platform/x86: intel-ips: remove unnecessary checks in ips_debugfs_init

2018-12-03 Thread Andy Shevchenko
S_IRUGO, > + ips->debug_root, node, > + _debugfs_ops); > } > > return; > - > -err_cleanup: > - ips_debugfs_cleanup(ips); > - return; > } > #endif /* CONFIG_DEBUG_FS */ > > -- > 2.7.0 > > -- With Best Regards, Andy Shevchenko

[PATCH v2] driver core: platform: Respect return code of platform_device_register_full()

2018-12-03 Thread Andy Shevchenko
. To make users' life easier, check for an error pointer inside driver core. Reported-by: Pierre-Louis Bossart Signed-off-by: Andy Shevchenko --- - rebase on top of linux-next since the conflicting patch has been applied there drivers/base/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v1] driver core: platform: Respect return code of platform_device_register_full()

2018-12-03 Thread Andy Shevchenko
. To make users' life easier, check for an error pointer inside driver core. Reported-by: Pierre-Louis Bossart Signed-off-by: Andy Shevchenko --- drivers/base/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-12-03 Thread Andy Shevchenko
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"linux,code", 105}, Package () {"linux,input-type", 1}, Package () {"gpios", Package () {^BTNS, 0, 0, 1}} } }) } } After updating firmware you would need just an ACPI ID table to be added to the GPIO driver. MFD driver should not be enumerated at all. -- With Best Regards, Andy Shevchenko

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 4:22 PM Takashi Iwai wrote: > On Mon, 03 Dec 2018 15:18:54 +0100, > Andy Shevchenko wrote: > > > > On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai wrote: > > > On Fri, 30 Nov 2018 00:57:37 +0100, > > > Ayman Bagabas wrote:

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
> + }, > + .id_table = huawei_wmi_id_table, > + .probe = huawei_wmi_probe, > + .notify = huawei_wmi_notify, > +}; > + > +static int __init huawei_wmi_init(void) > +{ > + if (!(wmi_has_guid(WMI0_EVENT_GUID) || > wmi_has_guid(AMW0_EVENT_GUID))) { > + pr_debug("Compatible WMI GUID not found\n"); > + return -ENODEV; > + } > + > + return wmi_driver_register(_wmi_driver); > +} > + > +static void __exit huawei_wmi_exit(void) > +{ > + wmi_driver_unregister(_wmi_driver); > +} > + > +module_init(huawei_wmi_init); > +module_exit(huawei_wmi_exit); > + > +MODULE_ALIAS("wmi:"WMI0_EVENT_GUID); > +MODULE_ALIAS("wmi:"AMW0_EVENT_GUID); > +MODULE_AUTHOR("Ayman Bagabas "); > +MODULE_DESCRIPTION("Huawei WMI hotkeys"); > +MODULE_LICENSE("GPL v2"); > -- > 2.19.1 > -- With Best Regards, Andy Shevchenko

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
ndle(priv->handle, "\\_SB.PCI0.LPCB.EC0", > > >handle); > > + if (ACPI_FAILURE(status)) > > + return 0; -- With Best Regards, Andy Shevchenko

Re: [PATCH v9 1/2] clk: Add comment about __of_clk_get_by_name() error values

2018-12-03 Thread Andy Shevchenko
herwise looks good to me: Reviewed-by: Andy Shevchenko > + * is called even if of_property_match_string() returns an error. > + */ > static struct clk *__of_clk_get_by_name(struct device_node *np, > const char *dev_id, >

Re: [PATCH v2 06/17] Platform: OLPC: Add XO-1.75 EC driver

2018-12-02 Thread Andy Shevchenko
change the same line or > function for example. Order them with cleanups / non-functional-changes > first, followed by functional changes. > > > > > Basically all of the above is based on the review by Andy Shevchenko. > > Andy, what was your intent for Lubomir here? From

Re: [PATCH v5 02/15] platform/x86: intel_cht_int33fe: Accept errors of i2c_acpi_new_device()

2018-12-02 Thread Andy Shevchenko
On Sun, Dec 02, 2018 at 03:56:06PM +, Jonathan Cameron wrote: > On Wed, 28 Nov 2018 13:45:22 +0200 > Andy Shevchenko wrote: > > In the future i2c_acpi_new_device() will return error pointer in some cases. > > Prepare intel_cht_int33fe driver to support that. > >

Re: [PATCH v5 09/15] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper

2018-11-30 Thread Andy Shevchenko
y think about this. > > IMHO all the bus specific ACPI things should go under those buses (so > the opposite what is proposed here) but I also don't think any of this > is show stopper for the patch series under discussion ;-) Thank you guys for your input, let me fix this later, out of this series. -- With Best Regards, Andy Shevchenko

Re: [PATCH v5 09/15] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper

2018-11-30 Thread Andy Shevchenko
y might produce a linker error in some cases. > > Is this something we have to live with or which can be cleaned up > somewhen? My opinion that we might need something like drivers/acpi/acpi_i2c_lib.c drivers/acpi/acpi_gpio_lib.c etc. But better to ask Rafael and Mika what they think about this. -- With Best Regards, Andy Shevchenko

Re: [PATCH v5 09/15] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper

2018-11-30 Thread Andy Shevchenko
On Fri, Nov 30, 2018 at 10:55:33AM +0100, Wolfram Sang wrote: > On Wed, Nov 28, 2018 at 01:45:29PM +0200, Andy Shevchenko wrote: > > Besides current two users one more is coming. Definitely makes sense to > > introduce a helper. > > > > No functional change intended. &

Re: [PATCH v5 14/15] ACPI / scan: Create platform device for INT3515 ACPI nodes

2018-11-30 Thread Andy Shevchenko
On Thu, Nov 29, 2018 at 09:58:51PM +0100, Rafael J. Wysocki wrote: > On Wed, Nov 28, 2018 at 12:48 PM Andy Shevchenko > wrote: > > > > The ACPI device with INT3515 _HID is representing a complex USB PD > > hardware infrastructure which includes several I2C slave I

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Andy Shevchenko
s." > Yes i will fix your hints tomorrow and send a v6 of my patchset. > Thank you for your hints and time > It would be nice if you could fix ACPI problemmatik. I would like to see the ACPI dump for that... -- With Best Regards, Andy Shevchenko

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Andy Shevchenko
> b0: 00 00 00 00 00 00 00 00 04 00 e9 3d 00 00 00 00 > c0: 00 00 00 00 00 00 00 00 00 00 00 80 47 10 82 ff > d0: 86 ff ff 08 42 00 00 00 00 00 00 00 00 00 00 00 > e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Thanks. -- With Best Regards, Andy Shevchenko

[PATCH v5 03/21] rtc: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
-off-by: Andy Shevchenko --- drivers/char/rtc.c | 7 +++ drivers/rtc/hctosys.c | 8 ++-- drivers/rtc/interface.c | 8 ++-- drivers/rtc/rtc-proc.c | 36 +--- drivers/rtc/rtc-sysfs.c | 16 ++-- 5 files changed, 18 insertions(+), 57

[PATCH v5 04/21] rtc: at91rm9200: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-at91rm9200.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc

[PATCH v5 05/21] rtc: at91sam9: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-at91sam9.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc

[PATCH v5 08/21] rtc: mcp795: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-mcp795.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc

[PATCH v5 14/21] rtc: rx6110: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rx6110.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c

[PATCH v5 13/21] rtc: rk808: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rk808.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-rk808.c b/drivers/rtc/rtc

[PATCH v5 09/21] rtc: pcf50633: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pcf50633.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf50633.c b/drivers/rtc/rtc-pcf50633.c

[PATCH v5 12/21] rtc: puv3: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Guan Xuetao Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-puv3.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-puv3.c b

[PATCH v5 10/21] rtc: pic32: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pic32.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-pic32.c b/drivers/rtc/rtc-pic32

[PATCH v5 06/21] rtc: m41t80: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-m41t80.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index

[PATCH v5 17/21] rtc: s5m: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Bartlomiej Zolnierkiewicz Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-s5m.c | 27 ++- 1 file changed, 6 insertions(+), 21

[PATCH v5 19/21] Input: hp_sdc_rtc - Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Dmitry Torokhov Signed-off-by: Andy Shevchenko Acked-by: Dmitry Torokhov --- drivers/input/misc/hp_sdc_rtc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v5 21/21] PM: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: linux...@vger.kernel.org Acked-by: Rafael J. Wysocki Signed-off-by: Andy Shevchenko --- drivers/base/power/trace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v5 20/21] m68k/mac: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Geert Uytterhoeven Cc: linux-m68k Signed-off-by: Andy Shevchenko --- arch/m68k/mac/misc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/m68k/mac/misc.c b

[PATCH v5 15/21] rtc: rx8025: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rx8025.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc

[PATCH v5 16/21] rtc: s3c: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-s3c.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c

[PATCH v5 11/21] rtc: pm8xxx: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pm8xxx.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc

[PATCH v5 02/21] lib/vsprintf: Print time and date in human readable format via %pt

2018-11-29 Thread Andy Shevchenko
: Ingo Molnar Cc: Jason Wessel Cc: Jonathan Corbet Cc: Jonathan Hunter Cc: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" Cc: Thierry Reding Cc: Petr Mladek Signed-off-by: Andy Shevchenko --- Documentation/core-api/printk-formats.rst | 18 lib/test_printf.c

[PATCH v5 01/21] nvmem: Move nvmem_type_str array to its only user

2018-11-29 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- drivers/nvmem/core.c | 7 +++ include/linux/nvmem-provider.h | 7 --- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d9fd11033c1c..22345e65a301 100644 --- a/drivers/nvmem/core.c

[PATCH v5 18/21] rtc: tegra: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Thierry Reding Cc: Jonathan Hunter Signed-off-by: Andy Shevchenko Acked-by: Thierry Reding --- drivers/rtc/rtc-tegra.c | 30 +++--- 1 file changed, 3 insertions

[PATCH v5 07/21] rtc: m48t59: Switch to use %ptR

2018-11-29 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-m48t59.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-m48t59.c b/drivers/rtc/rtc-m48t59.c index

[PATCH v5 00/21] lib, rtc: Print rtc_time via %ptR[dt][r]

2018-11-29 Thread Andy Shevchenko
for different time representations - make above letter capital to reduce confusion on %ptr vs. %ptR - drop kdb patch since it's a candidate for time64_t support Andy Shevchenko (21): nvmem: Move nvmem_type_str array to its only user lib/vsprintf: Print time and date in human readable format via

[PATCH v4 02/21] lib/vsprintf: Print time and date in human readable format via %pt

2018-11-28 Thread Andy Shevchenko
: Ingo Molnar Cc: Jason Wessel Cc: Jonathan Corbet Cc: Jonathan Hunter Cc: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" Cc: Thierry Reding Signed-off-by: Andy Shevchenko --- Documentation/core-api/printk-formats.rst | 18 lib/test_printf.c |

[PATCH v4 04/21] rtc: at91rm9200: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-at91rm9200.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc

[PATCH v4 06/21] rtc: m41t80: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-m41t80.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index

[PATCH v4 05/21] rtc: at91sam9: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-at91sam9.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc

[PATCH v4 12/21] rtc: puv3: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Guan Xuetao Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-puv3.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-puv3.c b

[PATCH v4 08/21] rtc: mcp795: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-mcp795.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc

[PATCH v4 11/21] rtc: pm8xxx: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pm8xxx.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc

[PATCH v4 07/21] rtc: m48t59: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-m48t59.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-m48t59.c b/drivers/rtc/rtc-m48t59.c index

[PATCH v4 10/21] rtc: pic32: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pic32.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-pic32.c b/drivers/rtc/rtc-pic32

[PATCH v4 09/21] rtc: pcf50633: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-pcf50633.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf50633.c b/drivers/rtc/rtc-pcf50633.c

[PATCH v4 14/21] rtc: rx6110: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rx6110.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c

[PATCH v4 03/21] rtc: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
-off-by: Andy Shevchenko --- drivers/char/rtc.c | 7 +++ drivers/rtc/hctosys.c | 8 ++-- drivers/rtc/interface.c | 8 ++-- drivers/rtc/rtc-proc.c | 36 +--- drivers/rtc/rtc-sysfs.c | 16 ++-- 5 files changed, 18 insertions(+), 57

[PATCH v4 17/21] rtc: s5m: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Bartlomiej Zolnierkiewicz Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-s5m.c | 27 ++- 1 file changed, 6 insertions(+), 21

[PATCH v4 13/21] rtc: rk808: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rk808.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-rk808.c b/drivers/rtc/rtc

[PATCH v4 19/21] Input: hp_sdc_rtc - Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Dmitry Torokhov Signed-off-by: Andy Shevchenko Acked-by: Dmitry Torokhov --- drivers/input/misc/hp_sdc_rtc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v4 16/21] rtc: s3c: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-s3c.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c

[PATCH v4 15/21] rtc: rx8025: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-rx8025.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc

[PATCH v4 20/21] mk68/mac: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Geert Uytterhoeven Signed-off-by: Andy Shevchenko --- arch/m68k/mac/misc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac

[PATCH v4 18/21] rtc: tegra: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: Thierry Reding Cc: Jonathan Hunter Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-tegra.c | 30 +++--- 1 file changed, 3 insertions(+), 27 deletions(-) diff

[PATCH v4 01/21] nvmem: Mark nvmem_type_str array with __maybe_unused

2018-11-28 Thread Andy Shevchenko
/rtc-proc.c:15: include/linux/nvmem-provider.h:29:27: warning: ‘nvmem_type_str’ defined but not used [-Wunused-const-variable=] static const char * const nvmem_type_str[] = { ^~ Cc: Srinivas Kandagatla Signed-off-by: Andy Shevchenko --- include/linux/nvmem

[PATCH v4 00/21] lib, rtc: Print rtc_time via %ptR[dt][r]

2018-11-28 Thread Andy Shevchenko
PRINTK_PEXT_TIMEDATE - for now support only struct rtc_time - make an additional letter for different time representations - make above letter capital to reduce confusion on %ptr vs. %ptR - drop kdb patch since it's a candidate for time64_t support Andy Shevchenko (21): nvmem: Mark nvmem_type_str

[PATCH v4 21/21] PM: Switch to use %ptR

2018-11-28 Thread Andy Shevchenko
Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Cc: linux...@vger.kernel.org Acked-by: Rafael J. Wysocki Signed-off-by: Andy Shevchenko --- drivers/base/power/trace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH v3 01/20] lib/vsprintf: Print time and date in human readable format via %pt

2018-11-28 Thread Andy Shevchenko
On Tue, Nov 20, 2018 at 11:27:57PM +0100, Alexandre Belloni wrote: > Hello, > > (Please update my email address). I will follow all recommendations. New version coming soon... Thanks for review! > > On 13/11/2018 19:17:10+0200, Andy Shevchenko wrote: > > There are u

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-28 Thread Andy Shevchenko
s from the ACPI subsystem. I'm sorry if I already asked, please, remind me where dump of ACPI tables can be found? Also would be nice to have the output of `lspci -nk -vv -xxx` on such platform. -- With Best Regards, Andy Shevchenko

Re: [PATCH v5 2/2] platform: Add reset button device for PC Engines APU boards

2018-11-28 Thread Andy Shevchenko
gt; + > +static struct platform_device apu_button_dev = { > + .name = "gpio-keys-polled", > + .id = 1, > + .dev = { > + .platform_data = _buttons_data, > + } > +}; > + > +static int __init apu_init(void) > +{ > + if (!(dmi_check_system(apu2_gpio_dmi_table)) && > + !(dmi_check_system(apu3_gpio_dmi_table))) { > + return -ENODEV; > + } > + > + return platform_device_register(_button_dev); > +} > + > +static void __exit apu_exit(void) > +{ > + platform_device_unregister(_button_dev); > +} > + > +module_init(apu_init); > +module_exit(apu_exit); > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko

Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-11-28 Thread Andy Shevchenko
= platform_device_register_simple(KBUILD_MODNAME, > + -1, NULL, 0); > + if (IS_ERR(apu_gpio_pdev)) > + return PTR_ERR(apu_gpio_pdev); > + > + > + return platform_driver_register(_gpio_driver); > +} > + > +static void __exit apu_gpio_exit(void) > +{ > + platform_device_unregister(apu_gpio_pdev); > + platform_driver_unregister(_gpio_driver); > +} > + > +module_init(apu_gpio_init); > +module_exit(apu_gpio_exit); After removing unneeded checks why not to simple use module_platform_driver() ? -- With Best Regards, Andy Shevchenko

[PATCH v5 11/15] platform/x86: i2c-multi-instantiate: Distinguish IRQ resource type

2018-11-28 Thread Andy Shevchenko
As a preparatory patch switch the driver to distinguish IRQ resource type. For now, only GpioInt() is supported. Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede --- drivers/platform/x86/i2c-multi-instantiate.c | 27 +--- 1 file changed, 18 insertions(+), 9 deletions

  1   2   3   4   5   6   7   8   9   10   >