[GIT PULL] asm-generic: bugfix for asm/unistd.h

2018-12-08 Thread Arnd Bergmann
The following changes since commit 2e6e902d185027f8e3cb8b7305238f7e35d6a436: Linux 4.20-rc4 (2018-11-25 14:19:31 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git tags/asm-generic-4.20 for you to fetch changes up to

Re: linux-next: bad merge in the y2038 tree

2018-12-06 Thread Arnd Bergmann
On Thu, Dec 6, 2018 at 9:12 PM Stephen Rothwell wrote: > > Hi Arnd, > > The y2038 tree contains a merge of next-20181206. I cannot use a tree > that includes a version of linux-next. I assume that this was just a > test merge, so please remove it. Fixed now, I had pushed the wrong branch after

Re: [PATCH] asm-generic: unistd.h: fixup broken macro include.

2018-12-06 Thread Arnd Bergmann
On Thu, Dec 6, 2018 at 3:07 AM Guo Ren wrote: > > The broken macros make the glibc compile error. If there is no > __NR3264_fstat*, we should also removed related definitions. > > Signed-off-by: Guo Ren > Signed-off-by: Mao Han > Cc: Arnd Bergmann > --- Thanks for t

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Arnd Bergmann
On Wed, Dec 5, 2018 at 11:32 PM Sven Van Asbroeck wrote: > On Wed, Dec 5, 2018 at 2:17 PM Greg KH wrote: > > > > Great, then call it a 'fieldbus' class, not "fieldbus_dev' class. > > Small nit: > > Hardware connected to a fieldbus comes in two distinct flavours: > - clients (e.g. thermometer,

[PATCH] powerpc: split compat syscall table out from native table

2018-12-04 Thread Arnd Bergmann
as on the other architectures. Split out a new compat_sys_call_table symbol that contains all the compat calls, and leave the main table for the native calls, to more closely match the method we use everywhere else. Signed-off-by: Arnd Bergmann --- This is completely untested, it's just for illustration

Re: [PATCH 3/3] arm64: ftrace: add cond_resched() to func ftrace_make_(call|nop)

2018-12-03 Thread Arnd Bergmann
> > Microseconds add up because this is called in a loop for each dyn_ftrace > > record, and this triggers the softlockup watchdog unless we let it sleep > > occasionally. > > Rework so that we call cond_resched() before going into the > > ftrace_modify_code() functi

Re: [PATCH] ARM: mmp/mmp2: fix cpu_is_mmp2() on mmp2-dt

2018-12-02 Thread Arnd Bergmann
ave a better idea. > > Signed-off-by: Lubomir Rintel Acked-by: Arnd Bergmann I'd suggest adding Cc: sta...@vger.kernel.org since this fixes bugs on other platforms when CONFIG_MMP2 is enabled in a multiplatform kernel.

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-12-01 Thread Arnd Bergmann
On Sat, Dec 1, 2018 at 9:51 AM Arnd Bergmann wrote: > On Sat, Dec 1, 2018 at 12:54 AM Andy Lutomirski wrote: > > On Fri, Nov 30, 2018 at 2:10 PM Arnd Bergmann wrote: > > > On Fri, Nov 30, 2018 at 5:36 PM Andy Lutomirski wrote: > > > > On Fri, Nov 30, 2018 a

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-12-01 Thread Arnd Bergmann
On Sat, Dec 1, 2018 at 12:54 AM Andy Lutomirski wrote: > On Fri, Nov 30, 2018 at 2:10 PM Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 5:36 PM Andy Lutomirski wrote: > > > On Fri, Nov 30, 2018 at 3:41 AM Arnd Bergmann wrote: > > > > siginfo_t as it is n

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-30 Thread Arnd Bergmann
On Sat, Dec 1, 2018 at 12:12 AM Arnd Bergmann wrote: > > On Sat, Dec 1, 2018 at 12:05 AM Daniel Colascione wrote: > > On Fri, Nov 30, 2018 at 2:26 PM Christian Brauner > > wrote: > > > On December 1, 2018 11:09:58 AM GMT+13:00, Arnd Bergmann > > > wrote:

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-30 Thread Arnd Bergmann
On Sat, Dec 1, 2018 at 12:05 AM Daniel Colascione wrote: > On Fri, Nov 30, 2018 at 2:26 PM Christian Brauner > wrote: > > On December 1, 2018 11:09:58 AM GMT+13:00, Arnd Bergmann > > wrote: > > > > One humble point I would like to make is that what I care abo

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 5:36 PM Andy Lutomirski wrote: > > On Fri, Nov 30, 2018 at 3:41 AM Arnd Bergmann wrote: > > siginfo_t as it is now still has a number of other downsides, and Andy in > > particular didn't like the idea of having three new variants on x86 > > (de

Re: [RFC PATCH 3/6] char: fastrpc: Add support for context Invoke method

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 5:03 PM Srinivas Kandagatla wrote: > On 30/11/18 15:08, Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 4:01 PM Srinivas Kandagatla > > wrote: > >> Thanks Arnd for the review comments! > >> On 30/11/18 13:41, Arnd Bergmann wrote: >

Re: [RFC PATCH 3/6] char: fastrpc: Add support for context Invoke method

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 4:01 PM Srinivas Kandagatla wrote: > Thanks Arnd for the review comments! > On 30/11/18 13:41, Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 11:48 AM Srinivas Kandagatla > > wrote: > >> +static long fastrpc_device_ioctl(struct f

Re: [PATCH 4/7] remoteproc: add warning on resource table cast

2018-11-30 Thread Arnd Bergmann
On Thu, Nov 29, 2018 at 10:31 PM Loic Pallardy wrote: > > Today resource table supports only 32bit address fields. > This is not compliant with 64bit platform for which addresses > are cast in 32bit. > This patch adds warn messages when address cast is done. > > Signed-off-by: Loic Pallardy >

Re: [RFC PATCH 6/6] char: fastrpc: Add support for compat ioctls

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 2:20 PM Thierry Escande wrote: > On 30/11/2018 13:58, Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 11:48 AM Srinivas Kandagatla > > wrote: > >> > >> From: Thierry Escande > >> > >> This patch adds support for

Re: [RFC PATCH 3/6] char: fastrpc: Add support for context Invoke method

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 11:48 AM Srinivas Kandagatla wrote: > > This patch adds support to compute context invoke method > on the remote processor (DSP). > This involves setting up the functions input and output arguments, > input and output handles and mapping the dmabuf fd for the >

Re: [RFC PATCH 4/6] char: fastrpc: Add support for create remote init process

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 11:48 AM Srinivas Kandagatla wrote: > + > +static int fastrpc_init_process(struct fastrpc_user *fl, > + struct fastrpc_ioctl_init *init) > +{ > + struct fastrpc_ioctl_invoke *ioctl; > + struct fastrpc_phy_page pages[1]; > +

Re: [RFC PATCH 6/6] char: fastrpc: Add support for compat ioctls

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 11:48 AM Srinivas Kandagatla wrote: > > From: Thierry Escande > > This patch adds support for compat ioctl from 32 bits userland to > Qualcomm fastrpc driver. > > Supported ioctls in this change are INIT, INVOKE, and ALLOC/FREE_DMA. > > Most of the work is derived from

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 7:56 AM Christian Brauner wrote: > On Thu, Nov 29, 2018 at 11:13:57PM -0600, Eric W. Biederman wrote: > > Arnd Bergmann writes: > > > On Thu, Nov 29, 2018 at 9:14 PM Andy Lutomirski > > > wrote: > > > > > > It looks li

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-29 Thread Arnd Bergmann
On Thu, Nov 29, 2018 at 10:35 PM Christian Brauner wrote: > On Thu, Nov 29, 2018 at 10:02:13PM +0100, Arnd Bergmann wrote: > > On Thu, Nov 29, 2018 at 9:14 PM Andy Lutomirski wrote: > > > > Is the current procfd_signal() proposal (under whichever name) sufficient > >

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-29 Thread Arnd Bergmann
On Thu, Nov 29, 2018 at 9:14 PM Andy Lutomirski wrote: > > On Nov 29, 2018, at 11:55 AM, Christian Brauner > > wrote: > >> On Thu, Nov 29, 2018 at 11:22:58AM -0800, Andy Lutomirski wrote: > >>> On Thu, Nov 29, 2018 at 11:17 AM Christian Brauner > >>> wrote: > On November 30, 2018 5:54:18

Re: [PATCH v3 6/6] mips: generate uapi header and system call table files

2018-11-29 Thread Arnd Bergmann
On Thu, Nov 29, 2018 at 9:45 AM Firoz Khan wrote: > diff --git a/arch/mips/include/uapi/asm/Kbuild > b/arch/mips/include/uapi/asm/Kbuild > index 7a4becd..ed4bd03 100644 > --- a/arch/mips/include/uapi/asm/Kbuild > +++ b/arch/mips/include/uapi/asm/Kbuild > @@ -1,5 +1,11 @@ > # UAPI Header export

Re: [PATCH 2/2] kernel/trace: fix watchdog soft lockup

2018-11-28 Thread Arnd Bergmann
ched() gets called in the > > ftrace_replace_code loop. > > > > Co-developed-by: Arnd Bergmann > > Signed-off-by: Arnd Bergmann > > Signed-off-by: Anders Roxell > > --- > > kernel/trace/ftrace.c | 4 > > 1 file changed, 4 insertions(+) > >

Re: [PATCH v4 0/20] MMP platform fixes

2018-11-28 Thread Arnd Bergmann
On Wed, Nov 28, 2018 at 6:53 PM Lubomir Rintel wrote: > > Hi, > > this series contains contains a bunch of MMP2 platform fixes. > > Previous spins of the patch set were sent out over the course of last > three months to the MMP platform maintainers, with Arnd and >

Re: [PATCH v4 14/20] ARM: mmp/mmp2: use cpu_is_pj4() instead of cpu_is_mmp2()

2018-11-28 Thread Arnd Bergmann
On Wed, Nov 28, 2018 at 6:54 PM Lubomir Rintel wrote: > > The MMP2 platform uses the PJ4 CPU. The cpu_is_mmp2() macro is thus > actually not useful at all and moreover gives the wrong result on > MACH_MMP2_DT. > > The actual problem I aim to fix is that on a device-tree enabled system, > the

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-28 Thread Arnd Bergmann
de/linux/proc_fs.h| 12 +++ > include/linux/syscalls.h | 2 + > include/uapi/asm-generic/unistd.h | 4 +- > kernel/signal.c| 127 +++-- > 8 files changed, 151 insertions(+), 13 deletions(-) For asm-generic

Re: [PATCH v2 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable

2018-11-25 Thread Arnd Bergmann
On Sun, Nov 25, 2018 at 10:45 PM Otavio Salvador wrote: > > On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann wrote: > > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador > > wrote: > > > > > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but

Re: [PATCH v2 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable

2018-11-25 Thread Arnd Bergmann
On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador wrote: > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but > selected by the Kconfig logic. This is done in preparation to making > further changes to this defconfig cleaner. > Does this mean we no longer get the unwinder, or there

Re: [PATCH 1/6] char: lp: remove trailing whitespace

2018-11-25 Thread Arnd Bergmann
On Sun, Nov 25, 2018 at 8:47 PM Sudip Mukherjee wrote: > > Fix checkpatch error for trailing whitespace. > > Signed-off-by: Sudip Mukherjee All six patches Acked-by: Arnd Bergmann They only touch whitespace and related coding style, so that's all fine.

Re: [PATCH 11/17] soc: ti: pruss: add pruss_get()/put() API

2018-11-23 Thread Arnd Bergmann
On Thu, Nov 22, 2018 at 12:41 PM Roger Quadros wrote: > + > + if (IS_ERR_OR_NULL(rproc)) > + return ERR_PTR(-EINVAL); Any usage of IS_ERR_OR_NULL() tends to be an indication of a badly designed API. Please change this to allow only one of the two to be passed around.

Re: [PATCH] soc/tegra: refactor soc_is_tegra()

2018-11-22 Thread Arnd Bergmann
On Thu, Nov 22, 2018 at 11:45 AM Arnd Bergmann wrote: > > On Wed, Nov 21, 2018 at 3:40 PM Yangtao Li wrote: > > > > of_find_node_by_path() acquires a reference to the node returned by > > it and that reference needs to be dropped by its caller.soc_is_tegra() > > d

Re: [PATCH] soc/tegra: refactor soc_is_tegra()

2018-11-22 Thread Arnd Bergmann
On Wed, Nov 21, 2018 at 3:40 PM Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node returned by > it and that reference needs to be dropped by its caller.soc_is_tegra() > doesn't do that, so fix it.Call of_machine_is_compatible() to refactor > soc_is_tegra() whcih

Re: Cleaning up numbering for new x86 syscalls?

2018-11-21 Thread Arnd Bergmann
On Tue, Nov 20, 2018 at 4:35 PM Andy Lutomirski wrote: > > On Tue, Nov 20, 2018 at 1:03 AM Florian Weimer wrote: > > > > * Andy Lutomirski: > > > > > 5. Adjust the scripts so that we only have to wire up new syscalls > > > once. They'll have a nr above 1024, and they'll have the same nr on > >

Re: Cleaning up numbering for new x86 syscalls?

2018-11-21 Thread Arnd Bergmann
On Tue, Nov 20, 2018 at 1:25 AM Andy Lutomirski wrote: > > Hi all- > > We currently have some giant turds in the way that syscalls are > numbered. We have the x86_32 table, which is totally sane other than > some legacy multiplexers. Then we have the x86_64 table, which is, > um, demented: > >

Re: [PATCH v2 06/15] arm: dts: Add devicetree for OrangePi 2G IoT board

2018-11-21 Thread Arnd Bergmann
On Wed, Nov 21, 2018 at 4:38 AM Manivannan Sadhasivam wrote: > + aliases { > + serial0 = > + serial1 = > + serial2 = > + }; > + > + { > + status = "okay"; > + clocks = <_clk>; > +}; This is clearly mismatched here: you mark

Re: [PATCH 0/8] BCM2835 PM driver

2018-11-20 Thread Arnd Bergmann
On Tue, Nov 20, 2018 at 10:34 PM Eric Anholt wrote: > >> Eric Anholt hat am 20. November 2018 um 18:19 > >> geschrieben: > >> > >> > >> This series moves the BCM2835 WDT driver that controls a fraction of > >> the PM block out to soc/ and adds most of the rest of its > >> functionality. My

Re: BUG: unable to handle kernel NULL pointer dereference in write_port

2018-11-20 Thread Arnd Bergmann
On Tue, Nov 13, 2018 at 9:24 AM Kyungtae Kim wrote: > > We report a bug in v4.19-rc8 (4.20-rc1 as well): > > kernel config: https://kt0755.github.io/etc/config-4.19-rc2.kmsan > repro: https://kt0755.github.io/etc/repro.e3752.c > > This happens during data transition from user-supplied buffer to

Re: [PATCH 04/16] arm: dts: Add devicetree for RDA8810PL SoC

2018-11-19 Thread Arnd Bergmann
On Mon, Nov 19, 2018 at 6:11 PM Manivannan Sadhasivam wrote: > > Add initial device tree for RDA8810PL SoC from RDA Microelectronics. > + aliases { > + serial0 = > + serial1 = > + serial2 = > + }; Better move the aliases into the board

Re: [PATCH v2 3/4] powerpc: add system call table generation support

2018-11-19 Thread Arnd Bergmann
On Wed, Nov 14, 2018 at 11:04 AM Firoz Khan wrote: > Adding a new table entry consisting of: > - System call number. > - ABI. > - System call name. > - Entry point name. > - Compat entry name, if required. > > syscallhdr.sh and syscalltbl.sh will generate

Re: [PATCH v2 2/4] powerpc: move macro definition from asm/systbl.h

2018-11-19 Thread Arnd Bergmann
On Wed, Nov 14, 2018 at 11:04 AM Firoz Khan wrote: > diff --git a/arch/powerpc/include/asm/systbl.h > b/arch/powerpc/include/asm/systbl.h > index 01b5171..c4321b9 100644 > --- a/arch/powerpc/include/asm/systbl.h > +++ b/arch/powerpc/include/asm/systbl.h > @@ -76,7 +76,6 @@ >

Re: [PATCH v2 5/5] mips: generate uapi header and system call table files

2018-11-19 Thread Arnd Bergmann
On Thu, Nov 15, 2018 at 7:15 AM Firoz Khan wrote: > > System call table generation script must be run to gener- > ate unistd_64/n32/o32.h and syscall_table_32_o32/64_64/64- > _n32/64-o32.h files. This patch will have changes which > will invokes the script. > > This patch will generate

Re: [PATCH v2 4/5] mips: add system call table generation support

2018-11-19 Thread Arnd Bergmann
On Thu, Nov 15, 2018 at 7:15 AM Firoz Khan wrote: > > The system call tables are in different format in all > architecture and it will be difficult to manually add, > modify or delete the syscall table entries in the res- > pective files. To make it easy by keeping a script and > which will

Re: [PATCH v2 2/5] mips: add +1 to __NR_syscalls in uapi header

2018-11-19 Thread Arnd Bergmann
On Thu, Nov 15, 2018 at 7:15 AM Firoz Khan wrote: > > All other architectures are hold a value for __NR_syscalls will > be equal to the last system call number +1. > > But in mips architecture, __NR_syscalls hold the value equal to > total number of system exits in the architecture. One of the >

Re: [PATCH v2 1/5] mips: add __NR_syscalls along with __NR_Linux_syscalls

2018-11-19 Thread Arnd Bergmann
On Thu, Nov 15, 2018 at 7:14 AM Firoz Khan wrote: > > The 2nd option will be the recommended one. For that, I > added the __NR_syscalls macro in uapi/asm/unistd.h along > with __NR_Linux_syscalls. The macro __NR_syscalls also > added for making the name convention same across all > architecture.

Re: Official Linux system wrapper library?

2018-11-14 Thread Arnd Bergmann
On Wed, Nov 14, 2018 at 6:58 AM Carlos O'Donell wrote: > On 11/14/18 6:58 AM, Szabolcs Nagy wrote: > > an actual proposal in the thread that i think is > > worth considering is to make the linux syscall > > design process involve libc devs so the c api is > > designed together with the syscall

Re: [PATCH v2 2/9] arm64: defconfig: Drop ARM_BIG_LITTLE_CPUFREQ

2018-11-10 Thread Arnd Bergmann
On 11/10/18, Marc Gonzalez wrote: > On 10/11/2018 09:57, Arnd Bergmann wrote: > >> On Thu, Nov 8, 2018 at 10:36 AM Sudeep Holla >> wrote: >>> >>> On Wed, Nov 07, 2018 at 11:39:42PM +0100, Marc Gonzalez wrote: >>>> Commit a7314405d83c ("drop AR

Re: [PATCH v2 2/9] arm64: defconfig: Drop ARM_BIG_LITTLE_CPUFREQ

2018-11-10 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 10:36 AM Sudeep Holla wrote: > > On Wed, Nov 07, 2018 at 11:39:42PM +0100, Marc Gonzalez wrote: > > Commit a7314405d83c ("drop ARM_BIG_LITTLE_CPUFREQ support for ARM64") > > dropped ARM_BIG_LITTLE_CPUFREQ support for ARM64. > > > > Looks good, > > Acked-by: Sudeep Holla >

Re: [PATCH anybus v3 0/6] Support HMS Profinet Card over Anybus

2018-11-09 Thread Arnd Bergmann
On Fri, Nov 9, 2018 at 10:47 PM Sven Van Asbroeck wrote: > > On Fri, Nov 9, 2018 at 4:22 PM Arnd Bergmann wrote: > > > > > > As usual, it comes down to the user space interfaces I think. Designing > > a user interface is hard, most importantly because you cannot ch

Re: [PATCH anybus v3 0/6] Support HMS Profinet Card over Anybus

2018-11-09 Thread Arnd Bergmann
On Fri, Nov 9, 2018 at 5:02 PM Sven Van Asbroeck wrote: > > Arnd, Rob, Linus, > > Many thanks for your constructive feedback so far ! > > Is there anything in general about this set that would prevent it from being > mainlined? Perhaps I am trying to do too much at once, dropping a patchset >

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-09 Thread Arnd Bergmann
On Fri, Nov 9, 2018 at 5:25 PM Sven Van Asbroeck wrote: > > On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > > > +struct anybus_mbox_hdr { > > > + u16 id; > > > + u16 info; > > > + u16 cmd_num; > >

Re: [PATCH v6 5/9] dt-bindings: ARM: document marvell,ecc-enable binding

2018-11-09 Thread Arnd Bergmann
On Fri, Nov 9, 2018 at 12:48 PM Russell King - ARM Linux wrote: > > On Fri, Nov 09, 2018 at 12:40:06PM +0100, Arnd Bergmann wrote: > > On Fri, Nov 9, 2018 at 8:04 AM Chris Packham > > wrote: > > > > > > Add documentation for the marvell,ecc-enable and marvel

Re: [PATCH v6 5/9] dt-bindings: ARM: document marvell,ecc-enable binding

2018-11-09 Thread Arnd Bergmann
On Fri, Nov 9, 2018 at 8:04 AM Chris Packham wrote: > > Add documentation for the marvell,ecc-enable and marvell,ecc-disable > properties which can be used to enable/disable ECC on the Marvell aurora > cache. > > Signed-off-by: Chris Packham > --- Why do you need both enable and disable?

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-08 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 4:47 PM Sven Van Asbroeck wrote: > On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > I see this is called from the interrupt handler at the moment, which > > means you cannot call sleeping functions, but it also means that > > the timeout may

Re: [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-08 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 4:35 PM Sven Van Asbroeck wrote: > On Thu, Nov 8, 2018 at 9:20 AM Arnd Bergmann wrote: > > + struct { > > > + /* addresses IN NETWORK ORDER! */ > > > + __u32 ip_addr; > > > + __u32 sub

Re: [PATCH anybus v3 5/6] dt-bindings: anybuss-host: document devicetree binding

2018-11-08 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 3:21 PM Sven Van Asbroeck wrote: > > Hi Arnd, thank you for the review and the feedback ! > > > > > To allow describing connected devices, I think we need a #address-cells > > and #size-cells property here, with fixed values. > > I'm not sure I understand. Connected devices

Re: [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-08 Thread Arnd Bergmann
On Sun, Nov 4, 2018 at 4:55 PM wrote: > + > +struct msgEthConfig { > + u32 ip_addr, subnet_msk, gateway_addr; > +} __packed; The __packed attribute makes it slower to access but doesn't change the layout, so better drop it. > +struct msgMacAddr { > + u8 addr[6]; > +} __packed; > +

Re: [PATCH anybus v3 5/6] dt-bindings: anybuss-host: document devicetree binding

2018-11-08 Thread Arnd Bergmann
On Sun, Nov 4, 2018 at 4:55 PM wrote: > --- > .../bindings/bus/arcx,anybuss-host.txt| 36 +++ > 1 file changed, 36 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/bus/arcx,anybuss-host.txt > > diff --git

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-08 Thread Arnd Bergmann
On Sun, Nov 4, 2018 at 4:55 PM wrote: > From: Sven Van Asbroeck > +struct anybus_mbox_hdr { > + u16 id; > + u16 info; > + u16 cmd_num; > + u16 data_size; > + u16 frame_count; > + u16 frame_num; > + u16 offset_high; > + u16 offset_low; > +

Re: [PATCH anybus v3 1/6] misc: support the Arcx anybus bridge

2018-11-08 Thread Arnd Bergmann
On Tue, Nov 6, 2018 at 9:05 PM Sven Van Asbroeck wrote: > On Tue, Nov 6, 2018 at 1:31 PM Rob Herring wrote: > > > If the host is not a h/w component, but just a s/w protocol then it > > doesn't belong in DT. Perhaps it could be a library which the bridge > > driver can call into. > > Anybus

Re: [PATCH] riscv: add asm/unistd.h UAPI header

2018-11-08 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 3:10 AM Palmer Dabbelt wrote: > > On Wed, 07 Nov 2018 13:09:39 PST (-0800), Arnd Bergmann wrote: > > On Wed, Nov 7, 2018 at 7:30 PM David Abdurachmanov > > wrote: > >> On Wed, Nov 7, 2018 at 1:08 AM Palmer Dabbelt wrote: > >> >

Re: [PATCH 0/9] Regenerate arm64 defconfig for current kernel

2018-11-07 Thread Arnd Bergmann
On Wed, Nov 7, 2018 at 9:39 PM Marc Gonzalez wrote: > > Arnd, Olof, > > The following patch series was sent to a...@kernel.org > but the messages bounced because the SMTP server is > currently blacklisted. Can you get the patches through > the LAKML mailing list? Yes, that worked fine, and they

Re: [PATCH v2] ubsan: don't mark __ubsan_handle_builtin_unreachable as noreturn

2018-11-07 Thread Arnd Bergmann
On Wed, Nov 7, 2018 at 9:55 PM Andrew Morton wrote: > > On Wed, 7 Nov 2018 17:45:16 +0300 Andrey Ryabinin > wrote: > > > From: Arnd Bergmann > > --- a/lib/ubsan.c > > +++ b/lib/ubsan.c > > @@ -427,8 +427,7 @@ void __ubsan_handle_shift_out_of_bounds(struct

Re: [PATCH] riscv: add asm/unistd.h UAPI header

2018-11-07 Thread Arnd Bergmann
On Wed, Nov 7, 2018 at 7:30 PM David Abdurachmanov wrote: > On Wed, Nov 7, 2018 at 1:08 AM Palmer Dabbelt wrote: > > On Mon, 05 Nov 2018 12:56:15 PST (-0800), Arnd Bergmann wrote: > > The target is still the next glibc release (Feb 1st) for a stable RV32I ABI. > > Th

Re: [RFC 0/2] RISC-V: A proposal to add vendor-specific code

2018-11-07 Thread Arnd Bergmann
On 11/7/18, Palmer Dabbelt wrote: > On Mon, 05 Nov 2018 00:52:52 PST (-0800), Arnd Bergmann wrote: >> On 11/5/18, Christoph Hellwig wrote: >>> On Mon, Nov 05, 2018 at 02:58:07PM +0800, Vincent Chen wrote: >>>> Many thanks for kinds of comments. I q

Re: [PATCH] EDAC: skx_edac: add ACPI dependency

2018-11-06 Thread Arnd Bergmann
On Sat, Nov 3, 2018 at 12:42 AM Borislav Petkov wrote: > > On Fri, Nov 02, 2018 at 10:39:59AM -0700, Luck, Tony wrote: > > On Fri, Nov 02, 2018 at 05:10:13PM +0100, Borislav Petkov wrote: > > > On Fri, Nov 02, 2018 at 04:32:06PM +0100, Arnd Bergmann wrote: > > >

Re: [PATCH v1 4/4] xtensa: generate uapi header and syscall table header files

2018-11-06 Thread Arnd Bergmann
On Mon, Nov 5, 2018 at 10:44 PM Max Filippov wrote: > On Thu, Nov 1, 2018 at 6:57 AM Firoz Khan wrote: > > index 82c75643..b35d2e6 100644 > > --- a/arch/xtensa/include/asm/Kbuild > > +++ b/arch/xtensa/include/asm/Kbuild > > @@ -28,3 +28,4 @@ generic-y += topology.h > > generic-y +=

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-06 Thread Arnd Bergmann
On 11/5/18, Kishon Vijay Abraham I wrote: > On 05/11/18 8:46 AM, Chunyan Zhang wrote: >> >> +sdhci_switch_extdma(host, true); > > A number of devices using sdhci-omap supports ADMA. So switching to > external > DMA shouldn't be unconditional. > > IMHO sdhci.c should see if the device supports

Re: [PATCH RFC 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-06 Thread Arnd Bergmann
On 11/5/18, Chunyan Zhang wrote: > Some standard SD host controller can support both external dma > controllers as well as ADMA in which the controller acts as > DMA master. > > Currently the generic SDHCI code supports ADMA/SDMA integrated into > the host controller but does not have any support

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Andy Shevchenko wrote: > On Mon, Nov 5, 2018 at 7:19 PM Pierre-Louis Bossart > wrote: >> >> >> >>> We have this ("strange") lines over the drivers: >> >>> >> >>> config BAR >> >>> depends on FOO || FOO=n >> >>> >> >>> which guarantees that FOO will be not module when BAR is built-in.

Re: [PATCH] riscv: add asm/unistd.h UAPI header

2018-11-05 Thread Arnd Bergmann
t see: > > - __NR_riscv_flush_icache > - __NR_newfstatat > - __NR_fstat > > which are supported by riscv kernel. > > Signed-off-by: David Abdurachmanov > Cc: Arnd Bergmann > Cc: Marcin Juszkiewicz > Cc: Guenter Roeck Thanks for addressing this, your patch correctly f

Re: [PATCH] mm: fix uninitialized variable warnings

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Jan Kara wrote: > On Fri 02-11-18 16:31:06, Arnd Bergmann wrote: >> In a rare randconfig build, I got a warning about possibly uninitialized >> variables: >> >> mm/page-writeback.c: In function 'balance_dirty_pages': >> mm/page-writeback.c:1623:1

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Andy Shevchenko wrote: > On Fri, Nov 02, 2018 at 11:07:34PM +0100, Arnd Bergmann wrote: >> On 11/2/18, Andy Shevchenko wrote: >> > On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: > >> >> - depends on MFD_AXP20X_I2C && I

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Andy Shevchenko wrote: > On Sun, Nov 04, 2018 at 10:45:17AM -0600, Pierre-Louis Bossart wrote: > >> So yes indeed we have to add a select HDAC_HDA statement under the >> SKYLAKE >> config - i just don't know of any other means to say "don't build >> HDAC_HDA >> as a module when

Re: [PATCH] x86: vsmp: avoid link error with gcc -Og

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Thomas Gleixner wrote: > Arnd, > > On Fri, 2 Nov 2018, Arnd Bergmann wrote: > >> When the compiler skips optimizations for ease of debugging, >> teh vsmp_cap_cpus() function is not eliminated from the build >> with CONFIG_PCI=n: > > thanks for

Re: [RFC 0/2] RISC-V: A proposal to add vendor-specific code

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Christoph Hellwig wrote: > On Mon, Nov 05, 2018 at 09:52:52AM +0100, Arnd Bergmann wrote: >> > I fundamentally disagree with this… and think it should be the >> > contrary. >> > >> > 1. The kernel shall support no vendor specific instructions

Re: [RFC 0/2] RISC-V: A proposal to add vendor-specific code

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Christoph Hellwig wrote: > On Mon, Nov 05, 2018 at 02:58:07PM +0800, Vincent Chen wrote: >> Many thanks for kinds of comments. I quickly synthesize the comments and >> list them as below. >> 1. The kernel image shall include all vendor-specific code. > > I fundamentally disagree with

[PATCH] ASoC: Intel: mrfld: fix uninitialized variable access

2018-11-03 Thread Arnd Bergmann
ement") Signed-off-by: Arnd Bergmann --- sound/soc/intel/atom/sst/sst_loader.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst_loader.c b/sound/soc/intel/atom/sst/sst_loader.c index 27413ebae956..b8c456753f01 100644 --- a/sound/soc/inte

Re: [PATCH] copy_{to,from}_user(): fix compile-time sanity checks with gcc -Og

2018-11-03 Thread Arnd Bergmann
On 11/3/18, Changbin Du wrote: > On Fri, Nov 02, 2018 at 04:56:58PM +0100, Arnd Bergmann wrote: >> When CONFIG_CC_OPTIMIZE_FOR_DEBUGGING is set, we get countless warnings >> like >> >> In function 'check_copy_size', >> inlined from 'copy_from_user'

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Arnd Bergmann wrote: > On 11/2/18, Andy Shevchenko wrote: >> On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: >>> We still get a link failure with IOSF_MBI=m when the xpower driver >>> is built-in: >>> >>> drive

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Andy Shevchenko wrote: > On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: >> We still get a link failure with IOSF_MBI=m when the xpower driver >> is built-in: >> >> drivers/acpi/pmic/intel_pmic_xpower.o: In function >>

Re: [PATCH] ASoC: sunxi: rename SND_SUN8I_ADDA_PR_REGMAP

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Vasily Khoruzhick wrote: > On Friday, November 2, 2018 8:33:40 AM PDT Arnd Bergmann wrote: >> The newly added SND_SUN50I_CODEC_ANALOG driver selects a nonexisting >> symbol SND_SUNXI_ADDA_PR_REGMAP, which was evidently intended to replace >> SND_SUN8I_ADDA

Re: [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Pierre-Louis Bossart wrote: > > On 11/2/18 6:24 AM, Arnd Bergmann wrote: >> The skylake sound support is written to work both with or without >> CONFIG_SND_SOC_HDAC_HDA, and uses an #ifdef to decide whether it should >> link against that. However, this fails w

[PATCH] copy_{to,from}_user(): fix compile-time sanity checks with gcc -Og

2018-11-02 Thread Arnd Bergmann
to '__bad_copy_to' declared with attribute error: copy destination size is too small It seems that constant propagation doesn't work well enough to make this code reliable, so turn it off for that configuration. Cc: Changbin Du Cc: Al Viro Signed-off-by: Arnd Bergmann --- include/linux

Re: linux-next: Tree for Oct 31 (vboxguest)

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Masahiro Yamada wrote: > On Thu, Nov 1, 2018 at 11:32 PM Changbin Du wrote: >> On Thu, Nov 01, 2018 at 12:32:48PM +0900, Masahiro Yamada wrote: > > How about clang? > > For clang, -Og might be equivalent to -O1 at this moment, but I am not > sure. > > In my understanding, Clang does

[PATCH] x86: vsmp: avoid link error with gcc -Og

2018-11-02 Thread Arnd Bergmann
that will always optimize this as required. Signed-off-by: Arnd Bergmann --- arch/x86/kernel/vsmp_64.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/vsmp_64.c b/arch/x86/kernel/vsmp_64.c index 1eae5af491c2..6a2ae6964ce5 100644 --- a/arch/x86/kernel

[PATCH] ubifs: replay: fix high stack usage

2018-11-02 Thread Arnd Bergmann
the same behavior as before. Signed-off-by: Arnd Bergmann --- fs/ubifs/replay.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c index 75f961c4c044..a08c5b7030ea 100644 --- a/fs/ubifs/replay.c +++ b/fs/ubifs

[PATCH] vbox: fix link error with 'gcc -Og'

2018-11-02 Thread Arnd Bergmann
to `vbg_hgcm_call32' Another compile-time check documents better what we want and avoids the error. Acked-by: Randy Dunlap Tested-by: Randy Dunlap Signed-off-by: Arnd Bergmann --- drivers/virt/vboxguest/vboxguest_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virt

[PATCH] ASoC: sunxi: rename SND_SUN8I_ADDA_PR_REGMAP

2018-11-02 Thread Arnd Bergmann
;ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls") Signed-off-by: Arnd Bergmann --- sound/soc/sunxi/Kconfig | 4 ++-- sound/soc/sunxi/Makefile | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kco

[PATCH] mm: fix uninitialized variable warnings

2018-11-02 Thread Arnd Bergmann
sed uninitialized in this function [-Werror=maybe-uninitialized] The compiler evidently fails to notice that the usage is in dead code after 'mdtc' is set to NULL when CONFIG_CGROUP_WRITEBACK is disabled. Adding an IS_ENABLED() check makes this clear to the compiler. Signed-off-by: Arnd Bergmann --- mm/p

[PATCH] EDAC: skx_edac: add ACPI dependency

2018-11-02 Thread Arnd Bergmann
_INTEL [=y] && PCI_MMCONFIG [=y] && (ACPI_NFIT [=n] || !ACPI_NFIT [=n]) Add a corresponding dependency here. Fixes: ad6e16059d8e ("EDAC, skx_edac: Add address translation for non-volatile DIMMs") Signed-off-by: Arnd Bergmann --- drivers/edac/Kconfig | 2 +- 1 file changed

[PATCH] arm64: hide unused swiotlb functions

2018-11-02 Thread Arnd Bergmann
: 886643b76632 ("arm64: use the generic swiotlb_dma_ops") Signed-off-by: Arnd Bergmann --- arch/arm64/mm/dma-mapping.c | 58 ++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 3a

[PATCH] [v2] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Arnd Bergmann
out of an #ifdef. The same code is used in three drivers, all of which I'm changing the same way. Fixes: 2ed1a8e0ce8d ("ASoC: wm9712: add ac97 new bus support") Signed-off-by: Arnd Bergmann --- v2: fix a missing check that Charles pointed out --- include/sound/soc.h | 2 +- sound/

Re: [PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Charles Keepax wrote: > On Fri, Nov 02, 2018 at 12:23:08PM +0100, Arnd Bergmann wrote: >> static void wm9713_soc_remove(struct snd_soc_component *component) >> { >> -#ifdef CONFIG_SND_SOC_AC97_BUS >> struct wm9713_priv *wm9713 = snd_soc_comp

[PATCH] HID: asus: fix build warning wiht CONFIG_ASUS_WMI disabled

2018-11-02 Thread Arnd Bergmann
; ^ With an extra IS_ENABLED() check, the warning goes away. Fixes: 3b692c55e58d ("HID: asus: only support backlight when it's not driven by WMI") Signed-off-by: Arnd Bergmann --- drivers/hid/hid-asus.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drive

[PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-02 Thread Arnd Bergmann
-off-by: Arnd Bergmann --- sound/soc/intel/Kconfig | 1 + sound/soc/intel/skylake/skl.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index 0caa1f4eb94d..c21ce7624af1 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc

[PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Arnd Bergmann
out of an #ifdef. The same code is used in three drivers, all of which I'm changing the same way. Fixes: 2ed1a8e0ce8d ("ASoC: wm9712: add ac97 new bus support") Signed-off-by: Arnd Bergmann --- include/sound/soc.h | 2 +- sound/soc/codecs/wm9705.c | 10 -- sound/soc/codec

[PATCH] ASoC: pxa: change ac97 dependencies

2018-11-02 Thread Arnd Bergmann
one of the reset functions and have each driver link to exactly the old or the compat code, that would also work, but I could not find if that's possible. Fixes: bec5ecdf41d4 ("ASoC: pxa: avoid AC97_BUS build warning") Signed-off-by: Arnd Bergmann --- sound/soc/pxa/Kconfig | 16 -

[PATCH] ubifs: auth: add CONFIG_KEYS dependency

2018-11-02 Thread Arnd Bergmann
-declaration] keyring_key = request_key(_type_logon, c->auth_key_name, NULL); Fixes: d8a22773a12c ("ubifs: Enable authentication support") Signed-off-by: Arnd Bergmann --- fs/ubifs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig index

[PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Arnd Bergmann
): undefined reference to `iosf_mbi_unblock_punit_i2c_access' This makes the dependency stronger, so we can only build when IOSF_MBI is built-in. Fixes: 6a9b593d4b6f ("ACPI / PMIC: xpower: Add depends on IOSF_MBI to Kconfig entry") Signed-off-by: Arnd Bergmann --- drivers/acpi/Kconfig | 2

  1   2   3   4   5   6   7   8   9   10   >