Re: [RFC PATCH bpf-next] bpf: change syscall_nr type to int in struct syscall_tp_t

On Thu, Oct 12, 2023 at 04:32:51PM -0700, Andrii Nakryiko wrote: > On Thu, Oct 12, 2023 at 6:43 AM Steven Rostedt wrote: > > > > On Thu, 12 Oct 2023 13:45:50 +0200 > > Artem Savkov wrote: > > > > > linux-rt-devel tree contains a patch (b1773eac3f29c ("sch

[PATCH bpf-next] bpf: change syscall_nr type to int in struct syscall_tp_t

call_trace_(enter|exit) and changing the tests to use these structs to dereference context. Signed-off-by: Artem Savkov Acked-by: Steven Rostedt (Google) --- kernel/trace/trace_syscalls.c| 4 ++-- tools/testing/selftests/bpf/progs/profiler.inc.h | 2 +- tools/testing/selftests/bpf/pr

[RFC PATCH bpf-next] bpf: change syscall_nr type to int in struct syscall_tp_t

call_trace_(enter|exit) and changing the tests to use these structs to dereference context. Signed-off-by: Artem Savkov --- kernel/trace/trace_syscalls.c| 4 ++-- tools/testing/selftests/bpf/progs/profiler.inc.h | 2 +- tools/testing/selftests/bpf/progs/test_vmlinux.c | 4 ++-- 3 files

Re: [RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

On Wed, Oct 04, 2023 at 02:55:47PM +0200, Artem Savkov wrote: > On Tue, Oct 03, 2023 at 09:38:44PM -0400, Steven Rostedt wrote: > > On Mon, 2 Oct 2023 15:52:42 +0200 > > Artem Savkov wrote: > > > > > linux-rt-devel tree contains a patch that adds an extra memb

Re: [RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

On Tue, Oct 03, 2023 at 09:38:44PM -0400, Steven Rostedt wrote: > On Mon, 2 Oct 2023 15:52:42 +0200 > Artem Savkov wrote: > > > linux-rt-devel tree contains a patch that adds an extra member to struct > > trace_entry. This causes the offset of args field in struct > >

Re: [RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

On Tue, Oct 03, 2023 at 03:11:15PM -0700, Andrii Nakryiko wrote: > On Mon, Oct 2, 2023 at 6:53 AM Artem Savkov wrote: > > > > linux-rt-devel tree contains a patch that adds an extra member to struct > > can you please point to the patch itself that makes that change? Of

[RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

CES; 10493 } This patch changes the type of nr member in syscall_trace_* structs to be long so that "args" offset is equal to that in struct trace_event_raw_sys_enter. Signed-off-by: Artem Savkov --- kernel/trace/trace.h | 4 ++-- kernel/trace/trace_syscalls.c | 7 ++

Re: [PATCH] kbuild: add extra-y to targets-for-modules

On Thu, Dec 17, 2020 at 05:26:07PM +0900, Masahiro Yamada wrote: > On Thu, Dec 17, 2020 at 8:04 AM Joe Lawrence wrote: > > > > On 12/16/20 1:14 AM, Masahiro Yamada wrote: > > > On Tue, Dec 8, 2020 at 11:31 PM Artem Savkov > > > wrote: > > >> > >

Re: [PATCH] kbuild: add extra-y to targets-for-modules

t; 'targets-for-modules' fails because kpatch.lds isn't there. > > > > > > Heh, you rely on the targets built from left to right, > > and you have never thought Make supports the parallel option -j. > > You're right. I missed that. > > > > > > > Yo

Re: [PATCH] pty: do tty_flip_buffer_push without port->lock in pty_write

Hello Sergey, On Fri, Sep 04, 2020 at 04:43:33PM +0900, Sergey Senozhatsky wrote: > On (20/09/01 14:01), Artem Savkov wrote: > [..] > > It looks like the commit was aimed to protect tty_insert_flip_string and > > there is no need for tty_flip_buffer_push to

[PATCH v2] pty: do tty_flip_buffer_push without port->lock in pty_write

t;tty: Fix data race in tty_insert_flip_string_fixed_flag") Signed-off-by: Artem Savkov Acked-by: Jiri Slaby --- v2: trimmed stack traces in commit message. drivers/tty/pty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c index 0009

[PATCH] pty: do tty_flip_buffer_push without port->lock in pty_write

15: 0002 It looks like the commit was aimed to protect tty_insert_flip_string and there is no need for tty_flip_buffer_push to be under this lock. Fixes: b6da31b2c07c ("tty: Fix data race in tty_insert_flip_string_fixed_flag") Signed-off-by: Artem Savkov --- drivers/tty/pty.

[tip:x86/build] x86/tools/relocs: Fix big section header tables

Commit-ID: f36e7495dd3990d6848e6d6703c78f1f17a97538 Gitweb: https://git.kernel.org/tip/f36e7495dd3990d6848e6d6703c78f1f17a97538 Author: Artem Savkov AuthorDate: Thu, 29 Nov 2018 16:56:15 +0100 Committer: Ingo Molnar CommitDate: Fri, 19 Apr 2019 20:54:07 +0200 x86/tools/relocs: Fix big

Re: [PATCH v3 2/9] kbuild: Support for Symbols.list creation

On Wed, Apr 10, 2019 at 11:50:51AM -0400, Joe Lawrence wrote: > -clean: archclean vmlinuxclean > +klpclean: > + $(Q) rm -f $(objtree)/Symbols.list nit: $(SLIST) can be used here. > +clean: archclean vmlinuxclean klpclean > > # mrproper - Delete all generated files, including .config > #

Re: mm: race in put_and_wait_on_page_locked()

On Mon, Feb 04, 2019 at 12:42:50PM -0800, Hugh Dickins wrote: > On Mon, 4 Feb 2019, Artem Savkov wrote: > > > Hi Hugh, > > > > Your recent patch 9a1ea439b16b "mm: put_and_wait_on_page_locked() while > > page is migrated" seems to have introduced a race

mm: race in put_and_wait_on_page_locked()

Hi Hugh, Your recent patch 9a1ea439b16b "mm: put_and_wait_on_page_locked() while page is migrated" seems to have introduced a race into page migration process. I have a host that eagerly reproduces the following BUG under stress: [ 302.847402] page:f0021700 count:0 mapcount:0

[PATCH v2] x86/tools/relocs: fix big section header tables

of e_shstrndx. This case is easily reproducible with KCFLAGS="-ffunction-sections", bzImage build fails with "String table index out of bounds" error. Signed-off-by: Artem Savkov --- arch/x86/tools/relocs.c | 58 + 1 file changed, 41 inserti

[PATCH v2] x86/tools/relocs: fix big section header tables

of e_shstrndx. This case is easily reproducible with KCFLAGS="-ffunction-sections", bzImage build fails with "String table index out of bounds" error. Signed-off-by: Artem Savkov --- arch/x86/tools/relocs.c | 58 + 1 file changed, 41 inserti

Re: [PATCH] x86/tools/relocs: fix big section header tables

On Thu, Nov 29, 2018 at 08:23:12AM -0600, Josh Poimboeuf wrote: > On Thu, Nov 29, 2018 at 02:51:33PM +0100, Artem Savkov wrote: > > In case when the number of entries in the section header table is larger > > then or equal to SHN_LORESERVE the size of the table is held in the sh_

Re: [PATCH] x86/tools/relocs: fix big section header tables

On Thu, Nov 29, 2018 at 08:23:12AM -0600, Josh Poimboeuf wrote: > On Thu, Nov 29, 2018 at 02:51:33PM +0100, Artem Savkov wrote: > > In case when the number of entries in the section header table is larger > > then or equal to SHN_LORESERVE the size of the table is held in the sh_

[PATCH] x86/tools/relocs: fix big section header tables

of e_shstrndx. This case is easily reproducible with KCFLAGS="-ffunction-sections", bzImage build fails with "String table index out of bounds" error. Signed-off-by: Artem Savkov --- arch/x86/tools/relocs.c | 58 + 1 file changed, 41 inserti

[PATCH] x86/tools/relocs: fix big section header tables

of e_shstrndx. This case is easily reproducible with KCFLAGS="-ffunction-sections", bzImage build fails with "String table index out of bounds" error. Signed-off-by: Artem Savkov --- arch/x86/tools/relocs.c | 58 + 1 file changed, 41 inserti

[tip:core/urgent] objtool: Fix segfault in .cold detection with -ffunction-sections

Commit-ID: 22566c1603030f0a036ad564634b064ad1a55db2 Gitweb: https://git.kernel.org/tip/22566c1603030f0a036ad564634b064ad1a55db2 Author: Artem Savkov AuthorDate: Tue, 20 Nov 2018 11:52:16 -0600 Committer: Ingo Molnar CommitDate: Tue, 20 Nov 2018 18:59:00 +0100 objtool: Fix segfault

[tip:core/urgent] objtool: Fix segfault in .cold detection with -ffunction-sections

Commit-ID: 22566c1603030f0a036ad564634b064ad1a55db2 Gitweb: https://git.kernel.org/tip/22566c1603030f0a036ad564634b064ad1a55db2 Author: Artem Savkov AuthorDate: Tue, 20 Nov 2018 11:52:16 -0600 Committer: Ingo Molnar CommitDate: Tue, 20 Nov 2018 18:59:00 +0100 objtool: Fix segfault

[tip:core/urgent] objtool: Fix double-free in .cold detection error path

Commit-ID: 0b9301fb632f7111a3293a30cc5b20f1b82ed08d Gitweb: https://git.kernel.org/tip/0b9301fb632f7111a3293a30cc5b20f1b82ed08d Author: Artem Savkov AuthorDate: Tue, 20 Nov 2018 11:52:15 -0600 Committer: Ingo Molnar CommitDate: Tue, 20 Nov 2018 18:59:00 +0100 objtool: Fix double-free

[tip:core/urgent] objtool: Fix double-free in .cold detection error path

Commit-ID: 0b9301fb632f7111a3293a30cc5b20f1b82ed08d Gitweb: https://git.kernel.org/tip/0b9301fb632f7111a3293a30cc5b20f1b82ed08d Author: Artem Savkov AuthorDate: Tue, 20 Nov 2018 11:52:15 -0600 Committer: Ingo Molnar CommitDate: Tue, 20 Nov 2018 18:59:00 +0100 objtool: Fix double-free

[PATCH v4 2/2] objtool: fix .cold functions parent symbols search

in place. Fixes: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions") Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index e7a7ac40e045..b8f3cca8e58b

[PATCH v4 0/2] objtool: read_symbols() fixes

The series started with 'parent symbol search' patch, but I found another issue in read_symbols() while testing the failure-path. Artem Savkov (2): objtool: fix failed cold symbol doublefree objtool: fix .cold functions parent symbols search tools/objtool/elf.c | 19 +++ 1

[PATCH v4 1/2] objtool: fix failed cold symbol doublefree

(). Fixes: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions") Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..e7a7ac40e045 100644 --- a/tools/objtool/elf.c

[PATCH v4 1/2] objtool: fix failed cold symbol doublefree

(). Fixes: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions") Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..e7a7ac40e045 100644 --- a/tools/objtool/elf.c

[PATCH v4 2/2] objtool: fix .cold functions parent symbols search

in place. Fixes: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions") Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index e7a7ac40e045..b8f3cca8e58b

[PATCH v4 0/2] objtool: read_symbols() fixes

The series started with 'parent symbol search' patch, but I found another issue in read_symbols() while testing the failure-path. Artem Savkov (2): objtool: fix failed cold symbol doublefree objtool: fix .cold functions parent symbols search tools/objtool/elf.c | 19 +++ 1

[PATCH v3 2/2] objtool: fix .cold functions parent symbols search

in place. Fixes: 13810435b9a7 "objtool: Support GCC 8's cold subfunctions" Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 3decd43477df..15d9acfb2c97 100644

[PATCH v3 1/2] objtool: fix failed cold symbol doublefree

ons" Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..3decd43477df 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -312,7 +312,7 @@ static int rea

[PATCH v3 1/2] objtool: fix failed cold symbol doublefree

ons" Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..3decd43477df 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -312,7 +312,7 @@ static int rea

[PATCH v3 2/2] objtool: fix .cold functions parent symbols search

in place. Fixes: 13810435b9a7 "objtool: Support GCC 8's cold subfunctions" Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 3decd43477df..15d9acfb2c97 100644

[PATCH v3 0/2] objtool: read_symbols() fixes

The series started with 'parent symbol search' patch, but I found another issue in read_symbols() while testing the failure-path. Artem Savkov (2): objtool: fix failed cold symbol doublefree objtool: fix .cold functions parent symbols search tools/objtool/elf.c | 22

[PATCH v3 0/2] objtool: read_symbols() fixes

The series started with 'parent symbol search' patch, but I found another issue in read_symbols() while testing the failure-path. Artem Savkov (2): objtool: fix failed cold symbol doublefree objtool: fix .cold functions parent symbols search tools/objtool/elf.c | 22

Re: [PATCH v2] objtool: fix .cold. functions parent symbols search

On Fri, Nov 09, 2018 at 11:23:09AM -0600, Josh Poimboeuf wrote: > On Wed, Nov 07, 2018 at 10:45:15PM +0100, Artem Savkov wrote: > > Because find_symbol_by_name() traverses the same lists as read_symbols() > > changing sym->name in place without copying it

Re: [PATCH v2] objtool: fix .cold. functions parent symbols search

On Fri, Nov 09, 2018 at 11:23:09AM -0600, Josh Poimboeuf wrote: > On Wed, Nov 07, 2018 at 10:45:15PM +0100, Artem Savkov wrote: > > Because find_symbol_by_name() traverses the same lists as read_symbols() > > changing sym->name in place without copying it

[PATCH v2] objtool: fix .cold. functions parent symbols search

ace. Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..781c8afb29b9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -298,6 +298,7 @@ static int rea

[PATCH v2] objtool: fix .cold. functions parent symbols search

ace. Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..781c8afb29b9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -298,6 +298,7 @@ static int rea

Re: [PATCH] objtool: fix .cold. functions parent symbols search

On Wed, Nov 07, 2018 at 11:08:56AM -0600, Josh Poimboeuf wrote: > On Wed, Nov 07, 2018 at 03:05:59PM +0100, Artem Savkov wrote: > > The way it is currently done it is possible for read_symbols() to find the > > same symbol as parent for ".cold" functions. >

Re: [PATCH] objtool: fix .cold. functions parent symbols search

On Wed, Nov 07, 2018 at 11:08:56AM -0600, Josh Poimboeuf wrote: > On Wed, Nov 07, 2018 at 03:05:59PM +0100, Artem Savkov wrote: > > The way it is currently done it is possible for read_symbols() to find the > > same symbol as parent for ".cold" functions. >

[PATCH] objtool: fix .cold. functions parent symbols search

t in place. Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..781c8afb29b9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -298,6 +298,7 @@

[PATCH] objtool: fix .cold. functions parent symbols search

t in place. Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..781c8afb29b9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -298,6 +298,7 @@

[PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure

every probe to be disabled. Signed-off-by: Artem Savkov --- kernel/trace/trace_kprobe.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 21f718472942..27ace4513c43 100644 --- a/kernel/trace

[PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure

every probe to be disabled. Signed-off-by: Artem Savkov --- kernel/trace/trace_kprobe.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 21f718472942..27ace4513c43 100644 --- a/kernel/trace

[PATCH] kprobes: fix trace_probe flags in enable_trace_kprobe

every probe to be disabled. Signed-off-by: Artem Savkov --- kernel/trace/trace_kprobe.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 21f718472942..fb887ced5056 100644 --- a/kernel/trace

[PATCH] kprobes: fix trace_probe flags in enable_trace_kprobe

every probe to be disabled. Signed-off-by: Artem Savkov --- kernel/trace/trace_kprobe.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 21f718472942..fb887ced5056 100644 --- a/kernel/trace

Re: [PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

On Wed, Feb 07, 2018 at 10:56:59AM +0100, Corentin Labbe wrote: > On Tue, Feb 06, 2018 at 10:20:21PM +0100, Artem Savkov wrote: > > According to crypto/rng.h generate function should return 0 on success > > and < 0 on error. > > > > Fixes: b8ae5c7387ad ("cryp

Re: [PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

On Wed, Feb 07, 2018 at 10:56:59AM +0100, Corentin Labbe wrote: > On Tue, Feb 06, 2018 at 10:20:21PM +0100, Artem Savkov wrote: > > According to crypto/rng.h generate function should return 0 on success > > and < 0 on error. > > > > Fixes: b8ae5c7387ad ("cryp

[PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

According to crypto/rng.h generate function should return 0 on success and < 0 on error. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov <artem.sav...@gmail.com> --- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 2 +-

[PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

According to crypto/rng.h generate function should return 0 on success and < 0 on error. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov --- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 2 +- 1 file changed, 1 insertion(+

[PATCH 2/2] sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate

Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning. Disabling softirqs to fix this. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by:

[PATCH 2/2] sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate

Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning. Disabling softirqs to fix this. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savk

[PATCH 0/2] sun4i_ss_prng fixes

IPSec hasn't been working on my a10 board since 4.14 and it turned out to be caused by sun4i_ss_rng driver. Artem Savkov (2): sun4i_ss_prng: fix return value of sun4i_ss_prng_generate sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 6

[PATCH 0/2] sun4i_ss_prng fixes

IPSec hasn't been working on my a10 board since 4.14 and it turned out to be caused by sun4i_ss_rng driver. Artem Savkov (2): sun4i_ss_prng: fix return value of sun4i_ss_prng_generate sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 6

Re: [PATCH] xfrm: init skb_head lock for transport-mode packets

On Thu, Jan 04, 2018 at 10:01:32PM +1100, Herbert Xu wrote: > On Thu, Jan 04, 2018 at 11:36:28AM +0100, Artem Savkov wrote: > > Commit acf568ee859f "xfrm: Reinject transport-mode packets through tasklet" > > adds an sk_buff_head queue, but never initializes trans->q

Re: [PATCH] xfrm: init skb_head lock for transport-mode packets

On Thu, Jan 04, 2018 at 10:01:32PM +1100, Herbert Xu wrote: > On Thu, Jan 04, 2018 at 11:36:28AM +0100, Artem Savkov wrote: > > Commit acf568ee859f "xfrm: Reinject transport-mode packets through tasklet" > > adds an sk_buff_head queue, but never initializes trans->q

[PATCH] xfrm: init skb_head lock for transport-mode packets

f __skb_queue_head_init() to properly initialize said lock. Signed-off-by: Artem Savkov <asav...@redhat.com> --- net/xfrm/xfrm_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c index 26b10eb7a206..d5389b9dbbb9 100644 --- a/ne

[PATCH] xfrm: init skb_head lock for transport-mode packets

f __skb_queue_head_init() to properly initialize said lock. Signed-off-by: Artem Savkov --- net/xfrm/xfrm_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c index 26b10eb7a206..d5389b9dbbb9 100644 --- a/net/xfrm/xfrm_input.c +++

[PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock

c14a8 xfrm: add xdst pcpu cache Signed-off-by: Artem Savkov <asav...@redhat.com> --- net/xfrm/xfrm_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 0dab1cd79ce4..12213477cd3a 100644 --- a/net/xfrm/xfrm_state.c +

[PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock

c14a8 xfrm: add xdst pcpu cache Signed-off-by: Artem Savkov --- net/xfrm/xfrm_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 0dab1cd79ce4..12213477cd3a 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.

[PATCH v3] ebtables: fix race condition in frame_filter_net_init()

-by: Artem Savkov <asav...@redhat.com> --- include/linux/netfilter_bridge/ebtables.h | 7 --- net/bridge/netfilter/ebtable_broute.c | 4 ++-- net/bridge/netfilter/ebtable_filter.c | 4 ++-- net/bridge/netfilter/ebtable_nat.c| 4 ++-- net/bridge/netfilter/ebta

[PATCH v3] ebtables: fix race condition in frame_filter_net_init()

-by: Artem Savkov --- include/linux/netfilter_bridge/ebtables.h | 7 --- net/bridge/netfilter/ebtable_broute.c | 4 ++-- net/bridge/netfilter/ebtable_filter.c | 4 ++-- net/bridge/netfilter/ebtable_nat.c| 4 ++-- net/bridge/netfilter/ebtables.c | 17

[PATCH v2] ebtables: fix race condition in frame_filter_net_init()

It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ebtables: remove nf_hook_register usage Signed-off-by: Artem Savkov <asav...@redhat.com> --- include

[PATCH v2] ebtables: fix race condition in frame_filter_net_init()

It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ebtables: remove nf_hook_register usage Signed-off-by: Artem Savkov --- include/linux/netfilter_bridge

Re: [PATCH] ebtables: fix race condition in frame_filter_net_init()

On Tue, Sep 26, 2017 at 02:42:11PM +0200, Florian Westphal wrote: > Artem Savkov <asav...@redhat.com> wrote: > > It is possible for ebt_in_hook to be triggered before ebt_table is assigned > > resulting in a NULL-pointer dereference. Make sure hooks are > > registered a

Re: [PATCH] ebtables: fix race condition in frame_filter_net_init()

On Tue, Sep 26, 2017 at 02:42:11PM +0200, Florian Westphal wrote: > Artem Savkov wrote: > > It is possible for ebt_in_hook to be triggered before ebt_table is assigned > > resulting in a NULL-pointer dereference. Make sure hooks are > > registered as the last ste

[PATCH] ebtables: fix race condition in frame_filter_net_init()

It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ebtables: remove nf_hook_register usage Signed-off-by: Artem Savkov <asav...@redhat.com> --- include

[PATCH] ebtables: fix race condition in frame_filter_net_init()

It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ebtables: remove nf_hook_register usage Signed-off-by: Artem Savkov --- include/linux/netfilter_bridge

Re: MADV_FREE is broken

On Wed, Sep 20, 2017 at 03:37:33PM -0700, Shaohua Li wrote: > On Wed, Sep 20, 2017 at 11:01:47AM +0200, Artem Savkov wrote: > > Hi All, > > > > We recently started noticing madvise09[1] test from ltp failing strangely. > > The > > test does the followi

Re: MADV_FREE is broken

On Wed, Sep 20, 2017 at 03:37:33PM -0700, Shaohua Li wrote: > On Wed, Sep 20, 2017 at 11:01:47AM +0200, Artem Savkov wrote: > > Hi All, > > > > We recently started noticing madvise09[1] test from ltp failing strangely. > > The > > test does the followi

MADV_FREE is broken

Hi All, We recently started noticing madvise09[1] test from ltp failing strangely. The test does the following: maps 32 pages, sets MADV_FREE for the range it got, dirties 2 of the pages, creates memory pressure and check that nondirty pages are free. The test hanged while accessing the last 4

MADV_FREE is broken

Hi All, We recently started noticing madvise09[1] test from ltp failing strangely. The test does the following: maps 32 pages, sets MADV_FREE for the range it got, dirties 2 of the pages, creates memory pressure and check that nondirty pages are free. The test hanged while accessing the last 4

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

On Thu, Aug 31, 2017 at 02:09:51PM +0200, Michal Hocko wrote: > On Thu 31-08-17 13:10:06, Artem Savkov wrote: > > Hi Michal, > > > > On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > > > The previous patch is insufficient. drain_all_stock can still race

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

On Thu, Aug 31, 2017 at 02:09:51PM +0200, Michal Hocko wrote: > On Thu 31-08-17 13:10:06, Artem Savkov wrote: > > Hi Michal, > > > > On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > > > The previous patch is insufficient. drain_all_stock can still race

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

Hi Michal, On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > The previous patch is insufficient. drain_all_stock can still race with > the memory offline callback and the underlying memcg disappear. So we > need to be more careful and pin the css on the memcg. This patch >

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

Hi Michal, On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > The previous patch is insufficient. drain_all_stock can still race with > the memory offline callback and the underlying memcg disappear. So we > need to be more careful and pin the css on the memcg. This patch >

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

On Wed, Aug 16, 2017 at 03:39:14PM +0200, Laurent Dufour wrote: > On 15/08/2017 21:01, Paul E. McKenney wrote: > > On Mon, Aug 07, 2017 at 04:09:47PM +0200, Artem Savkov wrote: > >> Hello, > >> > >> After commit fc8dffd "cpu/hotplug: Convert hotplug lo

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

On Wed, Aug 16, 2017 at 03:39:14PM +0200, Laurent Dufour wrote: > On 15/08/2017 21:01, Paul E. McKenney wrote: > > On Mon, Aug 07, 2017 at 04:09:47PM +0200, Artem Savkov wrote: > >> Hello, > >> > >> After commit fc8dffd "cpu/hotplug: Convert hotplug lo

[PATCH v2] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

is a NULL-pointer dereference panic during boot on some hosts. Signed-off-by: Artem Savkov <asav...@redhat.com> --- drivers/iommu/arm-smmu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index b97188a..2d80fa8 100644 --- a/d

[PATCH v2] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

is a NULL-pointer dereference panic during boot on some hosts. Signed-off-by: Artem Savkov --- drivers/iommu/arm-smmu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index b97188a..2d80fa8 100644 --- a/drivers/iommu/arm-smmu.c +++

[PATCH] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

is a NULL-pointer dereference panic during boot on some hosts. Signed-off-by: Artem Savkov <asav...@redhat.com> --- drivers/iommu/arm-smmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index b97188a..95f1c86 100644 --- a/drivers/

[PATCH] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

is a NULL-pointer dereference panic during boot on some hosts. Signed-off-by: Artem Savkov --- drivers/iommu/arm-smmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index b97188a..95f1c86 100644 --- a/drivers/iommu/arm-smmu.c +++ b/dri

possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

Hello, After commit fc8dffd "cpu/hotplug: Convert hotplug locking to percpu rwsem" the following lockdep splat started showing up on some systems while running ltp's madvise06 test (right after first dirty_pages call [1]). [1]

possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

Hello, After commit fc8dffd "cpu/hotplug: Convert hotplug locking to percpu rwsem" the following lockdep splat started showing up on some systems while running ltp's madvise06 test (right after first dirty_pages call [1]). [1]

Re: [PATCH] iommu/amd: Fix schedule-while-atomic BUG in initialization code

On Wed, Jul 26, 2017 at 02:26:14PM +0200, Joerg Roedel wrote: > Hi Artem, Thomas, > > On Wed, Jul 26, 2017 at 12:42:49PM +0200, Thomas Gleixner wrote: > > On Tue, 25 Jul 2017, Artem Savkov wrote: > > > > > Hi, > > > > > > Commit 1c3c5ea "

Re: [PATCH] iommu/amd: Fix schedule-while-atomic BUG in initialization code

On Wed, Jul 26, 2017 at 02:26:14PM +0200, Joerg Roedel wrote: > Hi Artem, Thomas, > > On Wed, Jul 26, 2017 at 12:42:49PM +0200, Thomas Gleixner wrote: > > On Tue, 25 Jul 2017, Artem Savkov wrote: > > > > > Hi, > > > > > > Commit 1c3c5ea "

amd-iommu/x2apic: sleeping function called from invalid context

Hi, Commit 1c3c5ea "sched/core: Enable might_sleep() and smp_processor_id() checks early" seem to have uncovered an issue with amd-iommu/x2apic. Starting with that commit the following warning started to show up on AMD systems during boot: [0.140480] smpboot: Max logical packages: 6 [

amd-iommu/x2apic: sleeping function called from invalid context

Hi, Commit 1c3c5ea "sched/core: Enable might_sleep() and smp_processor_id() checks early" seem to have uncovered an issue with amd-iommu/x2apic. Starting with that commit the following warning started to show up on AMD systems during boot: [0.140480] smpboot: Max logical packages: 6 [

[PATCH v2] Use ctlr directly in rdac_failover_get()

..@vger.kernel.org Signed-off-by: Artem Savkov <asav...@redhat.com> --- drivers/scsi/device_handler/scsi_dh_rdac.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c index

[PATCH v2] Use ctlr directly in rdac_failover_get()

..@vger.kernel.org Signed-off-by: Artem Savkov --- drivers/scsi/device_handler/scsi_dh_rdac.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c index 3cbab87..2ceff58 100644

[PATCH] Use ctlr directly in rdac_failover_get()

[ 18.436192] CR2: 0790 [ 18.436198] ---[ end trace 40f3e4dca1ffabdd ]--- [ 18.436199] Kernel panic - not syncing: Fatal exception [ 18.436222] Kernel Offset: disabled [-- MARK -- Thu May 18 11:45:00 2017] Signed-off-by: Artem Savkov <asav...@redhat.com> --- dri

[PATCH] Use ctlr directly in rdac_failover_get()

[ 18.436192] CR2: 0790 [ 18.436198] ---[ end trace 40f3e4dca1ffabdd ]--- [ 18.436199] Kernel panic - not syncing: Fatal exception [ 18.436222] Kernel Offset: disabled [-- MARK -- Thu May 18 11:45:00 2017] Signed-off-by: Artem Savkov --- drivers/scsi/device_handler/s

[PATCH v2] nfs/filelayout: fix NULL pointer dereference in fl_pnfs_update_layout()

t_lseg+0x29/0x100 [nfsv4] RSP: c9ff39b8 [ 3000.672462] CR2: 003c Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/nfs/filelayout/filelayout.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/

[PATCH v2] nfs/filelayout: fix NULL pointer dereference in fl_pnfs_update_layout()

t_lseg+0x29/0x100 [nfsv4] RSP: c9ff39b8 [ 3000.672462] CR2: 003c Signed-off-by: Artem Savkov --- fs/nfs/filelayout/filelayout.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filelayout.c index a

[PATCH] nfs/filelayout: fix NULL pointer dereference in fl_pnfs_update_layout()

1] RIP: pnfs_put_lseg+0x29/0x100 [nfsv4] RSP: c9ff39b8 [ 3000.672462] CR2: 003c Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/nfs/filelayout/filelayout.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filela

[PATCH] nfs/filelayout: fix NULL pointer dereference in fl_pnfs_update_layout()

1] RIP: pnfs_put_lseg+0x29/0x100 [nfsv4] RSP: c9ff39b8 [ 3000.672462] CR2: 003c Signed-off-by: Artem Savkov --- fs/nfs/filelayout/filelayout.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filelayout.c index acd30ba..a53d1b7

  1   2   3   >