Re: ibmvtpm byteswapping inconsistency

Adding Vicky from IBM. On 01/26/2017 04:05 PM, Jason Gunthorpe wrote: On Thu, Jan 26, 2017 at 09:22:48PM +0100, Michal Such??nek wrote: This is repeated a few times in the driver so I added memset to quiet gcc and make behavior deterministic in case the unused fields get some meaning in the

Re: ibmvtpm byteswapping inconsistency

Adding Vicky from IBM. On 01/26/2017 04:05 PM, Jason Gunthorpe wrote: On Thu, Jan 26, 2017 at 09:22:48PM +0100, Michal Such??nek wrote: This is repeated a few times in the driver so I added memset to quiet gcc and make behavior deterministic in case the unused fields get some meaning in the

Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned

On 10/14/2015 04:15 PM, Ashley Lai wrote: On 10/13/2015 04:27 PM, Hon Ching(Vicky) Lo wrote: On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote: On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: The event log generated by OpenFirmware in PowerPC is 4-byte aligned. This patch reformats

Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned

On 10/13/2015 04:27 PM, Hon Ching(Vicky) Lo wrote: On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote: On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: The event log generated by OpenFirmware in PowerPC is 4-byte aligned. This patch reformats the log to be byte-aligned for the Linux

Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned

On 10/13/2015 04:27 PM, Hon Ching(Vicky) Lo wrote: On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote: On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: The event log generated by OpenFirmware in PowerPC is 4-byte aligned. This patch reformats the log to be byte-aligned for the Linux

Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned

On 10/14/2015 04:15 PM, Ashley Lai wrote: On 10/13/2015 04:27 PM, Hon Ching(Vicky) Lo wrote: On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote: On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: The event log generated by OpenFirmware in PowerPC is 4-byte aligned. This patch reformats

Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned

On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: The event log generated by OpenFirmware in PowerPC is 4-byte aligned. This patch reformats the log to be byte-aligned for the Linux client. Signed-off-by: Hon Ching(Vicky) Lo --- arch/powerpc/kernel/prom_init.c | 13 - 1

Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned

On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: The event log generated by OpenFirmware in PowerPC is 4-byte aligned. This patch reformats the log to be byte-aligned for the Linux client. Signed-off-by: Hon Ching(Vicky) Lo --- arch/powerpc/kernel/prom_init.c |

Re: [PATCH v4 1/2] vTPM: support little endian guests

Looks better. Thanks. Reviewed-by: Ashley Lai Cheers, Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FA

Re: [PATCH v4 2/2] TPM: remove unnecessary little endian conversion

Looks good. Reviewed-by: Ashley Lai Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4 2/2] TPM: remove unnecessary little endian conversion

Looks good. Reviewed-by: Ashley Lai ash...@ahsleylai.com Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH v4 1/2] vTPM: support little endian guests

Looks better. Thanks. Reviewed-by: Ashley Lai ash...@ahsleylai.com Cheers, Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH v2 2/2] TPM: remove unnecessary little endian conversion

Looks good. Reviewed-by: Ashley Lai Thanks, --Ashley On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote: The base pointer for the event log is allocated in the local kernel (in prom_instantiate_sml()), therefore it is already in the host's endian byte order and requires no conversion

Re: [PATCH v2 1/2] vTPM: support little endian guests

above. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 1/2] vTPM: support little endian guests

, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 2/2] TPM: remove unnecessary little endian conversion

Looks good. Reviewed-by: Ashley Lai ash...@ahsleylai.com Thanks, --Ashley On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote: The base pointer for the event log is allocated in the local kernel (in prom_instantiate_sml()), therefore it is already in the host's endian byte order and requires

Re: [PATCH] vTPM: set virtual device before passing to ibmvtpm_reset_crq

Thanks for the patch. Looks good to me. Reviewed-by: Ashley Lai --Ashley Lai On Fri, 22 May 2015, Hon Ching(Vicky) Lo wrote: tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq, the phype call

Re: [PATCH] vTPM: set virtual device before passing to ibmvtpm_reset_crq

Thanks for the patch. Looks good to me. Reviewed-by: Ashley Lai ash...@ahsleylai.com --Ashley Lai On Fri, 22 May 2015, Hon Ching(Vicky) Lo wrote: tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq

Re: [PATCH 3/3] vTPM: support little endian guests

@@ -208,11 +229,43 @@ static int tpm_binary_bios_measurements_show(struct seq_file *m, void *v) struct tcpa_event *event = v; char *data = v; int i; - - for (i = 0; i < sizeof(struct tcpa_event) + event->event_size; i++) + u32 x; + char tmp[4]; + +

Re: [PATCH 3/3] vTPM: support little endian guests

/* Data */ + if (convert_to_host_format(event->event_size)) { + for (i = 0; i < convert_to_host_format(event->event_size); i++) + seq_putc(m, data[i]); + } return 0; + } If the tcpa_event structure is converted, you may be abl

Re: [PATCH 3/3] vTPM: support little endian guests

++) + seq_putc(m, data[i]); + } return 0; + } If the tcpa_event structure is converted, you may be able to get away with memcpy and the for loop. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 3/3] vTPM: support little endian guests

@@ -208,11 +229,43 @@ static int tpm_binary_bios_measurements_show(struct seq_file *m, void *v) struct tcpa_event *event = v; char *data = v; int i; - - for (i = 0; i sizeof(struct tcpa_event) + event-event_size; i++) + u32 x; + char tmp[4]; + +

Re: [PATCH 3/3] vTPM: support little endian guests

The event log in ppc64 arch is always in big endian format. PowerPC supports both little endian and big endian guests. This patch converts the event log entries to guest format. I'm a little confused here. If this patch is to convert the event log entries why are we convert in the

Re: [PATCH 3/3] vTPM: support little endian guests

The event log in ppc64 arch is always in big endian format. PowerPC supports both little endian and big endian guests. This patch converts the event log entries to guest format. I'm a little confused here. If this patch is to convert the event log entries why are we convert in the

Re: [PATCH 1/1] tpm_ibmvtpm: Update email address in maintainers list and ibmvtpm driver

Thanks Joe. I just resubmitted. --Ashley On Thu, 4 Dec 2014, Joe Perches wrote: On Thu, 2014-12-04 at 19:17 -0600, Ashley Lai wrote: Added myself as a maintainer for the IBM vtpm driver and removed myself from the tpm maintainer list. Also, updated the tpm_ibmvtpm driver with my current

[PATCH 1/1] tpm_ibmvtpm: Update email address in maintainers list and ibmvtpm driver

Added myself as a maintainer for the IBM vtpm driver and removed myself from the tpm maintainer list. Also, updated the tpm_ibmvtpm driver with my current email address. Signed-off-by: Ashley Lai --- MAINTAINERS| 8 +++- drivers/char/tpm/tpm_ibmvtpm.c | 2 +- drivers

[PATCH 1/1] tpm_ibmvtpm: Update email address in maintainers list and ibmvtpm driver

Added myself as a maintainer for the IBM vtpm driver and removed myself from the tpm maintainer list. Also, updated the tpm_ibmvtpm driver with my current email address. Signed-off-by: Ashley Lai --- MAINTAINERS| 8 +++- drivers/char/tpm/tpm_ibmvtpm.c | 2 +- drivers

[PATCH 1/1] tpm_ibmvtpm: Update email address in maintainers list and ibmvtpm driver

Added myself as a maintainer for the IBM vtpm driver and removed myself from the tpm maintainer list. Also, updated the tpm_ibmvtpm driver with my current email address. Signed-off-by: Ashley Lai ashleyd...@gmail.com --- MAINTAINERS| 8 +++- drivers/char/tpm/tpm_ibmvtpm.c

[PATCH 1/1] tpm_ibmvtpm: Update email address in maintainers list and ibmvtpm driver

Added myself as a maintainer for the IBM vtpm driver and removed myself from the tpm maintainer list. Also, updated the tpm_ibmvtpm driver with my current email address. Signed-off-by: Ashley Lai ashleyd...@gmail.com --- MAINTAINERS| 8 +++- drivers/char/tpm/tpm_ibmvtpm.c

Re: [PATCH 1/1] tpm_ibmvtpm: Update email address in maintainers list and ibmvtpm driver

Thanks Joe. I just resubmitted. --Ashley On Thu, 4 Dec 2014, Joe Perches wrote: On Thu, 2014-12-04 at 19:17 -0600, Ashley Lai wrote: Added myself as a maintainer for the IBM vtpm driver and removed myself from the tpm maintainer list. Also, updated the tpm_ibmvtpm driver with my current

Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

I recommend not applying this patch until we hear back from IBM. Thanks, --Ashley On Tue, 2 Dec 2014, Peter Hüwe wrote: Hi, so shall I apply this patch? or not? Thanks, Peter Am Dienstag, 2. Dezember 2014, 20:22:35 schrieb Ashley Lai: @@ -63,9 +63,9 @@ static int ibmvtpm_send_crq(struct

Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

@@ -63,9 +63,9 @@ static int ibmvtpm_send_crq(struct vio_dev *vdev, u64 w1, u64 w2) static struct ibmvtpm_dev *ibmvtpm_get_data(const struct device *dev) { struct tpm_chip *chip = dev_get_drvdata(dev); - if (chip) - return (struct ibmvtpm_dev *)TPM_VPRIV(chip); -

Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

@@ -63,9 +63,9 @@ static int ibmvtpm_send_crq(struct vio_dev *vdev, u64 w1, u64 w2) static struct ibmvtpm_dev *ibmvtpm_get_data(const struct device *dev) { struct tpm_chip *chip = dev_get_drvdata(dev); - if (chip) - return (struct ibmvtpm_dev *)TPM_VPRIV(chip); -

Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

I recommend not applying this patch until we hear back from IBM. Thanks, --Ashley On Tue, 2 Dec 2014, Peter Hüwe wrote: Hi, so shall I apply this patch? or not? Thanks, Peter Am Dienstag, 2. Dezember 2014, 20:22:35 schrieb Ashley Lai: @@ -63,9 +63,9 @@ static int ibmvtpm_send_crq(struct

Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

) { struct tpm_chip *chip = dev_get_drvdata(dev); - if (chip) - return (struct ibmvtpm_dev *)TPM_VPRIV(chip); - return NULL; + + BUG_ON(!chip); + return (struct ibmvtpm_dev *)TPM_VPRIV(chip); } /** Acked-by: Ashley Lai -- To unsubscribe from this list

Re: [PATCH 2/2] tpm/tpm_ibmvtpm: Remove unnecessary casts

On Sat, 20 Sep 2014, Anton Blanchard wrote: There is no need to cast from a void pointer to another pointer. Signed-off-by: Anton Blanchard Acked-by: Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

Hi Anton, Thanks for the patch. Is this oops easy to recreate? If so could you give us the steps to reproduce? Thanks, --Ashley Lai On Sat, 20 Sep 2014, Anton Blanchard wrote: I'm looking at an oops in tpm_ibmvtpm_get_desired_dma: 28:00 00 20 39 li r9,0 2c:10 00 01 e8

Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

Hi Anton, Thanks for the patch. Is this oops easy to recreate? If so could you give us the steps to reproduce? Thanks, --Ashley Lai On Sat, 20 Sep 2014, Anton Blanchard wrote: I'm looking at an oops in tpm_ibmvtpm_get_desired_dma: 28:00 00 20 39 li r9,0 2c:10 00 01 e8

Re: [PATCH 2/2] tpm/tpm_ibmvtpm: Remove unnecessary casts

On Sat, 20 Sep 2014, Anton Blanchard wrote: There is no need to cast from a void pointer to another pointer. Signed-off-by: Anton Blanchard an...@samba.org Acked-by: Ashley Lai ash...@ashleylai.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

device *dev) { struct tpm_chip *chip = dev_get_drvdata(dev); - if (chip) - return (struct ibmvtpm_dev *)TPM_VPRIV(chip); - return NULL; + + BUG_ON(!chip); + return (struct ibmvtpm_dev *)TPM_VPRIV(chip); } /** Acked-by: Ashley Lai ash

Re: [tpmdd-devel] [PATCH 5/5 v2] tpm: Make tpm-dev allocate a per-file structure

_EXCL behaviour of the current code. Reviewed-by: Ashley Lai Acked-by: Ashley Lai Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majord

Re: [tpmdd-devel] [PATCH 4/5 v2] tpm: Use the ops structure instead of a copy in tpm_vendor_specific

On Sun, 2013-11-03 at 20:38 -0700, Jason Gunthorpe wrote: > This builds on the last commit to use the ops structure in the core > and reduce the size of tpm_vendor_specific. > > Signed-off-by: Jason Gunthorpe > Reviewed-by: Joel Schopp > --- Reviewed-by: Ashley Lai Ac

Re: [tpmdd-devel] [PATCH 3/5 v2] tpm: Create a tpm_class_ops structure and use it in the drivers

Reviewed-by: Joel Schopp Reviewed-by: Ashley Lai Acked-by: Ashley Lai Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [tpmdd-devel] [PATCH 2/5 v2] tpm: Pull everything related to sysfs into tpm-sysfs.c

thout any modification to the code. Why do we need to change the function names in this file? Unless there is a good reason for it otherwise I would prefer to keep the same function names. This is for easy maintaining (for me at least :)) in case there are issues in the future and we need to go back w

Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

; + dev_warn(chip->dev, Any reason why we use dev_warn here instead of dev_err? > + "unable to misc_register %s, minor %d err=%d\n", > + chip->vendor.miscdev.name, > + chip->vendor.miscdev.minor

Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

, Any reason why we use dev_warn here instead of dev_err? + unable to misc_register %s, minor %d err=%d\n, + chip-vendor.miscdev.name, + chip-vendor.miscdev.minor, rc); + } + return rc; +} + Reviewed-by: Ashley Lai ad

Re: [tpmdd-devel] [PATCH 2/5 v2] tpm: Pull everything related to sysfs into tpm-sysfs.c

, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [tpmdd-devel] [PATCH 3/5 v2] tpm: Create a tpm_class_ops structure and use it in the drivers

...@obsidianresearch.com Reviewed-by: Joel Schopp jsch...@linux.vnet.ibm.com Reviewed-by: Ashley Lai ad...@linux.vnet.ibm.com Acked-by: Ashley Lai ad...@linux.vnet.ibm.com Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [tpmdd-devel] [PATCH 4/5 v2] tpm: Use the ops structure instead of a copy in tpm_vendor_specific

--- Reviewed-by: Ashley Lai ad...@linux.vnet.ibm.com Acked-by: Ashley Lai ad...@linux.vnet.ibm.com Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [tpmdd-devel] [PATCH 5/5 v2] tpm: Make tpm-dev allocate a per-file structure

of the current code. Reviewed-by: Ashley Lai ad...@linux.vnet.ibm.com Acked-by: Ashley Lai ad...@linux.vnet.ibm.com Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [tpmdd-devel] tpm: Remainder of earlier clean up

Hi Jason, Just want to let you know that I'm not forgetting about reviewing these patches. It is on my to do list, I will get to it by this or next weekend. --Ashley Lai On Sun, 2013-11-03 at 20:38 -0700, Jason Gunthorpe wrote: > Here is the last five patches from the prior series I s

Re: [tpmdd-devel] tpm: Remainder of earlier clean up

Hi Jason, Just want to let you know that I'm not forgetting about reviewing these patches. It is on my to do list, I will get to it by this or next weekend. --Ashley Lai On Sun, 2013-11-03 at 20:38 -0700, Jason Gunthorpe wrote: Here is the last five patches from the prior series I sent

Re: Re: [tpmdd-devel] [PATCH] tpm: MAINTAINERS: Add myself as tpm maintainer

gunthorpe/linux/commits/for-tpm Peter already submitted most of the patches to James from this branch. Let us know which series need to be review. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: Re: [tpmdd-devel] [PATCH] tpm: MAINTAINERS: Add myself as tpm maintainer

/for-tpm Peter already submitted most of the patches to James from this branch. Let us know which series need to be review. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [tpmdd-devel] [PATCH 06/13] tpm: Remove redundant dev_set_drvdata

spi_set_drvdata(dev, chip); > platform_data->bchipf = false; > Acked-by: Ashley Lai Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [tpmdd-devel] [PATCH 05/13] tpm: Use container_of to locate the tpm_chip in tpm_open

ange > means we do not have to export the tpm_chip list. > > Signed-off-by: Jason Gunthorpe Acked-by: Ashley Lai Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: TPM.ko module rename (was tpm: Pull everything related to /dev/tpmX into tpm-dev.c)

good? I'll respin the patches and test modular rebuilds. Jason Me too, I vote to keep the same module name. Please let me know when you are done with this patch, I would like to test it out. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [tpmdd-devel] [PATCH 04/13] tpm: Store devname in the tpm_chip

On Mon, 2013-09-23 at 12:14 -0600, Jason Gunthorpe wrote: > Just put the memory directly in the chip structure, rather than > in a 2nd dedicated kmalloc. > > Signed-off-by: Jason Gunthorpe Acked-by: Ashley Lai Thanks, --Ashley Lai -- To unsubscribe from this list: send the line

Re: [tpmdd-devel] [PATCH 04/13] tpm: Store devname in the tpm_chip

On Mon, 2013-09-23 at 12:14 -0600, Jason Gunthorpe wrote: Just put the memory directly in the chip structure, rather than in a 2nd dedicated kmalloc. Signed-off-by: Jason Gunthorpe jguntho...@obsidianresearch.com Acked-by: Ashley Lai ad...@linux.vnet.ibm.com Thanks, --Ashley Lai

Re: TPM.ko module rename (was tpm: Pull everything related to /dev/tpmX into tpm-dev.c)

good? I'll respin the patches and test modular rebuilds. Jason Me too, I vote to keep the same module name. Please let me know when you are done with this patch, I would like to test it out. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [tpmdd-devel] [PATCH 05/13] tpm: Use container_of to locate the tpm_chip in tpm_open

to export the tpm_chip list. Signed-off-by: Jason Gunthorpe jguntho...@obsidianresearch.com Acked-by: Ashley Lai ad...@linux.vnet.ibm.com Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [tpmdd-devel] [PATCH 06/13] tpm: Remove redundant dev_set_drvdata

); platform_data-bchipf = false; Acked-by: Ashley Lai ad...@linux.vnet.ibm.com Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: TPM: STMicroelectronics st33 driver SPI

hecks for the return value. ... + + + /* go and do it */ + data = TPM_STS_GO; + ret = spi_write8_reg(chip, TPM_STS, , 1); Regards, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: TPM: STMicroelectronics st33 driver SPI

= TPM_STS_GO; + ret = spi_write8_reg(chip, TPM_STS, data, 1); Regards, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 1/1] drivers/char/tpm: remove tasklet and cleanup

James Morris wrote: > > > > On Wed, 12 Sep 2012, Ashley Lai wrote: > > > > > > > > > This patch removed the tasklet and moved the wait queue into the > > > > > private structure. It also cleaned up the response CRQ path. > > > > > > &g

Re: [PATCH 1/1] drivers/char/tpm: remove tasklet and cleanup

2012, Ashley Lai wrote: This patch removed the tasklet and moved the wait queue into the private structure. It also cleaned up the response CRQ path. Signed-off-by: Ashley Lai ad...@us.ibm.com Kent: any comment on this? You should probably push this to me

[PATCH 1/1] drivers/char/tpm: remove tasklet and cleanup

This patch removed the tasklet and moved the wait queue into the private structure. It also cleaned up the response CRQ path. Signed-off-by: Ashley Lai --- James, This patch is based on your "next" branch. git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git Than

[PATCH 1/1] drivers/char/tpm: remove tasklet and cleanup

This patch removed the tasklet and moved the wait queue into the private structure. It also cleaned up the response CRQ path. Signed-off-by: Ashley Lai ad...@us.ibm.com --- James, This patch is based on your next branch. git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

l > have quite a lot of traffic here, is that the case ? > > You might be actually increasing latency here in favor of throughput, is > that what you are aiming for ? Also keep in mind that > vio_disable/enable_interrupt() being an hcall, it can have significant > overhead. So again,

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

, Ben. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

functionalities by communicating with the vTPM adjunct partition through Hypervisor calls (Hcalls) and Command/Response Queue (CRQ) commands. Signed-off-by: Ashley Lai --- Oopps... I forgot to remove some invalid comments. Please use this patch for 1/3. drivers/char/tpm/Kconfig |8

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

functionalities by communicating with the vTPM adjunct partition through Hypervisor calls (Hcalls) and Command/Response Queue (CRQ) commands. Signed-off-by: Ashley Lai ad...@us.ibm.com --- Oopps... I forgot to remove some invalid comments. Please use this patch for 1/3. drivers/char/tpm/Kconfig

[PATCH V3 2/3] PPC64: Add support for instantiating SML from Open Firmware

This patch instantiate Stored Measurement Log (SML) and put the log address and size in the device tree. Signed-off-by: Ashley Lai --- arch/powerpc/kernel/prom_init.c | 62 +++ 1 files changed, 62 insertions(+), 0 deletions(-) diff --git a/arch/powerpc

[PATCH V3 3/3] drivers/char/tpm: Add securityfs support for event log

This patch retrieves the event log data from the device tree during file open. The event log data will then displayed through securityfs. Signed-off-by: Ashley Lai --- drivers/char/tpm/Makefile |5 +++ drivers/char/tpm/tpm.h | 12 -- drivers/char/tpm/tpm_eventlog.h

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

functionalities by communicating with the vTPM adjunct partition through Hypervisor calls (Hcalls) and Command/Response Queue (CRQ) commands. Signed-off-by: Ashley Lai --- drivers/char/tpm/Kconfig |8 + drivers/char/tpm/Makefile |1 + drivers/char/tpm/tpm.h |1 + drivers

[PATCH V3 0/3] tpm: Add new vTPM device driver for PPC64

-tpmdd-staging Ashley Lai (3): drivers/char/tpm: Add new device driver to support IBM vTPM PPC64: Add support for instantiating SML from Open Firmware drivers/char/tpm: Add securityfs support for event log arch/powerpc/kernel/prom_init.c | 62 drivers/char/tpm/Kconfig|8

[PATCH V3 0/3] tpm: Add new vTPM device driver for PPC64

-tpmdd-staging Ashley Lai (3): drivers/char/tpm: Add new device driver to support IBM vTPM PPC64: Add support for instantiating SML from Open Firmware drivers/char/tpm: Add securityfs support for event log arch/powerpc/kernel/prom_init.c | 62 drivers/char/tpm/Kconfig|8

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

functionalities by communicating with the vTPM adjunct partition through Hypervisor calls (Hcalls) and Command/Response Queue (CRQ) commands. Signed-off-by: Ashley Lai ad...@us.ibm.com --- drivers/char/tpm/Kconfig |8 + drivers/char/tpm/Makefile |1 + drivers/char/tpm/tpm.h

[PATCH V3 3/3] drivers/char/tpm: Add securityfs support for event log

This patch retrieves the event log data from the device tree during file open. The event log data will then displayed through securityfs. Signed-off-by: Ashley Lai ad...@us.ibm.com --- drivers/char/tpm/Makefile |5 +++ drivers/char/tpm/tpm.h | 12 -- drivers/char/tpm

[PATCH V3 2/3] PPC64: Add support for instantiating SML from Open Firmware

This patch instantiate Stored Measurement Log (SML) and put the log address and size in the device tree. Signed-off-by: Ashley Lai ad...@us.ibm.com --- arch/powerpc/kernel/prom_init.c | 62 +++ 1 files changed, 62 insertions(+), 0 deletions(-) diff --git

Re: [PATCH V2 3/3] drivers/char/tpm: Add securityfs support for event log

Thank you so much for reviewing the code. Please see my reply below. On Fri, 2012-08-10 at 17:23 +1000, Michael Ellerman wrote: > On Thu, 2012-08-09 at 18:13 -0500, Ashley Lai wrote: > > This patch retrieves the event log data from the device tree > > during file open. The

Re: [PATCH V2 3/3] drivers/char/tpm: Add securityfs support for event log

Thank you so much for reviewing the code. Please see my reply below. On Fri, 2012-08-10 at 17:23 +1000, Michael Ellerman wrote: On Thu, 2012-08-09 at 18:13 -0500, Ashley Lai wrote: This patch retrieves the event log data from the device tree during file open. The event log data

[PATCH V2 2/3] PPC64: Add support for instantiating SML from Open Firmware

This patch instantiate Stored Measurement Log (SML) and put the log address and size in the device tree. Signed-off-by: Ashley Lai --- arch/powerpc/kernel/prom_init.c | 64 +++ 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/arch/powerpc

[PATCH V2 3/3] drivers/char/tpm: Add securityfs support for event log

This patch retrieves the event log data from the device tree during file open. The event log data will then displayed through securityfs. Signed-off-by: Ashley Lai --- drivers/char/tpm/Makefile |8 - drivers/char/tpm/tpm.h| 12 -- drivers/char/tpm

[PATCH V2 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

functionalities by communicating with the vTPM adjunct partition through Hypervisor calls (Hcalls) and Command/Response Queue (CRQ) commands. Signed-off-by: Ashley Lai --- drivers/char/tpm/Kconfig |8 + drivers/char/tpm/Makefile |1 + drivers/char/tpm/tpm.h |1 + drivers

[PATCH V2 0/3] tpm: Add new vTPM device driver for PPC64

release 740 or higher). Tested on Power7+ system with firmware level ZM770_001. Applied to Kent Yoder patch to modularize event log located at: https://github.com/shpedoikal/linux/tree/tpmdd-next Ashley Lai (3): drivers/char/tpm: Add new device driver to support IBM vTPM PPC64: Add support

Re: [PATCH 3/3] drivers/char/tpm: Add securityfs support for event log

Hi Kent, Thanks for looking into it. I'll fix in the next version. Sorry if you got this message twice. I have some issues with my mail server. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH 3/3] drivers/char/tpm: Add securityfs support for event log

Hi Kent, Thanks for looking into it. I'll fix in the next version. Sorry if you got this message twice. I have some issues with my mail server. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

[PATCH V2 0/3] tpm: Add new vTPM device driver for PPC64

release 740 or higher). Tested on Power7+ system with firmware level ZM770_001. Applied to Kent Yoder patch to modularize event log located at: https://github.com/shpedoikal/linux/tree/tpmdd-next Ashley Lai (3): drivers/char/tpm: Add new device driver to support IBM vTPM PPC64: Add support

[PATCH V2 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

functionalities by communicating with the vTPM adjunct partition through Hypervisor calls (Hcalls) and Command/Response Queue (CRQ) commands. Signed-off-by: Ashley Lai ad...@us.ibm.com --- drivers/char/tpm/Kconfig |8 + drivers/char/tpm/Makefile |1 + drivers/char/tpm/tpm.h

[PATCH V2 3/3] drivers/char/tpm: Add securityfs support for event log

This patch retrieves the event log data from the device tree during file open. The event log data will then displayed through securityfs. Signed-off-by: Ashley Lai ad...@us.ibm.com --- drivers/char/tpm/Makefile |8 - drivers/char/tpm/tpm.h| 12 -- drivers/char

[PATCH V2 2/3] PPC64: Add support for instantiating SML from Open Firmware

This patch instantiate Stored Measurement Log (SML) and put the log address and size in the device tree. Signed-off-by: Ashley Lai ad...@us.ibm.com --- arch/powerpc/kernel/prom_init.c | 64 +++ 1 files changed, 64 insertions(+), 0 deletions(-) diff --git

[PATCH 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. This driver provides TPM functionalities by communicating with the vTPM adjunct through Hypervisor calls (Hcalls) and Command/Response Queue (CRQ) commands. Signed-off-by: Ashley Lai --- drivers/char/tpm/Kconfig

[PATCH 3/3] drivers/char/tpm: Add securityfs support for event log

This patch retrieves the event log from the device tree and the event log data will be displayed through securityfs. Signed-off-by: Ashley Lai --- drivers/char/tpm/Makefile |8 - drivers/char/tpm/tpm.h| 12 -- drivers/char/tpm/tpm_eventlog.c |7

[PATCH 2/3] PPC64: Add support for instantiating SML from Open Firmware

This patch instantiate Stored Measurement Log (SML) and put the log address and size in the device tree. Signed-off-by: Ashley Lai --- arch/powerpc/kernel/prom_init.c | 64 +++ 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/arch/powerpc

[PATCH 0/3] tpm: Add new vTPM device driver for PPC64

/linux/tree/tpmdd-next Ashley Lai (3): drivers/char/tpm: Add new device driver to support IBM vTPM PPC64: Add support for instantiating SML from Open Firmware drivers/char/tpm: Add securityfs support for event log arch/powerpc/kernel/prom_init.c | 64 drivers/char/tpm/Kconfig

[PATCH 0/3] tpm: Add new vTPM device driver for PPC64

/linux/tree/tpmdd-next Ashley Lai (3): drivers/char/tpm: Add new device driver to support IBM vTPM PPC64: Add support for instantiating SML from Open Firmware drivers/char/tpm: Add securityfs support for event log arch/powerpc/kernel/prom_init.c | 64 drivers/char/tpm/Kconfig

[PATCH 2/3] PPC64: Add support for instantiating SML from Open Firmware

This patch instantiate Stored Measurement Log (SML) and put the log address and size in the device tree. Signed-off-by: Ashley Lai ad...@us.ibm.com --- arch/powerpc/kernel/prom_init.c | 64 +++ 1 files changed, 64 insertions(+), 0 deletions(-) diff --git

[PATCH 3/3] drivers/char/tpm: Add securityfs support for event log

This patch retrieves the event log from the device tree and the event log data will be displayed through securityfs. Signed-off-by: Ashley Lai ad...@us.ibm.com --- drivers/char/tpm/Makefile |8 - drivers/char/tpm/tpm.h| 12 -- drivers/char/tpm/tpm_eventlog.c

[PATCH 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. This driver provides TPM functionalities by communicating with the vTPM adjunct through Hypervisor calls (Hcalls) and Command/Response Queue (CRQ) commands. Signed-off-by: Ashley Lai ad...@us.ibm.com --- drivers

  1   2   >