Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-04 Thread Azael Avalos
Hi there Let me add my two cents on the Toshiba side. 2018-06-04 8:23 GMT-06:00 Hans de Goede : > > 1) drivers/platform/x86/toshiba_acpi.c > > I don't know how the key on Toshiba's behaves on models where > it is hardwired / under Windows With Toshiba we have two types of hardware

Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-10-19 Thread Azael Avalos
Hi Darren, 2016-10-19 14:26 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Wed, Oct 12, 2016 at 10:26:43AM -0600, Azael Avalos wrote: >> *ping* >> >> 2016-08-28 11:00 GMT-06:00 Darren Hart <dvh...@infradead.org>: >> > On Thu, Aug 25, 2016 at 12:50

Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-10-12 Thread Azael Avalos
*ping* 2016-08-28 11:00 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote: >> Bug 150611 uncovered that the WMI ID used by the toshiba-wmi driver >> is not Toshiba specific, and as such, the driver was being loa

[PATCH 2/2] toshiba_haps: Change the error logging level from info to debug

2016-09-07 Thread Azael Avalos
Two of the internal functions are printing an info message, one whenever the HDD protection level changes, and another when the driver receives an ACPI event. This patch changes those two prints to debug, as that information is more pertaining to debuging purposes. Signed-off-by: Azael Avalos

[PATCH] toshiba_bluetooth: Decouple an error checking status code

2016-09-07 Thread Azael Avalos
This patch simply decouples te error checking of the ACPI status and the actual BT status, as those two were nested in an if/else check, but are completely unrelated. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_bluetooth.c | 4 +++- 1 file chan

[PATCH 1/2] toshiba_haps: Split ACPI status error check from HDD protection support

2016-09-07 Thread Azael Avalos
Currently the code checking for the ACPI status is mixed along with the actual HDD protection status check. This patch splits those two checks are they are not related, printing an error string in case the ACPI call failed, and then check for actual HDD protection status. Signed-off-by: Azael

[PATCH 0/2] toshiba_haps: Small updates to driver code

2016-09-07 Thread Azael Avalos
These two patches make some small changes to the driver code, the first splits the error check fro the ACPI status and the HDD protection, and the second simply changes the printing level of two strings from info to debug. Azael Avalos (2): toshiba_haps: Split ACPI status error check from HDD

[PATCH v2 1/3] toshiba_acpi: Clean up variable declaration

2016-08-29 Thread Azael Avalos
This patch moves all the multiple line variable declaration to a single line declaration (except variables being initialized) following the reverse tree order, to conform to the practices of the kernel. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_

[PATCH v2 3/3] toshiba_acpi: Fix typo in *_cooling_method_set function

2016-08-29 Thread Azael Avalos
This patch simply fixes a typo in the error string printed in such function. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/pl

[PATCH v2 0/3] toshiba_acpi: Functions cleanup

2016-08-29 Thread Azael Avalos
to Darren's comments - Added a missing return on *eco_mode_available function Azael Avalos (3): toshiba_acpi: Clean up variable declaration toshiba_acpi: Change error checking logic from TCI functions toshiba_acpi: Fix typo in *_cooling_method_set function drivers/platform/x86/toshiba_acpi.c

[PATCH v2 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-29 Thread Azael Avalos
the acpi_status and the tci_raw function call error check, as those two are completely unrelated and were nested in if/else statements. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 226 ++-- 1 file changed, 138 inse

Re: [PATCH 1/3] toshiba_acpi: Cleanup variable declaration

2016-08-29 Thread Azael Avalos
Hi Darren, 2016-08-28 10:49 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Tue, Aug 16, 2016 at 12:06:15PM -0600, Azael Avalos wrote: >> This patch moves all the multiple line variable declaration to a >> single line declaration (except variables being initialized) >

Re: [PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-29 Thread Azael Avalos
Hi Darren, 2016-08-28 10:56 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Tue, Aug 16, 2016 at 12:06:16PM -0600, Azael Avalos wrote: >> Currently the success/error checking logic is intermixed, making the >> code a bit cumbersome to understand. >> >> This pat

[PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-08-25 Thread Azael Avalos
, dropping the TOSHIBA_ prefix, to better reflect that such GUID is not a Toshiba specific one. Cc: <sta...@vger.kernel.org> # 4.4+ Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Hi Darren, I was waiting on input from the bug above, but haven't received an answer (as of yet),

[PATCH 0/3] toshiba_acpi: Functions cleanup

2016-08-16 Thread Azael Avalos
These set of patches make some cleanup in some of the driver's functions. The first patch changes the variables declaration, the second changes the error checking logic and the third simply fixes a typo found while making these changes. Azael Avalos (3): toshiba_acpi: Cleanup variable

[PATCH 3/3] toshiba_acpi: Fix typo in *_cooling_method_set function

2016-08-16 Thread Azael Avalos
This patch simply fixes a typo in the error string printed in such function. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/pl

[PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-16 Thread Azael Avalos
the acpi_status and the tci_raw function call error check, as those two are completely unrelated and were nested in if/else statements. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 222 ++-- 1 file changed, 135 inse

[PATCH 1/3] toshiba_acpi: Cleanup variable declaration

2016-08-16 Thread Azael Avalos
This patch moves all the multiple line variable declaration to a single line declaration (except variables being initialized) following the reverse tree order, to conform to the practices of the kernel. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_

[PATCH] toshiba_acpi: Fix the kbd_backlight_mode_show printed value

2016-08-16 Thread Azael Avalos
-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 254a4d5..444f351 100644 --- a/drivers/platform/x86/toshiba_acpi.c

Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

2016-06-28 Thread Azael Avalos
2016-06-28 23:16 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Tue, Jun 28, 2016 at 01:58:55PM -0600, Azael Avalos wrote: >> The toshiba_acpi driver added support to the accelerometer axis >> via the IIO subsystem, but failed to add the dependency to the >> Kcon

[PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

2016-06-28 Thread Azael Avalos
in Kconfig to avoid such build failure. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Darren, Jonathan: I just received a few mails from the kbuild test robot informing the build failure, as a fix for this I just added a hard dependency to IIO, but maybe Jonathan can weigh in and prov

[PATCH v3 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-27 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos <coproscef...@gmail.

[PATCH v3 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-27 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.

[PATCH v3 3/3] toshiba_acpi: Bump driver version and update copyright year

2016-06-27 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file c

[PATCH v3 0/3] toshiba_acpi: Accelerometer updates

2016-06-27 Thread Azael Avalos
- Changed the iio code according to feedback from Jonathan Cameron Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove the position sysfs entry toshiba_acpi: Bump driver version and update copyright year drivers/platform/x86/toshiba_acpi.c

Re: [PATCH v2 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-27 Thread Azael Avalos
Hi Darren, 2016-06-27 18:19 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Sun, Jun 19, 2016 at 05:28:04PM -0600, Azael Avalos wrote: >> This patch adds the accelerometer axis data to the IIO subsystem. >> >> Currently reporting the X, Y and Z values, as no other d

Re: [PATCH 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-19 Thread Azael Avalos
Hi, Thanks for the feedback, I just did a respin of the series with the changes you mentioned. Cheers Azael 2016-06-19 14:16 GMT-06:00 Jonathan Cameron <ji...@kernel.org>: > On 11/06/16 19:57, Azael Avalos wrote: >> This patch adds the accelerometer axis data to th

[PATCH v2 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-19 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos <coproscef...@gmail.

[PATCH v2 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-19 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.

[PATCH v2 0/3] toshiba_acpi: Accelerometer updates

2016-06-19 Thread Azael Avalos
Cameron Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove the position sysfs entry toshiba_acpi: Bump driver version and update copyright year drivers/platform/x86/toshiba_acpi.c | 136 +--- 1 file changed

[PATCH v2 3/3] toshiba_acpi: Bump driver version and update copyright year

2016-06-19 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file c

[PATCH 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-11 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos <coproscef...@gmail.

[PATCH 0/3] toshiba_acpi: Accelerometer updates

2016-06-11 Thread Azael Avalos
These series of patches update the accelerometer axis data reporting to use the IIO subsystem, deprecating the custom position sysfs entry, and finally bumping the driver version to 0.24. Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove

[PATCH 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-11 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.

[PATCH 3/3] toshiba_acpi: Bump driver version and update copyrignt year

2016-06-11 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file c

Re: [PATCH] toshiba_acpi: Fix regression caused by hotkey enabling value

2016-04-25 Thread Azael Avalos
Hi Darren, No problem with me, ohh and thanks, I forgot to include stable. Cheers Azael 2016-04-25 11:31 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Fri, Apr 22, 2016 at 09:29:36AM -0600, Azael Avalos wrote: >> Commit 52cbae0127ad ("toshiba_acpi: Change default H

[PATCH] toshiba_acpi: Fix regression caused by hotkey enabling value

2016-04-22 Thread Azael Avalos
ill switch or the pointing device toggle button. This patch reverts such commit by changing the default hotkey enabling value to 0x09, which enables hotkey events only, making the hardware buttons working again. Fixes bugs 113331 and 114941. Signed-off-by: Azael Avalos <coproscef...@gmail.com> ---

[PATCH] toshiba_acpi: Add a module parameter to disable hotkeys registration

2016-01-25 Thread Azael Avalos
-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 5ace1e0..df1f1a7 100644 --- a/drivers/platform/x86/toshiba_

[PATCH 2/2] toshiba_acpi: Add sysfs entries for the Cooling Method feature

2016-01-25 Thread Azael Avalos
This patch adds the sysfs entry Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 51 + 1 file changed, 51 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c

[PATCH 0/3] toshiba_acpi: Add support for Cooling Method

2016-01-25 Thread Azael Avalos
. Azael Avalos (3): toshiba_acpi: Add support for cooling method feature toshiba_acpi: Add sysfs entries for th Cooling Method feature Documentation/ABI: Update sysfs-driver-toshiba_acpi file .../ABI/testing/sysfs-driver-toshiba_acpi | 16 drivers/platform/x86/toshiba_acpi.c

[PATCH 1/3] toshiba_acpi: Add support for cooling method feature

2016-01-25 Thread Azael Avalos
- Battery Optimized Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 54 + 1 file changed, 54 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 7383307

[PATCH 3/3] Documentation/ABI: Update sysfs-driver-toshiba_acpi file

2016-01-25 Thread Azael Avalos
This patch updates the documentation file adding the Cooling Method entry. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Documentation/ABI/testing/sysfs-driver-toshiba_acpi | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-

[PATCH] platform/x86: Add rfkill dependency to ACPI_TOSHIBA entry

2015-12-14 Thread Azael Avalos
the build issue. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 1089eaa..25a02f9 100644 --- a/drivers/platform/x86/Kconfig +++ b/driv

[PATCH v3 2/2] toshiba_acpi: Add WWAN RFKill support

2015-11-23 Thread Azael Avalos
status. Signed-off-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 79 +++-- 1 file changed, 76 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH v3 0/2] toshiba_acpi: Add WWAN support

2015-11-23 Thread Azael Avalos
to rfkill_unregister and rfkill_destroy functions Azael Avalos (2): toshiba_acpi: Add support for WWAN devices toshiba_acpi: Add WWAN RFKill support drivers/platform/x86/toshiba_acpi.c | 188 +++- 1 file changed, 185 insertions(+), 3 deletions(-) -- 2.6.3

[PATCH v3 1/2] toshiba_acpi: Add support for WWAN devices

2015-11-23 Thread Azael Avalos
), the second queries WWAN support, and finally the third (de)activates the device. Signed-off-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com>ZZ --- drivers/platform/x86/toshiba_acpi.c | 109 1

[PATCH v2] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

2015-11-23 Thread Azael Avalos
, to make userspace aware of such change. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Changes since v1: - Moved the implementation of the toshiba_acpi_kbd_bl_work function further down to make the file compile drivers/platform/x86/toshiba_acpi.

Re: [PATCH] toshiba_acpi: Fix blank screen at boot if transflective backlight is supported

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 16:16 GMT-07:00 Darren Hart <dvh...@infradead.org>: > On Sun, Nov 15, 2015 at 08:32:47PM -0700, Azael Avalos wrote: >> If transflective backlight is supported and the brightness is zero >> (lowest brightness level), the set_lcd_brightness f

Re: [PATCH] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 16:39 GMT-07:00 Darren Hart <dvh...@infradead.org>: > On Mon, Nov 16, 2015 at 12:59:31PM -0700, Azael Avalos wrote: >> Certain Toshiba models with the second generation keyboard backlight >> (type 2) do not generate the keyboard backlight changed even

Re: [PATCH v2 2/2] toshiba_acpi: Add WWAN RFKill support

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 15:50 GMT-07:00 Darren Hart <dvh...@infradead.org>: > On Thu, Nov 19, 2015 at 08:49:25AM -0700, Azael Avalos wrote: > > Hi Azael, > >> A previuos patch added WWAN support to the driver, allowing to query >> and set the device status. >&g

Re: [PATCH v2 1/2] toshiba_acpi: Add support for WWAN devices

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 15:49 GMT-07:00 Darren Hart <dvh...@infradead.org>: > On Thu, Nov 19, 2015 at 08:49:24AM -0700, Azael Avalos wrote: >> Toshiba laptops with WWAN devices installed cannot use the device unless >> it is attached and powered, similar to how Toshiba Blue

Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 16:19 GMT-07:00 Darren Hart <dvh...@infradead.org>: > On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote: >> The driver uses genetlink to inform userspace of events generated by >> the system, but the data passed is always zero as there

[PATCH v2 0/2] toshiba_acpi: Add WWAN support

2015-11-19 Thread Azael Avalos
These two patches add WWAN support to the driver, the first adds the actual support functions and the second adds RFKill handler functions to set the device status according to the killswitch. Changes since v1: - Added missing calls to rfkill_unregister and rfkill_destroy functions Azael Avalos

[PATCH v2 2/2] toshiba_acpi: Add WWAN RFKill support

2015-11-19 Thread Azael Avalos
status. Signed-off-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 79 + 1 file changed, 79 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.

[PATCH v2 1/2] toshiba_acpi: Add support for WWAN devices

2015-11-19 Thread Azael Avalos
), the second queries WWAN support, and finally the third (de)activates the device. Signed-off-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 92 + 1

[PATCH] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

2015-11-16 Thread Azael Avalos
, to make userspace aware of such change. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 45 + 1 file changed, 41 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/pl

[PATCH] toshiba_acpi: Fix blank screen at boot if transflective backlight is supported

2015-11-15 Thread Azael Avalos
, avoiding the activation of the tranflective backlight. Cc: <sta...@vger.kernel.org> # 4.3+ Reported-and-tested-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 8 1 file changed, 8 i

[PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

2015-11-15 Thread Azael Avalos
The driver uses genetlink to inform userspace of events generated by the system, but the data passed is always zero as there is no data to pass, except for the hotkey event. This patch propagates the hotkey value via genetlink so userspace can make use of it. Signed-off-by: Azael Avalos

[PATCH 0/2] toshiba_acpi: Add WWAN support

2015-11-15 Thread Azael Avalos
These two patches add WWAN support to the driver, the first adds the actual support functions and the second adds RFKill handler functions to set the device status according to the killswitch. Azael Avalos (2): toshiba_acpi: Add support for WWAN devices toshiba_acpi: Add WWAN RFKill support

[PATCH 1/2] toshiba_acpi: Add support for WWAN devices

2015-11-15 Thread Azael Avalos
), the second queries WWAN support, and finally the third (de)activates the device. Signed-off-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 92 + 1

[PATCH 2/2] toshiba_acpi: Add WWAN RFKill support

2015-11-15 Thread Azael Avalos
status. Signed-off-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 74 + 1 file changed, 74 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.

[PATCH] toshiba_bluetooth: Add missing newline in toshiba_bluetooth_present function

2015-11-15 Thread Azael Avalos
This patch simply adds a missing newline in the error string printed by the toshiba_bluetooth_present function. This is just a cosmetic change, no functionality was changed. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_bluetooth.c | 2 +- 1 file c

Re: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable

2015-11-04 Thread Azael Avalos
Hi Darren, 2015-11-03 17:44 GMT-07:00 Darren Hart <dvh...@infradead.org>: > On Sun, Nov 01, 2015 at 07:30:30PM -0700, Azael Avalos wrote: >> Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some >> toshiba models") fixed an issue on some laptops re

[PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type variable

2015-11-04 Thread Azael Avalos
ed effects as the variable is being checked. This patch initializes such variable to avoid such unwanted effects. Cc: <sta...@vger.kernel.org> # 4.1+ Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] toshiba_acpi: Initialize hotkey_event_type variable

2015-11-01 Thread Azael Avalos
ed effects as the variable is being checked. This patch initializes such variable to avoid such unwanted effects. Cc: <sta...@vger.kernel.org> # 4.1+ Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Darren, Sorry for sending this patch this late, I had a really busy week :-( drivers/platf

Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on some toshiba models

2015-10-26 Thread Azael Avalos
nyone has any objections, please let me know. >> > >> > -- >> > >> > From: Azael Avalos <coproscef...@gmail.com> >> > >> > commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream. >> > >> > Com

[PATCH v4] platform/x86: Toshiba WMI Hotkey Driver

2015-09-28 Thread Azael Avalos
ated stuff. Currently the driver is under the EXPERIMENTAL flag, as the keymap and the notify function are incomplete (due to lack of hardware to test). Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Changes since v3: - Fixed Makefile entry, CONFIG_TOSHIBA_HAPS was doubled instead of one

[PATCH v3] platform/x86: Toshiba WMI Hotkey Driver

2015-09-26 Thread Azael Avalos
ated stuff. Currently the driver is under the EXPERIMENTAL flag, as the keymap and the notify function are incomplete (due to lack of hardware to test). Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Changes since v2: - Fixed typo in patch and Kconfig description as well as in a comment

Re: [PATCH] platform/x86: Toshiba WMI Hotkey Driver

2015-09-22 Thread Azael Avalos
Hi there 2015-09-19 10:48 GMT-06:00 Dmitry Torokhov <dmitry.torok...@gmail.com>: > On Fri, Sep 18, 2015 at 2:59 PM, Darren Hart <dvh...@infradead.org> wrote: >> On Wed, Sep 09, 2015 at 11:30:10AM -0600, Azael Avalos wrote: >>> Toshiba laptops that feature WM

Re: [PATCH] platform/x86: Toshiba WMI Hotkey Driver

2015-09-18 Thread Azael Avalos
Hi Darren, 2015-09-18 15:59 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Wed, Sep 09, 2015 at 11:30:10AM -0600, Azael Avalos wrote: >> Toshiba laptops that feature WMI events for hotkeys were left unsupported >> by the toshiba_acpi driver, however, commit a88bc0

[PATCH v2] platform/x86: Toshiba WMI Hotkey Driver

2015-09-18 Thread Azael Avalos
ated stuff. Currently the driver is under the EXPERIMENTAL flag, as the keymap and the notify function are incomplete (due to lack of hardware to test). Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Changes since v1: - Changed the printed log level of the ACPI event type value from

[PATCH v2] toshiba_acpi: Remove unneeded u32 variables from *setup_keyboard

2015-09-18 Thread Azael Avalos
STEM_EVENT query can be checked directly from the function. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Changes since v1: - Effectively remove unneeded braces to avoid compiler errors I forgot to respin the patch with the changes when compile tested this patch, sorry for the noi

Re: [PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value

2015-09-18 Thread Azael Avalos
Hi Darren, 2015-09-18 16:14 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Fri, Sep 18, 2015 at 03:45:05PM -0600, Azael Avalos wrote: >> Hi Darren, >> >> 2015-09-18 15:37 GMT-06:00 Darren Hart <dvh...@infradead.org>: >> > On Wed, Sep 09, 20

Re: [PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value

2015-09-18 Thread Azael Avalos
Hi Darren, 2015-09-18 15:37 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote: >> The driver currently uses the hotkey enabling value of 0x09 to enable >> hotkey events, but windows uses a different value (0x01). >

[PATCH] toshiba_acpi: Fix hotkeys registration on some toshiba models

2015-09-09 Thread Azael Avalos
to notice, making the function responsible for registering the input device to continue. This issue was found on a Toshiba Portege Z30-B, but there might be some other models out there affected by this regression as well. Cc: <sta...@vger.kernel.org> # 4.1+ Signed-off-by: Azael Avalos <cop

[PATCH] toshiba_acpi: Fix USB Sleep and Music always disabled

2015-09-09 Thread Azael Avalos
assignment to a comparison, making the laptops with actual support for such feature to work again. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Darren, Hopefully this patch can go into one of the 4.3 RCs, as the changes are there and to avoid shipping a broken feature support.

[PATCH 0/2] toshiba_acpi: Hotkey updates

2015-09-09 Thread Azael Avalos
These two patches make some changes to the hotkeys code, the first patch unify the hotkey enabling code, and the second changes the default hotkey enabling parameter. Azael Avalos (2): toshiba_acpi: Unify hotkey enabling functions toshiba_acpi: Change default Hotkey enabling value drivers

[PATCH 1/2] toshiba_acpi: Unify hotkey enabling functions

2015-09-09 Thread Azael Avalos
Currently the driver has two functions enabling hotkeys support, but these two functions can be merged into one. This patch merges these two functions, moving some checks to the *enable_hotkeys function, simplifying code in the process. Signed-off-by: Azael Avalos <coproscef...@gmail.

[PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value

2015-09-09 Thread Azael Avalos
vents only. 0x0b - Disable (hotkey and system) events. This patch changes the default hotkey enabling value from 0x09 to 0x01, enabling both the hotkey and system events. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1

[PATCH 1/1] toshiba_acpi: Add 0x prefix to available_kbd_modes_show funtion

2015-09-09 Thread Azael Avalos
. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 9f7ced1..50a2116 100644 --- a/drivers/platfo

[PATCH] platform/x86: Toshiba WMI Hotkey Driver

2015-09-09 Thread Azael Avalos
ated stuff. Currently the driver is under the EXPERIMENTAL flag, as the keymap and the notify function are incomplete (due to lack of hardware to test). Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- MAINTAINERS| 6 ++ drivers/platform/x86/Kconfig | 1

[PATCH 1/1] toshiba_acpi: Remove unneeded u32 variables from *setup_keyboard

2015-09-09 Thread Azael Avalos
STEM_EVENT query can be checked directly from the function. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/driv

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-06 Thread Azael Avalos
Hi Darren, 2015-08-05 17:21 GMT-06:00 Darren Hart dvh...@infradead.org: On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote: Hi Darren, 2015-08-05 14:21 GMT-06:00 Darren Hart dvh...@infradead.org: @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct toshiba_acpi_dev

Re: [PATCH v3 2/5] toshiba_acpi: Remove *not supported feature prints

2015-08-05 Thread Azael Avalos
Hi Darren, 2015-08-05 3:38 GMT-06:00 Darren Hart dvh...@infradead.org: On Fri, Jul 31, 2015 at 09:58:13PM -0600, Azael Avalos wrote: Currently the driver prints *not supported if any of the features queried are in fact not supported, let us print the available features instead. This patch

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-05 Thread Azael Avalos
Hi Darren, 2015-08-05 14:21 GMT-06:00 Darren Hart dvh...@infradead.org: @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct toshiba_acpi_dev *dev, u32 state) result = sci_write(dev, SCI_USB_THREE, state); sci_close(dev); - if (result == TOS_FAILURE) { + if

[PATCH] MAINTAINERS: Remove Toshiba Linux mailing list address

2015-08-03 Thread Azael Avalos
As of March 31th 2015, the mailing-list service finished [1]. This patch simply removes such address. [1] http://goo.gl/F6jS5r Signed-off-by: Azael Avalos coproscef...@gmail.com --- Hi Darren, I hope you can queue this patch through your tree, I ran the get_maintainer.pl script but didn't come

[PATCH v3 1/5] toshiba_acpi: Change *available functions return type

2015-07-31 Thread Azael Avalos
accordingly to these changes and two new variables were created and another was changed from uint to bool. Also, the function toshiba_acceleremoter_supported was renamed to toshiba_accelerometer_available to maintain the naming consistency on the driver. Signed-off-by: Azael Avalos coproscef

[PATCH v3 0/5] toshiba_acpi: Refactor *{get, set} and *available functions

2015-07-31 Thread Azael Avalos
in patch 03 to ensure we are not breaking userspace and updated patch description Azael Avalos (5): toshiba_acpi: Change *available functions return type toshiba_acpi: Remove *not supported feature prints toshiba_acpi: Refactor *{get, set} functions return value toshiba_acpi: Remove

[PATCH v3 2/5] toshiba_acpi: Remove *not supported feature prints

2015-07-31 Thread Azael Avalos
the available laptop features. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 72 +++-- 1 file changed, 46 insertions(+), 26 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index

[PATCH v3 5/5] toshiba_acpi: Bump driver version to 0.23

2015-07-31 Thread Azael Avalos
Given that some features were added (/dev/toshiba_acpi device), some clean-ups and minor (cosmetic) changes all over the driver code, bump the driver version to 0.23 to reflect these overall changes. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 2

[PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-07-31 Thread Azael Avalos
values other than the ones currently checking for. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 169 ++-- 1 file changed, 44 insertions(+), 125 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers

[PATCH v3 3/5] toshiba_acpi: Refactor *{get, set} functions return value

2015-07-31 Thread Azael Avalos
to their parent HCI functions. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 177 +--- 1 file changed, 104 insertions(+), 73 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86

[PATCH v2 3/4] toshiba_acpi: Refactor *{get, set} functions return value

2015-07-27 Thread Azael Avalos
to their parent HCI functions. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 432 ++-- 1 file changed, 217 insertions(+), 215 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86

[PATCH v2 0/4] toshiba_acpi: Refactor *{get, set} and *available functions

2015-07-27 Thread Azael Avalos
, video}_proc functions in patch 03 to ensure we are not breaking userspace and updated patch description Azael Avalos (4): toshiba_acpi: Change *available functions return type toshiba_acpi: Remove *not supported feature prints toshiba_acpi: Refactor *{get, set} functions return value

[PATCH v2 2/4] toshiba_acpi: Remove *not supported feature prints

2015-07-27 Thread Azael Avalos
the available laptop features. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 69 +++-- 1 file changed, 44 insertions(+), 25 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index

[PATCH v2 4/4] toshiba_acpi: Bump driver version to 0.23

2015-07-27 Thread Azael Avalos
Given that some features were added (/dev/toshiba_acpi device), some clean-ups and minor changes, bump the driver version to 0.23. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] toshiba_acpi: Add set_fan_status function

2015-07-27 Thread Azael Avalos
of the HCI/SCI functions), printing an error message, returning -ENODEV and zero respectively. The proc and sysfs functions were updated to reflect these changes as well, returning -EIO for proc, and propagating the error value on the sysfs functions. Signed-off-by: Azael Avalos coproscef...@gmail.com

[PATCH v2 1/4] toshiba_acpi: Change *available functions return type

2015-07-27 Thread Azael Avalos
to *accelerometer_available. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 142 1 file changed, 61 insertions(+), 81 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c

Re: [PATCH 1/1] toshiba_acpi: Add set_fan_status function

2015-07-24 Thread Azael Avalos
Hi Darren, 2015-07-24 16:45 GMT-06:00 Darren Hart dvh...@infradead.org: On Wed, Jul 22, 2015 at 07:37:48PM -0600, Azael Avalos wrote: This patch adds a new function named set_fan_status to complement its get* counterpart, as well as to avoid code duplication between fan_proc_write

[PATCH 1/1] toshiba_acpi: Add set_fan_status function

2015-07-22 Thread Azael Avalos
This patch adds a new function named set_fan_status to complement its get* counterpart, as well as to avoid code duplication between fan_proc_write and fan_store. Signed-off-by: Azael Avalos coproscef...@gmail.com --- drivers/platform/x86/toshiba_acpi.c | 55

  1   2   3   4   >