[Resend v1] Bluetooth: hci_qca: Wait for timeout during suspend

2020-11-10 Thread Balakrishna Godavarthi
triggered during FW download and memory collections. Signed-off-by: Venkata Lakshmi Narayana Gubba Signed-off-by: Balakrishna Godavarthi Reviewed-by: Abhishek Pandit-Subedi --- drivers/bluetooth/hci_qca.c | 48 - 1 file changed, 39 insertions(+), 9

[Resend v1] Bluetooth: hci_qca: Enhance retry logic in qca_setup

2020-11-10 Thread Balakrishna Godavarthi
request command too. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Abhishek Pandit-Subedi --- drivers/bluetooth/hci_qca.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index

[PATCH v1] Bluetooth: hci_qca: Wait for timeout during suspend

2020-10-06 Thread Balakrishna Godavarthi
triggered during FW download and memory collections. Signed-off-by: Venkata Lakshmi Narayana Gubba Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 48 - 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH v1] Bluetooth: hci_qca: Enhance retry logic in qca_setup

2020-10-05 Thread Balakrishna Godavarthi
request command too. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 2d3f1f1..1c9a2d46 100644 --- a/drivers

[PATCH v1] Bluetooth: hci_qca: Increase SoC idle timeout to 200ms

2020-06-12 Thread Balakrishna Godavarthi
In some version of WCN399x, SoC idle timeout is configured as 80ms instead of 20ms or 40ms. To honor all the SoC's supported in the driver increasing SoC idle timeout to 200ms. Fixes: 41d5b25fed0a0 ("Bluetooth: hci_qca: add PM support") Signed-off-by: Balakrishna Godavarth

[PATCH v1] Bluetooth: hci_qca: Disable SoC debug logging for WCN3991

2020-06-12 Thread Balakrishna Godavarthi
By default, WCN3991 sent debug packets to HOST via ACL packet with header 0xDC2E. This logging is not required on commercial devices. With this patch SoC logging is disabled post fw download. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/btqca.c | 27

[PATCH v1] Bluetooth: hci_qca: Request Tx clock vote off only when Tx is pending

2020-06-12 Thread Balakrishna Godavarthi
need to wake up hci to send data. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index f3fde99..50f896f 100644 --- a/drivers/bluetooth/hci_qca.c +++ b

Re: [PATCH 2/4] Bluetooth: hci_qca: Don't vote for specific voltage

2019-10-21 Thread Balakrishna Godavarthi
Hi Matthias, Bjorn andresson, On 2019-10-21 12:07, Harish Bandi wrote: + Bala On 2019-10-18 23:52, Matthias Kaehlcke wrote: On Thu, Oct 17, 2019 at 10:24:02PM -0700, Bjorn Andersson wrote: Devices with specific voltage requirements should not request voltage from the driver, but instead rely

Re: [PATCH] Bluetooth: hci_qca: fix in-band sleep enablement

2019-10-11 Thread Balakrishna Godavarthi
Hi Claire, This change will not work as we need fw files to be loaded tofor IBS to active. may i know on which chipset you have this issue of IBS active even with out fw download. On 2019-10-11 12:31, Harish Bandi wrote: ++ Balakrishna On 2019-10-09 14:21, Claire Chang wrote: Enabling in-

Re: [PATCH v1] Bluetooth: hci_qca: wait for Pre shutdown to command complete event before sending the Power off pulse

2019-08-08 Thread Balakrishna Godavarthi
pre shutdown command */ qca_send_pre_shutdown_cmd(hdev); + usleep_range(8000, 1); + qca_power_shutdown(hu); return 0; } Reviewed-by: Balakrishna Godavarthi -- Regards Balakrishna.

Re: [PATCH] Bluetooth: btqca: release_firmware after qca_inject_cmd_complete_event

2019-08-06 Thread Balakrishna Godavarthi
*hdev, */ if (config->dnld_type == ROME_SKIP_EVT_VSE_CC || config->dnld_type == ROME_SKIP_EVT_VSE) - return qca_inject_cmd_complete_event(hdev); + ret = qca_inject_cmd_complete_event(hdev); out: release_firmware(fw); Change look fine to me. Reviewed-by: Balakrishna Godavarthi -- Regards Balakrishna.

Re: [PATCH v8] Bluetooth: btqca: inject command complete event during fw download

2019-04-30 Thread Balakrishna Godavarthi
Hi Harish, On 2019-04-30 21:08, Matthias Kaehlcke wrote: On Tue, Apr 30, 2019 at 02:27:33PM +0800, kbuild test robot wrote: Hi Matthias, Thank you for the patch! Yet something to improve: [auto build test ERROR on bluetooth-next/master] [also build test ERROR on next-20190429] [cannot apply t

Re: [PATCH v3 1/2] Bluetooth: hci_qca: Rename STATE_ to QCA_

2019-04-30 Thread Balakrishna Godavarthi
LED, &qca->flags); + clear_bit(QCA_IBS_ENABLED, &qca->flags); qca_flush(hu); spin_unlock_irqrestore(&qca->hci_ibs_lock, flags); Change looks fine to me. Reviewed-by: Balakrishna Godavarthi -- Regards Balakrishna.

Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

2019-04-24 Thread Balakrishna Godavarthi
it controller UNCONFIGURED state. This patch enables the normal flow even if the BD address is missing from the dts tree. Signed-off-by: Balakrishna Godavarthi --- net/bluetooth/hci_core.c | 2 -- 1 file changed, 2 deletions(-) can I get an ACK for this one? Regards Marcel nit: it would be

[RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

2019-04-18 Thread Balakrishna Godavarthi
: Balakrishna Godavarthi --- net/bluetooth/hci_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index d6b2540ba7f8..3d9175f130b3 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c @@ -1460,8 +1460,6 @@ static int

[RFC PATCH v3] Bluetooth: hci_qca: Collect controller memory dump during SSR

2019-04-16 Thread Balakrishna Godavarthi
reason into a memory buffer which application processor can retrieve afterwards. SW developers can often provide initial investigation by looking into that debugging information. Signed-off-by: Balakrishna Godavarthi --- changes v3: * used wakeup helper instead of polling while collecting dump

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

2019-04-04 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-04-03 21:44, Matthias Kaehlcke wrote: On Wed, Apr 03, 2019 at 11:53:26AM +0530, Balakrishna Godavarthi wrote: + Harish to update his findings on wcn3998. Mean time i will perform a regression to detect the failure. On my system it typically reproduces within a few dozen

Re: [PATCH v2 1/2] Bluetooth: hci_qca: Load customized NVM based on the device property

2019-04-04 Thread Balakrishna Godavarthi
Hi Rocky, On 2019-04-04 14:38, Rocky Liao wrote: QCA BTSOC nvm is a customized file and different vendor/platoform may want to have different BTSOC configuration via this file (e.g. Configure SCO over PCM or I2S, Setting Tx power, etc.) This patch will allow vendors to download different nvm f

Re: [PATCH] Bluetooth: hci_qca: Load customized NVM based on the device property

2019-04-03 Thread Balakrishna Godavarthi
Hi Rocky, On 2019-04-04 12:07, Rocky Liao wrote: QCA BTSOC nvm is a customized file and different vendor/platoform may want to have different BTSOC configuration via this file (e.g. Configure SCO over PCM or I2S, Setting Tx power, etc.) This patch will allow vendors to download different nvm f

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

2019-04-02 Thread Balakrishna Godavarthi
+ Harish to update his findings on wcn3998. Mean time i will perform a regression to detect the failure. On 2019-04-02 23:35, Matthias Kaehlcke wrote: On Tue, Apr 02, 2019 at 05:32:54PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2019-04-01 22:42, Matthias Kaehlcke wrote: > On

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

2019-04-02 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-04-01 22:42, Matthias Kaehlcke wrote: On Mon, Apr 01, 2019 at 01:48:23PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2019-04-01 13:29, Balakrishna Godavarthi wrote: > Hi Matthias, > > Sorry for the late reply i was on vacation. > > On 2019-03-08

[PATCH v2] Bluetooth: hci_qca: Give enough time to ROME controller to bootup.

2019-04-01 Thread Balakrishna Godavarthi
This patch enables enough time to ROME controller to bootup after we bring the enable pin out of reset. Fixes: 05ba533c5c11 ("Bluetooth: hci_qca: Add serdev support"). Signed-off-by: Balakrishna Godavarthi Reviewed-by: Rocky Liao Tested-by: Rocky Liao Tested-by: Claire Chang --- Cha

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

2019-04-01 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-04-01 13:29, Balakrishna Godavarthi wrote: Hi Matthias, Sorry for the late reply i was on vacation. On 2019-03-08 05:00, Matthias Kaehlcke wrote: On Thu, Mar 07, 2019 at 10:20:09AM -0800, Matthias Kaehlcke wrote: Hi Balakrishna, On Thu, Mar 07, 2019 at 10:35:08AM +0530

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

2019-04-01 Thread Balakrishna Godavarthi
Hi Matthias, Sorry for the late reply i was on vacation. On 2019-03-08 05:00, Matthias Kaehlcke wrote: On Thu, Mar 07, 2019 at 10:20:09AM -0800, Matthias Kaehlcke wrote: Hi Balakrishna, On Thu, Mar 07, 2019 at 10:35:08AM +0530, Balakrishna Godavarthi wrote: > hi Matthias, > > On 2

Re: [PATCH v2 1/2] Bluetooth: hci_qca: Rename STATE_ to QCA_

2019-04-01 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-03-13 02:12, Matthias Kaehlcke wrote: Rename STATE_IN_BAND_SLEEP_ENABLED to QCA_IN_BAND_SLEEP_ENABLED. The constant represents a flag (multiple flags can be set at once), not a unique state of the controller or driver. Also make the flag an enum value instead of a pre-proce

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-01 Thread Balakrishna Godavarthi
t;) Reported-by: Balakrishna Godavarthi Reported-by: Rocky Liao Signed-off-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 4ea995d610d2..714a6a16f9d5 100644 --- a/dr

Re: [PATCH v6 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-03-27 Thread Balakrishna Godavarthi
ice *serdev) static const struct of_device_id qca_bluetooth_of_match[] = { { .compatible = "qcom,qca6174-bt" }, - { .compatible = "qcom,wcn3990-bt", .data = &qca_soc_data}, + { .compatible = "qcom,wcn3990-bt", .data = &qca_soc_data_wcn3990}, + { .compatible = "qcom,wcn3998-bt", .data = &qca_soc_data_wcn3998}, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, qca_bluetooth_of_match); Reviewed-by: Balakrishna Godavarthi -- Regards Balakrishna.

Re: [PATCH v1] Bluetooth: hci_qca: Enable the ldisc for ROME for x86 platforms.

2019-03-07 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-03-08 02:12, Matthias Kaehlcke wrote: Hi Balakrishna, On Thu, Mar 07, 2019 at 03:47:22PM +0530, Balakrishna Godavarthi wrote: When using btattach to setup Rome over ldisc we observed a crash in qca_setup as it will try to access the serdev which is not available in the

[PATCH v1] Bluetooth: hci_qca: Enable the ldisc for ROME for x86 platforms.

2019-03-07 Thread Balakrishna Godavarthi
When using btattach to setup Rome over ldisc we observed a crash in qca_setup as it will try to access the serdev which is not available in the ldisc proto. This patch will fix the crash by support both the ldisc and serdev way in the qca hci_uart driver. Signed-off-by: Balakrishna Godavarthi

Re: [PATCH v1] Bluetooth: hci_qca: Give enough time to ROME controller to bootup.

2019-03-06 Thread Balakrishna Godavarthi
Hi Stepen, On 2019-03-07 04:03, Stephen Boyd wrote: Quoting Balakrishna Godavarthi (2019-03-06 08:21:13) This patch enables enough time to ROME controller to bootup after we bring the enable ping out of reset. Signed-off-by: Balakrishna Godavarthi --- Any Fixes tag? And maybe some more

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

2019-03-06 Thread Balakrishna Godavarthi
hi Matthias, On 2019-03-07 06:10, Matthias Kaehlcke wrote: Firmware download to the WCN3990 often fails with a 'TLV response size mismatch' error: [ 133.064659] Bluetooth: hci0: setting up wcn3990 [ 133.489150] Bluetooth: hci0: QCA controller version 0x02140201 [ 133.495245] Bluetooth: hci0:

Re: [PATCH 1/2] Bluetooth: hci_qca: Rename STATE_ to QCA_

2019-03-06 Thread Balakrishna Godavarthi
tatic void qca_power_shutdown(struct hci_uart *hu) * data in skb's. */ spin_lock_irqsave(&qca->hci_ibs_lock, flags); - clear_bit(STATE_IN_BAND_SLEEP_ENABLED, &qca->flags); + clear_bit(QCA_IN_BAND_SLEEP_ENABLED, &qca->flags);

Fw files for QCA BT Chip QCA6174

2019-03-06 Thread Balakrishna Godavarthi
c99beda7e0368961d024ddc8e45a46f118100cc7: QCA: Add the fw files for BT Chip QCA6174. (2019-02-25 15:36:36 +0530) Balakrishna Godavarthi (1): QCA: Add the fw files for BT Chip QCA6174. WHENCE| 2 ++ qca/nvm_00440302.bin

[PATCH v1] Bluetooth: hci_qca: Give enough time to ROME controller to bootup.

2019-03-06 Thread Balakrishna Godavarthi
This patch enables enough time to ROME controller to bootup after we bring the enable ping out of reset. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index

Re: [PATCH] Bluetooth: hci_qca: Remove redundant initializations to zero

2019-03-05 Thread Balakrishna Godavarthi
->votes_off = 0; - qca->tx_votes_on = 0; - qca->tx_votes_off = 0; - qca->rx_votes_on = 0; - qca->rx_votes_off = 0; hu->priv = qca; Reviewed-by: Balakrishna Godavarthi -- Regards Balakrishna.

Re: [PATCH 2/3] Bluetooth: hci_qca: Move boot delay to qca_send_power_pulse()

2019-02-26 Thread Balakrishna Godavarthi
hi Matthias, On 2019-02-26 17:48, Balakrishna Godavarthi wrote: On 2019-02-26 05:19, Matthias Kaehlcke wrote: After sending a power on pulse the driver has a delay of 100ms to allow the host controller to boot. Move the delay into qca_send_power_pulse(), since it is directly related with the

Re: [PATCH 3/3] Bluetooth: hci_qca: Add delay after power-off pulse

2019-02-26 Thread Balakrishna Godavarthi
) usleep_range(100, 200); hci_uart_set_flow_control(hu, false); + /* Give to controller time to boot/shutdown */ if (on) msleep(100); + else + msleep(10); return 0; } Reviewed-by: Balakrishna Godavarthi -- Regards

Re: [PATCH 2/3] Bluetooth: hci_qca: Move boot delay to qca_send_power_pulse()

2019-02-26 Thread Balakrishna Godavarthi
) return ret; - /* Wait for 100 ms for SoC to boot */ - msleep(100); - /* Now the device is in ready state to communicate with host. * To sync host with device we need to reopen port. * Without this, we will have RTS and CTS synchronization Reviewed-by: Balakrishna

Re: [PATCH 1/3] Bluetooth: hci_qca: Pass boolean 'on/off' to qca_send_power_pulse()

2019-02-26 Thread Balakrishna Godavarthi
; host_set_baudrate(hu, 2400); - qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE); + qca_send_power_pulse(hu, false); qca_power_setup(hu, false); } Reviewed-by: Balakrishna Godavarthi -- Regards Balakrishna.

Fw files for QCA BT Chip QCA6174

2019-02-25 Thread Balakrishna Godavarthi
c99beda7e0368961d024ddc8e45a46f118100cc7: QCA: Add the fw files for BT Chip QCA6174. (2019-02-25 15:36:36 +0530) Balakrishna Godavarthi (1): QCA: Add the fw files for BT Chip QCA6174. WHENCE| 2 ++ qca/nvm_00440302.bin

Firmware files for QCA BT chip wcn3990

2019-02-20 Thread Balakrishna Godavarthi
f859d9fda9379205c9bcf2eab11fae68891085ee: qca: Add firmware files for BT chip wcn3990. (2019-02-20 18:23:46 +0530) Balakrishna Godavarthi (1): qca: Add firmware files for BT chip wcn3990. WHENCE | 2 + qca

[PATCH v1] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990

2019-02-20 Thread Balakrishna Godavarthi
-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 5e03504c4e0c..22f3c983f868 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth

Re: Firmware files for QCA BT chip WCN3990.

2019-02-18 Thread Balakrishna Godavarthi
Hi Nicolas, On 2019-02-18 14:08, Nicolas Dechesne wrote: hi Balakrishna, On Mon, Feb 18, 2019 at 7:13 AM Balakrishna Godavarthi wrote: Hi, The following changes since commit a9c22d3d8af87bd39a078ec6c846b0674dd2ca38: qca: Add firmware files for BT chip wcn3990. (2019-02-15 16:07:56

Firmware files for QCA BT chip WCN3990.

2019-02-17 Thread Balakrishna Godavarthi
Hi, The following changes since commit a9c22d3d8af87bd39a078ec6c846b0674dd2ca38: qca: Add firmware files for BT chip wcn3990. (2019-02-15 16:07:56 +0530) are available in the Git repository at: https://github.com/bgodavar/qca_bt_wcn3990_fw.git for you to fetch changes up to a9c22d3d

[PATCH v11 0/3] Bug fixes for Qualcomm BT chip wcn3990

2019-02-04 Thread Balakrishna Godavarthi
serdev_device_write_buf() instead of serdev_device_write(). * added new patch to stop logging of 0xfc00 timeout on console. Changes in v3: * moved IBS & qca_flush to different patch * updated comments in code fo Deassert RTS patch Balakrishna Godavarthi (3): Bluetooth: hci_qca: use wait_until_sent()

[PATCH v11 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-02-04 Thread Balakrishna Godavarthi
issues. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- Changes in v10: Updated the wait time to 100 us for power pules. --- drivers/bluetooth/hci_qca.c | 38 +++-- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers

[PATCH v11 3/3] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer

2019-02-04 Thread Balakrishna Godavarthi
During hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is powered off. This patch will disable IBS and flush the Tx buffer before we turn off the chip. Signed-off-by: Balakrishna Godavarthi

[PATCH v11 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-02-04 Thread Balakrishna Godavarthi
with newer baudrate, On host side we are still operating in 115200 bps which results of reading garbage data. Here we are pulling RTS line, so that chip we will wait to send data to host until host change its baudrate. Signed-off-by: Balakrishna Godavarthi Tested-by: Matthias Kaehlcke Reviewed

[PATCH v10 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-02-04 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi This patch will help to stop frame reassembly errors while changing the baudrate. This is because host send a change baudrate request command to the chip with 115200 bps, Whereas chip will change their UART clocks to the enable for new baudrate and sends the response

[PATCH v10 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-02-04 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing these commands. This is causing synchronization issues with chip, which intern delay the chip setup or

[PATCH v10 0/3] Bug fixes for Qualcomm BT chip wcn3990.

2019-02-04 Thread Balakrishna Godavarthi
patch to stop logging of 0xfc00 timeout on console. Changes in v3: * moved IBS & qca_flush to different patch * updated comments in code fo Deassert RTS patch Balakrishna Godavarthi (3): Bluetooth: hci_qca: use wait_until_sent() for power pulses Bluetooth: hci_qca: Deassert RTS while baud

[PATCH v10 3/3] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer

2019-02-04 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi During hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is powered off. This patch will disable IBS and flush the Tx buffer before we turn off the chip. Signed

Re: [PATCH v9 3/3] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer

2019-02-01 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-25 06:25, Matthias Kaehlcke wrote: On Thu, Jan 24, 2019 at 05:38:08PM +0530, Balakrishna Godavarthi wrote: During hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is

Re: [PATCH v9 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-29 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-28 23:17, Matthias Kaehlcke wrote: On Mon, Jan 28, 2019 at 07:19:56PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2019-01-25 06:44, Matthias Kaehlcke wrote: > On Thu, Jan 24, 2019 at 05:38:06PM +0530, Balakrishna Godavarthi wrote: > > wcn3990 require

Re: [PATCH v9 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-28 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-25 06:44, Matthias Kaehlcke wrote: On Thu, Jan 24, 2019 at 05:38:06PM +0530, Balakrishna Godavarthi wrote: wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing

Re: [PATCH v9 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-28 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-25 05:42, Matthias Kaehlcke wrote: Hi Balakrishna, On Thu, Jan 24, 2019 at 05:38:07PM +0530, Balakrishna Godavarthi wrote: This patch will help to stop frame reassembly errors while changing the baudrate. This is because host send a change baudrate request command to

[PATCH v9 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-24 Thread Balakrishna Godavarthi
with newer baudrate, On host side we are still operating in 115200 bps which results of reading garbage data. Here we are pulling RTS line, so that chip we will wait to send data to host until host change its baudrate. Signed-off-by: Balakrishna Godavarthi Tested-by: Matthias Kaehlcke Reviewed

[PATCH v9 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-24 Thread Balakrishna Godavarthi
issues. Signed-off-by: Balakrishna Godavarthi --- Changes in v9: * Reverted to 100us sleep. * used inline call msecs_to_jiffies() Changes in v8: * Updated 1 second timeout instead of indefinite wait. Changes in v7: * updated the wait time to 5 ms after sending power pulses. Changes in v6

[PATCH v9 3/3] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer

2019-01-24 Thread Balakrishna Godavarthi
During hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is powered off. This patch will disable IBS and flush the Tx buffer before we turn off the chip. Signed-off-by: Balakrishna Godavarthi

[PATCH v9 0/3] Bug fixes for Qualcomm BT chip wcn3990.

2019-01-24 Thread Balakrishna Godavarthi
during shutdown. Changes in v4: * used serdev_device_write_buf() instead of serdev_device_write(). * added new patch to stop logging of 0xfc00 timeout on console. Changes in v3: * moved IBS & qca_flush to different patch * updated comments in code fo Deassert RTS patch Balakrishna Godava

Re: [PATCH v8 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-24 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-17 01:52, Matthias Kaehlcke wrote: On Wed, Jan 16, 2019 at 05:16:01PM +0530, Balakrishna Godavarthi wrote: wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-23 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-23 03:23, Matthias Kaehlcke wrote: On Mon, Jan 21, 2019 at 08:11:39PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2019-01-19 06:01, Matthias Kaehlcke wrote: > On Fri, Jan 18, 2019 at 10:44:16AM +0100, Johan Hovold wrote: > > On Thu, Jan 17, 2019 at 0

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-21 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-19 06:01, Matthias Kaehlcke wrote: On Fri, Jan 18, 2019 at 10:44:16AM +0100, Johan Hovold wrote: On Thu, Jan 17, 2019 at 09:21:09AM -0800, Matthias Kaehlcke wrote: > I observed that the qcom_geni_serial driver doesn't raise RTS with > flow control disabled. It seems we

Re: [RFC,v2] Bluetooth: hci_qca: Collect controller memory dump during SSR

2019-01-21 Thread Balakrishna Godavarthi
subsystem or a process to perform proper cache dump and software failure reason into a memory buffer which application processor can retrieve afterwards. SW developers can often provide initial investigation by looking into that debugging information. Signed-off-by: Balakrishna Godavarthi

Re: [PATCH v8 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-17 Thread Balakrishna Godavarthi
On 2019-01-17 21:43, Johan Hovold wrote: On Thu, Jan 17, 2019 at 03:55:17PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2019-01-17 01:52, Matthias Kaehlcke wrote: >> - /* Wait for 100 uS for SoC to settle down */ >> - usleep_ra

Re: [PATCH v8 3/3] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer

2019-01-17 Thread Balakrishna Godavarthi
On 2019-01-17 04:38, Matthias Kaehlcke wrote: On Wed, Jan 16, 2019 at 05:16:03PM +0530, Balakrishna Godavarthi wrote: During hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is powered off

Re: [PATCH v8 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-17 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-17 01:52, Matthias Kaehlcke wrote: On Wed, Jan 16, 2019 at 05:16:01PM +0530, Balakrishna Godavarthi wrote: wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing

Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2019-01-17 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-17 01:27, Matthias Kaehlcke wrote: On Wed, Jan 16, 2019 at 03:06:29PM +0530, Balakrishna Godavarthi wrote: On 2019-01-15 06:50, Matthias Kaehlcke wrote: > On Mon, Jan 14, 2019 at 09:21:25PM +0530, Balakrishna Godavarthi wrote: > > On 2019-01-12 04:42, Matthias

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: Add WCN3990 BT node

2019-01-16 Thread Balakrishna Godavarthi
Hi Anderson, On 2019-01-17 10:10, Bjorn Andersson wrote: The SDM845 MTP has a WCN3990 Bluetooth chip on UART6, enable this. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 44 + 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot

Re: [RFC,v2] Bluetooth: hci_qca: Collect controller memory dump during SSR

2019-01-16 Thread Balakrishna Godavarthi
subsystem or a process to perform proper cache dump and software failure reason into a memory buffer which application processor can retrieve afterwards. SW developers can often provide initial investigation by looking into that debugging information. Signed-off-by: Balakrishna Godavarthi

[RESEND v2] Bluetooth: hci_qca: Add helper to set device address

2019-01-16 Thread Balakrishna Godavarthi
This patch add qca_set_bdaddr() to set the device address for latest Qualcomm Bluetooth chipset wcn3990 and above. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 19 +++ drivers/bluetooth

[PATCH v8 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-16 Thread Balakrishna Godavarthi
issues. Signed-off-by: Balakrishna Godavarthi --- Changes in v8: * Updated 1 second timeout instead of indefinite wait. Changes in v7: * updated the wait time to 5 ms after sending power pulses. Changes in v6: * added serdev_device_write_flush() in qca_send_power_pulse instead during the

[PATCH v8 3/3] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer

2019-01-16 Thread Balakrishna Godavarthi
During hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is powered off. This patch will disable IBS and flush the Tx buffer before we turn off the chip. Signed-off-by: Balakrishna Godavarthi

[PATCH v8 0/3] Bug fixes for Qualcomm BT chip wcn3990.

2019-01-16 Thread Balakrishna Godavarthi
rent patch * updated comments in code fo Deassert RTS patch Balakrishna Godavarthi (3): Bluetooth: hci_qca: use wait_until_sent() for power pulses Bluetooth: hci_qca: Deassert RTS while baudrate change command Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer drivers/bluet

[PATCH v8 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-16 Thread Balakrishna Godavarthi
with newer baudrate, On host side we are still operating in 115200 bps which results of reading garbage data. Here we are pulling RTS line, so that chip we will wait to send data to host until host change its baudrate. Signed-off-by: Balakrishna Godavarthi Tested-by: Matthias Kaehlcke Reviewed

Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2019-01-16 Thread Balakrishna Godavarthi
On 2019-01-15 06:50, Matthias Kaehlcke wrote: On Mon, Jan 14, 2019 at 09:21:25PM +0530, Balakrishna Godavarthi wrote: On 2019-01-12 04:42, Matthias Kaehlcke wrote: > On Fri, Jan 11, 2019 at 07:53:43PM +0530, Balakrishna Godavarthi wrote: > > Hi Matthias, > > > > On 2019-

Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2019-01-14 Thread Balakrishna Godavarthi
On 2019-01-12 04:42, Matthias Kaehlcke wrote: On Fri, Jan 11, 2019 at 07:53:43PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2019-01-11 02:13, Matthias Kaehlcke wrote: > Hi Balakrishna, > > On Thu, Jan 10, 2019 at 08:30:43PM +0530, Balakrishna Godavarthi wrote: > &

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-14 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-12 05:26, Matthias Kaehlcke wrote: On Fri, Jan 11, 2019 at 08:37:12PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2019-01-11 07:07, Matthias Kaehlcke wrote: > On Thu, Jan 10, 2019 at 08:22:12PM +0530, Balakrishna Godavarthi wrote: > > Hi Johan, > &

Re: [PATCH v5 1/5] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-14 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-12 05:08, Matthias Kaehlcke wrote: On Fri, Jan 11, 2019 at 08:02:00PM +0530, Balakrishna Godavarthi wrote: On 2019-01-11 06:25, Matthias Kaehlcke wrote: > On Thu, Jan 10, 2019 at 08:18:37PM +0530, Balakrishna Godavarthi wrote: > > Hi Johan, > > > >

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-11 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-11 07:07, Matthias Kaehlcke wrote: On Thu, Jan 10, 2019 at 08:22:12PM +0530, Balakrishna Godavarthi wrote: Hi Johan, On 2019-01-10 20:09, Johan Hovold wrote: > On Thu, Jan 10, 2019 at 08:04:12PM +0530, Balakrishna Godavarthi wrote: > > Hi Johan, > > &g

Re: [PATCH v5 1/5] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-11 Thread Balakrishna Godavarthi
On 2019-01-11 06:25, Matthias Kaehlcke wrote: On Thu, Jan 10, 2019 at 08:18:37PM +0530, Balakrishna Godavarthi wrote: Hi Johan, On 2019-01-09 20:08, Johan Hovold wrote: > On Fri, Dec 21, 2018 at 05:59:47PM -0800, Matthias Kaehlcke wrote: > > On Thu, Dec 20, 2018 at 08:16:3

Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2019-01-11 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-11 02:13, Matthias Kaehlcke wrote: Hi Balakrishna, On Thu, Jan 10, 2019 at 08:30:43PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2019-01-03 03:45, Matthias Kaehlcke wrote: > On Mon, Dec 31, 2018 at 11:34:46AM +0530, Balakrishna Godavarthi wrote: >

Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2019-01-10 Thread Balakrishna Godavarthi
Hi Matthias, On 2019-01-03 03:45, Matthias Kaehlcke wrote: On Mon, Dec 31, 2018 at 11:34:46AM +0530, Balakrishna Godavarthi wrote: Hi Marcel, On 2018-12-30 13:40, Marcel Holtmann wrote: > Hi Balakrishna, > > > > > Latest qualcomm chips are not sending an command

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-10 Thread Balakrishna Godavarthi
Hi Johan, On 2019-01-10 20:09, Johan Hovold wrote: On Thu, Jan 10, 2019 at 08:04:12PM +0530, Balakrishna Godavarthi wrote: Hi Johan, On 2019-01-09 20:22, Johan Hovold wrote: > On Thu, Dec 20, 2018 at 08:16:36PM +0530, Balakrishna Godavarthi wrote: >> This patch will help to s

Re: [PATCH v5 1/5] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2019-01-10 Thread Balakrishna Godavarthi
Hi Johan, On 2019-01-09 20:08, Johan Hovold wrote: On Fri, Dec 21, 2018 at 05:59:47PM -0800, Matthias Kaehlcke wrote: On Thu, Dec 20, 2018 at 08:16:35PM +0530, Balakrishna Godavarthi wrote: > wcn3990 requires a power pulse to turn ON/OFF along with > regulators. Sometimes we are observi

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-10 Thread Balakrishna Godavarthi
Hi Johan, On 2019-01-09 20:22, Johan Hovold wrote: On Thu, Dec 20, 2018 at 08:16:36PM +0530, Balakrishna Godavarthi wrote: This patch will help to stop frame reassembly errors while changing the baudrate. This is because host send a change baudrate request command to the chip with 115200 bps

Re: [RESEND, v2] Bluetooth: hci_qca: Add helper to set device address

2019-01-07 Thread Balakrishna Godavarthi
Hi Marcel, On 2018-12-28 17:37, Balakrishna Godavarthi wrote: This patch add qca_set_bdaddr() to set the device address for latest Qualcomm Bluetooth chipset wcn3990 and above. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- drivers

Re: [RFC,v2] Bluetooth: hci_qca: Collect controller memory dump during SSR

2019-01-03 Thread Balakrishna Godavarthi
subsystem or a process to perform proper cache dump and software failure reason into a memory buffer which application processor can retrieve afterwards. SW developers can often provide initial investigation by looking into that debugging information. Signed-off-by: Balakrishna Godavarthi

Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2018-12-31 Thread Balakrishna Godavarthi
Hi Marcel, On 2018-12-31 11:34, Balakrishna Godavarthi wrote: Hi Marcel, On 2018-12-30 13:40, Marcel Holtmann wrote: Hi Balakrishna, Latest qualcomm chips are not sending an command complete event for every firmware packet sent to chip. They only respond with a vendor specific event for the

Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2018-12-30 Thread Balakrishna Godavarthi
time. Due to this we are seeing a timeout error message logs on the console during firmware download. Now we are injecting a command complete event once we receive an vendor specific event for the last RAM firmware packet. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/btqca.c | 39

Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2018-12-28 Thread Balakrishna Godavarthi
time. Due to this we are seeing a timeout error message logs on the console during firmware download. Now we are injecting a command complete event once we receive an vendor specific event for the last RAM firmware packet. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/btqca.c | 39

[RFC,v2] Bluetooth: hci_qca: Collect controller memory dump during SSR

2018-12-28 Thread Balakrishna Godavarthi
reason into a memory buffer which application processor can retrieve afterwards. SW developers can often provide initial investigation by looking into that debugging information. Signed-off-by: Balakrishna Godavarthi --- changes v2: * entirely an newer approach handling with an work queue

[RESEND, v2] Bluetooth: hci_qca: Add helper to set device address

2018-12-28 Thread Balakrishna Godavarthi
This patch add qca_set_bdaddr() to set the device address for latest Qualcomm Bluetooth chipset wcn3990 and above. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 19 +++ drivers/bluetooth

[PATCH v7 3/4] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer

2018-12-28 Thread Balakrishna Godavarthi
During hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is powered off. This patch will disable IBS and flush the Tx buffer before we turn off the chip. Signed-off-by: Balakrishna Godavarthi

[PATCH v7 2/4] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2018-12-28 Thread Balakrishna Godavarthi
with newer baudrate, On host side we are still operating in 115200 bps which results of reading garbage data. Here we are pulling RTS line, so that chip we will wait to send data to host until host change its baudrate. Signed-off-by: Balakrishna Godavarthi Tested-by: Matthias Kaehlcke Reviewed

[PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download

2018-12-28 Thread Balakrishna Godavarthi
during firmware download. Now we are injecting a command complete event once we receive an vendor specific event for the last RAM firmware packet. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/btqca.c | 39 ++- drivers/bluetooth/btqca.h | 3

[PATCH v7 0/4] Bug fixes for Qualcomm BT chip wcn3990.

2018-12-28 Thread Balakrishna Godavarthi
serdev_device_write_buf() instead of serdev_device_write(). * added new patch to stop logging of 0xfc00 timeout on console. Changes in v3: * moved IBS & qca_flush to different patch * updated comments in code fo Deassert RTS patch Balakrishna Godavarthi (4): Bluetooth: hci_qca: use wait_until_sent() for p

[PATCH v7 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2018-12-28 Thread Balakrishna Godavarthi
issues. Signed-off-by: Balakrishna Godavarthi --- Changes in v7: * updated the wait time to 5 ms after sending power pulses. Changes in v6: * added serdev_device_write_flush() in qca_send_power_pulse instead during the power off pulse. Changes in v5: * added serdev_device_write_flush() in

Re: [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990

2018-12-28 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-12-28 02:30, Matthias Kaehlcke wrote: On Thu, Dec 27, 2018 at 01:01:35PM +0530, Balakrishna Godavarthi wrote: This patch will update the baudrate change request wait time from 300 ms to 100 ms. When host sends the change baudrate request to the controller, controller sets

Re: [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990

2018-12-27 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-12-28 01:55, Matthias Kaehlcke wrote: On Thu, Dec 27, 2018 at 01:01:33PM +0530, Balakrishna Godavarthi wrote: During initalization of wcn3990, we observed UART is reading some stray bytes on the Rx line. This is logging Frame reassembly errors on the serial console. This

  1   2   3   >