[PATCH] staging: panel: fix regression in lcd_write

2014-04-23 Thread Bastien Armand
This patch fix a regression in lcd_write caused by commit 70a8c3eb8546cefe40fb0bc7991e8899b7b91075 Signed-off-by: Bastien Armand --- drivers/staging/panel/panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-23 Thread Bastien Armand
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: > Out of curiosity, have you tested this patch? > > On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote: > > This patch fixes two sparse warnings related to lcd_write : > > warning: incorrect type in

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-23 Thread Bastien Armand
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: Out of curiosity, have you tested this patch? On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote: This patch fixes two sparse warnings related to lcd_write : warning: incorrect type in argument 1 (different address

[PATCH] staging: panel: fix regression in lcd_write

2014-04-23 Thread Bastien Armand
This patch fix a regression in lcd_write caused by commit 70a8c3eb8546cefe40fb0bc7991e8899b7b91075 Signed-off-by: Bastien Armand armand.bast...@laposte.net --- drivers/staging/panel/panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/panel/panel.c b

[PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-18 Thread Bastien Armand
. So we introduce the lcd_write_char function that will write a char to the device. We modify lcd_write and panel_lcd_print to use it. Finally we add __user annotation missing in lcd_write. Signed-off-by: Bastien Armand --- drivers/staging/panel/panel.c | 205

[PATCH v2 1/2] staging: panel: fix sparse warnings in keypad_read

2014-04-18 Thread Bastien Armand
This patch fixes two sparse warnings related to keypad_read : warning: incorrect type in argument 1 (different address spaces) warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) Signed-off-by: Bastien Armand --- drivers/staging/panel/panel.c |4

[PATCH v2 0/2] staging: panel: fix sparse warnings.

2014-04-18 Thread Bastien Armand
: - splitted patch in two Bastien Armand (2): staging: panel: fix sparse warnings in keypad_read staging: panel: fix sparse warnings in lcd_write drivers/staging/panel/panel.c | 209 ++--- 1 file changed, 111 insertions(+), 98 deletions(-) -- 1.7.10.4

Re: [PATCH] staging: panel: fix sparse warnings

2014-04-18 Thread Bastien Armand
On Thu, Apr 17, 2014 at 11:15:10PM -0700, Greg Kroah-Hartman wrote: > On Fri, Apr 18, 2014 at 08:01:22AM +0200, Bastien Armand wrote: > > This patch fixes sparse warnings in panel.c. > > What sparse warnings were fixed here? > > It looks like you did a lot of different t

[PATCH] staging: panel: fix sparse warnings

2014-04-18 Thread Bastien Armand
This patch fixes sparse warnings in panel.c. Signed-off-by: Bastien Armand --- drivers/staging/panel/panel.c | 209 ++--- 1 file changed, 111 insertions(+), 98 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index

Re: [PATCH] staging: panel: fix sparse warnings

2014-04-18 Thread Bastien Armand
On Thu, Apr 17, 2014 at 11:15:10PM -0700, Greg Kroah-Hartman wrote: On Fri, Apr 18, 2014 at 08:01:22AM +0200, Bastien Armand wrote: This patch fixes sparse warnings in panel.c. What sparse warnings were fixed here? It looks like you did a lot of different things, can you please break

[PATCH v2 0/2] staging: panel: fix sparse warnings.

2014-04-18 Thread Bastien Armand
] *noident )( ... ) Changes since v1 : - splitted patch in two Bastien Armand (2): staging: panel: fix sparse warnings in keypad_read staging: panel: fix sparse warnings in lcd_write drivers/staging/panel/panel.c | 209 ++--- 1 file changed, 111 insertions(+), 98

[PATCH v2 1/2] staging: panel: fix sparse warnings in keypad_read

2014-04-18 Thread Bastien Armand
This patch fixes two sparse warnings related to keypad_read : warning: incorrect type in argument 1 (different address spaces) warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) Signed-off-by: Bastien Armand armand.bast...@laposte.net --- drivers/staging

[PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-18 Thread Bastien Armand
. So we introduce the lcd_write_char function that will write a char to the device. We modify lcd_write and panel_lcd_print to use it. Finally we add __user annotation missing in lcd_write. Signed-off-by: Bastien Armand armand.bast...@laposte.net --- drivers/staging/panel/panel.c | 205

[PATCH] staging: panel: fix sparse warnings

2014-04-18 Thread Bastien Armand
This patch fixes sparse warnings in panel.c. Signed-off-by: Bastien Armand armand.bast...@laposte.net --- drivers/staging/panel/panel.c | 209 ++--- 1 file changed, 111 insertions(+), 98 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers

[PATCH v2] staging: panel: add blank lines after declarations

2014-04-04 Thread Bastien Armand
This patch fixes "Missing a blank line after declarations" checkpatch warnings in panel.c. Signed-off-by: Bastien Armand --- drivers/staging/panel/panel.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/pan

[PATCH v2] staging: panel: add blank lines after declarations

2014-04-04 Thread Bastien Armand
This patch fixes Missing a blank line after declarations checkpatch warnings in panel.c. Signed-off-by: Bastien Armand armand.bast...@laposte.net --- drivers/staging/panel/panel.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/panel/panel.c b/drivers