Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

2016-06-15 Thread Ben Zhang
On Wed, Jun 15, 2016 at 5:44 AM, Rob Herring wrote: > On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: >> On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: >>> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: >> >>> > +sound { >>> > +

Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

2016-06-15 Thread Ben Zhang
On Wed, Jun 15, 2016 at 5:44 AM, Rob Herring wrote: > On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: >> On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: >>> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: >> >>> > +sound { >>> > + compatible =

Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-19 Thread Ben Zhang
linux/io.h is later removed from linux/irq.h. Since the irq-gic-v3 driver uses the read/write io functions, it might be better to include linux/io.h explicitly. Thanks, Ben On Wed, Aug 19, 2015 at 2:13 PM, Thomas Gleixner wrote: > On Fri, 7 Aug 2015, Ben Zhang wrote: >> Mainline build is

Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-19 Thread Ben Zhang
is later removed from linux/irq.h. Since the irq-gic-v3 driver uses the read/write io functions, it might be better to include linux/io.h explicitly. Thanks, Ben On Wed, Aug 19, 2015 at 2:13 PM, Thomas Gleixner t...@linutronix.de wrote: On Fri, 7 Aug 2015, Ben Zhang wrote: Mainline build is fine

Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-07 Thread Ben Zhang
On Fri, Aug 7, 2015 at 1:40 AM, Marc Zyngier wrote: > Hi Ben, > > On 07/08/15 06:31, Ben Zhang wrote: >> linux/io.h is needed because the driver uses: >> readl_relaxed >> writel_relaxed >> writeq_relaxed >> readq_relaxed >> iounmap >> &g

Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-07 Thread Ben Zhang
On Fri, Aug 7, 2015 at 1:40 AM, Marc Zyngier marc.zyng...@arm.com wrote: Hi Ben, On 07/08/15 06:31, Ben Zhang wrote: linux/io.h is needed because the driver uses: readl_relaxed writel_relaxed writeq_relaxed readq_relaxed iounmap The header was implicitly included by an unrelated commit

[PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-06 Thread Ben Zhang
.h include/linux/irq.h include/linux/of_irq.h drivers/irqchip/irq-gic-v3.c Signed-off-by: Ben Zhang --- drivers/irqchip/irq-gic-v3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index e406bc5..3350b8d 100644 --- a/drivers/irqchip/

[PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-06 Thread Ben Zhang
/linux/irq.h include/linux/of_irq.h drivers/irqchip/irq-gic-v3.c Signed-off-by: Ben Zhang be...@chromium.org --- drivers/irqchip/irq-gic-v3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index e406bc5..3350b8d 100644 --- a/drivers

Re: [PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks

2015-06-03 Thread Ben Zhang
On Wed, Jun 3, 2015 at 4:59 AM, Mark Brown wrote: > On Tue, Jun 02, 2015 at 03:24:03PM -0700, Ben Zhang wrote: > >> - int (*get)(unsigned int __user *bytes, unsigned int size); >> - int (*put)(const unsigned int __user *bytes, unsigned int size); >> + int (*

Re: [PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks

2015-06-03 Thread Ben Zhang
On Wed, Jun 3, 2015 at 4:59 AM, Mark Brown broo...@kernel.org wrote: On Tue, Jun 02, 2015 at 03:24:03PM -0700, Ben Zhang wrote: - int (*get)(unsigned int __user *bytes, unsigned int size); - int (*put)(const unsigned int __user *bytes, unsigned int size); + int (*get)(struct

[PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks

2015-06-02 Thread Ben Zhang
The get/put callbacks need the kcontrol pointer to get context information like snd_soc_codec and drvdata. Signed-off-by: Ben Zhang --- include/sound/soc.h | 6 -- sound/soc/soc-ops.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/sound/soc.h b/include

[PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks

2015-06-02 Thread Ben Zhang
The get/put callbacks need the kcontrol pointer to get context information like snd_soc_codec and drvdata. Signed-off-by: Ben Zhang be...@chromium.org --- include/sound/soc.h | 6 -- sound/soc/soc-ops.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/sound

[PATCH] pstore/ram: verify ramoops header before saving record

2015-03-27 Thread Ben Zhang
-by: Ben Zhang --- fs/pstore/ram.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 44a549b..e16af43 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -186,12 +186,34 @@ static ssize_t

[PATCH] pstore/ram: verify ramoops header before saving record

2015-03-27 Thread Ben Zhang
-by: Ben Zhang be...@chromium.org --- fs/pstore/ram.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 44a549b..e16af43 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -186,12 +186,34 @@ static

Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-12 Thread Ben Zhang
On Fri, Dec 12, 2014 at 5:27 AM, Mark Brown wrote: > On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote: > >> The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V > > The changelog says "platform config" but this is adding DT binding. > >

Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-12 Thread Ben Zhang
On Fri, Dec 12, 2014 at 5:27 AM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote: The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V The changelog says platform config but this is adding DT binding. +- realtek,micbias1

[PATCH 3/3] ASoC: rt5677: add a platform config option for DACREF source

2014-12-10 Thread Ben Zhang
DACREF power source can come from external 1.8V or codec internal 1.8V. This patch adds the option to enable the internal DACREF power source. Signed-off-by: Ben Zhang --- Documentation/devicetree/bindings/sound/rt5677.txt | 3 +++ include/sound/rt5677.h | 2

[PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-10 Thread Ben Zhang
The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V Signed-off-by: Ben Zhang --- Documentation/devicetree/bindings/sound/rt5677.txt | 4 include/sound/rt5677.h | 9 + sound/soc/codecs/rt5677.c | 6 ++ 3

[PATCH 1/3] ASoC: rt5677: add REGMAP_I2C and REGMAP_IRQ dependency

2014-12-10 Thread Ben Zhang
The codec driver uses regmap to do i2c read/write. The codec driver started to use REGMAP_IRQ since: 5e3363ad1b7b2e1f197a3f56b01e21cb155ad454 ASoC: rt5677: add GPIO IRQ support Signed-off-by: Ben Zhang --- sound/soc/codecs/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc

[PATCH 1/3] ASoC: rt5677: add REGMAP_I2C and REGMAP_IRQ dependency

2014-12-10 Thread Ben Zhang
The codec driver uses regmap to do i2c read/write. The codec driver started to use REGMAP_IRQ since: 5e3363ad1b7b2e1f197a3f56b01e21cb155ad454 ASoC: rt5677: add GPIO IRQ support Signed-off-by: Ben Zhang be...@chromium.org --- sound/soc/codecs/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-10 Thread Ben Zhang
The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V Signed-off-by: Ben Zhang be...@chromium.org --- Documentation/devicetree/bindings/sound/rt5677.txt | 4 include/sound/rt5677.h | 9 + sound/soc/codecs/rt5677.c

[PATCH 3/3] ASoC: rt5677: add a platform config option for DACREF source

2014-12-10 Thread Ben Zhang
DACREF power source can come from external 1.8V or codec internal 1.8V. This patch adds the option to enable the internal DACREF power source. Signed-off-by: Ben Zhang be...@chromium.org --- Documentation/devicetree/bindings/sound/rt5677.txt | 3 +++ include/sound/rt5677.h

Re: [PATCH 1/2] ASoC: rt5677: Add ACPI device probing

2014-11-25 Thread Ben Zhang
+Duncan who works on our firmware project. Please correct me if I'm wrong. Here is the summary of what I understand. Looks like the recommended practice for passing device platform data is using _DSD and the new device_property_read_ API from include/linux/property.h For example, the firmware

Re: [PATCH 1/2] ASoC: rt5677: Add ACPI device probing

2014-11-25 Thread Ben Zhang
+Duncan who works on our firmware project. Please correct me if I'm wrong. Here is the summary of what I understand. Looks like the recommended practice for passing device platform data is using _DSD and the new device_property_read_ API from include/linux/property.h For example, the firmware

[PATCH 2/2] ASoC: rt5677: add a platform config option for PDM clock divider

2014-11-14 Thread Ben Zhang
The PDM output clock can use a divider of 1/2/3/4 based on the system clock Signed-off-by: Ben Zhang --- Documentation/devicetree/bindings/sound/rt5677.txt | 5 + include/sound/rt5677.h | 8 sound/soc/codecs/rt5677.c | 7

[PATCH 1/2] ASoC: rt5677: Add ACPI device probing

2014-11-14 Thread Ben Zhang
The rt5677 codec driver looks for ACPI device ID "RT5677CE", which is specified in coreboot. This patch allows platform data to be obtained via ACPI Signed-off-by: Ben Zhang --- sound/soc/codecs/rt5677.c | 52 +-- 1 file changed, 50 insert

[PATCH 2/2] ASoC: rt5677: add a platform config option for PDM clock divider

2014-11-14 Thread Ben Zhang
The PDM output clock can use a divider of 1/2/3/4 based on the system clock Signed-off-by: Ben Zhang be...@chromium.org --- Documentation/devicetree/bindings/sound/rt5677.txt | 5 + include/sound/rt5677.h | 8 sound/soc/codecs/rt5677.c

[PATCH 1/2] ASoC: rt5677: Add ACPI device probing

2014-11-14 Thread Ben Zhang
The rt5677 codec driver looks for ACPI device ID RT5677CE, which is specified in coreboot. This patch allows platform data to be obtained via ACPI Signed-off-by: Ben Zhang be...@chromium.org --- sound/soc/codecs/rt5677.c | 52 +-- 1 file changed, 50

[PATCH] pstore/ram: strip ramoops header for correct decompression

2014-10-30 Thread Ben Zhang
the first "==" as a zlib header, so the decompression always fails. For example, this causes the driver to write /dev/pstore/dmesg-ramoops-0.enc.z instead of /dev/pstore/dmesg-ramoops-0. This patch makes the ramoops driver remove the header before pstore decompression. Signed-off-by: Ben Zhang ---

[PATCH] pstore/ram: strip ramoops header for correct decompression

2014-10-30 Thread Ben Zhang
header, so the decompression always fails. For example, this causes the driver to write /dev/pstore/dmesg-ramoops-0.enc.z instead of /dev/pstore/dmesg-ramoops-0. This patch makes the ramoops driver remove the header before pstore decompression. Signed-off-by: Ben Zhang be...@chromium.org --- fs

[PATCH] ASoC: rt5677: fix rt5677 spi driver build

2014-10-20 Thread Ben Zhang
Create a separate module for rt5677 spi driver. Without this patch, the build fails due to multiple defs of 'init_module' and 'cleanup_module'. module_spi_driver() defines its own module, so it can't be part of the rt5677 module. Signed-off-by: Ben Zhang --- sound/soc/codecs/Kconfig | 4

[PATCH] ASoC: rt5677: fix rt5677 spi driver build

2014-10-20 Thread Ben Zhang
Create a separate module for rt5677 spi driver. Without this patch, the build fails due to multiple defs of 'init_module' and 'cleanup_module'. module_spi_driver() defines its own module, so it can't be part of the rt5677 module. Signed-off-by: Ben Zhang be...@chromium.org --- sound/soc/codecs

[PATCH 3/3] ASoC: rt5677: Add jack detection support

2014-10-03 Thread Ben Zhang
plug detect/mic present signal to the codec device itself, via Device Tree, ACPI or platform data. The corresponding GPIO indexes are: RT5677_GPIO_PLUG_DET - 0 RT5677_GPIO_MIC_PRESENT_L - 1 Signed-off-by: Ben Zhang --- sound/soc/codecs/rt5677.c | 179

[PATCH 2/3] ASoC: rt5677: Add ACPI device probing

2014-10-03 Thread Ben Zhang
The rt5677 codec driver looks for ACPI device ID "RT5677CE", which is specified in coreboot. Signed-off-by: Ben Zhang Reviewed-on: https://chromium-review.googlesource.com/207622 Reviewed-by: Dylan Reid Reviewed-by: AndyX C Huang --- sound/soc/codecs/rt5677.c | 12 1 fi

[PATCH 1/3] ASoC: rt5677: Include gpio driver header

2014-10-03 Thread Ben Zhang
The header file is needed because struct gpio_chip is placed in struct rt5677_priv. Signed-off-by: Ben Zhang --- sound/soc/codecs/rt5677.h | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5677.h b/sound/soc/codecs/rt5677.h index d4eb6d5..99fd023 100644 --- a/sound/soc

[PATCH 1/3] ASoC: rt5677: Include gpio driver header

2014-10-03 Thread Ben Zhang
The header file is needed because struct gpio_chip is placed in struct rt5677_priv. Signed-off-by: Ben Zhang be...@chromium.org --- sound/soc/codecs/rt5677.h | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5677.h b/sound/soc/codecs/rt5677.h index d4eb6d5..99fd023 100644

[PATCH 2/3] ASoC: rt5677: Add ACPI device probing

2014-10-03 Thread Ben Zhang
The rt5677 codec driver looks for ACPI device ID RT5677CE, which is specified in coreboot. Signed-off-by: Ben Zhang be...@chromium.org Reviewed-on: https://chromium-review.googlesource.com/207622 Reviewed-by: Dylan Reid dgr...@chromium.org Reviewed-by: AndyX C Huang andyx.c.hu...@intel.com

[PATCH 3/3] ASoC: rt5677: Add jack detection support

2014-10-03 Thread Ben Zhang
plug detect/mic present signal to the codec device itself, via Device Tree, ACPI or platform data. The corresponding GPIO indexes are: RT5677_GPIO_PLUG_DET - 0 RT5677_GPIO_MIC_PRESENT_L - 1 Signed-off-by: Ben Zhang be...@chromium.org --- sound/soc/codecs/rt5677.c | 179

[PATCH] watchdog: touch_nmi_watchdog should only touch local cpu not every one

2013-12-05 Thread Ben Zhang
to trigger. So it won't matter if the wrong cpu is touched because the percpu interrupt counters the NMI watchdog uses should still be incrementing. Signed-off-by: Don Zickus Signed-off-by: Ben Zhang --- kernel/watchdog.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH] watchdog: touch_nmi_watchdog should only touch local cpu not every one

2013-12-05 Thread Ben Zhang
to trigger. So it won't matter if the wrong cpu is touched because the percpu interrupt counters the NMI watchdog uses should still be incrementing. Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by: Ben Zhang be...@chromium.org --- kernel/watchdog.c | 16 1 file changed, 8

[PATCH v2] watchdog: Add a sysctl to disable soft lockup detector

2013-12-04 Thread Ben Zhang
p detector. Signed-off-by: Ben Zhang --- Documentation/kernel-parameters.txt | 11 +++ Documentation/sysctl/kernel.txt | 20 include/linux/sched.h | 3 ++- kernel/sysctl.c | 9 + kernel/watchdog.c

[PATCH v2] watchdog: Add a sysctl to disable soft lockup detector

2013-12-04 Thread Ben Zhang
. Signed-off-by: Ben Zhang be...@chromium.org --- Documentation/kernel-parameters.txt | 11 +++ Documentation/sysctl/kernel.txt | 20 include/linux/sched.h | 3 ++- kernel/sysctl.c | 9 + kernel/watchdog.c

[PATCH] watchdog: Add a sysctl to disable soft lockup detector

2013-12-03 Thread Ben Zhang
. Note kernel.softlockup_detector_enable does not affect the hard lockup detector. Signed-off-by: Ben Zhang --- include/linux/sched.h | 1 + kernel/sysctl.c | 9 + kernel/watchdog.c | 15 +++ 3 files changed, 25 insertions(+) diff --git a/include/linux/sched.h b

[PATCH] watchdog: Add a sysctl to disable soft lockup detector

2013-12-03 Thread Ben Zhang
. Note kernel.softlockup_detector_enable does not affect the hard lockup detector. Signed-off-by: Ben Zhang be...@chromium.org --- include/linux/sched.h | 1 + kernel/sysctl.c | 9 + kernel/watchdog.c | 15 +++ 3 files changed, 25 insertions(+) diff --git a/include