[PATCH] nvdimm: use kobj_to_dev instead of container_of

This change is to cleanup the code a bit. Signed-off-by: Bernard Zhao --- drivers/nvdimm/dimm_devs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c index dc7449a40003..bea41bb5f830 100644 --- a/drivers/nvdimm

[patch v3] translations/zh_CN: add translations to dev-tools gcov

Add translations to dev-tools gcov Signed-off-by: Bernard Zhao --- Changes since V2: * fix some inaccurate translation Changes since V1: * add index.rst in dev-tools and link to to zh_CN/index.rst * fix some inaccurate translation --- .../translations/zh_CN/dev-tools/gcov.rst | 261

[PATCH] drm/msm: remove unneeded variable ret

This patch fix coccicheck warning: drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return "0" on line 880 Also remove unneeded function return value check. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dp/dp_link.c | 15 +++ 1 file c

[PATCH] drm/nouveau: fix potential abnormal lock/unlock

save, but no spin_unlock_irqrestore in if/return branch, seems like a potential bug? Signed-off-by: Bernard Zhao --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/ba

[PATCH] drm/kmb: cleanup coding style a bit

: Unneeded semicolon Signed-off-by: Bernard Zhao --- drivers/gpu/drm/kmb/kmb_dsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index 4b5d82af84b3..231041b269f5 100644 --- a/drivers/gpu/drm/kmb/kmb_dsi.c

[PATCH] drm/gud: cleanup coding style a bit

Fix coccicheck warning: drivers/gpu/drm/gud/gud_internal.h:89:2-3: Unneeded semicolon drivers/gpu/drm/gud/gud_internal.h:107:2-3: Unneeded semicolon Signed-off-by: Bernard Zhao --- drivers/gpu/drm/gud/gud_internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] drm/amd: remove not needed conversion to bool

Fix coccicheck warning: drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c:573:39-44: WARNING: conversion to bool not needed here drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c:575:39-44: WARNING: conversion to bool not needed here Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c | 4

[PATCH v2] Documentation/translations/zh_CN/dev-tools/

Add translations to dev-tools gcov Signed-off-by: Bernard Zhao Reviewed-by: Wu X.C --- Changes since V1: * add index.rst in dev-tools and link to to zh_CN/index.rst * fix some inaccurate translation Link for V1: *https://lore.kernel.org/patchwork/patch/1405740/ --- .../translations/zh_CN/dev

[PATCH] msm/disp: dpu_plane cleanup-coding-style-a-bit

Fix sparse warning: drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:1195:41: warning: Using plain integer as NULL pointer Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1

[PATCH] drm/amd: cleanup coding style a bit

ocks + if (obj && obj->use < 0) { +DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n", obj->head.name); + } Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) d

[PATCH] drm/ttm: cleanup coding style a bit

Fix sparse warning: drivers/gpu/drm/ttm/ttm_bo.c:52:1: warning: symbol 'ttm_global_mutex' was not declared. Should it be static? drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol 'ttm_bo_glob_use_count' was not declared. Should it be static? Signed-off-by: Bernard Zhao --- drivers/gpu/drm

[PATCH] amd/amdgpu: code refactoring to clean code style a bit

- consider code refactoring + if (vbios_voltage_id <= leakage_bin[j]) { Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 84 1 file changed, 35 insertions(+), 49 deletions(-) diff --git

[PATCH] drm/nouveau: cleanup-coding-style-a-bit

This change is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c | 44 ++--- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c b/drivers/gpu/drm/nouveau/dispnv50

[PATCH] drm/amd: use kmalloc_array over kmalloc with multiply

Fix patch check warning: WARNING: Prefer kmalloc_array over kmalloc with multiply + buf = kmalloc(MAX_KFIFO_SIZE * sizeof(*buf), GFP_KERNEL); Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] /msm/adreno: fix different address spaces warning

/a6xx_gpu_state.c:198:19: warning: dereference of noderef expression Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 36 ++--- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm

[PATCH] translations/zh_CN: add translations to dev-tools gcov

Add translations to dev-tools gcov Signed-off-by: Bernard Zhao --- .../translations/zh_CN/dev-tools/gcov.rst | 274 ++ 1 file changed, 274 insertions(+) create mode 100644 Documentation/translations/zh_CN/dev-tools/gcov.rst diff --git a/Documentation/translations/zh_CN/dev

[PATCH] drm/msm: remove unneeded variable: "rc"

remove unneeded variable: "rc". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dp/dp_panel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index d1780bcac8cc..9cc816663668 100644 ---

[PATCH] drm/tegra: remove unneeded variable: "ret"

remove unneeded variable: "ret". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/tegra/dpaux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 105fb9cdbb3b..b8abd55f3ef8 100644 --- a/drivers/gpu

[PATCH] amd/display: remove unneeded variable: "pattern"

Remove unneeded variable: "pattern". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_

[PATCH] drm/vc4: remove unneeded variable: "ret"

remove unneeded variable: "ret". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/vc4/vc4_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index b641252939d8..445d3bab89e0 100644 --- a/drivers/g

[PATCH] drm/hisilicon: remove redundant when devm_kzalloc failed

Line 852 DRM_ERROR is redundant because memory alloc already prints an error when failed. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers

[PATCH] drm/bridge/analogix: remove redundant when devm_kzalloc failed

Line 1590 DRM_ERROR is redundant because devm_kzalloc() already prints an error. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b

[PATCH] gpu/drm/msm: remove redundant when devm_kzalloc failed

Line 1826 pr_err is redundant because memory alloc already prints an error when failed. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index

[PATCH] via/via_irq: use __func__ to replace string function name

This change also fix checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'via_driver_irq_postinstall', this function's name, in a string + DRM_DEBUG("via_driver_irq_postinstall\n"); Signed-off-by: Bernard Zhao --- drivers/gpu/drm/via/via_irq.c |

[PATCH v2] drm/vmwgfx: use min_t to replace min

-by: Bernard Zhao Reported-by: kernel test robot --- Changes since V1: *fix compile error reported by kernel test robot Link for V1: *https://lore.kernel.org/patchwork/patch/1340996/ --- drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH] drm/via: fix assignment in if condition

Fix check_patch.pl warning: ERROR: do not use assignment in if condition + if ((HALCYON_HEADER2 == (cmd = *buf)) && ERROR: do not use assignment in if condition + if (HALCYON_HEADER2 == (cmd = *buf)) Signed-off-by: Bernard Zhao --- drivers

[PATCH] drm/vmwgfx: use min_t to replace min

-by: Bernard Zhao --- drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c index 83c0d5a3e4fd..b8f6fe1a71e6 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c +++ b/drivers/gpu/drm

[PATCH] amd/amdgpu: optimise CONFIG_X||CONFIG_X_MODULE to IS_ENABLED(X)

Optimise CONFIG_ || CONFIG__MODULE to IS_ENABLED(). This change also fix check_patch.pl warning: WARNING: Prefer IS_ENABLED() to CONFIG_ || CONFIG__MODULE +#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || defined (CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE) Signed-off-by: Bernard Zhao --- drivers/gpu

[PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with multiply

ay has multiply overflow check, which will be safer. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index d0aea5

[PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg

Fix check_patch.pl warning: kmalloc_array uses number as first arg, sizeof is generally wrong. +fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL); Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 5/5] adreno/adreno_gpu.c: add KERN_LEVEL to printk

Add KERN_LEVEL to printk. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 458b5b26d3c2..be752db5abed

[PATCH 4/5] adreno/a5xx_gpu.c: add KERN_LEVEL to printk

Add KERN_LEVEL to printk. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c index d6804a802355..c3ac78a32caf 100644

[PATCH 2/5] adreno/a3xx_gpu.c: add KERN_LEVEL to printk

Add KERN_LEVEL to printk. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c index f29c77d9cd42..64c9a9448f53 100644

[PATCH 1/5] adreno/a2xx_gpu.c: add KERN_LEVEL to printk

Add KERN_LEVEL to printk. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a2xx_gpu.c b/drivers/gpu/drm/msm/adreno/a2xx_gpu.c index 7e82c41a85f1..33b45d237e56 100644

[PATCH 3/5] adreno/a4xx_gpu.c: add KERN_LEVEL to printk

Add KERN_LEVEL to printk. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a4xx_gpu.c b/drivers/gpu/drm/msm/adreno/a4xx_gpu.c index 2b93b33b05e4..2206b3b4b191 100644

[PATCH 0/5] add KERN_LEVEL to printk

Hi: When call printk, set the KERN_LEVEL is suggested by the community. This patch sereies add KERN_* level to printk which do not set this level. Bernard Zhao (5): adreno/a2xx_gpu.c: add KERN_LEVEL to printk adreno/a3xx_gpu.c: add KERN_LEVEL to printk adreno/a4xx_gpu.c: add KERN_LEVEL

[PATCH] amd/display/amdgpu_dm: delete same check in if condition

In function amdgpu_dm_connector_get_modes, drm_edid_is_valid will check weather (!edid), no need to check again in the if branch. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 0/2] drivers/tty: delete break after return or goto

Hi, Greg: This patch sereies delete code which never run: { case XXX: return XXX; break; //The break is meanless, so just delete it. case YYY: goto YYY; break; //The break is meanless, so just delete it. .. } Bernard Zhao (2): tty/serial: delete break after

[PATCH 1/2] tty/serial: delete break after return

Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/serial/imx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b

[PATCH 2/2] drivers/tty: delete break after goto/return

Delete break after goto/return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/nozomi.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index d42b854cb7df..946cc16827aa 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty

[PATCH 2/2] drivers/tty: delete break after return

Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/serial/imx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b

[PATCH 1/2] drivers/tty: delete break after goto

Delete break after goto, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/nozomi.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index d42b854cb7df..946cc16827aa 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c

[PATCH 0/2] drivers/tty: delete break after return or goto

This patch sereies optimise code like: { case XXX: return XXX; break; //The break is meanless, so just delete it. case YYY: goto YYY; break; //The break is meanless, so just delete it. .. } Signed-off-by: Bernard Zhao --- Bernard Zhao (2): drivers/tty

[PATCH 0/2] drivers/tty: delete break after return

This patch sereies delete break after return, which will never run. Signed-off-by: Bernard Zhao *** BLURB HERE *** Bernard Zhao (2): drivers/tty: delete break after return drivers/tty: delete break after return drivers/tty/nozomi.c | 4 drivers/tty/serial/imx.c | 5 - 2 files

[PATCH 2/2] drivers/tty: delete break after return

Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/serial/imx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b

[PATCH 1/2] drivers/tty: delete break after return

Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/nozomi.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index d42b854cb7df..946cc16827aa 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c

[PATCH 1/2] drivers/tty: delete break after return

Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/nozomi.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index d42b854cb7df..946cc16827aa 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c

[PATCH 0/2] drivers/tty: delete break after return

This patch sereies delete break after return, which will never run. Signed-off-by: Bernard Zhao *** BLURB HERE *** Bernard Zhao (2): drivers/tty: delete break after return drivers/tty: delete break after return drivers/tty/nozomi.c | 4 drivers/tty/serial/imx.c | 5 - 2 files

[PATCH 2/2] drivers/tty: delete break after return

Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/serial/imx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b

[PATCH] drm/amd: fix typoes

Fix typoes. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c index 2c6db379afae..e994d233aa21

[PATCH] drm/msm: delete conversion from bool value to bool return

Delete the conversion from bool value to bool function return. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm

[PATCH] drm/msm: delete conversion from bool value to bool variable

Remove the conversion from bool value to bool variable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

[PATCH] drm/amd: move DRM_ERROR log out of the mutex protect area

In function amdgpu_register_gpu_instance, there is no need to protect DRM_ERROR in mutex mgpu_info.mutex. This change is to make the code to run a bit fast. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] gpu/drm: delete same check in if condition

In function drm_bridge_connector_get_modes_edid, drm_edid_is_valid will check weather (!edid), no need to check again in the if branch. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/drm_bridge_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH] gpu/drm: make crtc check before new_connector circle

In function prepare_signaling, crtc check (c==0) is not related with the next new_connector circle, maybe we can put the crtc check just after the crtc circle and before new_connector circle. This change is to make the code to run a bit first. Signed-off-by: Bernard Zhao --- drivers/gpu/drm

[PATCH] drivers/thermal: cleanup coding style a bit

Function thermal_add_hwmon_sysfs, hwmon will be NULL when new_hwmon_device = 0, so there is no need to check, kfree will handle NULL point. Signed-off-by: Bernard Zhao --- drivers/thermal/thermal_hwmon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/thermal

[PATCH] drivers/thermal: fix potential memleak in error branch

Function __thermal_cooling_device_register, when device_register failed, cdev is not free after error value return, this may bring in potential memleak. Signed-off-by: Bernard Zhao --- drivers/thermal/thermal_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal

[PATCH v2] drivers/thermal: optimize the for circle to run a bit fast

Function thermal_zone_device_register, in the for circle, if the first if branch set the count bit in tz->trips_disabled, there is no need to set in the other if branch again. This change is to make the code run a bit fast and readable. Signed-off-by: Bernard Zhao Changes since V1: *m

[PATCH] gpu/drm/mgag200:remove break after return

In function mgag200_set_pci_regs, there are some switch cases returned, then break. These break will never run. This patch is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/mgag200/mgag200_mode.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff

[PATCH] drivers/thermal: optimize the for circle to run a bit fast

Function thermal_zone_device_register, in the for circle, if the first if branch set the count bit in tz->trips_disabled, there is no need to set in the other if branch again. This change is to make the code run a bit fast and readable. Signed-off-by: Bernard Zhao --- drivers/ther

[PATCH] drivers/thermal: remove unnecessary structure members allocated_tzp

Struct power_allocator_params element allocated_tzp is only used in unbind to kfree the kzalloc space. Maybe we don’t have to need this member to mark, also, kfree will handle NULL point, there is no risk. This change is to make the code run a bit fast. Signed-off-by: Bernard Zhao --- drivers

[PATCH] drm/amd: remove unnecessary conversion from bool value to bool

In functions vegam_is_dpm_running & vegam_populate_avfs_parameters, maybe there is no need to conver bool condition to bool variable or bool return value. This change is to make the code a bit more readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c

[PATCH] drm/mediatek: Optimize functions which do not need to return

Function mtk_hdmi_aud_set_input always return 0, no need to keep the return value. Functions mtk_hdmi_aud_enable_packet & mtk_hdmi_aud_on_off_hw_ncts are the same, these two functions just call next functions. Maybe it`s a bit better to just call the inner function. Signed-off-by: Bernard

[PATCH] gpu/drm/armada: fix unused parameter warning

Functions armada_drm_crtc_atomic_flush & armada_drm_crtc_atomic_enable don`t use the second parameter. So we may get warning like : warning: unused parameter ‘***’ [-Wunused-parameter]. This change is to fix the compile warning with -Wunused-parameter. Signed-off-by: Bernard Zhao --- dri

[PATCH] gpu/drm/mediatek: fix unused parameter warning

gned-off-by: Bernard Zhao --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 4d29568be3f5..6e55ec0e80bb 100644 --- a/drivers/gpu/drm/mediatek/mtk_dr

[PATCH] drm/amd/display: remove no need return value

Functions (disable_all_writeback_pipes_for_stream & dc_enable_stereo & dc_post_update_surfaces_to_stream) always return true, there is no need to keep the return value. This change is to make the code a bit more readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/c

[PATCH] drm/msm/disp: add error value record in for circle`s error index

able. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c index f1bc6a1af7a7..e6da0469b743 100644 --- a/drivers

[PATCH] drm/amd/display: remove no need return value

Functions (disable_all_writeback_pipes_for_stream & dc_enable_stereo & dc_post_update_surfaces_to_stream) always return true, there is no need to keep the return value. This change is to make the code a bit more readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/c

[PATCH] drm/amd:fix typoes in comments

Change the comment typo: "programm" -> "program". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++

[PATCH] drm/radeon:fix typoes in comments

Change the comment typo: "programm" -> "program". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/radeon/uvd_v1_0.c | 4 ++-- drivers/gpu/drm/radeon/uvd_v2_2.c | 2 +- drivers/gpu/drm/radeon/uvd_v4_2.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH] mtd/map: fix typoes for struct memcard

Change struct memcard`s element "removeable" -> "removable". Signed-off-by: Bernard Zhao --- drivers/mtd/maps/vmu-flash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c index 177bf134e1

[PATCH v2] drm/amd/display: optimize code runtime a bit

In the function dal_ddc_service_query_ddc_data, get rid of dal_ddc_i2c_payloads_destroy, call dal_vector_destruct() directly. This change is to make the code run a bit fast. Signed-off-by: Bernard Zhao Changes since V1: *get rid of dal_ddc_i2c_payloads_destroy, call dal_vector_destruct

[PATCH] drm/amd/display: optimize code runtime a bit

Static function dal_ddc_i2c_payloads_destroy is only called in dal_ddc_service_query_ddc_data, the parameter is , there is no point NULL risk, so no need to check. This change is to make the code run a bit fast. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c

[PATCH] drm/amd/display: optimize code runtime a bit

In fnction is_cr_done & is_ch_eq_done, when done = false happened once, no need to circle left ln_count. This change is to make the code run a bit fast. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 14 +- 1 file changed, 5 insertions(+

[PATCH] gpu/drm: cleanup coding style a bit

Remove first assignment to info which is meaningless. Put the width and higth check first. This change is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/drm_framebuffer.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu

[PATCH] gpu/ipu-v3:reduce protected code area in ipu idmac get/put

This change will speed-up a bit these ipu_idmac_get & ipu_idmac_put processing and there is no need to protect kzalloc & kfree. Signed-off-by: Bernard Zhao --- drivers/gpu/ipu-v3/ipu-common.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a

[PATCH] drm/via: reduce no need mutex_lock area

In function via_mem_alloc`s error branch, DRM_ERROR is protected in the mutex_lock(>struct_mutex) area. >From the code, we see that DRM_ERROR is just an error log print without any struct element, there is no need to protect this. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/via/via_mm

[PATCH] drm/msm/adreno: remove return value of function XX_print

XX_print like pfp_print/me_print/meq_print/roq_print are just used in file a5xx_debugfs.c. And these function always return 0, this return value is meaningless. This change is to make the code a bit more readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 21

[PATCH] drm/panel: remove return value of function drm_panel_add

The function "int drm_panel_add(struct drm_panel *panel)" always returns 0, this return value is meaningless. Also, there is no need to check return value which calls "drm_panel_add and", error branch code will never run. Signed-off-by: Bernard Zhao --- drivers

[PATCH] drm/panel: remove meaningless if(ret) check code.

The function drm_panel_add always returns true. So if(ret) check code will never run into error branch. Remove these check will make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] drm/panel: remove meaningless if(ret) check code.

The function drm_panel_add always returns true. So if(ret) check code will never run into error branch. Remove these check make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH] drm/msm: use kthread_create_worker instead of kthread_run

Use kthread_create_worker to simplify the code and optimise the manager struct: msm_drm_thread. With this change, we could remove struct element (struct task_struct *thread & struct kthread_worker worker), instead, use one point (struct kthread_worker *worker). Signed-off-by: Bernard

[PATCH v3] drm/amd: fix potential memleak in err branch

atched. These changes are to add kobject_put in kobject_init_and_add failed branch, fix potential memleak. Signed-off-by: Bernard Zhao --- Changes since V2: *remove duplicate kobject_put in kfd_procfs_init. Link for V1: *https://lore.kernel.org/patchwork/patch/1258608/ --- drivers/gpu/drm/amd/amdkfd/k

[PATCH v2] drm/amd: fix potential memleak in err branch

atched. These changes are to add kobject_put in kobject_init_and_add failed branch, fix potential memleak. Signed-off-by: Bernard Zhao --- Changes since V1: *Remove duplicate changed file kfd_topology.c, this file`s fix already applied to the main line. --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2

[PATCH] drm/amd: fix potential memleak in err branch

atched. These changes are to add kobject_put in kobject_init_and_add failed branch, fix potential memleak. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 ++ drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 20 +++- 2 files changed, 17 insertions(+), 5 del

[PATCH] gpu/drm: remove drm_modeset_lock protection for drm_error

In function drm_atomic_helper_shutdown, maybe there is no need to protect DRM_ERROR log in DRM_MODESET_LOCK_ALL_BEGIN & DRM_MODESET_LOCK_ALL_END. This change is to make code run a bit fast. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/drm_atomic_helper.c | 4 +--- 1 file changed, 1 inser

[PATCH v2] drm/mediatek: remove unnecessary conversion to bool

In function mtk_dsi_clk_hs_state, remove unnecessary conversion to bool return, this change is to make the code a bit readable. Signed-off-by: Bernard Zhao --- Changes since V1: *optimize to make the code a bit more clear. Link for V1: *https://lore.kernel.org/patchwork/patch/1255327

[PATCH] drm/i915: remove unnecessary conversion to bool

In function perform_bb_shadow, bb->ppgtt is bool, so maybe there is no need to convert the bool condition to bool. This change is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH] drm/mediatek: remove unnecessary conversion to bool

In function mtk_dsi_clk_hs_state, remove unnecessary conversion to bool return, this change is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek

[PATCH] drm/amd: remove unnecessary conversion to bool

In function is_support_sw_smu, remove unnecessary conversion to bool return, this change is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amd: add missing fill of the array`s first element

In function fill_iram_v_2, the ram_table->bright_neg_gain`s first element [0][0] seems to be missing. This change is just to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 1 + 1 file changed, 1 insertion(+) diff --

[PATCH] drm/msm: fix potential memleak issue

Function msm_gpu_crashstate_capture maybe called for several times, and then the state->bos is a potential memleak. Also the state->pos maybe alloc failed, but now without any handle. This change is to fix some potential memleak and add error handle when alloc failed. Signed-off-by: Bernar

[PATCH] drm/msm: fix potential memleak in error branch

In fucntin msm_submitqueue_create, the queue is a local variable, in return -EINVAL branch, queue didn`t add to ctx`s list yet, and also didn`t kfree, this maybe bring in potential memleak. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/msm_submitqueue.c | 4 +++- 1 file changed, 3

[PATCH] drm/mxsfb: miss err handle in probe

There are three err return values in drm_fbdev_generic_setup. In mxsfb_probe we called this function, but didn`t handle the return value, this change is to add err handle, maybe make code a bit more readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +++- 1 file

[PATCH v3] memory/samsung: reduce protected code area in IRQ

This change will speed-up a bit this IRQ processing and there is no need to protect return value or printing. Signed-off-by: Bernard Zhao --- Changes since v1: *change release lock before the if statement. *revert dmc->df->lock mutex lock to protect function exynos5_dmc_perf_events

[PATCH v2] memory/samsung: reduce unnecessary mutex lock area

Maybe dmc->df->lock seems not needed to protect "if (ret) & dev_warn" branch. Maybe this change speed up the code a bit. Signed-off-by: Bernard Zhao Changes since v1: *change release lock before the if statement. *revert dmc->df->lock mute

[PATCH] memory/samsung: reduce unnecessary mutex lock area

Maybe dmc->df->lock is unnecessary to protect function exynos5_dmc_perf_events_check(dmc). If we have to protect, dmc->lock is more better and more effective. Also, it seems not needed to protect "if (ret) & dev_warn" branch. Signed-off-by: Bernard Zhao --- drivers/me

[PATCH] memory/samsung: Maybe wrong triming parameter

In function create_timings_aligned, all the max is to use dmc->min_tck->xxx, aligned with val dmc->timings->xxx. But the dmc->timings->tFAW use dmc->min_tck->tXP? Maybe this point is wrong parameter useing. Signed-off-by: Bernard Zhao --- drivers/memory/samsung/exynos5

[PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

There is DEVICE_ATTR mechanism in separate attribute define. So this change is to use attr array, also use sysfs_create_files in init function & sysfs_remove_files in fini function. This maybe make the code a bit readable. Signed-off-by: Bernard Zhao Changes since V1: *Use DEVICE_ATTR mecha

[PATCH] drm/mediatek: eliminate the magic number in array size

Eiminate the magic number in array size, there macro defines in hdmi.h. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index

  1   2   >