Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

2016-12-03 Thread Bhuvanchandra DV
On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(>lpuart_timer) while holding sport->port.lock - sport->lpuart_timer routine is lpuart_timer_func() that calls lpuart_copy_rx_to_tty() that acquires same lock. To fix,

Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

2016-12-03 Thread Bhuvanchandra DV
On 12/03/2016 02:25 PM, Nikita Yushchenko wrote: 03.12.2016 10:06, Bhuvanchandra DV пишет: On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(>lpuart_timer) while holding sport->port.lock - sport->lpu

Re: [PATCH] tty: serial: fsl_lpuart: Fix Tx DMA edge case

2016-10-10 Thread Bhuvanchandra DV
On 10/07/16 03:43, Aaron Brice wrote: In the case where head == 0 on the circular buffer, there should be one DMA buffer, not two. The second zero-length buffer would break the lpuart driver, transfer would never complete. Tested-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com>

[PATCH v3 4/6] arm: dts: imx7: Update #pwm-cells for PWM polarity control

2016-10-07 Thread Bhuvanchandra DV
Update #pwm-cells to 3 in order to support PWM signal polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Acked-by: Rob Herring <r...@kernel.org> --- arch/arm/boot/dts/imx7s.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCH v3 0/6] Support PWM polarity control

2016-10-07 Thread Bhuvanchandra DV
arm-kernel/msg530818.html Bhuvanchandra DV (3): arm: dts: imx7: Update #pwm-cells for PWM polarity control arm: dts: imx7-colibri: Use pwm polarity control arm: dts: imx7-colibri: Use enable-gpios for BL_ON Lothar Wassmann (3): pwm: print error messages with pr_err() instead of pr_de

[PATCH v3 2/6] pwm: core: make the PWM_POLARITY flag in DTB optional

2016-10-07 Thread Bhuvanchandra DV
driver without having to modify all existing DTS files. Signed-off-by: Lothar Wassmann <l...@karo-electronics.de> Signed-off-by: Lukasz Majewski <l.majew...@samsung.com> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Suggested-by: Sascha Hauer ---

[PATCH v3 1/6] pwm: print error messages with pr_err() instead of pr_debug()

2016-10-07 Thread Bhuvanchandra DV
From: Lothar Wassmann <l...@karo-electronics.de> Make the messages that are printed in case of fatal errors actually visible to the user without having to recompile the driver with debugging enabled. Signed-off-by: Lothar Waßmann <l...@karo-electronics.de> Signed-off-by: Bhuv

Re: [PATCH v2 2/6] pwm: core: make the PWM_POLARITY flag in DTB optional

2016-10-07 Thread Bhuvanchandra DV
' flag. This is done to provide polarity inversion support for the pwm-imx driver without having to modify all existing DTS files. Signed-off-by: Lothar Wassmann <l...@karo-electronics.de> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Suggested-by: Thierry Reding <thi

[PATCH v3 3/6] pwm: imx: support output polarity inversion

2016-10-07 Thread Bhuvanchandra DV
ski <l.majew...@samsung.com> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Acked-by: Shawn Guo <shawn@linaro.org> Reviewed-by: Sascha Hauer <s.ha...@pengutronix.de> --- Documentation/devicetree/bindings/pwm/imx-pwm.txt | 6 +-- drivers/pwm/pwm-im

[PATCH v3 5/6] arm: dts: imx7-colibri: Use pwm polarity control

2016-10-07 Thread Bhuvanchandra DV
Configure PWM polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- arch/arm/boot/dts/imx7-colibri.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi index a

[PATCH v3 6/6] arm: dts: imx7-colibri: Use enable-gpios for BL_ON

2016-10-07 Thread Bhuvanchandra DV
Use pwm-backlight driver 'enable-gpios' property for backlight on/off control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- arch/arm/boot/dts/imx7-colibri.dtsi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibr

[PATCH v2 6/6] arm: dts: imx7-colibri: Use enable-gpios for BL_ON

2016-10-01 Thread Bhuvanchandra DV
Use pwm-backlight driver 'enable-gpios' property for backlight on/off control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- arch/arm/boot/dts/imx7-colibri.dtsi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibr

[PATCH v2 5/6] arm: dts: imx7-colibri: Use pwm polarity control

2016-10-01 Thread Bhuvanchandra DV
Configure PWM polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- arch/arm/boot/dts/imx7-colibri.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi index a

[PATCH v2 0/6] Support PWM polarity control

2016-10-01 Thread Bhuvanchandra DV
]. [1] http://thread.gmane.org/gmane.linux.pwm/1621 [2] https://www.spinics.net/lists/arm-kernel/msg530818.html Bhuvanchandra DV (3): arm: dts: imx7: Update #pwm-cells for PWM polarity control arm: dts: imx7-colibri: Use pwm polarity control arm: dts: imx7-colibri: Use enable-gpios for BL_ON

[PATCH v2 2/6] pwm: core: make the PWM_POLARITY flag in DTB optional

2016-10-01 Thread Bhuvanchandra DV
driver without having to modify all existing DTS files. Signed-off-by: Lothar Wassmann <l...@karo-electronics.de> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Suggested-by: Thierry Reding <thierry.red...@gmail.com> --- drivers/pwm/core.c | 27 ---

[PATCH v2 1/6] pwm: print error messages with pr_err() instead of pr_debug()

2016-10-01 Thread Bhuvanchandra DV
From: Lothar Wassmann <l...@karo-electronics.de> Make the messages that are printed in case of fatal errors actually visible to the user without having to recompile the driver with debugging enabled. Signed-off-by: Lothar Waßmann <l...@karo-electronics.de> Signed-off-by: Bhuv

[PATCH v2 3/6] pwm: imx: support output polarity inversion

2016-10-01 Thread Bhuvanchandra DV
ski <l.majew...@samsung.com> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Acked-by: Shawn Guo <shawn@linaro.org> Reviewed-by: Sascha Hauer <s.ha...@pengutronix.de> --- Documentation/devicetree/bindings/pwm/imx-pwm.txt | 6 +-- drivers/pwm/pwm-im

[PATCH v2 4/6] arm: dts: imx7: Update #pwm-cells for PWM polarity control

2016-10-01 Thread Bhuvanchandra DV
Update #pwm-cells to 3 in order to support PWM signal polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Acked-by: Rob Herring <r...@kernel.org> --- arch/arm/boot/dts/imx7s.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

Re: [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for PWM polarity control

2016-09-27 Thread Bhuvanchandra DV
On 09/23/16 23:22, Rob Herring wrote: On Mon, Sep 19, 2016 at 07:53:45PM +0530, Bhuvanchandra DV wrote: Update #pwm-cells to 3 in order to support PWM signal polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- Documentation/devicetree/bindings/p

[PATCH 0/3] iMX7 PWM polarity control

2016-09-19 Thread Bhuvanchandra DV
] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/294027.html [2] https://www.spinics.net/lists/arm-kernel/msg530818.html Bhuvanchandra DV (3): arm: dts: imx7: Update #pwm-cells for PWM polarity control arm: dts: imx7-colibri: Use pwm polarity control arm: dts: imx7-colibri

[PATCH 2/3] arm: dts: imx7-colibri: Use pwm polarity control

2016-09-19 Thread Bhuvanchandra DV
Configure PWM polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- arch/arm/boot/dts/imx7-colibri.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi index a

[PATCH 1/3] arm: dts: imx7: Update #pwm-cells for PWM polarity control

2016-09-19 Thread Bhuvanchandra DV
Update #pwm-cells to 3 in order to support PWM signal polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- Documentation/devicetree/bindings/pwm/imx-pwm.txt | 6 +++--- arch/arm/boot/dts/imx7s.dtsi | 8 2 files changed, 7 inse

[PATCH 3/3] arm: dts: imx7-colibri: Use enable-gpios for BL_ON

2016-09-19 Thread Bhuvanchandra DV
Use pwm-backlight driver 'enable-gpios' property for backlight on/off control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- arch/arm/boot/dts/imx7-colibri.dtsi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibr

Re: [PATCH RESEND v2 0/8] Improve Rx/Tx DMA implementation

2016-08-03 Thread Bhuvanchandra DV
Hi Andrew, On 08/02/16 20:58, Andrew Lunn wrote: On Tue, Aug 02, 2016 at 01:23:32PM +0530, Bhuvanchandra DV wrote: Hello, Any comments on this patchset? I tested v1 on my Vybrid board and it fixed the corruption issues i was seeing with the console on a serial port. I will try to test

Re: [PATCH RESEND v2 0/8] Improve Rx/Tx DMA implementation

2016-08-02 Thread Bhuvanchandra DV
Hello, Any comments on this patchset? On 07/19/16 13:13, Bhuvanchandra DV wrote: Drop the clock change patch from v2 patchset[1] since it is applied. Changes since v1: Split suspend/resume patch. [1] https://lkml.org/lkml/2016/6/28/124 Bhuvanchandra DV (5): tty: serial: fsl_lpuart: Fix

[PATCH RESEND v2 6/8] tty: serial: fsl_lpuart: Use scatter/gather DMA for Tx

2016-07-19 Thread Bhuvanchandra DV
Drop PIO to DMA switching and use scatter/gather DMA for Tx path to improve performance. Some part of the code is borrowed from imx serial driver. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 257 ++---

[PATCH RESEND v2 4/8] tty: serial: fsl_lpuart: Fix broken 8m/s1 support

2016-07-19 Thread Bhuvanchandra DV
By default the driver always configure the mode as 8s1 even when 8m1 mode is selected. Fix this by adding support to control the space/mark bit. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 9 +++-- 1 file changed, 7 insertions

[PATCH RESEND v2 3/8] tty: serial: fsl_lpuart: fix clearing of receive flag

2016-07-19 Thread Bhuvanchandra DV
he data register is still required. This leads to a FIFO underrun. To avoid this, follow the advice in the overrun "Operation section": Unconditionally clear RXUF after using RXFLUSH. Signed-off-by: Stefan Agner <ste...@agner.ch> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@t

[PATCH RESEND v2 1/8] tty: serial: fsl_lpuart: consider TX FIFO too in tx_empty

2016-07-19 Thread Bhuvanchandra DV
itions between DMA and the driver by checking whether the TX DMA is in progress too. Signed-off-by: Stefan Agner <ste...@agner.ch> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 14 -- 1 file changed, 12 insertions(+), 2 deleti

[PATCH RESEND v2 7/8] tty: serial: fsl_lpuart: Update suspend/resume for DMA mode

2016-07-19 Thread Bhuvanchandra DV
and start the DMA at resume. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 44 + 1 file changed, 44 insertions(+) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 2

[PATCH RESEND v2 5/8] tty: serial: fsl_lpuart: Use cyclic DMA for Rx

2016-07-19 Thread Bhuvanchandra DV
driver. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 483 +--- 1 file changed, 258 insertions(+), 225 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 6

[PATCH RESEND v2 8/8] tty: serial: fsl_lpuart: Add support for RS-485

2016-07-19 Thread Bhuvanchandra DV
Enable Vybrid's build-in support for RS-485 auto RTS for controlling line direction of RS-485 transceiver driver. Enable RS485 feature by either using ioctrl 'TIOCSRS485' or enable it in the device tree by setting 'linux,rs485-enabled-at-boot-time' property. Signed-off-by: Bhuvanchandra DV

[PATCH RESEND v2 2/8] tty: serial: fsl_lpuart: support suspend/resume

2016-07-19 Thread Bhuvanchandra DV
From: Stefan Agner <ste...@agner.ch> Add suspend/resume support. Signed-off-by: Stefan Agner <ste...@agner.ch> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deleti

[PATCH RESEND v2 0/8] Improve Rx/Tx DMA implementation

2016-07-19 Thread Bhuvanchandra DV
Drop the clock change patch from v2 patchset[1] since it is applied. Changes since v1: Split suspend/resume patch. [1] https://lkml.org/lkml/2016/6/28/124 Bhuvanchandra DV (5): tty: serial: fsl_lpuart: Fix broken 8m/s1 support tty: serial: fsl_lpuart: Use cyclic DMA for Rx tty: serial

Re: [PATCH v2 0/9] Improve Rx/Tx DMA implementation

2016-07-04 Thread Bhuvanchandra DV
Ping! On 06/28/16 11:02, Bhuvanchandra DV wrote: Changes since v1: Split suspend/resume patch. Bhuvanchandra DV (5): tty: serial: fsl_lpuart: Fix broken 8m/s1 support tty: serial: fsl-lpuart: Use cyclic DMA for Rx tty: serial: fsl-lpuart: Use scatter/gather DMA for Tx tty: serial

[PATCH v2 7/9] tty: serial: fsl-lpuart: Use scatter/gather DMA for Tx

2016-06-28 Thread Bhuvanchandra DV
Drop PIO to DMA switching and use scatter/gather DMA for Tx path to improve performance. Some part of the code is borrowed from imx serial driver. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 257 ++---

[PATCH v2 9/9] tty: serial: fsl_lpuart: Add support for RS-485

2016-06-28 Thread Bhuvanchandra DV
Enable Vybrid's build-in support for RS-485 auto RTS for controlling line direction of RS-485 transceiver driver. Enable RS485 feature by either using ioctrl 'TIOCSRS485' or enable it in the device tree by setting 'linux,rs485-enabled-at-boot-time' property. Signed-off-by: Bhuvanchandra DV

[PATCH v2 3/9] tty: serial: fsl_lpuart: support suspend/resume

2016-06-28 Thread Bhuvanchandra DV
From: Stefan Agner <ste...@agner.ch> Add suspend/resume support. Signed-off-by: Stefan Agner <ste...@agner.ch> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deleti

[PATCH v2 8/9] tty: serial: fsl-lpuart: Update suspend/resume for DMA mode

2016-06-28 Thread Bhuvanchandra DV
and start the DMA at resume. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 44 + 1 file changed, 44 insertions(+) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 2

[PATCH v2 0/9] Improve Rx/Tx DMA implementation

2016-06-28 Thread Bhuvanchandra DV
Changes since v1: Split suspend/resume patch. Bhuvanchandra DV (5): tty: serial: fsl_lpuart: Fix broken 8m/s1 support tty: serial: fsl-lpuart: Use cyclic DMA for Rx tty: serial: fsl-lpuart: Use scatter/gather DMA for Tx tty: serial: fsl-lpuart: Update suspend/resume for DMA mode tty

[PATCH v2 5/9] tty: serial: fsl_lpuart: Fix broken 8m/s1 support

2016-06-28 Thread Bhuvanchandra DV
By default the driver always configure the mode as 8s1 even when 8m1 mode is selected. Fix this by adding support to control the space/mark bit. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 9 +++-- 1 file changed, 7 insertions

[PATCH v2 2/9] clk: imx: vf610: Disable automatic clock gating for lpuart in LPSTOP mode

2016-06-28 Thread Bhuvanchandra DV
, if wake is not enabled, the driver should disable the clocks explicitly to save power. Signed-off-by: Stefan Agner <ste...@agner.ch> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/clk/imx/clk-vf610.c | 12 ++-- 1 file changed, 6 insertions(+), 6 del

[PATCH v2 6/9] tty: serial: fsl-lpuart: Use cyclic DMA for Rx

2016-06-28 Thread Bhuvanchandra DV
driver. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 483 +--- 1 file changed, 258 insertions(+), 225 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 6

[PATCH v2 4/9] tty: serial: fsl_lpuart: fix clearing of receive flag

2016-06-27 Thread Bhuvanchandra DV
he data register is still required. This leads to a FIFO underrun. To avoid this, follow the advice in the overrun "Operation section": Unconditionally clear RXUF after using RXFLUSH. Signed-off-by: Stefan Agner <ste...@agner.ch> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@t

[PATCH v2 1/9] tty: serial: fsl_lpuart: consider TX FIFO too in tx_empty

2016-06-27 Thread Bhuvanchandra DV
itions between DMA and the driver by checking whether the TX DMA is in progress too. Signed-off-by: Stefan Agner <ste...@agner.ch> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 14 -- 1 file changed, 12 insertions(+), 2 deleti

Re: [PATCH 1/8] tty: serial: fsl_lpuart: consider TX FIFO too in tx_empty

2016-06-27 Thread Bhuvanchandra DV
On 06/26/16 02:56, Greg KH wrote: On Thu, Jun 09, 2016 at 08:40:32PM +0530, Bhuvanchandra DV wrote: From: Stefan Agner <ste...@agner.ch> Currently the tx_empty callback only considers the Transmit Complete Flag (TC). The reference manual is not quite clear if the TC flag covers the T

[PATCH 6/8] tty: serial: fsl-lpuart: Use scatter/gather DMA for Tx Drop PIO to DMA switching and use scatter/gather DMA for Tx path to improve performance.

2016-06-09 Thread Bhuvanchandra DV
Some part of the code is borrowed from imx serial driver. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 257 ++-- 1 file changed, 113 insertions(+), 144 deletions(-) diff --git a/drivers/tty/

[PATCH 1/8] tty: serial: fsl_lpuart: consider TX FIFO too in tx_empty

2016-06-09 Thread Bhuvanchandra DV
From: Stefan Agner Currently the tx_empty callback only considers the Transmit Complete Flag (TC). The reference manual is not quite clear if the TC flag covers the TX FIFO too. Debug prints on real hardware have shown that from time to time the TC flag is asserted (indicating

[PATCH 8/8] tty: serial: fsl_lpuart: Add support for RS-485

2016-06-09 Thread Bhuvanchandra DV
Enable Vybrid's build-in support for RS-485 auto RTS for controlling line direction of RS-485 transceiver driver. Enable RS485 feature by either using ioctrl 'TIOCSRS485' or enable it in the device tree by setting 'linux,rs485-enabled-at-boot-time' property. Signed-off-by: Bhuvanchandra DV

[PATCH 5/8] tty: serial: fsl-lpuart: Use cyclic DMA for Rx

2016-06-09 Thread Bhuvanchandra DV
driver. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 483 +--- 1 file changed, 258 insertions(+), 225 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 6

[PATCH 0/8] Improve Rx/Tx DMA implementation

2016-06-09 Thread Bhuvanchandra DV
Bhuvanchandra DV (5): tty: serial: fsl_lpuart: Fix broken 8m/s1 support tty: serial: fsl-lpuart: Use cyclic DMA for Rx tty: serial: fsl-lpuart: Use scatter/gather DMA for Tx Drop PIO to DMA switching and use scatter/gather DMA for Tx path to improve performance. tty: serial: fsl

[PATCH 7/8] tty: serial: fsl-lpuart: Update suspend/resume for DMA mode

2016-06-09 Thread Bhuvanchandra DV
and start the DMA at resume. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 44 + 1 file changed, 44 insertions(+) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 2

[PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume

2016-06-09 Thread Bhuvanchandra DV
From: Stefan Agner In order to allow wake support in STOP sleep mode, clocks are needed. Use imx_clk_gate2_cgr to disable automatic clock gating in low power mode STOP. This allows to enable wake by UART using: echo enabled > /sys/class/tty/ttyLP0/power/wakeup However, if wake

[PATCH 3/8] tty: serial: fsl_lpuart: fix clearing of receive flag

2016-06-09 Thread Bhuvanchandra DV
From: Stefan Agner Commit 8e4934c6d6c6 ("tty: serial: fsl_lpuart: clear receive flag on FIFO flush") implemented clearing of the receive flag by reading the status register only. It turned out that even though we flush the FIFO afterwards, a explicit read of the data

[PATCH 4/8] tty: serial: fsl_lpuart: Fix broken 8m/s1 support

2016-06-09 Thread Bhuvanchandra DV
By default the driver always configure the mode as 8s1 even when 8m1 mode is selected. Fix this by adding support to control the space/mark bit. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/tty/serial/fsl_lpuart.c | 9 +++-- 1 file changed, 7 insertions

[PATCH] drm/panel: Add display timings for TPK U.S.A. LLC Fusion 7", 10.1" panels

2016-05-05 Thread Bhuvanchandra DV
Add support for TPK U.S.A. LLC Fusion 7", 10.1" panels to the DRM simple panel driver. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- This patch is based on top of Stefan's clock polarity patches[1] [1] https://lkml.org/lkml/2016/5/5/20 .../bindings/displa

Re: [RFC 1/2] spi: spidev: Use 'new_id' sysfs file for enabling spidev

2016-04-20 Thread Bhuvanchandra DV
On 04/20/2016 05:47 PM, Mark Brown wrote: On Wed, Apr 20, 2016 at 05:43:32PM +0530, Bhuvanchandra DV wrote: SPI drivers bind to the device as configured in DT, but in case of spidev(non DT approach) the device is not available in hand to bind the driver. So tried this approach of creating

Re: [RFC 1/2] spi: spidev: Use 'new_id' sysfs file for enabling spidev

2016-04-20 Thread Bhuvanchandra DV
On 04/18/2016 06:31 PM, Mark Brown wrote: On Mon, Apr 18, 2016 at 04:48:27PM +0530, Bhuvanchandra DV wrote: +++ b/Documentation/ABI/testing/sysfs-bus-spi-spidev @@ -0,0 +1,8 @@ +What: /sys/bus/spi/drivers/spidev/new_id +Date: March 2016 +Description

[RFC 2/2] spi core: Add new sysfs 'num_chipselect' file

2016-04-18 Thread Bhuvanchandra DV
Add new sysfs 'num_chipselect' file to expose the maximum number of chipselects a SPI master can support. This allows to create a script in user space which automatically creates a new spidev instance for every chipselect on a bus. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.

[RFC 1/2] spi: spidev: Use 'new_id' sysfs file for enabling spidev

2016-04-18 Thread Bhuvanchandra DV
by Greg. [1] http://thread.gmane.org/gmane.linux.kernel.spi.devel/20331/focus=20369 Suggested-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Signed-off-by: Stefan Agner <stefan.ag...@toradex.com> --- Documentation

[RFC 0/2] sysfs new_id file support for spidev

2016-04-18 Thread Bhuvanchandra DV
This patchset adds support for loading spidev via sysfs new_id file. Any comments/suggestions welcome! Bhuvanchandra DV (2): spi: spidev: Use 'new_id' sysfs file for enabling spidev spi core: Add new sysfs 'num_chipselect' file Documentation/ABI/testing/sysfs-bus-spi-spidev | 8

[PATCH] spi: fsl-dspi: Set max_speed_hz for master

2016-03-21 Thread Bhuvanchandra DV
Calculate and update max speed from bus clock for SoC's using DSPI IP. The bus clock factor's are taken from the data sheet's of respective SoC's. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/spi/spi-fsl-dspi.c | 7 +++ 1 file changed, 7 insertions(+)

[PATCH] ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins

2016-02-15 Thread Bhuvanchandra DV
Add pinmux for UART_A RTS, CTS pin's. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> Acked-by: Stefan Agner <ste...@agner.ch> --- arch/arm/boot/dts/vf-colibri.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm

Re: [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON

2016-01-27 Thread Bhuvanchandra DV
Ping! On 01/09/2016 12:29 PM, Bhuvanchandra DV wrote: Use pwm-backlight driver 'enable-gpios' property for backlight on/off control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- arch/arm/boot/dts/vf-colibri.dtsi | 9 + 1 file changed, 9 insertions(+)

Re: [PATCH v2] spi-fsl-dspi: Fix CTAR Register access

2015-12-10 Thread Bhuvanchandra DV
On 12/10/2015 12:45 PM, Alexander Stein wrote: On Thursday 10 December 2015 11:25:30, Bhuvanchandra DV wrote: DSPI instances in Vybrid have a different amount of chip selects and CTARs (Clock and transfer Attributes Register). In case of DSPI1 we only have 2 CTAR registers and 4 CS. In present

Re: [PATCH] spi-fsl-dspi: Fix CTAR Register access

2015-12-09 Thread Bhuvanchandra DV
On 12/10/2015 02:11 AM, Mark Brown wrote: On Wed, Dec 09, 2015 at 11:51:39AM +0530, Bhuvanchandra DV wrote: DSPI instances in Vybrid have a different amount of chip selects and CTARs (Clock and transfer Attributes Register). In case of DSPI1 we only have 2 CTAR registers and 4 CS. In present

[PATCH v2] spi-fsl-dspi: Fix CTAR Register access

2015-12-09 Thread Bhuvanchandra DV
that is not present, hence configure CTAS to use CTAR0. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/spi/spi-fsl-dspi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 59a1143..3

[PATCH] spi-fsl-dspi: Fix CTAR Register access

2015-12-08 Thread Bhuvanchandra DV
that is not present, hence configure CTAS to use CTAR0. Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/spi/spi-fsl-dspi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 0

[PATCH v2] vf610_adc: Fix internal temperature calculation

2015-10-19 Thread Bhuvanchandra DV
| VDDconv | ADCR@Temp25 | | 3.0V| 0.696mV |30 | 950 | | 3.3V| 0.699mV |33 | 867 | Acked-by: Fugang Duan <b38...@freescale.com> Signed-off-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/iio/adc/vf610_adc.c | 19 ++-

[PATCH] vf610_adc: Fix internal temperature calculation

2015-09-23 Thread Bhuvanchandra DV
-by: Bhuvanchandra DV <bhuvanchandra...@toradex.com> --- drivers/iio/adc/vf610_adc.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index f4df2a7..e7abc13 100644 --- a/drivers/iio/adc/vf610

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Bhuvanchandra DV
On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote: On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: +/* + * CTS/RTS can _only_ be handled + * automatically by the hardware. + */ That's really not acceptable. You need to do something here so that you can

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Bhuvanchandra DV
Hello, On 06/08/2015 12:11 PM, Uwe Kleine-König wrote: Hello, On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: The LPUART does not provide manual control of RTS/CTS signals, those can only be controlled by the hardware directly. Therefore manual control of those signals

Re: [PATCH V2 0/3] Add RS-485 support and fix RTS/CTS implementation

2015-06-07 Thread Bhuvanchandra DV
Hello, Ping! On 06/01/2015 10:51 AM, Bhuvanchandra DV wrote: Changes since V1: Use common get/set mctrl control methods for both lpuart, lpuart32 and fix indention. Bhuvanchandra DV (3): ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins tty: serial: fsl_lpuart: remove

[PATCH V2 3/3] tty: serial: fsl_lpuart: Add support for RS-485

2015-05-31 Thread Bhuvanchandra DV
Enable Vybrid's build-in support for RS-485 auto RTS for controlling line direction of RS-485 transceiver driver. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/tty/serial/fsl_lpuart.c | 56 + 1 file changed, 56 insertions

[PATCH V2 1/3] ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins

2015-05-31 Thread Bhuvanchandra DV
Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf-colibri.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi index 68ca125..ad6c5ca 100644 --- a/arch/arm/boot/dts/vf-colibri.dtsi

[PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-05-31 Thread Bhuvanchandra DV
, hence remove the incorrect implementation. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/tty/serial/fsl_lpuart.c | 63 + 1 file changed, 7 insertions(+), 56 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty

[PATCH V2 0/3] Add RS-485 support and fix RTS/CTS implementation

2015-05-31 Thread Bhuvanchandra DV
Changes since V1: Use common get/set mctrl control methods for both lpuart, lpuart32 and fix indention. Bhuvanchandra DV (3): ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl tty: serial: fsl_lpuart: Add

[PATCH 0/3] Add RS-485 support and fix RTS/CTS implementation

2015-05-29 Thread Bhuvanchandra DV
- Add pinmux for UART_0 RTS/CTS pins. - Since hardware can handle RTS/CTS flow control automatically, remove manual control of RTS/CTS from set/get mctrl. - Add RS-485 support for Vybird platform. Bhuvanchandra DV (3): ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins

[PATCH 3/3] tty: serial: fsl_lpuart: Add support for RS-485

2015-05-29 Thread Bhuvanchandra DV
Enable Vybrid's build-in support for RS-485 auto RTS for controlling line direction of RS-485 transceiver driver. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/tty/serial/fsl_lpuart.c | 60 + 1 file changed, 60 insertions

[PATCH 1/3] ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins

2015-05-29 Thread Bhuvanchandra DV
Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf-colibri.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi index 68ca125..ad6c5ca 100644 --- a/arch/arm/boot/dts/vf-colibri.dtsi

[PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-05-29 Thread Bhuvanchandra DV
, hence remove the incorrect implementation. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/tty/serial/fsl_lpuart.c | 56 - 1 file changed, 10 insertions(+), 46 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty

Re: [PATCH 3/3] tty: serial: fsl_lpuart: Add support for RS-485

2015-05-29 Thread Bhuvanchandra DV
On 05/29/2015 03:48 PM, Jakub Kiciński wrote: On Fri, 29 May 2015 13:35:54 +0530, Bhuvanchandra DV wrote: Enable Vybrid's build-in support for RS-485 auto RTS for controlling line direction of RS-485 transceiver driver. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers

Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-05-29 Thread Bhuvanchandra DV
Hello Jakub, On 05/29/2015 03:34 PM, Jakub Kiciński wrote: On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote: The LPUART does not provide manual control of RTS/CTS signals, those can only be controlled by the hardware directly. Therefore manual control of those signals through mctrl

[PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip'

2015-01-31 Thread Bhuvanchandra DV
Move the check for spi-bits_per_word before allocation, to avoid memory leak. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/spi/spi-fsl-dspi.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions

[PATCH V2] ARM: vf-colibri: add SPI support and enable MCP2515 CAN

2015-01-29 Thread Bhuvanchandra DV
MCP2515 CAN controller is available on Colibri Evaluation board. Hence enable MCP2515 CAN. Acked-by: Stefan Agner ste...@agner.ch Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 31 +++ arch/arm/boot/dts/vf

[PATCH 5/7] spi: spi-fsl-dspi: Remove spi-bitbang

2015-01-27 Thread Bhuvanchandra DV
the bitbang in the driver. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/spi/Kconfig| 1 - drivers/spi/spi-fsl-dspi.c | 144 ++--- 2 files changed, 71 insertions(+), 74 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers

[PATCH 7/7] spi: spi-fsl-dspi: Add support for TCFQ transfer mode

2015-01-27 Thread Bhuvanchandra DV
. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- .../devicetree/bindings/spi/spi-fsl-dspi.txt | 2 + drivers/spi/spi-fsl-dspi.c | 74 +++--- 2 files changed, 68 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree

[PATCH 6/7] spi: spi-fsl-dspi: split the resuable code

2015-01-27 Thread Bhuvanchandra DV
From: Chao Fu b44...@freescale.com Add two functions: - dspi_data_from_popr - dspi_data_to_pushr Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/spi/spi-fsl-dspi.c | 118 +++-- 1 file changed, 60 insertions(+), 58 deletions

[PATCH 4/7] spi: spi-fsl-dspi: avoid preparing the clock two times

2015-01-27 Thread Bhuvanchandra DV
ste...@agner.ch Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/spi/spi-fsl-dspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 9b80d54..5378148 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b

[PATCH 1/7] ARM: vf610: add second DSPI instance

2015-01-27 Thread Bhuvanchandra DV
Acked-by: Stefan Agner ste...@agner.ch Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf500.dtsi | 4 arch/arm/boot/dts/vfxxx.dtsi | 11 +++ 2 files changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/vf500.dtsi b/arch/arm/boot/dts/vf500

[PATCH 2/7] ARM: vf-colibri: add SPI support and enable MCP2515 CAN

2015-01-27 Thread Bhuvanchandra DV
MCP2515 CAN controller is available on Colibri Evaluation board. Hence enable MCP2515 CAN. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 31 +++ arch/arm/boot/dts/vf-colibri.dtsi | 15

[PATCH 3/7] spi: spi-fsl-dspi: Remove usage of devm_kzalloc

2015-01-27 Thread Bhuvanchandra DV
trace f7f1c89f62e53de9 ]--- Acked-by: Stefan Agner ste...@agner.ch Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- drivers/spi/spi-fsl-dspi.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c

[PATCH 0/7] Add SPI support for Colibri modules and DSPI driver fixes

2015-01-27 Thread Bhuvanchandra DV
- Add second dspi instance. - Enable MCP2515 CAN controller which is avaialble on Colibri evaluation board. - Respin the stalled patches of dspi fixes. Previous discussion at: http://comments.gmane.org/gmane.linux.ports.arm.kernel/359542 Bhuvanchandra DV (4): ARM: vf610: add second DSPI

[PATCH] net: fec: Fix dual ethernet issue in VFxx

2015-01-06 Thread Bhuvanchandra DV
On i.MX28, the MDIO bus is shared between the two RMII interfaces. However, in newer designs, such as Vybrid, this is not the case. This patch adds a quirk for the single MDIO case. This allows to use both FEC interfaces working independently on Vybird. Signed-off-by: Bhuvanchandra DV

[PATCH] ARM: imx: clk-vf610: Add clock for UART4 and UART5

2015-01-06 Thread Bhuvanchandra DV
Add support for clock gating of UART4 and UART5. We use these UART's in a (not yet mainlined) device tree. Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/mach-imx/clk-vf610.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-imx/clk-vf610.c b/arch

[RESEND PATCH V2 0/2] Add I2C and enable M41T0M6 RTC

2014-11-12 Thread Bhuvanchandra DV
Add I2C support on Colibri VFxx moduels and enable M41T0M6 RTC available on Colibri carrier boards. Bhuvanchandra DV (2): ARM: dts: vf-colibri: Add I2C support ARM: dts: vf-colibri-eval-v3.dts: Enable ST-M41T0M6 RTC arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 12 +++- arch/arm

[RESEND PATCH V2 2/2] ARM: dts: vf-colibri-eval-v3.dts: Enable ST-M41T0M6 RTC

2014-11-12 Thread Bhuvanchandra DV
ST-M41T0M6 is available on Colibri carrier boards. Hence enable M41T0M6 RTC. Acked-by: Stefan Agner ste...@agner.ch Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf-colibri-eval-v3.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm

[RESEND PATCH V2 1/2] ARM: dts: vf-colibri: Add I2C support

2014-11-12 Thread Bhuvanchandra DV
Acked-by: Stefan Agner ste...@agner.ch Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf-colibri-eval-v3.dtsi |6 +- arch/arm/boot/dts/vf-colibri.dtsi | 13 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/arch/arm

[PATCH V2 1/2] ARM: dts: vf-colibri: Add I2C support

2014-11-05 Thread Bhuvanchandra DV
Acked-by: Stefan Agner ste...@agner.ch Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf-colibri-eval-v3.dtsi |6 +- arch/arm/boot/dts/vf-colibri.dtsi | 13 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/arch/arm

[PATCH V2 2/2] ARM: dts: vf-colibri-eval-v3.dts: Enable ST-M41T0M6 RTC

2014-11-05 Thread Bhuvanchandra DV
ST-M41T0M6 is available on Colibri carrier boards. Hence enable M41T0M6 RTC. Acked-by: Stefan Agner ste...@agner.ch Signed-off-by: Bhuvanchandra DV bhuvanchandra...@toradex.com --- arch/arm/boot/dts/vf-colibri-eval-v3.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm

  1   2   >