[GIT PULL] PCI fixes for v4.20

2018-12-07 Thread Bjorn Helgaas
PCI fixes: - Revert ASPM change that caused a regression (Bjorn Helgaas) The following changes since commit c74eadf881ad634c68880e2c1b504989d95993ee: Merge remote-tracking branch 'lorenzo/pci/controller-fixes' into for-linus (2018-11-30 23:42:08 -0600) are available in the Git repository

Re: [PATCH] PCI: Add missing include to drivers/pci.h

2018-12-06 Thread Bjorn Helgaas
On Wed, Nov 28, 2018 at 04:28:04PM -0600, Alexandru Gagniuc wrote: > This files makes use of definitions provided in . This > only compiles when is included beforehand, and creates > a nasty include dependency. Instead, just include the correct file. > > Signed-off-by: Alexandru Gagniuc

Re: [PATCH] PCI/P2PDMA: Match interface changes to devm_memremap_pages()

2018-12-06 Thread Bjorn Helgaas
site in > that code. > > Without this patch, all drivers will fail to register P2P resources > because devm_memremap_pages() will return -EINVAL due to the 'kill' > member of the pagemap structure not yet being set. > > Signed-off-by: Logan Gunthorpe > Cc: Andrew Mort

Re: [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments

2018-12-06 Thread Bjorn Helgaas
On Sat, Dec 01, 2018 at 08:07:11AM -0800, Benjamin Young wrote: > Made spacing more consistent in the code for function pointer > declarations based on checkpatch.pl > > Signed-off-by: Benjamin Young Applied to pci/misc for v4.21, thanks! I also made similar changes to include/linux/pci.h.

Re: [PATCH] pci: p2pdma: clean up documentation and kernel-doc

2018-12-06 Thread Bjorn Helgaas
On Sat, Dec 01, 2018 at 09:31:34AM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix typos, spellos, and grammar in p2pdma.rst and p2pdma.c. > > Fix return value(s) in function pci_p2pmem_alloc_sgl(). > > Signed-off-by: Randy Dunlap > Cc: linux-...@vger.kernel

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-12-03 Thread Bjorn Helgaas
On Wed, Nov 28, 2018 at 02:05:21PM -0600, Bjorn Helgaas wrote: > On Wed, Nov 28, 2018 at 6:13 AM Rafael J. Wysocki wrote: > > On Tuesday, November 27, 2018 9:25:14 PM CET Bjorn Helgaas wrote: > > > On Mon, Nov 26, 2018 at 11:37:20PM +0100, Rafael J. Wysocki wrote: > > &g

Fwd: [Bug 201517] New: pcieport 0000:00:03.1: AER: Corrected error received: 0000:00:00.0

2018-12-03 Thread Bjorn Helgaas
[Forwarding this to linux-pci since nobody really monitors the bugzilla] Possibly the same issue reported here: https://bugzilla.kernel.org/show_bug.cgi?id=109691 https://bugzilla.kernel.org/show_bug.cgi?id=111601 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1588428/

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-03 Thread Bjorn Helgaas
On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: > On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: > > [...] > > > +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int > > size, > > + u32 *val) > > +{ > > + struct

Re: [PATCH 2/2] PCI: mobiveil: ls_pcie_g4: add Workaround for A-011451

2018-12-03 Thread Bjorn Helgaas
On Sun, Dec 02, 2018 at 01:32:45PM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > When LX2 PCIe controller is sending multiple split completions and > ACK latency expires indicating that ACK should be send at priority. > But because of large number of split completions and FC update DLLP, > the

Re: [PATCH] x86/pci: Remove dead code DBG() macro

2018-12-03 Thread Bjorn Helgaas
e been > super interesting decades ago when the PCI code was first > bootstrapped, but we have better mechanisms meanwhile, and code > readability is king ... ;-) > > Signed-off-by: Ingo Molnar Acked-by: Bjorn Helgaas for both of these. I have nothing in the queue for these f

Re: [PATCH 1/2] PCI: mobiveil: ls_pcie_g4: add Workaround for A-011577

2018-12-03 Thread Bjorn Helgaas
On Sun, Dec 02, 2018 at 01:32:42PM +, Z.q. Hou wrote: > From: Hou Zhiqiang Can we pick one driver name (either "mobiveil" or "ls_pcie_g4" (this seems excessively long and excessively specific), or something else)? I don't want to waste the space of "PCI: mobiveil: ls_pcie_g4:" in every

[GIT PULL] PCI fixes for v4.20

2018-11-30 Thread Bjorn Helgaas
pci-v4.20-fixes-2 -------- Bjorn Helgaas (1): Merge remote-tracking branch 'lorenzo/pci/controller-fixes' into for-linus Gustavo Pimentel (1): PCI: dwc: Fix MSI-X EP framework address calculation bug Hou Zhiqiang (1): PCI:

Re: [PATCH] PCI: pciehp: Report degraded links via link bandwidth notification

2018-11-29 Thread Bjorn Helgaas
On Thu, Nov 29, 2018 at 08:13:12PM +0100, Lukas Wunner wrote: > On Thu, Nov 29, 2018 at 06:57:37PM +, alex_gagn...@dellteam.com wrote: > > On 11/29/2018 11:36 AM, Bjorn Helgaas wrote: > > > On Wed, Nov 28, 2018 at 06:08:24PM -0600, Alexandru Gagniuc wrote: > > >&g

Re: [PATCH] PCI: pciehp: Report degraded links via link bandwidth notification

2018-11-29 Thread Bjorn Helgaas
On Wed, Nov 28, 2018 at 06:08:24PM -0600, Alexandru Gagniuc wrote: > A warning is generated when a PCIe device is probed with a degraded > link, but there was no similar mechanism to warn when the link becomes > degraded after probing. The Link Bandwidth Notification provides this > mechanism. >

Re: [PATCH v2] PCI: assign bus numbers present in EA capability for bridges

2018-11-29 Thread Bjorn Helgaas
On Thu, Nov 29, 2018 at 07:00:14PM +0530, sundeep subbaraya wrote: > On Thu, Nov 29, 2018 at 3:25 AM Bjorn Helgaas wrote: > > On Mon, Nov 19, 2018 at 06:44:32PM +0530, sundeep.l...@gmail.com wrote: > > > From: Subbaraya Sundeep > > > > > > As per the s

Re: [PATCH v2] PCI: assign bus numbers present in EA capability for bridges

2018-11-28 Thread Bjorn Helgaas
On Mon, Nov 19, 2018 at 06:44:32PM +0530, sundeep.l...@gmail.com wrote: > From: Subbaraya Sundeep > > As per the spec, bridges with EA capability work > with fixed secondary and subordinate bus numbers. > Hence assign bus numbers to bridges from EA if the > capability exists. A reference to the

Re: Fwd: [Bug 201647] New: Intel Wireless card 3165 does not get detected but bluetooth works

2018-11-28 Thread Bjorn Helgaas
[+cc Emmanuel, LKML] On Fri, Nov 09, 2018 at 03:43:06PM -0600, Bjorn Helgaas wrote: > -- Forwarded message - > From: > Date: Fri, Nov 9, 2018 at 4:10 AM > Subject: [Bug 201647] New: Intel Wireless card 3165 does not get > detected but bluetooth w

Re: [PATCH] PCI: Mark NXP LS1088 to avoid bus reset bus

2018-11-28 Thread Bjorn Helgaas
On Tue, Nov 27, 2018 at 10:32 PM Bharat Bhushan wrote: > > -Original Message- > > From: Alex Williamson > > Sent: Tuesday, November 27, 2018 9:39 PM > > To: Bjorn Helgaas > > Cc: Bharat Bhushan ; linux-...@vger.kernel.org; > > linux-kernel@vger

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-11-28 Thread Bjorn Helgaas
On Wed, Nov 28, 2018 at 6:13 AM Rafael J. Wysocki wrote: > > On Tuesday, November 27, 2018 9:25:14 PM CET Bjorn Helgaas wrote: > > On Mon, Nov 26, 2018 at 11:37:20PM +0100, Rafael J. Wysocki wrote: > > > On Monday, November 26, 2018 7:03:58 PM CET Rafael J. Wysocki wr

Re: [RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure

2018-11-28 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, Nov 28, 2018 at 10:45 AM Dou Liyang wrote: > > Now, Linux just spread the irq affinity to irqdesc core by a cpumask pointer. > if an Vector's affinity is not NULL, it will be marked as managed. > > But, as Kashyap and Sumit reported, in MSI/-x subsystem, the pre/post

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-11-27 Thread Bjorn Helgaas
On Mon, Nov 26, 2018 at 11:37:20PM +0100, Rafael J. Wysocki wrote: > On Monday, November 26, 2018 7:03:58 PM CET Rafael J. Wysocki wrote: > > Hi Bjorn, > > > > The SD card reader in my Acer Aspire S5 doesn't work with 4.20-rc. > > > > Here's what lspci -v says about it (in a bad kernel): > > >

Re: [PATCH] PCI: Mark NXP LS1088 to avoid bus reset bus

2018-11-27 Thread Bjorn Helgaas
[+cc David, Jan, Alex, Maik, Chris] On Tue, Nov 27, 2018 at 08:46:33AM +, Bharat Bhushan wrote: > NXP (Freescale Vendor ID) LS1088 chips do not behave correctly after > bus reset with e1000e. Link state of device does not comes UP and so > config space never accessible again. Previous

Re: [PATCH 00/12] Bring suspend to RAM support to PCIe Aardvark driver

2018-11-26 Thread Bjorn Helgaas
On Fri, Nov 23, 2018 at 8:18 AM Miquel Raynal wrote: > > Hello, > > As part of an effort to bring suspend to RAM support to Armada 3700 > SoCs (main target: ESPRESSObin), this series handles the work around > the PCIe IP. > > First, more configuration is done in the 'setup' helper as inspired >

Re: [PATCH v2 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-15 Thread Bjorn Helgaas
On Thu, Nov 15, 2018 at 08:58:09AM -0600, Bjorn Helgaas wrote: > On Thu, Nov 15, 2018 at 03:16:29PM +0800, Kai Heng Feng wrote: > > On Nov 9, 2018, at 08:21, Bjorn Helgaas wrote: > > > I'm not sure we want a quirk for this at all, since as Christoph > > > points out,

Re: [GIT PULL] PCI fixes for v4.20

2018-11-15 Thread Bjorn Helgaas
On Thu, Nov 15, 2018 at 10:54:18AM -0500, Konstantin Ryabitsev wrote: > On Thu, Nov 15, 2018 at 09:03:21AM -0600, Bjorn Helgaas wrote: > > > You didn't really do anything wrong. In *general* I prefer to see > > > public URLs if they are sent to public lists, so if you're c

Re: [GIT PULL] PCI fixes for v4.20

2018-11-15 Thread Bjorn Helgaas
On Thu, Nov 15, 2018 at 02:53:30AM -0500, Konstantin Ryabitsev wrote: > On Thu, Nov 15, 2018 at 01:12:53AM -0600, Bjorn Helgaas wrote: > > > and I kinda see the point of maybe not having your ssh username in the > > > URL. Not that it is a big deal for us, k.org users thou

Re: [PATCH v2 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-15 Thread Bjorn Helgaas
On Thu, Nov 15, 2018 at 03:16:29PM +0800, Kai Heng Feng wrote: > > On Nov 9, 2018, at 08:21, Bjorn Helgaas wrote: > > On Tue, Nov 06, 2018 at 03:12:13PM +0800, AceLan Kao wrote: > >> It leads to the power consumption raises to 2.2W during s2idle, while > >> it con

Re: [GIT PULL] PCI fixes for v4.20

2018-11-14 Thread Bjorn Helgaas
On Wed, Nov 14, 2018 at 11:48:39PM +0100, Borislav Petkov wrote: > On Wed, Nov 14, 2018 at 05:21:54PM -0500, Konstantin Ryabitsev wrote: > > For the record, there's nothing wrong with that, it's just a condition > > that I didn't expect. I have a fix in place that should avoid this in > > the

[GIT PULL] PCI fixes for v4.20

2018-11-13 Thread Bjorn Helgaas
PCI fixes: - Revert a _PXM change that causes silent early boot failure on some AMD ThreadRipper systems (Bjorn Helgaas) The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository

Re: [GIT PULL] PCI changes for v4.20

2018-11-13 Thread Bjorn Helgaas
[+cc Martin, Rafael, Len, linux-acpi] On Tue, Nov 13, 2018 at 11:20:04AM +0100, Borislav Petkov wrote: > On Tue, Nov 13, 2018 at 08:17:12AM +0100, Ingo Molnar wrote: > > > > * Bjorn Helgaas wrote: > > > > > PCI changes: > > > > > > - P

Re: [PATCH v2 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-08 Thread Bjorn Helgaas
On Tue, Nov 06, 2018 at 03:12:13PM +0800, AceLan Kao wrote: > It leads to the power consumption raises to 2.2W during s2idle, while > it consumes less than 1W during long idle if put SK hynix nvme to D3 > and then enter s2idle. > From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its

Re: [PATCH] x86/PCI: Fix Broadcom CNB20LE unintended sign extension (redux)

2018-11-08 Thread Bjorn Helgaas
On Thu, Oct 25, 2018 at 02:52:31PM +0100, Colin King wrote: > From: Colin Ian King > > In the expression "word1 << 16", word1 starts as u16, but is promoted to > a signed int, then sign-extended to resource_size_t, which is probably > not what was intended. Cast to resource_size_t to avoid the

Re: [RFC] x86/pci: Mark pci_root_ops as const

2018-11-08 Thread Bjorn Helgaas
Hi Zubin, On Thu, Nov 08, 2018 at 09:11:15AM -0800, Zubin Mithra wrote: > pci_root_ops is only written to from within intel_mid_pci_init. This > is linked in only when CONFIG_X86_INTEL_MID is set. If not for this, > pci_root_ops could be marked as const. > > Fix this by replacing pci_root_ops

Re: [PATCH] MAINTAINERS: Add x86 early-quirks.c file pattern to PCI subsystem

2018-11-08 Thread Bjorn Helgaas
On Wed, Oct 24, 2018 at 05:13:59PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > arch/x86/kernel/early-quirks.c contains special PCI quirks that need to > run even before the usual DECLARE_PCI_FIXUP_EARLY() quirks. These have > typically been merged by the x86 maintainers

Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected

2018-11-07 Thread Bjorn Helgaas
On Tue, Sep 18, 2018 at 05:15:00PM -0500, Alexandru Gagniuc wrote: > When a PCI device is gone, we don't want to send IO to it if we can > avoid it. We expose functionality via the irq_chip structure. As > users of that structure may not know about the underlying PCI device, > it's our

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-05 Thread Bjorn Helgaas
[+cc Takashi, Andy, Colin, Myron for potential distro impact] [Beginning of thread: https://lore.kernel.org/linux-pci/20181102181055.130531-1-brian.wo...@amd.com/] On Sat, Nov 03, 2018 at 12:29:48AM +0100, Borislav Petkov wrote: > On Fri, Nov 02, 2018 at 02:59:25PM -0500, Bjorn Helgaas wr

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Bjorn Helgaas
since v5 by Elie M.: > > -> move DMA mapping from the platform driver to the PCI driver > -> attempt to find the platform device's PCI parent through the _DEP ACPI > method >(if not found take the first MP2 device registred in the i2c-amd-pci-mp2 >driver, like befo

Re: [PATCH 1/3] PCI/AER: Option to leave System Error Interrupts as-is

2018-10-29 Thread Bjorn Helgaas
[+cc Rafael, Len, Tony, Borislav, Tyler, Christoph, linux-acpi, LKML] On Fri, Oct 26, 2018 at 02:19:04PM -0600, Jon Derrick wrote: > Add a bit in pci_host_bridge to indicate to leave the System Error > Interrupts as configured by the pre-boot environment. Propagate this to > the AER driver which

Re: [PATCH] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor

2018-10-29 Thread Bjorn Helgaas
On Fri, Oct 26, 2018 at 02:20:21AM +, Z.q. Hou wrote: > > From: Bjorn Helgaas > > Holy cow, this has been broken since v4.14. If fixing this makes > > a difference, you might want to tag it for stable. > > How can I tag it for stable? https://git.kernel.org/cgit/l

Re: [PATCH] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor

2018-10-25 Thread Bjorn Helgaas
$ git log --oneline --follow drivers/pci/controller/dwc/pci-layerscape.c | head 6e0832fa432e PCI: Collect all native drivers under drivers/pci/controller/ 3f43ccc4ea1b PCI: dwc: Remove old MSI IRQs API 8cfab3cf63cf PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate 84d897d69938 PCI:

[PATCH] MAINTAINERS: Add x86 early-quirks.c file pattern to PCI subsystem

2018-10-24 Thread Bjorn Helgaas
From: Bjorn Helgaas arch/x86/kernel/early-quirks.c contains special PCI quirks that need to run even before the usual DECLARE_PCI_FIXUP_EARLY() quirks. These have typically been merged by the x86 maintainers, which is fine, but PCI folks should at least see what's happening, so add a file

Re: [PATCH v3] i2c:amd I2C Driver based on PCI Interface for upcoming, platform

2018-10-24 Thread Bjorn Helgaas
On Thu, Oct 25, 2018 at 01:26:51AM +0800, Kai Heng Feng wrote: > > On Sep 17, 2018, at 16:19, Kai-Heng Feng > > wrote: > > at 18:54, Shah, Nehal-bakulchandra wrote: > > > >> From: Nehal-bakulchandra Shah > >> > >> This contains two drivers. > >> 1)i2c-amd-platdrv: This is based on I2C

Re: HP DL585 warm boot fail (old)

2018-10-24 Thread Bjorn Helgaas
On Wed, Oct 24, 2018 at 05:47:17PM +0300, Meelis Roos wrote: > > Can you try the patch below? This is extracted from the code here: > > https://github.com/joyent/illumos-joyent/blob/b6a0b04d591f5b877cfe05f45e81f0e8a5cfc2b3/usr/src/uts/intel/io/pci/pci_boot.c#L1805 > > Thank you. Unfortunately it

Re: HH DL585 warm boot fail (old)

2018-10-24 Thread Bjorn Helgaas
On Wed, Oct 24, 2018 at 10:47:24AM +0300, Meelis Roos wrote: > > Would you mind opening a report at https://bugzilla.kernel.org? I'm > > not sure if anybody will be able to do anything about this, but it's > > always possible. > > Submitted now, https://bugzilla.kernel.org/show_bug.cgi?id=201503

[GIT PULL] PCI changes for v4.20

2018-10-23 Thread Bjorn Helgaas
on of many VFs (KarimAllah Ahmed) - Remove unnecessary include (Bjorn Helgaas) - Fix VMD AERSID quirk Device ID matching (Jon Derrick) - Fix Cadence PHY handling during probe (Alan Douglas) - Signal Cadence Endpoint interrupts via AXI region 0 instead of last region (Alan Douglas) -

Re: [PATCH v4] PCI/AER: Enable error reporting for all ports

2018-10-18 Thread Bjorn Helgaas
On Thu, Oct 18, 2018 at 05:03:13PM -0600, Keith Busch wrote: > On Thu, Oct 18, 2018 at 03:53:58PM -0500, Bjorn Helgaas wrote: > > Change the AER service driver so it binds to *all* PCIe Ports, > > including Switch Upstream and Downstream Ports. Enable AER error > > reportin

[PATCH v4] PCI/AER: Enable error reporting for all ports

2018-10-18 Thread Bjorn Helgaas
From: Bjorn Helgaas Previously we enabled AER error reporting only for Switch Ports that were enumerated prior to registering the AER service driver. Switch Ports enumerated after AER driver registration were left with error reporting disabled. A common order, which works correctly, is that we

Re: [PATCH v3] PCI/AER: Enable reporting for ports enumerated after AER driver registration

2018-10-18 Thread Bjorn Helgaas
On Fri, Oct 12, 2018 at 04:16:04PM +0800, Dongdong Liu wrote: > 在 2018/10/11 23:57, Keith Busch 写道: > > On Thu, Oct 11, 2018 at 08:26:18AM -0700, Bjorn Helgaas wrote: > > > From: Bjorn Helgaas > > > > > > Previously we enabled AER error reporting only for Swi

Re: [PATCH v3] PCI/AER: Enable reporting for ports enumerated after AER driver registration

2018-10-18 Thread Bjorn Helgaas
On Thu, Oct 11, 2018 at 09:57:16AM -0600, Keith Busch wrote: > On Thu, Oct 11, 2018 at 08:26:18AM -0700, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Previously we enabled AER error reporting only for Switch Ports that were > > enumerated prior to registe

Re: [PATCH] PCI: pcie: remove redundant 'default n' from Kconfig

2018-10-18 Thread Bjorn Helgaas
On Tue, Oct 16, 2018 at 04:38:13PM +0200, Bartlomiej Zolnierkiewicz wrote: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible

Re: [PATCH] PCI/P2PDMA: Fix NULL check in pci_p2pmem_publish()

2018-10-17 Thread Bjorn Helgaas
On Wed, Oct 17, 2018 at 10:05:10AM -0600, Logan Gunthorpe wrote: > We should only assign 'p2pmem_published' if 'pdev->p2pdma' is not NULL. > The extra check on 'publish' makes no sense. > > Signed-off-by: Logan Gunthorpe > Reported-by: Dan Carpenter > Cc: Bjorn Helgaas &g

Re: [PATCH v9 2/9] PCI: Using PCI configuration space header type instead of class type to assign resource

2018-10-17 Thread Bjorn Helgaas
PCI r3.0 sec 6.1, PCIe r4.0 sec 7.5.1.1.9) while the > > resource assignment is based on the configuration space layout instead > > of its class type. Using configuration space header type instead of > > class type for the resource assignment. > > > > Sugg

Re: [PATCH v8 2/9] PCI: mediatek: Fix class type for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-15 Thread Bjorn Helgaas
On Mon, Oct 15, 2018 at 04:08:53PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The commit 101c92dc80c8 ("PCI: mediatek: Set up vendor ID and class > type for MT7622") have set the class type for MT7622 as un-properly > value of PCI_CLASS_BRIDGE_HOST. > > The PCIe

Re: [PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-15 Thread Bjorn Helgaas
On Mon, Oct 15, 2018 at 10:42:23AM +0800, Honghui Zhang wrote: > On Fri, 2018-10-12 at 09:12 -0500, Bjorn Helgaas wrote: > > On Fri, Oct 12, 2018 at 11:22:30AM +0100, Lorenzo Pieralisi wrote: > > > On Fri, Oct 12, 2018 at 04:01:29PM +0800, Honghui Zhang wrote: > > >&g

Re: [PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-12 Thread Bjorn Helgaas
On Fri, Oct 12, 2018 at 11:22:30AM +0100, Lorenzo Pieralisi wrote: > On Fri, Oct 12, 2018 at 04:01:29PM +0800, Honghui Zhang wrote: >> On Thu, 2018-10-11 at 12:38 +0100, Lorenzo Pieralisi wrote: >>> On Tue, Oct 09, 2018 at 11:08:15AM +0800, Honghui Zhang wrote: On Mon, 2018-10-08 at 18:23

Re: [PATCH v2] PCI/IOV: Use VF0 cached config space size for other VFs

2018-10-11 Thread Bjorn Helgaas
n when enabling SR-IOV on a device with many VFs. > > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: KarimAllah Ahmed Applied to pci/virtualization for v4.20, thanks! As I mentioned last time, I think CONFIG_PCI_ATS is the w

[PATCH v3] PCI/AER: Enable reporting for all ports

2018-10-11 Thread Bjorn Helgaas
--- Bjorn Helgaas (1): PCI/AER: Enable reporting for ports enumerated after AER driver registration drivers/pci/pcie/aer.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-)

[PATCH v3] PCI/AER: Enable reporting for ports enumerated after AER driver registration

2018-10-11 Thread Bjorn Helgaas
From: Bjorn Helgaas Previously we enabled AER error reporting only for Switch Ports that were enumerated prior to registering the AER service driver. Switch Ports enumerated after AER driver registration were left with error reporting disabled. A common order, which works correctly, is that we

Re: [PATCH] PCI/portdrv: Enable error reporting on managed ports

2018-10-11 Thread Bjorn Helgaas
On Thu, Oct 11, 2018 at 07:58:47PM +0800, Dongdong Liu wrote: > Hi Bjorn > > > commit 15a6711649915ca3e9d1086dc88ff4b616b99aac > > Author: Bjorn Helgaas > > Date: Tue Oct 9 17:25:25 2018 -0500 > > > > PCI/AER: Enable reporting for ports enumerate

Re: [PATCH v9 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory

2018-10-10 Thread Bjorn Helgaas
On Wed, Oct 10, 2018 at 05:03:33PM -0600, Logan Gunthorpe wrote: > > > On 2018-10-10 2:19 p.m., Bjorn Helgaas wrote: > > I added the reviewed-by tags from Christoph, Jens' ack on the blkdev.h > > change, and applied these to pci/peer-to-peer with the intent of > &

Re: [PATCH v2] PCI: Fix Switchtec DMA aliasing quirk dmesg noise

2018-10-10 Thread Bjorn Helgaas
hange as much code if > we ever have to adjust the list). > > Reported-by: Stephen Bates > Cc: Doug Meyer > Cc: Bjorn Helgaas > Cc: Kurt Schwemmer > Fixes: ad281ecf1c7d ("PCI: Add DMA alias quirk for Microsemi Switchtec NTB") > Signed-off-by: Logan Gunthorpe Appl

Re: [PATCH 3/3] PCI: remove pci_set_dma_max_seg_size

2018-10-10 Thread Bjorn Helgaas
[+cc maintainers] On Tue, Oct 09, 2018 at 04:08:24PM +0200, Christoph Hellwig wrote: > The few callers can just use dma_set_max_seg_size directly. I intend to apply this, just FYI about these trivial changes to your drivers. > Signed-off-by: Christoph Hellwig > --- >

Re: [PATCH 2/3] PCI: remove pci_set_dma_seg_boundary

2018-10-10 Thread Bjorn Helgaas
[+cc s390 network maintainers] On Tue, Oct 09, 2018 at 04:08:23PM +0200, Christoph Hellwig wrote: > The two callers can just use dma_set_seg_boundary directly. I intend to apply this trivial patch, so just FYI. > Signed-off-by: Christoph Hellwig > --- > drivers/pci/probe.c| 2 +- >

Re: [PATCH 1/3] PCI: remove DMA unmap wrappers

2018-10-10 Thread Bjorn Helgaas
[+cc folks from MAINTAINERS] On Tue, Oct 09, 2018 at 04:08:22PM +0200, Christoph Hellwig wrote: > Only some of these were still used by the cxgb4 driver, and that despite > the fact that the driver otherwise uses the generic DMA API. This is trivial and I intend to apply it, so just copying

Re: [PATCH] PCI/portdrv: Enable error reporting on managed ports

2018-10-09 Thread Bjorn Helgaas
On Tue, Oct 09, 2018 at 07:51:58PM +, Derrick, Jonathan wrote: > On Tue, 2018-10-09 at 12:56 -0500, Bjorn Helgaas wrote: > > On Tue, Sep 04, 2018 at 12:33:09PM -0600, Jon Derrick wrote: > > > During probe, the port driver will disable error reporting and > > > assum

Re: [PATCH] PCI/portdrv: Enable error reporting on managed ports

2018-10-09 Thread Bjorn Helgaas
On Tue, Sep 04, 2018 at 12:33:09PM -0600, Jon Derrick wrote: > During probe, the port driver will disable error reporting and assumes > it will be enabled later by the AER driver's pci_walk_bus() sequence. > This may not be the case for host-bridge enabled root ports, who will > enable first error

[tip:x86/mm] resource: Fix find_next_iomem_res() iteration issue

2018-10-09 Thread tip-bot for Bjorn Helgaas
Commit-ID: 010a93bf97c72f43aac664d0a685942f83d1a103 Gitweb: https://git.kernel.org/tip/010a93bf97c72f43aac664d0a685942f83d1a103 Author: Bjorn Helgaas AuthorDate: Thu, 27 Sep 2018 09:22:09 -0500 Committer: Borislav Petkov CommitDate: Tue, 9 Oct 2018 17:18:36 +0200 resource: Fix

[tip:x86/mm] resource: Include resource end in walk_*() interfaces

2018-10-09 Thread tip-bot for Bjorn Helgaas
Commit-ID: a98959fdbda1849a01b2150bb635ed559ec06700 Gitweb: https://git.kernel.org/tip/a98959fdbda1849a01b2150bb635ed559ec06700 Author: Bjorn Helgaas AuthorDate: Thu, 27 Sep 2018 09:22:02 -0500 Committer: Borislav Petkov CommitDate: Tue, 9 Oct 2018 17:18:34 +0200 resource: Include

[tip:x86/mm] x86/kexec: Correct KEXEC_BACKUP_SRC_END off-by-one error

2018-10-09 Thread tip-bot for Bjorn Helgaas
Commit-ID: 51fbf14f2528a8c6401290e37f1c893a2412f1d3 Gitweb: https://git.kernel.org/tip/51fbf14f2528a8c6401290e37f1c893a2412f1d3 Author: Bjorn Helgaas AuthorDate: Thu, 27 Sep 2018 09:21:55 -0500 Committer: Borislav Petkov CommitDate: Tue, 9 Oct 2018 17:18:31 +0200 x86/kexec: Correct

Re: x86/mm: Found insecure W+X mapping at address (ptrval)/0xc00a0000

2018-10-08 Thread Bjorn Helgaas
On Mon, Oct 8, 2018 at 2:37 PM Thomas Gleixner wrote: > > Paul, > > On Fri, 5 Oct 2018, Paul Menzel wrote: > > On 10/05/18 11:27, Thomas Gleixner wrote: > > > If pcibios is enabled and used, need to look at the gory details of that > > > first, then the W+X check has to exclude that region. We

Re: [PATCH] PCI: expand the "PF" acronym in Kconfig help text

2018-10-08 Thread Bjorn Helgaas
On Sat, Oct 06, 2018 at 08:56:33PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Tell users what a PCI PF is in the PCI_PF_STUB config help text. > > Fixes: a8ccf8a3 ("PCI/IOV: Add pci-pf-stub driver for PFs that only > enable VFs") > > Signed-off-by: Randy Dunlap > Cc: Alexander

Re: [PATCH v6 0/9] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-10-08 Thread Bjorn Helgaas
On Mon, Oct 08, 2018 at 11:24:39AM +0800, honghui.zh...@mediatek.com wrote: > Honghui Zhang (9): > PCI: mediatek: Using slot's devfn for compare to fix > mtk_pcie_find_port logic > PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI > PCI: mediatek: Remove the redundant

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-08 Thread Bjorn Helgaas
On Mon, Oct 08, 2018 at 10:18:47AM -0600, Keith Busch wrote: > On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > > [+cc arm64 folks, LKML: This conversation is about this patch: > > > > > > https://lore.kernel.org/linux-pci/20180918235848.26

[GIT PULL] PCI fixes for v4.19

2018-10-05 Thread Bjorn Helgaas
PCI fixes: - Reprogram bridge prefetch registers to fix NVIDIA and Radeon issues after suspend/resume (Daniel Drake) - Fix mvebu I/O mapping creation sequence (Thomas Petazzoni) - Fix minor MAINTAINERS file match issue (Bjorn Helgaas) The following changes since commit

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-05 Thread Bjorn Helgaas
. Note that this question is only about the error *injection* module used for testing. It doesn't affect AER support itself.] On Thu, Oct 04, 2018 at 04:11:37PM -0600, Keith Busch wrote: > On Thu, Oct 04, 2018 at 04:40:15PM -0500, Bjorn Helgaas wrote: > > On Tue, Sep 18, 2018 at 05:58:3

Re: [PATCH] PCI / ACPI: Mark expected switch fall-through

2018-10-04 Thread Bjorn Helgaas
On Thu, Oct 04, 2018 at 05:40:41PM +0200, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1472052 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Applied to

Re: [PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep

2018-10-03 Thread Bjorn Helgaas
f-by: Lance Roy > Cc: Bjorn Helgaas > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: > Cc: I assume you plan to merge the whole series together. I don't object to that, but I don't know enough to be able to formally ack t

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-10-02 Thread Bjorn Helgaas
On Mon, Oct 01, 2018 at 03:40:51PM -0500, Bjorn Helgaas wrote: > I think the names "pci_device_is_present()" and > "mpt3sas_base_pci_device_is_available()" contribute to the problem > because they make promises that can't be kept -- all we can say is > that the d

Re: linux-next: build warnings after merge of the pci tree

2018-10-02 Thread Bjorn Helgaas
On Mon, Oct 1, 2018 at 7:26 PM Stephen Rothwell wrote: > > Hi Bjorn, > > After merging the pci tree, today's linux-next build (powerpc > ppc64_defconfig) produced these warning: > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function > 'ixgbe_io_slot_reset': >

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-10-01 Thread Bjorn Helgaas
On Mon, Oct 01, 2018 at 02:51:48PM +0200, Thomas Petazzoni wrote: > Hello, > > On Mon, 01 Oct 2018 12:56:37 +0200, Jan Kundrát wrote: > > > Thomas, Russell, Lorenzo, > > did you have time to convert this into a patch which can hit 4.19? I don't > > see anything related in 4.19-rc6, but perhaps

Re: Bad MAINTAINERS pattern in section 'ACPI'

2018-10-01 Thread Bjorn Helgaas
On Fri, Sep 28, 2018 at 06:06:17PM -0500, Bjorn Helgaas wrote: > [+cc Tony, Borislav (ACPI APEI reviewers), linux-pci] > > On Fri, Sep 28, 2018 at 02:50:53PM -0700, Joe Perches wrote: > > Please fix this defect appropriately. > > > > linux-next MAINTAINERS section

Re: Bad MAINTAINERS pattern in section 'ACPI'

2018-09-28 Thread Bjorn Helgaas
vers/pci/*/*acpi* > --> 327 F: drivers/pci/*/*/*acpi* > 328 F: tools/power/acpi/ My proposal to fix this: commit a99051c0d3c59fd259fd76a8bbd9837b76b509d9 Author: Bjorn Helgaas Date: Fri Sep 28 17:34:21 2018 -0500 MAINTAINERS: Remove obsolete drivers/p

Re: [PATCH v3] PCI: Reprogram bridge prefetch registers on resume

2018-09-27 Thread Bjorn Helgaas
[+cc LKML] On Tue, Sep 18, 2018 at 04:32:44PM -0500, Bjorn Helgaas wrote: > On Thu, Sep 13, 2018 at 11:37:45AM +0800, Daniel Drake wrote: > > On 38+ Intel-based Asus products, the nvidia GPU becomes unusable > > after S3 suspend/resume. The affected products include multiple

[GIT PULL] PCI fixes for v4.19

2018-09-27 Thread Bjorn Helgaas
PCI fixes: - Fix ACPI hotplug issue that causes black screen crash at boot (Mika Westerberg) - Fix DesignWare "scheduling while atomic" issues (Jisheng Zhang) - Add PPC contacts to MAINTAINERS for PCI core error handling (Bjorn Helgaas) - Sort Mobiveil MAINTAI

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-27 Thread Bjorn Helgaas
Wed, Sep 26, 2018 at 04:32:41PM -0500, Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:34AM +0530, Suganath Prabu S wrote: > > > @@ -6853,6 +6872,13 @@ mpt3sas_wait_for_commands_to_complete(struct > > > MPT3SAS_ADAPTER *ioc) > > >

[PATCH 3/3] resource: Fix find_next_iomem_res() iteration issue

2018-09-27 Thread Bjorn Helgaas
From: Bjorn Helgaas Previously find_next_iomem_res() used "*res" as both an input parameter for the range to search and the type of resource to search for, and an output parameter for the resource we found, which makes the interface confusing. The current callers use find_next

[PATCH 2/3] resource: Include resource end in walk_*() interfaces

2018-09-27 Thread Bjorn Helgaas
From: Bjorn Helgaas find_next_iomem_res() finds an iomem resource that covers part of a range described by "start, end". All callers expect that range to be inclusive, i.e., both start and end are included, but find_next_iomem_res() doesn't handle the end address correctly. I

[PATCH 1/3] x86/kexec: Correct KEXEC_BACKUP_SRC_END off-by-one error

2018-09-27 Thread Bjorn Helgaas
From: Bjorn Helgaas The only use of KEXEC_BACKUP_SRC_END is as an argument to walk_system_ram_res(): int crash_load_segments(struct kimage *image) { ... walk_system_ram_res(KEXEC_BACKUP_SRC_START, KEXEC_BACKUP_SRC_END, image, determine_backup_region

[PATCH 0/3] find_next_iomem_res() fixes

2018-09-27 Thread Bjorn Helgaas
to avoid deciding and merging these myself, but I'm not sure who really wants to own kernel/resource.c. [1] https://lore.kernel.org/lkml/01551d06-c421-5df3-b19f-fc66f3639...@redhat.com [2] https://lore.kernel.org/lkml/20180921073211.20097-2-liji...@redhat.com --- Bjorn Helgaas (3): x86/kexec

Re: [PATCH 3/3] resource: Fix find_next_iomem_res() iteration issue

2018-09-27 Thread Bjorn Helgaas
On Thu, Sep 27, 2018 at 01:27:41PM +0800, lijiang wrote: > 在 2018年09月25日 06:15, Bjorn Helgaas 写道: > > From: Bjorn Helgaas > > > > Previously find_next_iomem_res() used "*res" as both an input parameter for > > the range to search and the type of

Re: [PATCH v3] PCI: Equalize hotplug memory and io for non/occupied slots

2018-09-26 Thread Bjorn Helgaas
On Tue, Sep 25, 2018 at 12:39:06PM -0600, Jon Derrick wrote: > Currently, a hotplug bridge will be given hpmemsize additional memory > and hpiosize additional io if available, in order to satisfy any future > hotplug allocation requirements. > > These calculations don't consider the current

Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-26 Thread Bjorn Helgaas
[+cc Sinan, LKML] On Tue, Sep 18, 2018 at 04:20:29AM -0400, Oza Pawandeep wrote: > PCI based device drivers handles ERR_NONFATAL by registering > pci_error_handlers. some of the drivers clear AER uncorrectable status > in slot_reset while some in resume. > > Drivers should not have

Re: linux-next: build failure after merge of the pci tree

2018-09-26 Thread Bjorn Helgaas
On Wed, Sep 26, 2018 at 9:56 AM Keith Busch wrote: > > On Wed, Sep 26, 2018 at 08:25:40AM -0600, Keith Busch wrote: > > On Wed, Sep 26, 2018 at 03:00:51PM +1000, Stephen Rothwell wrote: > > > Hi Bjorn, > > > > > > After merging the pci tree, today's linux-next build (powerpc allnoconfig) > > >

Re: [PATCH -next] PCI: hotplug: Remove set but not used variable 'physical_slot'

2018-09-26 Thread Bjorn Helgaas
On Wed, Sep 26, 2018 at 11:06:02AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/pci/hotplug/cpqphp_core.c: In function 'init_SERR': > drivers/pci/hotplug/cpqphp_core.c:124:5: warning: > variable 'physical_slot' set but not used [-Wunused-but-set-variable]

[PATCH 1/3] x86/kexec: Correct KEXEC_BACKUP_SRC_END off-by-one error

2018-09-24 Thread Bjorn Helgaas
From: Bjorn Helgaas The only use of KEXEC_BACKUP_SRC_END is as an argument to walk_system_ram_res(): int crash_load_segments(struct kimage *image) { ... walk_system_ram_res(KEXEC_BACKUP_SRC_START, KEXEC_BACKUP_SRC_END, image, determine_backup_region

Re: [PATCH v6 03/13] PCI/P2PDMA: Add PCI p2pmem DMA mappings to adjust the bus offset

2018-09-21 Thread Bjorn Helgaas
On Fri, Sep 21, 2018 at 12:13:21PM -0600, Logan Gunthorpe wrote: > On 2018-09-21 10:48 AM, Bjorn Helgaas wrote: > >> I think the use of "map" in this context is slightly confusing because the > >> general expectation is that map/unmap must be balanced. >

Re: [PATCH v6 06/13] PCI/P2PDMA: Add P2P DMA driver writer's documentation

2018-09-21 Thread Bjorn Helgaas
index for the PCI documentation tree even though this > is the only PCI document that has been converted to restructured text > at this time. > > Signed-off-by: Logan Gunthorpe Acked-by: Bjorn Helgaas > +With the client list in hand, the orchestrator may then call > +:

Re: [PATCH v6 02/13] PCI/P2PDMA: Add sysfs group to display p2pmem stats

2018-09-21 Thread Bjorn Helgaas
it is published or not. > > Signed-off-by: Logan Gunthorpe Acked-by: Bjorn Helgaas > +What:/sys/bus/pci/devices/.../p2pmem/available > +Date:November 2017 > +Contact: Logan Gunthorpe > +Description: > + If the device ha

Re: [PATCH v3] PCI: dwc: fix scheduling while atomic issues

2018-09-20 Thread Bjorn Helgaas
On Thu, Sep 13, 2018 at 04:05:54PM +0100, Lorenzo Pieralisi wrote: > On Wed, Aug 29, 2018 at 11:04:08AM +0800, Jisheng Zhang wrote: > > When programming inbound/outbound atu, we call usleep_range() after > > each checking PCIE_ATU_ENABLE bit. Unfortunately, the atu programming > > can be called in

Re: [PATCH v2] PCI hotplug Eq v2

2018-09-17 Thread Bjorn Helgaas
On Thu, Aug 30, 2018 at 04:11:59PM -0600, Jon Derrick wrote: > Hi Bjorn, > > Sorry for the delay on this one and pushing it after RC1. > Feel free to queue it up for 4.20 if it looks fine. > > I've added comments to the git log and source explaining why > calculate_iosize was left unchanged.

  1   2   3   4   5   6   7   8   9   10   >