[PATCH v2] mmc: core: Extend sysfs with DSR register

2016-07-19 Thread Bojan Prtvar
Export DSR register through sysfs same as we did for the CID, CSD and OCR registers. Signed-off-by: Bojan Prtvar <prtva...@gmail.com> --- v2: Extended to cover SD cards Documentation/mmc/mmc-dev-attrs.txt | 1 + drivers/mmc/core/mmc.c | 17 + drivers/mm

[PATCH v2] mmc: core: Extend sysfs with DSR register

2016-07-19 Thread Bojan Prtvar
Export DSR register through sysfs same as we did for the CID, CSD and OCR registers. Signed-off-by: Bojan Prtvar --- v2: Extended to cover SD cards Documentation/mmc/mmc-dev-attrs.txt | 1 + drivers/mmc/core/mmc.c | 17 + drivers/mmc/core/sd.c | 17

[PATCH] mmc: sd: Extend sysfs with OCR register

2016-07-13 Thread Bojan Prtvar
We already exported OCR for mmc cards. Let's export it for sd cards as well. Signed-off-by: Bojan Prtvar <prtva...@gmail.com> --- drivers/mmc/core/sd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index b95bd24..3dd0861 100644 --- a/d

[PATCH] mmc: sd: Extend sysfs with OCR register

2016-07-13 Thread Bojan Prtvar
We already exported OCR for mmc cards. Let's export it for sd cards as well. Signed-off-by: Bojan Prtvar --- drivers/mmc/core/sd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index b95bd24..3dd0861 100644 --- a/drivers/mmc/core/sd.c +++ b

[PATCH] mmc: core: Extend sysfs with DSR register

2016-07-12 Thread Bojan Prtvar
Export DSR register through sysfs same as we did for the CID, CSD and OCR registers. Signed-off-by: Bojan Prtvar <prtva...@gmail.com> --- Documentation/mmc/mmc-dev-attrs.txt | 1 + drivers/mmc/core/mmc.c | 17 + 2 files changed, 18 insertions(+) diff

[PATCH] mmc: core: Extend sysfs with DSR register

2016-07-12 Thread Bojan Prtvar
Export DSR register through sysfs same as we did for the CID, CSD and OCR registers. Signed-off-by: Bojan Prtvar --- Documentation/mmc/mmc-dev-attrs.txt | 1 + drivers/mmc/core/mmc.c | 17 + 2 files changed, 18 insertions(+) diff --git a/Documentation/mmc/mmc-dev

Re: [PATCH] mmc: core: Extend sysfs with OCR register

2016-07-12 Thread bojan prtvar
Hi Ulf, On Tue, Jul 12, 2016 at 11:53 AM, Ulf Hansson wrote: > I just realized that the OCR register is also available for SD cards. > > Could you perhaps cook a patch which adds this to sysfs for SD cards as well!? > Sure. I'll do it tomorrow. Regards, Bojan

Re: [PATCH] mmc: core: Extend sysfs with OCR register

2016-07-12 Thread bojan prtvar
Hi Ulf, On Tue, Jul 12, 2016 at 11:53 AM, Ulf Hansson wrote: > I just realized that the OCR register is also available for SD cards. > > Could you perhaps cook a patch which adds this to sysfs for SD cards as well!? > Sure. I'll do it tomorrow. Regards, Bojan

Re: [PATCH] mmc: core: Extend sysfs with OCR register

2016-07-04 Thread bojan prtvar
Hi, On Mon, Jul 4, 2016 at 4:13 PM, Wolfram Sang wrote: >> Make operation conditions register (OCR) easily accessible from user space. >> > You described "what" above. Can you add the "why", too? > According to JEDEC v5.0 chapter 7 the OCR, CID and CSD registers carry the

Re: [PATCH] mmc: core: Extend sysfs with OCR register

2016-07-04 Thread bojan prtvar
Hi, On Mon, Jul 4, 2016 at 4:13 PM, Wolfram Sang wrote: >> Make operation conditions register (OCR) easily accessible from user space. >> > You described "what" above. Can you add the "why", too? > According to JEDEC v5.0 chapter 7 the OCR, CID and CSD registers carry the Device/content

[PATCH] mmc: core: Extend sysfs with OCR register

2016-07-04 Thread Bojan Prtvar
Make operation conditions register (OCR) easily accessible from user space. Signed-off-by: Bojan Prtvar <prtva...@gmail.com> --- Documentation/mmc/mmc-dev-attrs.txt | 1 + drivers/mmc/core/mmc.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/mmc/m

[PATCH] mmc: core: Extend sysfs with OCR register

2016-07-04 Thread Bojan Prtvar
Make operation conditions register (OCR) easily accessible from user space. Signed-off-by: Bojan Prtvar --- Documentation/mmc/mmc-dev-attrs.txt | 1 + drivers/mmc/core/mmc.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/mmc/mmc-dev-attrs.txt b/Documentation

Re: [PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread bojan prtvar
On Tue, Dec 29, 2015 at 2:36 PM, Laurent Navet wrote: > why not directly ? > > struct region_devres *dr = devres_alloc(devm_region_release, > sizeof(struct region_devres),.. > I follow Dan's rationale [1] [1] http://www.spinics.net/lists/target-devel/msg11355.html -- To unsubscribe from this

[PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread Bojan Prtvar
Few lines below dr is reinitialized by devres_alloc() so we don't need to init it by NULL in the beginning of __devm_request_region() Signed-off-by: Bojan Prtvar --- kernel/resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/resource.c b/kernel/resource.c index

Re: [PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread bojan prtvar
On Tue, Dec 29, 2015 at 2:36 PM, Laurent Navet wrote: > why not directly ? > > struct region_devres *dr = devres_alloc(devm_region_release, > sizeof(struct region_devres),.. > I follow Dan's rationale [1] [1] http://www.spinics.net/lists/target-devel/msg11355.html -- To

[PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread Bojan Prtvar
Few lines below dr is reinitialized by devres_alloc() so we don't need to init it by NULL in the beginning of __devm_request_region() Signed-off-by: Bojan Prtvar <prtva...@gmail.com> --- kernel/resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/resour

[PATCH] netfilter: xtables: Remove unnecessary initialization of struct ts_state

2014-09-08 Thread Bojan Prtvar
The skb_find_text() accepts uninitialized textsearch state variable. Signed-off-by: Bojan Prtvar --- net/netfilter/xt_string.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/netfilter/xt_string.c b/net/netfilter/xt_string.c index d3c48b1..5699adb 100644 --- a/net/netfilter/xt_string.c

[PATCH] netfilter: xtables: Remove unnecessary initialization of struct ts_state

2014-09-08 Thread Bojan Prtvar
The skb_find_text() accepts uninitialized textsearch state variable. Signed-off-by: Bojan Prtvar prtva...@gmail.com --- net/netfilter/xt_string.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/netfilter/xt_string.c b/net/netfilter/xt_string.c index d3c48b1..5699adb 100644 --- a/net

Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-19 Thread bojan prtvar
On Sat, Apr 19, 2014 at 9:58 AM, bojan prtvar wrote: > On Sat, Apr 19, 2014 at 1:23 AM, Greg KH wrote: >> On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: >>> This fixes the following sparse warnings: >>> drivers/staging/crystalhd/crystalhd_l

Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-19 Thread bojan prtvar
On Sat, Apr 19, 2014 at 1:23 AM, Greg KH wrote: > On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: >> This fixes the following sparse warnings: >> drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol >> 'chd_dec_pci_suspend' was not declared

Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-19 Thread bojan prtvar
On Sat, Apr 19, 2014 at 1:23 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: This fixes the following sparse warnings: drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol 'chd_dec_pci_suspend' was not declared. Should

Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-19 Thread bojan prtvar
On Sat, Apr 19, 2014 at 9:58 AM, bojan prtvar prtva...@gmail.com wrote: On Sat, Apr 19, 2014 at 1:23 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: This fixes the following sparse warnings: drivers/staging/crystalhd/crystalhd_lnx.c

[PATCH] Staging: crystalhd: Mark local functions as static

2014-04-18 Thread Bojan Prtvar
? drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning: symbol 'chd_dec_alloc_iodata' was not declared. Should it be static? drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning: symbol 'chd_dec_free_iodata' was not declared. Should it be static? Signed-off-by: Bojan Prtvar --- drivers

[PATCH] Staging: crystalhd: Mark local functions as static

2014-04-18 Thread Bojan Prtvar
? drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning: symbol 'chd_dec_alloc_iodata' was not declared. Should it be static? drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning: symbol 'chd_dec_free_iodata' was not declared. Should it be static? Signed-off-by: Bojan Prtvar prtva...@gmail.com

Re: checkpatch guide for newbies

2013-09-23 Thread bojan prtvar
Hi Dan, On Mon, Sep 23, 2013 at 11:01 AM, Dan Carpenter wrote: > I've written a checkpatch guide for newbies because it seems like they > make the same mistakes over and over. I intend to put it under > Documentation/. Could you look it over? Maybe to add a paragraph about general work flow

Re: checkpatch guide for newbies

2013-09-23 Thread bojan prtvar
Hi Dan, On Mon, Sep 23, 2013 at 11:01 AM, Dan Carpenter dan.carpen...@oracle.com wrote: I've written a checkpatch guide for newbies because it seems like they make the same mistakes over and over. I intend to put it under Documentation/. Could you look it over? Maybe to add a paragraph