Re: [PATCHv2] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-16 Thread Brendan McGrath
CHECKSUM --checksum-fill So I think this patch can be withdrawn in favour of one of these two workarounds. On 16/12/17 05:27, David Miller wrote: From: Brendan McGrath Date: Thu, 14 Dec 2017 22:37:03 +1100 Currently, when forwarding a multicast packet originating from a Virtual Interface

[PATCHv2] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-14 Thread Brendan McGrath
therefore rejected by the receiving machine(s). This patch ensures the checksum is recalculated before forwarding. Signed-off-by: Brendan McGrath --- Changes since PATCH v1: - fixed formatting - clarified in git comment that issue is with packet originating on multicast router - check value of

Re: [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-13 Thread Brendan McGrath
orrect (packet accepted) ip_summed = 1 (CHECKSUM_UNNECESSARY) On 14/12/17 04:52, Eric Dumazet wrote: On Wed, 2017-12-13 at 22:20 +1100, Brendan McGrath wrote: Currently, when forwarding from a Virtual Interface to a Physical Interface, ip_summed is set to a value of CHECKSUM_UNNECESSARY and the UDP checksum h

[PATCH] ipv6: icmp6: Allow icmp messages to be looped back

2017-12-13 Thread Brendan McGrath
to ensure a looped back packet is delivered to the Multicast Router. Signed-off-by: Brendan McGrath --- I considered putting this in mld_sendpack after the call to icmp6_dst_alloc but it looks like igmp6_send could use this fix too. In the end I followed the example set by addrconf_dst_alloc

[PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-13 Thread Brendan McGrath
receiving machine(s). This patch ensures the checksum is recalculated before forwarding. Signed-off-by: Brendan McGrath --- It's a bit ugly putting UDP specific code in this spot - but I'm not aware of any other protocols that are: a) multicast; b) forwarded; and c) checksummed net/ip

[PATCHv3] HID: i2c-hid: Add sleep between POWER ON and RESET

2017-01-06 Thread Brendan McGrath
. But it was discovered the Windows driver has a 1ms delay. As a result, this patch modifies the i2c-hid module to add a sleep inbetween the POWER ON and RESET commands which lasts between 1ms and 5ms. See https://github.com/vlasenko/hid-asus-dkms/issues/24 for further details. Signed-off-by: Brendan

[PATCHv2] HID: i2c-hid: Add sleep between POWER ON and RESET

2017-01-05 Thread Brendan McGrath
. But it was discovered the Windows driver has a 1ms delay. As a result, this patch modifies the i2c-hid module to add a sleep inbetween the POWER ON and RESET commands which lasts between 1ms and 5ms. See https://github.com/vlasenko/hid-asus-dkms/issues/24 for further details. Signed-off-by: Brendan

[PATCH] HID: i2c-hid: Add quirk for sleep before reset

2017-01-04 Thread Brendan McGrath
-off-by: Brendan McGrath --- I considered three approaches for this patch: a) add a hardcoded sleep that would affect all devices; b) add a quirk with a hardcoded sleep value; or c) add a quirk with a configurable sleep value Each was a trade off between flexibility and the amount of code/complexity

[PATCH] HID: asus: Fix keyboard support

2016-12-10 Thread Brendan McGrath
put->name to 'Asus Keyboard' for the keyboard Signed-off-by: Brendan McGrath --- drivers/hid/hid-asus.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 96179b2..34a703c 100644 --- a/drivers/hid/

[PATCH] HID: asus: Add i2c touchpad support

2016-11-29 Thread Brendan McGrath
Update the hid-asus module to add multitouch support for the Asus i2c touchpad. Signed-off-by: Brendan McGrath Signed-off-by: Victor Vlasenko Signed-off-by: Frederik Wenigwieser --- This patch aims to resolve the issue raised here: https://bugzilla.kernel.org/show_bug.cgi?id=120181 The issue

Re: [PATCHv5] [media] saa7164: use an MSI interrupt when available

2015-06-04 Thread Brendan McGrath
orate. Regards, Brendan McGrath On 05/06/15 14:42, Kyle Sanderson wrote: This has been plaguing users for years (there's a number of threads on the Ubuntu board). I've been using revision 1 of the patch without issue since early February. This is from having to constantly reboot the sys

[PATCHv4] [media] saa7164: use an MSI interrupt when available

2015-03-13 Thread Brendan McGrath
e saa7164 chip is in use. A reported example can be found here: http://permalink.gmane.org/gmane.linux.drivers.video-input-infrastructure/83948 Reviewed-by: Steven Toth Signed-off-by: Brendan McGrath --- Changes since v3: - fixes a conflict with a commit (3f845f3c4cf4) made to the media_tree a

[PATCHv3] [media] saa7164: use an MSI interrupt when available

2015-02-28 Thread Brendan McGrath
e in use. A reported example can be found here: http://permalink.gmane.org/gmane.linux.drivers.video-input-infrastructure/83948 Reviewed-by: Steven Toth Signed-off-by: Brendan McGrath --- Changes since v3: * Added link to reported incident in comments * Added Reviewed-by tag from Steven Toth