Re: [PATCH v2 4/6] virtiofs: support bounce buffer backed by scattered pages

On Sat, Mar 09, 2024 at 12:14:23PM +0800, Hou Tao wrote: > Hi, > > On 2/29/2024 11:01 PM, Brian Foster wrote: > > On Wed, Feb 28, 2024 at 10:41:24PM +0800, Hou Tao wrote: > >> From: Hou Tao > >> > >> When reading a file kept in virtiofs from

Re: [PATCH v2 4/6] virtiofs: support bounce buffer backed by scattered pages

On Wed, Feb 28, 2024 at 10:41:24PM +0800, Hou Tao wrote: > From: Hou Tao > > When reading a file kept in virtiofs from kernel (e.g., insmod a kernel > module), if the cache of virtiofs is disabled, the read buffer will be > passed to virtiofs through out_args[0].value instead of pages. Because >

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote: > On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: > > On 2022/9/9 21:01, Brian Foster wrote: > > > Yes.. I don't recall all the internals of the tools and test, but IIRC > > > it relied on discard to perform

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

On Thu, Sep 08, 2022 at 09:46:04PM +0800, Shiyang Ruan wrote: > > > 在 2022/8/4 8:51, Darrick J. Wong 写道: > > On Wed, Aug 03, 2022 at 06:47:24AM +, ruansy.f...@fujitsu.com wrote: > > ... > > > > > > > > > > > > > > > BTW, since these patches (dax + THIS + pmem-unbind) > > > > > > > are >

Re: [PATCH] xfs: fix return of uninitialized value in variable error

gt; retval = xfs_attr_node_hasname(args, ); > if (retval != -ENOATTR && retval != -EEXIST) > goto out; I think it would be nicer to initialize at the top of the function as opposed to try and "preserve" historical behavior, but that nit aside: Reviewed-by: Brian Foster > -- > 2.30.2 >

Re: [PATCH] xfs: Wake CIL push waiters more reliably

On Mon, Feb 15, 2021 at 02:36:38PM +0100, Donald Buczek wrote: > On 13.01.21 22:53, Dave Chinner wrote: > > [...] > > I agree that a throttling fix is needed, but I'm trying to > > understand the scope and breadth of the problem first instead of > > jumping the gun and making the wrong fix for the

Re: [PATCH] xfs: fix boolreturn.cocci warnings

; true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task") > CC: Brian Foster > Reported-by: kernel test robot > Signed-off-by: kernel test robot >

Re: rcu: INFO: rcu_sched self-detected stall on CPU: Workqueue: xfs-conv/md0 xfs_end_io

On Tue, Feb 09, 2021 at 07:43:14AM +1100, Dave Chinner wrote: > On Mon, Feb 08, 2021 at 09:28:24AM -0800, Darrick J. Wong wrote: > > On Mon, Feb 09, 2021 at 09:11:40AM -0800, Paul E. McKenney wrote: > > > On Mon, Feb 08, 2021 at 10:44:58AM -0500, Brian Foster wrote: > > &

Re: rcu: INFO: rcu_sched self-detected stall on CPU: Workqueue: xfs-conv/md0 xfs_end_io

On Mon, Feb 08, 2021 at 09:28:24AM -0800, Darrick J. Wong wrote: > On Mon, Feb 09, 2021 at 09:11:40AM -0800, Paul E. McKenney wrote: > > On Mon, Feb 08, 2021 at 10:44:58AM -0500, Brian Foster wrote: > > > On Mon, Feb 08, 2021 at 06:57:24AM -0800, Paul E. McKenney wrote: >

Re: rcu: INFO: rcu_sched self-detected stall on CPU: Workqueue: xfs-conv/md0 xfs_end_io

On Mon, Feb 08, 2021 at 06:57:24AM -0800, Paul E. McKenney wrote: > On Mon, Feb 08, 2021 at 09:07:24AM -0500, Brian Foster wrote: > > On Fri, Feb 05, 2021 at 09:12:40AM -0800, Paul E. McKenney wrote: > > > On Fri, Feb 05, 2021 at 08:29:06AM +0100, Paul Menzel wrote: > &

Re: rcu: INFO: rcu_sched self-detected stall on CPU: Workqueue: xfs-conv/md0 xfs_end_io

On Fri, Feb 05, 2021 at 09:12:40AM -0800, Paul E. McKenney wrote: > On Fri, Feb 05, 2021 at 08:29:06AM +0100, Paul Menzel wrote: > > Dear Linux folks, > > > > > > On a Dell PowerEdge T630/0NT78X, BIOS 2.8.0 05/23/2018 with Linux 5.4.57, we > > twice saw a self-detected stall on a CPU (October

Re: [PATCH] xfs: fix unused variable warning

variable] > > Remove the variable declaration and open-code it inside > of the assertion. > > Fixes: 303591a0a947 ("xfs: cover the log during log quiesce") > Signed-off-by: Arnd Bergmann > --- I sent basically the same patch[1] about a week ago, but either one is

Re: linux-next: build warning after merge of the xfs tree

ash into the original commit. Brian --- 8< --- >From 6078f06e2bd4c82111a85a2032c39a56654b0be6 Mon Sep 17 00:00:00 2001 From: Brian Foster Date: Mon, 25 Jan 2021 08:22:56 -0500 Subject: [PATCH] xfs: fix unused log variable in xfs_log_cover() The log variable is only used in kernels with asserts enabled. Rem

Re: [PATCH] xfs: set inode size after creating symlink

> Signed-off-by: Jeffrey Mitchell > --- Reviewed-by: Brian Foster > fs/xfs/xfs_symlink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c > index 1f43fd7f3209..c835827ae389 100644 > --- a/fs/xfs/xf

Re: [PATCH] xfs: Wake CIL push waiters more reliably

On Fri, Jan 08, 2021 at 11:56:57AM -0500, Brian Foster wrote: > On Fri, Jan 08, 2021 at 08:54:44AM +1100, Dave Chinner wrote: > > On Mon, Jan 04, 2021 at 11:23:53AM -0500, Brian Foster wrote: > > > On Thu, Dec 31, 2020 at 09:16:11AM +1100, Dave Chinner wrote: > > > >

Re: [PATCH] xfs: Wake CIL push waiters more reliably

On Fri, Jan 08, 2021 at 08:54:44AM +1100, Dave Chinner wrote: > On Mon, Jan 04, 2021 at 11:23:53AM -0500, Brian Foster wrote: > > On Thu, Dec 31, 2020 at 09:16:11AM +1100, Dave Chinner wrote: > > > On Wed, Dec 30, 2020 at 12:56:27AM +0100, Donald Buczek wrote: > > >

Re: [PATCH] xfs: Wake CIL push waiters more reliably

On Thu, Dec 31, 2020 at 09:16:11AM +1100, Dave Chinner wrote: > On Wed, Dec 30, 2020 at 12:56:27AM +0100, Donald Buczek wrote: > > Threads, which committed items to the CIL, wait in the xc_push_wait > > waitqueue when used_space in the push context goes over a limit. These > > threads need to be

Re: v5.10.1 xfs deadlock

On Thu, Dec 17, 2020 at 10:30:37PM +0100, Donald Buczek wrote: > On 17.12.20 20:43, Brian Foster wrote: > > On Thu, Dec 17, 2020 at 06:44:51PM +0100, Donald Buczek wrote: > > > Dear xfs developer, > > > > > > I was doing some testing on a Linux 5.10.1 system wi

Re: v5.10.1 xfs deadlock

On Thu, Dec 17, 2020 at 06:44:51PM +0100, Donald Buczek wrote: > Dear xfs developer, > > I was doing some testing on a Linux 5.10.1 system with two 100 TB xfs > filesystems on md raid6 raids. > > The stress test was essentially `cp -a`ing a Linux source repository with two > threads in

Re: [PATCH -next] fs/xfs: convert comma to semicolon

On Fri, Dec 11, 2020 at 04:41:12PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- Reviewed-by: Brian Foster > fs/xfs/libxfs/xfs_btree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend().

On Thu, Sep 17, 2020 at 09:04:55AM +0100, Christoph Hellwig wrote: > On Wed, Sep 16, 2020 at 09:07:14AM -0400, Brian Foster wrote: > > Dave described the main purpose earlier in this thread [1]. The initial > > motivation is that we've had downstream reports of soft

Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend().

On Wed, Sep 16, 2020 at 09:45:10AM +0100, Christoph Hellwig wrote: > On Tue, Sep 15, 2020 at 05:12:42PM -0700, Darrick J. Wong wrote: > > On Tue, Aug 25, 2020 at 10:49:17AM -0400, Brian Foster wrote: > > > cc Ming > > > > > > On Tue, Aug 25, 2020 at

Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend().

On Mon, Aug 31, 2020 at 12:01:07PM +0800, Ming Lei wrote: > On Tue, Aug 25, 2020 at 10:49:17AM -0400, Brian Foster wrote: > > cc Ming > > > > On Tue, Aug 25, 2020 at 10:42:03AM +1000, Dave Chinner wrote: > > > On Mon, Aug 24, 2020 at 11:48:41AM -0400, Brian Foster

Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend().

cc Ming On Tue, Aug 25, 2020 at 10:42:03AM +1000, Dave Chinner wrote: > On Mon, Aug 24, 2020 at 11:48:41AM -0400, Brian Foster wrote: > > On Mon, Aug 24, 2020 at 04:04:17PM +0100, Christoph Hellwig wrote: > > > On Mon, Aug 24, 2020 at 10:28:23AM -0400, Brian Foster wrote: >

Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend().

On Mon, Aug 24, 2020 at 04:04:17PM +0100, Christoph Hellwig wrote: > On Mon, Aug 24, 2020 at 10:28:23AM -0400, Brian Foster wrote: > > Do I understand the current code (__bio_try_merge_page() -> > > page_is_mergeable()) correctly in that we're checking for physical p

Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend().

On Sat, Aug 22, 2020 at 02:13:12PM +0100, Christoph Hellwig wrote: > On Sat, Aug 22, 2020 at 07:53:58AM +1000, Dave Chinner wrote: > > but iomap only allows BIO_MAX_PAGES when creating the bio. And: > > > > #define BIO_MAX_PAGES 256 > > > > So even on a 64k page machine, we should not be

Re: [PATCH] xfs: fix use-after-free on CIL context on shutdown

rd > throttle size threshold. > > Fixes: 0e7ab7efe7745 ("xfs: Throttle commits on delayed background CIL push") > Reported-by: Yu Kuai > Signed-off-by: Dave Chinner > --- Looks reasonable: Reviewed-by: Brian Foster > fs/xfs/xfs_log_cil.c | 10 +- > fs/xf

Re: [PATCH 09/12] iomap: lift the xfs writeback code to iomap

On Wed, Oct 16, 2019 at 09:48:36AM +0200, Christoph Hellwig wrote: > On Wed, Oct 16, 2019 at 09:07:21AM +1100, Dave Chinner wrote: ... > > > +/* > > > + * Submit the bio for an ioend. We are passed an ioend with a bio > > > attached to > > > + * it, and we submit that bio. The ioend may be used

Re: [PATCH 10/11] xfs: use the iomap writeback code

y: Darrick J. Wong > --- Reviewed-by: Brian Foster > fs/xfs/xfs_aops.c | 667 ++--- > fs/xfs/xfs_aops.h | 17 -- > fs/xfs/xfs_super.c | 11 +- > fs/xfs/xfs_trace.h | 39 --- > 4 files changed, 78 insertions(+), 656 deletions(-) > &g

Re: [PATCH 01/11] iomap: add tracing for the readpage / readpages

On Sun, Oct 06, 2019 at 05:45:58PM +0200, Christoph Hellwig wrote: > Lift the xfs code for tracing address space operations to the iomap > layer. > > Signed-off-by: Christoph Hellwig > --- For the v7 version: Reviewed-by: Brian Foster > fs/iomap/Makefile | 16

Re: [PATCH 10/11] xfs: use the iomap write page code

On Tue, Oct 01, 2019 at 09:11:51AM +0200, Christoph Hellwig wrote: > Use the new iomap writeback code that was copied from XFS to perform > writeback. > > Signed-off-by: Christoph Hellwig > [darrick: reduce this patch only to convert the xfs writeback code] > Signed-off-by: Darrick J. Wong >

Re: [PATCH 06/11] xfs: remove the readpage / readpages tracing code

On Tue, Oct 01, 2019 at 09:11:47AM +0200, Christoph Hellwig wrote: > The actual iomap implementations now have equivalent trace points. > > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Brian Foster > fs/xfs/xfs_aops.c | 2 -- > fs/xfs/xfs_trace.h | 26 -

Re: [PATCH 01/11] iomap: add tracing for the readpage / readpages

On Tue, Oct 01, 2019 at 09:11:42AM +0200, Christoph Hellwig wrote: > Lift the xfs code for tracing address space operations to the iomap > layer. > > Signed-off-by: Christoph Hellwig > --- > fs/iomap/buffered-io.c | 7 +++ > include/trace/events/iomap.h | 27

Re: [PATCH] xfs: avoid unused to_mp() function warning

to_mp() might be removed safely to get rid of warning message. > > Signed-off-by: Austin Kim > --- Reviewed-by: Brian Foster > fs/xfs/xfs_sysfs.c | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c > index ddd

Re: [PATCH] xfs: libxfs: move xfs_perag_put late

On Mon, Nov 26, 2018 at 06:36:19PM +0800, PanBian wrote: > On Mon, Nov 26, 2018 at 10:31:39AM +0100, Carlos Maiolino wrote: > > On Sat, Nov 24, 2018 at 05:44:20PM +0800, Pan Bian wrote: > > > The function xfs_alloc_get_freelist calls xfs_perag_put to drop the > > > reference. In this case, pag may

Re: [PATCH] xfs: libxfs: move xfs_perag_put late

On Mon, Nov 26, 2018 at 06:36:19PM +0800, PanBian wrote: > On Mon, Nov 26, 2018 at 10:31:39AM +0100, Carlos Maiolino wrote: > > On Sat, Nov 24, 2018 at 05:44:20PM +0800, Pan Bian wrote: > > > The function xfs_alloc_get_freelist calls xfs_perag_put to drop the > > > reference. In this case, pag may

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 08:26:44AM -0700, Darrick J. Wong wrote: > On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > >

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 08:26:44AM -0700, Darrick J. Wong wrote: > On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > >

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > > Hi, > > > > > > Recent commit 82ff27bc52a88cb5cc400

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > > Hi, > > > > > > Recent commit 82ff27bc52a88cb5cc400

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > Hi, > > Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic > dfops buffer relogging") removed the assignment of variable error: > > - error = xfs_defer_bjoin(tp->t_dfops, bp); > if (error) { >

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > Hi, > > Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic > dfops buffer relogging") removed the assignment of variable error: > > - error = xfs_defer_bjoin(tp->t_dfops, bp); > if (error) { >

Re: INFO: task hung in xlog_grant_head_check

On Mon, May 21, 2018 at 10:55:02AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:203ec2fed17a Merge tag 'armsoc-fixes' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11c1ad7780 >

Re: INFO: task hung in xlog_grant_head_check

On Mon, May 21, 2018 at 10:55:02AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:203ec2fed17a Merge tag 'armsoc-fixes' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11c1ad7780 >

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

unless > Ultimately causing a xfs_buffer with ->b_lru_ref == 0, to take another > trip around LRU, while isolating buffers with non-zero b_lru_ref. > > Signed-off-by: Vratislav Bendel <vben...@redhat.com> > CC: Brian Foster <bfo

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

unless > Ultimately causing a xfs_buffer with ->b_lru_ref == 0, to take another > trip around LRU, while isolating buffers with non-zero b_lru_ref. > > Signed-off-by: Vratislav Bendel > CC: Brian Foster > --- It might be worth pointing o

Re: [PATCH] xfs: destroy mutex pag_ici_reclaim_lock before free xfs_perag_t structure

e > perag. > > Signed-off-by: Xiongwei Song <sxwj...@me.com> > --- Only relevant with mutex debugging enabled I suppose, but seems appropriate: Reviewed-by: Brian Foster <bfos...@redhat.com> > fs/xfs/xfs_mount.c | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [PATCH] xfs: destroy mutex pag_ici_reclaim_lock before free xfs_perag_t structure

e > perag. > > Signed-off-by: Xiongwei Song > --- Only relevant with mutex debugging enabled I suppose, but seems appropriate: Reviewed-by: Brian Foster > fs/xfs/xfs_mount.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs

Re: [PATCH v2] xfs: scrub: avoid uninitialized return code

produce a > buffer pointer. > > Fixes: 7c4a07a424c1 ("xfs: scrub directory/attribute btrees") > Reported-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Darrick J. Wong <darrick.w...@oracle.com> > --- Reviewed-by: Brian Foster <bfos...@redhat.com&g

Re: [PATCH v2] xfs: scrub: avoid uninitialized return code

gt; > Fixes: 7c4a07a424c1 ("xfs: scrub directory/attribute btrees") > Reported-by: Arnd Bergmann > Signed-off-by: Darrick J. Wong > --- Reviewed-by: Brian Foster > fs/xfs/scrub/dabtree.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [PATCH 2/2] xfs: fix unused variable warnings

xtent") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- Thanks for sending this: Reviewed-by: Brian Foster <bfos...@redhat.com> > fs/xfs/libxfs/xfs_bmap.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_bm

Re: [PATCH 2/2] xfs: fix unused variable warnings

xtent") > Signed-off-by: Arnd Bergmann > --- Thanks for sending this: Reviewed-by: Brian Foster > fs/xfs/libxfs/xfs_bmap.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c > index f45f05c45e

Re: [PATCH 1/2] xfs: scrub: avoid uninitialized return code

On Thu, Nov 02, 2017 at 12:11:12PM +0100, Arnd Bergmann wrote: > The newly added xfs_scrub_da_btree_block() function has one code path > that returns the 'error' variable without initializing it first, as > shown by this compiler warning: > > fs/xfs/scrub/dabtree.c: In function

Re: [PATCH 1/2] xfs: scrub: avoid uninitialized return code

On Thu, Nov 02, 2017 at 12:11:12PM +0100, Arnd Bergmann wrote: > The newly added xfs_scrub_da_btree_block() function has one code path > that returns the 'error' variable without initializing it first, as > shown by this compiler warning: > > fs/xfs/scrub/dabtree.c: In function

Re: [PATCH v3 12/13] dax: handle truncate of dma-busy pages

On Fri, Oct 20, 2017 at 10:27:22AM -0700, Dan Williams wrote: > On Fri, Oct 20, 2017 at 9:32 AM, Christoph Hellwig wrote: > > On Fri, Oct 20, 2017 at 08:42:00AM -0700, Dan Williams wrote: > >> I agree, but it needs quite a bit more thought and restructuring of > >> the truncate path.

Re: [PATCH v3 12/13] dax: handle truncate of dma-busy pages

On Fri, Oct 20, 2017 at 10:27:22AM -0700, Dan Williams wrote: > On Fri, Oct 20, 2017 at 9:32 AM, Christoph Hellwig wrote: > > On Fri, Oct 20, 2017 at 08:42:00AM -0700, Dan Williams wrote: > >> I agree, but it needs quite a bit more thought and restructuring of > >> the truncate path. I also

Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT

On Sat, Oct 14, 2017 at 09:08:25AM +1100, Dave Chinner wrote: > On Fri, Oct 13, 2017 at 02:05:40PM +0200, Arnd Bergmann wrote: > > The last cleanup introduced two harmless warnings: > > > > fs/xfs/xfs_fsmap.c:480:1: warning: '__xfs_getfsmap_rtdev' defined but not > > used > >

Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT

On Sat, Oct 14, 2017 at 09:08:25AM +1100, Dave Chinner wrote: > On Fri, Oct 13, 2017 at 02:05:40PM +0200, Arnd Bergmann wrote: > > The last cleanup introduced two harmless warnings: > > > > fs/xfs/xfs_fsmap.c:480:1: warning: '__xfs_getfsmap_rtdev' defined but not > > used > >

Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT

ed but not used > > This moves those two functions as well. > > Fixes: bb9c2e543325 ("xfs: move more RT specific code under CONFIG_XFS_RT") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- I don't reproduce the warning, but the patch looks fine: Reviewed

Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT

ed but not used > > This moves those two functions as well. > > Fixes: bb9c2e543325 ("xfs: move more RT specific code under CONFIG_XFS_RT") > Signed-off-by: Arnd Bergmann > --- I don't reproduce the warning, but the patch looks fine: Reviewed-by

Re: [PATCH] xfs: Fix bool initialization/comparison

On Sat, Oct 07, 2017 at 04:02:21PM +0200, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer <tho...@m3y3r.de> > --- Reviewed-by: Brian Foster <bfos...@redhat.com> > > diff

Re: [PATCH] xfs: Fix bool initialization/comparison

On Sat, Oct 07, 2017 at 04:02:21PM +0200, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer > --- Reviewed-by: Brian Foster > > diff -u -p a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/

Re: [PATCH] xfs: remove redundant re-initialization of total_nr_pages

p clang build warning: > > Value stored to 'total_nr_pages' during its initialization is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- Reviewed-by: Brian Foster <bfos...@redhat.com> > fs/xfs/xfs_buf.c | 2 -- > 1 file changed, 2 de

Re: [PATCH] xfs: remove redundant re-initialization of total_nr_pages

t; > Value stored to 'total_nr_pages' during its initialization is never read > > Signed-off-by: Colin Ian King > --- Reviewed-by: Brian Foster > fs/xfs/xfs_buf.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index da14658da310.

Re: linux-next: build warning after merge of the xfs tree

On Thu, Aug 31, 2017 at 07:57:52AM -0700, Darrick J. Wong wrote: > On Thu, Aug 31, 2017 at 06:30:41AM -0400, Brian Foster wrote: > > On Thu, Aug 31, 2017 at 10:07:03AM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the xfs tre

Re: linux-next: build warning after merge of the xfs tree

On Thu, Aug 31, 2017 at 07:57:52AM -0700, Darrick J. Wong wrote: > On Thu, Aug 31, 2017 at 06:30:41AM -0400, Brian Foster wrote: > > On Thu, Aug 31, 2017 at 10:07:03AM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the xfs tre

Re: linux-next: build warning after merge of the xfs tree

On Thu, Aug 31, 2017 at 10:07:03AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the xfs tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > fs/xfs/xfs_buf_item.c: In function 'xfs_buf_item_unlock': > fs/xfs/xfs_buf_item.c:573:9: warning: unused

Re: linux-next: build warning after merge of the xfs tree

On Thu, Aug 31, 2017 at 10:07:03AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the xfs tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > fs/xfs/xfs_buf_item.c: In function 'xfs_buf_item_unlock': > fs/xfs/xfs_buf_item.c:573:9: warning: unused

Re: [PATCH] xfs: fix semicolon.cocci warnings

ge details on log reservation > overrun") > CC: Brian Foster <bfos...@redhat.com> > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > --- Reviewed-by: Brian Foster <bfos...@redhat.com> > > xfs_log.c |2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] xfs: fix semicolon.cocci warnings

ge details on log reservation > overrun") > CC: Brian Foster > Signed-off-by: Fengguang Wu > --- Reviewed-by: Brian Foster > > xfs_log.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -2089

Re: [xfs] 63db7c815b: XFS: Assertion failed: spin_is_locked(>b_lock), file: fs/xfs/xfs_buf.c, line: 120

ter > > commit 63db7c815bc0997c29e484d2409684fdd9fcd93b > Author: Brian Foster <bfos...@redhat.com> > AuthorDate: Wed May 31 08:22:52 2017 -0700 > Commit: Darrick J. Wong <darrick.w...@oracle.com> > CommitDate: Wed May 31 08:22:52 2017 -0700 > > xfs: use ->b_state to fix buffer I

Re: [xfs] 63db7c815b: XFS: Assertion failed: spin_is_locked(>b_lock), file: fs/xfs/xfs_buf.c, line: 120

ter > > commit 63db7c815bc0997c29e484d2409684fdd9fcd93b > Author: Brian Foster > AuthorDate: Wed May 31 08:22:52 2017 -0700 > Commit: Darrick J. Wong > CommitDate: Wed May 31 08:22:52 2017 -0700 > > xfs: use ->b_state to fix buffer I/O accounting release race > > We've had u

Re: [PATCH 02/23] xfs: use uuid_be to implement the uuid_t type

On Thu, May 18, 2017 at 08:26:44AM +0200, Christoph Hellwig wrote: > Use the generic Linux definition to implement our UUID type, this will > allow using more generic infrastructure in the future. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- Reviewed-b

Re: [PATCH 02/23] xfs: use uuid_be to implement the uuid_t type

On Thu, May 18, 2017 at 08:26:44AM +0200, Christoph Hellwig wrote: > Use the generic Linux definition to implement our UUID type, this will > allow using more generic infrastructure in the future. > > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Brian Foster > fs/x

Re: [PATCH 14/23] xfs: use the common helper uuid_is_null()

sed in > userspace by libuuid and xfsprogs. > > Signed-off-by: Amir Goldstein <amir7...@gmail.com> > [hch: remove now unused uuid.[ch]] > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- Reviewed-by: Brian Foster <bfos...@redhat.

Re: [PATCH 12/23] xfs: remove uuid_getnodeuniq and xfs_uu_t

On Thu, May 18, 2017 at 08:26:54AM +0200, Christoph Hellwig wrote: > Directly use the v1 intepretation of uuid_t instead. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- Reviewed-by: Brian Foster <bfos...@redhat.com> > fs/xfs/uuid.c | 25 ---

Re: [PATCH 14/23] xfs: use the common helper uuid_is_null()

y libuuid and xfsprogs. > > Signed-off-by: Amir Goldstein > [hch: remove now unused uuid.[ch]] > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Brian Foster > fs/xfs/Makefile | 3 +-- > fs/xfs/uuid.c| 32 >

Re: [PATCH 12/23] xfs: remove uuid_getnodeuniq and xfs_uu_t

On Thu, May 18, 2017 at 08:26:54AM +0200, Christoph Hellwig wrote: > Directly use the v1 intepretation of uuid_t instead. > > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Brian Foster > fs/xfs/uuid.c | 25 - > fs/xfs/uuid.h

Re: [PATCH 01/23] xfs: use uuid_copy() helper to abstract uuid_t

On Thu, May 18, 2017 at 08:26:43AM +0200, Christoph Hellwig wrote: > From: Amir Goldstein <amir7...@gmail.com> > > uuid_t definition is about to change. > > Signed-off-by: Amir Goldstein <amir7...@gmail.com> > Signed-off-by: Christoph Hellwig <h...@lst.de> &g

Re: [PATCH 01/23] xfs: use uuid_copy() helper to abstract uuid_t

On Thu, May 18, 2017 at 08:26:43AM +0200, Christoph Hellwig wrote: > From: Amir Goldstein > > uuid_t definition is about to change. > > Signed-off-by: Amir Goldstein > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Brian Foster > fs/xfs/xfs_inode_item.c | 8 ++

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

On Wed, Mar 29, 2017 at 01:18:34PM +0200, Michal Hocko wrote: > On Wed 29-03-17 13:14:42, Ilya Dryomov wrote: > > On Wed, Mar 29, 2017 at 1:05 PM, Brian Foster <bfos...@redhat.com> wrote: > > > On Wed, Mar 29, 2017 at 12:41:26PM +0200, Michal Hocko wrote: > > >>

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

On Wed, Mar 29, 2017 at 01:18:34PM +0200, Michal Hocko wrote: > On Wed 29-03-17 13:14:42, Ilya Dryomov wrote: > > On Wed, Mar 29, 2017 at 1:05 PM, Brian Foster wrote: > > > On Wed, Mar 29, 2017 at 12:41:26PM +0200, Michal Hocko wrote: > > >> [CC xfs guys] > >

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

On Wed, Mar 29, 2017 at 12:41:26PM +0200, Michal Hocko wrote: > [CC xfs guys] > > On Wed 29-03-17 11:21:44, Ilya Dryomov wrote: > [...] > > This is a set of stack traces from http://tracker.ceph.com/issues/19309 > > (linked in the changelog): > > > > Workqueue: ceph-msgr con_work [libceph] > >

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

On Wed, Mar 29, 2017 at 12:41:26PM +0200, Michal Hocko wrote: > [CC xfs guys] > > On Wed 29-03-17 11:21:44, Ilya Dryomov wrote: > [...] > > This is a set of stack traces from http://tracker.ceph.com/issues/19309 > > (linked in the changelog): > > > > Workqueue: ceph-msgr con_work [libceph] > >

Re: [PATCH v2] xfs: Honor FALLOC_FL_KEEP_SIZE when punching ends of files

On Sun, Mar 19, 2017 at 09:54:51PM -0700, Calvin Owens wrote: > When punching past EOF on XFS, fallocate(mode=PUNCH_HOLE|KEEP_SIZE) will > round the file size up to the nearest multiple of PAGE_SIZE: > > calvinow@vm-disks/generic-xfs-1 ~$ dd if=/dev/urandom of=test bs=2048 > count=1 >

Re: [PATCH v2] xfs: Honor FALLOC_FL_KEEP_SIZE when punching ends of files

On Sun, Mar 19, 2017 at 09:54:51PM -0700, Calvin Owens wrote: > When punching past EOF on XFS, fallocate(mode=PUNCH_HOLE|KEEP_SIZE) will > round the file size up to the nearest multiple of PAGE_SIZE: > > calvinow@vm-disks/generic-xfs-1 ~$ dd if=/dev/urandom of=test bs=2048 > count=1 >

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

On Fri, Mar 10, 2017 at 08:19:58PM +0900, Tetsuo Handa wrote: > Andrew Morton wrote: > > On Thu, 9 Mar 2017 19:46:14 +0900 Tetsuo Handa > > wrote: > > > Tetsuo Handa wrote: > > > > This patch adds a watchdog which periodically reports number of memory > > > >

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

On Fri, Mar 10, 2017 at 08:19:58PM +0900, Tetsuo Handa wrote: > Andrew Morton wrote: > > On Thu, 9 Mar 2017 19:46:14 +0900 Tetsuo Handa > > wrote: > > > Tetsuo Handa wrote: > > > > This patch adds a watchdog which periodically reports number of memory > > > > allocating tasks, dying tasks and

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

On Thu, Mar 09, 2017 at 07:43:12AM -0500, Jeff Layton wrote: > On Thu, 2017-03-09 at 12:02 +0100, Jan Kara wrote: > > On Thu 09-03-17 05:47:51, Jeff Layton wrote: > > > On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > > > > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > > > > On Tue, Mar 07,

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

On Thu, Mar 09, 2017 at 07:43:12AM -0500, Jeff Layton wrote: > On Thu, 2017-03-09 at 12:02 +0100, Jan Kara wrote: > > On Thu 09-03-17 05:47:51, Jeff Layton wrote: > > > On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > > > > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > > > > On Tue, Mar 07,

Re: 4.11.0-rc1 boot resulted in WARNING: CPU: 14 PID: 1722 at fs/sysfs/dir.c:31 .sysfs_warn_dup+0x78/0xb0

cc linux-block On Thu, Mar 09, 2017 at 04:20:06PM +0530, Abdul Haleem wrote: > On Wed, 2017-03-08 at 08:17 -0500, Brian Foster wrote: > > On Tue, Mar 07, 2017 at 10:01:04PM +0530, Abdul Haleem wrote: > > > > > > Hi, > > > > > > Today's mainline (4.

Re: 4.11.0-rc1 boot resulted in WARNING: CPU: 14 PID: 1722 at fs/sysfs/dir.c:31 .sysfs_warn_dup+0x78/0xb0

cc linux-block On Thu, Mar 09, 2017 at 04:20:06PM +0530, Abdul Haleem wrote: > On Wed, 2017-03-08 at 08:17 -0500, Brian Foster wrote: > > On Tue, Mar 07, 2017 at 10:01:04PM +0530, Abdul Haleem wrote: > > > > > > Hi, > > > > > > Today's mainline (4.

Re: 4.11.0-rc1 boot resulted in WARNING: CPU: 14 PID: 1722 at fs/sysfs/dir.c:31 .sysfs_warn_dup+0x78/0xb0

On Tue, Mar 07, 2017 at 10:01:04PM +0530, Abdul Haleem wrote: > > Hi, > > Today's mainline (4.11.0-rc1) booted with warnings on Power7 LPAR. > > Issue is not reproducible all the time. > > traces: > > Found device VDASD 5. > Mounting /home... > Reached target Swap. > Found device

Re: 4.11.0-rc1 boot resulted in WARNING: CPU: 14 PID: 1722 at fs/sysfs/dir.c:31 .sysfs_warn_dup+0x78/0xb0

On Tue, Mar 07, 2017 at 10:01:04PM +0530, Abdul Haleem wrote: > > Hi, > > Today's mainline (4.11.0-rc1) booted with warnings on Power7 LPAR. > > Issue is not reproducible all the time. > > traces: > > Found device VDASD 5. > Mounting /home... > Reached target Swap. > Found device

Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail

orted-by: Xiong Zhou <xz...@redhat.com> > Analyzed-by: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> > Signed-off-by: Michal Hocko <mho...@suse.com> > --- Reviewed-by: Brian Foster <bfos...@redhat.com> > fs/xfs/kmem.c | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail

+0xa7/0x5e0 > SyS_ioctl+0x79/0x90 > do_syscall_64+0x67/0x180 > entry_SYSCALL64_slow_path+0x25/0x25 > > fsstress keeps looping inside kmem_zalloc_greedy without any way out > because vmalloc keeps failing due to fatal_signal_pending. > > Reported-by: Xiong Zhou >

Re: [PATCH 2/2] xfs: back off from kmem_zalloc_greedy if the task is killed

possible. The current implementation of > vmalloc will fail anyway. > > Suggested-by: Brian Foster <bfos...@redhat.com> > Signed-off-by: Michal Hocko <mho...@suse.com> > --- Reviewed-by: Brian Foster <bfos...@redhat.com> > fs/xfs/kmem.c | 2 +- > 1 file cha

Re: [PATCH 2/2] xfs: back off from kmem_zalloc_greedy if the task is killed

implementation of > vmalloc will fail anyway. > > Suggested-by: Brian Foster > Signed-off-by: Michal Hocko > --- Reviewed-by: Brian Foster > fs/xfs/kmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c > index

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

On Thu, Mar 02, 2017 at 04:14:11PM +0100, Michal Hocko wrote: > On Thu 02-03-17 09:51:31, Brian Foster wrote: > > On Thu, Mar 02, 2017 at 03:34:41PM +0100, Michal Hocko wrote: > > > On Thu 02-03-17 09:23:15, Brian Foster wrote: > > > > On Thu, Mar 02, 2017 at 02:50:

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

On Thu, Mar 02, 2017 at 04:14:11PM +0100, Michal Hocko wrote: > On Thu 02-03-17 09:51:31, Brian Foster wrote: > > On Thu, Mar 02, 2017 at 03:34:41PM +0100, Michal Hocko wrote: > > > On Thu 02-03-17 09:23:15, Brian Foster wrote: > > > > On Thu, Mar 02, 2017 at 02:50:

  1   2   3   >