Re: [PATCH v4] Add power/gpu_frequency tracepoint.

2020-12-02 Thread Brian Starkey
Hi Peiyong, On Mon, Nov 30, 2020 at 02:33:59PM -0800, Peiyong Lin wrote: > On Tue, Nov 17, 2020 at 1:31 PM Peiyong Lin wrote: > > > > On Thu, Oct 22, 2020 at 10:34 AM Peiyong Lin wrote: > > > > > > Historically there is no common trace event for GPU frequency, in > > > downstream Android each di

Re: [PATCH v2] drm/fourcc: Add AXBXGXRX106106106106 format

2020-10-09 Thread Brian Starkey
formatting of the table as a whole. If Joe feels strongly about having it split, I don't think that should hurt grep-ability much for the common cases (grep for format name, or grep for format parameters). So either way you can add: Reviewed-by: Brian Starkey Thanks! -Brian >

Re: [PATCH v3 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

2020-10-08 Thread Brian Starkey
+/1399519 > - Visibly improves performance over the system heap > * AOSP Codec2 (possibly, needs more review): > - > https://android-review.googlesource.com/c/platform/frameworks/av/+/1360640/17/media/codec2/vndk/C2DmaBufAllocator.cpp#325 > > Cc: Sumit Semwal > Cc: Liam Mark >

Re: [PATCH v3 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-10-08 Thread Brian Starkey
Hi John, On Sat, Oct 03, 2020 at 04:02:50AM +, John Stultz wrote: > Hey All, ... > > I did add to this series a reworked version of my uncached > system heap implementation I was submitting a few weeks back. > Since it duplicated a lot of the now reworked system heap code, > I realized it w

Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-19 Thread Brian Starkey
Hi KyongHo, On Wed, Aug 19, 2020 at 12:46:26PM +0900, Cho KyongHo wrote: > I have seriously considered CPA in our product but we developed our own > because of the pool in CPA. Oh good, I'm glad you considered it :-) > The high-order pages are required by some specific users like Netflix > app.

Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-18 Thread Brian Starkey
Hi, On Tue, Aug 18, 2020 at 05:04:12PM +0900, Hyesoo Yu wrote: > These patch series to introduce a new dma heap, chunk heap. > That heap is needed for special HW that requires bulk allocation of > fixed high order pages. For example, 64MB dma-buf pages are made up > to fixed order-4 pages * 1024.

Re: [RFC][PATCH] dma-heap: Add proper kref handling on dma-buf heaps

2020-08-13 Thread Brian Starkey
ew F. Davis > Cc: Benjamin Gaignard > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: linux-me...@vger.kernel.org > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: John Stultz > --- > drivers/dma-buf/dma-heap.c | 31 +++ &

Re: [PATCH 1/2] drm: drm_fourcc: add NV20 YUV format

2020-06-08 Thread Brian Starkey
, .hsub = 2, > + .vsub = 1, .is_yuv = true }, That looks how I would expect, so: Reviewed-by: Brian Starkey Cheers, -Brian > { .format = DRM_FORMAT_Q410,.depth = 0, > .num_planes = 3, .char_per_block = { 2, 2, 2 }, >

Re: [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA regions tagged with "linux,cma-heap"

2020-05-15 Thread Brian Starkey
On Thu, May 14, 2020 at 09:52:35AM -0500, Rob Herring wrote: > On Wed, May 13, 2020 at 5:44 AM Brian Starkey wrote: > > > > Hi Rob, > > > > On Tue, May 12, 2020 at 11:37:14AM -0500, Rob Herring wrote: > > > On Mon, May 04, 2020 at 10:06:28AM +0100, Brian S

Re: [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA regions tagged with "linux,cma-heap"

2020-05-13 Thread Brian Starkey
Hi Rob, On Tue, May 12, 2020 at 11:37:14AM -0500, Rob Herring wrote: > On Mon, May 04, 2020 at 10:06:28AM +0100, Brian Starkey wrote: > > On Fri, May 01, 2020 at 12:01:40PM -0700, John Stultz wrote: > > > On Fri, May 1, 2020 at 4:08 AM Robin Murphy wrote: > > > >

Re: [PATCH] kselftests: dmabuf-heaps: Fix confused return value on expected error testing

2020-05-13 Thread Brian Starkey
Khan > Cc: Sumit Semwal > Cc: Benjamin Gaignard > Cc: Brian Starkey > Cc: Laura Abbott > Cc: "Andrew F. Davis" > Cc: linux-kselft...@vger.kernel.org > Signed-off-by: John Stultz > --- > tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 1 + > 1 fi

Re: [PATCH] dma-buf: heaps: Remove Unneeded variable "ret" in dma_heap_dma_buf_begin_cpu_access()

2020-05-06 Thread Brian Starkey
Hi Jason, On Wed, May 06, 2020 at 02:18:51PM +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/dma-buf/heaps/heap-helpers.c:203:5-8: Unneeded variable: "ret". > Return "0" on line 216 > > Signed-off-by: Jason Yan LGTM. Revie

Re: [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA regions tagged with "linux,cma-heap"

2020-05-04 Thread Brian Starkey
On Fri, May 01, 2020 at 12:01:40PM -0700, John Stultz wrote: > On Fri, May 1, 2020 at 4:08 AM Robin Murphy wrote: > > > > On 2020-05-01 11:21 am, Brian Starkey wrote: > > > Hi John, > > > > > > On Fri, May 01, 2020 at 07:39:48AM +, John Stultz wro

Re: [RFC][PATCH 1/4] devicetree: bindings: Add linux,cma-heap tag for reserved memory

2020-05-04 Thread Brian Starkey
On Fri, May 01, 2020 at 11:40:16AM -0700, John Stultz wrote: > On Fri, May 1, 2020 at 3:42 AM Brian Starkey wrote: > > > > Hi, > > > > On Fri, May 01, 2020 at 07:39:46AM +, John Stultz wrote: > > > This patch adds a linux,cma-heap property for CMA reserved

Re: [RFC][PATCH 2/4] mm: cma: Add dma_heap flag to cma structure

2020-05-01 Thread Brian Starkey
tch. > > Cc: Rob Herring > Cc: Sumit Semwal > Cc: "Andrew F. Davis" > Cc: Benjamin Gaignard > Cc: Liam Mark > Cc: Pratik Patel > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Chenbo Feng > Cc: Alistair Strachan > Cc: Sandeep Patil > Cc: Hrid

Re: [RFC][PATCH 1/4] devicetree: bindings: Add linux,cma-heap tag for reserved memory

2020-05-01 Thread Brian Starkey
Cc: "Andrew F. Davis" > Cc: Benjamin Gaignard > Cc: Liam Mark > Cc: Pratik Patel > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Chenbo Feng > Cc: Alistair Strachan > Cc: Sandeep Patil > Cc: Hridya Valsaraju > Cc: Christoph Hellwig > Cc: Marek Sz

Re: [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA regions tagged with "linux,cma-heap"

2020-05-01 Thread Brian Starkey
umit Semwal > Cc: "Andrew F. Davis" > Cc: Benjamin Gaignard > Cc: Liam Mark > Cc: Pratik Patel > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Chenbo Feng > Cc: Alistair Strachan > Cc: Sandeep Patil > Cc: Hridya Valsaraju > Cc: Christoph Hellwig

Re: [PATCH v12 1/5] dma-buf: Add dma-buf heaps framework

2019-10-18 Thread Brian Starkey
cca Schultz Zavin, Colin Cross, Benjamin Gaignard, > Laura Abbott, and many other contributors! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Pratik Patel > Cc: Brian Starkey > Cc: Vincent Donnefort > Cc: Sudipto Paul &g

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-16 Thread Brian Starkey
Hi, On Wed, Oct 16, 2019 at 03:51:39PM +, Mihail Atanassov wrote: > Hi James, > > On Wednesday, 9 October 2019 06:54:15 BST james qian wang (Arm Technology > China) wrote: > > On Fri, Oct 04, 2019 at 02:34:42PM +, Mihail Atanassov wrote: > > > To support transmitters other than the tda99

Re: [RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION)

2019-10-14 Thread Brian Starkey
Hi Andrew, On Wed, Oct 09, 2019 at 02:27:15PM -0400, Andrew F. Davis wrote: > The CMA driver that registers these nodes will have to be expanded to > export them using this framework as needed. We do something similar to > export SRAM nodes: > > https://lkml.org/lkml/2019/3/21/575 > > Unlike the

Re: [PATCH v3 3/5] memremap: Add support for read-only memory mappings

2019-10-04 Thread Brian Starkey
Hi, On Thu, Oct 03, 2019 at 01:05:53PM -0700, Evan Green wrote: > On Thu, Oct 3, 2019 at 11:56 AM Stephen Boyd wrote: > > > > Quoting Evan Green (2019-09-18 12:37:34) > > > On Tue, Sep 10, 2019 at 9:09 AM Stephen Boyd wrote: > > > > > > > > @@ -53,6 +60,9 @@ static void *try_ram_remap(resource_s

Re: [PATCH v9 0/5] DMA-BUF Heaps (destaging ION)

2019-10-03 Thread Brian Starkey
been deprecated in the common/andoid-* > kernels, so this should be ok. > > I've also removed the stats accounting, since any such accounting > should be implemented by dma-buf core or the heaps themselves. > > New in v9: > * Removing needless check in cma heap (noted

Re: [PATCH] drm/komeda: Adds output-color format/depth support

2019-09-25 Thread Brian Starkey
Hi James, On Tue, Sep 24, 2019 at 02:13:27AM +, james qian wang (Arm Technology China) wrote: > > Hi Brian: > > Since one monitor can support mutiple color-formats, this DT property > supply a way for user to select a specific one from this supported > color-formats. Modifying DT is a _rea

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-08-05 Thread Brian Starkey
Hi Lowry, Based on Daniel's input, this patch looks fine: Reviewed-by: Brian Starkey I think there's some opportunity for improvement around prepare_signaling/complete_signaling, but that can be treated as separate from fixing this bug. Thanks, -Brian On Wed, Jul 31, 2019 at 11:04:

Re: drm/komeda: Add support for generation of CRC data per frame.

2019-08-02 Thread Brian Starkey
Hi Liviu, On Thu, Aug 01, 2019 at 11:42:31AM +0100, Liviu Dudau wrote: > Komeda has support to generate per-frame CRC values in the DOU > backend subsystem. Implement necessary hooks to expose the CRC > "control" and "data" file over debugfs and program the DOUx_BS > accordingly. > > This patch m

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-07-31 Thread Brian Starkey
Hi Lowry, Thanks for this cleanup. On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China) wrote: > During it signals the completion of a writeback job, after releasing > the out_fence, we'd clear the pointer. > > Check if fence left over in drm_writeback_cleanup_job(), release

Re: [PATCH] drm/fourcc: Add Arm 16x16 block modifier

2019-06-24 Thread Brian Starkey
Hi Daniel, On Fri, Jun 21, 2019 at 05:27:00PM +0200, Daniel Vetter wrote: > On Fri, Jun 21, 2019 at 12:21 PM Raymond Smith wrote: > > > > Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to > > denote the 16x16 block u-interleaved format used in Arm Utgard and > > Midgard GPUs. > > >

Re: [PATCH v5 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-06-07 Thread Brian Starkey
implementation, so > thanks to its original authors and maintainters: > Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Pratik Patel > Cc: Brian Starkey > Cc: Vince

Re: [PATCH v5 1/5] dma-buf: Add dma-buf heaps framework

2019-06-07 Thread Brian Starkey
f the Android ION implementation, > and a big thanks is due to its authors/maintainers over time > for their effort: > Rebecca Schultz Zavin, Colin Cross, Benjamin Gaignard, > Laura Abbott, and many other contributors! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: S

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-19 Thread Brian Starkey
Hi John, On Tue, Mar 05, 2019 at 12:54:29PM -0800, John Stultz wrote: > From: "Andrew F. Davis" [snip] > + > +#define NUM_HEAP_MINORS 128 > +static DEFINE_IDR(dma_heap_idr); > +static DEFINE_MUTEX(minor_lock); /* Protect idr accesses */ I saw that Matthew Wilcox is trying to nuke idr: https://

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-18 Thread Brian Starkey
On Fri, Feb 15, 2019 at 11:01:59AM -0800, John Stultz wrote: > On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: > > > > Hi John, > > > > On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > > > > > [snip] > > > > > Some t

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-15 Thread Brian Starkey
Hi John, On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > [snip] > Some thoughts, as this ABI break has the potential to be pretty painful. > > 1) Unfortunately, this ABI is exposed *through* libion via > ion_alloc/ion_alloc_fd out to gralloc implementations. Which means it > will

Re: [PATCH 2/4] staging: android: ion: Restrict cache maintenance to dma mapped memory

2019-01-30 Thread Brian Starkey
s above make ION align > > more with the way the DMA APIs are used. Basically when the buffer is not > > dma-mapped the CPU doesn't need to do any CMOs to access the buffer (and > > ION ensures not CMOs are applied) but if the CPU does want to access the > > buff

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-24 Thread Brian Starkey
On Thu, Jan 24, 2019 at 10:12:10AM -0600, Andrew F. Davis wrote: > On 1/24/19 9:24 AM, Brian Starkey wrote: [snip] > > > > What do you think about renaming ion_allocation_data.unused to heap_id > > and adding a flag instead? It's adding cruft to a staging API, b

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-24 Thread Brian Starkey
On Thu, Jan 24, 2019 at 10:04:46AM -0600, Andrew F. Davis wrote: > On 1/23/19 11:11 AM, Brian Starkey wrote: [snip] > > I'm very new to all this, so any pointers to history in this area are > appreciated. > [snip] > > > In case you didn't come across it

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-24 Thread Brian Starkey
Hi Andrew, On Wed, Jan 23, 2019 at 01:28:35PM -0600, Andrew F. Davis wrote: > Previously the heap to allocate from was selected by a mask of allowed > heap types. This may have been done as a primitive form of constraint > solving, the first heap type that matched any set bit of the heap mask > wa

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-23 Thread Brian Starkey
since he has been one of the > > core guys who shaped up dma-buf as it is today. > > > > On Tue, 22 Jan 2019 at 02:51, Andrew F. Davis wrote: > >> > >> On 1/21/19 5:22 AM, Brian Starkey wrote: > > [snip] > > >>> > >>> A

Re: [PATCH 4/4] staging: android: ion: Support for mapping with dma mapping attributes

2019-01-21 Thread Brian Starkey
Hi Liam, On Fri, Jan 18, 2019 at 10:37:47AM -0800, Liam Mark wrote: > Add support for configuring dma mapping attributes when mapping > and unmapping memory through dma_buf_map_attachment and > dma_buf_unmap_attachment. > > For example this will allow ION clients to skip cache maintenance, by > u

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-21 Thread Brian Starkey
16/19 4:54 PM, Liam Mark wrote: > >>> On Wed, 16 Jan 2019, Andrew F. Davis wrote: > >>> > >>>> On 1/16/19 9:19 AM, Brian Starkey wrote: > >>>>> Hi :-) > >>>>> > >>>>> On Tue, Jan 15, 2019 at 12:40:16PM -0600,

Re: [PATCH 11/14] staging: android: ion: Allow heap name to be null

2019-01-16 Thread Brian Starkey
Hi Andrew, On Fri, Jan 11, 2019 at 12:05:20PM -0600, Andrew F. Davis wrote: > The heap name can be used for debugging but otherwise does not seem > to be required and no other part of the code will fail if left NULL > except here. We can make it required and check for it at some point, > for now l

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-16 Thread Brian Starkey
Hi :-) On Tue, Jan 15, 2019 at 12:40:16PM -0600, Andrew F. Davis wrote: > On 1/15/19 12:38 PM, Andrew F. Davis wrote: > > On 1/15/19 11:45 AM, Liam Mark wrote: > >> On Tue, 15 Jan 2019, Andrew F. Davis wrote: > >> > >>> On 1/14/19 11:13 AM, Liam Mark wrote: > On Fri, 11 Jan 2019, Andrew F. Da

Re: [PATCH] drm/fourcc: Add modifier defininitions for AFBC 1.3

2019-01-15 Thread Brian Starkey
-by on any patches that you send, but otherwise this is: Reviewed-by: Brian Starkey Thanks! -Brian > --- > include/uapi/drm/drm_fourcc.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.

Re: [RFC AFBC 03/12] drm/afbc: Add AFBC modifier usage documentation

2019-01-14 Thread Brian Starkey
Hi Jani, On Mon, Jan 14, 2019 at 02:23:46PM +0200, Jani Nikula wrote: > On Fri, 11 Jan 2019, Liviu Dudau wrote: > > On Thu, Jan 03, 2019 at 05:44:26PM -0300, Ezequiel Garcia wrote: > >> Hi Liviu, > >> > >> On Mon, 2018-12-03 at 11:31 +0000, Ayan Hald

Re: [PATCH 1/7] drm/komeda: Add d71_enum_resources and d71_cleanup

2019-01-07 Thread Brian Starkey
Hi James, A few minor comments. On Mon, Dec 24, 2018 at 08:58:46AM +, james qian wang (Arm Technology China) wrote: > D71 consists of a number of Register Blocks, every Block controls a > specific HW function, every block has a common block_header to represent > its type and pipeline informa

Re: [PATCH v10 13/16] vb2: add out-fence support to QBUF

2018-05-25 Thread Brian Starkey
Hi Ezequiel, Not sure if this patch series is still relevant, but I spotted a couple more things below. On Mon, May 21, 2018 at 01:59:43PM -0300, Ezequiel Garcia wrote: From: Gustavo Padovan If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create an out_fence and send its fd to

Re: [PATCH] drm: check_pixel_format() should return true if no modifiers are passed for a supported pixel format

2018-05-25 Thread Brian Starkey
Hi Ayan, On Fri, May 25, 2018 at 04:35:41PM +0100, Ayan Kumar Halder wrote: If a plane supports a pixel format and the framebuffer does not pass any modifiers, then drm_plane_check_pixel_format() should always return true for the given format regardless of whether the plane supports any modifier

Re: [PATCH v9 1/3] drm: Add writeback connector type

2018-05-25 Thread Brian Starkey
On Thu, May 24, 2018 at 05:41:01PM +0100, Liviu Dudau wrote: From: Brian Starkey Writeback connectors represent writeback engines which can write the CRTC output to a memory framebuffer. Add a writeback connector type and related support functions. Drivers should initialize a writeback

Re: [PATCH v7 3/5] drm/mali-dp: Add writeback support for DP500.

2018-05-18 Thread Brian Starkey
Hi Liviu, On Fri, May 18, 2018 at 09:24:21AM +0100, Liviu Dudau wrote: Mali DP500 behaves differently from the rest of the Mali DP IP, in that it does not have a one-shot mode and keeps writing the content of the current frame to the provided memory area until stopped. As a way of emulating the

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
On Wed, May 09, 2018 at 01:03:15PM -0300, Ezequiel Garcia wrote: On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, void *pb) >b->timestamp = ns_to_timeval(vb->timestamp); >b-&

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Brian Starkey
On Wed, May 09, 2018 at 12:52:26PM -0300, Ezequiel Garcia wrote: On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: Hi Ezequiel, On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Turn the reserved2 field into fence_fd that we will us

Re: [PATCH v9 12/15] vb2: add out-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi, On Fri, May 04, 2018 at 05:06:09PM -0300, Ezequiel Garcia wrote: From: Gustavo Padovan If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create an out_fence and send its fd to userspace in the fence_fd field as a return arg for the QBUF call. The fence is signaled on buffer_d

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
fences always keep the order userspace queues the buffers. - Protect in_fence manipulation with a lock (Brian Starkey) - check if fences have the same context before adding a fence array - Fix last_fence ref unbalance in __set_in_fence() (Brian Starkey) - Clean up fence if __set_in_

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi, On Tue, May 08, 2018 at 08:18:06PM -0300, Gustavo Padovan wrote: Hi Hans, On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan [snip] > diff --git a/include/media/videobuf2-core.h > b/include/media/videobuf2-core.h >

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Brian Starkey
Hi Ezequiel, On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel or return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE,

Re: [PATCH 8/8] drm/arm/malidp: Added the late system pm functions

2018-04-13 Thread Brian Starkey
Hi Daniel, On Fri, Apr 13, 2018 at 05:44:09PM +0200, Daniel Vetter wrote: On Mon, Apr 09, 2018 at 05:15:08PM +0100, Brian Starkey wrote: Hi Daniel, On Mon, Apr 09, 2018 at 10:23:37AM +0200, Daniel Vetter wrote: > On Fri, Apr 06, 2018 at 08:02:16PM +0100, Ayan Halder wrote: > > On Tu

Re: [PATCH 8/8] drm/arm/malidp: Added the late system pm functions

2018-04-09 Thread Brian Starkey
Hi Daniel, On Mon, Apr 09, 2018 at 10:23:37AM +0200, Daniel Vetter wrote: On Fri, Apr 06, 2018 at 08:02:16PM +0100, Ayan Halder wrote: On Tue, Mar 27, 2018 at 01:09:36PM +0200, Daniel Vetter wrote: > On Tue, Mar 27, 2018 at 11:59 AM, Ayan Halder wrote: > > On Tue, Mar 27, 2018 at 10:29:03AM +0

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-20 Thread Brian Starkey
On Fri, Nov 17, 2017 at 11:19:05AM -0200, Mauro Carvalho Chehab wrote: Em Fri, 17 Nov 2017 11:08:01 -0200 Gustavo Padovan escreveu: 2017-11-17 Mauro Carvalho Chehab : > Em Fri, 17 Nov 2017 15:49:23 +0900 > Alexandre Courbot escreveu: > > > > @@ -178,6 +179,12 @@ static int vb2_queue_or_prepa

[PATCH] clk: versatile: Remove WARNs in ->round_rate()

2017-11-13 Thread Brian Starkey
which trigger when an unachievable clock rate is passed to vexpress_osc_round_rate(). Reported-by: Vladimir Murzin Signed-off-by: Brian Starkey Acked-by: Sudeep Holla --- drivers/clk/versatile/clk-vexpress-osc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

Re: [PATCH] drm: hdlcd: Skip checking the clock provider when CRTC is disabled.

2017-11-01 Thread Brian Starkey
On Wed, Nov 01, 2017 at 02:16:25PM +, Liviu Dudau wrote: Some clock providers (clk-vexpress-osc) trigger a WARN() when the requested rate falls outside its capabilities, as is the case when a CRTC gets disabled. Check if the CRTC's new state is enabled and skip the clk_round_rate() call if it

Re: [RFC v4 17/17] [media] v4l: Document explicit synchronization behaviour

2017-10-27 Thread Brian Starkey
On Fri, Oct 20, 2017 at 07:50:12PM -0200, Gustavo Padovan wrote: From: Gustavo Padovan Add section to VIDIOC_QBUF about it v3: - make the out_fence refer to the current buffer (Hans) - Note what happens when the IN_FENCE is not set (Hans) v2: - mention that fences are

Re: [RFC v4 16/17] [media] vb2: add out-fence support to QBUF

2017-10-27 Thread Brian Starkey
Hi Gustavo, On Fri, Oct 20, 2017 at 07:50:11PM -0200, Gustavo Padovan wrote: From: Gustavo Padovan If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create an out_fence and send to userspace on the V4L2_EVENT_OUT_FENCE when the buffer is queued to the driver, or right away if the

Re: [RFC v4 15/17] [media] vb2: add infrastructure to support out-fences

2017-10-27 Thread Brian Starkey
Hi Gustavo, Sorry for the sporadic review... I'm struggling to get time to look at these. On Fri, Oct 20, 2017 at 07:50:10PM -0200, Gustavo Padovan wrote: From: Gustavo Padovan Add vb2_setup_out_fence() and the needed members to struct vb2_buffer. v2: - change it to reflect fd_install at

Re: [RFC v4 13/17] [media] vb2: add in-fence support to QBUF

2017-10-25 Thread Brian Starkey
v5: - use fence_array to keep buffers ordered in vb2 core when needed (Brian Stark) - keep backward compatibility on the reserved2 field (Brian Stark) - protect fence callback removal with lock (Brian Stark) Brian Starkey, but close ;-) v4: - Add a comment

Re: [PATCH v3 00/15] V4L2 Explicit Synchronization support

2017-10-12 Thread Brian Starkey
Hi, On Wed, Oct 04, 2017 at 05:08:55PM -0300, Gustavo Padovan wrote: Hi Brian, On Mon, 2017-10-02 at 14:41 +0100, Brian Starkey wrote: Hi Gustavo, On Thu, Sep 07, 2017 at 03:42:11PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi, > > Refer to the documentati

Re: [PATCH v3 10/15] [media] vb2: add 'ordered' property to queues

2017-10-02 Thread Brian Starkey
Hi, On Thu, Sep 07, 2017 at 03:42:21PM -0300, Gustavo Padovan wrote: From: Gustavo Padovan For explicit synchronization (and soon for HAL3/Request API) we need the v4l2-driver to guarantee the ordering in which the buffers were queued by userspace. This is already true for many drivers, but we

Re: [PATCH v3 04/15] [media] vb2: add in-fence support to QBUF

2017-10-02 Thread Brian Starkey
Hi, On Thu, Sep 07, 2017 at 03:42:15PM -0300, Gustavo Padovan wrote: From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers are only queued to the driver once they are ready. A buffer is ready when its in-fenc

Re: [PATCH v3 02/15] [media] vb2: add explicit fence user API

2017-10-02 Thread Brian Starkey
Hi, On Thu, Sep 07, 2017 at 03:42:13PM -0300, Gustavo Padovan wrote: From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel and return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that sho

Re: [PATCH v3 00/15] V4L2 Explicit Synchronization support

2017-10-02 Thread Brian Starkey
Hi Gustavo, On Thu, Sep 07, 2017 at 03:42:11PM -0300, Gustavo Padovan wrote: From: Gustavo Padovan Hi, Refer to the documentation on the first patch for the details. The previous iteration is here: https://www.mail-archive.com/linux-media@vger.kernel.org/msg118077.html The 2nd patch propose

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-19 Thread Brian Starkey
On Wed, Apr 19, 2017 at 01:34:34PM +0200, Boris Brezillon wrote: On Wed, 19 Apr 2017 10:51:23 +0100 Brian Starkey wrote: [snip] Could you expand a bit on how you think planes fit better? Just had the impression that the writeback feature was conceptually closer to a plane object (which is

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-19 Thread Brian Starkey
On Tue, Apr 18, 2017 at 09:57:17PM +0200, Boris Brezillon wrote: Hi Brian, On Tue, 18 Apr 2017 18:34:43 +0100 Brian Starkey wrote: >> @@ -214,6 +214,19 @@ struct drm_connector_state { >>struct drm_encoder *best_encoder; >> >>struct

Re: [PATCH 6/6] drm: mali-dp: Add writeback connector

2017-04-18 Thread Brian Starkey
On Fri, Apr 14, 2017 at 11:47:00AM +0200, Boris Brezillon wrote: On Fri, 25 Nov 2016 16:49:04 + Brian Starkey wrote: +static int +malidp_mw_encoder_atomic_check(struct drm_encoder *encoder, + struct drm_crtc_state *crtc_state

Re: [PATCH 2/6] drm: writeback: Add out-fences for writeback connectors

2017-04-18 Thread Brian Starkey
On Fri, Apr 14, 2017 at 12:11:14PM +0200, Boris Brezillon wrote: On Fri, 25 Nov 2016 16:49:00 + Brian Starkey wrote: Add the OUT_FENCE_PTR property to writeback connectors, to enable userspace to get a fence which will signal once the writeback is complete. It is not allowed to request an

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-18 Thread Brian Starkey
Hi Boris, On Fri, Apr 14, 2017 at 12:08:23PM +0200, Boris Brezillon wrote: On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index b5c6a8e..6bbd93f 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b

Re: [RFC PATCH v3 0/6] Introduce writeback connectors

2017-04-18 Thread Brian Starkey
Hi Boris, On Fri, Apr 14, 2017 at 11:35:17AM +0200, Boris Brezillon wrote: Hi Brian, On Fri, 25 Nov 2016 16:48:58 + Brian Starkey wrote: Hi, This is v3 of my series introducing a new connector type: DRM_MODE_CONNECTOR_WRITEBACK See v1 and v2 here: [1] [2] Writeback connectors are

Re: DRM Atomic property for color-space conversion

2017-03-17 Thread Brian Starkey
Hi Ville, On Thu, Mar 16, 2017 at 07:36:56PM +0200, Ville Syrjälä wrote: On Thu, Mar 16, 2017 at 07:05:12PM +0200, Sharma, Shashank wrote: On 3/16/2017 5:55 PM, Brian Starkey wrote: > On Thu, Mar 16, 2017 at 05:14:07PM +0200, Sharma Shashank wrote: >> On 3/16/2017 4:37 PM, Local user

Re: DRM Atomic property for color-space conversion

2017-03-16 Thread Brian Starkey
On 3/16/2017 4:07 PM, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at 03:55:41PM +, Brian Starkey wrote: On Tue, Jan 31, 2017 at 05:15:46PM +0200, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at 12:33:29PM +, Brian Starkey wrote: Hi, On Mon, Jan 30, 2017 at 03:35:13PM +0200, Ville Syrjälä

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-13 Thread Brian Starkey
On Sun, Mar 12, 2017 at 02:34:14PM +0100, Benjamin Gaignard wrote: 2017-03-09 18:38 GMT+01:00 Laura Abbott : On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: 2017-03-06 17:04 GMT+01:00 Daniel Vetter : On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: On Mon, Mar 06, 2017 at 11:40:41

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Brian Starkey
On Fri, Mar 10, 2017 at 11:46:42AM +, Robin Murphy wrote: On 10/03/17 10:31, Brian Starkey wrote: Hi, On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: [snip] For me those patches are going in the right direction. I still

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Brian Starkey
Hi, On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: [snip] For me those patches are going in the right direction. I still have few questions: - since alignment management has been remove from ion-core, should it be also removed

Re: [PATCH v2] drm/color: Document CTM eqations

2017-02-17 Thread Brian Starkey
What's the verdict? We've got [1] which is about to become another (driver) implementation - better to change before that merges than after I guess. -Brian [1] https://lkml.org/lkml/2017/2/13/304 On Wed, Feb 15, 2017 at 11:56:55AM +, Daniel Stone wrote: Hi, On 15 February 2017 at 11:39, V

Re: [PATCH 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Brian Starkey
I'd be fine with you squashing these two together, but either way both are: Reviewed-by: Brian Starkey (two nitpicks below, but take them or leave them.) On Wed, Feb 01, 2017 at 10:16:57AM +, Mihail Atanassov wrote: Add a custom CRTC state struct to enable storing driver-private per

Re: [PATCH] drm: mali-dp: Add CTM support

2017-02-01 Thread Brian Starkey
+Daniel to weigh in on the coefficient conversion. On Wed, Feb 01, 2017 at 12:05:03PM +, Mihail Atanassov wrote: All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.1

[PATCH v4] drm/color: Document CTM eqations

2017-01-31 Thread Brian Starkey
Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc: Lionel Landwerlin Cc: Daniel Vetter Signed-off-by: Brian Starkey --- drivers/gpu/drm/drm_color_mgmt.c | 13 + include

Re: DRM Atomic property for color-space conversion

2017-01-31 Thread Brian Starkey
On Tue, Jan 31, 2017 at 05:15:46PM +0200, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at 12:33:29PM +, Brian Starkey wrote: Hi, On Mon, Jan 30, 2017 at 03:35:13PM +0200, Ville Syrjälä wrote: >On Fri, Jan 27, 2017 at 05:23:24PM +0000, Brian Starkey wrote: >> Hi, >> >> We

Re: [PATCH v3 3/3] drm: rcar-du: Add VSP1 live source support

2017-01-31 Thread Brian Starkey
On Thu, Jan 26, 2017 at 12:38:26AM +0300, Sergei Shtylyov wrote: From: Laurent Pinchart Register live sources for VSPD0 and VSPD1 and configure the plane source at plane setup time to source frames from memory or from the VSP1. [Sergei: ported to the modern kernel.] Signed-off-by: Laurent Pin

Re: [PATCH v3 2/3] drm: Connect live source to framebuffers

2017-01-31 Thread Brian Starkey
On Thu, Jan 26, 2017 at 12:36:55AM +0300, Sergei Shtylyov wrote: From: Laurent Pinchart Introduce a new live source flag for framebuffers. When a framebuffer is created with that flag set, a live source is associated with the framebuffer instead of buffer objects. The framebuffer can then be us

Re: [PATCH v3 1/3] drm: Add live source object

2017-01-31 Thread Brian Starkey
Hi Sergei, I wasn't around to see v1/v2 but I've taken a quick look in the archives. As context for my comments below, I'm keen to push for something which can be reused for live-sinks, so that we can hook a writeback connector (when I land that) into a v4l2 device for video capture. In that ca

Re: [PATCH v2] drm/color: Document CTM eqations

2017-01-31 Thread Brian Starkey
Hi Ville, On Tue, Jan 31, 2017 at 05:18:28PM +0200, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at 10:48:34AM +, Brian Starkey wrote: Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc

[PATCH v3] drm/color: Document CTM eqations

2017-01-31 Thread Brian Starkey
Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc: Lionel Landwerlin Cc: Daniel Vetter Signed-off-by: Brian Starkey --- drivers/gpu/drm/drm_color_mgmt.c | 13 + include

Re: DRM Atomic property for color-space conversion

2017-01-31 Thread Brian Starkey
Hi, On Mon, Jan 30, 2017 at 03:35:13PM +0200, Ville Syrjälä wrote: On Fri, Jan 27, 2017 at 05:23:24PM +, Brian Starkey wrote: Hi, We're looking to enable the per-plane color management hardware in Mali-DP with atomic properties, which has sparked some conversation around how to h

Re: [PATCH v2] drm/color: Document CTM eqations

2017-01-31 Thread Brian Starkey
Hi Jani, On Tue, Jan 31, 2017 at 01:30:41PM +0200, Jani Nikula wrote: On Tue, 31 Jan 2017, Brian Starkey wrote: Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc: Lionel Landwerlin Cc

[PATCH v2] drm/color: Document CTM eqations

2017-01-31 Thread Brian Starkey
Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc: Lionel Landwerlin Cc: Daniel Vetter Signed-off-by: Brian Starkey --- drivers/gpu/drm/drm_color_mgmt.c | 13 + include

DRM Atomic property for color-space conversion

2017-01-27 Thread Brian Starkey
Hi, We're looking to enable the per-plane color management hardware in Mali-DP with atomic properties, which has sparked some conversation around how to handle YCbCr formats. As it stands today, it's assumed that a driver will implicitly "do the right thing" to display a YCbCr buffer. YCbCr dat

[PATCH 1/6] drm: Add writeback connector type

2016-11-25 Thread Brian Starkey
check to allow CRTC to be set without an FB - Add some writeback_ prefixes - Drop PIXEL_FORMATS_SIZE property, as it was unnecessary Gustavo Padovan: - Add drm_writeback_job to handle writeback signalling centrally Signed-off-by: Brian Starkey --- Documentation/gpu/drm-kms.rst |9

[PATCH 2/6] drm: writeback: Add out-fences for writeback connectors

2016-11-25 Thread Brian Starkey
Store fence in drm_writeback_job Gustavo Padovan: - Move out_fence_ptr out of connector_state - Signal fence from drm_writeback_signal_completion instead of in driver directly Signed-off-by: Brian Starkey --- drivers/gpu/drm/drm_atomic.c| 96 + dr

[PATCH 5/6] drm: mali-dp: Add RGB writeback formats for DP550/DP650

2016-11-25 Thread Brian Starkey
Add a layer bit for the SE memory-write, and add it to the pixel format matrix for DP550/DP650. Signed-off-by: Brian Starkey --- drivers/gpu/drm/arm/malidp_hw.c | 28 ++-- drivers/gpu/drm/arm/malidp_hw.h |1 + 2 files changed, 15 insertions(+), 14 deletions

[PATCH 6/6] drm: mali-dp: Add writeback connector

2016-11-25 Thread Brian Starkey
Signed-off-by: Brian Starkey --- drivers/gpu/drm/arm/Makefile |1 + drivers/gpu/drm/arm/malidp_crtc.c | 21 +++ drivers/gpu/drm/arm/malidp_drv.c | 25 +++- drivers/gpu/drm/arm/malidp_drv.h |3 + drivers/gpu/drm/arm/malidp_hw.c |7 +- drivers/gpu/drm/arm/malidp_mw.

[PATCH 4/6] drm: mali-dp: Add support for writeback on DP550/DP650

2016-11-25 Thread Brian Starkey
. Signed-off-by: Liviu Dudau Signed-off-by: Brian Starkey --- drivers/gpu/drm/arm/malidp_hw.c | 52 +++-- drivers/gpu/drm/arm/malidp_hw.h | 18 + drivers/gpu/drm/arm/malidp_regs.h | 15 +++ 3 files changed, 83 insertions(+), 2 deletions

[PATCH 3/6] drm: mali-dp: Rename malidp_input_format

2016-11-25 Thread Brian Starkey
We're going to use the same format list for output formats, so rename everything related to input formats to avoid confusion. Signed-off-by: Brian Starkey Reviewed-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_hw.c | 24 drivers/gpu/drm/arm/malidp

[RFC PATCH v3 0/6] Introduce writeback connectors

2016-11-25 Thread Brian Starkey
tion of drm_writeback_job) is probably up for debate. v4 will be accompanied by igt tests. As always, I look forward to any comments. Thanks, Brian [1] http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1247574.html [2] http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg125801

  1   2   3   >