Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface

2020-11-18 Thread Brice Goglin
Le 17/11/2020 à 16:55, Brice Goglin a écrit : > Le 12/11/2020 à 11:49, Greg Kroah-Hartman a écrit : >> On Thu, Nov 12, 2020 at 10:10:57AM +0100, Brice Goglin wrote: >>> Le 12/11/2020 à 07:42, Greg Kroah-Hartman a écrit : >>>> On Thu, Nov 12, 2020 at 07:19:

Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface

2020-11-17 Thread Brice Goglin
Le 12/11/2020 à 11:49, Greg Kroah-Hartman a écrit : > On Thu, Nov 12, 2020 at 10:10:57AM +0100, Brice Goglin wrote: >> Le 12/11/2020 à 07:42, Greg Kroah-Hartman a écrit : >>> On Thu, Nov 12, 2020 at 07:19:48AM +0100, Brice Goglin wrote: >>>> >>>> Hello

Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface

2020-11-12 Thread Brice Goglin
Le 12/11/2020 à 07:42, Greg Kroah-Hartman a écrit : > On Thu, Nov 12, 2020 at 07:19:48AM +0100, Brice Goglin wrote: >> Le 07/10/2020 à 07:15, Greg Kroah-Hartman a écrit : >>> On Tue, Oct 06, 2020 at 08:14:47PM -0700, Ricardo Neri wrote: >>>> On Tue, Oct 06, 2020 a

Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface

2020-11-11 Thread Brice Goglin
Le 07/10/2020 à 07:15, Greg Kroah-Hartman a écrit : > On Tue, Oct 06, 2020 at 08:14:47PM -0700, Ricardo Neri wrote: >> On Tue, Oct 06, 2020 at 09:37:44AM +0200, Greg Kroah-Hartman wrote: >>> On Mon, Oct 05, 2020 at 05:57:36PM -0700, Ricardo Neri wrote: On Sat, Oct 03, 2020 at 10:53:45AM +0200,

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Brice Goglin
Le 19/10/2020 à 16:16, Morten Rasmussen a écrit : > >>> If there is a provable benefit of having interconnect grouping >>> information, I think it would be better represented by a distance matrix >>> like we have for NUMA. >> There have been some discussions in various forums about how to >> desc

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Brice Goglin
Le 19/10/2020 à 14:50, Peter Zijlstra a écrit : > On Mon, Oct 19, 2020 at 01:32:26PM +0100, Jonathan Cameron wrote: >> On Mon, 19 Oct 2020 12:35:22 +0200 >> Peter Zijlstra wrote: >>> I'm confused by all of this. The core level is exactly what you seem to >>> want. >> It's the level above the cor

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Brice Goglin
Le 16/10/2020 à 17:27, Jonathan Cameron a écrit : > Both ACPI and DT provide the ability to describe additional layers of > topology between that of individual cores and higher level constructs > such as the level at which the last level cache is shared. > In ACPI this can be represented in PPTT as

Re: [PATCHv2 1/2] hmat: Register memory-side cache after parsing

2019-07-01 Thread Brice Goglin
IMM node). Tested-by: Brice Goglin > --- > v1 -> v2: > > Fixed multi-level caches, and no caches. v1 incorrectly assumed only a level > 1 always existed (Brice). > > drivers/acpi/hmat/hmat.c | 70 > +--- > 1 file cha

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-12 Thread Brice Goglin
Le 12/04/2019 à 21:52, Len Brown a écrit : I think I prefer 's/threads/cpus/g' on that. Threads makes me think SMT, and I don't think there's any guarantee the part in question will have SMT on. >>> I think 'threads' is a bit confusing as well. We seem to be using 'cpu' >>> everywher

Re: [PATCH] hmat: Register attributes for memory hot add

2019-04-10 Thread Brice Goglin
-tested-by: Brice Goglin Just one minor typo below. Le 09/04/2019 à 23:44, Keith Busch a écrit : > Some types of memory nodes that HMAT describes may not be online at the > time we initially parse their nodes' tables. If the node should be set > to online later, as can happen when usi

Re: [RFC PATCH 0/10] Another Approach to Use PMEM as NUMA Node

2019-03-25 Thread Brice Goglin
Le 25/03/2019 à 20:29, Dan Williams a écrit : > Perhaps "path" might be a suitable replacement identifier rather than > type. I.e. memory that originates from an ACPI.NFIT root device is > likely "pmem". Could work. What kind of "path" would we get for other types of memory? (DDR, non-ACPI-bas

Re: [RFC PATCH 0/10] Another Approach to Use PMEM as NUMA Node

2019-03-25 Thread Brice Goglin
Le 25/03/2019 à 17:56, Dan Williams a écrit : > > I'm generally against the concept that a "pmem" or "type" flag should > indicate anything about the expected performance of the address range. > The kernel should explicitly look to the HMAT for performance data and > not otherwise make type-based p

Re: [RFC PATCH 0/10] Another Approach to Use PMEM as NUMA Node

2019-03-25 Thread Brice Goglin
Le 23/03/2019 à 05:44, Yang Shi a écrit : > With Dave Hansen's patches merged into Linus's tree > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c221c0b0308fd01d9fb33a16f64d2fd95f8830a4 > > PMEM could be hot plugged as NUMA node now. But, how to use PMEM as NUMA n

Re: [PATCHv8 00/10] Heterogenous memory node attributes

2019-03-11 Thread Brice Goglin
cellaneous typos, editorial clarifications, and whitespace fixups. > > Merged to most current linux-next. > > Added received review, test, and ack by's. Tested-by: Brice Goglin I tested this series with several manually-created HMATs. I already have user-space support

Re: [PATCHv6 07/10] acpi/hmat: Register processor domain to its memory

2019-03-07 Thread Brice Goglin
Le 14/02/2019 à 18:10, Keith Busch a écrit : > If the HMAT Subsystem Address Range provides a valid processor proximity > domain for a memory domain, or a processor domain matches the performance > access of the valid processor proximity domain, register the memory > target with that initiator so t

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-24 Thread Brice Goglin
Le 19/02/2019 à 04:40, Len Brown a écrit : > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index ccd1f2a8e557..4250a87f57db 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -393,6 +393,7 @@ static bool match_smt(struct cpuinfo_x86 *c, struct >

Re: [PATCHv6 06/10] node: Add memory-side caching attributes

2019-02-22 Thread Brice Goglin
Le 14/02/2019 à 18:10, Keith Busch a écrit : > System memory may have caches to help improve access speed to frequently > requested address ranges. While the system provided cache is transparent > to the software accessing these memory ranges, applications can optimize > their own access based on c

Re: [PATCHv6 06/10] node: Add memory-side caching attributes

2019-02-22 Thread Brice Goglin
Le 14/02/2019 à 18:10, Keith Busch a écrit : > System memory may have caches to help improve access speed to frequently > requested address ranges. While the system provided cache is transparent > to the software accessing these memory ranges, applications can optimize > their own access based on c

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-21 Thread Brice Goglin
Le 21/02/2019 à 08:41, Len Brown a écrit : > > Here is my list of applications that care about the new CPUID leaf > and the concepts of packages and die: > > cpuid > lscpu > x86_energy_perf_policy > turbostat You may add hwloc/lstopo which is used by most HPC runtimes (including your employers'

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-20 Thread Brice Goglin
Le 19/02/2019 à 04:40, Len Brown a écrit : > From: Len Brown > > like core_siblings, except it shows which die are in the same package. > > This is needed for lscpu(1) to correctly display die topology. > > Signed-off-by: Len Brown > Cc: linux-...@vger.kernel.org > Signed-off-by: Len Brown > ---

Re: [PATCHv6 00/10] Heterogenous memory node attributes

2019-02-18 Thread Brice Goglin
Le 14/02/2019 à 18:10, Keith Busch a écrit : > == Changes since v5 == > > Updated HMAT parsing to account for the recently released ACPI 6.3 > changes. > > HMAT attribute calculation overflow checks. > > Fixed memory leak if HMAT parse fails. > > Minor change to the patch order. All the

Re: [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM

2019-02-13 Thread Brice Goglin
Le 13/02/2019 à 09:43, Brice Goglin a écrit : > Le 13/02/2019 à 09:24, Dan Williams a écrit : >> On Wed, Feb 13, 2019 at 12:12 AM Brice Goglin wrote: >>> Le 13/02/2019 à 01:30, Dan Williams a écrit : >>>> On Tue, Feb 12, 2019 at 11:59 AM Brice Goglin >>&g

Re: [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM

2019-02-13 Thread Brice Goglin
Le 13/02/2019 à 09:24, Dan Williams a écrit : > On Wed, Feb 13, 2019 at 12:12 AM Brice Goglin wrote: >> Le 13/02/2019 à 01:30, Dan Williams a écrit : >>> On Tue, Feb 12, 2019 at 11:59 AM Brice Goglin wrote: >>>> # ndctl disable-region all >>>> # ndctl

Re: [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM

2019-02-13 Thread Brice Goglin
Le 13/02/2019 à 01:30, Dan Williams a écrit : > On Tue, Feb 12, 2019 at 11:59 AM Brice Goglin wrote: >> # ndctl disable-region all >> # ndctl zero-labels all >> # ndctl enable-region region0 >> # ndctl create-namespace -r region0 -t pmem -m devdax >> { >

Re: [PATCH v2] device-dax: Auto-bind device after successful new_id

2019-02-13 Thread Brice Goglin
orted-by: Alexander Duyck > Reported-by: Brice Goglin > Cc: Dave Hansen > Signed-off-by: Dan Williams > --- > Changes since v1: > * Fix the remove_id path since do_id_store() is shared with the new_id > path (Brice) > > Brice, this works for me. I'll push it out on libnvdi

Re: [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM

2019-02-12 Thread Brice Goglin
Le 11/02/2019 à 17:22, Dave Hansen a écrit : > On 2/9/19 3:00 AM, Brice Goglin wrote: >> I've used your patches on fake hardware (memmap=xx!yy) with an older >> nvdimm-pending branch (without Keith's patches). It worked fine. This >> time I am running on real In

Re: [PATCHv4 10/13] node: Add memory caching attributes

2019-02-12 Thread Brice Goglin
Le 11/02/2019 à 16:23, Keith Busch a écrit : > On Sun, Feb 10, 2019 at 09:19:58AM -0800, Jonathan Cameron wrote: >> On Sat, 9 Feb 2019 09:20:53 +0100 >> Brice Goglin wrote: >> >>> Hello Keith >>> >>> Could we ever have a single side cache in fr

Re: [PATCHv4 10/13] node: Add memory caching attributes

2019-02-09 Thread Brice Goglin
Hello Keith Could we ever have a single side cache in front of two NUMA nodes ? I don't see a way to find that out in the current implementation. Would we have an "id" and/or "nodemap" bitmask in the sidecache structure ? Thanks Brice Le 16/01/2019 à 18:58, Keith Busch a écrit : > System memo

Re: [PATCH 0/9] Allow persistent memory to be used like normal RAM

2018-12-03 Thread Brice Goglin
Le 22/10/2018 à 22:13, Dave Hansen a écrit : > Persistent memory is cool. But, currently, you have to rewrite > your applications to use it. Wouldn't it be cool if you could > just have it show up in your system like normal RAM and get to > it like a slow blob of memory? Well... have I got the p

Re: [PATCH] ACPI/PPTT: Handle architecturally unknown cache types

2018-09-13 Thread Brice Goglin
Le 13/09/2018 à 11:35, Sudeep Holla a écrit : > On Thu, Sep 13, 2018 at 10:39:10AM +0100, James Morse wrote: >> Hi Brice, >> >> On 13/09/18 06:51, Brice Goglin wrote: >>> Le 12/09/2018 à 11:49, Sudeep Holla a écrit : >>>>> Yes.  Without this change,

Re: [PATCH] ACPI/PPTT: Handle architecturally unknown cache types

2018-09-12 Thread Brice Goglin
Le 12/09/2018 à 11:49, Sudeep Holla a écrit : > >> Yes.  Without this change, we hit the lscpu error in the commit message, >> and get zero output about the system.  We don't even get information >> about the caches which are architecturally specified or how many cpus >> are present.  With this cha

Re: [PATCH v7 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-03-08 Thread Brice Goglin
> Is there a good reason for diverging instead of adjusting the > core_sibling mask? On x86 the core_siblings mask is defined by the last > level cache span so they don't have this issue. No. core_siblings is defined as the list of cores that have the same physical_package_id (see the doc of sys

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

2017-12-30 Thread Brice Goglin
Le 30/12/2017 à 07:58, Matthew Wilcox a écrit : > On Wed, Dec 27, 2017 at 10:10:34AM +0100, Brice Goglin wrote: >>> Perhaps we can enlist /proc/iomem or a similar enumeration interface >>> to tell userspace the NUMA node and whether the kernel thinks it has >>&g

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

2017-12-27 Thread Brice Goglin
Le 22/12/2017 à 23:53, Dan Williams a écrit : > On Thu, Dec 21, 2017 at 12:31 PM, Brice Goglin wrote: >> Le 20/12/2017 à 23:41, Ross Zwisler a écrit : > [..] >> Hello >> >> I can confirm that HPC runtimes are going to use these patches (at least >> all

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

2017-12-21 Thread Brice Goglin
Le 20/12/2017 à 23:41, Ross Zwisler a écrit : > On Wed, Dec 20, 2017 at 02:29:56PM -0800, Dan Williams wrote: >> On Wed, Dec 20, 2017 at 1:24 PM, Ross Zwisler >> wrote: >>> On Wed, Dec 20, 2017 at 01:16:49PM -0800, Matthew Wilcox wrote: On Wed, Dec 20, 2017 at 12:22:21PM -0800, Dave Hansen wr

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Brice Goglin
Le 27/06/2017 16:21, Thomas Gleixner a écrit : > On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: >> On 6/27/17 17:48, Borislav Petkov wrote: >>> On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: However, this is not the case on AMD family17h multi-die processor pl

Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus.

2017-06-09 Thread Brice Goglin
Le 09/06/2017 15:28, Thomas Renninger a écrit : > On Thursday, June 08, 2017 08:24:01 PM Greg KH wrote: >> On Thu, Jun 08, 2017 at 06:56:14PM +0200, Felix Schnizlein wrote: >>> --- >>> arch/x86/kernel/Makefile| 1 + >>> arch/x86/kernel/cpuinfo_sysfs.c | 166 > +

Re: AMD Bulldozer topology regression since 4.6

2017-01-03 Thread Brice Goglin
Le 29/11/2016 22:02, Brice Goglin a écrit : > Le 29/11/2016 20:39, Borislav Petkov a écrit : >> Does that fix it? >> >> Patch is against latest tip/master because we have some more changes in >> that area. > I tested the second patch on top of 4.8.11, it brings

Re: bnx2 breaks Dell R815 BMC IPMI since 4.8

2016-11-29 Thread Brice Goglin
Le 30 novembre 2016 00:28:08 GMT+01:00, Gavin Shan a écrit : >On Tue, Nov 29, 2016 at 07:57:51AM +0100, Brice Goglin wrote: >>Hello >> >>My Dell PowerEdge R815 doesn't have IPMI anymore when I boot a 4.8 >>kernel, the BMC doesn't even ping anymore. I

Re: AMD Bulldozer topology regression since 4.6

2016-11-29 Thread Brice Goglin
Le 29/11/2016 20:39, Borislav Petkov a écrit : > Does that fix it? > > Patch is against latest tip/master because we have some more changes in > that area. I tested the second patch on top of 4.8.11, it brings core_id back to where it was before 4.6, thanks. Reported-and-tested-by:

AMD Bulldozer topology regression since 4.6

2016-11-28 Thread Brice Goglin
Hello Since Linux 4.6 (and still in 4.9-rc5 at least), both AMD Bulldozer cores of a single dual-core compute unit report the same core_id: $ cat /sys/devices/system/cpu/cpu{?,??}/topology/core_id 0 0 1 1 2 2 3 0 3 [...] Before 4.5 (and for a very long time), the kernel reported different core_

Re: Why is SECTOR_SIZE = 512 inside kernel ?

2015-08-18 Thread Brice Goglin
Le 17/08/2015 15:54, Theodore Ts'o a écrit : > > It's cast in stone. There are too many places all over the kernel, > especially in a huge number of file systems, which assume that the > sector size is 512 bytes. So above the block layer, the sector size > is always going to be 512. Could this

Re: [PATCH v3 3/3] libnvdimm: Add sysfs numa_node to NVDIMM devices

2015-06-19 Thread Brice Goglin
Do you have local_cpus and local_cpulist attributes as well? User-space tools such as hwloc use those for binding near I/O devices, although I guess we could have some CPU-less NVDIMM NUMA nodes? Brice Le 19/06/2015 20:18, Toshi Kani a écrit : > Add support of sysfs 'numa_node' to I/O-related N

Re: Topology updates and NUMA-level sched domains

2015-04-08 Thread Brice Goglin
Le 07/04/2015 21:41, Peter Zijlstra a écrit : > No, that's very much not the same. Even if it were dealing with hotplug > it would still assume the cpu to return to the same node. > > But mostly people do not even bother to handle hotplug. > You said userspace assumes the cpu<->node relation is a

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-21 Thread Brice Goglin
Le 18/09/2014 21:33, Dave Hansen a écrit : > After this set, there are only 2 sets of core siblings, which > is what we expect for a 2-socket system. > > # cat cpu*/topology/physical_package_id | sort | uniq -c > 18 0 > 18 1 > # cat cpu*/topology/core_siblings_list | sort | uniq -c >

Re: [PATCH] x86: Consider multiple nodes in a single socket to be "sane"

2014-09-16 Thread Brice Goglin
Le 16/09/2014 05:29, Peter Zijlstra a écrit : > >> This also fixes sysfs because CPUs with the same 'physical_package_id' >> in /sys/devices/system/cpu/cpu*/topology/ are not listed together >> in the same 'core_siblings_list'. This violates a statement from >> Documentation/ABI/testing/sysfs-devi

Re: NUMA processor numbering

2013-10-03 Thread Brice Goglin
Le 03/10/2013 12:46, Stephan von Krawczynski a écrit : > Ok, let me re-phrase the question a bit. > Is it really possible what you see here: > > processor : 0 > vendor_id : GenuineIntel > cpu family : 6 > model : 45 > model name : Intel(R) Xeon(R) CPU E5-2660 0 @ 2.2

Re: dmaengine: make dma_channel_rebalance() NUMA aware

2013-08-19 Thread Brice Goglin
re (MEMCPY channel X goes to processor X and to its hyperthread sibling). Signed-off-by: Brice Goglin --- drivers/dma/dmaengine.c | 64 +++- 1 file changed, 37 insertions(+), 27 deletions(-) Index: linux-3.11-rc3/drivers/dma/dmaengine.c ===

Re: dmaengine: make dma_channel_rebalance() NUMA aware

2013-08-19 Thread Brice Goglin
. This rebalance is rarely used, so this won't hurt. On the above SuperMicro machine, channels are still allocated the same. On the Dells, there are no locality issue anymore (MEMCPY channel X goes to processor X and to its hyperthread sibling). Signed-off-by: Brice Goglin --- drivers/dma/d

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
ove related fixups such as the 64-byte alignement restriction on legacy DMA operations (introduced in commit f26df1a1 as a workaround for silicon errata). Signed-off-by: Brice Goglin --- drivers/dma/ioat/dma_v3.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) I

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
ations (introduced in commit f26df1a1 as a workaround for silicon errata). Signed-off-by: Brice Goglin --- drivers/dma/ioat/dma_v3.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) Index: b/drivers/dma/ioat/dma_v3.c ===

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
ors. RAID offload is now disabled by default on buggy 3.2 platforms. Passing ioat_raid_enabled=1 force-enables it on all platforms (previous behavior). Passing ioat_raid_enabled=0 force-disables it everywhere. When RAID offload is disabled, legacy operations (memcpy, etc.) can work again withou

ioatdma: add ioat_raid_enabled module parameter

2013-07-31 Thread Brice Goglin
operations (memcpy, etc.) can work without alignment restrictions anymore. Signed-off-by: Brice Goglin --- drivers/dma/ioat/dma_v3.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Index: b/drivers/dma/ioat/dma_v3.c

dmaengine: make dma_channel_rebalance() NUMA aware

2013-07-31 Thread Brice Goglin
machine, channels are still allocated the same. On the Dells, there are no locality issue anymore (each MEMCPY channel goes to both hyperthreads of a single core of the local socket). Signed-off-by: Brice Goglin --- drivers/dma/dmaengine.c | 64 +++

Re: MTRR use in drivers

2013-06-22 Thread Brice Goglin
Le 21/06/2013 07:00, H. Peter Anvin a écrit : > An awful lot of drivers, mostly DRI drivers, are still mucking with > MTRRs directly as opposed to using ioremap_wc() or similar interfaces. > In addition to the architecture dependency, this is really undesirable > because MTRRs are a limited resourc

Re: [PATCH v3 04/10] thp: do_huge_pmd_wp_page(): handle huge zero page

2012-10-02 Thread Brice Goglin
Le 02/10/2012 17:19, Kirill A. Shutemov a écrit : > From: "Kirill A. Shutemov" > > On right access to huge zero page we alloc a new page and clear it. > s/right/write/ ? Brice -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

Re: [patch 1/6] mmu_notifier: Core code

2008-02-16 Thread Brice Goglin
Andrew Morton wrote: > What is the status of getting infiniband to use this facility? > > How important is this feature to KVM? > > To xpmem? > > Which other potential clients have been identified and how important it it > to those? > As I said when Andrea posted the first patch series, I used

[PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

2008-02-13 Thread Brice Goglin
[I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec No need to compute copy twice in the frags loop in dma_skb_copy_datagram_iovec(). Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- user_dma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ne

Re: Purpose of numa_node?

2008-02-13 Thread Brice Goglin
Yinghai Lu wrote: >>> Have a look at the above link. I don't get -1. I get 0 everywhere, while >>> I should get 1 for some devices. And if I unplug/replug a device using >>> fakephp, numa_node becomes correct (1 instead of 0). This just looks >>> like the code is there but things are initialized in

Re: Linux 2.6.25-rc1

2008-02-11 Thread Brice Goglin
Linus Torvalds wrote: > - Lots of cleanups from the x86 merge (making more and more use of common >files), but also the big page attribute stuff is in and caused a fair >amount of churn, and while most of the issues should have been very >obvious and all got fixed, this is definitel

Re: Purpose of numa_node?

2008-01-31 Thread Brice Goglin
Yinghai Lu wrote: > On Jan 31, 2008 5:42 AM, Brice Goglin <[EMAIL PROTECTED]> wrote: > >> It works fine on regular machines such as dual opterons. However, I >> noticed recently that it was wrong on some quad-opteron machines (see >> http://marc.info/?l=linux-pci&

Re: Purpose of numa_node?

2008-01-31 Thread Brice Goglin
Paul Mundt wrote: On Wed, Jan 30, 2008 at 07:48:13PM -0500, Chris Snook wrote: While pondering ways to optimize I/O and swapping on large NUMA machines, I noticed that the numa_node field in struct device isn't actually used anywhere. We just have a couple dozen lines of code to conditionall

Re: [patch] PCI: disable the MSI of AMD RS690

2008-01-24 Thread Brice Goglin
Shane Huang wrote: This patch recover Tejun's commit 4be8f906435a6af241821ab5b94b2b12cb7d57d8 because there is one MSI bug on RS690+SB600 board which will lead to boot failure. This bug is NOT same as the one in SB700 SATA controller, quirk_msi_intx_disable_bug does not work to SB600. Disablemen

Re: [PATCH] mmu notifiers #v2

2008-01-16 Thread Brice Goglin
Andrea Arcangeli wrote: This patch is last version of a basic implementation of the mmu notifiers. In short when the linux VM decides to free a page, it will unmap it from the linux pagetables. However when a page is mapped not just by the regular linux ptes, but also from the shadow pagetables,

[PATCH][LRO] Fix lro_mgr->features checks

2008-01-07 Thread Brice Goglin
st_bit(LRO_F_FOO,&x). Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Acked-by: Andrew Gallatin <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/inet_lro.c b/net/ipv4/inet_lro.c index 9a96c27..4a4d49f 100644 --- a/net/ipv4/inet_lro.c +++ b/net/ipv4/inet_lro.c @@ -310,7 +310,7 @@ stati

Re: State of the Linux PCI Subsystem for 2.6.23-rc8

2007-09-26 Thread Brice Goglin
Greg KH wrote: > On Wed, Sep 26, 2007 at 11:40:58PM +0200, Brice Goglin wrote: > >> Greg KH wrote: >> >>> Here's a summary of the current state of the Linux PCI subsystem, as of >>> 2.6.23-rc8. >>> >>> If the information in here

Re: State of the Linux PCI Subsystem for 2.6.23-rc8

2007-09-26 Thread Brice Goglin
Greg KH wrote: > Here's a summary of the current state of the Linux PCI subsystem, as of > 2.6.23-rc8. > > If the information in here is incorrect, or anyone knows of any > outstanding issues not listed here, please let me know. > > List of outstanding regressions from 2.6.22: > - none known.

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Brice Goglin
Eric W. Biederman wrote: > @@ -1677,43 +1650,16 @@ static int __devinit msi_ht_cap_enabled(struct > pci_dev *dev) > return 0; > } > > -/* Check the hypertransport MSI mapping to know whether MSI is enabled or > not */ > +/* Enable MSI on hypertransport chipsets supporting MSI */ > stati

Re: Linux 2.6.21-rc2

2007-02-27 Thread Brice Goglin
Linus Torvalds wrote: > Oh well.. I'm not very proud of this, because quite frankly, -rc2 has way > more changes than I really like. > Hi Linus, rc2 fails to build on my thinkpad t43: CC arch/i386/kernel/io_apic.o arch/i386/kernel/io_apic.c: In function 'setup_IO_APIC_irqs': arch/i386

Re: [PATCH 7/7] cxgb3 - Add SW LRO support

2007-02-27 Thread Brice Goglin
Steve Wise wrote: > You're right. But cxgb3 has it now in the driver (tested and working). > Shouldn't it be pulled in? When the network stack design gets done > (which could take a few releases to finalize), all the drivers can be > updated to use it. It doesn't seem reasonable to allow some dr

Re: 2.6.20-rc3: known unfixed regressions (v4)

2007-01-06 Thread Brice Goglin
Adrian Bunk wrote: > This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19 > that are not yet fixed in Linus' tree. > I reported another one yesterday, about HT MSI capability lookup being broken (can only find the first one in the chain). See http://lkml.org/lkml/2007/1/5/21

[PATCH] increment pos before looking for the next cap in __pci_find_next_ht_cap

2007-01-05 Thread Brice Goglin
again. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> --- drivers/pci/pci.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-rc/drivers/pci/pci.c

Re: ipw2200 device naming problems in 2.6.20-rc2-git1

2006-12-31 Thread Brice Goglin
Robert Hancock wrote: > Having some intermittent problems using my ipw2200 wireless card on > 2.6.20-rc2-git1 (may affect earlier versions as well) under Fedora > Core 6 i386. It appears that sometimes on bootup the interface gets > named with a junk name like __tmp32284835 and it doesn't show up i

[PATCH] speedstep-centrino: missing space and bracket

2006-12-20 Thread Brice Goglin
A space and a bracket are missing (and indentation is wrong). Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-rc/arch/i386/kernel/cpu/cpufreq/speedstep-cent

[PATCH] Fix typo in 'EXPERIMENTAL' in CC_STACKPROTECTOR on x86_64

2006-12-11 Thread Brice Goglin
Fix typo in 'EXPERIMENTAL' in config CC_STACKPROTECTOR in arch/x86_64/Kconfig. Signed-off-by: <[EMAIL PROTECTED]> --- arch/x86_64/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.git/arch/x86_64/Kconfig

Re: get device from file struct

2006-12-11 Thread Brice Goglin
Silviu Craciunas wrote: > quick question for the gurus.. is it possible to determine the hardware > device from a file struct during read/write system call. For example in > fs/read_write.c when doing a vfs_read. > file->f_dentry->d_inode gives you the inode. If the inode is on top of a block

Re: RFC: PCI quirks update for 2.6.16

2006-12-08 Thread Brice Goglin
> Any comments on whether it's really good or whether I should change > anything? > > > Brice Goglin (1): > PCI: nVidia quirk to make AER PCI-E extended capability visible > No problem with this one (but it won't be very useful since nobody used the PCIe

Re: sparse errors in srcu.h

2006-12-07 Thread Brice Goglin
Paul E. McKenney wrote: > On Wed, Dec 06, 2006 at 10:50:14AM +0100, Brice Goglin wrote: > >> Hi, >> >> When running sparse checks on a file that ends up including srcu.h, we >> get the following warnings: >> >> include/linux/srcu.h:52:44: error

Re: sparse errors in srcu.h

2006-12-07 Thread Brice Goglin
Paul E. McKenney wrote: > On Wed, Dec 06, 2006 at 10:50:14AM +0100, Brice Goglin wrote: > >> Hi, >> >> When running sparse checks on a file that ends up including srcu.h, we >> get the following warnings: >> >> include/linux/srcu.h:52:44: error

Re: sparse errors in srcu.h

2006-12-07 Thread Brice Goglin
Paul E. McKenney wrote: > On Wed, Dec 06, 2006 at 10:50:14AM +0100, Brice Goglin wrote: > >> Hi, >> >> When running sparse checks on a file that ends up including srcu.h, we >> get the following warnings: >> >> include/linux/srcu.h:52:44: error

sparse errors in srcu.h

2006-12-06 Thread Brice Goglin
Hi, When running sparse checks on a file that ends up including srcu.h, we get the following warnings: include/linux/srcu.h:52:44: error: undefined identifier 'sp' include/linux/srcu.h:52:44: error: bad constant expression include/linux/srcu.h:53:56: error: undefined identifier 'sp'

Re: [PATCH] pci quirks: remove redundant check

2006-12-05 Thread Brice Goglin
David Rientjes wrote: > Removes redundant check for dev->subordinate; if it is NULL, the function > returns before the patch-affected code region. > ACK, looks like I forgot to remove it when copy-pasting the quirk right above it. Brice > Cc: Martin Mares <[EMAIL PROTECTED]> > Cc: Greg Kro

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Brice Goglin
Steve Wise wrote: > There is no SW TCP stack in this driver. The HW supports RDMA over > TCP/IP/10GbE in HW and this is required for zero-copy RDMA over Ethernet > (aka iWARP). The device is a 10 GbE device, not Infiniband. Then, I wonder why the driver goes in drivers/infiniband/ :) Is there r

[PATCH] ALSA: hda-intel - Disable MSI support by default]

2006-11-16 Thread Brice Goglin
(forgot to cc: LKML) Roland Dreier wrote: > > A whitelist is an awkward solution, the problem is the number of > > chipsets available with MSI will continue to grow. And the assumption > > is that after Microsoft OS supports MSI, that newer chipsets will work. > > Maybe a whitelist for older sy

Re: USB Storage speed regression since 2.6.12

2005-09-01 Thread Brice Goglin
Le 01.09.2005 13:36, DervishD a écrit : > I don't know if this is a known issue, but usb-storage speed for > 'Full speed' devices dropped from 2.6.11.12 (more than 800Kb/s) to > 2.6.12 (less than 250Kb/s). The problem still exists in 2.6.13. > > The lack of speed seems to affect only the O

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
Le 19.08.2005 15:45, Russell King a écrit : > #ifdef CONFIG_SMP > extern int smp_nmi_call_function(void (*fn)(void *), void *priv, int whatever); > #else > static inline int smp_nmi_call_function(void (*fn)(void *), void *priv, int whatever) > { > return 0; > } > #endif > > Obviously I've pro

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
Le 19.08.2005 15:27, Russell King a écrit : > Since you're going to be adding #ifdef CONFIG_SMP...#endif around each > of these, why not fix where it's declared/defined to be empty? Probably because I'm too lazy to find a nice way to fix it :) smp_nmi_call_function may return an error but I don't

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
arch/i386/kernel/traps.c: In function 'die_nmi': arch/i386/kernel/traps.c:633: warning: statement with no effect Another smp_nmi_call. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Brice --- linux-mm/arch/i386/kernel/traps.c.old 2005-08-19 15:19:14.0 +0200 +

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
Le 19.08.2005 15:18, Brice Goglin a écrit : > drivers/char/sysrq.c: In function 'sysrq_handle_showregs': > drivers/char/sysrq.c:186: warning: statement with no effect > > This is caused by a smp call while CONFIG_SMP is not set. > The attached patch fixes this. Oops, reve

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
drivers/char/sysrq.c: In function 'sysrq_handle_showregs': drivers/char/sysrq.c:186: warning: statement with no effect This is caused by a smp call while CONFIG_SMP is not set. The attached patch fixes this. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Brice --- linux

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
Hi Andrew, Got this warning: drivers/char/drm/drm_agpsupport.c:429:5: warning: "LINUX_VERSION_CODE" is not defined This test is for old 2.4 code. The attached patch simply removes it. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Regards, Brice --- linux-mm/

[2.6.13-rc4-mm1] Fix smsc_ircc_init return value

2005-08-01 Thread Brice Goglin
see in 2.6.12 it should probably be set to -ENODEV at the begining of the "else" case. The attached patch does this. Note that I didn't actually see any breakage caused by this. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Regards, Brice --- linux-mm/drivers/net/irda/sm

Re: 2.6.13-rc3-mm2 (kbuild broken for external modules)

2005-07-27 Thread Brice Goglin
Le 27.07.2005 14:08, Miklos Szeredi a écrit : >> git-kbuild.patch > > > This breaks building of external modules: > >scripts/Makefile.build:14: > /usr/src/linux-2.6.13-rc3-mm2//home/miko/fuse/kernel/Makefile: No such file > or directory >make[2]: *** No rule to make target > `/usr/src

Re: compiling Kernel Modules with debugging information enabled

2005-07-16 Thread Brice Goglin
Le 16.07.2005 19:11, k8 s a écrit : > To be more clear, say I have selected CONFIG_XFRM=y in .config file > I want to make a change such that net/xfrm/Makefile has an entry > CFLAGS += -g so that it generates debugging information for all the > modules in that directory Look at Documentation/kbui

Re: 2.6.13-rc2-mm1

2005-07-07 Thread Brice Goglin
Le 07.07.2005 13:32, Brice Goglin a écrit : > Le 07.07.2005 13:00, Andrew Morton a écrit : > >>ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm1/ >> >>(kernel.org seems to be stuck again - there's a copy at >>http://www.z

Re: 2.6.13-rc2-mm1

2005-07-07 Thread Brice Goglin
rnel/power/disk.o kernel/power/disk.c: Dans la fonction « software_resume »: kernel/power/disk.c:242: attention : implicit declaration of function `name_to_dev_t' The attached patch adds an extern declaration in disk.c as it's already done in swsusp.c Signed-off-by: Brice Goglin <[EMA

Crash when unmounting NFS/TCP with -f

2005-04-22 Thread Brice Goglin
Hi Trond, I'm using NFS (v2) over TCP (in a SSH tunnel). Each time the SSH dies before a umount NFS, I have to umount -f and I get a crash (only sysrq works). Actually, the crash occurs a few seconds after umount -f. It seems that killing SSH by hand does _not_ lead to crash. But a long network fai

Re: [PATCH] radeonfb: (#2) Implement proper workarounds for PLL accesses

2005-04-10 Thread Brice Goglin
Benjamin Herrenschmidt a écrit : But it's not specific to X11; I've applied the patch you posted and the same symptoms occur for pure tty switching as well, the delay has decreased a bit (it's hard to measure, but around a second), but it's still rather annoying to work with. Is it distinguishable

Re: 2.6.12-rc2-mm1

2005-04-06 Thread Brice Goglin
Ingo Molnar a écrit : weird - none of the WARN_ON(1)'s show up. In particular, the sched_clock() ones should have triggered at least once! I've attached a new version of the patch below (please unapply the previous patch), could you try it and send me the log? (It will unconditionally print so

Re: 2.6.12-rc2-mm1

2005-04-05 Thread Brice Goglin
Ingo Molnar a écrit : * Brice Goglin <[EMAIL PROTECTED]> wrote: Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc2/2.6.12-rc2-mm1/ Hi Andrew, printk timing seems broken. It always shows [ 0.00] on my Compaq Evo N600c. could you send th

  1   2   >