Re: [PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs

2018-02-06 Thread Caesar Wang
Kishon, Can you help merge this in your  or next tree?  I'm hoping that we can land this somewhere.:-) Thanks, -Caesar 在 2018年01月11日 10:40, Caesar Wang 写道: Hi Kishon, Since the Shawn isn't available, I take over this series patches for now. As the original bug had tracked on https

[PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs

2018-01-10 Thread Caesar Wang
Hi Kishon, Since the Shawn isn't available, I take over this series patches for now. As the original bug had tracked on https://issuetracker.google.com/71561742. In some cases, the mmc phy power on failed during booting up. The log as below: ... [ 2.375333] rockchip_emmc_phy_power: caldone

[PATCH v3 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-10 Thread Caesar Wang
From: Shawn Lin <shawn@rock-chips.com> It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Tested-by: Ziyuan Xu <xzy...@rock-chips.com> Signed-off-by: Caesar Wang &l

[PATCH v3 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

2018-01-10 Thread Caesar Wang
From: Shawn Lin <shawn@rock-chips.com> Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chromium.org> Signed-off-by: Caesar Wang <w...@rock-chips.com

Re: [PATCH v2 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

2018-01-10 Thread Caesar Wang
在 2018年01月11日 03:36, Doug Anderson 写道: Hi, On Wed, Jan 10, 2018 at 9:46 AM, Brian Norris wrote: */ - timeout = jiffies + msecs_to_jiffies(50); - do { - udelay(1); - - regmap_read(rk_phy->reg_base, -

Re: [PATCH v2 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

2018-01-10 Thread Caesar Wang
the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chromium.org> Tested-by: Caesar Wang <w...@rock-chips.com> Tested-by: Ziyuan Xu <xzy...@rock-chips.com> --- Changes in v

[PATCH v2 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

2018-01-09 Thread Caesar Wang
From: Shawn Lin <shawn@rock-chips.com> Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chromium.org> Signed-off-by: Caesar Wang <w...@rock-chips.com

[PATCH v2 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs

2018-01-09 Thread Caesar Wang
Hi Kishon, Since the Shawn isn't available, I take over this series patches for now. As the original bug had tracked on https://issuetracker.google.com/71561742. In some cases, the mmc phy power on failed during booting up. The log as below: ... [ 2.375333] rockchip_emmc_phy_power: caldone

[PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-09 Thread Caesar Wang
From: Shawn Lin <shawn@rock-chips.com> It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Tested-by: Ziyuan Xu <xzy...@rock-chips.com> Signed-off-by: Caesar Wang &l

Re: [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-04 Thread Caesar Wang
ned-off-by: Shawn Lin <shawn@rock-chips.com> Tested-by: Caesar Wang <w...@rock-chips.com> I had tested on rk3399 chromebook, so feel free to add my tag. -Caesar --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 + 1 file changed, 13 insertions(+), 8 delet

Re: [PATCH 2/5] thermal: rockchip: Support the RV1108 SoC in thermal driver

2017-09-14 Thread Caesar Wang
在 2017年09月15日 10:10, Caesar Wang 写道: Hi Rocky, 在 2017年08月24日 18:27, Rocky Hao 写道: RV1108 SOC has one Temperature Sensor for CPU. Signed-off-by: Rocky Hao <rocky@rock-chips.com> Reviewed-by: Caesar Wang <w...@rock-chips.com> --- drivers/thermal/rockchip_th

Re: [PATCH 2/5] thermal: rockchip: Support the RV1108 SoC in thermal driver

2017-09-14 Thread Caesar Wang
Hi Rocky, 在 2017年08月24日 18:27, Rocky Hao 写道: RV1108 SOC has one Temperature Sensor for CPU. Signed-off-by: Rocky Hao --- drivers/thermal/rockchip_thermal.c | 67 ++ 1 file changed, 67 insertions(+) diff --git

Re: [PATCH 3/5] arm: dts: rockchip: add tsadc node for RV1108 SoC

2017-09-14 Thread Caesar Wang
Rocky, 在 2017年08月24日 18:27, Rocky Hao 写道: Add tsadc needed main information for RV1108 SoC. 75Hz is the max clock rate supported by tsadc module. Signed-off-by: Rocky Hao --- arch/arm/boot/dts/rv1108.dtsi | 29 + 1 file changed, 29

Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RV1108 SoC compatible

2017-09-14 Thread Caesar Wang
Hi Rocky, 在 2017年08月24日 18:27, Rocky Hao 写道: Add a new compatible for thermal founding on RV1108 SoCs. Signed-off-by: Rocky Hao --- Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

2017-08-11 Thread Caesar Wang
在 2017年08月04日 16:06, Rocky Hao 写道: add thermal zone and dynamic CPU power coefficients for rk3328 Signed-off-by: Rocky Hao --- Change in v2: - remove gerrit Change-Id arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 1 file changed,

Re: [PATCH v2 3/5] arm64: dts: rockchip: add tsadc node for rk3328 SoC

2017-08-11 Thread Caesar Wang
在 2017年08月04日 16:06, Rocky Hao 写道: add tsadc needed main information for rk3328 SoC. 5Hz is the max clock rate supported by tsadc module. Signed-off-by: Rocky Hao --- Change in v2: - remove gerrit Change-Id arch/arm64/boot/dts/rockchip/rk3328.dtsi | 20

Re: [PATCH 2/5] thermal: rockchip: Support the RK3328 SOC in thermal driver

2017-08-10 Thread Caesar Wang
在 2017年08月11日 11:02, Zhang Rui 写道: On Tue, 2017-07-25 at 17:09 +0800, Rocky Hao wrote: RK3328 SOC has one Temperature Sensor for CPU. Change-Id: I176c76bae1801d815a513986cfefcb55272c69a8 Signed-off-by: Rocky Hao <rocky@rock-chips.com> Reviewed-by: Caesar Wang <w...@rock-

[PATCH] arm64: dts: rockchip: update dynamic-power-coefficient for rk3399

2017-07-25 Thread Caesar Wang
~443 216 0.8 82 ~438 312 0.8 115 ~430 408 0.8 150 ~455 So the dynamic-power-coefficient average value is about 436. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk339

Re: [PATCH v2 5/5] arm64: dts: rockchip: update the thermal zones for RK3399 SoCs

2017-07-25 Thread Caesar Wang
Hi Heiko, Thanks your comments. 在 2017年07月23日 05:48, Heiko Stuebner 写道: Hi Caesar, Am Montag, 17. Juli 2017, 16:14:31 CEST schrieb Caesar Wang: As RK3399 had used the Power allocator thermal governor by default, enabled this to manage thermals by dynamically allocating and limiting power

Re: [PATCH v2 0/5] arm64: dts: rockchip: support mail and IPA thermal for rk3399

2017-07-19 Thread Caesar Wang
fter. -Caesar 在 2017年07月17日 16:14, Caesar Wang 写道: This series patches supported the mail in devicetree and used the thermal IPA by default. Verified with kernel is based on Linus's master branch and Heiko's v4.14-armsoc-tmp/dts64 branch. ( The Linux version 4.12.0 for now). The most rockchip

Re: [PATCH v2 2/5] dt-bindings: gpu: add a power_model optional properties for MALI

2017-07-17 Thread Caesar Wang
Rob, 在 2017年07月18日 04:07, Rob Herring 写道: On Mon, Jul 17, 2017 at 04:14:28PM +0800, Caesar Wang wrote: This patch adds the MALI's power-model to set the IPA model to be used for power management. What's IPA? India Pale Ale or Intermediate Physical Address? IPA is intelligent Power Allocator

[PATCH v2 1/5] dt-bindings: gpu: add the RK3399 mali for rockchip specifics

2017-07-17 Thread Caesar Wang
RK3399's GPU uses the quad-core Mali-T860, which is the new generation of high-end graphics processors from ARM. This patch added "rockchip,rk3399-mali" for dt-bindings, in order to support IPA of gpu thermal in later. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Cha

[PATCH v2 3/5] arm64: dts: rockchip: add ARM Mali GPU node for RK3399 SoCs

2017-07-17 Thread Caesar Wang
Add Mali GPU device tree node for the RK3399 SoCs, with devfreq opp table. RK3399 and RK3399-OP1 SoCs have a different recommendation table with gpu opp. Also, the ARM's mali driver found on https://developer.arm.com/products/software/mali-drivers/midgard-kernel. Signed-off-by: Caesar Wang &l

[PATCH v2 4/5] arm64: dts: rockchip: enable the GPU for RK3399-GRU

2017-07-17 Thread Caesar Wang
This patch enables the gpu and adds the mali-supply power for RK3399-GRU devices. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/

[PATCH v2 5/5] arm64: dts: rockchip: update the thermal zones for RK3399 SoCs

2017-07-17 Thread Caesar Wang
. The Thermal power allocator governor works optimatly with two passive trip points, for the better performance we will use the trip-point0 with 70 degree above which the governor control starts operating and trip-point1 with 85 degree is the target temperature by controlling. Signed-off-by: Caesar

[PATCH v2 2/5] dt-bindings: gpu: add a power_model optional properties for MALI

2017-07-17 Thread Caesar Wang
This patch adds the MALI's power-model to set the IPA model to be used for power management. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v2: None Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 12 1 file changed, 12 insertions(+) diff

[PATCH v2 0/5] arm64: dts: rockchip: support mail and IPA thermal for rk3399

2017-07-17 Thread Caesar Wang
foo@ will produce warnings when used without reg property. - update the commit to explain the two passive trip points changed. Caesar Wang (5): dt-bindings: gpu: add the RK3399 mali for rockchip specifics dt-bindings: gpu: add a power_model optional properties for MALI arm64: dts: rockchip: a

Re: [PATCH 2/4] arm64: dts: rockchip: add ARM Mali GPU node for RK3399 SoCs

2017-07-12 Thread Caesar Wang
在 2017年07月12日 15:19, Heiko Stuebner 写道: Hi Caesar, Am Mittwoch, 12. Juli 2017, 14:29:28 CEST schrieb Caesar Wang: Add Mali GPU device tree node for the RK3399 SoCs, with devfreq opp table. RK3399 and RK3399-OP1 SoCs have a different recommendation table with gpu opp. As the ARM's mali driver

[PATCH 0/4] arm64: dts: rockchip: support mail and IPA thermal for rk3399

2017-07-12 Thread Caesar Wang
ts to have a look at the actual control. " while true; do grep "" /sys/class/thermal/thermal_zone[0-1]/temp /sys/devices/system/cpu/cpu[0-5]/cpufreq/scaling_cur_freq /sys/devices/platform/ff9a.gpu/devfreq/ff9a.gpu/cur_freq;date;sleep .5; done & " -Caesar Caesar

[PATCH 2/4] arm64: dts: rockchip: add ARM Mali GPU node for RK3399 SoCs

2017-07-12 Thread Caesar Wang
Add Mali GPU device tree node for the RK3399 SoCs, with devfreq opp table. RK3399 and RK3399-OP1 SoCs have a different recommendation table with gpu opp. As the ARM's mali driver found on https://developer.arm.com/products/software/mali-drivers/midgard-kernel. Signed-off-by: Caesar Wang &l

[PATCH 4/4] arm64: dts: rockchip: update the thermal zones for RK3399 SoCs

2017-07-12 Thread Caesar Wang
. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 62 +++- 1 file changed, 29 insertions(+), 33 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 8

[PATCH 1/4] dt-bindings: gpu: add the RK3399 mali for rockchip specifics

2017-07-12 Thread Caesar Wang
RK3399's GPU uses the quad-core Mali-T860, which is the new generation of high-end graphics processors from ARM. This patch added "rockchip,rk3399-mali" for dt-bindings, in order to support IPA of gpu thermal in later. Signed-off-by: Caesar Wang <w...@rock-chips.com> ---

[PATCH 3/4] arm64: dts: rockchip: enable the GPU for RK3399-GRU

2017-07-12 Thread Caesar Wang
This patch enables the gpu and adds the mali-supply power for RK3399-GRU devices. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch

arm64: dts: rockchip: add SdioAudio pd control for rk3399

2017-06-30 Thread Caesar Wang
The SdioAudio power domain includes the i2s/spdif/spi5/sdio. So this patch adds the pd control for rk3399 i2s/spdif/spi5/sdio, in order to save more power consumption. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes note: - As the Jeffy fixes the spi'cs issue recently as f

Re: [PATCH v3 1/3] spi: rockchip: add support for "cs-gpios" dts property

2017-06-16 Thread Caesar Wang
ock-chips.com> Tested-by: Caesar Wang <w...@rock-chips.com> I have fetched these patches to test S2R with my board for chromeos4.4. localhost ~ # cat /sys/kernel/debug/pm_genpd/pm_genpd_summary ... pd_sdioaudioon /devices/platform/ff20.spi

Re: [PATCH] mwifiex: fixes the trivial print

2017-06-14 Thread Caesar Wang
domain rules if (ch->flags & IEEE80211_CHAN_DISABLED) continue; so it should not been an ERROR. WARN looks fine to me. you can add me acked-by in v2. Okay, thanks for explanation and having a look at it. -Caesar Regards, Simon From: Caesar Wang [mailto:w...@r

[PATCH v2] mwifiex: fixes the unexpected be printed log by default

2017-06-14 Thread Caesar Wang
ED) continue; So it should not been an ERROR, use the WARN level to instead it for now. Signed-off-by: Caesar Wang <w...@rock-chips.com> Acked-by: Xinming Hu <h...@marvell.com> --- Changes in v2: - Fixes the commit and title as Kalle and Xinming comments on https://patc

Re: [PATCH] mwifiex: fixes the trivial print

2017-06-13 Thread Caesar Wang
在 2017年06月13日 15:04, Kalle Valo 写道: Caesar Wang <w...@rock-chips.com> writes: Kalle, 在 2017年06月13日 14:28, Kalle Valo 写道: Caesar Wang <w...@rock-chips.com> writes: We have always met the unused log be printed as following. ... [23193.523182] mwifiex_pcie :01:00.0: mwi

Re: [PATCH] mwifiex: fixes the trivial print

2017-06-13 Thread Caesar Wang
Kalle, 在 2017年06月13日 14:28, Kalle Valo 写道: Caesar Wang <w...@rock-chips.com> writes: We have always met the unused log be printed as following. ... [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp: cannot find cfp by band 2& channel=13 freq=0 [23378.633684] mwifiex_pc

[PATCH] mwifiex: fixes the trivial print

2017-06-09 Thread Caesar Wang
7 MHz [8] (30.0 dBm) * 2452 MHz [9] (30.0 dBm) * 2457 MHz [10] (30.0 dBm) * 2462 MHz [11] (30.0 dBm) * 2467 MHz [12] (disabled) * 2472 MHz [13] (disabled) * 2484 MHz [14] (disabled) Signed-off-by: Caesar Wang <w...@rock-chips.com> --- drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- 1 f

[PATCH] drm/rockchip: gem: add the lacks lock and trivial changes

2017-05-30 Thread Caesar Wang
As the allocation and free buffer that need to add mutex lock for drm mm, but it lacks the locking on error path in rockchip_gem_iommu_map(). Also, the trivial changes like The comment should be placed in the kerneldoc and unused blank line. Signed-off-by: Caesar Wang <w...@rock-chips.

Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1

2017-04-24 Thread Caesar Wang
在 2017年04月24日 16:26, Heiko Stübner 写道: Hi Caesar, Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang: Update the cpu opp table for rk3399 op1. Ideally this should contain something about the "why". Are these new voltage settings safer to operate under? The before

[PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1

2017-04-24 Thread Caesar Wang
Update the cpu opp table for rk3399 op1. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi b/arch/arm64/bo

Re: iommu/rockchip: Fix bugs and enable on ARM64

2017-03-07 Thread Caesar Wang
Shunqian, something is depending on these patches, can you resend these patches to solve the compile errors? -Caesar 在 2016年07月16日 00:16, Joerg Roedel 写道: On Fri, Jul 15, 2016 at 05:32:02PM +0200, Matthias Brugger wrote: The drm rockchip patches are dependent on iommu/rockchip patches, can

[PATCH] thermal: rockchip: fixes the conversion table

2017-01-04 Thread Caesar Wang
("thermal: rockchip: optimize the conversion table") Reported-by: ayaka <ay...@soulik.info> Signed-off-by: Caesar Wang <w...@rock-chips.com> --- drivers/thermal/rockchip_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/rockchip_therma

Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal

2017-01-02 Thread Caesar Wang
在 2017年01月03日 07:57, Randy Li 写道: On 01/02/2017 09:16 PM, Caesar Wang wrote: 在 2016年12月31日 00:11, ayaka 写道: BTW, Caesar have you ever met this at RK3288 at booting time? [8.430582] thermal thermal_zone1: critical temperature reached(125 C),shutting down [8.439038] thermal

Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal

2017-01-02 Thread Caesar Wang
for your linux kernel? http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380446.html -Caesar On 12/12/2016 07:05 PM, Caesar Wang wrote: There are five patches posted for upstream. 89267b5 thermal: rockchip: improve conversion error messages a0b5649 thermal: rockchip: don't

Re: [PATCH] spi: rockchip: support "sleep" pin configuration

2016-12-17 Thread Caesar Wang
在 2016年12月17日 08:59, Brian Norris 写道: In the pattern of many other devices, support a system-sleep pin configuration. Signed-off-by: Brian Norris <briannor...@chromium.org> Tested-by: Caesar Wang <w...@rock-chips.com> --- Documentation/devicetree/bindings/spi/spi-rock

[PATCH v3 2/2] drm/panel: simple: Add support BOE nv101wxmn51

2016-12-13 Thread Caesar Wang
Detailed mode2: Clock 57.500 MHz, 216 mm x 135 mm 1280 1328 1360 1440 hborder 0 800 803 808 832 vborder 0 +hsync -vsync Add the both edid to support more modes for BOE nv101wxmn51. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes

[PATCH v3 1/2] dt-bindings: display: Add BOE nv101wxmn51 panel binding

2016-12-13 Thread Caesar Wang
The BOE 10.1" NV101WXMN51 panel is an WXGA TFT LCD panel. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v3: None Changes in v2: None .../devicetree/bindings/display/panel/boe,nv101wxmn51.txt | 7 +++ 1 file changed, 7 insertions(+) create

Re: [PATCH v2 2/2] drm/panel: simple: Add support BOE nv101wxmn51

2016-12-13 Thread Caesar Wang
在 2016年12月13日 04:22, Stéphane Marchesin 写道: On Wed, Dec 7, 2016 at 11:26 PM, Caesar Wang <w...@rock-chips.com> wrote: 10.1WXGA is a color active matrix TFT LCD module using amorphous silicon TFT's as an active switching devices. It can be supported by the simple-panel driver. Read the

[PATCH v4 3/5] thermal: rockchip: fixes invalid temperature case

2016-12-12 Thread Caesar Wang
-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v4: None Changes in v3: - fix trivial thing for error message nd return value. Changes in v2: - As Brian commnets that restructure this to pass error codes back to the upper layers. - Improve the commit message. Changes in v1

[PATCH v4 2/5] thermal: rockchip: don't pass table structs by value

2016-12-12 Thread Caesar Wang
From: Brian Norris <briannor...@chromium.org> This driver passes struct chip_tsadc_table by value throughout; this is inefficient, and AFAICT, there is no reason for it. Let's pass pointers instead. Signed-off-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Caesar Wan

[PATCH v4 1/5] thermal: rockchip: improve conversion error messages

2016-12-12 Thread Caesar Wang
operly. While we're at it, fix the grammar too. Signed-off-by: Brian Norris <briannor...@chromium.org> Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v4: - As Eduardo and Brian commnets on https://patchwork.kernel.org/patch/9449301 Changes in v3: None Changes i

[PATCH v4 0/5] thermal: fixes the rockchip thermal

2016-12-12 Thread Caesar Wang
://patchwork.kernel.org/patch/9437687 Brian Norris (2): thermal: rockchip: improve conversion error messages thermal: rockchip: don't pass table structs by value Caesar Wang (3): thermal: rockchip: fixes invalid temperature case thermal: rockchip: optimize the conversion table thermal: rockchip: handle

[PATCH v4 5/5] thermal: rockchip: handle set_trips without the trip points

2016-12-12 Thread Caesar Wang
In some cases, some sensors didn't need the trip points, the set_trips will pass {-INT_MAX, INT_MAX} to trigger tsadc alarm in the end, ignore this case and disable the high temperature interrupt. Signed-off-by: Caesar Wang <w...@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chr

[PATCH v4 4/5] thermal: rockchip: optimize the conversion table

2016-12-12 Thread Caesar Wang
* $echo 68000 > trip_point_0_temp That will return the max analogic value indicates the invalid before posting this patch. So, this patch will optimize the conversion table to support the other cases. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v4: - Print a be

Re: [PATCH v3 4/5] thermal: rockchip: optimize the conversion table

2016-12-12 Thread Caesar Wang
在 2016年11月30日 14:29, Eduardo Valentin 写道: Hey, On Mon, Nov 28, 2016 at 07:12:03PM +0800, Caesar Wang wrote: + num = abs(table->id[mid].code - table->id[mid + 1].code); + num *= temp - table->id[mid].temp; + denom = table->id[mid + 1].temp - table->id[mid

Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error messages

2016-12-12 Thread Caesar Wang
在 2016年11月30日 13:04, Eduardo Valentin 写道: Hey, On Mon, Nov 28, 2016 at 09:47:29PM -0800, Brian Norris wrote: Hi, + __func__, table.mode); Given that we are improving messages, would it be more informative to say that you have an invalid table mode? I considered the

Re: [PATCH v3 3/5] thermal: rockchip: fixes invalid temperature case

2016-12-12 Thread Caesar Wang
Hi 在 2016年11月30日 14:26, Eduardo Valentin 写道: Hello, On Tue, Nov 29, 2016 at 09:59:28PM -0800, Brian Norris wrote: On Tue, Nov 29, 2016 at 09:02:42PM -0800, Eduardo Valentin wrote: On Tue, Nov 29, 2016 at 01:57:45PM -0800, Brian Norris wrote: I was thinking while reviewing that the binary

[PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr

2016-12-09 Thread Caesar Wang
Look likes, the BOE panel FW didn't ack the DPCD600 signal from the host device, that will cause the panel hang on the startup display. The root cause we use the fast link mode during enter and exit the psr, this issue is gone if switching the fast link to main link mode. Signed-off-by: Caesar

[PATCH v2 1/2] dt-bindings: display: Add BOE nv101wxmn51 panel binding

2016-12-07 Thread Caesar Wang
The BOE 10.1" NV101WXMN51 panel is an WXGA TFT LCD panel. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v2: None .../devicetree/bindings/display/panel/boe,nv101wxmn51.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 Documentation

[PATCH v2 2/2] drm/panel: simple: Add support BOE nv101wxmn51

2016-12-07 Thread Caesar Wang
.vsync_start = 803 .vsync_end = 808 .vtotal = 832 Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v2: - fix the vsync_start and vsync_end from the edid. - change the commit. drivers/gpu/drm/panel/panel-simple.

[RESEND PATCH 2/2] drm/panel: simple: Add support BOE nv101wxmn51

2016-12-07 Thread Caesar Wang
10.1WXGA is a color active matrix TFT LCD module using amorphous silicon TFT's as an active switching devices. It can be supported by the simple-panel driver. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- drivers/gpu/drm/panel/panel-simple.c | 31 +++

[RESEND PATCH 1/2] dt-bindings: display: Add BOE nv101wxmn51 panel binding

2016-12-07 Thread Caesar Wang
The BOE 10.1" NV101WXMN51 panel is an WXGA TFT LCD panel. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- .../devicetree/bindings/display/panel/boe,nv101wxmn51.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/displa

Re: [PATCH] drm/panel: simple: Add support BOE nv101wxmn51

2016-12-07 Thread Caesar Wang
Resend the missing document. Sorry for the noise. 在 2016年12月08日 13:26, Caesar Wang 写道: 10.1WXGA is a color active matrix TFT LCD module using amorphous silicon TFT's as an active switching devices. It can be supported by the simple-panel driver. Signed-off-by: Caesar Wang <w...@rock-chips.

[PATCH] drm/panel: simple: Add support BOE nv101wxmn51

2016-12-07 Thread Caesar Wang
10.1WXGA is a color active matrix TFT LCD module using amorphous silicon TFT's as an active switching devices. It can be supported by the simple-panel driver. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- drivers/gpu/drm/panel/panel-simple.c | 31 +++

[PATCH v3 2/5] thermal: rockchip: don't pass table structs by value

2016-11-28 Thread Caesar Wang
From: Brian Norris <briannor...@chromium.org> This driver passes struct chip_tsadc_table by value throughout; this is inefficient, and AFAICT, there is no reason for it. Let's pass pointers instead. Signed-off-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Caesar Wan

[PATCH v3 5/5] thermal: rockchip: handle set_trips without the trip points

2016-11-28 Thread Caesar Wang
In some cases, some sensors didn't need the trip points, the set_trips will pass {-INT_MAX, INT_MAX} to trigger tsadc alarm in the end, ignore this case and disable the high temperature interrupt. Signed-off-by: Caesar Wang <w...@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chr

[PATCH v3 4/5] thermal: rockchip: optimize the conversion table

2016-11-28 Thread Caesar Wang
* $echo 68000 > trip_point_0_temp That will return the max analogic value indicates the invalid before posting this patch. So, this patch will optimize the conversion table to support the other cases. Signed-off-by: Caesar Wang <w...@rock-chips.com> Reviewed-by: Brian Norris <briannor...@

[PATCH v3 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-28 Thread Caesar Wang
-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v3: - fix trivial thing for error message nd return value. Changes in v2: - As Brian commnets that restructure this to pass error codes back to the upper layers. - Improve the commit message. Changes in v1: None drivers/t

[PATCH v3 1/5] thermal: rockchip: improve conversion error messages

2016-11-28 Thread Caesar Wang
operly. While we're at it, fix the grammar too. Signed-off-by: Brian Norris <briannor...@chromium.org> Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v3: None Changes in v2: None Changes in v1: - The original Brian posted on https://patchwork.kernel.org/patch/94

[PATCH v3 0/5] thermal: fixes the rockchip thermal

2016-11-28 Thread Caesar Wang
: improve conversion error messages thermal: rockchip: don't pass table structs by value Caesar Wang (3): thermal: rockchip: fixes invalid temperature case thermal: rockchip: optimize the conversion table thermal: rockchip: handle set_trips without the trip points drivers/thermal

Re: [PATCH v2 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-23 Thread Caesar Wang
在 2016年11月24日 02:35, Brian Norris 写道: Hi Caesar, On Wed, Nov 23, 2016 at 10:29:32PM +0800, Caesar Wang wrote: The temp_to_code function will return 0 when we set the temperature to a invalid value (e.g. 61C, 62C, 63C), that's unpractical. This patch will prevent this case happening

[PATCH v2 0/5] thermal: fixes the rockchip thermal

2016-11-23 Thread Caesar Wang
://patchwork.kernel.org/patch/9437687 Brian Norris (2): thermal: rockchip: improve conversion error messages thermal: rockchip: don't pass table structs by value Caesar Wang (3): thermal: rockchip: fixes invalid temperature case thermal: rockchip: optimize the conversion table thermal: rockchip: handle

[PATCH v2 5/5] thermal: rockchip: handle set_trips without the trip points

2016-11-23 Thread Caesar Wang
In some cases, some sensors didn't need the trip points, the set_trips will return {-INT_MAX, INT_MAX} to trigger thermal alarm. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v2: - Fixes something as Brian comments on https://patchwork.kernel.org/patch/9440989. Changes

[PATCH v2 2/5] thermal: rockchip: don't pass table structs by value

2016-11-23 Thread Caesar Wang
From: Brian Norris <briannor...@chromium.org> This driver passes struct chip_tsadc_table by value throughout; this is inefficient, and AFAICT, there is no reason for it. Let's pass pointers instead. Signed-off-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Caesar Wan

[PATCH v2 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-23 Thread Caesar Wang
-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v2: - As Brian commnets that restructure this to pass error codes back to the upper layers. - Improve the commit message. Changes in v1: None drivers/thermal/rockchip_thermal.c | 41 ++ 1 file c

[PATCH v2 4/5] thermal: rockchip: optimize the conversion table

2016-11-23 Thread Caesar Wang
* $echo 68000 > trip_point_0_temp That will return the max analogic value indicates the invalid before posting this patch. So, this patch will optimize the conversion table to support the other cases. Signed-off-by: Caesar Wang <w...@rock-chips.com> Reviewed-by: Brian Norris <briannor...@

[PATCH v2 1/5] thermal: rockchip: improve conversion error messages

2016-11-23 Thread Caesar Wang
operly. While we're at it, fix the grammar too. Signed-off-by: Brian Norris <briannor...@chromium.org> Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes in v2: None Changes in v1: - The original Brian posted on https://patchwork.kernel.org/patch/9437686 Note: it'd prob

Re: [PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Caesar Wang
在 2016年11月23日 10:33, Brian Norris 写道: On Wed, Nov 23, 2016 at 10:06:15AM +0800, Caesar Wang wrote: 在 2016年11月23日 05:52, Brian Norris 写道: On Tue, Nov 22, 2016 at 12:57:37PM -0800, Brian Norris wrote: + if (temp < table->id[low].temp || temp > table->id[high].temp)

Re: [PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Caesar Wang
在 2016年11月23日 05:52, Brian Norris 写道: On Tue, Nov 22, 2016 at 12:57:37PM -0800, Brian Norris wrote: On Tue, Nov 22, 2016 at 08:34:46PM +0800, Caesar Wang wrote: The temp_to_code function will return 0 when we set the trip points value or valid temperature. I'm not quite sure what you mean

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-22 Thread Caesar Wang
在 2016年11月22日 15:57, Zhang Rui 写道: On Tue, 2016-11-22 at 09:51 +0800, Caesar Wang wrote: 在 2016年11月19日 11:31, Caesar Wang 写道: Brian, 在 2016年11月19日 07:52, Brian Norris 写道: These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid

[PATCH 2/5] thermal: rockchip: don't pass table structs by value

2016-11-22 Thread Caesar Wang
From: Brian Norris <briannor...@chromium.org> This driver passes struct chip_tsadc_table by value throughout; this is inefficient, and AFAICT, there is no reason for it. Let's pass pointers instead. Signed-off-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Caesar Wan

[PATCH 0/5] thermal: rockchip: optimization to improve the driver

2016-11-22 Thread Caesar Wang
the rockchip thermal driver. Brian Norris (2): thermal: rockchip: improve conversion error messages thermal: rockchip: don't pass table structs by value Caesar Wang (3): thermal: rockchip: fixes invalid temperature case thermal: rockchip: optimize the conversion table thermal: rockchip: handle

[PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Caesar Wang
The temp_to_code function will return 0 when we set the trip points value or valid temperature. This patch will prevent this case happening. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- drivers/thermal/rockchip_thermal.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[PATCH 5/5] thermal: rockchip: handle the set_trips without the trip points.

2016-11-22 Thread Caesar Wang
In some cases, some sensors didn't need the trip points, the set_trips will return {-INT_MAX, INT_MAX} to trigger thermal alarm. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- drivers/thermal/rockchip_thermal.c | 13 + 1 file changed, 13 insertions(+) diff --git a/d

[PATCH 4/5] thermal: rockchip: optimize the conversion table

2016-11-22 Thread Caesar Wang
age before posting this patch. Signed-off-by: Caesar Wang <w...@rock-chips.com> --- drivers/thermal/rockchip_thermal.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index 535f1fa..f4d4b

[PATCH 1/5] thermal: rockchip: improve conversion error messages

2016-11-22 Thread Caesar Wang
operly. While we're at it, fix the grammar too. Signed-off-by: Brian Norris <briannor...@chromium.org> Signed-off-by: Caesar Wang <w...@rock-chips.com> --- Changes: - The original Brian posted on https://patchwork.kernel.org/patch/9437685 Brain said: "Note: it'd probably be e

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-21 Thread Caesar Wang
在 2016年11月22日 10:15, Brian Norris 写道: On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote: CHECK: Alignment should match open parenthesis #428: FILE: drivers/thermal/rockchip_thermal.c:428: +pr_err("%s: invalid temperature, temp=%d error=%d\n", +__func__, t

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-21 Thread Caesar Wang
在 2016年11月19日 11:31, Caesar Wang 写道: Brian, 在 2016年11月19日 07:52, Brian Norris 写道: These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when

Re: [PATCH v2 3/9] arm64: dts: rockchip: add VOP and VOP iommu node for rk3399

2016-11-20 Thread Caesar Wang
在 2016年11月15日 00:05, Heiko Stuebner 写道: Am Mittwoch, 9. November 2016, 21:21:55 CET schrieb Caesar Wang: From: Mark Yao <mark@rock-chips.com> Add the core display-subsystem node and the two display controllers available on the rk3399. Signed-off-by: Mark Yao <mark@rock-

[PATCH v2.1 7/9] arm64: dts: rockchip: add pd_edp node for rk3399

2016-11-20 Thread Caesar Wang
From: zhangqing <zhangq...@rock-chips.com> This patch adds the below pd_edp information for rk3399. 1. add pd_edp node for RK3399 SoC 2. add the pd support for edp Signed-off-by: Elaine Zhang <zhangq...@rock-chips.com> Signed-off-by: Caesar Wang <w...@rock-chips.com> Reviewed

Re: [PATCH 3/3] thermal: rockchip: don't pass table structs by value

2016-11-18 Thread Caesar Wang
在 2016年11月19日 07:52, Brian Norris 写道: This driver passes struct chip_tsadc_table by value throughout; this is inefficient, and AFAICT, there is no reason for it. Let's pass pointers instead. Signed-off-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Caesar Wang <w...@rock-

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-18 Thread Caesar Wang
在 2016年11月19日 11:31, Caesar Wang 写道: Brian, 在 2016年11月19日 07:52, Brian Norris 写道: These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-18 Thread Caesar Wang
Brian, 在 2016年11月19日 07:52, Brian Norris 写道: These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when we can't handle a conversion

Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-18 Thread Caesar Wang
nor...@chromium.org> Tested-by: Caesar Wang <w...@rock-chips.com> [8.111296] thermal thermal_zone4: power_allocator: sustainable_power will be estimated [8.119420] thermal_zone_get_temp:537 the ret=-19, no such device, look like the A/D value had no ready yet. .. Anyway, this pat

Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399

2016-11-14 Thread Caesar Wang
On 2016年11月12日 12:22, Shawn Lin wrote: On 2016/11/9 21:21, Caesar Wang wrote: From: Ziyuan Xu <xzy...@rock-chips.com> Control power domain for eMMC via genpd to reduce power consumption. Signed-off-by: Elaine Zhang <zhangq...@rock-chips.com> Signed-off-by: Ziyuan Xu <xzy...

Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399

2016-11-14 Thread Caesar Wang
On 2016年11月14日 22:45, Heiko Stuebner wrote: Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang: From: Ziyuan Xu <xzy...@rock-chips.com> Control power domain for eMMC via genpd to reduce power consumption. Signed-off-by: Elaine Zhang <zhangq...@rock-chips.com>

[PATCH] arm64: dts: rockchip: add gmac needed clk for rk3399 pd

2016-11-13 Thread Caesar Wang
OC had enabled always) Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Signed-off-by: Caesar Wang <w...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/a

  1   2   3   4   5   6   7   8   9   10   >