Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-22 Thread Cai Liu
Hello Minchan 2014/1/23 Minchan Kim : > Hello Cai, > > On Thu, Jan 23, 2014 at 09:38:41AM +0800, Cai Liu wrote: >> Hello Dan >> >> 2014/1/22 Dan Streetman : >> > On Wed, Jan 22, 2014 at 7:16 AM, Cai Liu wrote: >> >> Hello Minchan >> >>

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-22 Thread Cai Liu
Hello Dan 2014/1/22 Dan Streetman : > On Wed, Jan 22, 2014 at 7:16 AM, Cai Liu wrote: >> Hello Minchan >> >> >> 2014/1/22 Minchan Kim >>> >>> Hello Cai, >>> >>> On Tue, Jan 21, 2014 at 09:52:25PM +0800, Cai Liu wrote: >&g

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-22 Thread Cai Liu
Hello Minchan 2014/1/22 Minchan Kim > > Hello Cai, > > On Tue, Jan 21, 2014 at 09:52:25PM +0800, Cai Liu wrote: > > Hello Minchan > > > > 2014/1/21 Minchan Kim : > > > Hello, > > > > > > On Tue, Jan 21, 2014 at 02:35:07PM +0800, Cai

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-22 Thread Cai Liu
Hello Minchan 2014/1/22 Minchan Kim minc...@kernel.org Hello Cai, On Tue, Jan 21, 2014 at 09:52:25PM +0800, Cai Liu wrote: Hello Minchan 2014/1/21 Minchan Kim minc...@kernel.org: Hello, On Tue, Jan 21, 2014 at 02:35:07PM +0800, Cai Liu wrote: 2014/1/21 Minchan Kim minc

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-22 Thread Cai Liu
Hello Dan 2014/1/22 Dan Streetman ddstr...@ieee.org: On Wed, Jan 22, 2014 at 7:16 AM, Cai Liu liucai@gmail.com wrote: Hello Minchan 2014/1/22 Minchan Kim minc...@kernel.org Hello Cai, On Tue, Jan 21, 2014 at 09:52:25PM +0800, Cai Liu wrote: Hello Minchan 2014/1/21 Minchan Kim

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-22 Thread Cai Liu
Hello Minchan 2014/1/23 Minchan Kim minc...@kernel.org: Hello Cai, On Thu, Jan 23, 2014 at 09:38:41AM +0800, Cai Liu wrote: Hello Dan 2014/1/22 Dan Streetman ddstr...@ieee.org: On Wed, Jan 22, 2014 at 7:16 AM, Cai Liu liucai@gmail.com wrote: Hello Minchan 2014/1/22 Minchan Kim

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-21 Thread Cai Liu
Hello Minchan 2014/1/21 Minchan Kim : > Hello, > > On Tue, Jan 21, 2014 at 02:35:07PM +0800, Cai Liu wrote: >> 2014/1/21 Minchan Kim : >> > Please check your MUA and don't break thread. >> > >> > On Tue, Jan 21, 2014 at 11:07:42AM +0800, C

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-21 Thread Cai Liu
Hello Minchan 2014/1/21 Minchan Kim minc...@kernel.org: Hello, On Tue, Jan 21, 2014 at 02:35:07PM +0800, Cai Liu wrote: 2014/1/21 Minchan Kim minc...@kernel.org: Please check your MUA and don't break thread. On Tue, Jan 21, 2014 at 11:07:42AM +0800, Cai Liu wrote: Thanks for your

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-20 Thread Cai Liu
2014/1/21 Minchan Kim : > Please check your MUA and don't break thread. > > On Tue, Jan 21, 2014 at 11:07:42AM +0800, Cai Liu wrote: >> Thanks for your review. >> >> 2014/1/21 Minchan Kim : >> > Hello Cai, >> > >> > On Mon, Jan 20, 2014 at 03

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-20 Thread Cai Liu
Thanks for your review. 2014/1/21 Minchan Kim : > Hello Cai, > > On Mon, Jan 20, 2014 at 03:50:18PM +0800, Cai Liu wrote: >> zswap can support multiple swapfiles. So we need to check >> all zbud pool pages in zswap. >> >> Version 2: >> * add *total_zbud

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-20 Thread Cai Liu
Thanks for your review. 2014/1/21 Minchan Kim minc...@kernel.org: Hello Cai, On Mon, Jan 20, 2014 at 03:50:18PM +0800, Cai Liu wrote: zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. Version 2: * add *total_zbud_pages* in zbud to record all

Re: [PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-20 Thread Cai Liu
2014/1/21 Minchan Kim minc...@kernel.org: Please check your MUA and don't break thread. On Tue, Jan 21, 2014 at 11:07:42AM +0800, Cai Liu wrote: Thanks for your review. 2014/1/21 Minchan Kim minc...@kernel.org: Hello Cai, On Mon, Jan 20, 2014 at 03:50:18PM +0800, Cai Liu wrote: zswap

[PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-19 Thread Cai Liu
zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. Version 2: * add *total_zbud_pages* in zbud to record all the pages in pools * move the updating of pool pages statistics to alloc_zbud_page/free_zbud_page to hide the details Signed-off-by: Cai Liu

[PATCH v2] mm/zswap: Check all pool pages instead of one pool pages

2014-01-19 Thread Cai Liu
zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. Version 2: * add *total_zbud_pages* in zbud to record all the pages in pools * move the updating of pool pages statistics to alloc_zbud_page/free_zbud_page to hide the details Signed-off-by: Cai Liu

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
Hello, Kim 2014/1/14 Minchan Kim : > Hello Bob, > > On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: >> >> On 01/14/2014 07:35 AM, Minchan Kim wrote: >> > Hello, >> > >> > On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: >&g

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
14 07:35 AM, Minchan Kim wrote: >>>>> Hello, >>>>> >>>>> On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: >>>>>> zswap can support multiple swapfiles. So we need to check >>>>>> all zbud pool pages in zswap.

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
:43:07PM +0800, Cai Liu wrote: zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. True but this patch is rather costly that we should iterate zswap_tree[MAX_SWAPFILES] to check it. SIGH. How about defining zswap_tress as linked list instead of static array

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
Hello, Kim 2014/1/14 Minchan Kim minc...@kernel.org: Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: zswap can support multiple swapfiles. So we need

[PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-10 Thread Cai Liu
zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. Signed-off-by: Cai Liu --- mm/zswap.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index d93afa6..2438344 100644 --- a/mm/zswap.c +++ b/mm

[PATCH] mm/zswap: correct some comments

2014-01-10 Thread Cai Liu
zswap uses zbud now. So change comments "zsmalloc" to "zbud". Signed-off-by: Cai Liu --- mm/zswap.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 5a63f78..d93afa6 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -165,7 +

[PATCH] mm/zbud: correct some comments

2014-01-10 Thread Cai Liu
zswap uses zbud now. So change zsmalloc to zbud. Signed-off-by: Cai Liu --- mm/zswap.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 5a63f78..d93afa6 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -165,7 +165,7 @@ static void

[PATCH] mm/zbud: correct some comments

2014-01-10 Thread Cai Liu
zswap uses zbud now. So change zsmalloc to zbud. Signed-off-by: Cai Liu cai@samsung.com --- mm/zswap.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 5a63f78..d93afa6 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -165,7 +165,7 @@ static

[PATCH] mm/zswap: correct some comments

2014-01-10 Thread Cai Liu
zswap uses zbud now. So change comments zsmalloc to zbud. Signed-off-by: Cai Liu cai@samsung.com --- mm/zswap.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 5a63f78..d93afa6 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -165,7 +165,7

[PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-10 Thread Cai Liu
zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. Signed-off-by: Cai Liu cai@samsung.com --- mm/zswap.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index d93afa6..2438344 100644