Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-02-27 Thread Cameron Gutman
On 2/24/21 11:32 PM, Chris Ye wrote: > Add "Share" button input capability and input event mapping for > Microsoft Xbox One controller. > Fixed Microsoft Xbox One controller share button not working under USB > connection. > > Signed-off-by: Chris Ye > --- > drivers/input/joystick/xpad.c | 9 +++

Re: [PATCH] Input: Add "Share" button to Microsoft Xbox One controller.

2021-02-27 Thread Cameron Gutman
On 2/25/21 12:26 AM, Dmitry Torokhov wrote: > On Wed, Feb 24, 2021 at 08:44:37PM -0800, Chris Ye wrote: >> Hi Dmitry, >> The latest Xbox One X series has this button, I can add a new >> XTYPE_XBOXONE_X and only apply the change to the new type. > > Sounds good to me. Cameron, what do you think? >

Re: [PATCH] Input: xpad - add support for Hyperkin Duke Xbox One gamepad

2018-11-27 Thread Cameron Gutman
On 11/27/2018 07:28 PM, Cameron Gutman wrote: > Originally submitted by Shelby Jueden (GitHub: AkBKukU) to paroj/xpad: > https://github.com/paroj/xpad/pull/97 > > Minor change to the location of the new entries done by me. > > Cc: Shelby Jueden > Cc: sta...@vger.kerne

[PATCH] Input: xpad - add support for Hyperkin Duke Xbox One gamepad

2018-11-27 Thread Cameron Gutman
Originally submitted by Shelby Jueden (GitHub: AkBKukU) to paroj/xpad: https://github.com/paroj/xpad/pull/97 Minor change to the location of the new entries done by me. Cc: Shelby Jueden Cc: sta...@vger.kernel.org Signed-off-by: Cameron Gutman --- drivers/input/joystick/xpad.c | 2 ++ 1 file

[PATCH] Input: xpad - quirk all PDP Xbox One gamepads

2018-11-27 Thread Cameron Gutman
/xpad/pull/109 [4]: https://github.com/paroj/xpad/pull/112 [5]: https://github.com/paroj/xpad/pull/115 [6]: https://github.com/paroj/xpad/pull/116 Fixes: e5c9c6a885fa ("Input: xpad - add support for PDP Xbox One controllers") Cc: sta...@vger.kernel.org Signed-off-by: Cameron Gutman --- Dmit

Re: [PATCH v2 1/3] HID: add driver for Valve Steam Controller

2018-02-20 Thread Cameron Gutman
On 02/20/2018 11:33 AM, Rodrigo Rivas Costa wrote: > +static void steam_work_connect_cb(struct work_struct *work) > +{ > + struct steam_device *steam = container_of(work, struct steam_device, > + work_connect); > + unsigned long flags; > +

Re: usb/joystick: warnings in xpad_start_input and xpad_try_sending_next_out_packet

2017-09-12 Thread Cameron Gutman
On 09/12/2017 08:36 AM, Andrey Konovalov wrote: > On Tue, Sep 12, 2017 at 5:42 AM, Cameron Gutman wrote: >> On 09/11/2017 05:26 AM, Andrey Konovalov wrote: >>> Hi! >>> >>> I've got the following crashes while fuzzing the

[PATCH] Input: xpad - validate USB endpoint type during probe

2017-09-12 Thread Cameron Gutman
depend on endpoint order Cc: Signed-off-by: Cameron Gutman --- To be able to hit any of the LTS kernels, we'll need to also cherry pick c01b5e7464f0 ("Input: xpad - don't depend on endpoint order"). In hindsight, this commit also addresses a malicious USB device case, since a d

Re: usb/joystick: warnings in xpad_start_input and xpad_try_sending_next_out_packet

2017-09-11 Thread Cameron Gutman
On 09/11/2017 05:26 AM, Andrey Konovalov wrote: > Hi! > > I've got the following crashes while fuzzing the kernel with syzkaller. > > On commit 81a84ad3cb5711cec79f4dd53a4ce026b092c432 (Sep 3). > > usb 1-1: BOGUS urb xfer, pipe 1 != type 3 > WARNING: CPU: 1 PID: 2574 at drivers/usb/core/urb.c:44

[PATCH RESEND] Input: xpad - fix PowerA init quirk for some gamepad models

2017-08-08 Thread Cameron Gutman
.com/paroj/xpad/issues/48#issuecomment-313904867 Reported-by: Kyle Beauchamp Tested-by: Kyle Beauchamp Fixes: 81093c9848a7 ("Input: xpad - support some quirky Xbox One pads") Cc: sta...@vger.kernel.org # v4.12 Signed-off-by: Cameron Gutman --- Forgot to CC LKML last time, resending

Re: [PATCH v4] Input: psxpad-spi - Add PSX (Play Station 1/2) pad SPI driver

2017-04-28 Thread Cameron Gutman
On 04/27/2017 07:31 PM, Tomohiro Yoshidomi wrote: > PSX pads can be connected directly to the SPI bus. > > Signed-off-by: Tomohiro Yoshidomi > --- > drivers/input/joystick/Kconfig | 17 ++ > drivers/input/joystick/Makefile | 1 + > drivers/input/joystick/psxpad-spi.c | 564 > +++

[PATCH v2 2/2] Input: xpad - add support for Razer Wildcat gamepad

2017-04-08 Thread Cameron Gutman
Cc: sta...@vger.kernel.org Signed-off-by: Cameron Gutman --- v2: - No changes drivers/input/joystick/xpad.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index efb798a..5c3d249 100644 --- a/drivers/input/joystick/xpad.c +++ b

[PATCH v2 1/2] Input: xpad - support some quirky Xbox One pads

2017-04-08 Thread Cameron Gutman
m/ValveSoftware/steamlink-sdk/blob/master/kernel/drivers/input/joystick/xpad.c [1]: https://github.com/360Controller/360Controller Signed-off-by: Cameron Gutman --- v2: - Fixed up the commit message which had some lines incorrectly copied from the previous submission. - Added more details as the

[PATCH v2 0/2] Support additional Xbox One pads

2017-04-08 Thread Cameron Gutman
nels. v2 changes: I've given the commit message for patch 1 some much needed TLC, as the old one was poorly worded and did not contain many details about the change. Cameron Gutman (2): Input: xpad - support some quirky Xbox One pads Input: xpad - add support for Razer Wildcat

[PATCH 1/2] Input: xpad - support some quirky Xbox One pads

2017-03-25 Thread Cameron Gutman
k properly. [0]: https://github.com/ValveSoftware/steamlink-sdk/blob/master/kernel/drivers/input/joystick/xpad.c [1]: https://github.com/360Controller/360Controller Signed-off-by: Cameron Gutman --- drivers/input/joystick/xpad.c | 114 +- 1 file changed,

[PATCH 0/2] Support additional Xbox One pads

2017-03-25 Thread Cameron Gutman
eedback on the last series. Patch 2 is a trivial new device ID addition that I've tagged for stable. This one is not purely cosmetic because we won't currently bind to any Xbox One pads with Razer's VID without it. Cameron Gutman (2): Input: xpad - support some quirky Xbox One

[PATCH 2/2] Input: xpad - add support for Razer Wildcat gamepad

2017-03-25 Thread Cameron Gutman
Cc: sta...@vger.kernel.org Signed-off-by: Cameron Gutman --- drivers/input/joystick/xpad.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index efb798a..5c3d249 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input

Re: Synaptics RMI4 touchpad regression in 4.11-rc1

2017-03-13 Thread Cameron Gutman
wrote: >>>> Lo! On 12.03.2017 02:55, Cameron Gutman wrote: >>>>> Beginning in 4.11-rc1, it looks like RMI4 is binding to my XPS 13 9343's >>>>> Synaptics touchpad and dropping some errors into dmesg. Here are the >>>>> messages that see

Re: Synaptics RMI4 touchpad regression in 4.11-rc1

2017-03-11 Thread Cameron Gutman
On 03/11/2017 05:55 PM, Cameron Gutman wrote: > > The affected machine is an XPS 13 9443 running Fedora 25 with 4.11-rc1 > and libinput 1.6.3-3.fc25 (latest in F25). > Oops, that's 9343, not 9443. DMI: Dell Inc. XPS 13 9343/0TM99H, BIOS A11 12/08/2016

Synaptics RMI4 touchpad regression in 4.11-rc1

2017-03-11 Thread Cameron Gutman
Hi, Beginning in 4.11-rc1, it looks like RMI4 is binding to my XPS 13 9443's Synaptics touchpad and dropping some errors into dmesg. Here are the messages that seem RMI-related: rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version rmi4_f34: probe of rmi4-00.fn34 failed with err

[PATCH v2] Input: xpad - restore LED state after device resume

2017-02-06 Thread Cameron Gutman
Set the LED_CORE_SUSPENDRESUME flag on our LED device so the LED state will be automatically restored by LED core on resume. Since Xbox One pads stop flashing only when reinitialized, we'll send them the initialization packet so they calm down too. Signed-off-by: Cameron Gutman --- Sending

Re: [PATCH 4/5] Input: xpad - restore LED state after device resume

2017-02-06 Thread Cameron Gutman
On 02/06/2017 02:05 PM, Dmitry Torokhov wrote: > On Sat, Feb 04, 2017 at 04:30:01PM -0800, Cameron Gutman wrote: >> The state of pad LEDs can be inconsistent when the system is >> woken up after sleep. Rather than leaving the controllers blinking, >> let's resend the la

Re: [PATCH 4/5] Input: xpad - restore LED state after device resume

2017-02-04 Thread Cameron Gutman
> https://github.com/0day-ci/linux/commits/Cameron-Gutman/Correctly-support-some-quirky-Xbox-One-pads/20170205-083659 > base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next > config: x86_64-randconfig-x016-201706 (attached as .config) > compiler: gcc-6 (Debian

[PATCH 4/5] Input: xpad - restore LED state after device resume

2017-02-04 Thread Cameron Gutman
packet so they calm down too. Signed-off-by: Cameron Gutman --- drivers/input/joystick/xpad.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 13f298d..1179266 100644 --- a/drivers/input/joyst

[PATCH 3/5] Input: xpad - send rumble on Xbox One init to fix PowerA pads

2017-02-04 Thread Cameron Gutman
Some PowerA pads require a rumble packet to start sending input reports. Signed-off-by: Cameron Gutman --- drivers/input/joystick/xpad.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 3f19f32b..13f298d 100644 --- a

[PATCH 2/5] Input: xpad - add init packet for Hori and Titanfall 2 pads

2017-02-04 Thread Cameron Gutman
Without sending this packet, the Titanfall 2 pad (0x0e6f:0x0165) continuously attempts to handshake with the PC and never sends any input reports. The Hori gamepad (0x0f0d:0x0067) analog sticks don't work if this isn't sent, though other buttons do work without it. Signed-off-by: Came

[PATCH 5/5] Input: xpad - fix stuck mode button on Xbox One S pad

2017-02-04 Thread Cameron Gutman
The Xbox One S requires an ack to its mode button report otherwise it continuously retransmits the report. This makes the mode button appear to be stuck down after it is pressed for the first time. Signed-off-by: Cameron Gutman --- drivers/input/joystick/xpad.c | 33

[PATCH 0/5] Correctly support some quirky Xbox One pads

2017-02-04 Thread Cameron Gutman
[2]: https://github.com/paroj/xpad [3]: https://github.com/paroj/xpad/issues/59 Cameron Gutman (5): Input: xpad - use a packet array to start Xbox One pads Input: xpad - add init packet for Hori and Titanfall 2 pads Input: xpad - send rumble on Xbox One init to fix PowerA pads Input: xp

[PATCH 1/5] Input: xpad - use a packet array to start Xbox One pads

2017-02-04 Thread Cameron Gutman
This is preparatory work for supporting some 3rd party pads that need more initialization packets than just one. No initialization behavior change expected. Signed-off-by: Cameron Gutman --- drivers/input/joystick/xpad.c | 40 +++- 1 file changed, 27

[PATCH] Input: xpad - Don't depend on endpoint order

2016-12-31 Thread Cameron Gutman
differ only by direction. We know that there are other pads out where this is not true, so let's go ahead and fix this. Signed-off-by: Cameron Gutman --- drivers/input/joystick/xpad.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/i