[PATCH] staging: comedi: das1800: prefer kmalloc_array over kmalloc with multiply

2015-01-19 Thread Chase Southwood
Checkpatch doesn't like kmalloc with multiply very much: drivers/staging/comedi/drivers/das1800.c:1377: WARNING: Prefer kmalloc_array over kmalloc with multiply So this patch swaps that use out for kmalloc_array instead. Signed-off-by: Chase Southwood chase.southw...@gmail.com --- drivers

[PATCH] staging: comedi: change some printk calls to pr_err

2014-11-30 Thread Chase Southwood
There are a handful of calls to printk in ni_stc.h without specified log levels, as well as one in ni_mio_common.c. This patch converts these calls to pr_err() instead, so that they are now explicitly log level ERR. Signed-off-by: Chase Southwood chase.southw...@gmail.com --- I tacked the change

[PATCH 1/4] staging: comedi: hwdrv_apci3120: clean up comments

2014-09-10 Thread Chase Southwood
This patch fixes improper comment indentation, removes dead code and obsolete comments, and conforms remaining comments to a consistent kernel commenting style. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee

[PATCH 0/4] staging: comedi: hwdrv_apci1320: style cleanups

2014-09-10 Thread Chase Southwood
This patchset begins by cleaning up the mess of the comments in this driver, then follows that with three very small and trivial checkpatch warning fixes. Chase Southwood (4): staging: comedi: hwdrv_apci3120: clean up comments staging: comedi: hwdrv_apci3120: add a blank line after

[PATCH 2/4] staging: comedi: hwdrv_apci3120: add a blank line after declarations

2014-09-10 Thread Chase Southwood
Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/addi-data

[PATCH 4/4] staging: comedi: hwdrv_apci3120: remove void function return statement

2014-09-10 Thread Chase Southwood
Returns at the end of void functions are useless. Remove this one. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 2 -- 1 file changed, 2

[PATCH 3/4] staging: comedi: hwdrv_apci3120: else is not useful after return

2014-09-10 Thread Chase Southwood
The statement nested in an else after a return may be brought out one indent level, the else is useless. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi-data

[PATCH] staging: comedi: hwdrv_apci1500: use dev-class_dev in calls to dev_warn()

2014-09-03 Thread Chase Southwood
git-grep reveals that hwdrv_apci1500.c is the only file in comedi that uses dev-hw_dev in calls to dev_{err,warn}(). The rest of the drivers pass dev-class_dev to these macros instead. Switch the dev_warn() calls in this driver to use dev-class_dev as well, for consistency. Signed-off-by: Chase

Re: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings

2014-08-31 Thread Chase Southwood
On Sat, Aug 30, 2014 at 5:40 AM, Ian Abbott abbo...@mev.co.uk wrote: That seems fine. Perhaps the variable 'p' in usbdux_ao_insn_write() should also be of type '__le16 *'? You're entirely correct. I had seen this in the output from Sparse, but for some reason at first glance I had convinced

[PATCH] staging: comedi: usbdux: fix more sparse endianness warnings

2014-08-31 Thread Chase Southwood
/usbdux.c:889:20:got restricted __le16 [usertype] noident This is the result of a couple of calls to cpu_to_le16() being assigned to uint16_t typed variables. Switch the types of these variables/pointers to __le16 accordingly. Signed-off-by: Chase Southwood chase.southw...@gmail.com Suggested

[PATCH] staging: comedi: usbduxsigma: fix more sparse endianness warnings

2014-08-31 Thread Chase Southwood
Sparse shows a couple of warnings like: drivers/staging/comedi/drivers/usbduxsigma.c:787:23: warning: cast to restricted __be32 Looking at the indicated lines shows that the issue is caused by an incorrect cast to uint32_t instead of __be32. Fix this cast. Signed-off-by: Chase Southwood

[PATCH] staging: comedi: hwdrv_apci035: remove useless return statement

2014-08-31 Thread Chase Southwood
Checkpatch pointed out a void function with a return statement. It can be removed. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 2 -- 1

[PATCH] staging: comedi: hwdrv_apci3501: change printk to dev_err

2014-08-31 Thread Chase Southwood
dev_err() is preferred to printk() in device drivers. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- 1 file changed, 1 insertion

[PATCH 1/4] staging: comedi: hwdrv_apci1500: remove unneeded braces

2014-08-31 Thread Chase Southwood
We don't need braces around single-statement blocks. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 30 +- 1 file changed, 12

[PATCH 2/4] staging: comedi: hwdrv_apci1500: remove commented out code

2014-08-31 Thread Chase Southwood
Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 249 ++--- 1 file changed, 123 insertions(+), 126 deletions(-) diff --git

[PATCH 0/4] staging: comedi: hwdrv_apci1500: coding style cleanups

2014-08-31 Thread Chase Southwood
This patchset begins by removing unneeded braces and commented out lines of code, and then tidies whitespace issues that are revealed after the braces/dead code is removed. Chase Southwood (4): staging: comedi: hwdrv_apci1500: remove unneeded braces staging: comedi: hwdrv_apci1500: remove

[PATCH 4/4] staging: comedi: hwdrv_apci1500: miscellaneous cleanup

2014-08-31 Thread Chase Southwood
This patch completes two final matters of cleanup which are each too small for their own patch. It corrects a couple of indentation issues and removes a return statement at the end of a void function. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H

[PATCH 3/4] staging: comedi: hwdrv_apci1500: clean some whitespace style issues

2014-08-31 Thread Chase Southwood
Now that commented out code has been removed, else statements can move to the same line as the close brace of the if statement. Also, a blank line has been added between declarations and code where needed. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk

[PATCH] staging: comedi: usbdux: fix sparse endianness warnings

2014-08-29 Thread Chase Southwood
Sparse has many warnings like: drivers/staging/comedi/drivers/usbdux.c:366:32: warning: cast to restricted __le16 on lines on which devpriv-in_buf or devpriv-insn_buf are passed to le16_to_cpu(). This suggests that both of these variables should actually be of type __le16. Signed-off-by: Chase

[PATCH] staging: comedi: usbduxsigma: fix sparse endianness warnings

2014-08-29 Thread Chase Southwood
Sparse has many warnings like: drivers/staging/comedi/drivers/usbduxsigma.c:293:21: warning: cast to restricted __be32 on lines on which devpriv-in_buf is passed to be32_to_cpu(). This suggests that this variable should actually be of type __be32. Signed-off-by: Chase Southwood chase.southw

[PATCH] staging: comedi: addi_apci_1564: move boilerplate text to addi_apci_1564.c

2014-08-29 Thread Chase Southwood
Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 -- drivers/staging/comedi/drivers/addi_apci_1564.c| 23

[PATCH] staging: comedi: dt2801: change function return type to void

2014-08-17 Thread Chase Southwood
the return type for this function from int to void, and remove the two assignments to 'stat'. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/dt2801.c | 8 +++- 1 file

[PATCH] staging: comedi: s626: remove unnecessary variable initialization

2014-08-17 Thread Chase Southwood
We initialize 'irqbit' to 0, only to properly set it immediately afterwards. Just remove the zero-initialization. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/s626

[PATCH 1/3] staging: comedi: addi_apci_1564: add whitespace to subdevice init

2014-08-16 Thread Chase Southwood
For purely aesthetic purposes, add some whitespace to subdevice initialization. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi_apci_1564.c | 78

[PATCH 2/3] staging: comedi: addi_apci_1564: correct typo in macro definition

2014-08-16 Thread Chase Southwood
A recent commit introduced a typo in the definition of APCI1564_DO_CC_INT_DISABLE. The macro is not use yet, so not a huge deal, but this patch corrects it. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee

[PATCH 3/3] staging: comedi: dt3000: remove unneeded variable

2014-08-16 Thread Chase Southwood
the variable. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- It occurred to me while doing this that zero might be or'd twice to indicate no information in order to maintain some three-part structure

[PATCH 0/3] staging: comedi: addi_apci_1564: miscellaneous cleanups

2014-08-11 Thread Chase Southwood
This patchset removes an uncorrect and unneeded insn_config operation, strips out remaining in-driver watchdog subdevice code, and cleans up the driver's register map defines. Chase Southwood (3): staging: comedi: addi_apci_1564: remove apci1564_do_config staging: comedi: addi_apci_1564

[PATCH 1/3] staging: comedi: addi_apci_1564: remove apci1564_do_config

2014-08-11 Thread Chase Southwood
The DO config function served the purpose of configuring the diagnostic interrupts for the board. As the driver currently does not support diagnostic interrupts, the digital output subdevice does not need an insn_config operation and this function can be safely removed. Signed-off-by: Chase

[PATCH 3/3] staging: comedi: addi_apci_1564: tidy register map defines

2014-08-11 Thread Chase Southwood
offsets to counter registers (since only the counters are offset from dev-iobase). Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengraver.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 70

[PATCH 2/3] staging: comedi: addi_apci_1564: Remove in-driver watchdog support code

2014-08-11 Thread Chase Southwood
future work on the timer and counter subdevices easier. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 54 +- 1 file changed

[PATCH 1/2] staging: comedi: addi_apci_1564: add subdevice to check diagnostic status

2014-07-31 Thread Chase Southwood
subdevice with an insn_bits handler to access this information. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi_apci_1564.c | 23 ++- 1 file changed, 22

[PATCH 0/2] staging: comedi: addi_apci_1564: provide interface to read diagnostic status

2014-07-31 Thread Chase Southwood
This patchset creates a simple subdevice to allow for reading of the board's diagnostic status, and then removes any code which is related to diagnostic interrupts, as the driver will not support these at this time. Chase Southwood (2): staging: comedi: addi_apci_1564: add subdevice to check

[PATCH 2/2] staging: comedi: addi_apci_1564: remove diagnostic interrupt support code

2014-07-31 Thread Chase Southwood
. So it is safe to simply remove this function. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 14 -- drivers/staging/comedi/drivers

Re: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

2014-07-16 Thread Chase Southwood
On Tue, Jul 15, 2014 at 5:14 AM, Ian Abbott abbo...@mev.co.uk wrote: On 2014-07-15 05:00, Chase Southwood wrote: On Mon, Jul 14, 2014 at 4:22 AM, Ian Abbott abbo...@mev.co.uk wrote: On 2014-07-12 23:44, Chase Southwood wrote: Use the addi_watchdog module to provide support for the watchdog

Re: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

2014-07-14 Thread Chase Southwood
On Mon, Jul 14, 2014 at 4:22 AM, Ian Abbott abbo...@mev.co.uk wrote: On 2014-07-12 23:44, Chase Southwood wrote: Use the addi_watchdog module to provide support for the watchdog subdevice. Also, rearrange the subdevice init blocks so that the order makes sense. Digital input/output

Re: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

2014-07-13 Thread Chase Southwood
On Sun, Jul 13, 2014 at 2:17 PM, Hartley Sweeten hartl...@visionengravers.com wrote: On Saturday, July 12, 2014 3:44 PM, Chase Southwood wrote: Use the addi_watchdog module to provide support for the watchdog subdevice. Also, rearrange the subdevice init blocks so that the order makes sense

[PATCH 1/2] staging: comedi: addi_apci_1564: driver no longer needs to include addi_common.h

2014-07-12 Thread Chase Southwood
This driver no longer depends on anything in addi_common.h, save for a few headers that it was including indirectly. Remove the include of addi_common.h and add the includes of linux/interrupt.h and linux/sched.h directly. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott

[PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

2014-07-12 Thread Chase Southwood
-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi_apci_1564.c | 34 +++-- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/staging

[PATCH 0/4] staging: comedi: addi_apci_1564: small fixes in apci1564_auto_attach() and apci1564_detach()

2014-07-10 Thread Chase Southwood
This is a small patchset containing a handful of fixes to the ADDI-DATA APCI1564 driver that I would like to get out of the way before I forget to take care of them. From here, I will move to start fixing the digital input/timer/counters/watchdog functionality of the board. Chase Southwood (4

[PATCH 1/4] staging: comedi: addi_apci_1564: remove len_chanlist from di and do subdevices

2014-07-10 Thread Chase Southwood
This value is only needed for subdevices that support async commands. The comedi core will default the value to 1 when it is not initialized. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers

[PATCH 4/4] staging: comedi: addi_apci_1564: fix s-maxdata assignment in do subdevice init.

2014-07-10 Thread Chase Southwood
s-maxdata for the do subdevice should be 1, however currently it is being set to 0x. Fix this. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- This patch is at the end because I'm somewhat

[PATCH 2/4] staging: comedi: addi_apci_1564: remove unnecessary dev-board_name initialization

2014-07-10 Thread Chase Southwood
The dev-board_name is now initialized by the comedi core before calling the(*attach) or (*auto_attach) function in a driver. As long as the driver does no additional probing, it's no longer necessary initialize the board_name. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian

[PATCH 3/4] staging: comedi: addi_apci_1564: remove null check of devpriv in apci1564_detach()

2014-07-10 Thread Chase Southwood
There is no need to test whether devpriv is null in this function. The check looks left over and we can just remove it. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers

Re: [PATCH v2 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups

2014-07-03 Thread Chase Southwood
On Thu, Jul 3, 2014 at 4:39 AM, Ian Abbott abbo...@mev.co.uk wrote: On 2014-07-03 03:15, Chase Southwood wrote: This patchset moves a misplaced include to the proper file, swaps out an overly aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt(). Chase Southwood (3

[PATCH v2 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups

2014-07-02 Thread Chase Southwood
This patchset moves a misplaced include to the proper file, swaps out an overly aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt(). Chase Southwood (3): staging: comedi: addi_apci_1564: move addi_watchdog.h include to addi_apci_1564.c staging: comedi

[PATCH v2 1/3] staging: comedi: addi_apci_1564: move addi_watchdog.h include to addi_apci_1564.c

2014-07-02 Thread Chase Southwood
Commit aed3f9d (staging: comedi: addi_apci_1564: absorb apci1564_reset()) moved the only use of addi_watchdog.h from hwdrv_apci1564.c to addi_apci_1564.c, but left the include statement itself in the former file. Move this include to the file which actually uses it. Signed-off-by: Chase

[PATCH v2 2/3] staging: comedi: addi_apci_1564: fix use of apci1564_reset() to disable DI interrupts

2014-07-02 Thread Chase Southwood
, and counters as well. Replace the reset function call with a direct disabling of just the digital input interrupts. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi_apci_1564

[PATCH v2 3/3] staging: comedi: addi_apci_1564: clean up apci1564_interrupt()

2014-07-02 Thread Chase Southwood
for the register is is accessing, so we can handle all four counters with a for loop. Finally, the interrupt handler is incorrectly setting and then checking devpriv-timer_select_mode before processing some of the triggered interrupts, so just remove all occurrences of this. Signed-off-by: Chase

Re: [PATCH 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups

2014-07-01 Thread Chase Southwood
Hi all, On Mon, Jun 30, 2014 at 5:25 AM, Ian Abbott abbo...@mev.co.uk wrote: On 2014-06-28 05:47, Chase Southwood wrote: This patchset moves a misplaced include to the proper file, swaps out an overly aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt(). Chase

[PATCH 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups

2014-06-27 Thread Chase Southwood
This patchset moves a misplaced include to the proper file, swaps out an overly aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt(). Chase Southwood (3): staging: comedi: addi_apci_1564: move addi_watchdog.h include to addi_apci_1564.c staging: comedi

[PATCH 1/3] staging: comedi: addi_apci_1564: move addi_watchdog.h include to addi_apci_1564.c

2014-06-27 Thread Chase Southwood
Commit aed3f9d (staging: comedi: addi_apci_1564: absorb apci1564_reset()) moved the only use of addi_watchdog.h from hwdrv_apci1564.c to addi_apci_1564.c, but left the include statement itself in the former file. Move this include to the file which actually uses it. Signed-off-by: Chase

[PATCH 2/3] staging: comedi: addi_apci_1564: fix use of apci1564_reset() to disable DI interrupts

2014-06-27 Thread Chase Southwood
, and counters as well. Replace the reset function call with a direct disabling of just the digital input interrupts. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi_apci_1564

[PATCH 3/3] staging: comedi: addi_apci_1564: clean up apci1564_interrupt()

2014-06-27 Thread Chase Southwood
of devpriv-timer_select_mode before processing any triggered interrupts, remove all occurrences of this. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- Hartley, I remember that you mentioned

[PATCH v3 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality

2014-06-21 Thread Chase Southwood
been fixed. CHANGES FROM v2: *Just refreshed set against staging-next. Otherwise everything is exactly the same, and should apply now. Chase Southwood (5): staging: comedi: addi_apci_1564: remove use of devpriv-b_OutputMemoryStatus staging: comedi: addi_apci_1564: remove unused static

[PATCH v3 1/5] staging: comedi: addi_apci_1564: remove use of devpriv-b_OutputMemoryStatus

2014-06-21 Thread Chase Southwood
This member of the private data struct is only set at one location in the entire driver, and then never even used for anything. Let's just remove its use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeeten hswee...@visionengravers.com

[PATCH v3 2/5] staging: comedi: addi_apci_1564: remove unused static variables

2014-06-21 Thread Chase Southwood
The global variables ui_InterruptStatus_1564 and ui_InterruptData are both set but never used. Just remove them from the driver. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging

[PATCH v3 3/5] staging: comedi: addi_apci_1564: introduce apci1564_private struct

2014-06-21 Thread Chase Southwood
containing only the fields it will actually use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 182 ++--- drivers/staging/comedi/drivers

[PATCH v3 4/5] staging: comedi: addi_apci_1564: add Change-of-State interrupt subdevice and required functions

2014-06-21 Thread Chase Southwood
is broken since it does not follow the comedi API for insn_config functions. Fix this function by implementing the config instruction INSN_CONFIG_DIGITAL_TRIG. Add the remaining subdevice operations necessary for the interrupt subdevice to support async commands. Signed-off-by: Chase Southwood

[PATCH v3 5/5] staging: comedi: addi_apci_1564: move apci1564_interrupt() into addi_apci_1564.c

2014-06-21 Thread Chase Southwood
On moving the function into the driver proper, also check the device is asserting the shared interrupt line. This patch also fixes the interrupt handling for the digital input change-of-state interrupts. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc

[PATCH v2 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality

2014-06-03 Thread Chase Southwood
been fixed. Chase Southwood (5): staging: comedi: addi_apci_1564: remove use of devpriv-b_OutputMemoryStatus staging: comedi: addi_apci_1564: remove unused static variables staging: comedi: addi_apci_1564: introduce apci1564_private struct staging: comedi: addi_apci_1564: add Change

[PATCH v2 1/5] staging: comedi: addi_apci_1564: remove use of devpriv-b_OutputMemoryStatus

2014-06-03 Thread Chase Southwood
This member of the private data struct is only set at one location in the entire driver, and then never even used for anything. Let's just remove its use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeeten hswee...@visionengravers.com

[PATCH v2 3/5] staging: comedi: addi_apci_1564: introduce apci1564_private struct

2014-06-03 Thread Chase Southwood
containing only the fields it will actually use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 182 ++--- drivers/staging/comedi/drivers

[PATCH v2 2/5] staging: comedi: addi_apci_1564: remove unused static variables

2014-06-03 Thread Chase Southwood
The global variables ui_InterruptStatus_1564 and ui_InterruptData are both set but never used. Just remove them from the driver. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging

[PATCH v2 5/5] staging: comedi: addi_apci_1564: move apci1564_interrupt() into addi_apci_1564.c

2014-06-03 Thread Chase Southwood
On moving the function into the driver proper, also check the device is asserting the shared interrupt line. This patch also fixes the interrupt handling for the digital input change-of-state interrupts. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc

[PATCH v2 4/5] staging: comedi: addi_apci_1564: add Change-of-State interrupt subdevice and required functions

2014-06-03 Thread Chase Southwood
is broken since it does not follow the comedi API for insn_config functions. Fix this function by implementing the config instruction INSN_CONFIG_DIGITAL_TRIG. Add the remaining subdevice operations necessary for the interrupt subdevice to support async commands. Signed-off-by: Chase Southwood

Re: [PATCH 6/6] staging: comedi: addi_apci_1564: cleanup v_ADDI_Interrupt()

2014-06-01 Thread Chase Southwood
On Fri, May 30, 2014 at 12:26 PM, Hartley Sweeten hartl...@visionengravers.com wrote: On Thursday, May 29, 2014 9:44 PM, Chase Southwood wrote: Move the function apci1564_interrupt() from hwdrv_apci1564.c to addi_apci_1564.c. On moving, for now just strip out all of the code for interrupts

Re: [PATCH 0/3] staging: comedi: addi_apci_1564: prepare for adding Change-of-State interrupt support

2014-05-29 Thread Chase Southwood
Hi Greg, On Sat, May 24, 2014 at 5:23 PM, Chase Southwood chase.southw...@gmail.com wrote: This patchset adds the required subdevice for supporting DI COS interrupts, as well as introducing a driver-specific private data struct that will make the COS interrupt operations much more

[PATCH 0/6] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality.

2014-05-29 Thread Chase Southwood
This patchset introduces a new private data struct for this driver, adds all of the code required to support Change-of-State interrupts for the digital input subsystem, and finally focuses and fixes apci1564_interrupt() to service this type of interrupt correctly. Chase Southwood (6): staging

[PATCH 2/6] staging: comedi: addi_apci_1564: remove use of devpriv-b_OutputMemoryStatus

2014-05-29 Thread Chase Southwood
This member of the private data struct is only set at one location in the entire driver, and then never even used for anything. Let's just remove its use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeeten hswee...@visionengravers.com

[PATCH 1/6] staging: comedi: addi_apci_1564: remove send_sig() use

2014-05-29 Thread Chase Southwood
-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 -- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi

[PATCH 4/6] staging: comedi: addi_apci_1564: add a subdevice for Change-of-State interrupt support

2014-05-29 Thread Chase Southwood
This board supports an interrupt that can be generated by an AND/OR combination of 16 of the input channels. Create a separate subdevice to handle this interrupt. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee

[PATCH 5/6] staging: comedi: addi_apci_1564: hook-up the interrupt subdevice

2014-05-29 Thread Chase Southwood
functions. Fix this function by implementing the config instruction INSN_CONFIG_DIGITAL_TRIG. Add the remaining subdevice operations necessary for the interrupt subdevice to support async commands. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H

[PATCH 3/6] staging: comedi: addi_apci_1564: introduce apci1564_private struct

2014-05-29 Thread Chase Southwood
containing only the fields it will actually use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 164 +++-- drivers/staging/comedi/drivers

[PATCH 6/6] staging: comedi: addi_apci_1564: cleanup v_ADDI_Interrupt()

2014-05-29 Thread Chase Southwood
) to IRQ_HANDLED. We also check the device is asserting the shared interrupt line and check that interrupts have been enabled. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- Admittedly, I am not sure

Re: [PATCH 1/3] staging: comedi: addi_apci_1564: add a subdevice for Change-of-State interrupt support

2014-05-27 Thread Chase Southwood
On Tue, May 27, 2014 at 11:34 AM, Ian Abbott abbo...@mev.co.uk wrote: On 2014-05-24 23:24, Chase Southwood wrote: This board supports an interrupt that can be generated by an AND/OR combination of 16 of the input channels. Create a separate subdevice to handle this interrupt. In doing

[PATCH 0/3] staging: comedi: addi_apci_1564: prepare for adding Change-of-State interrupt support

2014-05-24 Thread Chase Southwood
This patchset adds the required subdevice for supporting DI COS interrupts, as well as introducing a driver-specific private data struct that will make the COS interrupt operations much more straightforward and clean. Chase Southwood (3): staging: comedi: addi_apci_1564: add a subdevice

[PATCH 1/3] staging: comedi: addi_apci_1564: add a subdevice for Change-of-State interrupt support

2014-05-24 Thread Chase Southwood
renames it to make it more apparent that it is the config operation for the COS interrupt. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 8

[PATCH 2/3] staging: comedi: addi_apci_1564: remove send_sig() use

2014-05-24 Thread Chase Southwood
-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 -- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi

[PATCH 3/3] staging: comedi: addi_apci_1564: introduce apci1564_private struct

2014-05-24 Thread Chase Southwood
containing only the fields it will actually use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- The idea behind this patch is that it will allow me to rewrite the apci1564_cos_insn_config() function the same

[PATCH 1/2] staging: comedi: addi_apci_1564: move apci1564_di_insn_bits() to addi_apci_1564.c

2014-05-21 Thread Chase Southwood
...@visionengravers.com Signed-off-by: Chase Southwood chase.southw...@gmail.com --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 12 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 2/2] staging: comedi: addi_apci_1564: move apci1564_do_insn_bits() to addi_apci_1564.c

2014-05-21 Thread Chase Southwood
...@visionengravers.com Signed-off-by: Chase Southwood chase.southw...@gmail.com --- Just a couple patches in this set, but with these out of the way, the next patchset can focus entirely on getting the change-of-state interrupt functionality working. Made sense to just finish up with DI/DO and start COS

[PATCH 0/2] staging: comedi: addi_apci_1564: remove boardinfo

2014-05-07 Thread Chase Southwood
This patchset removes the last dependency on this driver's boardinfo (the timer subdevice init), and then removes the boardinfo from the driver. To be applied on top of my prior patchset staging: comedi: addi_apci_1564: further cleanups Chase Southwood (2): staging: comedi: addi_apci_1564

[PATCH 1/2] staging: comedi: addi_apci_1564: remove check for timer subdevice

2014-05-07 Thread Chase Southwood
The only board served by this driver always has a timer, so we can init the timer subdevice without checking first. The boardinfo about the timer can also be removed and the data used directly. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H

[PATCH 2/2] staging: comedi: addi_apci_1564: remove boardinfo

2014-05-07 Thread Chase Southwood
This driver only supports a single board type. Remove the boardinfo and its use in the driver. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi_apci_1564.c | 13

Re: [PATCH 1/6] staging: comedi: addi_apci_1564: remove eeprom support code

2014-05-04 Thread Chase Southwood
On Sat, May 3, 2014 at 6:52 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Apr 28, 2014 at 12:40:05PM +0300, Dan Carpenter wrote: Nice, Chase, you've become an expert on comedi, it seems. I can't say how happy comedi patches make me these days. Ian, you and Hartley are doing a

[PATCH 6/6 v3] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-05-03 Thread Chase Southwood
This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley

[PATCH 0/4] staging: comedi: addi_apci_1564: Further cleanups

2014-05-03 Thread Chase Southwood
: remove eeprom support code) Chase Southwood (4): staging: comedi: addi_apci_1564: board has 32 digital outputs staging: comedi: addi_apci_1564: don't allocate unused subdevices staging: comedi: addi_apci_1564: absorb apci1564_reset() staging: comedi: addi_apci_1564: call apci1564_interrupt

[PATCH 1/4] staging: comedi: addi_apci_1564: board has 32 digital outputs

2014-05-03 Thread Chase Southwood
This board always has 32 digital outputs. Remove the test when initializing the subdevice. Also, since this board is the only one supported by this driver, remove the boardinfo about the digital outputs and just use the data directly in the subdevice init. Signed-off-by: Chase Southwood

[PATCH 2/4] staging: comedi: addi_apci_1564: don't allocate unused subdevices

2014-05-03 Thread Chase Southwood
The addi-data common code always allocates 7 subdevices. This driver cannot or will not use the ones we are currently allocating for analog input and output or EEPROM, so just don't allocate these subdevices at all. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo

[PATCH 3/4] staging: comedi: addi_apci_1564: absorb apci1564_reset()

2014-05-03 Thread Chase Southwood
This is the only reset fuction used by this driver. We can remove it from the boardinfo and absorb the code from hwdrv_apci1564.c into the driver. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com

[PATCH 4/4] staging: comedi: addi_apci_1564: call apci1564_interrupt() directly

2014-05-03 Thread Chase Southwood
Remove the boardinfo about the interrupt function and just call it directly. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi_apci_1564.c | 6 +- 1 file changed

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-30 Thread Chase Southwood
...@visionengravers.com wrote: On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off

[PATCH 4/6 v3] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-30 Thread Chase Southwood
This driver only uses PCI bar 0 (devpriv-i_IobaseAmcc), and PCI bar 1 (dev-iobase), don't bother reading the unused PCI bars. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- 2: Bad PCI bar numbers

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-30 Thread Chase Southwood
: On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote: Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send them

Re: [PATCH 6/6] staging: comedi: addi_apci_2032: remove use of devpriv-s_EeParameters

2014-04-29 Thread Chase Southwood
...@visionengravers.com wrote: On Saturday, April 26, 2014 6:39 PM, Chase Southwood wrote: This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase

Re: [PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-29 Thread Chase Southwood
to be more careful in the future. Thanks your all of the assistance and patience, Chase On Mon, Apr 28, 2014 at 1:09 PM, Hartley Sweeten hartl...@visionengravers.com wrote: On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote: This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc

[PATCH 3/6 v2] staging: comedi: addi_apci_1564: board has 32 digital inputs

2014-04-29 Thread Chase Southwood
This board always has 32 digital inputs. Remove the test when initializing the subdevice. Also, since this board is the only one supported by this driver, remove the boardinfo about the digital inputs and just use the data directly in the subdevice init. Signed-off-by: Chase Southwood

[PATCH 4/6 v2] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-29 Thread Chase Southwood
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2 (dev-iobase) doon't bother reading the unused PCI bars. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- 2: Bad PCI bar numbers

[PATCH 5/6 v2] staging: comedi: addi_apci_1564: remove unnecessary info from boardinfo

2014-04-29 Thread Chase Southwood
The i_IorangeBase1, i_PCIEeprom, and pc_EepromChip data in the boardinfo was only needed to work out the usage of the PCI bars. Now that that is squared away, this info is no longer needed and can be removed. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo

[PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-29 Thread Chase Southwood
This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley

  1   2   3   >