Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

2024-01-30 Thread Chen-Yu Tsai
Hi, On Mon, Jan 29, 2024 at 12:09:50PM -0800, Luis Chamberlain wrote: > On Thu, Dec 21, 2023 at 10:02:46AM +0100, Christophe Leroy wrote: > > Declaring rodata_enabled and mark_rodata_ro() at all time > > helps removing related #ifdefery in C files. > > > > Signed-off-by: Christophe Leroy > >

Re: [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility

2023-09-21 Thread Chen-Yu Tsai
, 7 insertions(+), 11 deletions(-) > > > > Tested on asurada (spherion) and jacuzzi (juniper). The issue was detected by > KernelCI, so: > > Reported-by: "kernelci.org bot" > Tested-by: Laura Nao Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai on Hayato (MT8192) and Juniper (MT8183).

Re: [PATCH] remoteproc: mediatek: Detect single/multi core SCP with rpmsg-name property

2023-09-19 Thread Chen-Yu Tsai
On Tue, Sep 19, 2023 at 5:26 PM AngeloGioacchino Del Regno wrote: > > Il 19/09/23 07:03, Chen-Yu Tsai ha scritto: > > In the just landed multi-core SCP work, detection of single/multi core > > SCP is done by checking the immediate child node of the SCP complex > > devi

Re: [PATCH v17 00/14] Add support for MT8195 SCP 2nd core

2023-09-18 Thread Chen-Yu Tsai
On Tue, Sep 19, 2023 at 9:17 AM Mathieu Poirier wrote: > > On Mon, Sep 18, 2023 at 06:44:25PM +0800, Chen-Yu Tsai wrote: > > On Mon, Sep 18, 2023 at 6:32 PM Laura Nao wrote: > > > > > > > Other than patch 2 and 14, I have applied this set. The remaining

[PATCH] remoteproc: mediatek: Detect single/multi core SCP with rpmsg-name property

2023-09-18 Thread Chen-Yu Tsai
old device trees working again. Reported-by: Laura Nao Fixes: 1fdbf0cdde98 ("remoteproc: mediatek: Probe SCP cluster on multi-core SCP") Signed-off-by: Chen-Yu Tsai --- The patch is based on next-20230918 with a whole bunch of local patches stacked on top. None of my local patches are r

Re: [PATCH v17 00/14] Add support for MT8195 SCP 2nd core

2023-09-18 Thread Chen-Yu Tsai
On Mon, Sep 18, 2023 at 6:32 PM Laura Nao wrote: > > > Other than patch 2 and 14, I have applied this set. The remaining patches > > will > > have to be resent to Matthias. > > > Thanks, > > Mathieu > > Hello, > > With patch 2 missing, the SCP is not probed correctly anymore on asurada >

Re: [PATCH 0/2] sunxi: Enforce consistent MMC numbering

2021-04-18 Thread Chen-Yu Tsai
Hi, On Mon, Apr 19, 2021 at 10:52 AM Samuel Holland wrote: > > Dealing with the inconsistent numbering has been a major pain, and > there is a solution with (as far as I can tell) no tangible downsides. > So let's use it. > > Yes, I know the kernel supports UUIDs for root=. But UUIDs do not help

Re: [PATCH] nvmem: sunxi_sid: Set type to OTP

2021-04-18 Thread Chen-Yu Tsai
On Mon, Apr 19, 2021 at 9:58 AM Samuel Holland wrote: > > This device currently reports an "Unknown" type in sysfs. > Since it is an eFuse hardware device, set its type to OTP. > > Signed-off-by: Samuel Holland Acked-by: Chen-Yu Tsai

Re: [PATCH v2 3/6] ARM: dts: rockchip: remove interrupts properties from pwm nodes rv1108.dtsi

2021-04-12 Thread Chen-Yu Tsai
On Mon, Apr 12, 2021 at 6:03 PM Johan Jonker wrote: > > On 4/12/21 5:15 AM, Chen-Yu Tsai wrote: > > On Sun, Apr 11, 2021 at 9:11 PM Johan Jonker wrote: > >> > >> A test with the command below gives this error: > >> > >> /arch/arm/boot/dts/rv1108-e

Re: [PATCH v2 3/6] ARM: dts: rockchip: remove interrupts properties from pwm nodes rv1108.dtsi

2021-04-11 Thread Chen-Yu Tsai
On Sun, Apr 11, 2021 at 9:11 PM Johan Jonker wrote: > > A test with the command below gives this error: > > /arch/arm/boot/dts/rv1108-evb.dt.yaml: > pwm@1028: 'interrupts' does not match any of the regexes: > 'pinctrl-[0-9]+' > > "interrupts" is an undocumented property, so remove them > from

Re: [PATCH v2] rockchip: enabled LAN port on NanoPi R2S

2021-04-05 Thread Chen-Yu Tsai
On Mon, Apr 5, 2021 at 7:03 PM Johan Jonker wrote: > > Hi Tianling, > > On 4/5/21 11:34 AM, Tianling Shen wrote: > > From: David Bauer > > > > Enable the USB3 port on the FriendlyARM NanoPi R2S. > > This is required for the USB3 attached LAN port to work. > > > > Signed-off-by: David Bauer > >

Re: [PATCH] rockchip: enabled LAN port on NanoPi R2S

2021-04-05 Thread Chen-Yu Tsai
On Mon, Apr 5, 2021 at 4:53 PM Tianling Shen wrote: > > Hi Chen-Yu, > > On 2021-04-05 16:14, Chen-Yu Tsai wrote: > > > > Hi, > > > > On Mon, Apr 5, 2021 at 3:46 PM Tianling Shen wrote: > > > > > > From: David Bauer > >

Re: [PATCH] rockchip: enabled LAN port on NanoPi R2S

2021-04-05 Thread Chen-Yu Tsai
Hi, On Mon, Apr 5, 2021 at 3:46 PM Tianling Shen wrote: > > From: David Bauer > > Enable the USB3 port on the FriendlyARM NanoPi R2S. > This is required for the USB3 attached LAN port to work. > > Signed-off-by: David Bauer > Signed-off-by: Tianling Shen > --- >

Re: [PATCH 28/38] dt-bindings: power: supply: axp20x: Convert to DT schema format

2021-03-23 Thread Chen-Yu Tsai
On Fri, Mar 12, 2021 at 11:52 PM Sebastian Reichel wrote: > > Convert the binding to DT schema format. > > Cc: Chen-Yu Tsai > Signed-off-by: Sebastian Reichel Looks good to me. Though I'm not well versed in the new YAML binding format yet. Acked-by: Chen-Yu Tsai

Re: [linux-sunxi] [PATCH v2] ARM: dts: sun8i: h3: beelink-x2: Add power button

2021-03-23 Thread Chen-Yu Tsai
On Wed, Mar 24, 2021 at 4:44 AM Jernej Skrabec wrote: > > Beelink X2 has power button. Add node for it. > > Signed-off-by: Jernej Skrabec Acked-by: Chen-Yu Tsai

Re: [PATCH v3 6/8] power: supply: Clean-up few drivers by using managed work init

2021-03-23 Thread Chen-Yu Tsai
Hi, On Tue, Mar 23, 2021 at 9:58 PM Matti Vaittinen wrote: > > Few drivers implement remove call-back only for ensuring a delayed > work gets cancelled prior driver removal. Clean-up these by switching > to use devm_delayed_work_autocancel() instead. > > This change is compile-tested only. All

Re: [RFC RESEND PATCH v2 6/8] power: supply: Clean-up few drivers by using managed work init

2021-03-22 Thread Chen-Yu Tsai
Hi, On Mon, Mar 22, 2021 at 3:38 PM Matti Vaittinen wrote: > > Few drivers implement remove call-back only for ensuring a delayed > work gets cancelled prior driver removal. Clean-up these by switching > to use devm_delayed_work_autocancel() instead. > > This change is compile-tested only. All

Re: [PATCH] media: platform: sunxi: sun6i-csi: fix error return code of sun6i_video_start_streaming()

2021-03-07 Thread Chen-Yu Tsai
Signed-off-by: Jia-Ju Bai This should have the tag: Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s") Please try to add them when fixing bugs. And this should also be tagged for stable, so Cc: Otherwise, Acked-by: Chen-Yu Tsai

[PATCH] arm64: dts: allwinner: h6: Switch to macros for RSB clock/reset indices

2021-03-01 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The macros for the clock and reset indices for the RSB hardware block were replaced with raw numbers when the RSB controller node was added. This was done to avoid cross-tree dependencies. Now that both the clk and DT changes have been merged, we can switch back to using

Re: [PATCH] clk: sunxi-ng: v3s: add support for variable rate audio pll output

2021-02-18 Thread Chen-Yu Tsai
On Thu, Feb 18, 2021 at 4:06 PM Icenowy Zheng wrote: > > > > 于 2021年2月18日 GMT+08:00 下午3:58:35, Maxime Ripard 写到: > >Hi, > > > >On Fri, Feb 12, 2021 at 02:57:25PM +0100, Tobias Schramm wrote: > >> Previously the variable rate audio pll output was fixed to a divider > >of > >> four. This is

Re: Re: [PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-05 Thread Chen-Yu Tsai
On Sat, Feb 6, 2021 at 12:21 AM Jernej Škrabec wrote: > > Dne petek, 05. februar 2021 ob 17:01:30 CET je Maxime Ripard napisal(a): > > On Fri, Feb 05, 2021 at 11:21:22AM +0800, Chen-Yu Tsai wrote: > > > On Fri, Feb 5, 2021 at 2:48 AM Jernej Skrabec > wrote: > > >

Re: [linux-sunxi] [PATCH 5/5] drm/sun4i: dw-hdmi: Fix max. frequency for H6

2021-02-04 Thread Chen-Yu Tsai
more pronounced with higher frequencies. > > Fix that by allowing max. supported frequency in HW and fix the comment. > > Fixes: cd9063757a22 ("drm/sun4i: DW HDMI: Lower max. supported rate for H6") > Tested-by: Andre Heider > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai

Re: [linux-sunxi] [PATCH 4/5] drm/sun4i: Fix H6 HDMI PHY configuration

2021-02-04 Thread Chen-Yu Tsai
On Fri, Feb 5, 2021 at 2:48 AM Jernej Skrabec wrote: > > cpce value for 594 MHz is set differently in BSP driver. Fix that. > > Fixes: c71c9b2fee17 ("drm/sun4i: Add support for Synopsys HDMI PHY") > Tested-by: Andre Heider > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai

Re: [PATCH 3/5] drm/sun4i: dw-hdmi: always set clock rate

2021-02-04 Thread Chen-Yu Tsai
Fix that by removing set_rate quirk and always set clock rate. > > Fixes: 40bb9d3147b2 ("drm/sun4i: Add support for H6 DW HDMI controller") > Tested-by: Andre Heider > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai

Re: [PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-04 Thread Chen-Yu Tsai
gt; + val |= SUN4I_TCON0_IO_POL_VSYNC_POSITIVE; > + > + regmap_write(tcon->regs, SUN4I_TCON0_IO_POL_REG, val); > + } else { > + val = SUN4I_TCON1_IO_POL_UNKNOWN; I think a comment for the origin of this is warranted. Otherwise

Re: [linux-sunxi] [PATCH 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

2021-02-04 Thread Chen-Yu Tsai
> Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai

Re: [linux-sunxi] Re: [PATCH v5 06/20] mfd: axp20x: Allow AXP chips without interrupt lines

2021-02-02 Thread Chen-Yu Tsai
ber returned by the platform code is > > valid, before trying to register the irqchip. If not, we skip this > > registration, to avoid the driver to bail out completely. > > > > Signed-off-by: Andre Przywara > > Acked-by: Maxime Ripard Acked-by: Chen-Yu Tsai

Re: [PATCH v5 14/20] dt-bindings: bus: rsb: Add H616 compatible string

2021-02-01 Thread Chen-Yu Tsai
On Thu, Jan 28, 2021 at 1:26 AM Andre Przywara wrote: > > Add the obvious compatible name to the existing RSB binding, and pair > it with the existing A23 fallback compatible string, as the devices are > compatible. > > Signed-off-by: Andre Przywara Acked-by: Chen-Yu Tsai

Re: [linux-sunxi] [PATCH v5 04/20] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ)

2021-02-01 Thread Chen-Yu Tsai
Hi, On Thu, Jan 28, 2021 at 1:26 AM Andre Przywara wrote: > > The AXP305 PMIC used in AXP805 seems to be fully compatible to the ^ This statement doesn't quite make sense. I assume you wanted to mention a board or the H616 SoC here? > AXP805 PMIC, so add the proper

Re: arm: sunxi: &83t: WARNING: CPU: 2 PID: 57 at drivers/thermal/thermal_core.c:563 thermal_zone_device_update

2021-01-30 Thread Chen-Yu Tsai
Hi, On Sun, Jan 31, 2021 at 12:54 AM Corentin Labbe wrote: > > Hello > > When booting next-20210128, I got the following warning on by bpim3 > 6.148421] [ cut here ] > [6.153145] WARNING: CPU: 2 PID: 57 at drivers/thermal/thermal_core.c:563 >

Re: [PATCH v5 00/10] sunxi: Support IRQ wakeup from deep sleep

2021-01-27 Thread Chen-Yu Tsai
On Mon, Jan 25, 2021 at 6:56 PM Maxime Ripard wrote: > > On Sat, Jan 23, 2021 at 12:26:26AM -0600, Samuel Holland wrote: > > On 1/22/21 4:47 AM, Maxime Ripard wrote: > > > On Thu, Jan 21, 2021 at 07:33:54PM -0600, Samuel Holland wrote: > > >> On 1/21/21 2:35 PM, Marc Zyngier wrote: > > >>> On

Re: [PATCH] power: supply: axp20x_usb_power: Init work before enabling IRQs

2021-01-24 Thread Chen-Yu Tsai
On Sun, Jan 24, 2021 at 11:24 PM Samuel Holland wrote: > > The IRQ handler calls mod_delayed_work() on power->vbus_detect. However, > that work item is not initialized until after the IRQs are enabled. If > an IRQ is already pending when the driver is probed, the driver calls > mod_delayed_work()

Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node

2021-01-21 Thread Chen-Yu Tsai
On Fri, Jan 22, 2021 at 3:54 AM Jernej Škrabec wrote: > > Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a): > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > packet loss rates. The realtek phy driver overrides the settings of the > > pull ups

[PATCH v4 4/4] arm64: dts: rockchip: rk3399: Add NanoPi M4B

2021-01-21 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The NanoPi M4B is a minor revision of the original M4. The differences against the original Nanopi M4 that are common with the other M4V2 revision include: - microphone header removed - power button added - recovery button added Additional changes specific to the M4B

[PATCH v4 3/4] arm64: dts: rockchip: nanopi4: Move ep-gpios property to nanopc-t4

2021-01-21 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Only the NanoPC T4 hs the PCIe reset pin routed to the SoC. For the NanoPi M4 family, no such signal is routed to the expansion header on the base board. As the schematics for the expansion board were not released, it is unclear how this is handled, but the likely answer

[PATCH v4 2/4] dt-bindings: arm: rockchip: Add FriendlyARM NanoPi M4B

2021-01-21 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The NanoPi M4B is a minor revision of the original M4. The differences against the original Nanopi M4 that are common with the other M4V2 revision include: - microphone header removed - power button added - recovery button added Additional changes specific to the M4B

[PATCH v4 0/4] arm64: rockchip: Fix PCIe ep-gpios requirement and Add Nanopi M4B

2021-01-21 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This is v4 of my Nanopi M4B series. Changes since v3 include: - Directly return dev_err_probe() instead of having a separate return statement Changes since v2 include: - Replaced dev_err() with dev_err_probe() for gpiod_get_optional() error - Added

[PATCH v4 1/4] PCI: rockchip: Make 'ep-gpios' DT property optional

2021-01-21 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The Rockchip PCIe controller DT binding clearly states that 'ep-gpios' is an optional property. And indeed there are boards that don't require it. Make the driver follow the binding by using devm_gpiod_get_optional() instead of devm_gpiod_get(). Fixes: e77f847df54c (&quo

Re: [PATCH v4 1/4] dt-bindings: usb: add rk3328 dwc3 docs

2021-01-20 Thread Chen-Yu Tsai
On Thu, Jan 21, 2021 at 12:30 PM Lindsey Stanpoor wrote: > > On Fri, Nov 6, 2020 at 11:42 PM Felipe Balbi wrote: > > > > > > Hi, > > > > Lindsey Stanpoor writes: > > > On Wed, Sep 2, 2020 at 11:12 AM wrote: > > >> > > >> From: Cameron Nemo > > >> > > >> Document compatible for dwc3 on the

Re: [PATCH v3 1/4] PCI: rockchip: Make 'ep-gpios' DT property optional

2021-01-19 Thread Chen-Yu Tsai
On Tue, Jan 19, 2021 at 5:11 PM Heiko Stübner wrote: > > Am Mittwoch, 6. Januar 2021, 14:46:14 CET schrieb Chen-Yu Tsai: > > From: Chen-Yu Tsai > > > > The Rockchip PCIe controller DT binding clearly states that 'ep-gpios' is > > an optional property. And inde

Re: [PATCH v3 0/4] arm64: rockchip: Fix PCIe ep-gpios requirement and Add Nanopi M4B

2021-01-18 Thread Chen-Yu Tsai
Hi, On Wed, Jan 6, 2021 at 9:46 PM Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > Hi everyone, > > This is v3 of my Nanopi M4B series. Changes since v2 include: > > - Replaced dev_err() with dev_err_probe() for gpiod_get_optional() error > - Added Reviewed-by tag

Re: [linux-sunxi] Re: [PATCH v3 02/21] mmc: sunxi: add support for A100 mmc controller

2021-01-18 Thread Chen-Yu Tsai
On Mon, Jan 18, 2021 at 11:53 PM Andre Przywara wrote: > > On Mon, 18 Jan 2021 14:28:54 +0100 > Maxime Ripard wrote: > > Hi Maxime, > > > On Mon, Jan 18, 2021 at 02:08:29AM +, Andre Przywara wrote: > > > From: Yangtao Li > > > > > > This patch adds support for A100 MMC controller, which use

Re: [linux-sunxi] Re: [PATCH v2 4/4] arm64: dts: allwinner: h6: Use RSB for AXP805 PMIC connection

2021-01-18 Thread Chen-Yu Tsai
On Wed, Jan 13, 2021 at 5:16 PM Chen-Yu Tsai wrote: > > On Thu, Jan 7, 2021 at 6:27 PM Samuel Holland wrote: > > > > On 1/6/21 5:38 AM, Chen-Yu Tsai wrote: > > > On Wed, Jan 6, 2021 at 7:06 PM Maxime Ripard wrote: > > >> > > >> On Mon, Jan

Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition

2021-01-17 Thread Chen-Yu Tsai
On Wed, Dec 30, 2020 at 11:29 AM Chen-Yu Tsai wrote: > > On Tue, Dec 22, 2020 at 4:17 PM Jernej Škrabec > wrote: > > > > Hi! > > > > Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski > > napisal(a): > > > This adds a device-tree d

[PATCH v2 2/3] dt-bindings: arm: rockchip: Add Radxa ROCK Pi E

2021-01-17 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Radxa ROCK Pi E is a router oriented SBC based on Rockchip's RK3328 SoC. As the official wiki page puts it, "E for Ethernets". It features the RK3328 SoC, gigabit and fast Ethernet RJ45 ports, both directly served by Ethernet controllers in the SoC, a USB 3.0

[PATCH v2 1/3] arm64: dts: rockchip: rk3328: Add clock_in_out property to gmac2phy node

2021-01-17 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The gmac2phy is integrated with the PHY within the SoC. Any properties related to this integration can be included in the .dtsi file, instead of having board dts files specify them separately. Add the clock_in_out property to specify the direction of the PHY clock

[PATCH v2 0/3] arm64: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-17 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This is v2 of my ROCK Pi E support series. Changes since v1: - Picked up Rob's Ack for the binding - Dropped comment about LED color - Dropped max-frequency from emmc node - Changed pingroup name from "ethernet-phy" to "ephy" to avoid DT bin

[PATCH v2 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-17 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Radxa ROCK Pi E is a router oriented SBC based on Rockchip's RK3328 SoC. As the official wiki page puts it, "E for Ethernets". It features the RK3328 SoC, gigabit and fast Ethernet RJ45 ports, both directly served by Ethernet controllers in the SoC, a USB 3.0

Re: [PATCH] ARM: dts: sun8i: h2-plus: bananapi-m2-zero: Increase BT UART speed

2021-01-16 Thread Chen-Yu Tsai
On Sat, Jan 16, 2021 at 6:37 PM Jernej Skrabec wrote: > > Bluetooth module on BananaPi M2 Zero can also be used for streaming > audio. However, for that case higher UART speed is required. > > Add a max-speed property. > > Signed-off-by: Jernej Skrabec Acked-by: Chen-Yu Tsai

Re: [linux-sunxi] [PATCH] ARM: dts: sunxi: bananapi-m2-plus: Increase BT UART speed

2021-01-16 Thread Chen-Yu Tsai
On Sat, Jan 16, 2021 at 6:52 PM Jernej Skrabec wrote: > > Bluetooth module on BananaPi M2 Plus can also be used for streaming > audio. However, for that case higher UART speed is required. > > Add a max-speed property. > > Signed-off-by: Jernej Skrabec Acked-by: Chen-Yu Tsai

Re: [linux-sunxi] Re: [PATCH v2 4/4] arm64: dts: allwinner: h6: Use RSB for AXP805 PMIC connection

2021-01-13 Thread Chen-Yu Tsai
On Thu, Jan 7, 2021 at 6:27 PM Samuel Holland wrote: > > On 1/6/21 5:38 AM, Chen-Yu Tsai wrote: > > On Wed, Jan 6, 2021 at 7:06 PM Maxime Ripard wrote: > >> > >> On Mon, Jan 04, 2021 at 10:54:19AM +, André Przywara wrote: > >>> On 03/01/2021 10:

Re: [linux-sunxi] [PATCH] arm64: dts: allwinner: h6: PineH64 model B: Add bluetooth

2021-01-13 Thread Chen-Yu Tsai
On Mon, Jan 11, 2021 at 5:16 AM Jernej Skrabec wrote: > > PineH64 model B has wifi+bt combo module. Wifi is already supported, so > lets add also bluetooth node. > > Signed-off-by: Jernej Skrabec Acked-by: Chen-Yu Tsai Looks good to me, though I couldn't find anything

Re: [PATCH v3 2/4] dt-bindings: arm: rockchip: Add FriendlyARM NanoPi M4B

2021-01-12 Thread Chen-Yu Tsai
On Wed, Jan 6, 2021 at 9:46 PM Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > The NanoPi M4B is a minor revision of the original M4. > > The differences against the original Nanopi M4 that are common with the > other M4V2 revision include: > > - microphone header

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-11 Thread Chen-Yu Tsai
On Mon, Jan 11, 2021 at 3:50 PM Heiko Stübner wrote: > > Am Montag, 11. Januar 2021, 04:27:47 CET schrieb Chen-Yu Tsai: > > On Mon, Jan 11, 2021 at 4:06 AM Heiko Stübner wrote: > > > > > > Hi, > > > > > > Am Sonntag, 10. Januar 2021, 16:37:15 CE

Re: [PATCH] arm64: dts: rockchip: rename pinctrl nodename to gmac2io for nanopi-r2s board

2021-01-10 Thread Chen-Yu Tsai
Hi Rob, On Mon, Jan 11, 2021 at 3:50 AM Johan Jonker wrote: > > A test with the command below gives this error: > /arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml: > ethernet-phy: 'reg' is a required property > > The pinctrl nodename "ethernet-phy" conflicts with the rules > in the

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Chen-Yu Tsai
On Mon, Jan 11, 2021 at 4:17 AM Johan Jonker wrote: > > Hi Chen-Yu, > > Most is already answered by Heiko. > > On 1/10/21 4:37 PM, Chen-Yu Tsai wrote: > > Hi, > > > > On Sun, Jan 10, 2021 at 10:45 PM Johan Jonker wrote: > >> > >> Hi Chen-Yu

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Chen-Yu Tsai
On Mon, Jan 11, 2021 at 4:06 AM Heiko Stübner wrote: > > Hi, > > Am Sonntag, 10. Januar 2021, 16:37:15 CET schrieb Chen-Yu Tsai: > > > > + vcc_sd: sdmmc-regulator { > > > > + compatible = "regulator-fixed"; > &g

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Chen-Yu Tsai
Hi, On Sun, Jan 10, 2021 at 10:45 PM Johan Jonker wrote: > > Hi Chen-Yu, > > Some comments, have a look if it is useful... > > On 1/10/21 4:58 AM, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > > > Radxa ROCK Pi E is a router oriented SBC based on Rockchip's

[PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Radxa ROCK Pi E is a router oriented SBC based on Rockchip's RK3328 SoC. As the official wiki page puts it, "E for Ethernets". It features the RK3328 SoC, gigabit and fast Ethernet RJ45 ports, both directly served by Ethernet controllers in the SoC, a USB 3.0

[PATCH 1/3] arm64: dts: rockchip: rk3328: Add clock_in_out property to gmac2phy node

2021-01-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The gmac2phy is integrated with the PHY within the SoC. Any properties related to this integration can be included in the .dtsi file, instead of having board dts files specify them separately. Add the clock_in_out property to specify the direction of the PHY clock

[PATCH 0/3] arm64: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This series adds support for the Radxa ROCK Pi E. This is a router oriented SBC based on Rockchip's RK3328 SoC. As the official wiki page puts it, "E for Ethernets". It features the RK3328 SoC, gigabit and fast Ethernet RJ45 ports, both direc

[PATCH 2/3] dt-bindings: arm: rockchip: Add Radxa ROCK Pi E

2021-01-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Radxa ROCK Pi E is a router oriented SBC based on Rockchip's RK3328 SoC. As the official wiki page puts it, "E for Ethernets". It features the RK3328 SoC, gigabit and fast Ethernet RJ45 ports, both directly served by Ethernet controllers in the SoC, a USB 3.0

[PATCH] staging: rtl8723bs: wifi_regd.c: Fix incorrect number of regulatory rules

2021-01-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The custom regulatory ruleset in the rtl8723bs driver lists an incorrect number of rules: one too many. This results in an out-of-bounds access, as detected by KASAN. This was possible thanks to the newly added support for KASAN on ARMv7. Fix this by filling in the correct

[PATCH v3 0/4] arm64: rockchip: Fix PCIe ep-gpios requirement and Add Nanopi M4B

2021-01-06 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This is v3 of my Nanopi M4B series. Changes since v2 include: - Replaced dev_err() with dev_err_probe() for gpiod_get_optional() error - Added Reviewed-by tag from Robin Murphy for patch 3 Changes since v1 include: - Rewrite subject of patch 1 to match

[PATCH v3 1/4] PCI: rockchip: Make 'ep-gpios' DT property optional

2021-01-06 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The Rockchip PCIe controller DT binding clearly states that 'ep-gpios' is an optional property. And indeed there are boards that don't require it. Make the driver follow the binding by using devm_gpiod_get_optional() instead of devm_gpiod_get(). Fixes: e77f847df54c (&quo

[PATCH v3 2/4] dt-bindings: arm: rockchip: Add FriendlyARM NanoPi M4B

2021-01-06 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The NanoPi M4B is a minor revision of the original M4. The differences against the original Nanopi M4 that are common with the other M4V2 revision include: - microphone header removed - power button added - recovery button added Additional changes specific to the M4B

[PATCH v3 4/4] arm64: dts: rockchip: rk3399: Add NanoPi M4B

2021-01-06 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The NanoPi M4B is a minor revision of the original M4. The differences against the original Nanopi M4 that are common with the other M4V2 revision include: - microphone header removed - power button added - recovery button added Additional changes specific to the M4B

[PATCH v3 3/4] arm64: dts: rockchip: nanopi4: Move ep-gpios property to nanopc-t4

2021-01-06 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Only the NanoPC T4 hs the PCIe reset pin routed to the SoC. For the NanoPi M4 family, no such signal is routed to the expansion header on the base board. As the schematics for the expansion board were not released, it is unclear how this is handled, but the likely answer

Re: [PATCH 0/4] bus: sunxi-rsb: Implement power managment

2021-01-06 Thread Chen-Yu Tsai
On Wed, Jan 6, 2021 at 6:50 PM Maxime Ripard wrote: > > Hi! > > On Sun, Jan 03, 2021 at 05:06:31AM -0600, Samuel Holland wrote: > > This series adds system (complete power down) and runtime (clock gate) > > PM hooks to the RSB controller driver. Tested on A64 and H6. > > > > Samuel Holland (4): >

Re: [PATCH v2 4/4] arm64: dts: allwinner: h6: Use RSB for AXP805 PMIC connection

2021-01-06 Thread Chen-Yu Tsai
On Wed, Jan 6, 2021 at 7:06 PM Maxime Ripard wrote: > > On Mon, Jan 04, 2021 at 10:54:19AM +, André Przywara wrote: > > On 03/01/2021 10:00, Samuel Holland wrote: > > > On boards where the only peripheral connected to PL0/PL1 is an X-Powers > > > PMIC, configure the connection to use the RSB

Re: [PATCH net-next 5/5] net: stmmac: dwmac-sun8i: Add a shutdown callback

2021-01-06 Thread Chen-Yu Tsai
". > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net-next 4/5] net: stmmac: dwmac-sun8i: Minor probe function cleanup

2021-01-06 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland wrote: > > Adjust the spacing and use an explicit "return 0" in the success path > to make the function easier to parse. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net-next 2/5] net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check

2021-01-06 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland wrote: > > sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered, > so there is no need to do it again here. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net-next 3/5] net: stmmac: dwmac-sun8i: Use reset_control_reset

2021-01-06 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland wrote: > > Use the appropriate function instead of reimplementing it, > and update the error message to match the code. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net-next 1/5] net: stmmac: dwmac-sun8i: Return void from PHY unpower

2021-01-06 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland wrote: > > This is a deinitialization function that always returned zero, and that > return value was always ignored. Have it return void instead. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH v2 2/4] pinctrl: sunxi: h6-r: Add s_rsb pin functions

2021-01-05 Thread Chen-Yu Tsai
On Wed, Jan 6, 2021 at 6:35 AM Linus Walleij wrote: > > On Sun, Jan 3, 2021 at 11:00 AM Samuel Holland wrote: > > > As there is an RSB controller in the H6 SoC, there should be some pin > > configuration for it. While no such configuration is documented, the > > "s_i2c" pins are suspiciously on

Re: [PATCH net 1/4] net: stmmac: dwmac-sun8i: Fix probe error handling

2021-01-04 Thread Chen-Yu Tsai
: stmmac: Add dwmac-sun8i") > Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in > exit path") > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net 2/4] net: stmmac: dwmac-sun8i: Balance internal PHY resource references

2021-01-04 Thread Chen-Yu Tsai
gt; removal callback. Also ensure the EPHY is powered down before removal. > > Fixes: 634db83b8265 ("net: stmmac: dwmac-sun8i: Handle integrated/external > MDIOs") > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH 0/4] bus: sunxi-rsb: Implement power managment

2021-01-04 Thread Chen-Yu Tsai
letions(-) Looks good to me. Acked-by: Chen-Yu Tsai I already queued them up locally, but I think it's best to give other people some time to review as well. ChenYu

Re: [linux-sunxi] [PATCH v2 0/4] Allwinner H6 RSB support

2021-01-04 Thread Chen-Yu Tsai
e pushed out until that happens. Regarding patch 3, I replaced the clock and reset macros with raw numbers to get rid of cross-tree dependencies. The following fix will be posted for v5.12 later on during its RC cycle. >8 ---- commit 0b4781666adc5e

Re: [linux-sunxi] [PATCH v2 2/4] pinctrl: sunxi: h6-r: Add s_rsb pin functions

2021-01-03 Thread Chen-Yu Tsai
th no > primary function 2 given. This suggests the primary function for these > pins is actually RSB, and that is indeed the case. > > Add the "s_rsb" pin functions so the RSB controller can be used. > > Signed-off-by: Samuel Holland Acked-by: Chen-Yu Tsai

Re: [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list

2020-12-30 Thread Chen-Yu Tsai
On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche wrote: > > All revisions of the PinePhone share most of the hardware. > This patch makes it easier to detect PinePhone hardware without > having to check for each possible revision. Sounds good. > Signed-off-by: Dylan Van Assche > --- >

Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition

2020-12-29 Thread Chen-Yu Tsai
On Tue, Dec 22, 2020 at 4:17 PM Jernej Škrabec wrote: > > Hi! > > Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a): > > This adds a device-tree definition for the CSI0 MCLK pin, > > which can be used for feeding MIPI CSI-2 sensors. > > > > Signed-off-by: Paul

Re: [linux-sunxi] Re: [PATCH RESEND] ARM: configs: sunxi: enable brcm wireless

2020-12-27 Thread Chen-Yu Tsai
On Mon, Dec 28, 2020 at 4:03 AM Jernej Škrabec wrote: > > Hi! > > Dne nedelja, 27. december 2020 ob 21:00:00 CET je Corentin Labbe napisal(a): > > Lot of sunxi boards have BRCM wireless device, so let's enable necessary > > options for it in our defconfig. > > Idea is good but modules (=m)

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Chen-Yu Tsai
On Wed, Dec 16, 2020 at 4:16 AM Christophe JAILLET wrote: > > Le 15/12/2020 à 20:35, Dan Carpenter a écrit : > > On Tue, Dec 15, 2020 at 08:08:15PM +0100, Maxime Ripard wrote: > >> On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: > >>> Le 15/12/2020 à 12:37, Maxime Ripard a

Re: [linux-sunxi] Re: [PATCH v2 19/21] arm64: dts: allwinner: Add Allwinner H616 .dtsi file

2020-12-14 Thread Chen-Yu Tsai
On Mon, Dec 14, 2020 at 8:53 PM Andre Przywara wrote: > > On Mon, 14 Dec 2020 10:58:31 +0100 > Maxime Ripard wrote: > > Hi, > > > On Fri, Dec 11, 2020 at 01:19:32AM +, Andre Przywara wrote: > > > + reserved-memory { > > > + #address-cells = <2>; > > > + #size-cells =

Re: [PATCH 2/8] pinctrl: sunxi: Add support for the Allwinner H616 pin controller

2020-12-14 Thread Chen-Yu Tsai
On Mon, Dec 14, 2020 at 12:28 AM Icenowy Zheng wrote: > > 在 2020-12-02星期三的 13:54 +,Andre Przywara写道: > > Port A is used for an internal connection to some analogue circuitry > > which looks like an AC200 IP (as in the H6), though this is not > > mentioned in the manual. > > When developing

Re: [PATCH v2 1/4] PCI: rockchip: Make 'ep-gpios' DT property optional

2020-12-12 Thread Chen-Yu Tsai
On Mon, Dec 7, 2020 at 10:11 PM Rob Herring wrote: > > On Wed, Nov 18, 2020 at 1:17 AM Chen-Yu Tsai wrote: > > > > From: Chen-Yu Tsai > > > > The Rockchip PCIe controller DT binding clearly states that 'ep-gpios' is > > an optional property. And indeed

Re: [PATCH V2 3/3] arm64: dts: allwinner: a100: Add CPU Operating Performance Points table

2020-12-07 Thread Chen-Yu Tsai
On Mon, Dec 7, 2020 at 5:20 PM Shuosheng Huang wrote: > > Add an Operating Performance Points table for the CPU cores to > enable Dynamic Voltage & Frequency Scaling on the A100. > > Signed-off-by: Shuosheng Huang > --- > .../allwinner/sun50i-a100-allwinner-perf1.dts | 5 ++ >

Re: [PATCH v2 1/4] PCI: rockchip: Make 'ep-gpios' DT property optional

2020-12-06 Thread Chen-Yu Tsai
Ping On Wed, Nov 18, 2020 at 4:49 PM Heiko Stübner wrote: > > Am Mittwoch, 18. November 2020, 08:17:21 CET schrieb Chen-Yu Tsai: > > From: Chen-Yu Tsai > > > > The Rockchip PCIe controller DT binding clearly states that 'ep-gpios' is > > an optional propert

Re: [PATCH v2] regulatx DLDO2 voltage control register mask for AXP22x

2020-12-04 Thread Chen-Yu Tsai
On Sat, Dec 5, 2020 at 1:40 AM Mark Brown wrote: > > On Fri, Dec 04, 2020 at 10:34:21AM +0800, Chen-Yu Tsai wrote: > > On Thu, Dec 3, 2020 at 12:11 AM Mark Brown wrote: > > > > No, no sign. You can check if things are at least hitting the list at: > > > &

[PATCH] arm64: dts: rockchip: rk3328: Fix UART pull-ups

2020-12-03 Thread Chen-Yu Tsai
From: Chen-Yu Tsai For UARTs, the local pull-ups should be on the RX pin, not the TX pin. UARTs transmit active-low, so a disconnected RX pin should be pulled high instead of left floating to prevent noise being interpreted as transmissions. This gets rid of bogus sysrq events when the UART

Re: [PATCH v2] ARM: dts: sun8i: v3s: SRAM_C real mapping

2020-12-03 Thread Chen-Yu Tsai
On Fri, Dec 4, 2020 at 2:15 AM Martin Cerveny wrote: > > VideoEngine (cedrus) needs assign dedicated SRAM for decoding. > SRAM_C1 is usually used for Allwinner platforms. > Allwinner V3s scale down chip has not SRAM_C1 but only small SRAM_C (44kB). > > Result of additional testing: > > SRAM_C is

Re: [PATCH v2] regulatx DLDO2 voltage control register mask for AXP22x

2020-12-03 Thread Chen-Yu Tsai
On Thu, Dec 3, 2020 at 12:11 AM Mark Brown wrote: > > On Thu, Dec 03, 2020 at 12:04:05AM +0800, dinghua ma wrote: > > I sent a new email. I don’t know if you received it. The subject is "[PATCH > > v3] regulator: axp20x: Fix DLDO2 voltage control register mask for AXP22x" > > No, no sign. You

Re: [PATCH v3 3/6] ARM: dts: sun8i: v3s: Add node for system control

2020-12-03 Thread Chen-Yu Tsai
On Fri, Dec 4, 2020 at 12:25 AM Martin Cerveny wrote: > > Hello. > > On Thu, 3 Dec 2020, Chen-Yu Tsai wrote: > > > Hi, > > > > On Mon, Nov 16, 2020 at 8:57 PM Martin Cerveny > > wrote: > >> > >> Allwinner V3s has system control and SRAM

Re: [linux-sunxi] Re: [PATCH 7/8] arm64: dts: allwinner: Add Allwinner H616 .dtsi file

2020-12-03 Thread Chen-Yu Tsai
On Thu, Dec 3, 2020 at 11:45 PM André Przywara wrote: > > On 03/12/2020 15:02, Chen-Yu Tsai wrote: > > On Thu, Dec 3, 2020 at 6:54 PM André Przywara > > wrote: > >> > >> On 03/12/2020 03:16, Samuel Holland wrote: > >> > >> H

Re: [linux-sunxi] Re: [PATCH 7/8] arm64: dts: allwinner: Add Allwinner H616 .dtsi file

2020-12-03 Thread Chen-Yu Tsai
On Thu, Dec 3, 2020 at 6:54 PM André Przywara wrote: > > On 03/12/2020 03:16, Samuel Holland wrote: > > Hi, > > > On 12/2/20 7:54 AM, Andre Przywara wrote: > > ... > >> +soc { > >> +compatible = "simple-bus"; > >> +#address-cells = <1>; > >> +#size-cells =

Re: [PATCH v3 3/6] ARM: dts: sun8i: v3s: Add node for system control

2020-12-02 Thread Chen-Yu Tsai
Hi, On Mon, Nov 16, 2020 at 8:57 PM Martin Cerveny wrote: > > Allwinner V3s has system control and SRAM C1 region similar to H3. > > Signed-off-by: Martin Cerveny > --- > arch/arm/boot/dts/sun8i-v3s.dtsi | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git

[PATCH 3/3] arm64: dts: rockchip: rk3328-roc-cc: Enable analog audio

2020-11-25 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Now that driver support for the RK3328's audio codec, and the plumbing is defined at the SoC level, we can enable analog audio at the board level. Enable analog audio by enabling the codec and the I2S interface connected and the simple-audio-card that binds them together

[PATCH 2/3] arm64: dts: rockchip: rk3328-roc-cc: Enable HDMI audio

2020-11-25 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The RK3328-ROC-CC already has HDMI display output enabled. Now that audio for the HDMI controller is supported, it can be enabled as well. Enable the simple-audio-card, and the I2S interface the audio is fed from. Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts

  1   2   3   4   5   6   7   8   9   10   >