[PATCH v2] ASoC: hdmi-codec: Get ELD in before reporting plugged event

2020-11-17 Thread Cheng-Yi Chiang
-Yi Chiang --- Change from v1 to v2: - Report jack unplug event then clear ELD. This makes sure user will not get a cleared ELD during their usage of jack. sound/soc/codecs/hdmi-codec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/hdmi-codec.c

[PATCH] ASoC: hdmi-codec: Get ELD in before reporting plugged event

2020-11-17 Thread Cheng-Yi Chiang
-Yi Chiang --- sound/soc/codecs/hdmi-codec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index 403d4c6a49a8..f0e0e1836000 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c

[PATCH] ASoC: qcom: sc7180: Add missing PM ops

2020-11-09 Thread Cheng-Yi Chiang
Use PM ops snd_soc_pm_ops to handle suspend/resume like other machine drivers. Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/sc7180.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/sc7180.c b/sound/soc/qcom/sc7180.c index b391f64c3a80..42e366ecc689 100644 --- a/sound/soc

[PATCH v12 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-10-26 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- Changes from v11 to v12 - Machine driver

[PATCH v12 1/2] ASoC: google: dt-bindings: Add sc7180-trogdor machine bindings

2020-10-26 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- Changes from v11 to v12 - Documentation: - Change the file and title name for new compatible string google,sc7180-trogdor. - Change the example of model name. .../bindings/sound/google

[PATCH v12 0/2] Add documentation and machine driver for SC7180 sound card

2020-10-26 Thread Cheng-Yi Chiang
Note: - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit Pandey But Ajit has left codeaurora. Changes from v1 to v2: - Ducumentation: Addressed all suggestions from Doug. - Machine driver: - Fix comment style for license. - Sort includes

Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-10-23 Thread Cheng-yi Chiang
Sorry for resending this mail. I forgot to use plain text mode in the previous mail. On Thu, Oct 22, 2020 at 6:12 PM Srinivas Kandagatla wrote: > > > > On 22/10/2020 04:29, Tzung-Bi Shih wrote: > > Hi, sorry for jumping into your discussion but I am trying to > > summarize them to make sure we

Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-10-20 Thread Cheng-yi Chiang
On Tue, Oct 20, 2020 at 10:55 PM Srinivas Kandagatla wrote: > > > > On 20/10/2020 15:37, Mark Brown wrote: > > I don't understand what "logic scattered in various dtsi files" means, > > sorry. > > > >> Yes, that should work to describe the dailink we are using. > >> But a more tricky issue is how

Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-10-20 Thread Cheng-yi Chiang
On Tue, Oct 20, 2020 at 10:37 PM Mark Brown wrote: > > On Tue, Oct 20, 2020 at 09:37:05PM +0800, Cheng-yi Chiang wrote: > > > May I know your suggestion on Ajye's patch "ASoC: qcom: sc7180: Modify > > machine driver for 2mic" ? > > > https://lore.kern

Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-10-20 Thread Cheng-yi Chiang
On Fri, Oct 16, 2020 at 12:13 AM Mark Brown wrote: > > On Thu, Oct 15, 2020 at 03:59:26PM +0800, Cheng-yi Chiang wrote: > > On Tue, Oct 13, 2020 at 6:36 PM Srinivas Kandagatla > > > > > +properties: > > > > + compatible: > > > >

Re: [PATCH v11 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-10-15 Thread Cheng-yi Chiang
On Tue, Oct 13, 2020 at 11:50 AM Cheng-yi Chiang wrote: > > On Mon, Sep 14, 2020 at 4:06 PM Cheng-Yi Chiang wrote: > > > > From: Ajit Pandey > > > > Add new driver to register sound card on sc7180 trogdor board and > > do the required configuration f

Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-10-15 Thread Cheng-yi Chiang
On Tue, Oct 13, 2020 at 6:36 PM Srinivas Kandagatla wrote: > > Hi Cheng, > > Sorry for such late review w.r.t compatibles, > Hi Srini, Thank you for taking another look! > On 14/09/2020 09:06, Cheng-Yi Chiang wrote: > > +--- > > +$id:http://devicetree.org/

Re: [PATCH v11 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-10-12 Thread Cheng-yi Chiang
On Mon, Sep 14, 2020 at 4:06 PM Cheng-Yi Chiang wrote: > > From: Ajit Pandey > > Add new driver to register sound card on sc7180 trogdor board and > do the required configuration for lpass cpu dai and external codecs > connected over MI2S interfaces. > > Signed-off-by: A

Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-10-12 Thread Cheng-yi Chiang
On Tue, Sep 15, 2020 at 8:44 PM Cheng-yi Chiang wrote: > > On Tue, Sep 15, 2020 at 1:48 AM Rob Herring wrote: > > > > On Mon, 14 Sep 2020 16:06:18 +0800, Cheng-Yi Chiang wrote: > > > Add devicetree bindings documentation file for sc7180 sound card. > > >

[PATCH] ASoC: hdmi-codec: Use set_jack ops to set jack

2020-09-22 Thread Cheng-Yi Chiang
Use set_jack ops to set jack so machine drivers do not need to include hdmi-codec.h explicitly. Signed-off-by: Cheng-Yi Chiang Reviewed-by: Tzung-Bi Shih --- Separate this patch from the machine driver patch series at https://patchwork.kernel.org/cover/11773209/ in the hope that this can

Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-15 Thread Cheng-yi Chiang
On Tue, Sep 15, 2020 at 1:48 AM Rob Herring wrote: > > On Mon, 14 Sep 2020 16:06:18 +0800, Cheng-Yi Chiang wrote: > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > .../bindings/so

[PATCH v11 0/3] Add documentation and machine driver for SC7180 sound card

2020-09-14 Thread Cheng-Yi Chiang
Note: - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit Pandey But Ajit has left codeaurora. - This patch series needs HDMI DAI name SC7180_LPASS_DP defined in sc7180-lpass.h. It will be posted in the newer patchset of https

[PATCH v11 1/3] ASoC: hdmi-codec: Use set_jack ops to set jack

2020-09-14 Thread Cheng-Yi Chiang
Use set_jack ops to set jack so machine drivers do not need to include hdmi-codec.h explicitly. Signed-off-by: Cheng-Yi Chiang Reviewed-by: Tzung-Bi Shih --- include/sound/hdmi-codec.h | 3 --- sound/soc/codecs/hdmi-codec.c| 12

[PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-14 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 130 ++ 1 file changed, 130 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH v11 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-09-14 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 12 ++ sound/soc

[PATCH v10 1/3] ASoC: hdmi-codec: Use set_jack ops to set jack

2020-09-11 Thread Cheng-Yi Chiang
Use set_jack ops to set jack so machine drivers do not need to include hdmi-codec.h explicitly. Signed-off-by: Cheng-Yi Chiang Reviewed-by: Tzung-Bi Shih --- include/sound/hdmi-codec.h | 3 --- sound/soc/codecs/hdmi-codec.c| 12

[PATCH v10 0/3] Add documentation and machine driver for SC7180 sound card

2020-09-11 Thread Cheng-Yi Chiang
Note: - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit Pandey But Ajit has left codeaurora. - This patch series needs HDMI DAI name SC7180_LPASS_DP defined in sc7180-lpass.h. It will be posted in the newer patchset of https

[PATCH v10 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-11 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 130 ++ 1 file changed, 130 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH v10 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-09-11 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 12 ++ sound/soc

Re: [PATCH v9 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-09-11 Thread Cheng-yi Chiang
On Fri, Sep 11, 2020 at 11:01 PM Stephan Gerhold wrote: > > Hi, > > Thanks for removing the weird use of auxilliary devices :) > Hi Stephan, Thanks for the suggestion! > On Fri, Sep 11, 2020 at 06:22:59PM +0800, Cheng-Yi Chiang wrote: > > From: Ajit Pandey > >

Re: [PATCH v9 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-09-11 Thread Cheng-yi Chiang
On Fri, Sep 11, 2020 at 7:05 PM Srinivas Kandagatla wrote: > > > > On 11/09/2020 11:22, Cheng-Yi Chiang wrote: > > From: Ajit Pandey > > > > Add new driver to register sound card on sc7180 trogdor board and > > do the required configuration for lpass cpu d

[PATCH v9 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-11 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 130 ++ 1 file changed, 130 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH v9 0/3] Add documentation and machine driver for SC7180 sound card

2020-09-11 Thread Cheng-Yi Chiang
Note: - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit Pandey But Ajit has left codeaurora. - This patch series needs HDMI DAI name defined in sc7180-lpass.h. https://patchwork.kernel.org/patch/11745565/ Changes from v1 to v2

[PATCH v9 1/3] ASoC: hdmi-codec: Use set_jack ops to set jack

2020-09-11 Thread Cheng-Yi Chiang
Use set_jack ops to set jack so machine drivers do not need to include hdmi-codec.h explicitly. Signed-off-by: Cheng-Yi Chiang Reviewed-by: Tzung-Bi Shih --- include/sound/hdmi-codec.h | 3 --- sound/soc/codecs/hdmi-codec.c| 12

[PATCH v9 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-09-11 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 12 ++ sound/soc

[PATCH v8 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-09-09 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 12 ++ sound/soc

[PATCH v8 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-09 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 130 ++ 1 file changed, 130 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH v8 1/3] ASoC: hdmi-codec: Use set_jack ops to set jack

2020-09-09 Thread Cheng-Yi Chiang
Use set_jack ops to set jack so machine drivers do not need to include hdmi-codec.h explicitly. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h | 3 --- sound/soc/codecs/hdmi-codec.c| 12 sound/soc/mediatek/mt8173

[PATCH v8 0/3] Add documentation and machine driver for SC7180 sound card

2020-09-09 Thread Cheng-Yi Chiang
Note: - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit Pandey But Ajit has left codeaurora. - This patch series needs HDMI DAI name defined in sc7180-lpass.h. https://patchwork.kernel.org/patch/11745565/ Changes from v1 to v2

Re: [PATCH v7 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-09 Thread Cheng-yi Chiang
On Thu, Sep 10, 2020 at 1:49 AM Rob Herring wrote: > > On Wed, Sep 9, 2020 at 3:24 AM Cheng-yi Chiang wrote: > > > > On Wed, Sep 9, 2020 at 4:34 AM Rob Herring wrote: > > > > > > On Mon, Sep 07, 2020 at 06:00:38PM +0800, Cheng-Yi Chiang wrote: > > >

Re: [PATCH v7 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-09 Thread Cheng-yi Chiang
On Wed, Sep 9, 2020 at 5:23 PM Cheng-yi Chiang wrote: > > On Wed, Sep 9, 2020 at 4:34 AM Rob Herring wrote: > > > > On Mon, Sep 07, 2020 at 06:00:38PM +0800, Cheng-Yi Chiang wrote: > > > Add devicetree bindings documentation file for sc7180 sound card. > > >

Re: [PATCH v7 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-09 Thread Cheng-yi Chiang
On Wed, Sep 9, 2020 at 4:34 AM Rob Herring wrote: > > On Mon, Sep 07, 2020 at 06:00:38PM +0800, Cheng-Yi Chiang wrote: > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > .../bindings/so

[PATCH v7 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-09-07 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang Reviewed-by: Tzung-Bi Shih --- sound/soc/qcom

[PATCH v7 0/3] Add documentation and machine driver for SC7180 sound card

2020-09-07 Thread Cheng-Yi Chiang
Note: - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit Pandey But Ajit has left codeaurora. - This patch series needs HDMI DAI name defined in sc7180-lpass.h. https://patchwork.kernel.org/patch/11745565/ Changes from v1 to v2

[PATCH v7 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-09-07 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 143 ++ 1 file changed, 143 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH v7 1/3] ASoC: hdmi-codec: Use set_jack ops to set jack

2020-09-07 Thread Cheng-Yi Chiang
Use set_jack ops to set jack so machine drivers do not need to include hdmi-codec.h explicitly. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h | 3 --- sound/soc/codecs/hdmi-codec.c| 12 sound/soc/mediatek/mt8173

Re: [PATCH] ASoC: rt5682: Prefer async probe

2020-08-30 Thread Cheng-yi Chiang
On Sat, Aug 29, 2020 at 7:20 AM Douglas Anderson wrote: > > The probe of rt5682 is pretty slow. A quick measurement shows that it > takes ~650 ms on at least one board. There's no reason to block all > other drivers waiting for this probe to finish. Set the flag to allow > other drivers to

Re: [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-08-27 Thread Cheng-yi Chiang
On Wed, Aug 26, 2020 at 10:48 PM Stephan Gerhold wrote: > > On Wed, Aug 26, 2020 at 07:04:54PM +0800, Cheng-Yi Chiang wrote: > > From: Ajit Pandey > > > > Add new driver to register sound card on sc7180 trogdor board and > > do the required configuration for lpa

Re: [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-08-26 Thread Cheng-yi Chiang
On Wed, Aug 26, 2020 at 7:05 PM Cheng-Yi Chiang wrote: > > From: Ajit Pandey > > Add new driver to register sound card on sc7180 trogdor board and > do the required configuration for lpass cpu dai and external codecs > connected over MI2S interfaces. > > Signed-off-by: A

[PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-08-26 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang Reviewed-by: Tzung-Bi Shih --- sound/soc/qcom

[PATCH v6 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-08-26 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 124 ++ 1 file changed, 124 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH v6 0/2] Add documentation and machine driver for SC7180 sound card

2020-08-26 Thread Cheng-Yi Chiang
Note: - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit Pandey But Ajit has left codeaurora. Changes from v1 to v2: - Ducumentation: Addressed all suggestions from Doug. - Machine driver: - Fix comment style for license. - Sort includes

[PATCH v5 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-08-17 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 127 ++ 1 file changed, 127 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH v5 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-08-17 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang Reviewed-by: Tzung-Bi Shih --- sound/soc/qcom

[PATCH v5 0/2] Add documentation and machine driver for SC7180 sound card

2020-08-17 Thread Cheng-Yi Chiang
Note: - The machine driver patch depends on LPASS patch series so it is not ready to be merged now. ASoC: qcom: Add support for SC7180 lpass variant https://patchwork.kernel.org/cover/11714317/ - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit

Re: [PATCH v3 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-08-03 Thread Cheng-yi Chiang
On Sat, Aug 1, 2020 at 2:32 AM Rob Herring wrote: > > On Fri, Jul 31, 2020 at 04:40:22PM +0800, Cheng-Yi Chiang wrote: > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > .../bindings/so

Re: [PATCH v3 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-08-03 Thread Cheng-yi Chiang
On Sat, Aug 1, 2020 at 2:27 AM Rob Herring wrote: > > On Fri, 31 Jul 2020 16:40:22 +0800, Cheng-Yi Chiang wrote: > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > .../bindings/so

[PATCH v4 0/2] Add documentation and machine driver for SC7180 sound card

2020-08-02 Thread Cheng-Yi Chiang
Note: - The machine driver patch depends on LPASS patch series so it is not ready to be merged now. ASoC: qcom: Add support for SC7180 lpass variant https://patchwork.kernel.org/cover/11678133/ - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit

[PATCH v4 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-08-02 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang Reviewed-by: Tzung-Bi Shih --- sound/soc/qcom

[PATCH v4 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-08-02 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 113 ++ 1 file changed, 113 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-07-31 Thread Cheng-yi Chiang
On Fri, Jul 24, 2020 at 2:45 AM Stephan Gerhold wrote: > > On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > > +static int sc7180_parse_of(struct snd_soc_card *card) > > > +{ > > > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > > it will be

Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-07-31 Thread Cheng-yi Chiang
On Wed, Jul 22, 2020 at 5:25 PM Srinivas Kandagatla wrote: > > Few comments apart from Tzung-Bi comments, > Thanks a lot for reviewing the patch! > On 21/07/2020 11:44, Cheng-Yi Chiang wrote: > > From: Ajit Pandey > > > > Add new driver to register sound card on s

Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-07-31 Thread Cheng-yi Chiang
On Wed, Jul 22, 2020 at 11:15 AM Tzung-Bi Shih wrote: > > On Tue, Jul 21, 2020 at 6:44 PM Cheng-Yi Chiang wrote: > > diff --git a/sound/soc/qcom/sc7180.c b/sound/soc/qcom/sc7180.c > > new file mode 100644 > > index ..3beb2b129d01 > > --- /dev/null >

Re: [PATCH v2 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-07-31 Thread Cheng-yi Chiang
On Wed, Jul 22, 2020 at 5:25 PM Srinivas Kandagatla wrote: > > > > On 21/07/2020 11:44, Cheng-Yi Chiang wrote: > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > .../bindi

[PATCH v3 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-07-31 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 113 ++ 1 file changed, 113 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH v3 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-07-31 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 12 ++ sound/soc

[PATCH v3 0/2] Add documentation and machine driver for SC7180 sound card

2020-07-31 Thread Cheng-Yi Chiang
Note: - The machine driver patch depends on LPASS patch series so it is not ready to be merged now. ASoC: qcom: Add support for SC7180 lpass variant https://patchwork.kernel.org/cover/11678133/ - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit

Re: [PATCH] ASoC: Intel: Atom: use hardware counter to update hw_ptr

2020-07-28 Thread Cheng-yi Chiang
On Wed, Jul 29, 2020 at 1:31 AM Pierre-Louis Bossart wrote: > > > > On 7/28/20 12:02 PM, Lu, Brent wrote: > >> > >> So if there are already quirks in atom machine drivers to change the period > >> size, why is this patch necessary? > >> > > > > The story is: google implemented the constraint but

Re: [PATCH 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-07-21 Thread Cheng-yi Chiang
Hi Tzung-Bi, Thanks for the review! On Mon, Jul 20, 2020 at 10:47 AM Tzung-Bi Shih wrote: > > On Fri, Jul 17, 2020 at 8:02 PM Cheng-Yi Chiang wrote: > > diff --git a/sound/soc/qcom/sc7180.c b/sound/soc/qcom/sc7180.c > > new file mode 100644 > > index ..cbe6b4

Re: [PATCH 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-07-21 Thread Cheng-yi Chiang
On Fri, Jul 17, 2020 at 11:03 PM Doug Anderson wrote: > > Hi, > Thanks for the review! > On Fri, Jul 17, 2020 at 5:02 AM Cheng-Yi Chiang wrote: > > > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang

[PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-07-21 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 11 ++ sound/soc/qcom/Makefile | 2 + sound

[PATCH v2 0/2] Add documentation and machine driver for SC7180 sound card

2020-07-21 Thread Cheng-Yi Chiang
Note: - The machine driver patch depends on LPASS patch series so it is not ready to be merged now. ASoC: qcom: Add support for SC7180 lpass variant https://patchwork.kernel.org/cover/11650649/ - The machine driver patch is made by the collaboration of Cheng-Yi Chiang Rohit kumar Ajit

[PATCH v2 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-07-21 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 130 ++ 1 file changed, 130 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-07-17 Thread Cheng-Yi Chiang
From: Ajit Pandey Add new driver to register sound card on sc7180 trogdor board and do the required configuration for lpass cpu dai and external codecs connected over MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- Note: - This patch depends on this patch series

[PATCH 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-07-17 Thread Cheng-Yi Chiang
Add devicetree bindings documentation file for sc7180 sound card. Signed-off-by: Cheng-Yi Chiang --- .../bindings/sound/qcom,sc7180.yaml | 123 ++ 1 file changed, 123 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml diff --git

[PATCH] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver

2020-07-16 Thread Cheng-Yi Chiang
From: Ajit Pandey Add the I2S controller node to sc7180 dtsi. Add pinmux for pirmary and secondary I2S. Signed-off-by: Ajit Pandey Signed-off-by: Cheng-Yi Chiang --- This patch depends on these patch series so it is not ready to be merged now. - clk: qcom: Support for Low Power Audio Clocks

Re: [PATCH] pinctrl: qcom: Handle broken PDC dual edge case on sc7180

2020-07-13 Thread Cheng-yi Chiang
only ever letting our parent see > requests for single edge interrupts on affected hardware. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Douglas Anderson Tested-by: Cheng-Yi Chiang > > --- > As far as I can tell everythi

Re: [PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-13 Thread Cheng-yi Chiang
On Wed, Oct 9, 2019 at 10:05 PM Srinivas Kandagatla wrote: > > > > On 08/10/2019 16:14, Stephen Boyd wrote: > >> 3) As my use case does not use device tree, it is hard for ASoC > >> machine to access nvmem device. I am wondering if I can use > >> nvm_cell_lookup so machine driver can find the

Re: [PATCH v2] firmware: vpd: Add an interface to read VPD value

2019-10-08 Thread Cheng-yi Chiang
On Tue, Oct 8, 2019 at 8:06 PM Greg Kroah-Hartman wrote: > > On Tue, Oct 08, 2019 at 06:11:44PM +0800, Cheng-Yi Chiang wrote: > > Add an interface for other driver to query VPD value. > > This will be used for ASoC machine driver to query calibration > > data stored in

[PATCH v2] firmware: vpd: Add an interface to read VPD value

2019-10-08 Thread Cheng-Yi Chiang
static int load_calibration_data(struct cml_card_private *ctx) { char *data = NULL; int ret; u32 value_len; /* Read calibration data from VPD. */ ret = vpd_attribute_read(1, DSM_CALIB_KEY, (u8 **), _len); /* Parsing of this string...*/ } Signed-off-by: Cheng

Re: [PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-07 Thread Cheng-yi Chiang
On Mon, Oct 7, 2019 at 11:35 PM Stephen Boyd wrote: > > Quoting Cheng-yi Chiang (2019-10-07 06:58:41) > > > > Hi Guenter, > > Thanks for the quick review. > > I'll update accordingly in v2. > > I'd prefer this use the nvmem framework which already handles many

Re: [PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-07 Thread Cheng-yi Chiang
On Mon, Oct 7, 2019 at 8:27 PM Guenter Roeck wrote: > > On 10/7/19 1:03 AM, Tzung-Bi Shih wrote: > > On Mon, Oct 7, 2019 at 3:16 PM Cheng-Yi Chiang > > wrote: > >> > >> Add an interface for other driver to query VPD value. > >> This will be used

Re: [PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-07 Thread Cheng-yi Chiang
On Mon, Oct 7, 2019 at 4:03 PM Tzung-Bi Shih wrote: > > On Mon, Oct 7, 2019 at 3:16 PM Cheng-Yi Chiang wrote: > > > > Add an interface for other driver to query VPD value. > > This will be used for ASoC machine driver to query calibration > > data stored in V

[PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-07 Thread Cheng-Yi Chiang
Add an interface for other driver to query VPD value. This will be used for ASoC machine driver to query calibration data stored in VPD for smart amplifier speaker resistor calibration. Signed-off-by: Cheng-Yi Chiang --- drivers/firmware/google/vpd.c | 16 include

[PATCH v7 1/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-09-19 Thread Cheng-Yi Chiang
atform device can register the callback. When connector plug/unplug event happens, report this event using the callback. Make sure that audio and drm are using the single source of truth for connector status. Signed-off-by: Cheng-Yi Chiang --- .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c

[PATCH v7 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-09-19 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- .../boot/dts/rk3288-veyron-analog-audio.dtsi | 1 + sound/soc/rockchip/rockchip_max98090.c| 129 ++ 2 files

[PATCH v7 0/4] Add HDMI jack support on RK3288

2019-09-19 Thread Cheng-Yi Chiang
. With this we don't need to set fixed id for the created hdmi-audio-codec device. Cheng-Yi Chiang (4): drm: bridge: dw-hdmi: Report connector status using callback ASoC: rockchip-max98090: Add description for rockchip,hdmi-codec ASoC: rockchip_max98090: Add dai_link for HDMI ASoC

[PATCH v6 4/4] ASoC: rockchip_max98090: Add HDMI jack support

2019-09-18 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 ++- sound/soc/rockchip/rockchip_max98090.c | 20 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc

[PATCH v6 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-09-18 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 96 -- 1 file changed, 73 insertions(+), 23 deletions(-) diff --git a/sound

[PATCH] ASoC: rockchip: rockchip_max98090: Set period size to 240

2019-08-13 Thread Cheng-Yi Chiang
ize is small. Set constraint of period size to 240 to prevent such issue. With the constraint, there will be no issue after 2000 iterations. We can revert this patch once the root cause is found in rockchip's pl330 implementation. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockc

Re: [PATCH] Revert "ASoC: rockchip: i2s: Support mono capture"

2019-07-26 Thread Cheng-yi Chiang
On Fri, Jul 26, 2019 at 7:17 PM Mark Brown wrote: > > On Fri, Jul 26, 2019 at 12:42:02PM +0800, Cheng-Yi Chiang wrote: > > This reverts commit db51707b9c9aeedd310ebce60f15d5bb006567e0. > > > > Previous discussion in > > Please use subject lines matching the style fo

[PATCH v2] ASoC: rockchip: i2s: Revert "ASoC: rockchip: i2s: Support mono capture"

2019-07-26 Thread Cheng-Yi Chiang
nels. When user space reads the data and assumes it is a mono stream, the rate will be slowed down. Revert the change so the DAI no longer claims that mono capture is supported. Fixes: db51707b9c9a ("ASoC: rockchip: i2s: Support mono capture") Signed-off-by: Cheng-Yi Chiang ---

[PATCH] Revert "ASoC: rockchip: i2s: Support mono capture"

2019-07-25 Thread Cheng-Yi Chiang
-ch stream, the rate will be slower by 2x. Revert the change so 1-ch is not supported. User space can selectively take one channel data out of two channel if 1-ch is preferred. Currently, both channels record identical data. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_i2s.c

Re: [PATCH v3 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-16 Thread Cheng-yi Chiang
On Fri, Jul 12, 2019 at 6:48 PM Russell King - ARM Linux admin wrote: > > On Fri, Jul 12, 2019 at 06:04:40PM +0800, Cheng-Yi Chiang wrote: > > Allow codec driver register callback function for plug event. > > > > The callback registration flow: > > dw-hdmi <---

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-21 Thread Cheng-yi Chiang
On Fri, Jun 21, 2019 at 5:12 AM Daniel Vetter wrote: > > Massively cutting this thread, since halfway through in my previous reply > I realized that maybe hdmi_codec is a much better starting point. > ACK > On Thu, Jun 20, 2019 at 09:23:23PM +0800, Cheng-yi Chiang wrote: > >

Re: [alsa-devel] [PATCH] ASoC: DA7219: Fix failure in hw_params by not letting set_rate error out

2019-04-22 Thread Cheng-yi Chiang
Hi Akshu, On Mon, Apr 22, 2019 at 2:15 PM Agrawal, Akshu wrote: > > We need to set minimum bclk 64x of wclk as this is hw constraint in one > of the component used. > Since, clk_set_rate and clk is enabled in machine driver the > clk_set_rate in hw_params of da7219 fails and errors out and when

Re: [PATCH 3/3] ASoC: qcom: add i2c dependency for SND_SOC_SDM845

2019-03-04 Thread Cheng-yi Chiang
t; config SND_SOC_SDM845 > tristate "SoC Machine driver for SDM845 boards" > - depends on QCOM_APR && MFD_CROS_EC > + depends on QCOM_APR && MFD_CROS_EC && I2C > select SND_SOC_QDSP6 > select SND_SOC_QCOM_COMMON > select SND_SOC_RT5663 > -- > 2.20.0 > Hi Arnd, Thank you for the fix. Acked-by: Cheng-Yi Chiang

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-25 Thread Cheng-yi Chiang
On Mon, Feb 25, 2019 at 8:23 PM Enric Balletbo i Serra wrote: > > Hi Cheng-yi, > > Attached the config that Randy sent. > > Thanks, > Enric Hi Enric, Thanks for the quick reply. I have posted a patch to fix it. > On 25/2/19 11:22, Cheng-yi Chiang wrote: > > O

[PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845

2019-02-25 Thread Cheng-Yi Chiang
SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC. Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies warning. Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845) Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-25 Thread Cheng-yi Chiang
> > > Hi, > > > > on linux-next of 20190222, I now see this build error + Kconfig warnings: > > > > (this is on i386; randconfig file is attached) > > > > WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC > > Depends on [n]: SOUND

[PATCH] ASoC: qcom: Kconfig: select dmic for sdm845

2019-02-17 Thread Cheng-Yi Chiang
sdm845 uses dmic on EC so it should select CROS_EC_CODEC. Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 7948e993adba..8f206cb4fcc0 100644 --- a/sound/soc/qcom/Kconfig +++ b

Re: [PATCH -next] ASoC: cros_ec_codec: Make symbol 'cros_ec_dai' static

2019-02-12 Thread Cheng-yi Chiang
On Wed, Feb 13, 2019 at 2:16 PM Wei Yongjun wrote: > > Fixes the following sparse warning: > > sound/soc/codecs/cros_ec_codec.c:209:27: warning: > symbol 'cros_ec_dai' was not declared. Should it be static? > > Fixes: b291f42a3718 ("ASoC: cros_ec_codec: Add codec driver for Cros EC") >

Re: [PATCH v3 1/3] mfd: cros_ec: Add commands to control codec

2019-01-28 Thread Cheng-yi Chiang
On Mon, Jan 28, 2019 at 2:50 PM Lee Jones wrote: > > On Mon, 28 Jan 2019, Cheng-yi Chiang wrote: > > > Hi Lee, > > Could you please give Mark a tag so he can merge ? > > The later patch for cros_ec_codec driver is pending on it. > > Apologies for not getti

Re: [PATCH v4 2/2] ASoC: cros_ec_codec: Add codec driver for Cros EC

2019-01-19 Thread Cheng-yi Chiang
Hi Mark, Sorry, I forgot to mention that the patch for EC command definition has been already merged in upstream, but not in Mark's for-next tree yet. c1f3375be60c mfd: cros_ec: Add commands to control codec This is needed. Thanks! On Sat, Jan 19, 2019 at 7:34 PM Cheng-Yi Chiang wrote

[PATCH v4 1/2] ASoC: Documentation: Add google,cros-ec-codec

2019-01-19 Thread Cheng-Yi Chiang
Add documentation for Chrome EC codec driver. Signed-off-by: Cheng-Yi Chiang --- Change in v4: - Add a property max-dmic-gain so we can configure maximum gain on dmic. - Add Guenter to the reviewer list. .../bindings/sound/google,cros-ec-codec.txt | 26 +++ MAINTAINERS

  1   2   >