Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-21 Thread Cho KyongHo
Hi Brain, On Wed, Aug 19, 2020 at 02:22:04PM +0100, Brian Starkey wrote: > Hi KyongHo, > > On Wed, Aug 19, 2020 at 12:46:26PM +0900, Cho KyongHo wrote: > > I have seriously considered CPA in our product but we developed our own > > because of the pool in CPA. >

Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-18 Thread Cho KyongHo
On Tue, Aug 18, 2020 at 11:55:57AM +0100, Brian Starkey wrote: > Hi, > > On Tue, Aug 18, 2020 at 05:04:12PM +0900, Hyesoo Yu wrote: > > These patch series to introduce a new dma heap, chunk heap. > > That heap is needed for special HW that requires bulk allocation of > > fixed high order pages.

Re: [PATCH 1/2] dma-mapping: introduce relaxed version of dma sync

2020-08-18 Thread Cho KyongHo
On Tue, Aug 18, 2020 at 05:10:06PM +0100, Christoph Hellwig wrote: > On Tue, Aug 18, 2020 at 11:07:57AM +0100, Will Deacon wrote: > > > > so I'm not sure > > > > that we should be complicating the implementation like this to try to > > > > make it "fast". > > > > > > > I agree that this patch

Re: [PATCH 1/2] dma-mapping: introduce relaxed version of dma sync

2020-08-18 Thread Cho KyongHo
On Tue, Aug 18, 2020 at 11:07:57AM +0100, Will Deacon wrote: > On Tue, Aug 18, 2020 at 06:37:39PM +0900, Cho KyongHo wrote: > > On Tue, Aug 18, 2020 at 09:28:53AM +0100, Will Deacon wrote: > > > On Tue, Aug 18, 2020 at 04:43:10PM +0900, Cho KyongHo wrote: > > > >

Re: [PATCH 1/2] dma-mapping: introduce relaxed version of dma sync

2020-08-18 Thread Cho KyongHo
On Tue, Aug 18, 2020 at 09:37:20AM +0100, Christoph Hellwig wrote: > On Tue, Aug 18, 2020 at 09:28:53AM +0100, Will Deacon wrote: > > On Tue, Aug 18, 2020 at 04:43:10PM +0900, Cho KyongHo wrote: > > > Cache maintenance operations in the most of CPU architectures needs > >

Re: [PATCH 1/2] dma-mapping: introduce relaxed version of dma sync

2020-08-18 Thread Cho KyongHo
On Tue, Aug 18, 2020 at 09:28:53AM +0100, Will Deacon wrote: > On Tue, Aug 18, 2020 at 04:43:10PM +0900, Cho KyongHo wrote: > > Cache maintenance operations in the most of CPU architectures needs > > memory barrier after the cache maintenance for the DMAs to view the > >

Re: [PATCH] mm: sort freelist by rank number

2020-08-18 Thread Cho KyongHo
On Mon, Aug 10, 2020 at 09:32:18AM +0200, David Hildenbrand wrote: > On 07.08.20 09:08, Pekka Enberg wrote: > > Hi Cho and David, > > > > On Mon, Aug 3, 2020 at 10:57 AM David Hildenbrand wrote: > >> > >> On 03.08.20 08:10, pullip....@sam

[PATCH 1/2] dma-mapping: introduce relaxed version of dma sync

2020-08-18 Thread Cho KyongHo
() which do not involve memory barrier. So the users called those functions require explicitly calling arch_sync_barrier_for_device() and arch_sync_barrier_for_cpu(), respectively to confirm the view of memory is consistent between the CPUs and DMAs. Signed-off-by: Cho KyongHo --- drivers/iommu/dma

[PATCH 2/2] arm64: dma-mapping: add relaxed DMA sync

2020-08-18 Thread Cho KyongHo
6a9356234 ("dma-mapping: introduce relaxed version of dma sync") to reduce redundant memory barriers in sg versions of DMA sync API. Implementing relaxed version of DMA sync API will dramatically increase the performance of dma_sync_sg_for_{device|cpu}(). Signed-off-by: Cho KyongHo ---

Re: [PATCH] mm: sort freelist by rank number

2020-08-04 Thread Cho KyongHo
On Tue, Aug 04, 2020 at 11:12:55AM +0200, Vlastimil Babka wrote: > On 8/4/20 4:35 AM, Cho KyongHo wrote: > > On Mon, Aug 03, 2020 at 05:45:55PM +0200, Vlastimil Babka wrote: > >> On 8/3/20 9:57 AM, David Hildenbrand wrote: > >> > On 03.08.20 08:10, pullip@samsun

Re: [PATCH] mm: sort freelist by rank number

2020-08-03 Thread Cho KyongHo
On Mon, Aug 03, 2020 at 05:45:55PM +0200, Vlastimil Babka wrote: > On 8/3/20 9:57 AM, David Hildenbrand wrote: > > On 03.08.20 08:10, pullip@samsung.com wrote: > >> From: Cho KyongHo > >> > >> LPDDR5 introduces rank switch delay. If three successive DRAM

Re: [PATCH] mm: sort freelist by rank number

2020-08-03 Thread Cho KyongHo
Hi, On Mon, Aug 03, 2020 at 09:57:10AM +0200, David Hildenbrand wrote: > On 03.08.20 08:10, pullip@samsung.com wrote: > > From: Cho KyongHo > > > > LPDDR5 introduces rank switch delay. If three successive DRAM accesses > > happens and the first and the

RE: [PATCH] [media] v4l: vb2-memops: use vma slab when vma allocation

2015-04-08 Thread Cho KyongHo
-Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Thursday, April 09, 2015 1:01 AM Mauro, Please revert this patch: vm_area_cachep is not exported, so you cannot use this in a module. Cho KyongHo, if you believe that vm_area_cachep should be exported so it can be used here

RE: [PATCH] [media] v4l: vb2-memops: use vma slab when vma allocation

2015-04-08 Thread Cho KyongHo
-Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Thursday, April 09, 2015 1:01 AM Mauro, Please revert this patch: vm_area_cachep is not exported, so you cannot use this in a module. Cho KyongHo, if you believe that vm_area_cachep should be exported so it can be used here

[PATCH] [media] v4l: vb2-memops: use vma slab when vma allocation

2015-02-04 Thread Cho KyongHo
The slab for vm_area_struct which is vm_area_cachep is already prepared for the general use. Instead of kmalloc() for the vma copy for userptr, allocation from vm_area_cachep is more beneficial. CC: Mauro Carvalho Chehab CC: Hans Verkuil CC: Laurent Pinchart Signed-off-by: Cho KyongHo

[PATCH] [media] v4l: vb2-memops: use vma slab when vma allocation

2015-02-04 Thread Cho KyongHo
Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/media/v4l2-core/videobuf2-memops.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-memops.c b/drivers/media/v4l2-core/videobuf2

Re: [PATCH] iommu/exynos: Select ARM_DMA_USE_IOMMU

2014-07-04 Thread Cho KyongHo
" > depends on ARCH_EXYNOS > select IOMMU_API > + select ARM_DMA_USE_IOMMU > help > Support for the IOMMU (System MMU) of Samsung Exynos application > processor family. This enables H/W multimedia accelerators to see > -- Reviewe

Re: [PATCH] iommu/exynos: Select ARM_DMA_USE_IOMMU

2014-07-04 Thread Cho KyongHo
select IOMMU_API + select ARM_DMA_USE_IOMMU help Support for the IOMMU (System MMU) of Samsung Exynos application processor family. This enables H/W multimedia accelerators to see -- Reviewed-by: Cho KyongHo pullip@samsung.com' Thank you. KyongHo -- To unsubscribe

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-17 Thread Cho KyongHo
On Fri, 16 May 2014 14:23:18 +0200, Thierry Reding wrote: > From: Thierry Reding > > This commit introduces a generic device tree binding for IOMMU devices. > Only a very minimal subset is described here, but it is enough to cover > the requirements of both the Exynos System MMU and Tegra SMMU

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-17 Thread Cho KyongHo
On Fri, 16 May 2014 14:23:18 +0200, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com This commit introduces a generic device tree binding for IOMMU devices. Only a very minimal subset is described here, but it is enough to cover the requirements of both the Exynos System MMU and

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-05-15 Thread Cho KyongHo
On Thu, 15 May 2014 22:37:31 +0200, Thierry Reding wrote: > On Mon, Apr 28, 2014 at 02:05:30PM +0200, Arnd Bergmann wrote: > [...] > > let me clarify by example: > > > > iommu@1 { > > compatible = "some,simple-iommu"; > > reg = <1>; > > #iommu-cells = <0>;

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-05-15 Thread Cho KyongHo
On Thu, 15 May 2014 22:37:31 +0200, Thierry Reding wrote: On Mon, Apr 28, 2014 at 02:05:30PM +0200, Arnd Bergmann wrote: [...] let me clarify by example: iommu@1 { compatible = some,simple-iommu; reg = 1; #iommu-cells = 0; /* supports only one

Re: [PATCH v12 18/31] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-05-09 Thread Cho KyongHo
On Tue, 06 May 2014 20:05:14 +0200, Tomasz Figa wrote: > On 27.04.2014 09:37, Shaik Ameer Basha wrote: > > From: Cho KyongHo > > > > Some master device descriptor like fimc-is which is an abstraction > > of very complex H/W may have multiple System MMUs. For th

Re: [PATCH v12 18/31] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-05-09 Thread Cho KyongHo
On Tue, 06 May 2014 20:05:14 +0200, Tomasz Figa wrote: On 27.04.2014 09:37, Shaik Ameer Basha wrote: From: Cho KyongHo pullip@samsung.com Some master device descriptor like fimc-is which is an abstraction of very complex H/W may have multiple System MMUs. For those devices

Re: [PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-05-06 Thread Cho KyongHo
On Tue, 06 May 2014 20:08:47 +0200, Tomasz Figa wrote: > On 06.05.2014 19:59, Joerg Roedel wrote: > > On Wed, Apr 30, 2014 at 04:27:10PM +0530, Shaik Ameer Basha wrote: > >> This series is going on for quite a long time and most of the patches here > >> doesn't depend on dt bindings. As Exynos

Re: [PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-05-06 Thread Cho KyongHo
On Tue, 06 May 2014 20:08:47 +0200, Tomasz Figa wrote: On 06.05.2014 19:59, Joerg Roedel wrote: On Wed, Apr 30, 2014 at 04:27:10PM +0530, Shaik Ameer Basha wrote: This series is going on for quite a long time and most of the patches here doesn't depend on dt bindings. As Exynos IOMMU h/w is

Re: [PATCH v12 30/31] ARM: dts: add System MMU nodes of exynos5250

2014-05-01 Thread Cho KyongHo
On Mon, 28 Apr 2014 16:13:19 -0700, Doug Anderson wrote: > Vikas, > > > On Sun, Apr 27, 2014 at 10:39 AM, Vikas Sajjan wrote: > > Hi shaik, > > > > +Doug, Abhilash, > > > > On Sun, Apr 27, 2014 at 1:08 PM, Shaik Ameer Basha > > wrote: >

Re: [PATCH v12 18/31] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-05-01 Thread Cho KyongHo
On Mon, 28 Apr 2014 16:08:14 +0530, Tushar Behera wrote: > On 04/27/2014 01:07 PM, Shaik Ameer Basha wrote: > > From: Cho KyongHo > > > > Some master device descriptor like fimc-is which is an abstraction > > of very complex H/W may have multiple System MMUs. For th

Re: [PATCH v12 15/31] iommu/exynos: handle 'mmu-masters' property of DT and improve handling sysmmu

2014-05-01 Thread Cho KyongHo
On Sun, 27 Apr 2014 20:17:48 +0200, Arnd Bergmann wrote: > On Sunday 27 April 2014 13:07:47 Shaik Ameer Basha wrote: > > @@ -542,14 +592,41 @@ static int __init exynos_sysmmu_probe(struct > > platform_device *pdev) > > } > > } > > > > + /* Relation between master and System

Re: [PATCH v12 15/31] iommu/exynos: handle 'mmu-masters' property of DT and improve handling sysmmu

2014-05-01 Thread Cho KyongHo
On Sun, 27 Apr 2014 20:17:48 +0200, Arnd Bergmann wrote: On Sunday 27 April 2014 13:07:47 Shaik Ameer Basha wrote: @@ -542,14 +592,41 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev) } } + /* Relation between master and System MMU is 1:1. */

Re: [PATCH v12 18/31] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-05-01 Thread Cho KyongHo
On Mon, 28 Apr 2014 16:08:14 +0530, Tushar Behera wrote: On 04/27/2014 01:07 PM, Shaik Ameer Basha wrote: From: Cho KyongHo pullip@samsung.com Some master device descriptor like fimc-is which is an abstraction of very complex H/W may have multiple System MMUs. For those devices

Re: [PATCH v12 30/31] ARM: dts: add System MMU nodes of exynos5250

2014-05-01 Thread Cho KyongHo
On Mon, 28 Apr 2014 16:13:19 -0700, Doug Anderson wrote: Vikas, On Sun, Apr 27, 2014 at 10:39 AM, Vikas Sajjan sajjan.li...@gmail.com wrote: Hi shaik, +Doug, Abhilash, On Sun, Apr 27, 2014 at 1:08 PM, Shaik Ameer Basha shaik.am...@samsung.com wrote: From: Cho KyongHo pullip

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-04-22 Thread Cho KyongHo
On Tue, 22 Apr 2014 18:53:51 +0530, Shaik Ameer Basha wrote: > Hi KyongHo Cho, > > > > On Fri, Mar 14, 2014 at 10:40 AM, Cho KyongHo wrote: > > Some master device descriptor like fimc-is which is an abstraction > > of very complex H/W may have multiple Sys

Re: [PATCH v11 12/27] ARM: dts: Add description of System MMU of Exynos SoCs

2014-04-22 Thread Cho KyongHo
On Sun, 20 Apr 2014 15:25:59 +0530, Shaik Ameer Basha wrote: > Hi KyongHo Cho, > > Please find the comments inline. > > On Fri, Mar 14, 2014 at 10:36 AM, Cho KyongHo wrote: > > This patch adds dts entries for the System MMU devices found on > > Exynos4 and Exynos5 So

Re: [PATCH v11 12/27] ARM: dts: Add description of System MMU of Exynos SoCs

2014-04-22 Thread Cho KyongHo
On Sun, 20 Apr 2014 15:25:59 +0530, Shaik Ameer Basha wrote: Hi KyongHo Cho, Please find the comments inline. On Fri, Mar 14, 2014 at 10:36 AM, Cho KyongHo pullip@samsung.com wrote: This patch adds dts entries for the System MMU devices found on Exynos4 and Exynos5 SoC series

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-04-22 Thread Cho KyongHo
On Tue, 22 Apr 2014 18:53:51 +0530, Shaik Ameer Basha wrote: Hi KyongHo Cho, On Fri, Mar 14, 2014 at 10:40 AM, Cho KyongHo pullip@samsung.com wrote: Some master device descriptor like fimc-is which is an abstraction of very complex H/W may have multiple System MMUs. For those

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Cho KyongHo
On Thu, 20 Mar 2014 11:54:58 +0100, Tomasz Figa wrote: > On 20.03.2014 11:22, Cho KyongHo wrote: > > On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: > >> On 19.03.2014 14:20, Tomasz Figa wrote: > >>> On 19.03.2014 01:39, Cho KyongHo wrote: > >>>&g

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Cho KyongHo
On Thu, 20 Mar 2014 11:44:50 +0100, Tomasz Figa wrote: > On 20.03.2014 11:03, Cho KyongHo wrote: > > On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: > >> On 19.03.2014 10:01, Sachin Kamat wrote: > >>> On 19 March 2014 14:29, Cho KyongHo wrote: > >&g

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 19:51:21 +0100, Tomasz Figa wrote: > On 19.03.2014 19:37, Grant Grundler wrote: > > On Wed, Mar 19, 2014 at 10:30 AM, Tomasz Figa wrote: > > ... > >> As I said, AFAIK the trend is to get rid of ordering by initcalls and make > >> sure that drivers can handle missing

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 09:54:39 -0700, Grant Grundler wrote: > On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote: > ... > >> Device driver is not only for the scholarship but also for the real use. > > > > Huh? I'm not sure what kind of comment is this. > > I'm guessing Cho meant: "This isn't an

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: > On 19.03.2014 14:20, Tomasz Figa wrote: > > On 19.03.2014 01:39, Cho KyongHo wrote: > >> On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: > >>> > >>> > >>> On 18.03.2014 14:01,

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: > On 19.03.2014 10:01, Sachin Kamat wrote: > > On 19 March 2014 14:29, Cho KyongHo wrote: > >> On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: > >>> On 18.03.2014 12:09, Cho KyongHo wrote: > >&g

Re: [PATCH v11 24/27] iommu/exynos: use exynos-iommu specific typedef

2014-03-20 Thread Cho KyongHo
On Tue, 18 Mar 2014 18:33:20 -0700, Grant Grundler wrote: > On Thu, Mar 13, 2014 at 10:13 PM, Cho KyongHo wrote: > > This commit introduces sysmmu_pte_t for page table entries and > > sysmmu_iova_t vor I/O virtual address that is manipulated by > > exynos-iommu driver. The p

Re: [PATCH v11 24/27] iommu/exynos: use exynos-iommu specific typedef

2014-03-20 Thread Cho KyongHo
On Tue, 18 Mar 2014 18:33:20 -0700, Grant Grundler wrote: On Thu, Mar 13, 2014 at 10:13 PM, Cho KyongHo pullip@samsung.com wrote: This commit introduces sysmmu_pte_t for page table entries and sysmmu_iova_t vor I/O virtual address that is manipulated by exynos-iommu driver. The purpose

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: On 19.03.2014 10:01, Sachin Kamat wrote: On 19 March 2014 14:29, Cho KyongHo pullip@samsung.com wrote: On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar 2014 20:52:43

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 09:54:39 -0700, Grant Grundler wrote: On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa t.f...@samsung.com wrote: ... Device driver is not only for the scholarship but also for the real use. Huh? I'm not sure what kind of comment is this. I'm guessing Cho meant: This

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 19:51:21 +0100, Tomasz Figa wrote: On 19.03.2014 19:37, Grant Grundler wrote: On Wed, Mar 19, 2014 at 10:30 AM, Tomasz Figa t.f...@samsung.com wrote: ... As I said, AFAIK the trend is to get rid of ordering by initcalls and make sure that drivers can handle missing

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Cho KyongHo
On Thu, 20 Mar 2014 11:44:50 +0100, Tomasz Figa wrote: On 20.03.2014 11:03, Cho KyongHo wrote: On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: On 19.03.2014 10:01, Sachin Kamat wrote: On 19 March 2014 14:29, Cho KyongHo pullip@samsung.com wrote: On Tue, 18 Mar 2014 16:14:53

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Cho KyongHo
On Thu, 20 Mar 2014 11:54:58 +0100, Tomasz Figa wrote: On 20.03.2014 11:22, Cho KyongHo wrote: On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote

Re: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-19 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:33:04 +0100, Tomasz Figa wrote: > On 18.03.2014 12:23, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 17:07:53 +0100, Tomasz Figa wrote: > >> Hi KyongHo, > >> > >> On 14.03.2014 06:10, Cho KyongHo wrote: > > [snip] >

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-19 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:25:11 +0100, Tomasz Figa wrote: > On 18.03.2014 11:52, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 14:39:33 +0100, Tomasz Figa wrote: > >>> @@ -557,11 +558,23 @@ static int exynos_sysmmu_probe(struct > >>> platform_devic

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: > On 18.03.2014 12:09, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: > >> Hi KyongHo, > >> > >> On 14 March 2014 10:35, Cho KyongHo wrote: > >>> This patch u

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Cho KyongHo
On Wed, 19 Mar 2014 08:59:09 +0900, Jingoo Han wrote: > On Wednesday, March 19, 2014 12:12 AM, Tomasz Figa wrote: > > On 18.03.2014 11:38, Cho KyongHo wrote: > > > On Fri, 14 Mar 2014 14:28:36 +0100, Tomasz Figa wrote: > > >> On 14.03.2014 06:05, Cho KyongHo wrote: &

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-19 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:46:24 +0530, Sachin Kamat wrote: > On 18 March 2014 16:44, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 20:57:42 +0530, Sachin Kamat wrote: > >> Hi KyongHo, > >> > >> On 14 March 2014 10:39, Cho KyongHo wrote: > >> > > >&

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-19 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:46:24 +0530, Sachin Kamat wrote: On 18 March 2014 16:44, Cho KyongHo pullip@samsung.com wrote: On Fri, 14 Mar 2014 20:57:42 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:39, Cho KyongHo pullip@samsung.com wrote: -static struct

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Cho KyongHo
On Wed, 19 Mar 2014 08:59:09 +0900, Jingoo Han wrote: On Wednesday, March 19, 2014 12:12 AM, Tomasz Figa wrote: On 18.03.2014 11:38, Cho KyongHo wrote: On Fri, 14 Mar 2014 14:28:36 +0100, Tomasz Figa wrote: On 14.03.2014 06:05, Cho KyongHo wrote: This patch uses managed device helper

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo pullip@samsung.com wrote: This patch uses managed device helper functions

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-19 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:25:11 +0100, Tomasz Figa wrote: On 18.03.2014 11:52, Cho KyongHo wrote: On Fri, 14 Mar 2014 14:39:33 +0100, Tomasz Figa wrote: @@ -557,11 +558,23 @@ static int exynos_sysmmu_probe(struct platform_device *pdev) return 0; } -static struct

Re: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-19 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:33:04 +0100, Tomasz Figa wrote: On 18.03.2014 12:23, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:07:53 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: [snip] @@ -677,11 +679,40 @@ static int __init exynos_sysmmu_probe(struct

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-18 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:09:50 +0100, Tomasz Figa wrote: > On 18.03.2014 10:56, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 13:59:00 +0100, Tomasz Figa wrote: > >> Hi KyongHo, > >> > >> On 14.03.2014 06:08, Cho KyongHo wrote: > > [snip] > >

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-18 Thread Cho KyongHo
On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: > > > On 18.03.2014 14:01, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: > >> Hi KyongHo, > >> > >> On 14.03.2014 06:10, Cho KyongHo wrote: > >>

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:10, Cho KyongHo wrote: > > Some master device descriptor like fimc-is which is an abstraction > > of very complex H/W may have multiple System MMUs. For those devices, > > the

Re: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 17:07:53 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:10, Cho KyongHo wrote: > > This adds support for Suspend to RAM and Runtime Power Management. > > > > Since System MMU is located in the same local power domain of its >

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 20:57:42 +0530, Sachin Kamat wrote: > Hi KyongHo, > > On 14 March 2014 10:39, Cho KyongHo wrote: > > This commit adds device tree support for System MMU. > > > > Signed-off-by: Cho KyongHo > > --- > > drivers/iommu/Kconfig

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: > Hi KyongHo, > > On 14 March 2014 10:35, Cho KyongHo wrote: > > This patch uses managed device helper functions in the probe(). > > > > Signed-off-by: Cho KyongHo > > --- > [snip] > > >

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 22:27:59 +0530, Sachin Kamat wrote: > Hi KyongHo, > > On 14 March 2014 19:13, Tomasz Figa wrote: > > Hi KyongHo, > > > > > > On 14.03.2014 06:09, Cho KyongHo wrote: > >> > >> exynos-iommu driver must care about master H/W's

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 14:39:33 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:09, Cho KyongHo wrote: > > This commit adds device tree support for System MMU. > > > > Signed-off-by: Cho KyongHo > > --- > > drivers/iommu/Kconfig|5 +

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 14:28:36 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:05, Cho KyongHo wrote: > > This patch uses managed device helper functions in the probe(). > > > > Signed-off-by: Cho KyongHo > > --- > >

Re: [PATCH v11 08/27] iommu/exynos: always use a single clock descriptor

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 14:07:32 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:05, Cho KyongHo wrote: > > System MMU driver is changed to control only a single instance of > > System MMU at a time. Since a single instance of System MMU has only > > a sing

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 13:59:00 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:08, Cho KyongHo wrote: > > Runtime power management by exynos-iommu driver independently from > > master H/W's runtime pm is not useful for power saving since attaching > > maste

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 13:59:00 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:08, Cho KyongHo wrote: Runtime power management by exynos-iommu driver independently from master H/W's runtime pm is not useful for power saving since attaching master H/W in probing time turns on its

Re: [PATCH v11 08/27] iommu/exynos: always use a single clock descriptor

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 14:07:32 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:05, Cho KyongHo wrote: System MMU driver is changed to control only a single instance of System MMU at a time. Since a single instance of System MMU has only a single clock descriptor for its clock gating

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 14:28:36 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:05, Cho KyongHo wrote: This patch uses managed device helper functions in the probe(). Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 64

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 14:39:33 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: This commit adds device tree support for System MMU. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/Kconfig|5 ++--- drivers/iommu/exynos

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 22:27:59 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 19:13, Tomasz Figa t.f...@samsung.com wrote: Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: exynos-iommu driver must care about master H/W's gate clock as well as System MMU's gate clock

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo pullip@samsung.com wrote: This patch uses managed device helper functions in the probe(). Signed-off-by: Cho KyongHo pullip@samsung.com --- [snip] + data-clk

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 20:57:42 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:39, Cho KyongHo pullip@samsung.com wrote: This commit adds device tree support for System MMU. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/Kconfig|5

Re: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 17:07:53 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: This adds support for Suspend to RAM and Runtime Power Management. Since System MMU is located in the same local power domain of its master H/W, System MMU must be initialized

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-18 Thread Cho KyongHo
On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some master device descriptor like fimc-is which is an abstraction of very complex H/W may have multiple System MMUs. For those devices, the design of the link between System MMU

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-18 Thread Cho KyongHo
On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some master device descriptor like fimc-is which is an abstraction of very

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-18 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:09:50 +0100, Tomasz Figa wrote: On 18.03.2014 10:56, Cho KyongHo wrote: On Fri, 14 Mar 2014 13:59:00 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:08, Cho KyongHo wrote: [snip] -static bool __exynos_sysmmu_disable(struct sysmmu_drvdata *data

Re: [PATCH v11 12/27] ARM: dts: Add description of System MMU of Exynos SoCs

2014-03-16 Thread Cho KyongHo
On Fri, 14 Mar 2014 13:20:23 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:06, Cho KyongHo wrote: > > This patch adds dts entries for the System MMU devices found on > > Exynos4 and Exynos5 SoC series and the System MMU binding > > documentation. >

Re: [PATCH v11 11/27] clk: exynos: add gate clock descriptions of System MMU

2014-03-16 Thread Cho KyongHo
On Fri, 14 Mar 2014 13:17:26 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:06, Cho KyongHo wrote: > > This adds gate clocks of all System MMUs and their master IPs > > that are not apeared in clk-exynos5250.c and clk-exynos5420.c > > Also fixes GATE_IP

Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-16 Thread Cho KyongHo
On Fri, 14 Mar 2014 17:29:36 +0530, Sachin Kamat wrote: > On 14 March 2014 17:19, Cho KyongHo wrote: > >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > >> Sent: Friday, March 14, 2014 7:00 PM > >> > >> On 14 March 2014 10:31, Cho KyongHo wrote

Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-16 Thread Cho KyongHo
On Fri, 14 Mar 2014 17:29:36 +0530, Sachin Kamat wrote: On 14 March 2014 17:19, Cho KyongHo pullip@samsung.com wrote: From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Friday, March 14, 2014 7:00 PM On 14 March 2014 10:31, Cho KyongHo pullip@samsung.com wrote: Commit

Re: [PATCH v11 11/27] clk: exynos: add gate clock descriptions of System MMU

2014-03-16 Thread Cho KyongHo
On Fri, 14 Mar 2014 13:17:26 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:06, Cho KyongHo wrote: This adds gate clocks of all System MMUs and their master IPs that are not apeared in clk-exynos5250.c and clk-exynos5420.c Also fixes GATE_IP_ACP to 0x18800 and changed GATE_DA

Re: [PATCH v11 12/27] ARM: dts: Add description of System MMU of Exynos SoCs

2014-03-16 Thread Cho KyongHo
On Fri, 14 Mar 2014 13:20:23 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:06, Cho KyongHo wrote: This patch adds dts entries for the System MMU devices found on Exynos4 and Exynos5 SoC series and the System MMU binding documentation. CC: Rob Herring robherri...@gmail.com

RE: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Cho KyongHo
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Friday, March 14, 2014 7:00 PM > > On 14 March 2014 10:31, Cho KyongHo wrote: > > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from > > exynos tree) removed arch/arm/mach-exynos/mach

RE: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Cho KyongHo
From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Friday, March 14, 2014 7:00 PM On 14 March 2014 10:31, Cho KyongHo pullip@samsung.com wrote: Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header

[PATCH v11 27/27] iommu/exynos: enhanced error messages

2014-03-13 Thread Cho KyongHo
Some redundant error message is removed and some error messages are changed to error level from debug level. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b

[PATCH v11 25/27] iommu/exynos: use simpler function to get MMU version

2014-03-13 Thread Cho KyongHo
This commit changes the function to get MMU version simpler. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 30 ++ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index

[PATCH v11 26/27] iommu/exynos: apply workaround of caching fault page table entries

2014-03-13 Thread Cho KyongHo
ntries. This is the size between 256K ~ 384K. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 164 +- 1 file changed, 147 insertions(+), 17 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 3d4dabb..4888383

[PATCH v11 24/27] iommu/exynos: use exynos-iommu specific typedef

2014-03-13 Thread Cho KyongHo
This commit introduces sysmmu_pte_t for page table entries and sysmmu_iova_t vor I/O virtual address that is manipulated by exynos-iommu driver. The purpose of the typedef is to remove dependencies to the driver code from the change of CPU architecture from 32 bit to 64 bit. Signed-off-by: Cho

[PATCH v11 23/27] iommu/exynos: fix address handling

2014-03-13 Thread Cho KyongHo
Use of __pa and __va macro is changed to virt_to_phys and phys_to_virt which are recommended in driver code. printk formatting of physical address is also fixed to %pa. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 45 +++--- 1 file changed

[PATCH v11 22/27] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2014-03-13 Thread Cho KyongHo
Patch written by Antonios Motakis : IOMMU groups are expected by certain users of the IOMMU API, e.g. VFIO. Since each device is behind its own System MMU, we can allocate a new IOMMU group for each device. Reviewd-by: Cho KyongHo Signed-off-by: Antonios Motakis --- drivers/iommu/exynos

[PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-13 Thread Cho KyongHo
domain, its driver must call iommu_attach_device() after its local power domain is turned on, iommu_detach_device before turned off. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 220 ++ 1 file changed, 201 insertions(+), 19 deletions

[PATCH v11 21/27] iommu/exynos: change rwlock to spinlock

2014-03-13 Thread Cho KyongHo
Since acquiring read_lock is not more frequent than write_lock, it is not beneficial to use rwlock, this commit changes rwlock to spinlock. Reviewed-by: Grant Grundler Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 39 --- 1 file changed, 20

[PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-13 Thread Cho KyongHo
to master H/W and that has a pointer to the device descriptor of a System MMU. Given a device descriptor of a master H/W, it is possible to traverse all System MMUs that must be controlled along with the master H/W. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 534

[PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-13 Thread Cho KyongHo
exynos-iommu driver must care about master H/W's gate clock as well as System MMU's gate clock. To enhance readability of the source code, macros to gate/ungate those clocks are defined. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 34 ++ 1

  1   2   3   4   5   6   >