[BUG] ACPI Error: Needed type [Reference], found [Integer]

2017-02-27 Thread Chris Bainbridge
Latest Linux git has ACPI errors on Macbook IVB: [0.333133] ACPI Error: Needed type [Reference], found [Integer] 880261656f30 (20170119/exresop-103) [0.333141] ACPI Exception: AE_AML_OPERAND_TYPE, While resolving operands for [Store] (20170119/dswexec-461) [0.333150] ACPI Error:

[BUG] ACPI Error: Needed type [Reference], found [Integer]

2017-02-27 Thread Chris Bainbridge
Latest Linux git has ACPI errors on Macbook IVB: [0.333133] ACPI Error: Needed type [Reference], found [Integer] 880261656f30 (20170119/exresop-103) [0.333141] ACPI Exception: AE_AML_OPERAND_TYPE, While resolving operands for [Store] (20170119/dswexec-461) [0.333150] ACPI Error:

Re: [Intel-gfx] [v4.6-10530-g28165ec7a99b] i915: *ERROR* "CPU pipe/PCH transcoder" A FIFO underrun

2016-05-27 Thread Chris Bainbridge
On 25 May 2016 at 08:31, Sedat Dilek wrote: > Hi Daniel, > > with latest Linus Git I see this with my Intel SandyBridge GPU... > > [ 17.629014] [drm:intel_cpu_fifo_underrun_irq_handler [i915]] > *ERROR* CPU pipe A FIFO underrun > [ 17.630652]

Re: [Intel-gfx] [v4.6-10530-g28165ec7a99b] i915: *ERROR* "CPU pipe/PCH transcoder" A FIFO underrun

2016-05-27 Thread Chris Bainbridge
On 25 May 2016 at 08:31, Sedat Dilek wrote: > Hi Daniel, > > with latest Linus Git I see this with my Intel SandyBridge GPU... > > [ 17.629014] [drm:intel_cpu_fifo_underrun_irq_handler [i915]] > *ERROR* CPU pipe A FIFO underrun > [ 17.630652] [drm:intel_set_pch_fifo_underrun_reporting [i915]]

[PATCH v3] usb: core: hub: hub_port_init lock controller instead of bus

2016-04-25 Thread Chris Bainbridge
/2/8/312 Link: https://lkml.org/lkml/2016/2/4/748 Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- This is technically the same as the last patch version, but with a reworked commit message to better explain the cause of the issue. --- drivers/usb/core/hcd.c | 15 +++

[PATCH v3] usb: core: hub: hub_port_init lock controller instead of bus

2016-04-25 Thread Chris Bainbridge
/2/8/312 Link: https://lkml.org/lkml/2016/2/4/748 Signed-off-by: Chris Bainbridge --- This is technically the same as the last patch version, but with a reworked commit message to better explain the cause of the issue. --- drivers/usb/core/hcd.c | 15 +-- drivers/usb/core/hub.c |

Re: [PATCH] usb: core: hub: hub_port_init lock controller instead of bus

2016-04-07 Thread Chris Bainbridge
On Wed, Feb 10, 2016 at 07:13:38PM +0200, Mathias Nyman wrote: > > Most likely xhci is messed up after two device slots are in default state at > the same time. > This happens when both threads are in hub_port_init() have called > hub_port_reset() > > The issue becomes visible when the the

Re: [PATCH] usb: core: hub: hub_port_init lock controller instead of bus

2016-04-07 Thread Chris Bainbridge
On Wed, Feb 10, 2016 at 07:13:38PM +0200, Mathias Nyman wrote: > > Most likely xhci is messed up after two device slots are in default state at > the same time. > This happens when both threads are in hub_port_init() have called > hub_port_reset() > > The issue becomes visible when the the

[BUG] packet loss with PROVE_LOCKING, bisected to EDAC fix

2016-03-21 Thread Chris Bainbridge
Hi, I was testing something on an old server (Dell T105 opteron) and noticed packet loss after updating the kernel from 3.10 to 4.5. The test was: On Dell run: iperf -s On another system: iperf3 -c dell -u -b 20M -l 1k -t 1000 This sends a 20mbit UDP stream to the Dell. It works fine normally

[BUG] packet loss with PROVE_LOCKING, bisected to EDAC fix

2016-03-21 Thread Chris Bainbridge
Hi, I was testing something on an old server (Dell T105 opteron) and noticed packet loss after updating the kernel from 3.10 to 4.5. The test was: On Dell run: iperf -s On another system: iperf3 -c dell -u -b 20M -l 1k -t 1000 This sends a 20mbit UDP stream to the Dell. It works fine normally

[tip:x86/microcode] x86/microcode/intel: Change checksum variables to u32

2016-03-08 Thread tip-bot for Chris Bainbridge
Commit-ID: bc864af13f34d19c911f5691d87bdacc9ce109f5 Gitweb: http://git.kernel.org/tip/bc864af13f34d19c911f5691d87bdacc9ce109f5 Author: Chris Bainbridge <chris.bainbri...@gmail.com> AuthorDate: Mon, 7 Mar 2016 11:10:00 +0100 Committer: Thomas Gleixner <t...@linutronix.de> Com

[tip:x86/microcode] x86/microcode/intel: Change checksum variables to u32

2016-03-08 Thread tip-bot for Chris Bainbridge
Commit-ID: bc864af13f34d19c911f5691d87bdacc9ce109f5 Gitweb: http://git.kernel.org/tip/bc864af13f34d19c911f5691d87bdacc9ce109f5 Author: Chris Bainbridge AuthorDate: Mon, 7 Mar 2016 11:10:00 +0100 Committer: Thomas Gleixner CommitDate: Tue, 8 Mar 2016 09:08:44 +0100 x86/microcode/intel

Re: [PATCH] ACPICA: Events: Execute some _REG methods in early boot

2016-03-07 Thread Chris Bainbridge
On Mon, Mar 07, 2016 at 06:36:05AM +, Zheng, Lv wrote: > Hi, > > First of all, why don't you respond on the kernel bugzilla? > Posting a fix here directly without communication doesn't look like a > constructive help but more like a destructive attack to me. Sorry if it appears to be an

Re: [PATCH] ACPICA: Events: Execute some _REG methods in early boot

2016-03-07 Thread Chris Bainbridge
On Mon, Mar 07, 2016 at 06:36:05AM +, Zheng, Lv wrote: > Hi, > > First of all, why don't you respond on the kernel bugzilla? > Posting a fix here directly without communication doesn't look like a > constructive help but more like a destructive attack to me. Sorry if it appears to be an

[PATCH] ACPICA: Events: Execute some _REG methods in early boot

2016-03-05 Thread Chris Bainbridge
ow_bug.cgi?id=112911 Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- drivers/acpi/acpica/evregion.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpica/evregion.c b/drivers/acpi/acpica/evregion.c index 47092b4d63

[PATCH] ACPICA: Events: Execute some _REG methods in early boot

2016-03-05 Thread Chris Bainbridge
ow_bug.cgi?id=112911 Signed-off-by: Chris Bainbridge --- drivers/acpi/acpica/evregion.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpica/evregion.c b/drivers/acpi/acpica/evregion.c index 47092b4d633c..d0b02ef0effa 100644 --- a/drivers/a

[PATCH v2] x86/microcode: Change checksum to u32

2016-03-01 Thread Chris Bainbridge
] Link: https://lkml.org/lkml/2016/2/27/79 Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- arch/x86/kernel/cpu/microcode/intel_lib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/

[PATCH v2] x86/microcode: Change checksum to u32

2016-03-01 Thread Chris Bainbridge
] Link: https://lkml.org/lkml/2016/2/27/79 Signed-off-by: Chris Bainbridge --- arch/x86/kernel/cpu/microcode/intel_lib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/intel_lib.c

Re: [BUG] ODEBUG: assert_init not available (active state 0)

2016-02-27 Thread Chris Bainbridge
On Tue, Feb 23, 2016 at 02:18:22AM +, Zheng, Lv wrote: > > In fact, I don't understand what your report is. > What did you mean by referring the following commit: > > ACPICA: Events: Enhance acpi_ev_execute_reg_method() to ensure no _REG > > evaluations can happen during OS early boot

Re: [BUG] ODEBUG: assert_init not available (active state 0)

2016-02-27 Thread Chris Bainbridge
On Tue, Feb 23, 2016 at 02:18:22AM +, Zheng, Lv wrote: > > In fact, I don't understand what your report is. > What did you mean by referring the following commit: > > ACPICA: Events: Enhance acpi_ev_execute_reg_method() to ensure no _REG > > evaluations can happen during OS early boot

Re: [PATCH] x86/microcode: Change checksum to u32

2016-02-27 Thread Chris Bainbridge
On Sat, Feb 27, 2016 at 06:51:18PM +0100, Borislav Petkov wrote: > On Sat, Feb 27, 2016 at 11:01:47AM +0000, Chris Bainbridge wrote: > > Checksum should be unsigned 32-bit otherwise the calculation overflows > > resulting in undefined behaviour: > &g

Re: [PATCH] x86/microcode: Change checksum to u32

2016-02-27 Thread Chris Bainbridge
On Sat, Feb 27, 2016 at 06:51:18PM +0100, Borislav Petkov wrote: > On Sat, Feb 27, 2016 at 11:01:47AM +0000, Chris Bainbridge wrote: > > Checksum should be unsigned 32-bit otherwise the calculation overflows > > resulting in undefined behaviour: > &g

[PATCH] x86/microcode: Change checksum to u32

2016-02-27 Thread Chris Bainbridge
] Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- arch/x86/kernel/cpu/microcode/intel_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/microcode/intel_lib.c b/arch/x86/

[PATCH] x86/microcode: Change checksum to u32

2016-02-27 Thread Chris Bainbridge
] Signed-off-by: Chris Bainbridge --- arch/x86/kernel/cpu/microcode/intel_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/microcode/intel_lib.c b/arch/x86/kernel/cpu/microcode/intel_lib.c

[BUG] USB ethernet on XHCI dies under load

2016-02-25 Thread Chris Bainbridge
USB ethernet devices stop responding when plugged in to USB3 XHCI ports and flooded with incoming traffic. The usbnet layer seems to get -EPROTO from the xhci driver. Nothing is usually logged in kernel when this occurs, but with dyndebug on there are errors like: ax88179_178a 4-1.1:1.0

[BUG] USB ethernet on XHCI dies under load

2016-02-25 Thread Chris Bainbridge
USB ethernet devices stop responding when plugged in to USB3 XHCI ports and flooded with incoming traffic. The usbnet layer seems to get -EPROTO from the xhci driver. Nothing is usually logged in kernel when this occurs, but with dyndebug on there are errors like: ax88179_178a 4-1.1:1.0

Re: [BUG] ODEBUG: assert_init not available (active state 0)

2016-02-14 Thread Chris Bainbridge
On 5 February 2016 at 02:52, Zheng, Lv wrote: > > So you could wait for just several days to test it again. > And report here if you can still see issues. I didn't notice any revert last week, is there something specific that I should test? I just noticed that there are graphical glitches in

Re: [BUG] ODEBUG: assert_init not available (active state 0)

2016-02-14 Thread Chris Bainbridge
On 5 February 2016 at 02:52, Zheng, Lv wrote: > > So you could wait for just several days to test it again. > And report here if you can still see issues. I didn't notice any revert last week, is there something specific that I should test? I just noticed that there are

[PATCH] usb: core: hub: hub_port_init lock controller instead of bus

2016-02-08 Thread Chris Bainbridge
of both buses. Fixes: 638139eb95d2 ("usb: hub: allow to process more usb hub events in parallel") Signed-off-by: Chris Bainbridge --- drivers/usb/core/hcd.c | 15 +-- drivers/usb/core/hub.c | 8 include/linux/usb.h | 3 +-- include/linux/usb/hcd.h | 1

[PATCH] usb: core: hub: hub_port_init lock controller instead of bus

2016-02-08 Thread Chris Bainbridge
of both buses. Fixes: 638139eb95d2 ("usb: hub: allow to process more usb hub events in parallel") Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- drivers/usb/core/hcd.c | 15 +-- drivers/usb/core/hub.c | 8 include/linux/usb.h | 3 +-

Re: [PATCH] usb: host: xhci: Replace bus lock with host controller lock

2016-02-05 Thread Chris Bainbridge
Running task list at fail point: [8.978405] kworker/3:0 R running task1176024 2 0x [8.979624] Workqueue: usb_hub_wq hub_event [8.980831] 880260613af8 880260613ac0 811247ed 8802604597c0 [8.982061] 880260608000 880260614000

Re: [PATCH] usb: host: xhci: Replace bus lock with host controller lock

2016-02-05 Thread Chris Bainbridge
Running task list at fail point: [8.978405] kworker/3:0 R running task1176024 2 0x [8.979624] Workqueue: usb_hub_wq hub_event [8.980831] 880260613af8 880260613ac0 811247ed 8802604597c0 [8.982061] 880260608000 880260614000

Re: [PATCH] usb: host: xhci: Replace bus lock with host controller lock

2016-02-04 Thread Chris Bainbridge
On Thu, Feb 04, 2016 at 04:00:51PM -0500, Alan Stern wrote: > On Thu, 4 Feb 2016, Chris Bainbridge wrote: > > > The XHCI controller presents two USB buses to the system - one for USB 2 > > and one for USB 3. When only one bus is locked there is a race condition > > duri

[PATCH] usb: host: xhci: Replace bus lock with host controller lock

2016-02-04 Thread Chris Bainbridge
% of boots. Fix this by locking the bus controller instead of the bus, thus preventing simultaneous hub init on both buses. Fixes: 638139eb95d2 ("usb: hub: allow to process more usb hub events in parallel") Signed-off-by: Chris Bainbridge --- drivers/usb/core/hcd.c | 2 +- drivers/usb/

Re: [PATCH] usb: host: xhci: Replace bus lock with host controller lock

2016-02-04 Thread Chris Bainbridge
On Thu, Feb 04, 2016 at 04:00:51PM -0500, Alan Stern wrote: > On Thu, 4 Feb 2016, Chris Bainbridge wrote: > > > The XHCI controller presents two USB buses to the system - one for USB 2 > > and one for USB 3. When only one bus is locked there is a race condition > > duri

[PATCH] usb: host: xhci: Replace bus lock with host controller lock

2016-02-04 Thread Chris Bainbridge
% of boots. Fix this by locking the bus controller instead of the bus, thus preventing simultaneous hub init on both buses. Fixes: 638139eb95d2 ("usb: hub: allow to process more usb hub events in parallel") Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- driver

[BUG] ACPI Error: ...

2016-02-03 Thread Chris Bainbridge
v4.5-rc2, Macbook IVB, ACPI errors on boot: [0.618382] ACPI Error: Needed type [Reference], found [Integer] 880260240fa0 (20150930/exresop-103) [0.618448] ACPI Error: Method parse/execution failed [\_PR.CPU0._PDC] (Node 880261acb9e0), AE_AML_OPERAND_TYPE (20150930/psparse-542) [

[BUG] ODEBUG: assert_init not available (active state 0)

2016-02-03 Thread Chris Bainbridge
v4.5-rc2. Macbook 2012 (IVB). ODEBUG reports an error or two at shutdown. Apart from the ODEBUG error(s), this bug also seems to cause some graphical corruption when typing in Firefox text fields. efaed9be998b5ae0afb7458e057e5f4402b43fa0 is the first bad commit commit

[BUG] ODEBUG: assert_init not available (active state 0)

2016-02-03 Thread Chris Bainbridge
v4.5-rc2. Macbook 2012 (IVB). ODEBUG reports an error or two at shutdown. Apart from the ODEBUG error(s), this bug also seems to cause some graphical corruption when typing in Firefox text fields. efaed9be998b5ae0afb7458e057e5f4402b43fa0 is the first bad commit commit

[BUG] ACPI Error: ...

2016-02-03 Thread Chris Bainbridge
v4.5-rc2, Macbook IVB, ACPI errors on boot: [0.618382] ACPI Error: Needed type [Reference], found [Integer] 880260240fa0 (20150930/exresop-103) [0.618448] ACPI Error: Method parse/execution failed [\_PR.CPU0._PDC] (Node 880261acb9e0), AE_AML_OPERAND_TYPE (20150930/psparse-542) [

[PATCH] net/mac80211/agg-rx.c: fix use of uninitialised values

2016-01-27 Thread Chris Bainbridge
] [] ? process_one_work+0x860/0x860 [7.976693] [] kthread+0xf6/0x150 [7.976697] [] ? kthread_worker_fn+0x310/0x310 [7.976700] [] ret_from_fork+0x3f/0x70 [7.976703] [] ? kthread_worker_fn+0x310/0x310 Link: https://lkml.org/lkml/2016/1/26/230 Signed-off-by: Chris Bainbridge

[PATCH] net/mac80211/agg-rx.c: fix use of uninitialised values

2016-01-27 Thread Chris Bainbridge
] [] ? process_one_work+0x860/0x860 [7.976693] [] kthread+0xf6/0x150 [7.976697] [] ? kthread_worker_fn+0x310/0x310 [7.976700] [] ret_from_fork+0x3f/0x70 [7.976703] [] ? kthread_worker_fn+0x310/0x310 Link: https://lkml.org/lkml/2016/1/26/230 Signed-off-by: Chris Bainbridge

UBSAN: Undefined behaviour in fs/ext4/mballoc.c:1274:11

2016-01-26 Thread Chris Bainbridge
Mounting ext4 fs on 4.5.0-rc1 [ 1176.592557] [ 1176.592565] UBSAN: Undefined behaviour in fs/ext4/mballoc.c:1274:11 [ 1176.592567] shift exponent -1 is negative [ 1176.592571] CPU: 3 PID: 4976 Comm: QThread Not

Re: UBSAN: Undefined behaviour in fs/btrfs/inode.c:5845:10

2016-01-26 Thread Chris Bainbridge
On Tue, Jan 26, 2016 at 12:03:39PM +0100, David Sterba wrote: > On Tue, Jan 26, 2016 at 10:13:33AM +0000, Chris Bainbridge wrote: > > Booting 4.5.0-rc1 with new UBSAN checker enabled: > > &g

UBSAN: Undefined behaviour in net/mac80211/rx.c:924:18

2016-01-26 Thread Chris Bainbridge
4.5.0-rc1 another UBSAN error: [ 4845.229441] [ 4845.229454] UBSAN: Undefined behaviour in net/mac80211/rx.c:924:18 [ 4845.229458] load of value 2 is not a valid value for type '_Bool' [ 4845.229464] CPU: 1 PID:

UBSAN: Undefined behaviour in net/mac80211/rc80211_minstrel.h:47:34

2016-01-26 Thread Chris Bainbridge
4.5.0-rc1 with the new UBSAN checker: [ 2624.978741] [ 2624.978749] UBSAN: Undefined behaviour in net/mac80211/rc80211_minstrel.h:47:34 [ 2624.978752] signed integer overflow: [ 2624.978754] -32768 * 100 cannot

UBSAN: Undefined behaviour in fs/btrfs/inode.c:5845:10

2016-01-26 Thread Chris Bainbridge
Booting 4.5.0-rc1 with new UBSAN checker enabled: [3.859690] [3.859694] UBSAN: Undefined behaviour in fs/btrfs/inode.c:5845:10 [3.859696] signed integer overflow: [3.859697] 9223372036854775807 + 1

UBSAN: Undefined behaviour in drivers/usb/core/devio.c:1517:25

2016-01-26 Thread Chris Bainbridge
Booting 4.5.0-rc1 with new UBSAN checker enabled: [4.556968] [4.556972] UBSAN: Undefined behaviour in drivers/usb/core/devio.c:1517:25 [4.556975] shift exponent -1 is negative [4.556979] CPU: 2 PID:

UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:2

2016-01-26 Thread Chris Bainbridge
Booting 4.5.0-rc1 with new UBSAN checker enabled: [3.805449] [3.805453] UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:2 [3.805455] signed integer overflow: [3.805456] -1720106381

UBSAN: Undefined behaviour in drivers/usb/core/devio.c:1517:25

2016-01-26 Thread Chris Bainbridge
Booting 4.5.0-rc1 with new UBSAN checker enabled: [4.556968] [4.556972] UBSAN: Undefined behaviour in drivers/usb/core/devio.c:1517:25 [4.556975] shift exponent -1 is negative [4.556979] CPU: 2 PID:

UBSAN: Undefined behaviour in net/mac80211/rc80211_minstrel.h:47:34

2016-01-26 Thread Chris Bainbridge
4.5.0-rc1 with the new UBSAN checker: [ 2624.978741] [ 2624.978749] UBSAN: Undefined behaviour in net/mac80211/rc80211_minstrel.h:47:34 [ 2624.978752] signed integer overflow: [ 2624.978754] -32768 * 100 cannot

UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:2

2016-01-26 Thread Chris Bainbridge
Booting 4.5.0-rc1 with new UBSAN checker enabled: [3.805449] [3.805453] UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:2 [3.805455] signed integer overflow: [3.805456] -1720106381

UBSAN: Undefined behaviour in fs/ext4/mballoc.c:1274:11

2016-01-26 Thread Chris Bainbridge
Mounting ext4 fs on 4.5.0-rc1 [ 1176.592557] [ 1176.592565] UBSAN: Undefined behaviour in fs/ext4/mballoc.c:1274:11 [ 1176.592567] shift exponent -1 is negative [ 1176.592571] CPU: 3 PID: 4976 Comm: QThread Not

UBSAN: Undefined behaviour in fs/btrfs/inode.c:5845:10

2016-01-26 Thread Chris Bainbridge
Booting 4.5.0-rc1 with new UBSAN checker enabled: [3.859690] [3.859694] UBSAN: Undefined behaviour in fs/btrfs/inode.c:5845:10 [3.859696] signed integer overflow: [3.859697] 9223372036854775807 + 1

Re: UBSAN: Undefined behaviour in fs/btrfs/inode.c:5845:10

2016-01-26 Thread Chris Bainbridge
On Tue, Jan 26, 2016 at 12:03:39PM +0100, David Sterba wrote: > On Tue, Jan 26, 2016 at 10:13:33AM +0000, Chris Bainbridge wrote: > > Booting 4.5.0-rc1 with new UBSAN checker enabled: > > &g

UBSAN: Undefined behaviour in net/mac80211/rx.c:924:18

2016-01-26 Thread Chris Bainbridge
4.5.0-rc1 another UBSAN error: [ 4845.229441] [ 4845.229454] UBSAN: Undefined behaviour in net/mac80211/rx.c:924:18 [ 4845.229458] load of value 2 is not a valid value for type '_Bool' [ 4845.229464] CPU: 1 PID:

Re: 4.4-rc, intel dri i915, regular hangs and corruptions

2015-12-28 Thread Chris Bainbridge
On 17 December 2015 at 18:34, Norbert Preining wrote: > * font corruption > sometime sets of glyphs, or practically all glyphs disappear > related probably to bug > https://bugs.freedesktop.org/show_bug.cgi?id=55500 > I have sent some info there already, without response > > Currently

Re: 4.4-rc, intel dri i915, regular hangs and corruptions

2015-12-28 Thread Chris Bainbridge
On 17 December 2015 at 18:34, Norbert Preining wrote: > * font corruption > sometime sets of glyphs, or practically all glyphs disappear > related probably to bug > https://bugs.freedesktop.org/show_bug.cgi?id=55500 > I have sent some info there already, without

[PATCH] Revert "ACPI / SBS: Add 5 us delay to fix SBS hangs on MacBook"

2015-11-12 Thread Chris Bainbridge
This reverts commit 3349fb64b2927407017d970dd5c4daf3c5ad69f8. After commit 8848d20cf09c ("ACPI / SMBus: Fix boot stalls / high CPU caused by reentrant code") the delay is no longer necessary. Signed-off-by: Chris Bainbridge --- drivers/acpi/sbshc.c | 22 -- 1 fi

[PATCH] ACPI / SMBus: Fix boot stalls / high CPU caused by reentrant code

2015-11-12 Thread Chris Bainbridge
andler. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107191 Link: https://lkml.org/lkml/2015/11/6/776 Signed-off-by: Chris Bainbridge --- drivers/acpi/sbshc.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/drivers/acpi/sbshc.c b/driv

[PATCH] Revert "ACPI / SBS: Add 5 us delay to fix SBS hangs on MacBook"

2015-11-12 Thread Chris Bainbridge
This reverts commit 3349fb64b2927407017d970dd5c4daf3c5ad69f8. After commit 8848d20cf09c ("ACPI / SMBus: Fix boot stalls / high CPU caused by reentrant code") the delay is no longer necessary. Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- drivers/a

[PATCH] ACPI / SMBus: Fix boot stalls / high CPU caused by reentrant code

2015-11-12 Thread Chris Bainbridge
andler. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107191 Link: https://lkml.org/lkml/2015/11/6/776 Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- drivers/acpi/sbshc.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git

Re: [PATCH] Preserve task state in reentrant calls to ___wait_event

2015-11-07 Thread Chris Bainbridge
On Fri, Nov 06, 2015 at 08:44:08PM +, Chris Bainbridge wrote: > -#define ___wait_event(wq, condition, state, exclusive, ret, cmd) \ > +#define ___wait_event(wq, condition, nstate, exclusive, re

Re: [PATCH] Preserve task state in reentrant calls to ___wait_event

2015-11-07 Thread Chris Bainbridge
On Fri, Nov 06, 2015 at 08:44:08PM +, Chris Bainbridge wrote: > -#define ___wait_event(wq, condition, state, exclusive, ret, cmd) \ > +#define ___wait_event(wq, condition, nstate, exclusive, re

[PATCH] Preserve task state in reentrant calls to ___wait_event

2015-11-06 Thread Chris Bainbridge
ait_event_timeout() does not preserve the task state when called by tasks that are not running. We fix this by preserving and restoring the task state in ___wait_event(). Signed-off-by: Chris Bainbridge --- I am assuming here that wait_event_timeout() is supposed to support reentrant calls. If not, p

[PATCH] Preserve task state in reentrant calls to ___wait_event

2015-11-06 Thread Chris Bainbridge
ait_event_timeout() does not preserve the task state when called by tasks that are not running. We fix this by preserving and restoring the task state in ___wait_event(). Signed-off-by: Chris Bainbridge <chris.bainbri...@gmail.com> --- I am assuming here that wait_event_timeout() is supposed t

Re: Input: keyboard/Trackpad support for MacBookPro 12,1

2015-05-05 Thread Chris Bainbridge
On 5 May 2015 at 04:29, Yang Hongyang wrote: > Any ideas? https://bugzilla.kernel.org/show_bug.cgi?id=96771 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: Input: keyboard/Trackpad support for MacBookPro 12,1

2015-05-05 Thread Chris Bainbridge
On 5 May 2015 at 04:29, Yang Hongyang macrosh...@163.com wrote: Any ideas? https://bugzilla.kernel.org/show_bug.cgi?id=96771 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[BUG] Macbook intermittent boot fail at "Switched to clocksource tsc"

2015-04-09 Thread Chris Bainbridge
Commit 7bc5a2b -- ACPI: Support _OSI("Darwin") correctly -- has introduced an intermittent boot failure on an IvyBridge Macbook Pro 13 (MacBookPro10,2). The failure rate is around 12%. This was diagnosed by doing a bisect with many boots for each kernel, then verifying failure on 7bc5a2b, and then

[BUG] Macbook intermittent boot fail at Switched to clocksource tsc

2015-04-09 Thread Chris Bainbridge
Commit 7bc5a2b -- ACPI: Support _OSI(Darwin) correctly -- has introduced an intermittent boot failure on an IvyBridge Macbook Pro 13 (MacBookPro10,2). The failure rate is around 12%. This was diagnosed by doing a bisect with many boots for each kernel, then verifying failure on 7bc5a2b, and then

[tip:x86/cpu] x86, cpu: Add forcepae parameter for booting PAE kernels on PAE-disabled Pentium M

2014-03-20 Thread tip-bot for Chris Bainbridge
Commit-ID: 69f2366c9456d0ce784cf5aba87ee77eeadc1d5e Gitweb: http://git.kernel.org/tip/69f2366c9456d0ce784cf5aba87ee77eeadc1d5e Author: Chris Bainbridge AuthorDate: Fri, 7 Mar 2014 18:40:42 +0700 Committer: H. Peter Anvin CommitDate: Thu, 20 Mar 2014 16:31:54 -0700 x86, cpu: Add

[tip:x86/cpu] x86, cpu: Add forcepae parameter for booting PAE kernels on PAE-disabled Pentium M

2014-03-20 Thread tip-bot for Chris Bainbridge
Commit-ID: 3e2ae0fed2a12ef72dea787db4c25466f9d89207 Gitweb: http://git.kernel.org/tip/3e2ae0fed2a12ef72dea787db4c25466f9d89207 Author: Chris Bainbridge AuthorDate: Fri, 7 Mar 2014 18:40:42 +0700 Committer: H. Peter Anvin CommitDate: Thu, 20 Mar 2014 16:28:43 -0700 x86, cpu: Add

[tip:x86/cpu] x86, cpu: Add forcepae parameter for booting PAE kernels on PAE-disabled Pentium M

2014-03-20 Thread tip-bot for Chris Bainbridge
Commit-ID: 3e2ae0fed2a12ef72dea787db4c25466f9d89207 Gitweb: http://git.kernel.org/tip/3e2ae0fed2a12ef72dea787db4c25466f9d89207 Author: Chris Bainbridge chris.bainbri...@gmail.com AuthorDate: Fri, 7 Mar 2014 18:40:42 +0700 Committer: H. Peter Anvin h...@zytor.com CommitDate: Thu, 20 Mar

[tip:x86/cpu] x86, cpu: Add forcepae parameter for booting PAE kernels on PAE-disabled Pentium M

2014-03-20 Thread tip-bot for Chris Bainbridge
Commit-ID: 69f2366c9456d0ce784cf5aba87ee77eeadc1d5e Gitweb: http://git.kernel.org/tip/69f2366c9456d0ce784cf5aba87ee77eeadc1d5e Author: Chris Bainbridge chris.bainbri...@gmail.com AuthorDate: Fri, 7 Mar 2014 18:40:42 +0700 Committer: H. Peter Anvin h...@zytor.com CommitDate: Thu, 20 Mar

[PATCH] x86: Add forcepae parameter for booting PAE kernels on PAE-disabled Pentium M

2014-03-07 Thread Chris Bainbridge
From: Chris Bainbridge Many Pentium M systems disable PAE but may have a functionally usable PAE implementation. This adds the "forcepae" parameter which bypasses the boot check for PAE, and sets the CPU as being PAE capable. Using this parameter will taint

[PATCH] x86: Add forcepae parameter for booting PAE kernels on PAE-disabled Pentium M

2014-03-07 Thread Chris Bainbridge
From: Chris Bainbridge chris.bainbri...@gmail.com Many Pentium M systems disable PAE but may have a functionally usable PAE implementation. This adds the forcepae parameter which bypasses the boot check for PAE, and sets the CPU as being PAE capable. Using this parameter will taint the kernel

Re: Re: [PATCH] x86: set Pentium M as PAE capable

2014-03-04 Thread Chris Bainbridge
On 4 March 2014 17:44, Borislav Petkov wrote: > On Tue, Mar 04, 2014 at 01:06:03PM +0700, Chris Bainbridge wrote: >> On Mon, Mar 03, 2014 at 09:04:19PM -0800, H. Peter Anvin wrote: >> > forcepae is descriptive. >> >> Back to forcepae. > > Ok, it looks ok to

Re: Re: [PATCH] x86: set Pentium M as PAE capable

2014-03-04 Thread Chris Bainbridge
On 4 March 2014 17:44, Borislav Petkov b...@alien8.de wrote: On Tue, Mar 04, 2014 at 01:06:03PM +0700, Chris Bainbridge wrote: On Mon, Mar 03, 2014 at 09:04:19PM -0800, H. Peter Anvin wrote: forcepae is descriptive. Back to forcepae. Ok, it looks ok to me after a quick look. Now you only

Re: Re: [PATCH] x86: set Pentium M as PAE capable

2014-03-03 Thread Chris Bainbridge
On Mon, Mar 03, 2014 at 09:04:19PM -0800, H. Peter Anvin wrote: > forcepae is descriptive. Back to forcepae. Signed-off-by: Chris Bainbridge --- diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 580a60c..67755ea 100644 --- a/Documentation/ker

Re: Re: [PATCH] x86: set Pentium M as PAE capable

2014-03-03 Thread Chris Bainbridge
On Mon, Mar 03, 2014 at 08:29:39PM +0100, Borislav Petkov wrote: > On Mon, Mar 03, 2014 at 03:04:35PM +0700, Chris Bainbridge wrote: > > On 3 March 2014 02:05, Roland Kletzing wrote: > > > i would recommend adding the newly introduced param to > > > Documentation/k

Re: Re: [PATCH] x86: set Pentium M as PAE capable

2014-03-03 Thread Chris Bainbridge
and Kletzing wrote: > i would recommend adding the newly introduced param to > Documentation/kernel- > parameters.txt , though. Done. Signed-off-by: Chris Bainbridge --- diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index b9e9bd8..388b5e9 100644 --

Re: Re: [PATCH] x86: set Pentium M as PAE capable

2014-03-03 Thread Chris Bainbridge
recommend adding the newly introduced param to Documentation/kernel- parameters.txt , though. Done. Signed-off-by: Chris Bainbridge chris.bainbri...@gmail.com --- diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index b9e9bd8..388b5e9 100644

Re: Re: [PATCH] x86: set Pentium M as PAE capable

2014-03-03 Thread Chris Bainbridge
On Mon, Mar 03, 2014 at 08:29:39PM +0100, Borislav Petkov wrote: On Mon, Mar 03, 2014 at 03:04:35PM +0700, Chris Bainbridge wrote: On 3 March 2014 02:05, Roland Kletzing devz...@web.de wrote: i would recommend adding the newly introduced param to Documentation/kernel- parameters.txt

Re: Re: [PATCH] x86: set Pentium M as PAE capable

2014-03-03 Thread Chris Bainbridge
On Mon, Mar 03, 2014 at 09:04:19PM -0800, H. Peter Anvin wrote: forcepae is descriptive. Back to forcepae. Signed-off-by: Chris Bainbridge chris.bainbri...@gmail.com --- diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 580a60c..67755ea 100644

Re: [PATCH] x86: set Pentium M as PAE capable

2014-02-28 Thread Chris Bainbridge
lier versions of the Pentium M > ( Older Dothans and the Banias core) do not have PAE support, officially. > > -Dennis. Good point, patch updated to not show the warning if PAE is already enabled. Signed-off-by: Chris Bainbridge --- diff --git a/arch/x86/boot/cpucheck.c b/arch/x86/boot/c

Re: [PATCH] x86: set Pentium M as PAE capable

2014-02-28 Thread Chris Bainbridge
and the Banias core) do not have PAE support, officially. -Dennis. Good point, patch updated to not show the warning if PAE is already enabled. Signed-off-by: Chris Bainbridge chris.bainbri...@gmail.com --- diff --git a/arch/x86/boot/cpucheck.c b/arch/x86/boot/cpucheck.c index 4d3ff03..3fd12bc

Re: [PATCH] x86: set Pentium M as PAE capable

2014-02-27 Thread Chris Bainbridge
On Wed, Feb 26, 2014 at 10:49:49AM -0500, Dave Jones wrote: > On Wed, Feb 26, 2014 at 02:18:52PM +0100, Borislav Petkov wrote: > > On Wed, Feb 26, 2014 at 07:12:59PM +0700, Chris Bainbridge wrote: > > > @@ -226,6 +234,15 @@ static void intel_workarounds(str

Re: [PATCH] x86: set Pentium M as PAE capable

2014-02-27 Thread Chris Bainbridge
On Wed, Feb 26, 2014 at 10:49:49AM -0500, Dave Jones wrote: On Wed, Feb 26, 2014 at 02:18:52PM +0100, Borislav Petkov wrote: On Wed, Feb 26, 2014 at 07:12:59PM +0700, Chris Bainbridge wrote: @@ -226,6 +234,15 @@ static void intel_workarounds(struct cpuinfo_x86 *c

Re: [PATCH] x86: set Pentium M as PAE capable

2014-02-26 Thread Chris Bainbridge
On Tue, Feb 25, 2014 at 09:16:02AM -0800, H. Peter Anvin wrote: > On 02/25/2014 08:26 AM, Dave Jones wrote: > > On Tue, Feb 25, 2014 at 02:45:57AM -0800, H. Peter Anvin wrote: > > > On 02/24/2014 10:01 PM, Chris Bainbridge wrote: > > > > Pentium M is PAE ca

Re: [PATCH] x86: set Pentium M as PAE capable

2014-02-26 Thread Chris Bainbridge
On Tue, Feb 25, 2014 at 09:16:02AM -0800, H. Peter Anvin wrote: On 02/25/2014 08:26 AM, Dave Jones wrote: On Tue, Feb 25, 2014 at 02:45:57AM -0800, H. Peter Anvin wrote: On 02/24/2014 10:01 PM, Chris Bainbridge wrote: Pentium M is PAE capable but does not indicate so in the CPUID

[PATCH] x86: set Pentium M as PAE capable

2014-02-24 Thread Chris Bainbridge
discussion see https://bugs.launchpad.net/baltix/+bug/930447 Signed-off-by: Chris Bainbridge --- diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index bbe1b8b..97996aa 100644 --- a/arch/x86/kernel/cpu/intel.c +++ b/arch/x86/kernel/cpu/intel.c @@ -226,6 +226,12 @@ static void

[PATCH] x86: set Pentium M as PAE capable

2014-02-24 Thread Chris Bainbridge
discussion see https://bugs.launchpad.net/baltix/+bug/930447 Signed-off-by: Chris Bainbridge chris.bainbri...@gmail.com --- diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index bbe1b8b..97996aa 100644 --- a/arch/x86/kernel/cpu/intel.c +++ b/arch/x86/kernel/cpu/intel.c