Re: [PATCH 00/32] kmsan: Enable on s390

2023-11-16 Thread Christian Borntraeger
Am 16.11.23 um 11:13 schrieb Ilya Leoshkevich: It's also possible to get a free s390 machine at [1]. [1] https://linuxone.cloud.marist.edu/oss I think the URL for registration is this one https://linuxone.cloud.marist.edu/#/register?flag=VM

Re: [PATCH v3 1/9] context_tracking: Move guest exit context tracking to separate helpers

2021-04-20 Thread Christian Borntraeger
Christopherson Cc: Michael Tokarev Cc: Christian Borntraeger Signed-off-by: Wanpeng Li Co-developed-by: Sean Christopherson Signed-off-by: Sean Christopherson Reviewed-by: Christian Borntraeger --- include/linux/context_tracking.h | 9 - 1 file changed, 8 insertions(+), 1

Re: [PATCH v3 2/9] context_tracking: Move guest exit vtime accounting to separate helpers

2021-04-20 Thread Christian Borntraeger
accounting. Suggested-by: Thomas Gleixner Cc: Thomas Gleixner Cc: Michael Tokarev Cc: Christian Borntraeger Signed-off-by: Wanpeng Li Co-developed-by: Sean Christopherson Signed-off-by: Sean Christopherson Reviewed-by: Christian Borntraeger --- include/linux/context_tracking.h | 24

Re: linux-next: Fixes tag needs some work in the kvm tree

2021-04-16 Thread Christian Borntraeger
On 16.04.21 16:58, Stephen Rothwell wrote: Hi all, On Fri, 16 Apr 2021 16:02:01 +0200 Paolo Bonzini wrote: On 16/04/21 14:38, Christian Borntraeger wrote: On 16.04.21 14:27, Stephen Rothwell wrote: Hi all, In commit    c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for pref

Re: [PATCH v2] tools: do not include scripts/Kbuild.include

2021-04-16 Thread Christian Borntraeger
.include. Link: https://lore.kernel.org/lkml/86dadf33-70f7-a5ac-cb8c-64966d2f4...@linux.ibm.com/ Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler") Reported-by: Janosch Frank Reported-by: Christian Borntraeger Signed-off-by: Masahiro Yamada looks better. Tested-by: Christian Borntraeger

Re: linux-next: Fixes tag needs some work in the kvm tree

2021-04-16 Thread Christian Borntraeger
On 16.04.21 14:27, Stephen Rothwell wrote: Hi all, In commit c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and MSO") Fixes tag Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in VSIE") has these problem(s): - Subject does not match target commit

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Christian Borntraeger
On 15.04.21 10:06, Christian Borntraeger wrote: On 15.04.21 09:27, Masahiro Yamada wrote: Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler"), some kselftests fail to build. The tools/ directory opted out Kbuild, and went in a different

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Christian Borntraeger
Link: https://lore.kernel.org/lkml/86dadf33-70f7-a5ac-cb8c-64966d2f4...@linux.ibm.com/ Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler") Reported-by: Janosch Frank Reported-by: Christian Borntraeger Signed-off-by: Masahiro Yamada When appl

Re: [PATCH 3/4] kbuild: spilt cc-option and friends to scripts/Makefile.compiler

2021-04-13 Thread Christian Borntraeger
On 13.04.21 14:51, Janosch Frank wrote: On 2/28/21 7:10 AM, Masahiro Yamada wrote: scripts/Kbuild.include is included everywhere, but macros such as cc-option are needed by build targets only. For example, when 'make clean' traverses the tree, it does not need to evaluate $(call

Re: [PATCH v2 0/3] KVM: Properly account for guest CPU time

2021-04-13 Thread Christian Borntraeger
On 13.04.21 09:16, Wanpeng Li wrote: The bugzilla https://bugzilla.kernel.org/show_bug.cgi?id=209831 reported that the guest time remains 0 when running a while true loop in the guest. The commit 87fa7f3e98a131 ("x86/kvm: Move context tracking where it belongs") moves guest_exit_irqoff()

Re: [PATCH v2 1/3] context_tracking: Split guest_enter/exit_irqoff

2021-04-13 Thread Christian Borntraeger
On 13.04.21 09:52, Wanpeng Li wrote: Or did I miss anything. I mean the if (!context_tracking_enabled_this_cpu()) part in the function context_guest_enter_irqoff() ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN. :) Ah I missed that. Thanks.

Re: [PATCH v2 1/3] context_tracking: Split guest_enter/exit_irqoff

2021-04-13 Thread Christian Borntraeger
On 13.04.21 09:38, Wanpeng Li wrote: On Tue, 13 Apr 2021 at 15:35, Christian Borntraeger wrote: On 13.04.21 09:16, Wanpeng Li wrote: [...] @@ -145,6 +155,13 @@ static __always_inline void guest_exit_irqoff(void) } #else THis is the else part +static __always_inline void

Re: [PATCH v2 1/3] context_tracking: Split guest_enter/exit_irqoff

2021-04-13 Thread Christian Borntraeger
On 13.04.21 09:16, Wanpeng Li wrote: [...] @@ -145,6 +155,13 @@ static __always_inline void guest_exit_irqoff(void) } #else +static __always_inline void context_guest_enter_irqoff(void) +{ + instrumentation_begin(); + rcu_virt_note_context_switch(smp_processor_id()); +

RE: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-04-12 Thread Christian Borntraeger
On 12.04.21 12:53, Muchun Song wrote: On Mon, Apr 12, 2021 at 6:42 PM Christian Borntraeger wrote: FWIW, I was away the last week, and I checked yesterdays next (e99d8a849517) regression runs. I still do see errors in our CI system: [ 2263.021681] [ cut here

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-04-12 Thread Christian Borntraeger
FWIW, I was away the last week, and I checked yesterdays next (e99d8a849517) regression runs. I still do see errors in our CI system: [ 2263.021681] [ cut here ] [ 2263.021697] percpu ref (obj_cgroup_release) <= 0 (0) after switching to atomic [ 2263.021748] WARNING:

RE: kernel warning percpu ref in obj_cgroup_release

2021-03-31 Thread Christian Borntraeger
On 30.03.21 18:25, Muchun Song wrote: On Tue, Mar 30, 2021 at 11:10 PM Christian Borntraeger wrote: On 30.03.21 15:49, Muchun Song wrote: On Tue, Mar 30, 2021 at 9:27 PM Christian Borntraeger wrote: So bisect shows this for belows warning: Thanks for your effort on this. Can you

RE: kernel warning percpu ref in obj_cgroup_release

2021-03-30 Thread Christian Borntraeger
On 30.03.21 15:49, Muchun Song wrote: On Tue, Mar 30, 2021 at 9:27 PM Christian Borntraeger wrote: So bisect shows this for belows warning: Thanks for your effort on this. Can you share your config? attached (but its s390x) for next-20210330 The problem goes away when I add

Re: kernel warning percpu ref in obj_cgroup_release

2021-03-30 Thread Christian Borntraeger
-- mm/memcontrol.c| 110 +- 2 files changed, 145 insertions(+), 81 deletions(-) On 30.03.21 13:32, Christian Borntraeger wrote: [...] This next (328 is fine) triggers several bugs during our KVM CI run: [ 1506.494716] [ cut h

kernel warning percpu ref in obj_cgroup_release (was: Re: linux-next: Tree for Mar 29)

2021-03-30 Thread Christian Borntraeger
On 29.03.21 11:52, Stephen Rothwell wrote: Hi all, News: there will be no linux-next release on Friday or the following Monday. Changes since 20210326: The arm64 tree gained a conflict against Linus' tree. I applied a supplied patch for clang brakage in the kbuild tree. The net-next tree

Re: [PATCH v2 2/2] s390/kvm: VSIE: fix MVPG handling for prefixing and MSO

2021-03-23 Thread Christian Borntraeger
On 23.03.21 16:21, Claudio Imbrenda wrote: On Tue, 23 Mar 2021 16:16:18 +0100 Christian Borntraeger wrote: On 23.03.21 16:11, David Hildenbrand wrote: On 23.03.21 16:07, Christian Borntraeger wrote: On 22.03.21 15:05, Claudio Imbrenda wrote: Prefixing needs to be applied to the guest

Re: [PATCH v2 2/2] s390/kvm: VSIE: fix MVPG handling for prefixing and MSO

2021-03-23 Thread Christian Borntraeger
On 23.03.21 16:11, David Hildenbrand wrote: On 23.03.21 16:07, Christian Borntraeger wrote: On 22.03.21 15:05, Claudio Imbrenda wrote: Prefixing needs to be applied to the guest real address to translate it into a guest absolute address. The value of MSO needs to be added to a guest

Re: [PATCH v2 2/2] s390/kvm: VSIE: fix MVPG handling for prefixing and MSO

2021-03-23 Thread Christian Borntraeger
On 22.03.21 15:05, Claudio Imbrenda wrote: Prefixing needs to be applied to the guest real address to translate it into a guest absolute address. The value of MSO needs to be added to a guest-absolute address in order to obtain the host-virtual. Fixes: 223ea46de9e79 ("s390/kvm: VSIE:

Re: [PATCH v2 1/2] s390/kvm: split kvm_s390_real_to_abs

2021-03-23 Thread Christian Borntraeger
...@vger.kernel.org Signed-off-by: Claudio Imbrenda Reviewed-by: David Hildenbrand Reviewed-by: Thomas Huth Reviewed-by: Christian Borntraeger --- arch/s390/kvm/gaccess.h | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/arch/s390/kvm/gaccess.h b/arch/s390

Re: [PATCH v2 0/2] s390/kvm: VSIE: fix prefixing and MSO for MVPG

2021-03-23 Thread Christian Borntraeger
On 22.03.21 15:05, Claudio Imbrenda wrote: The guest real address needs to pass through prefixing in order to yield the absolute address. The absolute address needs to be offset by the MSO in order to get the host virtual address. v1->v2 * use the MSO from the shadow SIE page instead of the

Re: [PATCH v1 1/2] s390/kvm: split kvm_s390_real_to_abs

2021-03-22 Thread Christian Borntraeger
On 22.03.21 12:12, Heiko Carstens wrote: On Mon, Mar 22, 2021 at 10:53:46AM +0100, David Hildenbrand wrote: diff --git a/arch/s390/kvm/gaccess.h b/arch/s390/kvm/gaccess.h index daba10f76936..7c72a5e3449f 100644 --- a/arch/s390/kvm/gaccess.h +++ b/arch/s390/kvm/gaccess.h @@ -18,17 +18,14 @@

Re: [PATCH v5 0/3] s390/kvm: fix MVPG when in VSIE

2021-03-08 Thread Christian Borntraeger
On 02.03.21 18:44, Claudio Imbrenda wrote: The current handling of the MVPG instruction when executed in a nested guest is wrong, and can lead to the nested guest hanging. This patchset fixes the behaviour to be more architecturally correct, and fixes the hangs observed. v4->v5 * split

Re: [PATCH v5 3/3] s390/kvm: VSIE: correctly handle MVPG when in VSIE

2021-03-08 Thread Christian Borntraeger
Reviewed-by: David Hildenbrand looks sane. Acked-by: Christian Borntraeger --- arch/s390/kvm/vsie.c | 98 +--- 1 file changed, 93 insertions(+), 5 deletions(-) diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c index 78b604326016..48aab6290

Re: [PATCH v5 2/3] s390/kvm: extend kvm_s390_shadow_fault to return entry pointer

2021-03-05 Thread Christian Borntraeger
Reviewed-by: David Hildenbrand Reviewed-by: Christian Borntraeger

Re: [PATCH v5 1/3] s390/kvm: split kvm_s390_logical_to_effective

2021-03-05 Thread Christian Borntraeger
with the appropriate PSW from the vCPU. This is needed to avoid code duplication for vSIE. Signed-off-by: Claudio Imbrenda We might need cc stable here as well for patch 3? Otherwise this looks good. Reviewed-by: Christian Borntraeger --- arch/s390/kvm/gaccess.h | 29

Re: [PATCH v2 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-02-24 Thread Christian Borntraeger
On 23.02.21 10:48, Halil Pasic wrote: > On Mon, 15 Feb 2021 20:15:47 -0500 > Tony Krowiak wrote: > >> This patch fixes a circular locking dependency in the CI introduced by >> commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM >> pointer invalidated"). The lockdep only

Re: [PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-24 Thread Christian Borntraeger
On 23.02.21 07:19, Jason Wang wrote: > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > lot of confusion. E.g it may break various default configs which want > virtio devices. > > So this patch fixes this by hiding the prompot and documenting the > dependency. While at

Re: [PATCH -next] KVM: s390: Return the correct errno code

2021-02-04 Thread Christian Borntraeger
On 04.02.21 09:32, Cornelia Huck wrote: > On Thu, 4 Feb 2021 16:05:23 +0800 > Zheng Yongjun wrote: > >> When valloc failed, should return ENOMEM rather than ENOBUF. >> >> Signed-off-by: Zheng Yongjun >> --- >> arch/s390/kvm/interrupt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] s390: allow reschedule on syscall restart

2021-01-26 Thread Christian Borntraeger
On 21.01.21 15:39, Sven Schnelle wrote: > Commit 845f44e8ef28 ("sched: Report local wake up on resched blind zone > within idle loop") from next-20210121 causes a warning because s390 > doesn't call sched_resched_local_allow() when restarting a syscall. > > Signed-off-by: Sven Schnelle > --- >

Re: [PATCH v5] s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated

2021-01-22 Thread Christian Borntraeger
On 23.12.20 02:20, Tony Krowiak wrote: > The vfio_ap device driver registers a group notifier with VFIO when the > file descriptor for a VFIO mediated device for a KVM guest is opened to > receive notification that the KVM pointer is set (VFIO_GROUP_NOTIFY_SET_KVM > event). When the KVM pointer is

Re: [PATCH 1/1] s390/vfio-ap: No need to disable IRQ after queue reset

2021-01-22 Thread Christian Borntraeger
ixes: ec89b55e3bce ("s390: ap: implement PAPQ AQIC interception in kernel") > Cc: Acked-by: Christian Borntraeger Heiko, Vasily, lets carry this via the s390 tree. > > --- > > Since it turned out disabling the interrupts via PQAP/AQIC is not only > unnecesary but also b

Re: [PATCH v2 2/2] s390: mm: Fix secure storage access exception handling

2021-01-21 Thread Christian Borntraeger
nd a SIGSEGV to the process or > panic the kernel depending on who caused the exception. > > Signed-off-by: Janosch Frank > Fixes: 084ea4d611a3d ("s390/mm: add (non)secure page access exceptions > handlers") > Cc: sta...@vger.kernel.org Reviewed-by: Christian Borntraeger we s

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-20 Thread Christian Borntraeger
On 20.01.21 14:42, Heiko Carstens wrote: > On Tue, Jan 19, 2021 at 11:25:01AM +0100, Christian Borntraeger wrote: >>> + if (user_mode(regs)) { >>> + send_sig(SIGSEGV, current, 0); >>> + return; >>> +

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-19 Thread Christian Borntraeger
nd a SIGSEGV to the process or > panic the kernel depending on who caused the exception. > > Signed-off-by: Janosch Frank > Fixes: 084ea4d611a3d ("s390/mm: add (non)secure page access exceptions > handlers") > Cc: sta...@vger.kernel.org Reviewed-by: Christian Borntraeger som

Re: [PATCH 1/2] s390: uv: Fix sysfs max number of VCPUs reporting

2021-01-19 Thread Christian Borntraeger
On 19.01.21 11:04, Janosch Frank wrote: > The number reported by the query is N-1 and I think people reading the > sysfs file would expect N instead. For users creating VMs there's no > actual difference because KVM's limit is currently below the UV's > limit. > > The naming of the field is a

Re: [PATCH 1/2] s390: uv: Fix sysfs max number of VCPUs reporting

2021-01-19 Thread Christian Borntraeger
On 19.01.21 11:15, Janosch Frank wrote: > On 1/19/21 11:11 AM, Christian Borntraeger wrote: >> >> >> On 19.01.21 11:04, Janosch Frank wrote: >>> The number reported by the query is N-1 and I think people reading the >>> sysfs file would expect N

Re: [PATCH v5] s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated

2020-12-27 Thread Christian Borntraeger
On 23.12.20 02:20, Tony Krowiak wrote: > The vfio_ap device driver registers a group notifier with VFIO when the > file descriptor for a VFIO mediated device for a KVM guest is opened to > receive notification that the KVM pointer is set (VFIO_GROUP_NOTIFY_SET_KVM > event). When the KVM pointer

Re: [PATCH] zlib: move EXPORT_SYMBOL() and MODULE_LICENSE() out of dfltcc_syms.c

2020-12-23 Thread Christian Borntraeger
to dfltcc.c. > > Fixes: 11fb479ff5d9 ("zlib: export S390 symbols for zlib modules") > Signed-off-by: Randy Dunlap > Cc: Zaslonko Mikhail > Cc: Andrew Morton > Cc: Acked-by: Ilya Leoshkevich > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Bornt

Re: [PATCH v3] s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated

2020-12-16 Thread Christian Borntraeger
On 16.12.20 10:58, Christian Borntraeger wrote: > On 16.12.20 02:21, Halil Pasic wrote: >> On Tue, 15 Dec 2020 19:10:20 +0100 >> Christian Borntraeger wrote: >> >>> >>> >>> On 15.12.20 11:57, Halil Pasic wrote: >>>>

Re: [PATCH v3] s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated

2020-12-16 Thread Christian Borntraeger
On 16.12.20 02:21, Halil Pasic wrote: > On Tue, 15 Dec 2020 19:10:20 +0100 > Christian Borntraeger wrote: > >> >> >> On 15.12.20 11:57, Halil Pasic wrote: >>> On Mon, 14 Dec 2020 11:56:17 -0500 >>> Tony Krowiak wrote: >>> >>>> T

Re: [PATCH] lib/zlib: fix inflating zlib streams on s390

2020-12-15 Thread Christian Borntraeger
still > affected. > > Fix by always passing a checksum to and from the hardware as is, which > matches zlib_inflate()'s expectations. > > Fixes: 126196100063 ("lib/zlib: add s390 hardware support for kernel > zlib_inflate") > Signed-off-by: Ilya Leoshkevich Wi

Re: [PATCH v3] s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated

2020-12-15 Thread Christian Borntraeger
On 15.12.20 11:57, Halil Pasic wrote: > On Mon, 14 Dec 2020 11:56:17 -0500 > Tony Krowiak wrote: > >> The vfio_ap device driver registers a group notifier with VFIO when the >> file descriptor for a VFIO mediated device for a KVM guest is opened to >> receive notification that the KVM pointer

Re: [Patch v3 0/2] cgroup: KVM: New Encryption IDs cgroup controller

2020-12-10 Thread Christian Borntraeger
On 09.12.20 21:58, Tejun Heo wrote: > Hello, > > Rough take after skimming: > > * I don't have an overall objection. In terms of behavior, the only thing > which stood out was input rejection depending on the current usage. The > preferred way of handling that is rejecting future allocations

Re: [PATCH 1/1] crypto: Fix possible buffer overflows in pkey_protkey_aes_attr_read

2020-12-08 Thread Christian Borntraeger
On 09.12.20 07:47, Xiaohui Zhang wrote: > From: Zhang Xiaohui > > pkey_protkey_aes_attr_read() calls memcpy() without checking the > destination size may trigger a buffer overflower. To me it looks like protkey.len is generated programmatically in pkey_genprotkey/pkey_clr2protkey and this

Re: [RFC PATCH 0/1] "Bad page state" while freeing gigantic pages

2020-12-08 Thread Christian Borntraeger
On 08.12.20 19:28, Gerald Schaefer wrote: > The following "Bad page state" occurs on s390 when freeing gigantic pages: > > [ 276.681603] BUG: Bad page state in process bash pfn:380001 > [ 276.681614] page:c35f0856 refcount:0 mapcount:0 > mapping:126b68aa index:0x0

Re: [PATCH] s390/vfio-ap: Clean up vfio_ap resources when KVM pointer invalidated

2020-12-07 Thread Christian Borntraeger
On 07.12.20 16:24, Halil Pasic wrote: > On Fri, 4 Dec 2020 11:48:24 -0500 > Tony Krowiak wrote: > >> On 12/3/20 12:55 PM, Halil Pasic wrote: >>> On Wed, 2 Dec 2020 18:41:01 -0500 >>> Tony Krowiak wrote: >>> The vfio_ap device driver registers a group notifier with VFIO when the

Re: [PATCH 2/5] s390/vtime: Use the generic IRQ entry accounting

2020-12-02 Thread Christian Borntraeger
ed-off-by: Frederic Weisbecker > Cc: Peter Zijlstra > Cc: Tony Luck > Cc: Fenghua Yu > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger As far as I can tel,l this patch

Re: [PATCH 1/5] sched/cputime: Remove symbol exports from IRQ time accounting

2020-12-02 Thread Christian Borntraeger
er > Cc: Peter Zijlstra > Cc: Tony Luck > Cc: Fenghua Yu > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > --- > arch/s390/kernel/vtime.c | 10 +- > ker

Re: [GIT pull] locking/urgent for v5.10-rc6

2020-11-30 Thread Christian Borntraeger
On 30.11.20 19:04, Linus Torvalds wrote: > On Mon, Nov 30, 2020 at 5:03 AM Peter Zijlstra wrote: >> >>> But but but... >>> >>> do_idle() # IRQs on >>> local_irq_disable(); # IRQs off >>> defaul_idle_call()# IRQs off >> lockdep_hardirqs_on(); #

Re: [RFC Patch 0/2] KVM: SVM: Cgroup support for SVM SEV ASIDs

2020-11-27 Thread Christian Borntraeger
On 24.11.20 20:16, Sean Christopherson wrote: > On Fri, Nov 13, 2020, David Rientjes wrote: > >> >> >> On Mon, 2 Nov 2020, Sean Christopherson wrote:

Re: [PATCH v2] drivers/virt: vmgenid: add vm generation id driver

2020-11-19 Thread Christian Borntraeger
On 19.11.20 13:51, Alexander Graf wrote: > > > On 19.11.20 13:02, Christian Borntraeger wrote: >> >> On 16.11.20 16:34, Catangiu, Adrian Costin wrote: >>> - Background >>> >>> The VM Generation ID is a feature defined by Microsoft (paper: &

Re: [PATCH v2] drivers/virt: vmgenid: add vm generation id driver

2020-11-19 Thread Christian Borntraeger
On 16.11.20 16:34, Catangiu, Adrian Costin wrote: > - Background > > The VM Generation ID is a feature defined by Microsoft (paper: > http://go.microsoft.com/fwlink/?LinkId=260709) and supported by > multiple hypervisor vendors. > > The feature is required in virtualized environments by apps

Re: md: dm-writeback: add __noreturn to BUG-ging function

2020-11-18 Thread Christian Borntraeger
On 18.11.20 17:07, Mike Snitzer wrote: > On Wed, Nov 18 2020 at 10:49am -0500, > Mike Snitzer wrote: > >> I don't think my suggestion will help.. given it'd still leave >> persistent_memory_claim() without a return statement. >> >> Think it worthwhile to just add a dummy 'return 0;' after the

Re: [PATCH] md: dm-writeback: add __noreturn to BUG-ging function

2020-11-15 Thread Christian Borntraeger
asdair Kergon > Cc: Mike Snitzer > Cc: dm-de...@redhat.com > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc: linux-s...@vger.kernel.org > --- > drivers/md/dm-writecache.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --

Re: [PATCH 2/2] mm: simplify follow_pte{,pmd}

2020-11-11 Thread Christian Borntraeger
On 11.11.20 09:18, Christoph Hellwig wrote: > On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote: >> Sorry, I think this patch may be causing a regression for us for s390? >> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/432129279#L768 >> >> (via

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-20 Thread Christian Borntraeger
On 17.10.20 20:09, Alexander Graf wrote: > Hi Jason, > > On 17.10.20 15:24, Jason A. Donenfeld wrote: >> >> After discussing this offline with Jann a bit, I have a few general >> comments on the design of this. >> >> First, the UUID communicated by the hypervisor should be consumed by >> the

Re: autofs crash with latest linux-next

2020-10-13 Thread Christian Borntraeger
CC linux-next, Al Viro. On 12.10.20 09:54, Sven Schnelle wrote: > Hi, > > on s390 i see the following crash with linux-next: > > [ 4525.432605] Unable to handle kernel pointer dereference in virtual kernel > address space > [ 4525.432612] Failing address: TEID:

Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-10-07 Thread Christian Borntraeger
On 07.10.20 14:14, Christoph Hellwig wrote: > On Wed, Oct 07, 2020 at 02:09:18PM +0200, Christian Borntraeger wrote: >> Unfortunately not. On insmodding virtio_blk I do get: > > Yeah, the symbol_put needs to be conditional as well. New version below: Yes, this works. > &g

Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-10-07 Thread Christian Borntraeger
On 07.10.20 14:00, Christoph Hellwig wrote: > On Wed, Oct 07, 2020 at 12:44:55PM +0200, Christian Borntraeger wrote: >> >> >> On 07.10.20 12:39, Christoph Hellwig wrote: >>> On Wed, Oct 07, 2020 at 11:34:17AM +0200, Christian Borntraeger wrote: >>>> >

Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-10-07 Thread Christian Borntraeger
On 07.10.20 12:39, Christoph Hellwig wrote: > On Wed, Oct 07, 2020 at 11:34:17AM +0200, Christian Borntraeger wrote: >> >> On 19.05.20 16:22, Stefan Haberland wrote: >>> The IBM partition parser requires device type specific information only >>> availabl

Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-10-07 Thread Christian Borntraeger
On 19.05.20 16:22, Stefan Haberland wrote: > The IBM partition parser requires device type specific information only > available to the DASD driver to correctly register partitions. The > current approach of using ioctl_by_bdev with a fake user space pointer > is discouraged. > > Fix this by

Re: [RFC Patch 0/2] KVM: SVM: Cgroup support for SVM SEV ASIDs

2020-09-28 Thread Christian Borntraeger
On 28.09.20 11:12, Janosch Frank wrote: > On 9/23/20 2:47 PM, Paolo Bonzini wrote: >> On 22/09/20 03:48, Sean Christopherson wrote: >>> This should be genericized to not be SEV specific. TDX has a similar >>> scarcity issue in the form of key IDs, which IIUC are analogous to SEV ASIDs >>> (gave

Re: [RFC PATCH 0/3] KVM: Introduce "VM bugged" concept

2020-09-24 Thread Christian Borntraeger
On 24.09.20 00:45, Sean Christopherson wrote: > This series introduces a concept we've discussed a few times in x86 land. > The crux of the problem is that x86 has a few cases where KVM could > theoretically encounter a software or hardware bug deep in a call stack > without any sane way to

Re: [PATCH] KVM: Enable hardware before doing arch VM initialization

2020-09-23 Thread Christian Borntraeger
acai Chen > Cc: Aleksandar Markovic > Cc: linux-m...@vger.kernel.org > Cc: Paul Mackerras > Cc: kvm-...@vger.kernel.org > Cc: Christian Borntraeger > Cc: Janosch Frank > Cc: David Hildenbrand > Cc: Cornelia Huck > Cc: Claudio Imbrenda > Cc: Vitaly Kuznetso

Re: [PATCH v12 0/2] s390: virtio: let arch validate VIRTIO features

2020-09-22 Thread Christian Borntraeger
Michael, are you going to pick this series? On 10.09.20 10:53, Pierre Morel wrote: > Hi all, > > The goal of the series is to give a chance to the architecture > to validate VIRTIO device features. > > I changed VIRTIO_F_IOMMU_PLATFORM to VIRTIO_F_ACCESS_PLATFORM > I forgot in

Re: [PATCH] s390/zcrypt: Fix a size determination in zcrypt_unlocked_ioctl()

2020-09-22 Thread Christian Borntraeger
On 22.09.20 12:30, Zhenzhong Duan wrote: > With new ioctl(ZCRYPT_PERDEV_REQCNT) introduced, kernel use dynamic > allocation for the 256 element array of unsigned integers for the number > of successfully completed requests per device. It's not a static array of > 64 elements any more. > > Fixes:

Re: [PATCH 2/4] s390/pci: track whether util_str is valid in the zpci_dev

2020-09-21 Thread Christian Borntraeger
On 19.09.20 17:28, Matthew Rosato wrote: > We'll need to keep track of whether or not the byte string in util_str is > valid and thus needs to be passed to a vfio-pci passthrough device. > > Signed-off-by: Matthew Rosato If this goes via the vfio tree, Acked-by: Christian

Re: [PATCH 1/4] s390/pci: stash version in the zpci_dev

2020-09-21 Thread Christian Borntraeger
t on: Acked-by: Christian Borntraeger > --- > arch/s390/include/asm/pci.h | 1 + > arch/s390/pci/pci_clp.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h > index 99b92c3..882e233 100644 > --- a/arch

Re: [PATCH] s390/vfio-ap: fix unregister GISC when KVM is already gone results in OOPS

2020-09-20 Thread Christian Borntraeger
On 18.09.20 19:02, Tony Krowiak wrote: > Attempting to unregister Guest Interruption Subclass (GISC) when the > link between the matrix mdev and KVM has been removed results in the > following: > >"Kernel panic -not syncing: Fatal exception: panic_on_oops" I think the full backtrace would

Re: [PATCH v12 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-09-10 Thread Christian Borntraeger
s > the case. > > Signed-off-by: Pierre Morel > Reviewed-by: Cornelia Huck > Reviewed-by: Halil Pasic Acked-by: Christian Borntraeger Michael, I am fine if this patch goes via the virtio tree. > --- > arch/s390/Kconfig | 1 + > arch/s390/mm/init.c | 11 +

Re: [PATCH v12 1/2] virtio: let arch advertise guest's memory access restrictions

2020-09-10 Thread Christian Borntraeger
Signed-off-by: Pierre Morel > Reviewed-by: Cornelia Huck > Reviewed-by: Halil Pasic Acked-by: Christian Borntraeger > --- > drivers/virtio/Kconfig| 6 ++ > drivers/virtio/virtio.c | 15 +++ > include/linux/virtio_config.h | 10 ++ >

Re: [RFC PATCH v2 1/3] mm/gup: fix gup_fast with dynamic page table folding

2020-09-08 Thread Christian Borntraeger
On 08.09.20 07:06, Christophe Leroy wrote: > > > Le 07/09/2020 à 20:00, Gerald Schaefer a écrit : >> From: Alexander Gordeev >> >> Commit 1a42010cdc26 ("s390/mm: convert to the generic get_user_pages_fast >> code") introduced a subtle but severe bug on s390 with gup_fast, due to >> dynamic

Re: [PATCH v10 03/16] s390/vfio-ap: manage link between queue struct and matrix mdev

2020-09-04 Thread Christian Borntraeger
On 21.08.20 21:56, Tony Krowiak wrote: > diff --git a/drivers/s390/crypto/vfio_ap_private.h > b/drivers/s390/crypto/vfio_ap_private.h > index a2aa05bec718..57da703b549a 100644 > --- a/drivers/s390/crypto/vfio_ap_private.h > +++ b/drivers/s390/crypto/vfio_ap_private.h > @@ -87,6 +87,7 @@ struct

Re: [PATCH v10 02/16] s390/vfio-ap: use new AP bus interface to search for queue devices

2020-09-04 Thread Christian Borntraeger
On 21.08.20 21:56, Tony Krowiak wrote: > This patch refactor's the vfio_ap device driver to use the AP bus's > ap_get_qdev() function to retrieve the vfio_ap_queue struct containing > information about a queue that is bound to the vfio_ap device driver. > The bus's ap_get_qdev() function

Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding

2020-08-31 Thread Christian Borntraeger
On 28.08.20 16:03, Gerald Schaefer wrote: [...] > We came up with two possible fix-ups, both will introduce some gup-specific > helper functions, which will have no effect on other archs than s390. > > Patch 1 is the solution that has already been discussed in >

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-16 Thread Christian Borntraeger
ccess >>>> attempt. >>>> >>>> Signed-off-by: Pierre Morel >>>> Reviewed-by: Cornelia Huck >>>> Acked-by: Halil Pasic >>>> Acked-by: Christian Borntraeger >>>> --- >>>> arch/s390/mm/init.c | 28 ++

Re: linux-next: manual merge of the kvms390 tree with the kvm tree

2020-07-15 Thread Christian Borntraeger
On 15.07.20 18:25, Collin Walling wrote: > On 7/13/20 12:50 AM, Stephen Rothwell wrote: >> Hi all, >> >> Today's linux-next merge of the kvms390 tree got a conflict in: >> >> include/uapi/linux/kvm.h >> >> between commit: >> >> 1aa561b1a4c0 ("kvm: x86: Add "last CPU" to some KVM_EXIT

Re: [PATCH v6 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-14 Thread Christian Borntraeger
not the case, preventing a host error on access > attempt. > > Signed-off-by: Pierre Morel > Reviewed-by: Cornelia Huck > Acked-by: Halil Pasic We will probably move this (and other related code) into a new file, but we can do that later. As for now: Acked-by: Christian Borntraeger &

Re: [PATCH v8 04/16] s390/zcrypt: driver callback to indicate resource in use

2020-07-08 Thread Christian Borntraeger
On 05.06.20 23:39, Tony Krowiak wrote: > Introduces a new driver callback to prevent a root user from unbinding > an AP queue from its device driver if the queue is in use. The intent of > this callback is to provide a driver with the means to prevent a root user > from inadvertently taking a

Re: [PATCH v4 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-07 Thread Christian Borntraeger
On 07.07.20 10:44, Pierre Morel wrote: > S390, protecting the guest memory against unauthorized host access > needs to enforce VIRTIO I/O device protection through the use of > VIRTIO_F_VERSION_1 and VIRTIO_F_IOMMU_PLATFORM. > > Signed-off-by: Pierre Morel > --- > arch/s390/kernel/uv.c | 25

Re: [PATCH v4 1/2] virtio: let arch validate VIRTIO features

2020-07-07 Thread Christian Borntraeger
+/* >> + * arch_needs_virtio_iommu_platform - provide arch specific hook when >> finalizing > > s/arch_needs_virtio_iommu_platform/arch_validate_virtio_features/ With the things from Conny fixed, Acked-by: Christian Borntraeger

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Christian Borntraeger
On 01.07.20 17:58, Luis Chamberlain wrote: [...] >>> >>> Ah, well that would be a different fix required, becuase again, >>> br_stp_start() does not untangle the correct error today really. >>> I also I think it would be odd odd that SIGSEGV or another signal >>> is what was terminating

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Christian Borntraeger
On 01.07.20 17:38, Luis Chamberlain wrote: > On Wed, Jul 01, 2020 at 11:08:57PM +0900, Tetsuo Handa wrote: >> On 2020/07/01 22:53, Luis Chamberlain wrote: Well, it is not br_stp_call_user() but br_stp_start() which is expecting to set sub_info->retval for both KWIFEXITED() case and

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Christian Borntraeger
On 01.07.20 15:53, Luis Chamberlain wrote: > On Wed, Jul 01, 2020 at 10:24:29PM +0900, Tetsuo Handa wrote: >> On 2020/07/01 19:08, Christian Borntraeger wrote: >>> >>> >>> On 30.06.20 19:57, Luis Chamberlain wrote: >>>> On Fri, Jun 26,

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Christian Borntraeger
On 30.06.20 19:57, Luis Chamberlain wrote: > On Fri, Jun 26, 2020 at 02:54:10AM +, Luis Chamberlain wrote: >> On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote: >>> >>> >>> On 24.06.20 20:32, Christian Borntraeger wrote: >>>

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-25 Thread Christian Borntraeger
On 26.06.20 04:54, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote: >> >> >> On 24.06.20 20:32, Christian Borntraeger wrote: >> [...]> >>> So the translations look correct. But your change is actually a se

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-25 Thread Christian Borntraeger
On 24.06.20 20:37, Christian Borntraeger wrote: > > > On 24.06.20 20:32, Christian Borntraeger wrote: > [...]> >> So the translations look correct. But your change is actually a sematic >> change >> if(ret) will only trigger if there is an error >> i

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 20:32, Christian Borntraeger wrote: [...]> > So the translations look correct. But your change is actually a sematic change > if(ret) will only trigger if there is an error > if (KWIFEXITED(ret)) will always trigger when the process ends. So we will > always ov

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 20:09, Christian Borntraeger wrote: > > > On 24.06.20 19:58, Christian Borntraeger wrote: >> >> >> On 24.06.20 18:09, Luis Chamberlain wrote: >>> On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: >>>> >

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 19:58, Christian Borntraeger wrote: > > > On 24.06.20 18:09, Luis Chamberlain wrote: >> On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: >>> >>> >>> On 24.06.20 16:43, Christoph Hellwig wrote: >>>&g

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 18:09, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: >> >> >> On 24.06.20 16:43, Christoph Hellwig wrote: >>> On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: >>>&

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 16:43, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: >> Does anyone have an idea why "umh: fix processed error when UMH_WAIT_PROC is >> used" breaks the >> linux-bridge on s390? > > A

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 23.06.20 16:23, Christian Borntraeger wrote: > > > On 23.06.20 16:11, Christian Borntraeger wrote: >> Jens Markwardt reported a regression in the linux-next runs. with "umh: fix >> processed error when UMH_WAIT_PROC is used" (from linux-next) a linux bridge

Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Christian Borntraeger
On 23.06.20 15:14, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. For historical reasons, many kvm-related function parameters > retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This > patch does a unified cleanup of

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-23 Thread Christian Borntraeger
On 23.06.20 16:11, Christian Borntraeger wrote: > Jens Markwardt reported a regression in the linux-next runs. with "umh: fix > processed error when UMH_WAIT_PROC is used" (from linux-next) a linux bridge > with an KVM guests no longer activates : > > without patch &g

linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-23 Thread Christian Borntraeger
Jens Markwardt reported a regression in the linux-next runs. with "umh: fix processed error when UMH_WAIT_PROC is used" (from linux-next) a linux bridge with an KVM guests no longer activates : without patch # ip addr show dev virbr1 6: virbr1: mtu 1500 qdisc noqueue state UP group default

  1   2   3   4   5   6   7   8   9   10   >