Re: [PATCH] mwifiex: fix possible NULL dereference

[Christian Daudt]

On Mon, Apr 11, 2016 at 8:27 AM, Sudip Mukherjee
 wrote:
>
> From: Sudip Mukherjee 
>
> We have a check for card just after dereferencing it. So if it is NULL
> we have already dereferenced it before its check. Lets dereference it
> after checking card for NULL.
>
> Signed-off-by: Sudip Mukherjee 
> ---
>  drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c 
> b/drivers/net/wireless/marvell/mwifiex/pcie.c
> index edf8b07..84562d0 100644
> --- a/drivers/net/wireless/marvell/mwifiex/pcie.c
> +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
> @@ -2884,10 +2884,11 @@ static void mwifiex_unregister_dev(struct 
> mwifiex_adapter *adapter)
>  {
> struct pcie_service_card *card = adapter->card;
> const struct mwifiex_pcie_card_reg *reg;
> -   struct pci_dev *pdev = card->dev;
> +   struct pci_dev *pdev;


you might want to move the variable declaration into the if block
below to avoid it being left undefined

> int i;
>
> if (card) {
> +   pdev = card->dev;


to here
  +struct pci_dev pdev = card->dev;

>
> if (card->msix_enable) {
> for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++)
> synchronize_irq(card->msix_entries[i].vector);
>

cheers,
  csd

Re: [PATCH] mwifiex: fix possible NULL dereference

[Christian Daudt]

On Mon, Apr 11, 2016 at 8:27 AM, Sudip Mukherjee
 wrote:
>
> From: Sudip Mukherjee 
>
> We have a check for card just after dereferencing it. So if it is NULL
> we have already dereferenced it before its check. Lets dereference it
> after checking card for NULL.
>
> Signed-off-by: Sudip Mukherjee 
> ---
>  drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c 
> b/drivers/net/wireless/marvell/mwifiex/pcie.c
> index edf8b07..84562d0 100644
> --- a/drivers/net/wireless/marvell/mwifiex/pcie.c
> +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
> @@ -2884,10 +2884,11 @@ static void mwifiex_unregister_dev(struct 
> mwifiex_adapter *adapter)
>  {
> struct pcie_service_card *card = adapter->card;
> const struct mwifiex_pcie_card_reg *reg;
> -   struct pci_dev *pdev = card->dev;
> +   struct pci_dev *pdev;


you might want to move the variable declaration into the if block
below to avoid it being left undefined

> int i;
>
> if (card) {
> +   pdev = card->dev;


to here
  +struct pci_dev pdev = card->dev;

>
> if (card->msix_enable) {
> for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++)
> synchronize_irq(card->msix_entries[i].vector);
>

cheers,
  csd

Re: [PATCH] mmc: sdhci-bcm-kona: Fix locking in sdhci_bcm_kona_sd_card_emulate()

[Christian Daudt]

On Wed, Mar 5, 2014 at 8:25 PM, Markus Mayer  wrote:
> Since sdhci_bcm_kona_sd_card_emulate() can be called from interrupt
> context, we must use a spinlock instead of a mutex. This change
> essentially restores the way things worked before the change to
> mutexes in http://www.spinics.net/lists/linux-mmc/msg20276.html.
>
> Without this change, we see "scheduling while atomic" errors.
>
> Signed-off-by: Markus Mayer 
> ---

So digging back in memory (since I no longer have the
broadcom-internal email threads on this topic), I think I recall what
the problem is. card_event is being called directly from
mmc_gpio_cd_irqt, which is atomic context. My plan for this was to
delay the card_event callback into the mmc_rescan worker, as that
would have 2 nice results: remove the callback from atomic context
which it doesn't need to be in, and put it in line with the debounced
rescan (which I think it should be). I made mention of that option in
this thread (https://lkml.org/lkml/2013/8/19/539) but seems I never
followed up with code...
 Something along the lines of the (untested) code below might do the trick:

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 098374b..d4ffba8 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2421,6 +2421,11 @@ void mmc_rescan(struct work_struct *work)
  container_of(work, struct mmc_host, detect.work);
  int i;

+ if (host->trigger_card_event && host->ops->card_event) {
+ host->ops->card_event(host);
+ host->trigger_card_event = 0;
+ }
+
  if (host->rescan_disable)
  return;

diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/core/slot-gpio.c
index 46596b71..fc648ae 100644
--- a/drivers/mmc/core/slot-gpio.c
+++ b/drivers/mmc/core/slot-gpio.c
@@ -29,9 +29,7 @@ static irqreturn_t mmc_gpio_cd_irqt(int irq, void *dev_id)
  /* Schedule a card detection after a debounce timeout */
  struct mmc_host *host = dev_id;

- if (host->ops->card_event)
- host->ops->card_event(host);
-
+ host->trigger_card_event = 1;
  mmc_detect_change(host, msecs_to_jiffies(200));

  return IRQ_HANDLED;
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 99f5709..0b6bddf 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -322,6 +322,8 @@ struct mmc_host {
  int rescan_disable; /* disable card detection */
  int rescan_entered; /* used with nonremovable devices */

+ int trigger_card_event; /* card_event necessary */
+
  struct mmc_card *card; /* device attached to this host */

  wait_queue_head_t wq;


Of course there are (a few) more users of card_event callback than
bcm_kona that need to be confirmed ok such a change
 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] mmc: sdhci-bcm-kona: Fix locking in sdhci_bcm_kona_sd_card_emulate()

[Christian Daudt]

On Wed, Mar 5, 2014 at 8:25 PM, Markus Mayer markus.ma...@linaro.org wrote:
 Since sdhci_bcm_kona_sd_card_emulate() can be called from interrupt
 context, we must use a spinlock instead of a mutex. This change
 essentially restores the way things worked before the change to
 mutexes in http://www.spinics.net/lists/linux-mmc/msg20276.html.

 Without this change, we see scheduling while atomic errors.

 Signed-off-by: Markus Mayer markus.ma...@linaro.org
 ---

So digging back in memory (since I no longer have the
broadcom-internal email threads on this topic), I think I recall what
the problem is. card_event is being called directly from
mmc_gpio_cd_irqt, which is atomic context. My plan for this was to
delay the card_event callback into the mmc_rescan worker, as that
would have 2 nice results: remove the callback from atomic context
which it doesn't need to be in, and put it in line with the debounced
rescan (which I think it should be). I made mention of that option in
this thread (https://lkml.org/lkml/2013/8/19/539) but seems I never
followed up with code...
 Something along the lines of the (untested) code below might do the trick:

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 098374b..d4ffba8 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2421,6 +2421,11 @@ void mmc_rescan(struct work_struct *work)
  container_of(work, struct mmc_host, detect.work);
  int i;

+ if (host-trigger_card_event  host-ops-card_event) {
+ host-ops-card_event(host);
+ host-trigger_card_event = 0;
+ }
+
  if (host-rescan_disable)
  return;

diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/core/slot-gpio.c
index 46596b71..fc648ae 100644
--- a/drivers/mmc/core/slot-gpio.c
+++ b/drivers/mmc/core/slot-gpio.c
@@ -29,9 +29,7 @@ static irqreturn_t mmc_gpio_cd_irqt(int irq, void *dev_id)
  /* Schedule a card detection after a debounce timeout */
  struct mmc_host *host = dev_id;

- if (host-ops-card_event)
- host-ops-card_event(host);
-
+ host-trigger_card_event = 1;
  mmc_detect_change(host, msecs_to_jiffies(200));

  return IRQ_HANDLED;
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 99f5709..0b6bddf 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -322,6 +322,8 @@ struct mmc_host {
  int rescan_disable; /* disable card detection */
  int rescan_entered; /* used with nonremovable devices */

+ int trigger_card_event; /* card_event necessary */
+
  struct mmc_card *card; /* device attached to this host */

  wait_queue_head_t wq;


Of course there are (a few) more users of card_event callback than
bcm_kona that need to be confirmed ok such a change
 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [GIT PULL] bcm pinctrl rename

[Christian Daudt]

On Fri, Feb 21, 2014 at 2:29 PM, Olof Johansson  wrote:
> (As per irc discussion). The rename isn't the right thing to do at this
> time in the release, but the binding needs to be tweaked before it ships
> in a full release, or we'll always need to live with it.
>
> So, I'll be happy to take the bindings piece and the dtsi piece (and the
> small edit to the driver to change the compatible string match table),
> but the file rename and Kconfig entry edit is 3.15 material.
>
> Please send new pull request with just that (or, if you prefer, just send the
> patches and we can apply them too).
>

Can you please pull the patches below. Note that if you wanto to
absolutely reduce this to the bone, you can drop the last patch in the
series titled "pinctrl: Rename Broadcom Capri pinctrl binding". That
is the documentation fixup, so the binding doc will be wrong until
3.15. But that will reduce the change to just 2 lines :)
 thanks,
   csd


The following changes since commit cfbf8d4857c26a8a307fb7cd258074c9dcd8c691:

  Linux 3.14-rc4 (2014-02-23 17:40:03 -0800)

are available in the git repository at:

  git://github.com/broadcom/bcm11351.git
tags/bcm-for-3.14-pinctrl-reduced-rename

for you to fetch changes up to 735ea23c4868bf3123a4c79184e9206e0cc60211:

  pinctrl: Rename Broadcom Capri pinctrl binding (2014-02-24 20:25:54 -0800)


Rename pinctrl dt binding to restore consistency with
other bcm mobile bindings.

--------
Christian Daudt (1):
  pinctrl: refer to updated dt binding string.

Sherman Yin (2):
  Update dtsi with new pinctrl compatible string
  pinctrl: Rename Broadcom Capri pinctrl binding

 Documentation/devicetree/bindings/pinctrl/{brcm,capri-pinctrl.txt =>
brcm,bcm11351-pinctrl.txt} | 8 
 arch/arm/boot/dts/bcm11351.dtsi
  | 2 +-
 drivers/pinctrl/pinctrl-capri.c
  | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
 rename Documentation/devicetree/bindings/pinctrl/{brcm,capri-pinctrl.txt
=> brcm,bcm11351-pinctrl.txt} (98%)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [GIT PULL] bcm pinctrl rename

[Christian Daudt]

On Fri, Feb 21, 2014 at 2:29 PM, Olof Johansson  wrote:
> On Wed, Feb 12, 2014 at 09:20:13AM -0800, Christian Daudt wrote:
>> The following changes since commit b28a960c42fcd9cfc987441fa6d1c1a471f0f9ed:
>>
>>   Linux 3.14-rc2 (2014-02-09 18:15:47 -0800)
>>
>> are available in the git repository at:
>>
>>   git://github.com/broadcom/bcm11351.git tags/bcm-for-3.14-pinctrl-rename
>>
>> for you to fetch changes up to f5310a1712b68c7f83539fce6ebbfb6f0f510f5b:
>>
>>   Update dtsi with new pinctrl compatible string (2014-02-12 09:06:53 -0800)
>>
>> 
>> Renaming pinctrl code to keep in line with rest of bcm mobile
>>
>> Given that this driver has been in the works for a while, it
>> was written prior to the code standardizing on bcm-based naming.
>> this patchset brings it in line with the remainder of the code.
>>
>> 
>> Sherman Yin (4):
>>   pinctrl: Rename Broadcom Capri pinctrl binding
>>   pinctrl: Rename Broadcom Capri pinctrl driver
>>   Update bcm_defconfig with new pinctrl CONFIG
>>   Update dtsi with new pinctrl compatible string
>
> Hi,
>
> (As per irc discussion). The rename isn't the right thing to do at this
> time in the release, but the binding needs to be tweaked before it ships
> in a full release, or we'll always need to live with it.
>
> So, I'll be happy to take the bindings piece and the dtsi piece (and the
> small edit to the driver to change the compatible string match table),
> but the file rename and Kconfig entry edit is 3.15 material.
>
> Please send new pull request with just that (or, if you prefer, just send the
> patches and we can apply them too).
>
>
> -Olof

Ok, I have this ready to go, just need an ack for this patch (which
will replace "pinctrl: Rename Broadcom Capri pinctrl driver"):
Subject: [PATCH] pinctrl: refer to updated dt binding string.

Bring the driver in line with the bcm-based dt name for pinctrl.
This is being done to keep consistency with other Broadcom mobile
SoC drivers.

Signed-off-by: Christian Daudt 

diff --git a/drivers/pinctrl/pinctrl-capri.c b/drivers/pinctrl/pinctrl-capri.c
index 4669c53..eb25002 100644
--- a/drivers/pinctrl/pinctrl-capri.c
+++ b/drivers/pinctrl/pinctrl-capri.c
@@ -1435,7 +1435,7 @@ int __init capri_pinctrl_probe(struct
platform_device *pdev)
 }

 static struct of_device_id capri_pinctrl_of_match[] = {
-   { .compatible = "brcm,capri-pinctrl", },
+   { .compatible = "brcm,bcm11351-pinctrl", },
{ },
 };

-- 
1.8.3.2


Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [GIT PULL] bcm pinctrl rename

[Christian Daudt]

On Fri, Feb 21, 2014 at 2:29 PM, Olof Johansson o...@lixom.net wrote:
 On Wed, Feb 12, 2014 at 09:20:13AM -0800, Christian Daudt wrote:
 The following changes since commit b28a960c42fcd9cfc987441fa6d1c1a471f0f9ed:

   Linux 3.14-rc2 (2014-02-09 18:15:47 -0800)

 are available in the git repository at:

   git://github.com/broadcom/bcm11351.git tags/bcm-for-3.14-pinctrl-rename

 for you to fetch changes up to f5310a1712b68c7f83539fce6ebbfb6f0f510f5b:

   Update dtsi with new pinctrl compatible string (2014-02-12 09:06:53 -0800)

 
 Renaming pinctrl code to keep in line with rest of bcm mobile

 Given that this driver has been in the works for a while, it
 was written prior to the code standardizing on bcm-based naming.
 this patchset brings it in line with the remainder of the code.

 
 Sherman Yin (4):
   pinctrl: Rename Broadcom Capri pinctrl binding
   pinctrl: Rename Broadcom Capri pinctrl driver
   Update bcm_defconfig with new pinctrl CONFIG
   Update dtsi with new pinctrl compatible string

 Hi,

 (As per irc discussion). The rename isn't the right thing to do at this
 time in the release, but the binding needs to be tweaked before it ships
 in a full release, or we'll always need to live with it.

 So, I'll be happy to take the bindings piece and the dtsi piece (and the
 small edit to the driver to change the compatible string match table),
 but the file rename and Kconfig entry edit is 3.15 material.

 Please send new pull request with just that (or, if you prefer, just send the
 patches and we can apply them too).


 -Olof

Ok, I have this ready to go, just need an ack for this patch (which
will replace pinctrl: Rename Broadcom Capri pinctrl driver):
Subject: [PATCH] pinctrl: refer to updated dt binding string.

Bring the driver in line with the bcm-based dt name for pinctrl.
This is being done to keep consistency with other Broadcom mobile
SoC drivers.

Signed-off-by: Christian Daudt b...@fixthebug.org

diff --git a/drivers/pinctrl/pinctrl-capri.c b/drivers/pinctrl/pinctrl-capri.c
index 4669c53..eb25002 100644
--- a/drivers/pinctrl/pinctrl-capri.c
+++ b/drivers/pinctrl/pinctrl-capri.c
@@ -1435,7 +1435,7 @@ int __init capri_pinctrl_probe(struct
platform_device *pdev)
 }

 static struct of_device_id capri_pinctrl_of_match[] = {
-   { .compatible = brcm,capri-pinctrl, },
+   { .compatible = brcm,bcm11351-pinctrl, },
{ },
 };

-- 
1.8.3.2


Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [GIT PULL] bcm pinctrl rename

[Christian Daudt]

On Fri, Feb 21, 2014 at 2:29 PM, Olof Johansson o...@lixom.net wrote:
 (As per irc discussion). The rename isn't the right thing to do at this
 time in the release, but the binding needs to be tweaked before it ships
 in a full release, or we'll always need to live with it.

 So, I'll be happy to take the bindings piece and the dtsi piece (and the
 small edit to the driver to change the compatible string match table),
 but the file rename and Kconfig entry edit is 3.15 material.

 Please send new pull request with just that (or, if you prefer, just send the
 patches and we can apply them too).


Can you please pull the patches below. Note that if you wanto to
absolutely reduce this to the bone, you can drop the last patch in the
series titled pinctrl: Rename Broadcom Capri pinctrl binding. That
is the documentation fixup, so the binding doc will be wrong until
3.15. But that will reduce the change to just 2 lines :)
 thanks,
   csd


The following changes since commit cfbf8d4857c26a8a307fb7cd258074c9dcd8c691:

  Linux 3.14-rc4 (2014-02-23 17:40:03 -0800)

are available in the git repository at:

  git://github.com/broadcom/bcm11351.git
tags/bcm-for-3.14-pinctrl-reduced-rename

for you to fetch changes up to 735ea23c4868bf3123a4c79184e9206e0cc60211:

  pinctrl: Rename Broadcom Capri pinctrl binding (2014-02-24 20:25:54 -0800)


Rename pinctrl dt binding to restore consistency with
other bcm mobile bindings.


Christian Daudt (1):
  pinctrl: refer to updated dt binding string.

Sherman Yin (2):
  Update dtsi with new pinctrl compatible string
  pinctrl: Rename Broadcom Capri pinctrl binding

 Documentation/devicetree/bindings/pinctrl/{brcm,capri-pinctrl.txt =
brcm,bcm11351-pinctrl.txt} | 8 
 arch/arm/boot/dts/bcm11351.dtsi
  | 2 +-
 drivers/pinctrl/pinctrl-capri.c
  | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
 rename Documentation/devicetree/bindings/pinctrl/{brcm,capri-pinctrl.txt
= brcm,bcm11351-pinctrl.txt} (98%)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: dts: remove bcm11351-brt.dts

[Christian Daudt]

On Wed, Feb 19, 2014 at 1:31 PM, Matt Porter  wrote:
> The BCM11351 BRT board will never see the light of day. Remove the BRT
> dts since it is not maintainable.
>
> Reviewed-by: Alex Elder 
> Signed-off-by: Matt Porter 
> ---
> Changes since v1:
> - remove bcm11351-brt from Makefile
>
>  arch/arm/boot/dts/Makefile |  3 +--
>  arch/arm/boot/dts/bcm11351-brt.dts | 54 
> --
>  2 files changed, 1 insertion(+), 56 deletions(-)
>  delete mode 100644 arch/arm/boot/dts/bcm11351-brt.dts
>

R.I.P bcm11351...

Reviewed-by: Christian Daudt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: dts: remove bcm11351-brt.dts

[Christian Daudt]

On Wed, Feb 19, 2014 at 1:31 PM, Matt Porter mpor...@linaro.org wrote:
 The BCM11351 BRT board will never see the light of day. Remove the BRT
 dts since it is not maintainable.

 Reviewed-by: Alex Elder el...@linaro.org
 Signed-off-by: Matt Porter mpor...@linaro.org
 ---
 Changes since v1:
 - remove bcm11351-brt from Makefile

  arch/arm/boot/dts/Makefile |  3 +--
  arch/arm/boot/dts/bcm11351-brt.dts | 54 
 --
  2 files changed, 1 insertion(+), 56 deletions(-)
  delete mode 100644 arch/arm/boot/dts/bcm11351-brt.dts


R.I.P bcm11351...

Reviewed-by: Christian Daudt b...@fixthebug.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 12/28] Remove GENERIC_TIME

[Christian Daudt]

On Sun, Feb 9, 2014 at 12:02 PM, Richard Weinberger  wrote:
> Am 09.02.2014 19:57, schrieb Alexander Shiyan:
>>> The symbol is an orphan, get rid of it.
>>>
>>> Signed-off-by: Richard Weinberger 
>>> ---
>>> arch/arm/mach-bcm/Kconfig | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
>>> index b1aa6a9..8dd5fbf 100644
>>> --- a/arch/arm/mach-bcm/Kconfig
>>> +++ b/arch/arm/mach-bcm/Kconfig
>>> @@ -19,7 +19,6 @@ config ARCH_BCM_MOBILE
>>> select CPU_V7
>>> select CLKSRC_OF
>>> select GENERIC_CLOCKEVENTS
>>> -select GENERIC_TIME
>>> select GPIO_BCM_KONA
>>> select SPARSE_IRQ
>>> select TICK_ONESHOT
>>> --
>>> 1.8.4.2
>>

Applied to armsoc/for-3.15/soc
Also added signed-off-by for Alexander Shyian and Paul Bolle.

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 12/28] Remove GENERIC_TIME

[Christian Daudt]

On Sun, Feb 9, 2014 at 12:02 PM, Richard Weinberger rich...@nod.at wrote:
 Am 09.02.2014 19:57, schrieb Alexander Shiyan:
 The symbol is an orphan, get rid of it.

 Signed-off-by: Richard Weinberger rich...@nod.at
 ---
 arch/arm/mach-bcm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

 diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
 index b1aa6a9..8dd5fbf 100644
 --- a/arch/arm/mach-bcm/Kconfig
 +++ b/arch/arm/mach-bcm/Kconfig
 @@ -19,7 +19,6 @@ config ARCH_BCM_MOBILE
 select CPU_V7
 select CLKSRC_OF
 select GENERIC_CLOCKEVENTS
 -select GENERIC_TIME
 select GPIO_BCM_KONA
 select SPARSE_IRQ
 select TICK_ONESHOT
 --
 1.8.4.2


Applied to armsoc/for-3.15/soc
Also added signed-off-by for Alexander Shyian and Paul Bolle.

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] MAINTAINERS: Add Broadcom GPIO maintainer

[Christian Daudt]

On Wed, Feb 12, 2014 at 3:42 PM, Markus Mayer  wrote:
> List myself as maintainer for Broadcom's Kona GPIO driver.
>
> Signed-off-by: Markus Mayer 
> ---
>
> Does that look like a reasonable way to make this change? I added the
> entry alphabetically in the BROADCOM section.
>
>  MAINTAINERS |7 +++
>  1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b2cf5cf..896cf2b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1909,6 +1909,13 @@ L:   linux-s...@vger.kernel.org
>  S: Supported
>  F: drivers/scsi/bnx2i/
>
> +BROADCOM KONA GPIO DRIVER
> +M: Markus Mayer 
> +L: bcm-kernel-feedback-l...@broadcom.com
> +S: Supported
> +F: drivers/gpio/gpio-bcm-kona.c
> +F: Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt
> +
>  BROADCOM SPECIFIC AMBA DRIVER (BCMA)
>  M: Rafał Miłecki 
>  L: linux-wirel...@vger.kernel.org
> --
> 1.7.9.5
>
Acked-by: Christian Daudt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] MAINTAINERS: add additional ARM BCM281xx/BCM11xxx maintainer

[Christian Daudt]

On Fri, Feb 14, 2014 at 7:15 AM, Matt Porter  wrote:
> Add myself as an additional maintainer for the Broadcom mobile
> SoCs.
>
> Signed-off-by: Matt Porter 
> ---
> Since v1: put back my missing SOB
>
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b2cf5cf..9d6fbfd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1860,6 +1860,7 @@ F:drivers/net/ethernet/broadcom/bnx2x/
>
>  BROADCOM BCM281XX/BCM11XXX ARM ARCHITECTURE
>  M: Christian Daudt 
> +M: Matt Porter 
>  L: bcm-kernel-feedback-l...@broadcom.com
>  T: git git://git.github.com/broadcom/bcm11351
>  S: Maintained
> --
> 1.8.4
>
Acked-by: Christian Daudt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] MAINTAINERS: add additional ARM BCM281xx/BCM11xxx maintainer

[Christian Daudt]

On Fri, Feb 14, 2014 at 7:15 AM, Matt Porter mpor...@linaro.org wrote:
 Add myself as an additional maintainer for the Broadcom mobile
 SoCs.

 Signed-off-by: Matt Porter mpor...@linaro.org
 ---
 Since v1: put back my missing SOB

  MAINTAINERS | 1 +
  1 file changed, 1 insertion(+)

 diff --git a/MAINTAINERS b/MAINTAINERS
 index b2cf5cf..9d6fbfd 100644
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
 @@ -1860,6 +1860,7 @@ F:drivers/net/ethernet/broadcom/bnx2x/

  BROADCOM BCM281XX/BCM11XXX ARM ARCHITECTURE
  M: Christian Daudt b...@fixthebug.org
 +M: Matt Porter mpor...@linaro.org
  L: bcm-kernel-feedback-l...@broadcom.com
  T: git git://git.github.com/broadcom/bcm11351
  S: Maintained
 --
 1.8.4

Acked-by: Christian Daudt b...@fixthebug.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] MAINTAINERS: Add Broadcom GPIO maintainer

[Christian Daudt]

On Wed, Feb 12, 2014 at 3:42 PM, Markus Mayer markus.ma...@linaro.org wrote:
 List myself as maintainer for Broadcom's Kona GPIO driver.

 Signed-off-by: Markus Mayer markus.ma...@linaro.org
 ---

 Does that look like a reasonable way to make this change? I added the
 entry alphabetically in the BROADCOM section.

  MAINTAINERS |7 +++
  1 file changed, 7 insertions(+)

 diff --git a/MAINTAINERS b/MAINTAINERS
 index b2cf5cf..896cf2b 100644
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
 @@ -1909,6 +1909,13 @@ L:   linux-s...@vger.kernel.org
  S: Supported
  F: drivers/scsi/bnx2i/

 +BROADCOM KONA GPIO DRIVER
 +M: Markus Mayer markus.ma...@linaro.org
 +L: bcm-kernel-feedback-l...@broadcom.com
 +S: Supported
 +F: drivers/gpio/gpio-bcm-kona.c
 +F: Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt
 +
  BROADCOM SPECIFIC AMBA DRIVER (BCMA)
  M: Rafał Miłecki zaj...@gmail.com
  L: linux-wirel...@vger.kernel.org
 --
 1.7.9.5

Acked-by: Christian Daudt b...@fixthebug.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[GIT PULL] bcm pinctrl rename

[Christian Daudt]

The following changes since commit b28a960c42fcd9cfc987441fa6d1c1a471f0f9ed:

  Linux 3.14-rc2 (2014-02-09 18:15:47 -0800)

are available in the git repository at:

  git://github.com/broadcom/bcm11351.git tags/bcm-for-3.14-pinctrl-rename

for you to fetch changes up to f5310a1712b68c7f83539fce6ebbfb6f0f510f5b:

  Update dtsi with new pinctrl compatible string (2014-02-12 09:06:53 -0800)


Renaming pinctrl code to keep in line with rest of bcm mobile

Given that this driver has been in the works for a while, it
was written prior to the code standardizing on bcm-based naming.
this patchset brings it in line with the remainder of the code.


Sherman Yin (4):
  pinctrl: Rename Broadcom Capri pinctrl binding
  pinctrl: Rename Broadcom Capri pinctrl driver
  Update bcm_defconfig with new pinctrl CONFIG
  Update dtsi with new pinctrl compatible string

 .../bindings/pinctrl/{brcm,capri-pinctrl.txt =>
brcm,bcm11351-pinctrl.txt}|8 +-
 arch/arm/boot/dts/bcm11351.dtsi
|2 +-
 arch/arm/configs/bcm_defconfig
|2 +-
 drivers/pinctrl/Kconfig
|8 +-
 drivers/pinctrl/Makefile
|2 +-
 drivers/pinctrl/pinctrl-bcm281xx.c
| 1461 ++
 drivers/pinctrl/pinctrl-capri.c
| 1454 -
 7 files changed, 1472 insertions(+), 1465 deletions(-)
 rename Documentation/devicetree/bindings/pinctrl/{brcm,capri-pinctrl.txt
=> brcm,bcm11351-pinctrl.txt} (98%)
 create mode 100644 drivers/pinctrl/pinctrl-bcm281xx.c
 delete mode 100644 drivers/pinctrl/pinctrl-capri.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[GIT PULL] bcm pinctrl rename

[Christian Daudt]

The following changes since commit b28a960c42fcd9cfc987441fa6d1c1a471f0f9ed:

  Linux 3.14-rc2 (2014-02-09 18:15:47 -0800)

are available in the git repository at:

  git://github.com/broadcom/bcm11351.git tags/bcm-for-3.14-pinctrl-rename

for you to fetch changes up to f5310a1712b68c7f83539fce6ebbfb6f0f510f5b:

  Update dtsi with new pinctrl compatible string (2014-02-12 09:06:53 -0800)


Renaming pinctrl code to keep in line with rest of bcm mobile

Given that this driver has been in the works for a while, it
was written prior to the code standardizing on bcm-based naming.
this patchset brings it in line with the remainder of the code.


Sherman Yin (4):
  pinctrl: Rename Broadcom Capri pinctrl binding
  pinctrl: Rename Broadcom Capri pinctrl driver
  Update bcm_defconfig with new pinctrl CONFIG
  Update dtsi with new pinctrl compatible string

 .../bindings/pinctrl/{brcm,capri-pinctrl.txt =
brcm,bcm11351-pinctrl.txt}|8 +-
 arch/arm/boot/dts/bcm11351.dtsi
|2 +-
 arch/arm/configs/bcm_defconfig
|2 +-
 drivers/pinctrl/Kconfig
|8 +-
 drivers/pinctrl/Makefile
|2 +-
 drivers/pinctrl/pinctrl-bcm281xx.c
| 1461 ++
 drivers/pinctrl/pinctrl-capri.c
| 1454 -
 7 files changed, 1472 insertions(+), 1465 deletions(-)
 rename Documentation/devicetree/bindings/pinctrl/{brcm,capri-pinctrl.txt
= brcm,bcm11351-pinctrl.txt} (98%)
 create mode 100644 drivers/pinctrl/pinctrl-bcm281xx.c
 delete mode 100644 drivers/pinctrl/pinctrl-capri.c
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pinctrl: capri: Make capri_pinctrl_probe static

[Christian Daudt]

On Fri, Feb 7, 2014 at 10:35 AM, Christian Daudt  wrote:
> On Thu, Feb 6, 2014 at 1:21 AM, Linus Walleij  
> wrote:
>> On Tue, Feb 4, 2014 at 9:13 PM, Sherman Yin  wrote:
>>> On 14-02-04 12:49 AM, Axel Lin wrote:
>>>>
>>>> Signed-off-by: Axel Lin 
>>>>
>>> Note that this will collide with the capri->bcm281xx renaming patches.
>>>
>>> Linus, Christian, are those patches going in soon?
>>
>> I have ACKed it, expecting it to be funneled through ARM SoC.
>>
>> Yours,
>> Linus Walleij
>
> Linus, just to confirm. the bcm_defconfig portion is the only one
> going through armsoc right ?
>
>  thanks,
>csd

Linus,
 Sorry for the noise. I just had a chat with Olof on irc and it is
probably best to revert to v1 and push a single patch through, either
through pinctrl or armsoc. If you have further patches for 3.14 could
you pull this one in along with it ? If not then I'll ask Olof to pull
it in instead.
 thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pinctrl: capri: Make capri_pinctrl_probe static

[Christian Daudt]

On Thu, Feb 6, 2014 at 1:21 AM, Linus Walleij  wrote:
> On Tue, Feb 4, 2014 at 9:13 PM, Sherman Yin  wrote:
>> On 14-02-04 12:49 AM, Axel Lin wrote:
>>>
>>> Signed-off-by: Axel Lin 
>>>
>> Note that this will collide with the capri->bcm281xx renaming patches.
>>
>> Linus, Christian, are those patches going in soon?
>
> I have ACKed it, expecting it to be funneled through ARM SoC.
>
> Yours,
> Linus Walleij

Linus, just to confirm. the bcm_defconfig portion is the only one
going through armsoc right ?

 thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pinctrl: capri: Make capri_pinctrl_probe static

[Christian Daudt]

On Thu, Feb 6, 2014 at 1:21 AM, Linus Walleij linus.wall...@linaro.org wrote:
 On Tue, Feb 4, 2014 at 9:13 PM, Sherman Yin s...@broadcom.com wrote:
 On 14-02-04 12:49 AM, Axel Lin wrote:

 Signed-off-by: Axel Lin axel@ingics.com

 Note that this will collide with the capri-bcm281xx renaming patches.

 Linus, Christian, are those patches going in soon?

 I have ACKed it, expecting it to be funneled through ARM SoC.

 Yours,
 Linus Walleij

Linus, just to confirm. the bcm_defconfig portion is the only one
going through armsoc right ?

 thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pinctrl: capri: Make capri_pinctrl_probe static

[Christian Daudt]

On Fri, Feb 7, 2014 at 10:35 AM, Christian Daudt b...@fixthebug.org wrote:
 On Thu, Feb 6, 2014 at 1:21 AM, Linus Walleij linus.wall...@linaro.org 
 wrote:
 On Tue, Feb 4, 2014 at 9:13 PM, Sherman Yin s...@broadcom.com wrote:
 On 14-02-04 12:49 AM, Axel Lin wrote:

 Signed-off-by: Axel Lin axel@ingics.com

 Note that this will collide with the capri-bcm281xx renaming patches.

 Linus, Christian, are those patches going in soon?

 I have ACKed it, expecting it to be funneled through ARM SoC.

 Yours,
 Linus Walleij

 Linus, just to confirm. the bcm_defconfig portion is the only one
 going through armsoc right ?

  thanks,
csd

Linus,
 Sorry for the noise. I just had a chat with Olof on irc and it is
probably best to revert to v1 and push a single patch through, either
through pinctrl or armsoc. If you have further patches for 3.14 could
you pull this one in along with it ? If not then I'll ask Olof to pull
it in instead.
 thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 3/4] Update bcm_defconfig with new pinctrl CONFIG

[Christian Daudt]

On Thu, Jan 23, 2014 at 12:44 PM, Sherman Yin  wrote:
> To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl
> driver and its related CONFIG option are renamed to bcm281xx.
>
> This commit updates the defconfig that enables the pinctrl driver.
>
> Signed-off-by: Sherman Yin 
> Reviewed-by: Matt Porter 
> Acked-by: Linus Walleij 
> ---
>  arch/arm/configs/bcm_defconfig |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> index bede511..53d6d47 100644
> --- a/arch/arm/configs/bcm_defconfig
> +++ b/arch/arm/configs/bcm_defconfig
> @@ -126,4 +126,4 @@ CONFIG_CRC_ITU_T=y
>  CONFIG_CRC7=y
>  CONFIG_XZ_DEC=y
>  CONFIG_AVERAGE=y
> -CONFIG_PINCTRL_CAPRI=y
> +CONFIG_PINCTRL_BCM281XX=y
> --
> 1.7.9.5
>

Acked-by: Christian Daudt 

Olof,
 Can you apply this patch directly or do you want me to send a pull
request with it ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 3/4] Update bcm_defconfig with new pinctrl CONFIG

[Christian Daudt]

On Thu, Jan 23, 2014 at 12:44 PM, Sherman Yin s...@broadcom.com wrote:
 To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl
 driver and its related CONFIG option are renamed to bcm281xx.

 This commit updates the defconfig that enables the pinctrl driver.

 Signed-off-by: Sherman Yin s...@broadcom.com
 Reviewed-by: Matt Porter mpor...@linaro.org
 Acked-by: Linus Walleij linus.wall...@linaro.org
 ---
  arch/arm/configs/bcm_defconfig |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
 index bede511..53d6d47 100644
 --- a/arch/arm/configs/bcm_defconfig
 +++ b/arch/arm/configs/bcm_defconfig
 @@ -126,4 +126,4 @@ CONFIG_CRC_ITU_T=y
  CONFIG_CRC7=y
  CONFIG_XZ_DEC=y
  CONFIG_AVERAGE=y
 -CONFIG_PINCTRL_CAPRI=y
 +CONFIG_PINCTRL_BCM281XX=y
 --
 1.7.9.5


Acked-by: Christian Daudt b...@fixthebug.org

Olof,
 Can you apply this patch directly or do you want me to send a pull
request with it ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

[Christian Daudt]

On Wed, Jan 8, 2014 at 4:28 PM, Tim Kryger  wrote:
> On Wed, Jan 8, 2014 at 3:38 PM, Christian Daudt  wrote:
>> On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger  wrote:
>>> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
>>> when card is inserted" so the polarity has been updated to active low.
>>>
>>> Polarity is now specified with a GPIO define instead of a magic number.
>>>
>>> Signed-off-by: Tim Kryger 
>>> Reviewed-by: Matt Porter 
>>> ---
>>>  arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts 
>>> b/arch/arm/boot/dts/bcm28155-ap.dts
>>> index 08e47c2..27dd110 100644
>>> --- a/arch/arm/boot/dts/bcm28155-ap.dts
>>> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
>>> @@ -13,6 +13,8 @@
>>>
>>>  /dts-v1/;
>>>
>>> +#include 
>>> +
>>>  #include "bcm11351.dtsi"
>>>
>>>  / {
>>> @@ -40,7 +42,7 @@
>>>
>>> sdio4: sdio@3f1b {
>>> max-frequency = <4800>;
>>> -   cd-gpios = < 14 0>;
>>> +   cd-gpios = < 14 GPIO_ACTIVE_LOW>;
>>> status = "okay";
>>> };
>>>  };
>>> --
>>> 1.8.0.1
>>>
>> Tim,
>>  Does bcm11351-brt not also suffer from the same bug? If it does can
>> you pls update the patch to also fix it?
>>
>>  Thanks,
>>csd
>
> The BRT and AP boards are similar so it may have the same problem but
> I don't have a BRT and wouldn't be able to test any changes to its DTS
> file.
>
> -Tim

[sorry for the resend for those that get it twice]
Agreed - it's time that dts file go away. In this case:
Acked-by: Christian Daudt 

Olof - can you pls pull in this patch. This is the bugfix that was
discussed in irc earlier today.

 thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

[Christian Daudt]

On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger  wrote:
> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
> when card is inserted" so the polarity has been updated to active low.
>
> Polarity is now specified with a GPIO define instead of a magic number.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Matt Porter 
> ---
>  arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts 
> b/arch/arm/boot/dts/bcm28155-ap.dts
> index 08e47c2..27dd110 100644
> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> @@ -13,6 +13,8 @@
>
>  /dts-v1/;
>
> +#include 
> +
>  #include "bcm11351.dtsi"
>
>  / {
> @@ -40,7 +42,7 @@
>
> sdio4: sdio@3f1b {
> max-frequency = <4800>;
> -   cd-gpios = < 14 0>;
> +   cd-gpios = < 14 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>  };
> --
> 1.8.0.1
>
Tim,
 Does bcm11351-brt not also suffer from the same bug? If it does can
you pls update the patch to also fix it?

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

[Christian Daudt]

On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger tim.kry...@linaro.org wrote:
 The board schematic states that the SD_CARD_DET_N gets pulled to GND
 when card is inserted so the polarity has been updated to active low.

 Polarity is now specified with a GPIO define instead of a magic number.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

 diff --git a/arch/arm/boot/dts/bcm28155-ap.dts 
 b/arch/arm/boot/dts/bcm28155-ap.dts
 index 08e47c2..27dd110 100644
 --- a/arch/arm/boot/dts/bcm28155-ap.dts
 +++ b/arch/arm/boot/dts/bcm28155-ap.dts
 @@ -13,6 +13,8 @@

  /dts-v1/;

 +#include dt-bindings/gpio/gpio.h
 +
  #include bcm11351.dtsi

  / {
 @@ -40,7 +42,7 @@

 sdio4: sdio@3f1b {
 max-frequency = 4800;
 -   cd-gpios = gpio 14 0;
 +   cd-gpios = gpio 14 GPIO_ACTIVE_LOW;
 status = okay;
 };
  };
 --
 1.8.0.1

Tim,
 Does bcm11351-brt not also suffer from the same bug? If it does can
you pls update the patch to also fix it?

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

[Christian Daudt]

On Wed, Jan 8, 2014 at 4:28 PM, Tim Kryger tim.kry...@linaro.org wrote:
 On Wed, Jan 8, 2014 at 3:38 PM, Christian Daudt b...@fixthebug.org wrote:
 On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger tim.kry...@linaro.org wrote:
 The board schematic states that the SD_CARD_DET_N gets pulled to GND
 when card is inserted so the polarity has been updated to active low.

 Polarity is now specified with a GPIO define instead of a magic number.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

 diff --git a/arch/arm/boot/dts/bcm28155-ap.dts 
 b/arch/arm/boot/dts/bcm28155-ap.dts
 index 08e47c2..27dd110 100644
 --- a/arch/arm/boot/dts/bcm28155-ap.dts
 +++ b/arch/arm/boot/dts/bcm28155-ap.dts
 @@ -13,6 +13,8 @@

  /dts-v1/;

 +#include dt-bindings/gpio/gpio.h
 +
  #include bcm11351.dtsi

  / {
 @@ -40,7 +42,7 @@

 sdio4: sdio@3f1b {
 max-frequency = 4800;
 -   cd-gpios = gpio 14 0;
 +   cd-gpios = gpio 14 GPIO_ACTIVE_LOW;
 status = okay;
 };
  };
 --
 1.8.0.1

 Tim,
  Does bcm11351-brt not also suffer from the same bug? If it does can
 you pls update the patch to also fix it?

  Thanks,
csd

 The BRT and AP boards are similar so it may have the same problem but
 I don't have a BRT and wouldn't be able to test any changes to its DTS
 file.

 -Tim

[sorry for the resend for those that get it twice]
Agreed - it's time that dts file go away. In this case:
Acked-by: Christian Daudt b...@fixthebug.org

Olof - can you pls pull in this patch. This is the bugfix that was
discussed in irc earlier today.

 thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks

[Christian Daudt]

On Sat, Dec 14, 2013 at 12:14 AM, Christian Daudt  wrote:
> On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
>> Enable the external clock needed by the host controller during the
>> probe and disable it during the remove.
>>
>> Signed-off-by: Tim Kryger 
>> Reviewed-by: Markus Mayer 
>> Reviewed-by: Matt Porter 
>
> Reviewed-by: Christian Daudt 
>
> Chris,
>  Are you ok with me pulling this patch along with the rest of the
> patchset into the bcm tree?
>
>  Thanks,
>csd
Hi Chris,
 I'm hoping to get this patchset and "rename ARCH_BCM to
ARCH_BCM_MOBILE (mmc)" patch into 3.14 still, and these 2 patches are
waiting for your ack and confirmation that you're ok with me pulling
them through armsoc. Can you pls review them ?

 Thanks,
  csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v8 9/9] ARM: dts: add usb udc support to bcm281xx

[Christian Daudt]

On Thu, Dec 19, 2013 at 6:23 AM, Matt Porter  wrote:
> Adds USB OTG/PHY and clock support to BCM281xx and enables
> UDC support on the bcm11351-brt and bcm28155-ap boards.
>
> Signed-off-by: Matt Porter 
> Reviewed-by: Markus Mayer 
> Reviewed-by: Tim Kryger 

Applied to armsoc/for-3.14/dt

 thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v8 9/9] ARM: dts: add usb udc support to bcm281xx

[Christian Daudt]

On Thu, Dec 19, 2013 at 6:23 AM, Matt Porter mpor...@linaro.org wrote:
 Adds USB OTG/PHY and clock support to BCM281xx and enables
 UDC support on the bcm11351-brt and bcm28155-ap boards.

 Signed-off-by: Matt Porter mpor...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Tim Kryger tim.kry...@linaro.org

Applied to armsoc/for-3.14/dt

 thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks

[Christian Daudt]

On Sat, Dec 14, 2013 at 12:14 AM, Christian Daudt b...@fixthebug.org wrote:
 On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 Enable the external clock needed by the host controller during the
 probe and disable it during the remove.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org

 Reviewed-by: Christian Daudt b...@fixthebug.org

 Chris,
  Are you ok with me pulling this patch along with the rest of the
 patchset into the bcm tree?

  Thanks,
csd
Hi Chris,
 I'm hoping to get this patchset and rename ARCH_BCM to
ARCH_BCM_MOBILE (mmc) patch into 3.14 still, and these 2 patches are
waiting for your ack and confirmation that you're ok with me pulling
them through armsoc. Can you pls review them ?

 Thanks,
  csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 7/8] clocksource: kona: Add basic use of external clock

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
> When an clock is specified in the device tree, enable it and use it to
> determine the external clock frequency.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> Reviewed-by: Matt Porter 
> ---

Reviewed-by: Christian Daudt 

Daniel,
 Are you ok with me pulling this patch in with the rest of the
patchset into the bcm tree ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 6/8] Documentation: dt: kona-timer: Add clocks property

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
> The frequency for the Kona timer can either be specified through the
> device tree or determined by checking the rate of the clock specified
> in the device tree.  Update the documentation to reflect both ways.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Matt Porter 
> ---
>  Documentation/devicetree/bindings/arm/bcm/kona-timer.txt | 7 ++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/kona-timer.txt 
> b/Documentation/devicetree/bindings/arm/bcm/kona-timer.txt
> index 17d88b2..39adf54 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/kona-timer.txt
> +++ b/Documentation/devicetree/bindings/arm/bcm/kona-timer.txt
> @@ -8,13 +8,18 @@ Required properties:
>  - DEPRECATED: compatible : "bcm,kona-timer"
>  - reg : Register range for the timer
>  - interrupts : interrupt for the timer
> +- clocks: phandle + clock specifier pair of the external clock
>  - clock-frequency: frequency that the clock operates
>
> +Only one of clocks or clock-frequency should be specified.
> +
> +Refer to clocks/clock-bindings.txt for generic clock consumer properties.
> +
>  Example:
> timer@35006000 {
> compatible = "brcm,kona-timer";
> reg = <0x35006000 0x1000>;
> interrupts = <0x0 7 0x4>;
> -   clock-frequency = <32768>;
> +   clocks = <_timer_clk>;
> };
>
> --
> 1.8.0.1
>
Reviewed-by: Christian Daudt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
> Enable the external clock needed by the host controller during the
> probe and disable it during the remove.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> Reviewed-by: Matt Porter 

Reviewed-by: Christian Daudt 

Chris,
 Are you ok with me pulling this patch along with the rest of the
patchset into the bcm tree?

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 Enable the external clock needed by the host controller during the
 probe and disable it during the remove.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org

Reviewed-by: Christian Daudt b...@fixthebug.org

Chris,
 Are you ok with me pulling this patch along with the rest of the
patchset into the bcm tree?

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 6/8] Documentation: dt: kona-timer: Add clocks property

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 The frequency for the Kona timer can either be specified through the
 device tree or determined by checking the rate of the clock specified
 in the device tree.  Update the documentation to reflect both ways.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  Documentation/devicetree/bindings/arm/bcm/kona-timer.txt | 7 ++-
  1 file changed, 6 insertions(+), 1 deletion(-)

 diff --git a/Documentation/devicetree/bindings/arm/bcm/kona-timer.txt 
 b/Documentation/devicetree/bindings/arm/bcm/kona-timer.txt
 index 17d88b2..39adf54 100644
 --- a/Documentation/devicetree/bindings/arm/bcm/kona-timer.txt
 +++ b/Documentation/devicetree/bindings/arm/bcm/kona-timer.txt
 @@ -8,13 +8,18 @@ Required properties:
  - DEPRECATED: compatible : bcm,kona-timer
  - reg : Register range for the timer
  - interrupts : interrupt for the timer
 +- clocks: phandle + clock specifier pair of the external clock
  - clock-frequency: frequency that the clock operates

 +Only one of clocks or clock-frequency should be specified.
 +
 +Refer to clocks/clock-bindings.txt for generic clock consumer properties.
 +
  Example:
 timer@35006000 {
 compatible = brcm,kona-timer;
 reg = 0x35006000 0x1000;
 interrupts = 0x0 7 0x4;
 -   clock-frequency = 32768;
 +   clocks = hub_timer_clk;
 };

 --
 1.8.0.1

Reviewed-by: Christian Daudt b...@fixthebug.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 7/8] clocksource: kona: Add basic use of external clock

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 When an clock is specified in the device tree, enable it and use it to
 determine the external clock frequency.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---

Reviewed-by: Christian Daudt b...@fixthebug.org

Daniel,
 Are you ok with me pulling this patch in with the rest of the
patchset into the bcm tree ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 4/8] ARM: dts: Specify clocks for SDHCIs on bcm11351

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
> Specify the external clock label in each SDHCI node.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> Reviewed-by: Matt Porter 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 9b99c52..25ca128 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -118,6 +118,7 @@
> compatible = "brcm,kona-sdhci";
> reg = <0x3f18 0x1>;
> interrupts = ;
> +   clocks = <_clk>;
> status = "disabled";
> };
>
> @@ -125,6 +126,7 @@
> compatible = "brcm,kona-sdhci";
> reg = <0x3f19 0x1>;
> interrupts = ;
> +   clocks = <_clk>;
> status = "disabled";
> };
>
> @@ -132,6 +134,7 @@
> compatible = "brcm,kona-sdhci";
> reg = <0x3f1a 0x1>;
> interrupts = ;
> +   clocks = <_clk>;
> status = "disabled";
> };
>
> @@ -139,6 +142,7 @@
> compatible = "brcm,kona-sdhci";
> reg = <0x3f1b 0x1>;
> interrupts = ;
> +   clocks = <_clk>;
> status = "disabled";
> };
>
> --
> 1.8.0.1
>
Reviewed-by: Christian Daudt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 8/8] ARM: dts: Specify clocks for timer on bcm11351

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
> Specify the external clock label in the timer node.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> Reviewed-by: Matt Porter 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 25ca128..1246885 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -95,7 +95,7 @@
> compatible = "brcm,kona-timer";
> reg = <0x35006000 0x1000>;
> interrupts = ;
> -   clock-frequency = <32768>;
> +   clocks = <_timer_clk>;
>     };
>
> gpio: gpio@35003000 {
> --
> 1.8.0.1
>
Reviewed-by: Christian Daudt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 3/8] Documentation: dt: kona-sdhci: Add clocks property

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
> The Kona SDHCI block requires a clock that must be specified in the
> device tree.  Update the documentation to reflect this requirement.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Matt Porter 
> ---
>  Documentation/devicetree/bindings/mmc/kona-sdhci.txt | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/kona-sdhci.txt 
> b/Documentation/devicetree/bindings/mmc/kona-sdhci.txt
> index 789fb07..aaba248 100644
> --- a/Documentation/devicetree/bindings/mmc/kona-sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/kona-sdhci.txt
> @@ -6,12 +6,16 @@ and the properties present in the bcm281xx SDHCI
>  Required properties:
>  - compatible : Should be "brcm,kona-sdhci"
>  - DEPRECATED: compatible : Should be "bcm,kona-sdhci"
> +- clocks: phandle + clock specifier pair of the external clock
> +
> +Refer to clocks/clock-bindings.txt for generic clock consumer properties.
>
>  Example:
>
>  sdio2: sdio@0x3f1a {
> compatible = "brcm,kona-sdhci";
> reg = <0x3f1a0000 0x1>;
> +   clocks = <_clk>;
> interrupts = <0x0 74 0x4>;
>  };
>
> --
> 1.8.0.1
>
Reviewed-by: Christian Daudt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 3/8] Documentation: dt: kona-sdhci: Add clocks property

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 The Kona SDHCI block requires a clock that must be specified in the
 device tree.  Update the documentation to reflect this requirement.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  Documentation/devicetree/bindings/mmc/kona-sdhci.txt | 4 
  1 file changed, 4 insertions(+)

 diff --git a/Documentation/devicetree/bindings/mmc/kona-sdhci.txt 
 b/Documentation/devicetree/bindings/mmc/kona-sdhci.txt
 index 789fb07..aaba248 100644
 --- a/Documentation/devicetree/bindings/mmc/kona-sdhci.txt
 +++ b/Documentation/devicetree/bindings/mmc/kona-sdhci.txt
 @@ -6,12 +6,16 @@ and the properties present in the bcm281xx SDHCI
  Required properties:
  - compatible : Should be brcm,kona-sdhci
  - DEPRECATED: compatible : Should be bcm,kona-sdhci
 +- clocks: phandle + clock specifier pair of the external clock
 +
 +Refer to clocks/clock-bindings.txt for generic clock consumer properties.

  Example:

  sdio2: sdio@0x3f1a {
 compatible = brcm,kona-sdhci;
 reg = 0x3f1a 0x1;
 +   clocks = sdio3_clk;
 interrupts = 0x0 74 0x4;
  };

 --
 1.8.0.1

Reviewed-by: Christian Daudt b...@fixthebug.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 8/8] ARM: dts: Specify clocks for timer on bcm11351

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 Specify the external clock label in the timer node.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/boot/dts/bcm11351.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
 index 25ca128..1246885 100644
 --- a/arch/arm/boot/dts/bcm11351.dtsi
 +++ b/arch/arm/boot/dts/bcm11351.dtsi
 @@ -95,7 +95,7 @@
 compatible = brcm,kona-timer;
 reg = 0x35006000 0x1000;
 interrupts = GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH;
 -   clock-frequency = 32768;
 +   clocks = hub_timer_clk;
 };

 gpio: gpio@35003000 {
 --
 1.8.0.1

Reviewed-by: Christian Daudt b...@fixthebug.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 4/8] ARM: dts: Specify clocks for SDHCIs on bcm11351

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 Specify the external clock label in each SDHCI node.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/boot/dts/bcm11351.dtsi | 4 
  1 file changed, 4 insertions(+)

 diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
 index 9b99c52..25ca128 100644
 --- a/arch/arm/boot/dts/bcm11351.dtsi
 +++ b/arch/arm/boot/dts/bcm11351.dtsi
 @@ -118,6 +118,7 @@
 compatible = brcm,kona-sdhci;
 reg = 0x3f18 0x1;
 interrupts = GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH;
 +   clocks = sdio1_clk;
 status = disabled;
 };

 @@ -125,6 +126,7 @@
 compatible = brcm,kona-sdhci;
 reg = 0x3f19 0x1;
 interrupts = GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH;
 +   clocks = sdio2_clk;
 status = disabled;
 };

 @@ -132,6 +134,7 @@
 compatible = brcm,kona-sdhci;
 reg = 0x3f1a 0x1;
 interrupts = GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH;
 +   clocks = sdio3_clk;
 status = disabled;
 };

 @@ -139,6 +142,7 @@
 compatible = brcm,kona-sdhci;
 reg = 0x3f1b 0x1;
 interrupts = GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH;
 +   clocks = sdio4_clk;
 status = disabled;
 };

 --
 1.8.0.1

Reviewed-by: Christian Daudt b...@fixthebug.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 2/8] ARM: dts: Specify clocks for UARTs on bcm11351

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
> The frequency property in "snps,dw-apb-uart" entries are no longer
> required if the rate of the external clock can be determined using the
> clk api (see e302cd9 serial: 8250_dw: add support for clk api).
>
> This patch replaces the frequency property in the UART nodes of
> bcm11351.dtsi with references to the relevant clocks following the
> common clock binding.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> Reviewed-by: Matt Porter 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index eca6fbc..9b99c52 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -43,7 +43,7 @@
> compatible = "brcm,bcm11351-dw-apb-uart", "snps,dw-apb-uart";
> status = "disabled";
> reg = <0x3e00 0x1000>;
> -   clock-frequency = <1300>;
> +   clocks = <_clk>;
> interrupts = ;
> reg-shift = <2>;
> reg-io-width = <4>;
> @@ -53,7 +53,7 @@
> compatible = "brcm,bcm11351-dw-apb-uart", "snps,dw-apb-uart";
> status = "disabled";
> reg = <0x3e001000 0x1000>;
> -   clock-frequency = <1300>;
> +   clocks = <_clk>;
> interrupts = ;
> reg-shift = <2>;
> reg-io-width = <4>;
> @@ -63,7 +63,7 @@
> compatible = "brcm,bcm11351-dw-apb-uart", "snps,dw-apb-uart";
> status = "disabled";
> reg = <0x3e002000 0x1000>;
> -   clock-frequency = <1300>;
> +   clocks = <_clk>;
> interrupts = ;
> reg-shift = <2>;
> reg-io-width = <4>;
> @@ -73,7 +73,7 @@
> compatible = "brcm,bcm11351-dw-apb-uart", "snps,dw-apb-uart";
> status = "disabled";
> reg = <0x3e003000 0x1000>;
> -   clock-frequency = <1300>;
> +   clocks = <_clk>;
> interrupts = ;
> reg-shift = <2>;
> reg-io-width = <4>;
> --
> 1.8.0.1
>
Reviewed-by: Christian Daudt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 1/8] ARM: dts: Declare clocks as fixed on bcm11351

[Christian Daudt]

On Tue, Dec 10, 2013 at 12:26 PM, Tim Kryger  wrote:
> On Mon, Dec 9, 2013 at 11:18 PM, Christian Daudt  wrote:
>> Applied to armsoc/for-3.14/dt
>
> Could you wait till other maintainers provide their acks and then take
> the entire series into a branch that feeds into the arm-soc
> drivers-for-linus branch?
>
> Thanks,
> Tim Kryger

I'll try to sync with other maintainers to pull it in together. I'll
leave this commit in as-is for now as it is harmless on its own. I'll
back it off before 3.14 merge if it poses a problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 3/6] pinctrl: Make PINCTRL selectable by defconfig/menuconfig

[Christian Daudt]

On Thu, Dec 12, 2013 at 12:39 PM, Linus Walleij
 wrote:
> On Wed, Dec 11, 2013 at 7:37 PM, Sherman Yin  wrote:
>
>> Adds a string to the PINCTRL config option so that 1) CONFIG_PINCTRL=y would
>> not be erased by make config, and 2) PINCTRL option would show up in 
>> menuconfig.
>>
>> Signed-off-by: Sherman Yin 
>> ---
>> v3: added to patchset
>
> NAK. The pin control subsystem has been designed so that
> you should select the pin controller through select statements
> from the SoC using it.
>
> This was requested at one time by Linus (Torvalds).
>
> You need to convince me that this is really needed.
>
> Yours,
> Linus Walleij
Hi Linus,
 I had requested this from Sherman. The reason is so that pinctrl can
be selectable through defconfig, instead of through SoC select
statements. And the reason for that is so that, in the future, some of
these can be switched into loadable modules (which can't be done from
Kconfig). This will become necessary with the move to multiplatform -
we won't be able to have everything static anymore.

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 3/6] pinctrl: Make PINCTRL selectable by defconfig/menuconfig

[Christian Daudt]

On Thu, Dec 12, 2013 at 12:39 PM, Linus Walleij
linus.wall...@linaro.org wrote:
 On Wed, Dec 11, 2013 at 7:37 PM, Sherman Yin s...@broadcom.com wrote:

 Adds a string to the PINCTRL config option so that 1) CONFIG_PINCTRL=y would
 not be erased by make config, and 2) PINCTRL option would show up in 
 menuconfig.

 Signed-off-by: Sherman Yin s...@broadcom.com
 ---
 v3: added to patchset

 NAK. The pin control subsystem has been designed so that
 you should select the pin controller through select statements
 from the SoC using it.

 This was requested at one time by Linus (Torvalds).

 You need to convince me that this is really needed.

 Yours,
 Linus Walleij
Hi Linus,
 I had requested this from Sherman. The reason is so that pinctrl can
be selectable through defconfig, instead of through SoC select
statements. And the reason for that is so that, in the future, some of
these can be switched into loadable modules (which can't be done from
Kconfig). This will become necessary with the move to multiplatform -
we won't be able to have everything static anymore.

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 1/8] ARM: dts: Declare clocks as fixed on bcm11351

[Christian Daudt]

On Tue, Dec 10, 2013 at 12:26 PM, Tim Kryger tim.kry...@linaro.org wrote:
 On Mon, Dec 9, 2013 at 11:18 PM, Christian Daudt b...@fixthebug.org wrote:
 Applied to armsoc/for-3.14/dt

 Could you wait till other maintainers provide their acks and then take
 the entire series into a branch that feeds into the arm-soc
 drivers-for-linus branch?

 Thanks,
 Tim Kryger

I'll try to sync with other maintainers to pull it in together. I'll
leave this commit in as-is for now as it is harmless on its own. I'll
back it off before 3.14 merge if it poses a problem.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 2/8] ARM: dts: Specify clocks for UARTs on bcm11351

[Christian Daudt]

On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 The frequency property in snps,dw-apb-uart entries are no longer
 required if the rate of the external clock can be determined using the
 clk api (see e302cd9 serial: 8250_dw: add support for clk api).

 This patch replaces the frequency property in the UART nodes of
 bcm11351.dtsi with references to the relevant clocks following the
 common clock binding.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/boot/dts/bcm11351.dtsi | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

 diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
 index eca6fbc..9b99c52 100644
 --- a/arch/arm/boot/dts/bcm11351.dtsi
 +++ b/arch/arm/boot/dts/bcm11351.dtsi
 @@ -43,7 +43,7 @@
 compatible = brcm,bcm11351-dw-apb-uart, snps,dw-apb-uart;
 status = disabled;
 reg = 0x3e00 0x1000;
 -   clock-frequency = 1300;
 +   clocks = uartb_clk;
 interrupts = GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH;
 reg-shift = 2;
 reg-io-width = 4;
 @@ -53,7 +53,7 @@
 compatible = brcm,bcm11351-dw-apb-uart, snps,dw-apb-uart;
 status = disabled;
 reg = 0x3e001000 0x1000;
 -   clock-frequency = 1300;
 +   clocks = uartb2_clk;
 interrupts = GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH;
 reg-shift = 2;
 reg-io-width = 4;
 @@ -63,7 +63,7 @@
 compatible = brcm,bcm11351-dw-apb-uart, snps,dw-apb-uart;
 status = disabled;
 reg = 0x3e002000 0x1000;
 -   clock-frequency = 1300;
 +   clocks = uartb3_clk;
 interrupts = GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH;
 reg-shift = 2;
 reg-io-width = 4;
 @@ -73,7 +73,7 @@
 compatible = brcm,bcm11351-dw-apb-uart, snps,dw-apb-uart;
 status = disabled;
 reg = 0x3e003000 0x1000;
 -   clock-frequency = 1300;
 +   clocks = uartb4_clk;
 interrupts = GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH;
 reg-shift = 2;
 reg-io-width = 4;
 --
 1.8.0.1

Reviewed-by: Christian Daudt b...@fixthebug.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] ARM: bcm_defconfig: Unset CONFIG_CRYPTO_ANSI_CPRNG

[Christian Daudt]

On Thu, Dec 5, 2013 at 3:00 PM, Tim Kryger  wrote:
> Do not build the Pseudo Random Number Generation for Cryptographic
> modules since it is not currently being used for this platform.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> ---
>  arch/arm/configs/bcm_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> index 574e046..ef03bba 100644
> --- a/arch/arm/configs/bcm_defconfig
> +++ b/arch/arm/configs/bcm_defconfig
> @@ -119,6 +119,7 @@ CONFIG_DETECT_HUNG_TASK=y
>  CONFIG_DEFAULT_HUNG_TASK_TIMEOUT=110
>  CONFIG_BOOTPARAM_HUNG_TASK_PANIC=y
>  # CONFIG_FTRACE is not set
> +# CONFIG_CRYPTO_ANSI_CPRNG is not set
>  CONFIG_CRC_CCITT=y
>  CONFIG_CRC_T10DIF=y
>  CONFIG_CRC_ITU_T=y
> --
> 1.8.0.1
>
Applied to armsoc/for-3.14/soc

 thanks
  csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH] ARM: bcm_defconfig: Do not expect appended DTB

[Christian Daudt]

On Thu, Dec 5, 2013 at 3:30 PM, Tim Kryger  wrote:
> The bootloaders used with Broadcom mobile SoCs are capable of handling
> a device tree separately from the zImage so there is no need for this
> option to be enabled.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> ---
>  arch/arm/configs/bcm_defconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> index 6e49310..b152367 100644
> --- a/arch/arm/configs/bcm_defconfig
> +++ b/arch/arm/configs/bcm_defconfig
> @@ -35,7 +35,6 @@ CONFIG_AEABI=y
>  # CONFIG_COMPACTION is not set
>  CONFIG_ZBOOT_ROM_TEXT=0x0
>  CONFIG_ZBOOT_ROM_BSS=0x0
> -CONFIG_ARM_APPENDED_DTB=y
>  CONFIG_CMDLINE="console=ttyS0,115200n8 mem=128M"
>  CONFIG_CPU_IDLE=y
>  CONFIG_VFP=y
> --
> 1.8.0.1
>
Applied to armsoc/for-3.14/soc

 thanks,
  csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] ARM: dts: bcm281xx: Add i2c busses

[Christian Daudt]

On Fri, Dec 6, 2013 at 3:45 PM, Tim Kryger  wrote:
> Add the DTS nodes for all the i2c busses in the SoC.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Christian Daudt 
> Reviewed-by: Matt Porter 
> Reviewed-by: Markus Mayer 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi | 40 
>  1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 1246885..4bfd7e3 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -146,6 +146,46 @@
> status = "disabled";
> };
>
> +   i2c@3e016000 {
> +   compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +   reg = <0x3e016000 0x80>;
> +   interrupts = ;
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   clocks = <_clk>;
> +   status = "disabled";
> +   };
> +
> +   i2c@3e017000 {
> +   compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +   reg = <0x3e017000 0x80>;
> +   interrupts = ;
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   clocks = <_clk>;
> +   status = "disabled";
> +   };
> +
> +   i2c@3e018000 {
> +   compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +   reg = <0x3e018000 0x80>;
> +   interrupts = ;
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   clocks = <_clk>;
> +   status = "disabled";
> +   };
> +
> +   i2c@3500d000 {
> +   compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +   reg = <0x3500d000 0x80>;
> +   interrupts = ;
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   clocks = <_bsc_clk>;
> +   status = "disabled";
> +   };
> +
> clocks {
> bsc1_clk: bsc1 {
> compatible = "fixed-clock";
> --
> 1.8.0.1
>
Applied to armsoc/for-3.14/dt
 thanks,
  csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 1/8] ARM: dts: Declare clocks as fixed on bcm11351

[Christian Daudt]

Applied to armsoc/for-3.14/dt

 thanks,
   csd


On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger  wrote:
> Declare clocks that are enabled and configured by bootloaders as fixed
> rate clocks in the DTS such that device drivers may use standard clock
> function calls.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> Reviewed-by: Matt Porter 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi | 97 
> +
>  1 file changed, 97 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index b0c0610..eca6fbc 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -142,4 +142,101 @@
> status = "disabled";
> };
>
> +   clocks {
> +   bsc1_clk: bsc1 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <1300>;
> +   #clock-cells = <0>;
> +   };
> +
> +   bsc2_clk: bsc2 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <1300>;
> +   #clock-cells = <0>;
> +   };
> +
> +   bsc3_clk: bsc3 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <1300>;
> +   #clock-cells = <0>;
> +   };
> +
> +   pmu_bsc_clk: pmu_bsc {
> +   compatible = "fixed-clock";
> +   clock-frequency = <1300>;
> +   #clock-cells = <0>;
> +   };
> +
> +   hub_timer_clk: hub_timer {
> +   compatible = "fixed-clock";
> +   clock-frequency = <32768>;
> +   #clock-cells = <0>;
> +   };
> +
> +   pwm_clk: pwm {
> +   compatible = "fixed-clock";
> +   clock-frequency = <2600>;
> +   #clock-cells = <0>;
> +   };
> +
> +   sdio1_clk: sdio1 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <4800>;
> +   #clock-cells = <0>;
> +   };
> +
> +   sdio2_clk: sdio2 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <4800>;
> +   #clock-cells = <0>;
> +   };
> +
> +   sdio3_clk: sdio3 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <4800>;
> +   #clock-cells = <0>;
> +   };
> +
> +   sdio4_clk: sdio4 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <4800>;
> +   #clock-cells = <0>;
> +   };
> +
> +   tmon_1m_clk: tmon_1m {
> +   compatible = "fixed-clock";
> +   clock-frequency = <100>;
> +   #clock-cells = <0>;
> +   };
> +
> +   uartb_clk: uartb {
> +   compatible = "fixed-clock";
> +   clock-frequency = <1300>;
> +   #clock-cells = <0>;
> +   };
> +
> +   uartb2_clk: uartb2 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <1300>;
> +   #clock-cells = <0>;
> +   };
> +
> +   uartb3_clk: uartb3 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <1300>;
> +   #clock-cells = <0>;
> +   };
> +
> +   uartb4_clk: uartb4 {
> +   compatible = "fixed-clock";
> +   clock-frequency = <1300>;
> +   #clock-cells = <0>;
> +   };
> +
> +   usb_otg_ahb_clk: usb_otg_ahb {
> +   compatible = "fixed-clock";
> +   clock-frequency = <5200>;
> +   #clock-cells = <0>;
> +   };
> +   };
>  };
> --
> 1.8.0.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] ARM: dts: bcm28155-ap: Enable all the i2c busses

[Christian Daudt]

Applied to armsoc/for-3.14/dt
 thanks,
   csd


On Fri, Dec 6, 2013 at 3:45 PM, Tim Kryger  wrote:
> Enable all available i2c busses.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Christian Daudt 
> Reviewed-by: Matt Porter 
> Reviewed-by: Markus Mayer 
> ---
>  arch/arm/boot/dts/bcm28155-ap.dts | 20 
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts 
> b/arch/arm/boot/dts/bcm28155-ap.dts
> index 08e47c2..bab302d 100644
> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> @@ -27,6 +27,26 @@
> status = "okay";
> };
>
> +   i2c@3e016000 {
> +   status="okay";
> +   clock-frequency = <40>;
> +   };
> +
> +   i2c@3e017000 {
> +   status="okay";
> +   clock-frequency = <40>;
> +   };
> +
> +   i2c@3e018000 {
> +   status="okay";
> +   clock-frequency = <40>;
> +   };
> +
> +   i2c@3500d000 {
> +   status="okay";
> +   clock-frequency = <40>;
> +   };
> +
> sdio1: sdio@3f18 {
> max-frequency = <4800>;
> status = "okay";
> --
> 1.8.0.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] ARM: bcm_defconfig: CONFIG_OABI_COMPAT default off

[Christian Daudt]

On Thu, Dec 5, 2013 at 3:00 PM, Tim Kryger  wrote:
> Now that CONFIG_OABI_COMPAT is off by default, remove the explicit
> disabling of this feature.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> ---
>  arch/arm/configs/bcm_defconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> index 287ac1d..574e046 100644
> --- a/arch/arm/configs/bcm_defconfig
> +++ b/arch/arm/configs/bcm_defconfig
> @@ -29,7 +29,6 @@ CONFIG_ARCH_BCM_MOBILE=y
>  CONFIG_ARM_THUMBEE=y
>  CONFIG_PREEMPT=y
>  CONFIG_AEABI=y
> -# CONFIG_OABI_COMPAT is not set
>  # CONFIG_COMPACTION is not set
>  CONFIG_ZBOOT_ROM_TEXT=0x0
>  CONFIG_ZBOOT_ROM_BSS=0x0
> --
> 1.8.0.1
>
Applied to armsoc/for-3.14/soc

 thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] ARM: bcm_defconfig: CONFIG_OABI_COMPAT default off

[Christian Daudt]

On Thu, Dec 5, 2013 at 3:00 PM, Tim Kryger tim.kry...@linaro.org wrote:
 Now that CONFIG_OABI_COMPAT is off by default, remove the explicit
 disabling of this feature.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 ---
  arch/arm/configs/bcm_defconfig | 1 -
  1 file changed, 1 deletion(-)

 diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
 index 287ac1d..574e046 100644
 --- a/arch/arm/configs/bcm_defconfig
 +++ b/arch/arm/configs/bcm_defconfig
 @@ -29,7 +29,6 @@ CONFIG_ARCH_BCM_MOBILE=y
  CONFIG_ARM_THUMBEE=y
  CONFIG_PREEMPT=y
  CONFIG_AEABI=y
 -# CONFIG_OABI_COMPAT is not set
  # CONFIG_COMPACTION is not set
  CONFIG_ZBOOT_ROM_TEXT=0x0
  CONFIG_ZBOOT_ROM_BSS=0x0
 --
 1.8.0.1

Applied to armsoc/for-3.14/soc

 thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] ARM: dts: bcm28155-ap: Enable all the i2c busses

[Christian Daudt]

Applied to armsoc/for-3.14/dt
 thanks,
   csd


On Fri, Dec 6, 2013 at 3:45 PM, Tim Kryger tim.kry...@linaro.org wrote:
 Enable all available i2c busses.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Christian Daudt c...@broadcom.com
 Reviewed-by: Matt Porter matt.por...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 ---
  arch/arm/boot/dts/bcm28155-ap.dts | 20 
  1 file changed, 20 insertions(+)

 diff --git a/arch/arm/boot/dts/bcm28155-ap.dts 
 b/arch/arm/boot/dts/bcm28155-ap.dts
 index 08e47c2..bab302d 100644
 --- a/arch/arm/boot/dts/bcm28155-ap.dts
 +++ b/arch/arm/boot/dts/bcm28155-ap.dts
 @@ -27,6 +27,26 @@
 status = okay;
 };

 +   i2c@3e016000 {
 +   status=okay;
 +   clock-frequency = 40;
 +   };
 +
 +   i2c@3e017000 {
 +   status=okay;
 +   clock-frequency = 40;
 +   };
 +
 +   i2c@3e018000 {
 +   status=okay;
 +   clock-frequency = 40;
 +   };
 +
 +   i2c@3500d000 {
 +   status=okay;
 +   clock-frequency = 40;
 +   };
 +
 sdio1: sdio@3f18 {
 max-frequency = 4800;
 status = okay;
 --
 1.8.0.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v4 1/8] ARM: dts: Declare clocks as fixed on bcm11351

[Christian Daudt]

Applied to armsoc/for-3.14/dt

 thanks,
   csd


On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger tim.kry...@linaro.org wrote:
 Declare clocks that are enabled and configured by bootloaders as fixed
 rate clocks in the DTS such that device drivers may use standard clock
 function calls.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/boot/dts/bcm11351.dtsi | 97 
 +
  1 file changed, 97 insertions(+)

 diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
 index b0c0610..eca6fbc 100644
 --- a/arch/arm/boot/dts/bcm11351.dtsi
 +++ b/arch/arm/boot/dts/bcm11351.dtsi
 @@ -142,4 +142,101 @@
 status = disabled;
 };

 +   clocks {
 +   bsc1_clk: bsc1 {
 +   compatible = fixed-clock;
 +   clock-frequency = 1300;
 +   #clock-cells = 0;
 +   };
 +
 +   bsc2_clk: bsc2 {
 +   compatible = fixed-clock;
 +   clock-frequency = 1300;
 +   #clock-cells = 0;
 +   };
 +
 +   bsc3_clk: bsc3 {
 +   compatible = fixed-clock;
 +   clock-frequency = 1300;
 +   #clock-cells = 0;
 +   };
 +
 +   pmu_bsc_clk: pmu_bsc {
 +   compatible = fixed-clock;
 +   clock-frequency = 1300;
 +   #clock-cells = 0;
 +   };
 +
 +   hub_timer_clk: hub_timer {
 +   compatible = fixed-clock;
 +   clock-frequency = 32768;
 +   #clock-cells = 0;
 +   };
 +
 +   pwm_clk: pwm {
 +   compatible = fixed-clock;
 +   clock-frequency = 2600;
 +   #clock-cells = 0;
 +   };
 +
 +   sdio1_clk: sdio1 {
 +   compatible = fixed-clock;
 +   clock-frequency = 4800;
 +   #clock-cells = 0;
 +   };
 +
 +   sdio2_clk: sdio2 {
 +   compatible = fixed-clock;
 +   clock-frequency = 4800;
 +   #clock-cells = 0;
 +   };
 +
 +   sdio3_clk: sdio3 {
 +   compatible = fixed-clock;
 +   clock-frequency = 4800;
 +   #clock-cells = 0;
 +   };
 +
 +   sdio4_clk: sdio4 {
 +   compatible = fixed-clock;
 +   clock-frequency = 4800;
 +   #clock-cells = 0;
 +   };
 +
 +   tmon_1m_clk: tmon_1m {
 +   compatible = fixed-clock;
 +   clock-frequency = 100;
 +   #clock-cells = 0;
 +   };
 +
 +   uartb_clk: uartb {
 +   compatible = fixed-clock;
 +   clock-frequency = 1300;
 +   #clock-cells = 0;
 +   };
 +
 +   uartb2_clk: uartb2 {
 +   compatible = fixed-clock;
 +   clock-frequency = 1300;
 +   #clock-cells = 0;
 +   };
 +
 +   uartb3_clk: uartb3 {
 +   compatible = fixed-clock;
 +   clock-frequency = 1300;
 +   #clock-cells = 0;
 +   };
 +
 +   uartb4_clk: uartb4 {
 +   compatible = fixed-clock;
 +   clock-frequency = 1300;
 +   #clock-cells = 0;
 +   };
 +
 +   usb_otg_ahb_clk: usb_otg_ahb {
 +   compatible = fixed-clock;
 +   clock-frequency = 5200;
 +   #clock-cells = 0;
 +   };
 +   };
  };
 --
 1.8.0.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] ARM: dts: bcm281xx: Add i2c busses

[Christian Daudt]

On Fri, Dec 6, 2013 at 3:45 PM, Tim Kryger tim.kry...@linaro.org wrote:
 Add the DTS nodes for all the i2c busses in the SoC.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Christian Daudt c...@broadcom.com
 Reviewed-by: Matt Porter matt.por...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 ---
  arch/arm/boot/dts/bcm11351.dtsi | 40 
  1 file changed, 40 insertions(+)

 diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
 index 1246885..4bfd7e3 100644
 --- a/arch/arm/boot/dts/bcm11351.dtsi
 +++ b/arch/arm/boot/dts/bcm11351.dtsi
 @@ -146,6 +146,46 @@
 status = disabled;
 };

 +   i2c@3e016000 {
 +   compatible = brcm,bcm11351-i2c, brcm,kona-i2c;
 +   reg = 0x3e016000 0x80;
 +   interrupts = GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH;
 +   #address-cells = 1;
 +   #size-cells = 0;
 +   clocks = bsc1_clk;
 +   status = disabled;
 +   };
 +
 +   i2c@3e017000 {
 +   compatible = brcm,bcm11351-i2c, brcm,kona-i2c;
 +   reg = 0x3e017000 0x80;
 +   interrupts = GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH;
 +   #address-cells = 1;
 +   #size-cells = 0;
 +   clocks = bsc2_clk;
 +   status = disabled;
 +   };
 +
 +   i2c@3e018000 {
 +   compatible = brcm,bcm11351-i2c, brcm,kona-i2c;
 +   reg = 0x3e018000 0x80;
 +   interrupts = GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH;
 +   #address-cells = 1;
 +   #size-cells = 0;
 +   clocks = bsc3_clk;
 +   status = disabled;
 +   };
 +
 +   i2c@3500d000 {
 +   compatible = brcm,bcm11351-i2c, brcm,kona-i2c;
 +   reg = 0x3500d000 0x80;
 +   interrupts = GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH;
 +   #address-cells = 1;
 +   #size-cells = 0;
 +   clocks = pmu_bsc_clk;
 +   status = disabled;
 +   };
 +
 clocks {
 bsc1_clk: bsc1 {
 compatible = fixed-clock;
 --
 1.8.0.1

Applied to armsoc/for-3.14/dt
 thanks,
  csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH] ARM: bcm_defconfig: Do not expect appended DTB

[Christian Daudt]

On Thu, Dec 5, 2013 at 3:30 PM, Tim Kryger tim.kry...@linaro.org wrote:
 The bootloaders used with Broadcom mobile SoCs are capable of handling
 a device tree separately from the zImage so there is no need for this
 option to be enabled.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 ---
  arch/arm/configs/bcm_defconfig | 1 -
  1 file changed, 1 deletion(-)

 diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
 index 6e49310..b152367 100644
 --- a/arch/arm/configs/bcm_defconfig
 +++ b/arch/arm/configs/bcm_defconfig
 @@ -35,7 +35,6 @@ CONFIG_AEABI=y
  # CONFIG_COMPACTION is not set
  CONFIG_ZBOOT_ROM_TEXT=0x0
  CONFIG_ZBOOT_ROM_BSS=0x0
 -CONFIG_ARM_APPENDED_DTB=y
  CONFIG_CMDLINE=console=ttyS0,115200n8 mem=128M
  CONFIG_CPU_IDLE=y
  CONFIG_VFP=y
 --
 1.8.0.1

Applied to armsoc/for-3.14/soc

 thanks,
  csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] ARM: bcm_defconfig: Unset CONFIG_CRYPTO_ANSI_CPRNG

[Christian Daudt]

On Thu, Dec 5, 2013 at 3:00 PM, Tim Kryger tim.kry...@linaro.org wrote:
 Do not build the Pseudo Random Number Generation for Cryptographic
 modules since it is not currently being used for this platform.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 ---
  arch/arm/configs/bcm_defconfig | 1 +
  1 file changed, 1 insertion(+)

 diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
 index 574e046..ef03bba 100644
 --- a/arch/arm/configs/bcm_defconfig
 +++ b/arch/arm/configs/bcm_defconfig
 @@ -119,6 +119,7 @@ CONFIG_DETECT_HUNG_TASK=y
  CONFIG_DEFAULT_HUNG_TASK_TIMEOUT=110
  CONFIG_BOOTPARAM_HUNG_TASK_PANIC=y
  # CONFIG_FTRACE is not set
 +# CONFIG_CRYPTO_ANSI_CPRNG is not set
  CONFIG_CRC_CCITT=y
  CONFIG_CRC_T10DIF=y
  CONFIG_CRC_ITU_T=y
 --
 1.8.0.1

Applied to armsoc/for-3.14/soc

 thanks
  csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/5] Add-Broadcom-Kona-I2C-Support

[Christian Daudt]

On Fri, Nov 15, 2013 at 3:30 PM, Tim Kryger  wrote:
> On Fri, Nov 15, 2013 at 2:52 PM, Wolfram Sang  wrote:
>
>> Fixed Kconfig sorting, squashed broken out patches 1-3 into one and
>> applied to for-next, thanks! Let me know if I should take patches 4-5
>> also, but usually they go via arm-soc. Also, please provide a "Changes
>> since V1" log which will speed up reviewing.
>
> Thanks.  It appears that when I updated the dependencies, I
> accidentally removed the change list I had planned to send.  This is
> what should have appeared in my cover letter:
>
> Changes in v2:
>   - Binding documentation is in its own patch
>   - Minor cosmetic changes
>   - Fixed bug related to improper signedness
>   - Removed superflous mutex
>   - Simplified probe function
>
> I think it would be best for the DTS changes (patches 4 and 5) to go
> through Christian's tree.

I'll pick up 4 and 5.
 thanks
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/5] Add-Broadcom-Kona-I2C-Support

[Christian Daudt]

On Fri, Nov 15, 2013 at 3:30 PM, Tim Kryger tim.kry...@linaro.org wrote:
 On Fri, Nov 15, 2013 at 2:52 PM, Wolfram Sang w...@the-dreams.de wrote:

 Fixed Kconfig sorting, squashed broken out patches 1-3 into one and
 applied to for-next, thanks! Let me know if I should take patches 4-5
 also, but usually they go via arm-soc. Also, please provide a Changes
 since V1 log which will speed up reviewing.

 Thanks.  It appears that when I updated the dependencies, I
 accidentally removed the change list I had planned to send.  This is
 what should have appeared in my cover letter:

 Changes in v2:
   - Binding documentation is in its own patch
   - Minor cosmetic changes
   - Fixed bug related to improper signedness
   - Removed superflous mutex
   - Simplified probe function

 I think it would be best for the DTS changes (patches 4 and 5) to go
 through Christian's tree.

I'll pick up 4 and 5.
 thanks
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH v2 1/6] ARM: dts: Declare clocks as fixed on bcm11351

[Christian Daudt]

I can pick up the dt related changes as long as the other code works
as-is both with and without the change (i.e. no backwards/forwards
compatibility issues). If this must be introduced alongside the other
changes, then the patches will have to be reworked to break them up by
subtree so they can go in atomically.
 csd


On Fri, Nov 8, 2013 at 11:42 AM, Tim Kryger  wrote:
> On Fri, Nov 8, 2013 at 2:53 AM, Daniel Lezcano
>  wrote:
>
>> I was wondering what is the status of this patchset ?
>>
>> The patchset touches different areas maintained by different people. Through
>> what tree do you expect this patchset to be merged ??
>
> Hi Daniel,
>
> I plan to send an updated version soon to address some concerns raised by 
> Mark.
>
> Once all the maintainers are satisfied and provide their acks, I would
> like Christian to take the series into his tree.
>
> I expect Christian will have a few other Broadcom DTS file changes in
> his tree so sending the series through him should make it easier to
> avoid/manage conflicts.
>
> Christian, would that work for you?
>
> Thanks,
> Tim Kryger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH v2 1/6] ARM: dts: Declare clocks as fixed on bcm11351

[Christian Daudt]

I can pick up the dt related changes as long as the other code works
as-is both with and without the change (i.e. no backwards/forwards
compatibility issues). If this must be introduced alongside the other
changes, then the patches will have to be reworked to break them up by
subtree so they can go in atomically.
 csd


On Fri, Nov 8, 2013 at 11:42 AM, Tim Kryger tim.kry...@linaro.org wrote:
 On Fri, Nov 8, 2013 at 2:53 AM, Daniel Lezcano
 daniel.lezc...@linaro.org wrote:

 I was wondering what is the status of this patchset ?

 The patchset touches different areas maintained by different people. Through
 what tree do you expect this patchset to be merged ??

 Hi Daniel,

 I plan to send an updated version soon to address some concerns raised by 
 Mark.

 Once all the maintainers are satisfied and provide their acks, I would
 like Christian to take the series into his tree.

 I expect Christian will have a few other Broadcom DTS file changes in
 his tree so sending the series through him should make it easier to
 avoid/manage conflicts.

 Christian, would that work for you?

 Thanks,
 Tim Kryger
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

On Wed, Oct 16, 2013 at 11:12 PM, Christian Daudt  wrote:
> On Sat, Oct 5, 2013 at 8:43 AM, Christian Daudt  wrote:
>> This patch adds low level debug uart support to Broadcom
>>  mobile based SOCs.
>>
>> Signed-off-by: Christian Daudt 
>>
>> Changes from V2:
>>  - Changed to follow hex ordering on entries
>>  - Dropped defconfig changes
>>
>> Changes from V1:
>>  - Switched to use the common 8250 debug introduced in 3.12-rc1
>>
>
> Hi Russell,
>  Does V3 look ok ?
>
>  Thanks,
>csd
Hi,
 Can anyone provide an ack on this mod ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

On Wed, Oct 16, 2013 at 11:12 PM, Christian Daudt b...@fixthebug.org wrote:
 On Sat, Oct 5, 2013 at 8:43 AM, Christian Daudt b...@fixthebug.org wrote:
 This patch adds low level debug uart support to Broadcom
  mobile based SOCs.

 Signed-off-by: Christian Daudt b...@fixthebug.org

 Changes from V2:
  - Changed to follow hex ordering on entries
  - Dropped defconfig changes

 Changes from V1:
  - Switched to use the common 8250 debug introduced in 3.12-rc1


 Hi Russell,
  Does V3 look ok ?

  Thanks,
csd
Hi,
 Can anyone provide an ack on this mod ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

[Christian Daudt]

On Thu, Oct 17, 2013 at 7:54 AM, Stephen Warren  wrote:
> On 10/17/2013 12:03 AM, Christian Daudt wrote:
>> On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin  wrote:
>>> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
>>>
>>> Signed-off-by: Sherman Yin 
>>> Reviewed-by: Christian Daudt 
>>> Reviewed-by: Matt Porter 
>>> ---
>>>  arch/arm/mach-bcm/Kconfig   |2 +
>>>  drivers/pinctrl/Kconfig |   10 +
>>>  drivers/pinctrl/Makefile|1 +
>>>  drivers/pinctrl/pinctrl-capri.c | 1727 
>>> +++
>>>  4 files changed, 1740 insertions(+)
>>>  create mode 100644 drivers/pinctrl/pinctrl-capri.c
>>>
>>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
>>> index 69d67f7..2546365 100644
>>> --- a/arch/arm/mach-bcm/Kconfig
>>> +++ b/arch/arm/mach-bcm/Kconfig
>>> @@ -10,6 +10,8 @@ config ARCH_BCM
>>> select GENERIC_CLOCKEVENTS
>>> select GENERIC_TIME
>>> select GPIO_BCM
>>> +   select PINCTRL
>>> +   select PINCTRL_CAPRI
>>> select SPARSE_IRQ
>>> select TICK_ONESHOT
>>> select CACHE_L2X0
>>
>> On your subsequent patchset pls move this from Kconfig to
>> arm/configs/bcm_defconfig, and break that modification into a separate
>> patch from the drivers/* modification.
>
> The other SoCs I'm familiar with all select this from their ARCH_xxx
> config symbol.
>
I had a discussion on what is best left under ARCH and what is best
left to defconfig with Kevin Hilman a while back and the conclusion
was that any config not strictly required for bootup is best left to
defconfig. This will allow multiplatform kernels to switch to using
them as loadable modules later on, something not possible with configs
put under ARCH_xxx.

 Thanks,
csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

On Sat, Oct 5, 2013 at 8:43 AM, Christian Daudt  wrote:
> This patch adds low level debug uart support to Broadcom
>  mobile based SOCs.
>
> Signed-off-by: Christian Daudt 
>
> Changes from V2:
>  - Changed to follow hex ordering on entries
>  - Dropped defconfig changes
>
> Changes from V1:
>  - Switched to use the common 8250 debug introduced in 3.12-rc1
>

Hi Russell,
 Does V3 look ok ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

[Christian Daudt]

On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin  wrote:
> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
>
> Signed-off-by: Sherman Yin 
> Reviewed-by: Christian Daudt 
> Reviewed-by: Matt Porter 
> ---
>  arch/arm/mach-bcm/Kconfig   |2 +
>  drivers/pinctrl/Kconfig |   10 +
>  drivers/pinctrl/Makefile|1 +
>  drivers/pinctrl/pinctrl-capri.c | 1727 
> +++
>  4 files changed, 1740 insertions(+)
>  create mode 100644 drivers/pinctrl/pinctrl-capri.c
>
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index 69d67f7..2546365 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -10,6 +10,8 @@ config ARCH_BCM
> select GENERIC_CLOCKEVENTS
> select GENERIC_TIME
> select GPIO_BCM
> +   select PINCTRL
> +   select PINCTRL_CAPRI
> select SPARSE_IRQ
> select TICK_ONESHOT
> select CACHE_L2X0

On your subsequent patchset pls move this from Kconfig to
arm/configs/bcm_defconfig, and break that modification into a separate
patch from the drivers/* modification.

 thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

[Christian Daudt]

On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin s...@broadcom.com wrote:
 Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.

 Signed-off-by: Sherman Yin s...@broadcom.com
 Reviewed-by: Christian Daudt b...@fixthebug.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/mach-bcm/Kconfig   |2 +
  drivers/pinctrl/Kconfig |   10 +
  drivers/pinctrl/Makefile|1 +
  drivers/pinctrl/pinctrl-capri.c | 1727 
 +++
  4 files changed, 1740 insertions(+)
  create mode 100644 drivers/pinctrl/pinctrl-capri.c

 diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
 index 69d67f7..2546365 100644
 --- a/arch/arm/mach-bcm/Kconfig
 +++ b/arch/arm/mach-bcm/Kconfig
 @@ -10,6 +10,8 @@ config ARCH_BCM
 select GENERIC_CLOCKEVENTS
 select GENERIC_TIME
 select GPIO_BCM
 +   select PINCTRL
 +   select PINCTRL_CAPRI
 select SPARSE_IRQ
 select TICK_ONESHOT
 select CACHE_L2X0

On your subsequent patchset pls move this from Kconfig to
arm/configs/bcm_defconfig, and break that modification into a separate
patch from the drivers/* modification.

 thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

On Sat, Oct 5, 2013 at 8:43 AM, Christian Daudt b...@fixthebug.org wrote:
 This patch adds low level debug uart support to Broadcom
  mobile based SOCs.

 Signed-off-by: Christian Daudt b...@fixthebug.org

 Changes from V2:
  - Changed to follow hex ordering on entries
  - Dropped defconfig changes

 Changes from V1:
  - Switched to use the common 8250 debug introduced in 3.12-rc1


Hi Russell,
 Does V3 look ok ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

[Christian Daudt]

On Thu, Oct 17, 2013 at 7:54 AM, Stephen Warren swar...@wwwdotorg.org wrote:
 On 10/17/2013 12:03 AM, Christian Daudt wrote:
 On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin s...@broadcom.com wrote:
 Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.

 Signed-off-by: Sherman Yin s...@broadcom.com
 Reviewed-by: Christian Daudt b...@fixthebug.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/mach-bcm/Kconfig   |2 +
  drivers/pinctrl/Kconfig |   10 +
  drivers/pinctrl/Makefile|1 +
  drivers/pinctrl/pinctrl-capri.c | 1727 
 +++
  4 files changed, 1740 insertions(+)
  create mode 100644 drivers/pinctrl/pinctrl-capri.c

 diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
 index 69d67f7..2546365 100644
 --- a/arch/arm/mach-bcm/Kconfig
 +++ b/arch/arm/mach-bcm/Kconfig
 @@ -10,6 +10,8 @@ config ARCH_BCM
 select GENERIC_CLOCKEVENTS
 select GENERIC_TIME
 select GPIO_BCM
 +   select PINCTRL
 +   select PINCTRL_CAPRI
 select SPARSE_IRQ
 select TICK_ONESHOT
 select CACHE_L2X0

 On your subsequent patchset pls move this from Kconfig to
 arm/configs/bcm_defconfig, and break that modification into a separate
 patch from the drivers/* modification.

 The other SoCs I'm familiar with all select this from their ARCH_xxx
 config symbol.

I had a discussion on what is best left under ARCH and what is best
left to defconfig with Kevin Hilman a while back and the conclusion
was that any config not strictly required for bootup is best left to
defconfig. This will allow multiplatform kernels to switch to using
them as loadable modules later on, something not possible with configs
put under ARCH_xxx.

 Thanks,
csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: bcm_defconfig: Run "make savedefconfig"

[Christian Daudt]

On Mon, Oct 14, 2013 at 2:41 PM, Tim Kryger  wrote:
> Several of the options in bcm_defconfig have gotten out of date so
> regenerate it with "make savedefconfig" to keep things fresh.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Matt Porter 
> ---
>  arch/arm/configs/bcm_defconfig | 10 ++
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> index efb0132..3a138af 100644
> --- a/arch/arm/configs/bcm_defconfig
> +++ b/arch/arm/configs/bcm_defconfig
> @@ -1,4 +1,3 @@
> -CONFIG_EXPERIMENTAL=y
>  # CONFIG_LOCALVERSION_AUTO is not set
>  # CONFIG_SWAP is not set
>  CONFIG_SYSVIPC=y
> @@ -25,11 +24,8 @@ CONFIG_MODULES=y
>  CONFIG_MODULE_UNLOAD=y
>  # CONFIG_BLK_DEV_BSG is not set
>  CONFIG_PARTITION_ADVANCED=y
> -CONFIG_EFI_PARTITION=y
>  CONFIG_ARCH_BCM=y
> -CONFIG_ARCH_BCM_MOBILE=y
>  CONFIG_ARM_THUMBEE=y
> -CONFIG_ARM_ERRATA_743622=y
>  CONFIG_PREEMPT=y
>  CONFIG_AEABI=y
>  # CONFIG_OABI_COMPAT is not set
> @@ -51,7 +47,6 @@ CONFIG_UNIX_DIAG=y
>  CONFIG_NET_KEY=y
>  CONFIG_INET=y
>  CONFIG_IP_MULTICAST=y
> -CONFIG_ARPD=y
>  CONFIG_SYN_COOKIES=y
>  CONFIG_TCP_MD5SIG=y
>  CONFIG_IPV6=y
> @@ -96,7 +91,6 @@ CONFIG_MMC_UNSAFE_RESUME=y
>  CONFIG_MMC_BLOCK_MINORS=32
>  CONFIG_MMC_TEST=y
>  CONFIG_MMC_SDHCI=y
> -CONFIG_MMC_SDHCI_PLTFM=y
>  CONFIG_MMC_SDHCI_BCM_KONA=y
>  CONFIG_NEW_LEDS=y
>  CONFIG_LEDS_CLASS=y
> @@ -118,12 +112,12 @@ CONFIG_CONFIGFS_FS=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  CONFIG_PRINTK_TIME=y
> -CONFIG_MAGIC_SYSRQ=y
> +CONFIG_DEBUG_INFO=y
>  CONFIG_DEBUG_FS=y
> +CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DETECT_HUNG_TASK=y
>  CONFIG_DEFAULT_HUNG_TASK_TIMEOUT=110
>  CONFIG_BOOTPARAM_HUNG_TASK_PANIC=y
> -CONFIG_DEBUG_INFO=y
>  # CONFIG_FTRACE is not set
>  CONFIG_CRC_CCITT=y
>  CONFIG_CRC_T10DIF=y
> --

Reviewed-by: Christian Daudt 
Applied to armsoc/for-3.13/soc
 thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH v2 2/6] ARM: dts: Specify clocks for UARTs on bcm11351

[Christian Daudt]

On Wed, Oct 16, 2013 at 2:47 PM, Tim Kryger  wrote:
> Rather than declaring the frequency of the external clock, specify the
> label of the clock such that the driver may determine the frequency on
> its own.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Markus Mayer 
> Reviewed-by: Matt Porter 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index c6464fb..ce65367 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -43,7 +43,7 @@
> compatible = "brcm,bcm11351-dw-apb-uart", "snps,dw-apb-uart";
> status = "disabled";
> reg = <0x3e00 0x1000>;
> -   clock-frequency = <1300>;
> +   clocks = <_clk>;
> interrupts = ;
> reg-shift = <2>;
> reg-io-width = <4>;

Hi Sebastian,
 this patch series (and a subsequent one from Tim) both rely on your
"ARM: provide common arch init for DT clocks" patchset in order to
work. Will that patchset be in 3.13 ? I don't want to pull the dt mods
unless they are as they break the boot without them.

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH 3/4] ARM: dts: bcm281xx: Add i2c busses

[Christian Daudt]

Hi Tim,
 This patch does not work as it relies on the yet-unmerged clock code
for bcm11351. This patch does not apply to -rc, and when tweaked it
does not compile as it references  non-existent bsc_clks.
 Has the clk patches been submitted yet ? Applying this will have to
wait until those have been accepted.

 thanks,
   csd


On Wed, Oct 16, 2013 at 3:01 PM, Tim Kryger  wrote:
> Add the DTS nodes for all the i2c busses in the SoC.
>
> Signed-off-by: Tim Kryger 
> Reviewed-by: Christian Daudt 
> Reviewed-by: Matt Porter 
> Reviewed-by: Markus Mayer 
> ---
>  arch/arm/boot/dts/bcm11351.dtsi | 40 
>  1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 1246885..4bfd7e3 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -146,6 +146,46 @@
> status = "disabled";
> };
>
> +   i2c@3e016000 {
> +   compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +   reg = <0x3e016000 0x80>;
> +   interrupts = ;
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   clocks = <_clk>;
> +   status = "disabled";
> +   };
> +
> +   i2c@3e017000 {
> +   compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +   reg = <0x3e017000 0x80>;
> +   interrupts = ;
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   clocks = <_clk>;
> +   status = "disabled";
> +   };
> +
> +   i2c@3e018000 {
> +   compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +   reg = <0x3e018000 0x80>;
> +   interrupts = ;
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   clocks = <_clk>;
> +   status = "disabled";
> +   };
> +
> +   i2c@3500d000 {
> +   compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +   reg = <0x3500d000 0x80>;
> +   interrupts = ;
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   clocks = <_bsc_clk>;
> +   status = "disabled";
> +   };
> +
> clocks {
> bsc1_clk: bsc1 {
> compatible = "fixed-clock";
> --
> 1.8.0.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH 3/4] ARM: dts: bcm281xx: Add i2c busses

[Christian Daudt]

Hi Tim,
 This patch does not work as it relies on the yet-unmerged clock code
for bcm11351. This patch does not apply to -rc, and when tweaked it
does not compile as it references  non-existent bsc_clks.
 Has the clk patches been submitted yet ? Applying this will have to
wait until those have been accepted.

 thanks,
   csd


On Wed, Oct 16, 2013 at 3:01 PM, Tim Kryger tim.kry...@linaro.org wrote:
 Add the DTS nodes for all the i2c busses in the SoC.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Christian Daudt c...@broadcom.com
 Reviewed-by: Matt Porter matt.por...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 ---
  arch/arm/boot/dts/bcm11351.dtsi | 40 
  1 file changed, 40 insertions(+)

 diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
 index 1246885..4bfd7e3 100644
 --- a/arch/arm/boot/dts/bcm11351.dtsi
 +++ b/arch/arm/boot/dts/bcm11351.dtsi
 @@ -146,6 +146,46 @@
 status = disabled;
 };

 +   i2c@3e016000 {
 +   compatible = brcm,bcm11351-i2c, brcm,kona-i2c;
 +   reg = 0x3e016000 0x80;
 +   interrupts = GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH;
 +   #address-cells = 1;
 +   #size-cells = 0;
 +   clocks = bsc1_clk;
 +   status = disabled;
 +   };
 +
 +   i2c@3e017000 {
 +   compatible = brcm,bcm11351-i2c, brcm,kona-i2c;
 +   reg = 0x3e017000 0x80;
 +   interrupts = GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH;
 +   #address-cells = 1;
 +   #size-cells = 0;
 +   clocks = bsc2_clk;
 +   status = disabled;
 +   };
 +
 +   i2c@3e018000 {
 +   compatible = brcm,bcm11351-i2c, brcm,kona-i2c;
 +   reg = 0x3e018000 0x80;
 +   interrupts = GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH;
 +   #address-cells = 1;
 +   #size-cells = 0;
 +   clocks = bsc3_clk;
 +   status = disabled;
 +   };
 +
 +   i2c@3500d000 {
 +   compatible = brcm,bcm11351-i2c, brcm,kona-i2c;
 +   reg = 0x3500d000 0x80;
 +   interrupts = GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH;
 +   #address-cells = 1;
 +   #size-cells = 0;
 +   clocks = pmu_bsc_clk;
 +   status = disabled;
 +   };
 +
 clocks {
 bsc1_clk: bsc1 {
 compatible = fixed-clock;
 --
 1.8.0.1


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RESEND PATCH v2 2/6] ARM: dts: Specify clocks for UARTs on bcm11351

[Christian Daudt]

On Wed, Oct 16, 2013 at 2:47 PM, Tim Kryger tim.kry...@linaro.org wrote:
 Rather than declaring the frequency of the external clock, specify the
 label of the clock such that the driver may determine the frequency on
 its own.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Markus Mayer markus.ma...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/boot/dts/bcm11351.dtsi | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

 diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
 index c6464fb..ce65367 100644
 --- a/arch/arm/boot/dts/bcm11351.dtsi
 +++ b/arch/arm/boot/dts/bcm11351.dtsi
 @@ -43,7 +43,7 @@
 compatible = brcm,bcm11351-dw-apb-uart, snps,dw-apb-uart;
 status = disabled;
 reg = 0x3e00 0x1000;
 -   clock-frequency = 1300;
 +   clocks = uartb_clk;
 interrupts = GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH;
 reg-shift = 2;
 reg-io-width = 4;

Hi Sebastian,
 this patch series (and a subsequent one from Tim) both rely on your
ARM: provide common arch init for DT clocks patchset in order to
work. Will that patchset be in 3.13 ? I don't want to pull the dt mods
unless they are as they break the boot without them.

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: bcm_defconfig: Run make savedefconfig

[Christian Daudt]

On Mon, Oct 14, 2013 at 2:41 PM, Tim Kryger tim.kry...@linaro.org wrote:
 Several of the options in bcm_defconfig have gotten out of date so
 regenerate it with make savedefconfig to keep things fresh.

 Signed-off-by: Tim Kryger tim.kry...@linaro.org
 Reviewed-by: Matt Porter matt.por...@linaro.org
 ---
  arch/arm/configs/bcm_defconfig | 10 ++
  1 file changed, 2 insertions(+), 8 deletions(-)

 diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
 index efb0132..3a138af 100644
 --- a/arch/arm/configs/bcm_defconfig
 +++ b/arch/arm/configs/bcm_defconfig
 @@ -1,4 +1,3 @@
 -CONFIG_EXPERIMENTAL=y
  # CONFIG_LOCALVERSION_AUTO is not set
  # CONFIG_SWAP is not set
  CONFIG_SYSVIPC=y
 @@ -25,11 +24,8 @@ CONFIG_MODULES=y
  CONFIG_MODULE_UNLOAD=y
  # CONFIG_BLK_DEV_BSG is not set
  CONFIG_PARTITION_ADVANCED=y
 -CONFIG_EFI_PARTITION=y
  CONFIG_ARCH_BCM=y
 -CONFIG_ARCH_BCM_MOBILE=y
  CONFIG_ARM_THUMBEE=y
 -CONFIG_ARM_ERRATA_743622=y
  CONFIG_PREEMPT=y
  CONFIG_AEABI=y
  # CONFIG_OABI_COMPAT is not set
 @@ -51,7 +47,6 @@ CONFIG_UNIX_DIAG=y
  CONFIG_NET_KEY=y
  CONFIG_INET=y
  CONFIG_IP_MULTICAST=y
 -CONFIG_ARPD=y
  CONFIG_SYN_COOKIES=y
  CONFIG_TCP_MD5SIG=y
  CONFIG_IPV6=y
 @@ -96,7 +91,6 @@ CONFIG_MMC_UNSAFE_RESUME=y
  CONFIG_MMC_BLOCK_MINORS=32
  CONFIG_MMC_TEST=y
  CONFIG_MMC_SDHCI=y
 -CONFIG_MMC_SDHCI_PLTFM=y
  CONFIG_MMC_SDHCI_BCM_KONA=y
  CONFIG_NEW_LEDS=y
  CONFIG_LEDS_CLASS=y
 @@ -118,12 +112,12 @@ CONFIG_CONFIGFS_FS=y
  CONFIG_NLS_CODEPAGE_437=y
  CONFIG_NLS_ISO8859_1=y
  CONFIG_PRINTK_TIME=y
 -CONFIG_MAGIC_SYSRQ=y
 +CONFIG_DEBUG_INFO=y
  CONFIG_DEBUG_FS=y
 +CONFIG_MAGIC_SYSRQ=y
  CONFIG_DETECT_HUNG_TASK=y
  CONFIG_DEFAULT_HUNG_TASK_TIMEOUT=110
  CONFIG_BOOTPARAM_HUNG_TASK_PANIC=y
 -CONFIG_DEBUG_INFO=y
  # CONFIG_FTRACE is not set
  CONFIG_CRC_CCITT=y
  CONFIG_CRC_T10DIF=y
 --

Reviewed-by: Christian Daudt b...@fixthebug.org
Applied to armsoc/for-3.13/soc
 thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

This patch adds low level debug uart support to Broadcom
 mobile based SOCs.

Signed-off-by: Christian Daudt 

Changes from V2:
 - Changed to follow hex ordering on entries
 - Dropped defconfig changes

Changes from V1:
 - Switched to use the common 8250 debug introduced in 3.12-rc1

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 9762c84..0391691 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -94,6 +94,17 @@ choice
depends on ARCH_BCM2835
select DEBUG_UART_PL01X
 
+   config DEBUG_BCM_KONA_UART
+   bool "Kernel low-level debugging messages via BCM KONA UART"
+   depends on ARCH_BCM
+   select DEBUG_UART_8250
+   help
+ Say Y here if you want kernel low-level debugging support
+ on Broadcom SoC platforms.
+ This low level debug works for Broadcom
+ mobile SoCs in the Kona family of chips (e.g. bcm28155,
+ bcm11351, etc...)
+
config DEBUG_CLPS711X_UART1
bool "Kernel low-level debugging messages via UART1"
depends on ARCH_CLPS711X
@@ -951,6 +962,7 @@ config DEBUG_UART_PHYS
default 0x20064000 if DEBUG_RK29_UART1 || DEBUG_RK3X_UART2
default 0x20068000 if DEBUG_RK29_UART2 || DEBUG_RK3X_UART3
default 0x20201000 if DEBUG_BCM2835
+   default 0x3e00 if DEBUG_BCM_KONA_UART
default 0x4009 if ARCH_LPC32XX
default 0x4010 if DEBUG_PXA_UART1
default 0x4200 if ARCH_GEMINI
@@ -1010,6 +1022,7 @@ config DEBUG_UART_VIRT
default 0xfe018000 if DEBUG_MMP_UART3
default 0xfe10 if DEBUG_IMX23_UART || DEBUG_IMX28_UART
default 0xfe23 if DEBUG_PICOXCELL_UART
+   default 0xfe30 if DEBUG_BCM_KONA_UART
default 0xfe80 if ARCH_IOP32X
default 0xfeb0 if DEBUG_HI3620_UART || DEBUG_HI3716_UART
default 0xfeb24000 if DEBUG_RK3X_UART0
@@ -1052,7 +1065,8 @@ config DEBUG_UART_8250_WORD
default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART || \
ARCH_KEYSTONE || \
DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
-   DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1
+   DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1 || \
+   DEBUG_BCM_KONA_UART
 
 config DEBUG_UART_8250_FLOW_CONTROL
bool "Enable flow control for 8250 UART"
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

This patch adds low level debug uart support to Broadcom
 mobile based SOCs.

Signed-off-by: Christian Daudt b...@fixthebug.org

Changes from V2:
 - Changed to follow hex ordering on entries
 - Dropped defconfig changes

Changes from V1:
 - Switched to use the common 8250 debug introduced in 3.12-rc1

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 9762c84..0391691 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -94,6 +94,17 @@ choice
depends on ARCH_BCM2835
select DEBUG_UART_PL01X
 
+   config DEBUG_BCM_KONA_UART
+   bool Kernel low-level debugging messages via BCM KONA UART
+   depends on ARCH_BCM
+   select DEBUG_UART_8250
+   help
+ Say Y here if you want kernel low-level debugging support
+ on Broadcom SoC platforms.
+ This low level debug works for Broadcom
+ mobile SoCs in the Kona family of chips (e.g. bcm28155,
+ bcm11351, etc...)
+
config DEBUG_CLPS711X_UART1
bool Kernel low-level debugging messages via UART1
depends on ARCH_CLPS711X
@@ -951,6 +962,7 @@ config DEBUG_UART_PHYS
default 0x20064000 if DEBUG_RK29_UART1 || DEBUG_RK3X_UART2
default 0x20068000 if DEBUG_RK29_UART2 || DEBUG_RK3X_UART3
default 0x20201000 if DEBUG_BCM2835
+   default 0x3e00 if DEBUG_BCM_KONA_UART
default 0x4009 if ARCH_LPC32XX
default 0x4010 if DEBUG_PXA_UART1
default 0x4200 if ARCH_GEMINI
@@ -1010,6 +1022,7 @@ config DEBUG_UART_VIRT
default 0xfe018000 if DEBUG_MMP_UART3
default 0xfe10 if DEBUG_IMX23_UART || DEBUG_IMX28_UART
default 0xfe23 if DEBUG_PICOXCELL_UART
+   default 0xfe30 if DEBUG_BCM_KONA_UART
default 0xfe80 if ARCH_IOP32X
default 0xfeb0 if DEBUG_HI3620_UART || DEBUG_HI3716_UART
default 0xfeb24000 if DEBUG_RK3X_UART0
@@ -1052,7 +1065,8 @@ config DEBUG_UART_8250_WORD
default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART || \
ARCH_KEYSTONE || \
DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
-   DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1
+   DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1 || \
+   DEBUG_BCM_KONA_UART
 
 config DEBUG_UART_8250_FLOW_CONTROL
bool Enable flow control for 8250 UART
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

On Tue, Sep 17, 2013 at 5:05 PM, Christian Daudt  wrote:
> This patch adds low level debug uart support to Broadcom
>  mobile based SOCs.
>
> Signed-off-by: Christian Daudt 
>
> Changes from V1:
>  - Switched to use the common 8250 debug introduced in 3.12-rc1
>
Hi Russell,
 Are you okay with v2 of DEBUG_LL support for Broadcom mobile SoC ? If
so, should I submit it through your patchqueue ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

On Tue, Sep 17, 2013 at 5:05 PM, Christian Daudt c...@broadcom.com wrote:
 This patch adds low level debug uart support to Broadcom
  mobile based SOCs.

 Signed-off-by: Christian Daudt c...@broadcom.com

 Changes from V1:
  - Switched to use the common 8250 debug introduced in 3.12-rc1

Hi Russell,
 Are you okay with v2 of DEBUG_LL support for Broadcom mobile SoC ? If
so, should I submit it through your patchqueue ?

 Thanks,
   csd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ARM: bcm281xx: Add ARCH Timers to config

[Christian Daudt]

Add HAVE_ARM_ARCH_TIMER to Broadcom Kconfig as it is
required for some Mobile SoCs.

Signed-off-by: Christian Daudt 
Reviewed-by: Markus Mayer 
Reviewed-by: Mark Hambleton 
Reviewed-by: James King 

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 69d67f7..635537b 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -13,6 +13,7 @@ config ARCH_BCM
select SPARSE_IRQ
select TICK_ONESHOT
select CACHE_L2X0
+   select HAVE_ARM_ARCH_TIMER
help
  This enables support for system based on Broadcom SoCs.
  It currently supports the 'BCM281XX' family, which includes
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ARM: bcm281xx: more descriptive machine string

[Christian Daudt]

Add SoC model to DT_MACHINE_START string.

Signed-off-by: Christian Daudt 
Reviewed-by: Markus Mayer 
Reviewed-by: Mark Hambleton 
Reviewed-by: James King 

diff --git a/arch/arm/mach-bcm/board_bcm281xx.c 
b/arch/arm/mach-bcm/board_bcm281xx.c
index 8d9f931..dcfaf4a 100644
--- a/arch/arm/mach-bcm/board_bcm281xx.c
+++ b/arch/arm/mach-bcm/board_bcm281xx.c
@@ -67,7 +67,7 @@ static void __init board_init(void)
 
 static const char * const bcm11351_dt_compat[] = { "brcm,bcm11351", NULL, };
 
-DT_MACHINE_START(BCM11351_DT, "Broadcom Application Processor")
+DT_MACHINE_START(BCM11351_DT, "BCM281xx Broadcom Application Processor")
.init_time = clocksource_of_init,
.init_machine = board_init,
.restart = bcm_kona_restart,
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ARM: bcm281xx: more descriptive machine string

[Christian Daudt]

Add SoC model to DT_MACHINE_START string.

Signed-off-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Markus Mayer mma...@broadcom.com
Reviewed-by: Mark Hambleton maham...@broadcom.com
Reviewed-by: James King jam...@broadcom.com

diff --git a/arch/arm/mach-bcm/board_bcm281xx.c 
b/arch/arm/mach-bcm/board_bcm281xx.c
index 8d9f931..dcfaf4a 100644
--- a/arch/arm/mach-bcm/board_bcm281xx.c
+++ b/arch/arm/mach-bcm/board_bcm281xx.c
@@ -67,7 +67,7 @@ static void __init board_init(void)
 
 static const char * const bcm11351_dt_compat[] = { brcm,bcm11351, NULL, };
 
-DT_MACHINE_START(BCM11351_DT, Broadcom Application Processor)
+DT_MACHINE_START(BCM11351_DT, BCM281xx Broadcom Application Processor)
.init_time = clocksource_of_init,
.init_machine = board_init,
.restart = bcm_kona_restart,
-- 
1.7.10.4


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ARM: bcm281xx: Add ARCH Timers to config

[Christian Daudt]

Add HAVE_ARM_ARCH_TIMER to Broadcom Kconfig as it is
required for some Mobile SoCs.

Signed-off-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Markus Mayer mma...@broadcom.com
Reviewed-by: Mark Hambleton maham...@broadcom.com
Reviewed-by: James King jam...@broadcom.com

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 69d67f7..635537b 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -13,6 +13,7 @@ config ARCH_BCM
select SPARSE_IRQ
select TICK_ONESHOT
select CACHE_L2X0
+   select HAVE_ARM_ARCH_TIMER
help
  This enables support for system based on Broadcom SoCs.
  It currently supports the 'BCM281XX' family, which includes
-- 
1.7.10.4


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 00/26] ARM: provide common arch init for DT clocks

[Christian Daudt]

On 13-09-23 10:45 AM, Matt Porter wrote:

On 09/22/2013 08:14 AM, Sebastian Hesselbarth wrote:

On 09/20/2013 09:16 PM, Matt Porter wrote:

On Wed, Sep 18, 2013 at 07:53:33PM +0200, Sebastian Hesselbarth wrote:

This is a patch set based on an RFC [1][2] sent earlier to provide a
common
arch/arm init for DT clock providers. Currently, the call to
of_clk_init(NULL)
to initialize DT clock providers is spread among several mach-dirs.
Since most
machs require DT clocks initialized before timers, no initcall can be
used.

[...]

Could you pick up the following patch for mach-bcm/ into this series?

Thanks,
Matt

 From f65d048b3453447bb3e693cb21701c4d0c6375ed Mon Sep 17 00:00:00 2001
From: Matt Porter 
Date: Fri, 20 Sep 2013 13:41:06 -0400
Subject: [PATCH] ARM: bcm: Remove custom .time_init hook

With arch/arm calling of_clk_init(NULL) and clocksource_of_init()
this is no longer needed. The former is useful because we can make
use of dummy fixed clocks for drivers until the bcm281xx common
clock driver is ready.

Signed-off-by: Matt Porter 
Reviewed-by: Markus Mayer 
Reviewed-by: Christian Daudt 


As a v2 is required due to calling of_clk_init() breaks non-DT builds,
I will include this _if_ Christian actually gives his Acked-By.


Understood. Ccing Christian's new email as it just changed.

Old one still works for this week :)
Acked-by: Christian Daudt 

 Thanks,
   csd



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 00/26] ARM: provide common arch init for DT clocks

[Christian Daudt]

On 13-09-23 10:45 AM, Matt Porter wrote:

On 09/22/2013 08:14 AM, Sebastian Hesselbarth wrote:

On 09/20/2013 09:16 PM, Matt Porter wrote:

On Wed, Sep 18, 2013 at 07:53:33PM +0200, Sebastian Hesselbarth wrote:

This is a patch set based on an RFC [1][2] sent earlier to provide a
common
arch/arm init for DT clock providers. Currently, the call to
of_clk_init(NULL)
to initialize DT clock providers is spread among several mach-dirs.
Since most
machs require DT clocks initialized before timers, no initcall can be
used.

[...]

Could you pick up the following patch for mach-bcm/ into this series?

Thanks,
Matt

 From f65d048b3453447bb3e693cb21701c4d0c6375ed Mon Sep 17 00:00:00 2001
From: Matt Porter matt.por...@linaro.org
Date: Fri, 20 Sep 2013 13:41:06 -0400
Subject: [PATCH] ARM: bcm: Remove custom .time_init hook

With arch/arm calling of_clk_init(NULL) and clocksource_of_init()
this is no longer needed. The former is useful because we can make
use of dummy fixed clocks for drivers until the bcm281xx common
clock driver is ready.

Signed-off-by: Matt Porter matt.por...@linaro.org
Reviewed-by: Markus Mayer markus.ma...@linaro.org
Reviewed-by: Christian Daudt c...@broadcom.com


As a v2 is required due to calling of_clk_init() breaks non-DT builds,
I will include this _if_ Christian actually gives his Acked-By.


Understood. Ccing Christian's new email as it just changed.

Old one still works for this week :)
Acked-by: Christian Daudt c...@broadcom.com

 Thanks,
   csd



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] MAINTAINERS: Update mach-bcm related email address

[Christian Daudt]

Update email address on mach-bcm + drivers for Broadcom
mobile SoCs.

Signed-off-by: Christian Daudt 
Cc: Olof Johansson 
Cc: Arnd Bergmann 
Cc: Stephen Warren 

diff --git a/MAINTAINERS b/MAINTAINERS
index e61c2e8..b2f857c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1812,7 +1812,8 @@ S:Supported
 F: drivers/net/ethernet/broadcom/bnx2x/
 
 BROADCOM BCM281XX/BCM11XXX ARM ARCHITECTURE
-M: Christian Daudt 
+M: Christian Daudt 
+L: bcm-kernel-feedback-l...@broadcom.com
 T: git git://git.github.com/broadcom/bcm11351
 S: Maintained
 F: arch/arm/mach-bcm/
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] MAINTAINERS: Update mach-bcm related email address

[Christian Daudt]

Update email address on mach-bcm + drivers for Broadcom
mobile SoCs.

Signed-off-by: Christian Daudt c...@broadcom.com
Cc: Olof Johansson o...@lixom.net
Cc: Arnd Bergmann a...@arndb.de
Cc: Stephen Warren swar...@wwwdotorg.org

diff --git a/MAINTAINERS b/MAINTAINERS
index e61c2e8..b2f857c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1812,7 +1812,8 @@ S:Supported
 F: drivers/net/ethernet/broadcom/bnx2x/
 
 BROADCOM BCM281XX/BCM11XXX ARM ARCHITECTURE
-M: Christian Daudt c...@broadcom.com
+M: Christian Daudt b...@fixthebug.org
+L: bcm-kernel-feedback-l...@broadcom.com
 T: git git://git.github.com/broadcom/bcm11351
 S: Maintained
 F: arch/arm/mach-bcm/
-- 
1.7.10.4


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 06/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

[Christian Daudt]

On 13-08-12 06:54 AM, Lee Jones wrote:

On Thu, 08 Aug 2013, Christian Daudt wrote:


Hi Lee,
  I had to change some of the lines in the dts files you modified, so
I've added your mods. This patch:
https://lkml.org/lkml/2013/8/8/477

includes your changes to bcm11351.dtsi and bcm11351-brt.dts. Not sure
where your patch is at this point, but I just wanted to point that
out.

I haven't done anything with that patch yet, but I'd prefer they
stayed separate to be honest. If you make your changes and ensure
they're in an upstream tree (and let me know which one), I'll rebase
my patches on top of that tree.


These changes are in 3.12-rc1 now:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d7358f845645c588aff84ac6b476a17d3eec75fa


 thanks,
   csd



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 06/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

[Christian Daudt]

On 13-08-12 06:54 AM, Lee Jones wrote:

On Thu, 08 Aug 2013, Christian Daudt wrote:


Hi Lee,
  I had to change some of the lines in the dts files you modified, so
I've added your mods. This patch:
https://lkml.org/lkml/2013/8/8/477

includes your changes to bcm11351.dtsi and bcm11351-brt.dts. Not sure
where your patch is at this point, but I just wanted to point that
out.

I haven't done anything with that patch yet, but I'd prefer they
stayed separate to be honest. If you make your changes and ensure
they're in an upstream tree (and let me know which one), I'll rebase
my patches on top of that tree.


These changes are in 3.12-rc1 now:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d7358f845645c588aff84ac6b476a17d3eec75fa


 thanks,
   csd



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

This patch adds low level debug uart support to Broadcom
 mobile based SOCs.

Signed-off-by: Christian Daudt 

Changes from V1:
 - Switched to use the common 8250 debug introduced in 3.12-rc1

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 9762c84..0523e71 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -94,6 +94,17 @@ choice
depends on ARCH_BCM2835
select DEBUG_UART_PL01X
 
+   config DEBUG_BCM_KONA_UART
+   bool "Kernel low-level debugging messages via BCM KONA UART"
+   depends on ARCH_BCM
+   select DEBUG_UART_8250
+   help
+ Say Y here if you want kernel low-level debugging support
+ on Broadcom SoC platforms.
+ This low level debug works for Broadcom
+ mobile SoCs in the Kona family of chips (e.g. bcm28155,
+ bcm11351, etc...)
+
config DEBUG_CLPS711X_UART1
bool "Kernel low-level debugging messages via UART1"
depends on ARCH_CLPS711X
@@ -980,6 +991,7 @@ config DEBUG_UART_PHYS
default 0xffd82340 if ARCH_IOP13XX
default 0xfff36000 if DEBUG_HIGHBANK_UART
default 0xf700 if ARCH_IOP33X
+   default 0x3e00 if DEBUG_BCM_KONA_UART
depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
DEBUG_UART_8250 || DEBUG_UART_PL01X
 
@@ -1035,6 +1047,7 @@ config DEBUG_UART_VIRT
default 0xfef3 if ARCH_IXP4XX && CPU_BIG_ENDIAN
default 0xfefff700 if ARCH_IOP33X
default 0xff003000 if DEBUG_U300_UART
+   default 0xfe30 if DEBUG_BCM_KONA_UART
default DEBUG_UART_PHYS if !MMU
depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
DEBUG_UART_8250 || DEBUG_UART_PL01X
@@ -1052,7 +1065,8 @@ config DEBUG_UART_8250_WORD
default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART || \
ARCH_KEYSTONE || \
DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
-   DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1
+   DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1 || \
+   DEBUG_BCM_KONA_UART
 
 config DEBUG_UART_8250_FLOW_CONTROL
bool "Enable flow control for 8250 UART"
diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index 6e49310..5c12c4c 100644
--- a/arch/arm/configs/bcm_defconfig
+++ b/arch/arm/configs/bcm_defconfig
@@ -30,6 +30,8 @@ CONFIG_ARCH_BCM=y
 CONFIG_ARM_THUMBEE=y
 CONFIG_ARM_ERRATA_743622=y
 CONFIG_PREEMPT=y
+CONFIG_DEBUG_LL=y
+CONFIG_DEBUG_BCM_KONA_UART=y
 CONFIG_AEABI=y
 # CONFIG_OABI_COMPAT is not set
 # CONFIG_COMPACTION is not set
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

This patch adds low level debug uart support to Broadcom
 mobile based SOCs.

Signed-off-by: Christian Daudt 
Reviewed-by: James King 

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 583f4a0..a69d62a 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -93,6 +93,16 @@ choice
bool "Kernel low-level debugging on BCM2835 PL011 UART"
depends on ARCH_BCM2835
 
+   config DEBUG_BCM_KONA_UART
+   bool "Kernel low-level debugging messages via BCM KONA UART"
+   depends on ARCH_BCM
+   help
+ Say Y here if you want kernel low-level debugging support
+ on Broadcom SoC platforms.
+ This low level debug works for Broadcom
+ mobile SoCs in the Kona family of chips (e.g. bcm28155,
+ bcm11351, etc...)
+
config DEBUG_CLPS711X_UART1
bool "Kernel low-level debugging messages via UART1"
depends on ARCH_CLPS711X
@@ -761,6 +771,7 @@ endchoice
 
 config DEBUG_LL_INCLUDE
string
+   default "debug/bcm_kona.S" if DEBUG_BCM_KONA_UART
default "debug/bcm2835.S" if DEBUG_BCM2835
default "debug/cns3xxx.S" if DEBUG_CNS3XXX
default "debug/exynos.S" if DEBUG_EXYNOS_UART
diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index 65edf6d..ace92e4 100644
--- a/arch/arm/configs/bcm_defconfig
+++ b/arch/arm/configs/bcm_defconfig
@@ -30,6 +30,8 @@ CONFIG_ARCH_BCM=y
 CONFIG_ARM_THUMBEE=y
 CONFIG_ARM_ERRATA_743622=y
 CONFIG_PREEMPT=y
+CONFIG_DEBUG_LL=y
+CONFIG_DEBUG_BCM_KONA_UART=y
 CONFIG_AEABI=y
 # CONFIG_OABI_COMPAT is not set
 # CONFIG_COMPACTION is not set
diff --git a/arch/arm/include/debug/bcm_kona.S 
b/arch/arm/include/debug/bcm_kona.S
new file mode 100644
index 000..5e22032
--- /dev/null
+++ b/arch/arm/include/debug/bcm_kona.S
@@ -0,0 +1,20 @@
+/*
+ * Copyright (C) 1994-1999 Russell King
+ * Moved from linux/arch/arm/kernel/debug.S by Ben Dooks
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * Modified by Broadcom for Kona chipsets
+ */
+#defineUARTB_PHYS_BASE 0x3e00
+#defineUART_SHIFT  2
+
+   .macro  addruart, rp, rv, tmp
+   mov \rp, #UARTB_PHYS_BASE   @ physical base address of UART
+   mov \rv, #0x0e30@ virtual base address of UART
+   orr \rv, \rv, #0xf000
+   .endm
+
+#include "8250_32.S"
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

On 13-09-17 03:03 PM, Russell King - ARM Linux wrote:

On Tue, Sep 17, 2013 at 02:59:47PM -0700, Christian Daudt wrote:

This patch adds low level debug uart support to Broadcom
  mobile based SOCs.

Signed-off-by: Christian Daudt 
Reviewed-by: James King 

Unfortunately, your patch is out of date.

Please have a look at v3.12-rc1's debugging infrastructure.  You should
not need to add any .S file(s) for 8250 based ports, and in fact,
8250_32.S is gone.  It's now all done through Kconfig for these ports.

Thanks.


Oops. Ok, I last rebased it against -11-rc4. I'll rework it for 12-rc1 then.

 Thanks,
   csd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

On 13-09-17 03:03 PM, Russell King - ARM Linux wrote:

On Tue, Sep 17, 2013 at 02:59:47PM -0700, Christian Daudt wrote:

This patch adds low level debug uart support to Broadcom
  mobile based SOCs.

Signed-off-by: Christian Daudt c...@broadcom.com
Reviewed-by: James King jam...@broadcom.com

Unfortunately, your patch is out of date.

Please have a look at v3.12-rc1's debugging infrastructure.  You should
not need to add any .S file(s) for 8250 based ports, and in fact,
8250_32.S is gone.  It's now all done through Kconfig for these ports.

Thanks.


Oops. Ok, I last rebased it against -11-rc4. I'll rework it for 12-rc1 then.

 Thanks,
   csd


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

This patch adds low level debug uart support to Broadcom
 mobile based SOCs.

Signed-off-by: Christian Daudt c...@broadcom.com
Reviewed-by: James King jam...@broadcom.com

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 583f4a0..a69d62a 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -93,6 +93,16 @@ choice
bool Kernel low-level debugging on BCM2835 PL011 UART
depends on ARCH_BCM2835
 
+   config DEBUG_BCM_KONA_UART
+   bool Kernel low-level debugging messages via BCM KONA UART
+   depends on ARCH_BCM
+   help
+ Say Y here if you want kernel low-level debugging support
+ on Broadcom SoC platforms.
+ This low level debug works for Broadcom
+ mobile SoCs in the Kona family of chips (e.g. bcm28155,
+ bcm11351, etc...)
+
config DEBUG_CLPS711X_UART1
bool Kernel low-level debugging messages via UART1
depends on ARCH_CLPS711X
@@ -761,6 +771,7 @@ endchoice
 
 config DEBUG_LL_INCLUDE
string
+   default debug/bcm_kona.S if DEBUG_BCM_KONA_UART
default debug/bcm2835.S if DEBUG_BCM2835
default debug/cns3xxx.S if DEBUG_CNS3XXX
default debug/exynos.S if DEBUG_EXYNOS_UART
diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index 65edf6d..ace92e4 100644
--- a/arch/arm/configs/bcm_defconfig
+++ b/arch/arm/configs/bcm_defconfig
@@ -30,6 +30,8 @@ CONFIG_ARCH_BCM=y
 CONFIG_ARM_THUMBEE=y
 CONFIG_ARM_ERRATA_743622=y
 CONFIG_PREEMPT=y
+CONFIG_DEBUG_LL=y
+CONFIG_DEBUG_BCM_KONA_UART=y
 CONFIG_AEABI=y
 # CONFIG_OABI_COMPAT is not set
 # CONFIG_COMPACTION is not set
diff --git a/arch/arm/include/debug/bcm_kona.S 
b/arch/arm/include/debug/bcm_kona.S
new file mode 100644
index 000..5e22032
--- /dev/null
+++ b/arch/arm/include/debug/bcm_kona.S
@@ -0,0 +1,20 @@
+/*
+ * Copyright (C) 1994-1999 Russell King
+ * Moved from linux/arch/arm/kernel/debug.S by Ben Dooks
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * Modified by Broadcom for Kona chipsets
+ */
+#defineUARTB_PHYS_BASE 0x3e00
+#defineUART_SHIFT  2
+
+   .macro  addruart, rp, rv, tmp
+   mov \rp, #UARTB_PHYS_BASE   @ physical base address of UART
+   mov \rv, #0x0e30@ virtual base address of UART
+   orr \rv, \rv, #0xf000
+   .endm
+
+#include 8250_32.S
-- 
1.7.10.4


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] ARM: bcm: Add DEBUG_LL console support

[Christian Daudt]

This patch adds low level debug uart support to Broadcom
 mobile based SOCs.

Signed-off-by: Christian Daudt c...@broadcom.com

Changes from V1:
 - Switched to use the common 8250 debug introduced in 3.12-rc1

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 9762c84..0523e71 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -94,6 +94,17 @@ choice
depends on ARCH_BCM2835
select DEBUG_UART_PL01X
 
+   config DEBUG_BCM_KONA_UART
+   bool Kernel low-level debugging messages via BCM KONA UART
+   depends on ARCH_BCM
+   select DEBUG_UART_8250
+   help
+ Say Y here if you want kernel low-level debugging support
+ on Broadcom SoC platforms.
+ This low level debug works for Broadcom
+ mobile SoCs in the Kona family of chips (e.g. bcm28155,
+ bcm11351, etc...)
+
config DEBUG_CLPS711X_UART1
bool Kernel low-level debugging messages via UART1
depends on ARCH_CLPS711X
@@ -980,6 +991,7 @@ config DEBUG_UART_PHYS
default 0xffd82340 if ARCH_IOP13XX
default 0xfff36000 if DEBUG_HIGHBANK_UART
default 0xf700 if ARCH_IOP33X
+   default 0x3e00 if DEBUG_BCM_KONA_UART
depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
DEBUG_UART_8250 || DEBUG_UART_PL01X
 
@@ -1035,6 +1047,7 @@ config DEBUG_UART_VIRT
default 0xfef3 if ARCH_IXP4XX  CPU_BIG_ENDIAN
default 0xfefff700 if ARCH_IOP33X
default 0xff003000 if DEBUG_U300_UART
+   default 0xfe30 if DEBUG_BCM_KONA_UART
default DEBUG_UART_PHYS if !MMU
depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
DEBUG_UART_8250 || DEBUG_UART_PL01X
@@ -1052,7 +1065,8 @@ config DEBUG_UART_8250_WORD
default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART || \
ARCH_KEYSTONE || \
DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
-   DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1
+   DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1 || \
+   DEBUG_BCM_KONA_UART
 
 config DEBUG_UART_8250_FLOW_CONTROL
bool Enable flow control for 8250 UART
diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index 6e49310..5c12c4c 100644
--- a/arch/arm/configs/bcm_defconfig
+++ b/arch/arm/configs/bcm_defconfig
@@ -30,6 +30,8 @@ CONFIG_ARCH_BCM=y
 CONFIG_ARM_THUMBEE=y
 CONFIG_ARM_ERRATA_743622=y
 CONFIG_PREEMPT=y
+CONFIG_DEBUG_LL=y
+CONFIG_DEBUG_BCM_KONA_UART=y
 CONFIG_AEABI=y
 # CONFIG_OABI_COMPAT is not set
 # CONFIG_COMPACTION is not set
-- 
1.7.10.4


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/