Re: [patch 0/9] time: Add SPDX identifiers and cleanup boilerplates

2018-10-31 Thread Corey Minyard
on a script and data from Philippe Ombredanne, Kate Stewart and myself. The data has been created with two independent license scanners and manual inspection. Wow, Arques Ave.  That was about five moves ago. Anyway, this looks good to me.  Thanks. Acked-by: Corey Minyard -corey

Re: linux-next: Signed-off-by missing for commit in the ipmi tree

2018-08-30 Thread Corey Minyard
On 08/30/2018 04:37 PM, Stephen Rothwell wrote: Hi Corey, Commit 6320fd2c65b5 ("ipmi: fix return value of ipmi_set_my_LUN") is missing a Signed-off-by from its committer. Thanks, got it. -corey

Re: [PATCH 2/6] device: Add #define dev_fmt similar to #define pr_fmt

2018-07-06 Thread Corey Minyard
On 07/06/2018 10:50 AM, Greg Kroah-Hartman wrote: On Fri, Jul 06, 2018 at 08:41:34AM -0700, Joe Perches wrote: On Fri, 2018-07-06 at 17:30 +0200, Greg Kroah-Hartman wrote: On Wed, May 09, 2018 at 08:15:46AM -0700, Joe Perches wrote: Add a prefixing macro to dev_ uses similar to the pr_fmt

[GIT PULL] IPMI updates for 4.18

2018-06-05 Thread Corey Minyard
! Avi Fishman (1):   ipmi: NPCM7xx KCS BMC: enable interrupt to the host Corey Minyard (32):   ipmi: Add a way to tune some timeouts   ipmi: Add a maintenance mode for IPMB messages   ipmi:watchdog: Rework locking

Re: [PATCH 0/6] treewide: Add and use dev_fmt similar to pr_fmt

2018-05-09 Thread Corey Minyard
On 05/09/2018 12:04 PM, Joe Perches wrote: On Wed, 2018-05-09 at 11:47 -0500, Corey Minyard wrote: On 05/09/2018 10:15 AM, Joe Perches wrote: The pr_fmt mechanism exists for pr_ logging message prefixing, but no similar capability exists for dev_ message prefixing. Many uses of dev_ have

Re: [PATCH 0/6] treewide: Add and use dev_fmt similar to pr_fmt

2018-05-09 Thread Corey Minyard
On 05/09/2018 10:15 AM, Joe Perches wrote: The pr_fmt mechanism exists for pr_ logging message prefixing, but no similar capability exists for dev_ message prefixing. Many uses of dev_ have an embedded prefix for logging output. So add a similar dev_fmt macro that can automatically prefix the

Re: [PATCH 16/39] ipmi: simplify procfs code

2018-04-19 Thread Corey Minyard
On 04/19/2018 07:41 AM, Christoph Hellwig wrote: Use remove_proc_subtree to remove the whole subtree on cleanup instead of a hand rolled list of proc entries, unwind the registration loop into individual calls. Switch to use proc_create_single to further simplify the code. I'm yanking all the

Re: [PATCH] ipmi_ssif: Fix uninitialized variable issue

2018-04-19 Thread Corey Minyard
On 04/19/2018 08:24 AM, Gustavo A. R. Silva wrote: Currently, function ssif_remove returns _rv_, which is a variable that is never initialized. Fix this by removing variable _rv_ and return 0 instead. This fix is in my next tree now, thanks for catching this before it got any further than

Re: [PATCH ipmi/kcs_bmc v1] ipmi: add an NPCM7xx KCS BMC driver

2018-04-13 Thread Corey Minyard
On 03/22/2018 07:50 AM, Haiyue Wang wrote: This driver exposes the Keyboard Controller Style (KCS) interface on Novoton NPCM7xx SoCs as a character device. Such SOCs are commonly used as a BaseBoard Management Controller (BMC) on a server board, and KCS interface is commonly used to perform the

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-13 Thread Corey Minyard
not that important, and if you really want this patch, I can include it. Thanks, -corey BR, Haiyue On 2018-04-07 10:37, Wang, Haiyue wrote: On 2018-04-07 05:47, Corey Minyard wrote: On 03/15/2018 07:20 AM, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-06 Thread Corey Minyard
On 03/15/2018 07:20 AM, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment. I'm finally getting to this. Is there a reason you want to do this?  In general, it's better to not try to outsmart your base system.  Depending on the

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-03 Thread Corey Minyard
On 04/03/2018 01:00 AM, Wang, Haiyue wrote: Hi Corey, The 4.17 merge window is opened now, this patch is not yet in linux-next tree, so it will be merged into 4.18 ? Yeah, this came in kind of late, and I had some other critical things I was having to focus on, so I've been kind of out of

[GIT PULL] IPMI updates for 4.17

2018-04-03 Thread Corey Minyard
calculation Corey Minyard (8):   ipmi:pci: Make the PCI defines consistent with normal Linux ones   ipmi: Add or fix SPDX-License-Identifier in all files   ipmi: Fix some error cleanup issues   ipmi: Remove some unnecessary initializations   ipmi: Consolidate cleanup code

Re: [PATCH] ipmi:pci: Blacklist a Realtek "IPMI" device

2018-03-13 Thread Corey Minyard
On 03/13/2018 02:27 AM, Daniel Drake wrote: Hi, On Mon, Feb 26, 2018 at 10:50 AM, <miny...@acm.org> wrote: From: Corey Minyard <cminy...@mvista.com> Realtek has some sort of "Virtual" IPMI device on the PCI bus as a KCS controller, but whatever it is, it's not o

Re: [PATCH] ipmi: Remove ACPI SPMI probing from the SSIF (I2C) driver

2018-03-09 Thread Corey Minyard
On 03/09/2018 04:28 PM, Jiandi An wrote: On 03/08/2018 03:08 PM, miny...@acm.org wrote: From: Corey Minyard <cminy...@mvista.com> The IPMI spec states:    The purpose of the SPMI Table is to provide a mechanism that can    be used by the OSPM (an ACPI term for “OS Operating System-di

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-09 Thread Corey Minyard
On 03/09/2018 11:46 AM, Peter Zijlstra wrote: On Fri, Mar 09, 2018 at 12:04:18PM +0100, Sebastian Andrzej Siewior wrote: +void swake_add_all_wq(struct swait_queue_head *q, struct wake_q_head *wq) { struct swait_queue *curr; while (!list_empty(>task_list)) { curr =

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-09 Thread Corey Minyard
On 03/09/2018 08:58 AM, Sebastian Andrzej Siewior wrote: On 2018-03-09 07:29:31 [-0600], Corey Minyard wrote: From what I can tell, wake_up_q() is unbounded, and you have undone what the previous code had tried to accomplish.  In the scenario I'm talking about, interrupts are still disabled

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-09 Thread Corey Minyard
On 03/09/2018 05:04 AM, Sebastian Andrzej Siewior wrote: On 2018-03-08 13:54:17 [-0600], Corey Minyard wrote: It will work but I don't think pushing this into workqueue/tasklet is a good idea. You want to wakeup all waiters on waitqueue X (probably one waiter) and instead there is one one

Re: [PATCH] ipmi:ssif: Fix double probe from tryacpi and trydmi

2018-03-08 Thread Corey Minyard
On 03/08/2018 12:18 PM, Jiandi An wrote: On 03/08/2018 08:10 AM, Corey Minyard wrote: On 03/07/2018 05:59 PM, Jiandi An wrote: On 03/07/2018 07:34 AM, Corey Minyard wrote: On 03/06/2018 11:49 PM, Jiandi An wrote: IPMI SSIF driver's parameter tryacpi and trydmi both are set to true

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-08 Thread Corey Minyard
On 03/08/2018 11:41 AM, Sebastian Andrzej Siewior wrote: On 2018-03-07 09:45:29 [-0600], Corey Minyard wrote: I have no idea what is the wisest thing to do here. The obvious fix would be to use the irqsafe() variant here and not drop the lock between wake ups. That is essentially what

Re: [PATCH] ipmi:ssif: Fix double probe from tryacpi and trydmi

2018-03-08 Thread Corey Minyard
On 03/07/2018 05:59 PM, Jiandi An wrote: On 03/07/2018 07:34 AM, Corey Minyard wrote: On 03/06/2018 11:49 PM, Jiandi An wrote: IPMI SSIF driver's parameter tryacpi and trydmi both are set to true.  The addition of IPMI DMI driver to create platform device for each IPMI device causes SSIF

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-07 Thread Corey Minyard
On 03/06/2018 11:46 AM, Sebastian Andrzej Siewior wrote: On 2018-03-05 09:08:11 [-0600], Corey Minyard wrote: Starting with the change 8a64547a07980f9d25e962a78c2e10ee82bdb742 fs/dcache: use swait_queue instead of waitqueue … The following change is the obvious reason: --- a/kernel/sched

Re: [PATCH] ipmi:ssif: Fix double probe from tryacpi and trydmi

2018-03-07 Thread Corey Minyard
On 03/06/2018 11:49 PM, Jiandi An wrote: IPMI SSIF driver's parameter tryacpi and trydmi both are set to true. The addition of IPMI DMI driver to create platform device for each IPMI device causes SSIF probe to be done twice on the same SMB I2C address for BMC. Fix is to not call trydmi if

Re: Regression in IPMI on 4.15.6

2018-03-06 Thread Corey Minyard
On 03/06/2018 05:54 PM, Laura Abbott wrote: On 03/06/2018 09:19 AM, Corey Minyard wrote: On 03/06/2018 11:17 AM, Laura Abbott wrote: On 03/05/2018 11:39 AM, Corey Minyard wrote: On 03/05/2018 01:31 PM, Corey Minyard wrote: On 03/05/2018 01:07 PM, Laura Abbott wrote: On 03/02/2018 05:46 AM

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-06 Thread Corey Minyard
On 03/06/2018 11:46 AM, Sebastian Andrzej Siewior wrote: On 2018-03-05 09:08:11 [-0600], Corey Minyard wrote: Starting with the change 8a64547a07980f9d25e962a78c2e10ee82bdb742 fs/dcache: use swait_queue instead of waitqueue … The following change is the obvious reason: --- a/kernel/sched

Re: Regression in IPMI on 4.15.6

2018-03-06 Thread Corey Minyard
On 03/06/2018 11:17 AM, Laura Abbott wrote: On 03/05/2018 11:39 AM, Corey Minyard wrote: On 03/05/2018 01:31 PM, Corey Minyard wrote: On 03/05/2018 01:07 PM, Laura Abbott wrote: On 03/02/2018 05:46 AM, Corey Minyard wrote: On 02/28/2018 01:07 PM, Corey Minyard wrote: On 02/28/2018 08:17 AM

Re: Regression in IPMI on 4.15.6

2018-03-05 Thread Corey Minyard
On 03/05/2018 01:31 PM, Corey Minyard wrote: On 03/05/2018 01:07 PM, Laura Abbott wrote: On 03/02/2018 05:46 AM, Corey Minyard wrote: On 02/28/2018 01:07 PM, Corey Minyard wrote: On 02/28/2018 08:17 AM, Corey Minyard wrote: On 02/28/2018 07:53 AM, Corey Minyard wrote: On 02/27/2018 05:55 PM

Re: Regression in IPMI on 4.15.6

2018-03-05 Thread Corey Minyard
On 03/05/2018 01:07 PM, Laura Abbott wrote: On 03/02/2018 05:46 AM, Corey Minyard wrote: On 02/28/2018 01:07 PM, Corey Minyard wrote: On 02/28/2018 08:17 AM, Corey Minyard wrote: On 02/28/2018 07:53 AM, Corey Minyard wrote: On 02/27/2018 05:55 PM, Laura Abbott wrote: Hi, Fedora got a bug

Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-05 Thread Corey Minyard
Starting with the change 8a64547a07980f9d25e962a78c2e10ee82bdb742 fs/dcache: use swait_queue instead of waitqueue we are getting the following warning when running with PREEMPT__LL when inserting a USB drive.  This is on x86_64, 4.14.15-rt13.  It works fine with PREEMPT_RT. # [ 

Re: [PATCH] ipmi: use ARRAY_SIZE for poweroff_functions array sizing calculation

2018-03-02 Thread Corey Minyard
On 03/02/2018 08:14 AM, Colin King wrote: From: Colin Ian King Use the ARRAY_SIZE macro on a array poweroff_functions to determine size of the array. Improvement suggested by Coccinelle. Queued for next release.  Thanks! -corey Signed-off-by: Colin Ian King

Re: Regression in IPMI on 4.15.6

2018-03-02 Thread Corey Minyard
On 02/28/2018 01:07 PM, Corey Minyard wrote: On 02/28/2018 08:17 AM, Corey Minyard wrote: On 02/28/2018 07:53 AM, Corey Minyard wrote: On 02/27/2018 05:55 PM, Laura Abbott wrote: Hi, Fedora got a bug report of a crash in IPMI on 4.15.6 https://bugzilla.redhat.com/show_bug.cgi?id=1549316

Re: Regression in IPMI on 4.15.6

2018-02-28 Thread Corey Minyard
On 02/28/2018 08:17 AM, Corey Minyard wrote: On 02/28/2018 07:53 AM, Corey Minyard wrote: On 02/27/2018 05:55 PM, Laura Abbott wrote: Hi, Fedora got a bug report of a crash in IPMI on 4.15.6 https://bugzilla.redhat.com/show_bug.cgi?id=1549316 Unfortunately, it's only a screenshot but it's

Re: Regression in IPMI on 4.15.6

2018-02-28 Thread Corey Minyard
On 02/28/2018 07:53 AM, Corey Minyard wrote: On 02/27/2018 05:55 PM, Laura Abbott wrote: Hi, Fedora got a bug report of a crash in IPMI on 4.15.6 https://bugzilla.redhat.com/show_bug.cgi?id=1549316 Unfortunately, it's only a screenshot but it's fairly clear. It looks like a panic in the error

Re: Regression in IPMI on 4.15.6

2018-02-28 Thread Corey Minyard
On 02/27/2018 05:55 PM, Laura Abbott wrote: Hi, Fedora got a bug report of a crash in IPMI on 4.15.6 https://bugzilla.redhat.com/show_bug.cgi?id=1549316 Unfortunately, it's only a screenshot but it's fairly clear. It looks like a panic in the error handling path in platform_device_unregister.

Re: [PATCH] ipmi: Add or fix SPDX-License-Identifier in all files

2018-02-27 Thread Corey Minyard
On 02/26/2018 07:09 PM, Joel Stanley wrote: On Tue, Feb 27, 2018 at 1:54 AM, <miny...@acm.org> wrote: From: Corey Minyard <cminy...@mvista.com> And get rid of the license text that is no longer necessary. Signed-off-by: Corey Minyard <cminy...@mvista.com> Cc: Kees Cook <

Re: [PATCH ipmi/kcs_bmc v6] ipmi: kcs_bmc: coding-style fixes and use new poll type

2018-02-26 Thread Corey Minyard
On 02/26/2018 09:48 AM, Haiyue Wang wrote: Many for coding-style fixes, and update the poll API with the new type '__poll_t', this is new commit from linux-4.16-rc1. Signed-off-by: Haiyue Wang Sorry for the delay, I was on jury duty last week.  But it looks like

Re: [PATCH] char/ipmi: add documentation for sysfs interface

2018-02-26 Thread Corey Minyard
On 02/24/2018 03:06 AM, Aishwarya Pant wrote: This is an attempt to document the sysfs interface for the IPMI drivers. Descriptions were collected from v2.0 of the IPMI specification and from code comments. Signed-off-by: Aishwarya Pant Wow, you spent some time on this. 

Re: [PATCH] ipmi:pci: Blacklist a Realtek "IPMI" device

2018-02-26 Thread Corey Minyard
On 02/26/2018 08:34 AM, Andy Shevchenko wrote: On Mon, Feb 26, 2018 at 4:50 AM, wrote: Realtek has some sort of "Virtual" IPMI device on the PCI bus as a KCS controller, but whatever it is, it's not one. Ignore it if seen. +static struct pci_device_id ipmi_pci_blacklist[] =

Re: [PATCH ipmi/kcs_bmc v2] ipmi: kcs_bmc: make the code be more clean

2018-02-20 Thread Corey Minyard
On 02/19/2018 09:55 AM, Haiyue Wang wrote: --- When you use ---, it means everything following is not in the commit text, including your signature. v1 -> v2: Do you want me to fold this into the previous patch?  That's generally not how things work, a new patch is fine for this, with a list

Re: [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle_data

2018-02-14 Thread Corey Minyard
On 02/14/2018 11:30 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Thanks, queued for next release. -corey Addresses-Coverity-ID: 1465255 ("Missing break in switch") Signed-off-by: Gustavo A. R.

Re: ipmi_si fails to get BMC ID

2018-02-14 Thread Corey Minyard
I'm removing Greg and Arnd from the email, I don't think this requires their participation. On 02/13/2018 08:44 PM, Chris Chiu wrote: On Fri, Feb 9, 2018 at 9:34 PM, Corey Minyard <miny...@acm.org> wrote: On 02/08/2018 09:09 PM, Chris Chiu wrote: On Thu, Feb 8, 2018 at 11:53 PM,

Re: ipmi_si fails to get BMC ID

2018-02-09 Thread Corey Minyard
On 02/08/2018 09:09 PM, Chris Chiu wrote: On Thu, Feb 8, 2018 at 11:53 PM, Corey Minyard <miny...@acm.org> wrote: On 02/07/2018 09:01 PM, Chris Chiu wrote: Hi, We are working with a new desktop Acer Veriton Z4640G and get stumbled on failing to enter S3 suspend with kernel versio

Re: ipmi_si fails to get BMC ID

2018-02-08 Thread Corey Minyard
On 02/07/2018 09:01 PM, Chris Chiu wrote: Hi, We are working with a new desktop Acer Veriton Z4640G and get stumbled on failing to enter S3 suspend with kernel version 4.14 even the latest 4.15+. Here's the kernel log https://gist.github.com/mschiu77/76888f1fd4eb56aa8959d76759a912bb. This

Re: [PATCH arm/aspeed/ast2500 v5 1/2] ipmi: add a KCS IPMI BMC driver

2018-02-02 Thread Corey Minyard
On 02/01/2018 08:16 PM, Haiyue Wang wrote: --- v4->v5 - Fix -Wdiscarded-qualifiers 'const' compile warning. - Fix size_t printk compile error. v3->v4 - Change to accept WRITE_START any time. v2->v3 - Update the KCS phase state machine. - Fix the race condition of read/write. v1->v2 - Divide

Re: [PATCH arm/aspeed/ast2500 v4 1/2] ipmi: add a KCS IPMI BMC driver

2018-02-02 Thread Corey Minyard
On 02/01/2018 07:33 PM, Wang, Haiyue wrote: On 2018-02-02 09:10, Corey Minyard wrote: I loaded this in, tried a compile on x86_64, and got the following: In file included from ../drivers/char/ipmi/kcs_bmc.c:15:0: ../drivers/char/ipmi/kcs_bmc.h: In function ‘kcs_bmc_priv’: ../drivers/char

Re: [PATCH arm/aspeed/ast2500 v4 1/2] ipmi: add a KCS IPMI BMC driver

2018-02-01 Thread Corey Minyard
On 02/01/2018 06:28 PM, Haiyue Wang wrote: --- v3->v4 - Change to accept WRITE_START any time. v2->v3 - Update the KCS phase state machine. - Fix the race condition of read/write. v1->v2 - Divide the driver into two parts, one handles the BMC KCS IPMI 2.0 state; the other handles the BMC

Re: [PATCH arm/aspeed/ast2500 v3 1/2] ipmi: add a KCS IPMI BMC driver

2018-02-01 Thread Corey Minyard
On 02/01/2018 05:56 PM, Wang, Haiyue wrote: On 2018-02-02 04:32, Corey Minyard wrote: +static void kcs_bmc_handle_cmd(struct kcs_bmc *kcs_bmc) +{ +    u8 cmd; + +    set_state(kcs_bmc, WRITE_STATE); +    write_data(kcs_bmc, KCS_ZERO_DATA); + +    cmd = read_data(kcs_bmc); +    switch (cmd

Re: [PATCH arm/aspeed/ast2500 v3 1/2] ipmi: add a KCS IPMI BMC driver

2018-02-01 Thread Corey Minyard
On 02/01/2018 02:48 AM, Haiyue Wang wrote: --- v2->v3 - Update the KCS phase state machine. - Fix the race condition of read/write. v1->v2 - Divide the driver into two parts, one handles the BMC KCS IPMI 2.0 state; the other handles the BMC KCS controller such as AST2500 IO accessing. -

[GIT PULL] IPMI updates for 4.16

2018-01-31 Thread Corey Minyard
time). Andy Shevchenko (1):   ipmi_ssif: Remove duplicate NULL check Corey Minyard (1):   ipmi_si: Fix error handling of platform device Jeremy Kerr (1):   ipmi/ipmi_powernv: remove outdated todo in powernv IPMI driver

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-30 Thread Corey Minyard
On 01/30/2018 07:37 PM, Wang, Haiyue wrote: On 2018-01-31 09:25, Corey Minyard wrote: On 01/30/2018 07:02 PM, Wang, Haiyue wrote: On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-30 Thread Corey Minyard
On 01/30/2018 07:02 PM, Wang, Haiyue wrote: On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-30 Thread Corey Minyard
On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-30 Thread Corey Minyard
On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-26 Thread Corey Minyard
On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-24 Thread Corey Minyard
On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). This driver exposes the KCS interface on ASpeed SOCs (AST2400 and AST2500) as a character

Re: [PATCH v1] device property: Define type of PROPERTY_ENRTY_*() macros

2018-01-22 Thread Corey Minyard
/char/ipmi/ipmi_dmi.c:79:29: error: Expected ; at end of statement drivers/char/ipmi/ipmi_dmi.c:79:29: error: got { Cc: Corey Minyard <miny...@acm.org> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> This looks good to me. Acked-by: Corey Minyard <cminy...@mvista.c

Re: [PATCH] ipmi: use dynamic memory for DMI driver override

2018-01-22 Thread Corey Minyard
On 01/17/2018 11:06 AM, John Garry wrote: On 17/01/2018 16:49, Corey Minyard wrote: On 01/17/2018 10:36 AM, John Garry wrote: Currently a crash can be seen if we reach the "err" label in dmi_add_platform_ipmi(), calling platform_device_put(), like here: [    7.270584]  (null): ipmi:d

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-18 Thread Corey Minyard
On 01/17/2018 10:04 PM, Alexey Kardashevskiy wrote: On 17/01/18 22:25, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Reviewed-by: Alexey

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Corey Minyard
On 01/17/2018 06:16 PM, Wang, Haiyue wrote: On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller

Re: [PATCH] ipmi: use dynamic memory for DMI driver override

2018-01-17 Thread Corey Minyard
On 01/17/2018 10:36 AM, John Garry wrote: Currently a crash can be seen if we reach the "err" label in dmi_add_platform_ipmi(), calling platform_device_put(), like here: [7.270584] (null): ipmi:dmi: Unable to add resources: -16 [7.330229] [ cut here ] [

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Corey Minyard
On 01/17/2018 08:31 AM, Wang, Haiyue wrote: Snip... +/* mapped to lpc-host@80 IO space */ +#define LPC_HICRB    0x080 +#define LPC_HICRB_IBFIF4 BIT(1) +#define LPC_HICRB_LPC4E  BIT(0) +#define LPC_LADR4    0x090 +#define LPC_IDR4 0x094

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Corey Minyard
On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Corey Minyard
On 01/17/2018 05:25 AM, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. I think you are right here.  However, you had a bunch of people on the email that probably didn't need to be there, and

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-16 Thread Corey Minyard
On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). This driver exposes the KCS interface

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-16 Thread Corey Minyard
On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). This driver exposes the KCS interface on ASpeed SOCs (AST2400 and AST2500) as a character

Re: [PATCH] ipmi: Clear smi_info->thread to prevent use-after-free during module unload

2018-01-15 Thread Corey Minyard
On 01/15/2018 01:58 AM, Masamitsu Yamazaki wrote: Subject:[PATCH] ipmi: Clear smi_info->thread to prevent use-after-free during module unload To: Corey Minyard <miny...@acm.org> To: openipmi-develo...@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Cc: j-nom...@ce.jp.nec.co

Re: Backport of KPTI to 2.6.32 available

2018-01-11 Thread Corey Minyard
On 01/11/2018 02:32 PM, Greg KH wrote: On Thu, Jan 11, 2018 at 11:42:38AM -0600, Corey Minyard wrote: I've completed a backport of KPTI from linux-stable-3.2.y to 2.6.32.71, in case anyone is interested and wants to avoid all the work I went through. It's available at: https://github.com

Backport of KPTI to 2.6.32 available

2018-01-11 Thread Corey Minyard
I've completed a backport of KPTI from linux-stable-3.2.y to 2.6.32.71, in case anyone is interested and wants to avoid all the work I went through. It's available at: https://github.com/MontaVista-OpenSourceTechnology/linux-nonlts-secfix.git linux-2.6.32-secfix I'll try to keep it up to date

Re: [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

2017-12-20 Thread Corey Minyard
On 12/20/2017 06:59 PM, Wang, Haiyue wrote: On 2017-12-21 04:11, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are commonly used as BMCs

Re: [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

2017-12-20 Thread Corey Minyard
On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are commonly used as BMCs (BaseBoard Management Controllers) and this driver implements the BMC side of the KCS

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-19 Thread Corey Minyard
On 12/19/2017 12:15 PM, Joe Perches wrote: drivers/char/ipmi/ipmi_msghandler.c| 17 +++--- For ipmi: Acked-by: Corey Minyard <cminy...@mvista.com>

Re: [PATCH linux ipmi for BMC] ipmi: add an Aspeed KCS IPMI BMC driver

2017-12-15 Thread Corey Minyard
, __func__' to using 'kcs_outb', this function's name, in a string #299: FILE: drivers/char/ipmi/kcs-bmc.c:180: + WARN(rc != 0, "kcs_outb failed: %d\n", rc); total: 0 errors, 3 warnings, 836 lines checked -Original Message- From: Corey Minyard [mailto:tcminy...@gmail.com]

Re: [PATCH linux ipmi for BMC] ipmi: add an Aspeed KCS IPMI BMC driver

2017-12-14 Thread Corey Minyard
On 12/14/2017 08:03 PM, Haiyue Wang wrote: [based torvalds/linux.git] This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are commonly used as BMCs (BaseBoard Management Controllers) and this driver implements

Re: [ANNOUNCE] 4.1.46-rt52

2017-12-11 Thread Corey Minyard
On 12/11/2017 02:20 PM, Julia Cartwright wrote: On Mon, Dec 11, 2017 at 01:04:58PM -0600, Corey Minyard wrote: On 11/29/2017 05:13 PM, Julia Cartwright wrote: Hello RT Folks! I'm pleased to announce the 4.1.46-rt52 stable release. You can get this release via the git tree at: git

Re: [ANNOUNCE] 4.1.46-rt52

2017-12-11 Thread Corey Minyard
On 11/29/2017 05:13 PM, Julia Cartwright wrote: Hello RT Folks! I'm pleased to announce the 4.1.46-rt52 stable release. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: v4.1-rt Head SHA1:

[GIT PULL] IPMI bug fixes for 4.15 changes

2017-12-11 Thread Corey Minyard
since about their creation date.  I forgot the bugzilla reference on the second one (ipmi_si: Fix oops with PCI devices) so I rebased to add that. Corey Minyard (1):   ipmi_si: Fix oops with PCI devices Masamitsu Yamazaki (1

Re: ipmi null pointer oops in 4.15-rc2+ on HP DL360G6

2017-12-07 Thread Corey Minyard
On 12/07/2017 09:43 AM, Meelis Roos wrote: Tried current 4.15 git on HP DL360G6 (working fine in 4.14), got null pointer dereference oops from ipmi_pci_probe (or so it seems from the backtrace). I have a fix for this at https://bugzilla.kernel.org/show_bug.cgi?id=197999, but the reported hasn't

Re: [bugzilla-dae...@bugzilla.kernel.org: [Bug 197999] New: [ipmi pci] BUG: unable to handle kernel NULL pointer dereference at (null)]

2017-11-30 Thread Corey Minyard
On 11/27/2017 08:51 AM, Bjorn Helgaas wrote: FYI. This was reported against drivers/pci, but it doesn't look like a PCI core issue to me. Not a PCI issue, it was a change I did.  To whom shall I send the patch for testing? This change was in linux-next for many months, and I don't have

Re: linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282: bad if condition ?

2017-11-27 Thread Corey Minyard
On 11/27/2017 06:32 AM, David Binderman wrote: Hello there, linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282]: (style) Expression is always false because 'else if' condition matches previous condition at line 2279 Source code is if (new_smi->pdev) {

Re: [Openipmi-developer] [PATCH] ipmi: Stop timers before cleaning up the module

2017-11-17 Thread Corey Minyard
On 11/15/2017 01:33 AM, Masamitsu Yamazaki wrote: System may crash after unloading ipmi_si.ko module because a timer may remain and fire after the module cleaned up resources. This is a big improvement, thanks.  I'll work on getting this into 4.15. Thanks, -corey cleanup_one_si() contains

[GIT PULL] IPMI updates for 4.15

2017-11-15 Thread Corey Minyard
: pr_err() strings should end with newlines Bhumika Goyal (1):   IPMI: make ipmi_poweroff_handler const Colin Ian King (3):   char: ipmi: make function ipmi_get_info_from_resources static   ipmi: remove redundant initialization of bmc   ipmi_si: fix memory leak on new_smi Corey Minyard

Re: [PATCH] drivers/char/ipmi_si: prevent null deref during module exit

2017-11-09 Thread Corey Minyard
On 11/09/2017 12:38 PM, Corey Minyard wrote: On 11/09/2017 12:02 PM, Andrew Banman wrote: On 11/8/17 2:00 PM, Corey Minyard wrote: On 11/08/2017 11:11 AM, Andrew Banman wrote: On 11/8/17 11:06 AM, Andrew Banman wrote: If there are uninitialized SMIs in the smi_infos list, i.e

Re: [PATCH] drivers/char/ipmi_si: prevent null deref during module exit

2017-11-09 Thread Corey Minyard
On 11/09/2017 12:02 PM, Andrew Banman wrote: On 11/8/17 2:00 PM, Corey Minyard wrote: On 11/08/2017 11:11 AM, Andrew Banman wrote: On 11/8/17 11:06 AM, Andrew Banman wrote: If there are uninitialized SMIs in the smi_infos list, i.e. with no handlers set, then disable_si_irq

Re: [PATCH] drivers/char/ipmi_si: prevent null deref during module exit

2017-11-08 Thread Corey Minyard
On 11/08/2017 11:11 AM, Andrew Banman wrote: On 11/8/17 11:06 AM, Andrew Banman wrote: If there are uninitialized SMIs in the smi_infos list, i.e. with no handlers set, then disable_si_irq() in cleanup_smi_one() will hit a null pointer dereference when the former attempts to start the check

Re: [PATCH -next] ipmi_si_platform: Fix typo in parameter description

2017-11-03 Thread Corey Minyard
On 11/03/2017 04:52 AM, Wei Yongjun wrote: Fix typo in parameter description. Thanks, queued for next release. -corey Fixes: 95e300c052fd ("ipmi: Make the DMI probe into a generic platform probe") Signed-off-by: Wei Yongjun --- drivers/char/ipmi/ipmi_si_platform.c

Re: [PATCH -next] ipmi watchdog: fix typo in parameter description

2017-11-03 Thread Corey Minyard
On 11/03/2017 04:52 AM, Wei Yongjun wrote: Fix typo in parameter description. Thanks, queued for next release. -corey Signed-off-by: Wei Yongjun --- drivers/char/ipmi/ipmi_watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: linux-next: manual merge of the ipmi tree with the modules tree

2017-11-02 Thread Corey Minyard
On 11/02/2017 09:27 AM, Jessica Yu wrote: +++ Corey Minyard [02/11/17 08:31 -0500]: On 11/01/2017 10:58 PM, Stephen Rothwell wrote: Hi Corey, Today's linux-next merge of the ipmi tree got a conflict in:   drivers/char/ipmi/ipmi_si_intf.c between commit:   e4dca7b7aa08 ("treewide

Re: linux-next: manual merge of the ipmi tree with the modules tree

2017-11-02 Thread Corey Minyard
On 11/01/2017 10:58 PM, Stephen Rothwell wrote: Hi Corey, Today's linux-next merge of the ipmi tree got a conflict in: drivers/char/ipmi/ipmi_si_intf.c between commit: e4dca7b7aa08 ("treewide: Fix function prototypes for module_param_call()") from the modules tree and commit:

Re: [PATCH v10 1/9] LIB: Introduce a generic PIO mapping method

2017-10-27 Thread Corey Minyard
On 10/27/2017 11:11 AM, Gabriele Paoloni wrote: From: "zhichang.yuan" In commit 41f8bba7f555 ("of/pci: Add pci_register_io_range() and pci_pio_to_address()"), a new I/O space management was supported. With that driver, the I/O ranges configured for PCI/PCIE hosts on

Re: [PATCH][ipmi-next] ipmi_si: fix memory leak on new_smi

2017-10-17 Thread Corey Minyard
On 10/17/2017 10:54 AM, Colin King wrote: From: Colin Ian King The error exit path omits kfree'ing the allocated new_smi, causing a memory leak. Fix this by kfree'ing new_smi. Thanks, queued for the next release. -corey Detected by CoverityScan, CID#14582571

Re: [PATCH] ipmi_si: Delete an error message for a failed memory allocation in try_smi_init()

2017-10-17 Thread Corey Minyard
On 10/15/2017 03:36 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sun, 15 Oct 2017 22:30:11 +0200 Omit an extra message for a memory allocation failure in this function. Thanks, queued for the next release. -corey This issue was detected by using

Re: [PATCH] MIPS: Fix exception entry when CONFIG_EVA enabled

2017-10-11 Thread Corey Minyard
> Reported-by: Vladimir Kondratiev <vladimir.kondrat...@intel.com> I looked this over pretty carefully and it looks correct to me.  It makes no difference in the instructions generated by the non-EVA case.  I shouldn't have missed this :(. Reviewed-by: Corey Minyard <cminy...@mvista

Re: linux-next: build failure after merge of the ipmi tree

2017-09-28 Thread Corey Minyard
On 09/27/2017 11:45 PM, Stephen Rothwell wrote: Hi Corey, After merging the ipmi tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: data definition has no type or storage class MODULE_DEVICE_TABLE(of, of_ipmi_match);

Re: [PATCH][ipmi-next] ipmi: remove redundant initialization of bmc

2017-09-28 Thread Corey Minyard
On 09/28/2017 08:22 AM, Colin King wrote: From: Colin Ian King The pointer bmc is being initialized and this initialized value is never being read, so this is assignment redundant and can be removed. Cleans up clang warning: warning: Value stored to 'bmc' during its

Re: [PATCH] ipmi: pr_err() strings should end with newlines

2017-09-27 Thread Corey Minyard
On 09/25/2017 02:49 AM, Arvind Yadav wrote: pr_err() messages should terminated with a new-line to avoid other messages being concatenated onto the end. Thanks, it's queued for the next release. -corey Signed-off-by: Arvind Yadav ---

Re: [GIT PULL] Pull request for 4.14 for IPMI

2017-09-25 Thread Corey Minyard
I haven't seen this show up.  Is it too late? Thanks, -corey On 09/17/2017 09:02 PM, Corey Minyard wrote: I wanted to let this sit in linux-next for as long as possible, since some of the changes came in later than I would have liked.  And I was hoping you would wait until Monday to do 4.14

[GIT PULL] Pull request for 4.14 for IPMI

2017-09-17 Thread Corey Minyard
_resources static Corey Minyard (12): ipmi: fix unsigned long underflow ipmi: Make IPMI panic strings always available ipmi: Fix getting the GUID data ipmi: Move bmc find routing to below bmc device type ipmi: Check that the device type is BMC when scanning device

Anyone using /proc/ipmi?

2017-09-14 Thread Corey Minyard
Is anyone using /proc/ipmi for pulling IPMI information? That really needs to move to sysfs, and I'm going to start that process soon. I'll be adding sysfs attributes now then removing from /proc later to stage this, but this is your warning. -corey

Re: [PATCH] IPMI: make ipmi_poweroff_handler const

2017-08-28 Thread Corey Minyard
On 08/28/2017 01:08 PM, Bhumika Goyal wrote: Make this const as it is only passed to a const argument of the function ipmi_create_user. Queued for the next kernel release. -corey Signed-off-by: Bhumika Goyal --- drivers/char/ipmi/ipmi_poweroff.c | 2 +- 1 file

Re: [RFC v1 1/4] ipmi_bmc: framework for BT IPMI on BMCs

2017-08-10 Thread Corey Minyard
On 08/07/2017 10:52 PM, Brendan Higgins wrote: From: Benjamin Fair This patch introduces a framework for writing IPMI drivers which run on a Board Management Controller. It is similar in function to OpenIPMI. The framework handles registering devices and routing

  1   2   3   4   5   6   >