Re: [PATCH 1/3] zpool: extend API to match zsmalloc

2019-10-18 Thread Dan Streetman
retrieves the number of pages migrated due to compaction for > the whole time of this pool's existence and the third one returns > the huge class size. > > This API extension is done to align zpool API with zsmalloc API. > > Signed-off-by: Vitaly Wool Seems reasonable to me.

Re: [PATCH] zswap: allow setting default status, compressor and allocator in Kconfig

2019-10-18 Thread Dan Streetman
On Fri, Oct 11, 2019 at 7:40 PM Maciej S. Szmigiero wrote: > > The compressed cache for swap pages (zswap) currently needs from 1 to 3 > extra kernel command line parameters in order to make it work: it has to be > enabled by adding a "zswap.enabled=1" command line parameter and if one > wants a d

Re: [RFC v4] zswap: Add CONFIG_ZSWAP_IO_SWITCH to handle swap IO issue

2019-10-10 Thread Dan Streetman
On Tue, Oct 8, 2019 at 4:07 AM Hui Zhu wrote: > > This is the fourth version of this patch. The perious versions > are in [1], [2] and [3]. > > The parameters read_in_flight_limit and write_in_flight_limit were > replaced by io_switch_enabled_enabled in this verion to make this > function more cl

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

2019-10-03 Thread Dan Streetman
On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Dan Streetman wrote: > > The dummy vio_bus_device creates the /sys/devices/vio directory, which > > contains real vio devices under it; since it represents itself a

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

2019-09-28 Thread Dan Streetman
On Sat, Sep 28, 2019 at 3:41 AM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 03:48:49PM -0400, Dan Streetman wrote: > > On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Da

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

2019-09-27 Thread Dan Streetman
On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Dan Streetman wrote: > > The dummy vio_bus_device creates the /sys/devices/vio directory, which > > contains real vio devices under it; since it represents itself a

[PATCH] powerpc/vio: use simple dummy struct device as bus parent

2019-09-27 Thread Dan Streetman
do nothing and return 0. Signed-off-by: Dan Streetman --- arch/powerpc/platforms/pseries/vio.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms/pseries/vio.c index 79e2287991db..63bc16631680 100644 ---

Re: [RFC v3] zswap: Add CONFIG_ZSWAP_IO_SWITCH to handle swap IO issue

2019-09-26 Thread Dan Streetman
On Mon, Sep 23, 2019 at 4:14 PM Dan Streetman wrote: > > On Sun, Sep 22, 2019 at 11:32 PM Hui Zhu wrote: > > > > This is the third version of this patch. The first and second version > > is in [1] and [2]. > > This verion is updated according to the commen

Re: [RFC v3] zswap: Add CONFIG_ZSWAP_IO_SWITCH to handle swap IO issue

2019-09-23 Thread Dan Streetman
On Sun, Sep 22, 2019 at 11:32 PM Hui Zhu wrote: > > This is the third version of this patch. The first and second version > is in [1] and [2]. > This verion is updated according to the comments from Randy Dunlap > in [3]. > > Currently, I use a VM that has 2 CPUs, 4G memory and 4G swap file. > I

Re: [PATCH/RFC] zswap: do not map same object twice

2019-09-18 Thread Dan Streetman
it slows things down for z3fold. > > Since there's hardly a point in unmapping a handle _that_ fast as > zswap_writeback_entry() does when it reads swpentry, the > suggestion is to keep the handle mapped till the end. LGTM > > Signed-off-by: Vitaly Wool Reviewed-by: D

Re: [PATCH] zswap: Add CONFIG_ZSWAP_IO_SWITCH

2019-09-13 Thread Dan Streetman
43916 usecs = 503280 KB/s > 79386 usecs to free memory > 2415919104 bytes / 20136015 usecs = 117167 KB/s > 4411 usecs to free memory > 1207959552 bytes / 1833403 usecs = 643419 KB/s > 70452 usecs to free memory > ... > killall usemem > ./usemem -a -n 1 $((7 * 1024 *

Re: Follow up on hid2hci: Fix udev rules for linux-4.14+

2019-08-28 Thread Dan Streetman
On Wed, Aug 28, 2019 at 1:59 PM Ville Syrjälä wrote: > > On Wed, Aug 28, 2019 at 08:50:51PM +0300, Ville Syrjälä wrote: > > On Wed, Aug 28, 2019 at 01:34:07PM -0400, Dan Streetman wrote: > > > It looks like this patch got lost at some point: > > > https://lore.ker

Follow up on hid2hci: Fix udev rules for linux-4.14+

2019-08-28 Thread Dan Streetman
It looks like this patch got lost at some point: https://lore.kernel.org/patchwork/patch/902126/#1138115 but it seems to still be a problem and I'd like to pull it into Ubuntu: https://bugs.launchpad.net/ubuntu/+source/bluez/+bug/1759836 Ville, did you ever follow up with a v2 for that patch and/

Re: [PATCH] zswap: ignore debugfs_create_dir() return value

2019-01-31 Thread Dan Streetman
On Tue, Jan 29, 2019 at 3:33 PM Greg Kroah-Hartman wrote: > > On Tue, Jan 29, 2019 at 02:46:30PM -0500, Dan Streetman wrote: > > On Tue, Jan 22, 2019 at 10:23 AM Greg Kroah-Hartman > > wrote: > > > > > > When calling debugfs functions, there is no need to eve

Re: [PATCH] zswap: ignore debugfs_create_dir() return value

2019-01-29 Thread Dan Streetman
On Tue, Jan 22, 2019 at 10:23 AM Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Seth Jennings > Cc

Re: [PATCH v2] mm: fix z3fold warnings on CONFIG_SMP=n

2018-09-28 Thread Dan Streetman
On Thu, Sep 27, 2018 at 5:15 PM Alex Xu (Hello71) wrote: > > Spinlocks are always lockable on UP systems, even if they were just > locked. > > Cc: Dan Streetman I cc'ed Vitaly also, as this code is from him, but the change certainly looks correct to me. Acked-by: Dan Stre

Re: [PATCH] mm: fix z3fold warnings on CONFIG_SMP=n

2018-09-27 Thread Dan Streetman
On Thu, Sep 27, 2018 at 4:27 PM Alex Xu (Hello71) wrote: > > Spinlocks are always lockable on UP systems, even if they were just > locked. i think it would be much better to just use either assert_spin_locked() or just spin_is_locked(), instead of an #ifdef. > > Cc: Dan Streetma

Re: [PATCH v2] zswap: re-check zswap_is_full after do zswap_shrink

2018-07-25 Thread Dan Streetman
On Mon, Jun 25, 2018 at 4:08 AM Li Wang wrote: > > On 30 May 2018 at 20:53, Dan Streetman wrote: > > On Wed, May 30, 2018 at 6:39 AM, Li Wang wrote: > >> The '/sys/../zswap/stored_pages:' keep raising in zswap test with > >> "zswap.max_pool_perce

Re: [PATCH v2] zswap: re-check zswap_is_full after do zswap_shrink

2018-05-30 Thread Dan Streetman
w under the max_pool_percent, and > not to compress/store if reach its limitaion. > > Signed-off-by: Li Wang Acked-by: Dan Streetman > Cc: Seth Jennings > Cc: Dan Streetman > Cc: Huang Ying > Cc: Yu Zhao > --- > mm/zswap.c | 9 + > 1 file changed, 9 in

Re: [PATCH RFC] zswap: reject to compress/store page if zswap_max_pool_percent is 0

2018-05-30 Thread Dan Streetman
On Tue, May 29, 2018 at 10:57 PM, Li Wang wrote: > Hi Dan, > > On Wed, May 30, 2018 at 5:14 AM, Dan Streetman wrote: >> >> On Thu, May 24, 2018 at 5:57 AM, Li Wang wrote: >> > The '/sys/../zswap/stored_pages:' keep raising in zswap test with >&g

Re: [PATCH RFC] zswap: reject to compress/store page if zswap_max_pool_percent is 0

2018-05-29 Thread Dan Streetman
nother page, without re-checking zswap_is_full(). If you're trying to fix that, then I would ack a patch that adds a second zswap_is_full() check after zswap_shrink() to make sure it's now under the max_pool_percent (or somehow otherwise fixes that behavior). > > Signed-off-by: Li

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-05-11 Thread Dan Streetman
On Fri, May 11, 2018 at 5:19 AM, Dmitry Vyukov wrote: > On Thu, May 10, 2018 at 12:23 PM, Dan Streetman wrote: >>>>>>>> wrote: >>>>>>>>> On 20.02.2018 18:26, Neil Horman wrote: >>>>>>>>>> >>>>>

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-05-10 Thread Dan Streetman
On Thu, May 10, 2018 at 2:46 AM, Dmitry Vyukov wrote: > On Mon, Apr 16, 2018 at 9:42 PM, Dan Streetman wrote: >>>>>> On Wed, Feb 21, 2018 at 3:53 PM, Tommi Rantala >>>>>> wrote: >>>>>>> On 20.02.2018 18:26, Neil Horman wrote: >&g

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-04-16 Thread Dan Streetman
On Mon, Apr 16, 2018 at 3:35 AM, Dmitry Vyukov wrote: > On Fri, Apr 13, 2018 at 5:54 PM, Dmitry Vyukov wrote: >> On Fri, Apr 13, 2018 at 2:43 PM, Dan Streetman wrote: >>> On Thu, Apr 12, 2018 at 8:15 AM, Dmitry Vyukov wrote: >>>> On Wed, Feb 21, 2018 at 3:53

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-04-13 Thread Dan Streetman
On Thu, Apr 12, 2018 at 8:15 AM, Dmitry Vyukov wrote: > On Wed, Feb 21, 2018 at 3:53 PM, Tommi Rantala > wrote: >> On 20.02.2018 18:26, Neil Horman wrote: >>> >>> On Tue, Feb 20, 2018 at 09:14:41AM +0100, Dmitry Vyukov wrote: On Tue, Feb 20, 2018 at 8:56 AM, Tommi Rantala wrote: >

Re: [PATCH] crypto: nx-842: Delete an error message for a failed memory allocation in nx842_pseries_init()

2018-02-14 Thread Dan Streetman
d-off-by: Markus Elfring Reviewed-by: Dan Streetman > --- > drivers/crypto/nx/nx-842-pseries.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/nx/nx-842-pseries.c > b/drivers/crypto/nx/nx-842-pseries.c > index bf52cd1d7fca..6686997

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-12 Thread Dan Streetman
age is saved. After swapping > > > in, tail pages will not be restored to its original contents, so cause > > > the memory corruption in the applications. > > > > > > This is fixed via splitting THP before writing the page to swap device > > > if

[PATCH] net: tcp: close sock if net namespace is exiting

2018-01-18 Thread Dan Streetman
i?id=97811 Signed-off-by: Dan Streetman --- include/net/net_namespace.h | 10 ++ net/ipv4/tcp.c | 3 +++ net/ipv4/tcp_timer.c| 15 +++ 3 files changed, 28 insertions(+) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index f8

Re: [PATCH v3] zswap: only save zswap header when necessary

2018-01-11 Thread Dan Streetman
> + zpool->evictable = driver->shrink && ops && ops->evict; Since the ops->evict comes from zswap (and is never omitted), if we do restore zs_zpool_shrink() in the future to call the zsmalloc shrinker (and not do eviction), we'll have to add a driv

Re: [PATCH] zswap: only save zswap header if zpool is shrinkable

2018-01-10 Thread Dan Streetman
On Tue, Jan 9, 2018 at 5:47 PM, Yu Zhao wrote: > On Tue, Jan 09, 2018 at 01:25:18PM -0500, Dan Streetman wrote: >> On Mon, Jan 8, 2018 at 5:51 PM, Yu Zhao wrote: >> > We waste sizeof(swp_entry_t) for zswap header when using zsmalloc >> > as zpool driver because zsmall

Re: [PATCH] zswap: only save zswap header if zpool is shrinkable

2018-01-09 Thread Dan Streetman
include the header info that zswap_writeback_entry (i.e. ops->evict) later needs, so yeah it does make more sense to call it zpool_evictable() and zpool->evictable. However, I think the function should still be zpool_shrink() and zpool->driver->shrink(), because it should be possible for

Re: [PATCH 2/2] mm/zswap: move `zswap_has_pool` to front of `if ()`

2018-01-08 Thread Dan Streetman
On Tue, Jan 2, 2018 at 5:03 AM, Joey Pabalinas wrote: > `zwap_has_pool` is a simple boolean, so it should be tested first > to avoid unnecessarily calling `strcmp()`. Test `zswap_has_pool` > first to take advantage of the short-circuiting behavior of && in > `__zswap_param_set()`. > > Signed-off-b

Re: [PATCH 1/2] mm/zswap: make type and compressor const

2018-01-08 Thread Dan Streetman
On Tue, Jan 2, 2018 at 5:03 AM, Joey Pabalinas wrote: > The characters pointed to by `zswap_compressor`, `type`, and `compressor` > aren't ever modified. Add const to the static variable and both parameters in > `zswap_pool_find_get()`, `zswap_pool_create()`, and `__zswap_param_set()` > > Signed-o

Re: [PATCH v2] zswap: Update with same-value filled page feature

2017-12-06 Thread Dan Streetman
_enabled parameter. > > Updated zswap document with details on same-value filled > pages identification feature. > The usage of zswap.same_filled_pages_enabled module parameter > is explained. > > Signed-off-by: Srividya Desireddy Acked-by: Dan Streetman > --- > Documentation/

Re: [PATCH] zswap: Update with same-value filled page feature

2017-11-29 Thread Dan Streetman
On Wed, Nov 29, 2017 at 10:34 AM, Srividya Desireddy wrote: > From: Srividya Desireddy > Date: Wed, 29 Nov 2017 20:23:15 +0530 > Subject: [PATCH] zswap: Update with same-value filled page feature > > Updated zswap document with details on same-value filled > pages identification feature. > The us

Re: [PATCH] zswap: Same-filled pages handling

2017-11-28 Thread Dan Streetman
On Mon, Nov 20, 2017 at 6:46 PM, Andrew Morton wrote: > > On Wed, 18 Oct 2017 10:48:32 + Srividya Desireddy > wrote: > > > +/* Enable/disable handling same-value filled pages (enabled by default) */ > > +static bool zswap_same_filled_pages_enabled = true; > > +module_param_named(same_filled_

Re: [PATCH] zswap: Same-filled pages handling

2017-11-17 Thread Dan Streetman
which is optimised for this specific job. > > I have tested this patch using memset_l() function in zswap_fill_page() on > x86 64-bit system with 2GB RAM. The performance remains same. > But, memset_l() funcion might be optimised in future. > @Seth Jennings/Dan Streetman: Should I u

Re: [PATCH] zswap: Same-filled pages handling

2017-11-17 Thread Dan Streetman
On Wed, Oct 18, 2017 at 5:31 PM, Timofey Titovets wrote: >> +static int zswap_is_page_same_filled(void *ptr, unsigned long *value) >> +{ >> + unsigned int pos; >> + unsigned long *page; >> + >> + page = (unsigned long *)ptr; >> + for (pos = 1; pos < PAGE_SIZE / sizeof(*page

Re: [PATCH] zswap: Same-filled pages handling

2017-11-17 Thread Dan Streetman
e, but it's not huge. Considering that most systems will probably be swapping pages that aren't similar to the worst case (although I don't have any data to know that), I'd say the improvement is worth the possible worst-case performance impact. > > Signed-off-by: Srividya Desire

Re: [PATCH] mm/zswap: constify struct kernel_param_ops uses

2017-08-28 Thread Dan Streetman
On Sat, Aug 26, 2017 at 1:41 PM, Arvind Yadav wrote: > kernel_param_ops are not supposed to change at runtime. All functions > working with kernel_param_ops provided by work > with const kernel_param_ops. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav R

Re: [PATCH 2/2] zpool: Use common error handling code in zpool_create_pool()

2017-08-16 Thread Dan Streetman
On Mon, Aug 14, 2017 at 7:16 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 14 Aug 2017 13:04:33 +0200 > > Add a jump target so that a bit of exception handling can be better reused > in this function. > > Signed-off-by: Markus Elfring Acked-by: Dan St

Re: [PATCH 1/2] zpool: Delete an error message for a failed memory allocation in zpool_create_pool()

2017-08-16 Thread Dan Streetman
d-off-by: Markus Elfring Acked-by: Dan Streetman > --- > mm/zpool.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zpool.c b/mm/zpool.c > index fd3ff719c32c..fe1943f7d844 100644 > --- a/mm/zpool.c > +++ b/mm/zpool.c > @@ -172,7 +172,6 @@ struct zpool *zpoo

Re: [PATCH v2] zswap: Zero-filled pages handling

2017-07-06 Thread Dan Streetman
On Thu, Jul 6, 2017 at 5:29 AM, Srividya Desireddy wrote: > On Wed, Jul 6, 2017 at 10:49 AM, Sergey Senozhatsky wrote: >> On (07/02/17 20:28), Seth Jennings wrote: >>> On Sun, Jul 2, 2017 at 9:19 AM, Srividya Desireddy >>> > Zswap is a cache which compresses the pages that are being swapped out >>

Re: [PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare()

2017-05-30 Thread Dan Streetman
> > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring Acked-by: Dan Streetman > --- > mm/zswap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswa

Re: [PATCH 2/3] zswap: Improve a size determination in zswap_frontswap_init()

2017-05-30 Thread Dan Streetman
ize > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring Acked-by: Dan Streetman > --- > mm/zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 18d8e871

Re: [PATCH 1/3] zswap: Delete an error message for a failed memory allocation in zswap_pool_create()

2017-05-30 Thread Dan Streetman
> > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring Acked-by: Dan Streetman > --- > mm/zswap.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c >

Re: [PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression

2017-04-01 Thread Dan Streetman
On Sat, Apr 1, 2017 at 1:25 PM, Haren Myneni wrote: > [PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression > > Signed-off-by: Haren Myneni Acked-by: Dan Streetman > > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-27 Thread Dan Streetman
On Fri, Mar 24, 2017 at 9:33 PM, Boris Ostrovsky wrote: > >> >> I think we can all agree that the *ideal* situation would be, for the >> balloon driver to not immediately hotplug memory so it can add 11 more >> pages, so maybe I just need to figure out why the balloon driver >> thinks it needs 11

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-24 Thread Dan Streetman
On Fri, Mar 24, 2017 at 5:10 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 24, 2017 at 04:34:23PM -0400, Dan Streetman wrote: >> On Wed, Mar 22, 2017 at 10:13 PM, Boris Ostrovsky >> wrote: >> > >> > >> > On 03/22/2017 05:16 PM, Dan Streetman wrote: >

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-24 Thread Dan Streetman
On Wed, Mar 22, 2017 at 10:13 PM, Boris Ostrovsky wrote: > > > On 03/22/2017 05:16 PM, Dan Streetman wrote: >> >> I have a question about a problem introduced by this commit: >> c275a57f5ec3056f732843b11659d892235faff7 >> "xen/balloon: Set balloon's in

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-24 Thread Dan Streetman
On Thu, Mar 23, 2017 at 3:56 AM, Juergen Gross wrote: > On 23/03/17 03:13, Boris Ostrovsky wrote: >> >> >> On 03/22/2017 05:16 PM, Dan Streetman wrote: >>> I have a question about a problem introduced by this commit: >>> c275a57f5ec3056f732843b11659d8922

maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-22 Thread Dan Streetman
I have a question about a problem introduced by this commit: c275a57f5ec3056f732843b11659d892235faff7 "xen/balloon: Set balloon's initial state to number of existing RAM pages" It changed the xen balloon current_pages calculation to start with the number of physical pages in the system, instead of

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

2017-03-16 Thread Dan Streetman
On Thu, Mar 16, 2017 at 12:33 PM, Herbert Xu wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> >> setting the ASYNC bit makes it synchronous? that seems backwards...? > > You set the ASYNC bit in the mask and leave it clear in the type. >

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

2017-03-16 Thread Dan Streetman
On Thu, Mar 9, 2017 at 4:39 AM, Herbert Xu wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> It looks like the crypto_scomp interface is buried under >> include/crypto/internal/scompress.h, however that's exactly what zswap >> should be

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

2017-03-08 Thread Dan Streetman
On Mon, Feb 27, 2017 at 9:40 AM, Mahipal Reddy wrote: > Hi Dan, > Thanks for your reply. > > On Sat, Feb 25, 2017 at 3:51 AM, Dan Streetman wrote: >> On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa >> wrote: >>> This adds support for kernel's new cry

Re: [PATCH] zswap: Zero-filled pages handling

2017-03-08 Thread Dan Streetman
On Wed, Mar 8, 2017 at 6:47 AM, Srividya Desireddy wrote: > > On Sat, Mar 4, 2017 at 02:55 AM, Dan Streetman wrote: >> On Sat, Feb 25, 2017 at 12:18 PM, Sarbojit Ganguly >> wrote: >>> On 25 February 2017 at 20:12, Srividya Desireddy >>> wrote: >>>&

Re: [PATCH] zswap: Zero-filled pages handling

2017-03-03 Thread Dan Streetman
On Sat, Feb 25, 2017 at 12:18 PM, Sarbojit Ganguly wrote: > On 25 February 2017 at 20:12, Srividya Desireddy > wrote: >> From: Srividya Desireddy >> Date: Thu, 23 Feb 2017 15:04:06 +0530 >> Subject: [PATCH] zswap: Zero-filled pages handling your email is base64-encoded; please send plain text e

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

2017-02-24 Thread Dan Streetman
On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa wrote: > This adds support for kernel's new crypto acomp/scomp framework > to zswap. I don't understand the point of this, zswap can't compress pages asynchronously, so what benefit do we get from using the async crypto api and then immediately wai

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-02-21 Thread Dan Streetman
On Fri, Jan 13, 2017 at 5:30 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 13, 2017 at 03:07:51PM -0500, Dan Streetman wrote: >> Revert the main part of commit: >> af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests") >> >> That commit in

Re: [PATCH 3/4] zswap: Zero-filled pages handling

2017-02-17 Thread Dan Streetman
On Wed, Aug 17, 2016 at 6:18 AM, Srividya Desireddy wrote: > From: Srividya Desireddy > Date: Wed, 17 Aug 2016 14:34:14 +0530 > Subject: [PATCH 3/4] zswap: Zero-filled pages handling > > This patch adds a check in zswap_frontswap_store() to identify zero-filled > page before compression of the pa

Re: [PATCH 1/4] zswap: Share zpool memory of duplicate pages

2017-02-17 Thread Dan Streetman
On Wed, Aug 17, 2016 at 6:07 AM, Srividya Desireddy wrote: > From: Srividya Desireddy > Date: Wed, 17 Aug 2016 14:31:01 +0530 > Subject: [PATCH 1/4] zswap: Share zpool memory of duplicate pages > > This patch shares the compressed pool memory of duplicate pages and reduces > compressed pool memor

Re: [PATCH/RESEND v3 5/5] z3fold: add kref refcounting

2017-02-01 Thread Dan Streetman
of headless pages. > > Signed-off-by: Vitaly Wool Reviewed-by: Dan Streetman > --- > mm/z3fold.c | 151 > ++-- > 1 file changed, 66 insertions(+), 85 deletions(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > i

Re: [PATCH/RESEND v3 4/5] z3fold: use per-page spinlock

2017-02-01 Thread Dan Streetman
age spinlock (or rwlock) has been around for some time. > > This patch implements spinlock-based per-page locking mechanism which > is lightweight enough to normally fit ok into the z3fold header. > > Signed-off-by: Vitaly Wool Reviewed-by: Dan Streetman

Re: [PATCH/RESEND v3 3/5] z3fold: extend compaction function

2017-02-01 Thread Dan Streetman
there, if the gap between them is big > enough. > > This patch adds the relevant code, using BIG_CHUNK_GAP define as > a threshold for middle chunk to be worth moving. > > Signed-off-by: Vitaly Wool Reviewed-by: Dan Streetman > --- > mm/z3fold.c | 26 ++

Re: [PATCH/RESEND v3 2/5] z3fold: fix header size related issues

2017-02-01 Thread Dan Streetman
f the z3fold header in chunks. > > Fixed also are the calculation of num_free_chunks() and the address to > move the middle chunk to in case of in-page compaction in > z3fold_compact_page(). > > Signed-off-by: Vitaly Wool Reviewed-by: Dan Streetma

Re: [PATCH/RESEND v3 1/5] z3fold: make pages_nr atomic

2017-02-01 Thread Dan Streetman
On Tue, Jan 31, 2017 at 3:39 PM, Vitaly Wool wrote: > This patch converts pages_nr per-pool counter to atomic64_t. > > Signed-off-by: Vitaly Wool Reviewed-by: Dan Streetman > --- > mm/z3fold.c | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) &

[PATCH] zswap: don't param_set_charp while holding spinlock

2017-01-26 Thread Dan Streetman
9b42c3529e ("zswap: use charp for zswap param strings") Reported-by: Sergey Senozhatsky Signed-off-by: Dan Streetman --- Andrew, I'll leave it up to you if you want to send this to -stable; personally I don't think it's needed. For the stable kernels, only the first hunk of t

Re: [PATCH 2/3] zswap: allow initialization at boot without pool

2017-01-25 Thread Dan Streetman
On Tue, Jan 24, 2017 at 7:24 PM, Sergey Senozhatsky wrote: > > just a note, > > On (01/24/17 15:02), Dan Streetman wrote: > [..] >> @@ -692,6 +702,15 @@ static int __zswap_param_set(const char *val, const >> struct kernel_param *kp, >>*/ >>

[PATCH] MAINTAINERS: add Dan Streetman to zbud maintainers

2017-01-24 Thread Dan Streetman
Add myself as zbud maintainer. Cc: Seth Jennings Signed-off-by: Dan Streetman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e5575d5..0bd4b33 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13681,6 +13681,7 @@ F: drivers/net/hamradio

Re: [PATCH 1/3] zswap: disable changing params if init fails

2017-01-24 Thread Dan Streetman
On Tue, Jan 24, 2017 at 4:24 PM, Andrew Morton wrote: > On Tue, 24 Jan 2017 15:02:57 -0500 Dan Streetman wrote: > >> Add zswap_init_failed bool that prevents changing any of the module >> params, if init_zswap() fails, and set zswap_enabled to false. Change >> 'enab

[PATCHv2] MAINTAINERS: add Dan Streetman to zswap maintainers

2017-01-24 Thread Dan Streetman
Add myself as zswap maintainer. Cc: Seth Jennings Signed-off-by: Dan Streetman --- You'd think I could get this simple patch right. oops! Since v1: fixed Seth's email in Cc: line Seth, I'd meant to send this last year, I assume you're still ok adding me. Did yo

[PATCH] MAINTAINERS: add Dan Streetman to zswap maintainers

2017-01-24 Thread Dan Streetman
Add myself as zswap maintainer. Cc: Seth Jennings Signed-off-by: Dan Streetman --- Seth, I'd meant to send this last year, I assume you're still ok adding me. Did you want to stay on as maintainer also? MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/M

[PATCH 0/3] Fix zswap init failure behavior

2017-01-24 Thread Dan Streetman
will result in a WARNING because zswap didn't expect them to be changed if initialization failed. These patches fix that assumption, as well as allowing pool creation after a failed initialization, if only the zpool and/or compressor creation failed. Dan Streetman (3): zswap: disable changing

[PATCH 1/3] zswap: disable changing params if init fails

2017-01-24 Thread Dan Streetman
this WARNING: [ 429.723476] WARNING: CPU: 0 PID: 5140 at mm/zswap.c:503 __zswap_pool_current+0x56/0x60 Fixes: 90b0fc26d5db ("zswap: change zpool/compressor at runtime") Cc: sta...@vger.kernel.org Signed-off-by: Dan Streetman --- mm/zswap.c | 30 +- 1 file

[PATCH 2/3] zswap: allow initialization at boot without pool

2017-01-24 Thread Dan Streetman
Allow zswap to initialize at boot even if it can't create its pool due to a failure to create a zpool and/or compressor. Allow those to be created later, from the sysfs module param interface. Signed-off-by: Dan Streetman --- mm/zswap.c | 46 ++--

[PATCH 3/3] zswap: clear compressor or zpool param if invalid at init

2017-01-24 Thread Dan Streetman
: Dan Streetman --- mm/zswap.c | 49 + 1 file changed, 37 insertions(+), 12 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 77cb847..9e8565d 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -76,6 +76,8 @@ static u64 zswap_duplicate_entry

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Dan Streetman
On Fri, Jan 13, 2017 at 3:00 PM, Boris Ostrovsky wrote: > On 01/13/2017 01:44 PM, Stefano Stabellini wrote: >> On Fri, 13 Jan 2017, Dan Streetman wrote: >>> On Wed, Jan 11, 2017 at 6:25 PM, Dan Streetman wrote: >>>> On Wed, Jan 11, 2017 at 1:46 PM, Stefano Stabel

[PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Dan Streetman
en.org/archives/html/xen-devel/2017-01/msg00447.html Fixes: af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests") Signed-off-by: Dan Streetman --- arch/x86/pci/xen.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/arch/x86/pci/

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Dan Streetman
On Wed, Jan 11, 2017 at 6:25 PM, Dan Streetman wrote: > On Wed, Jan 11, 2017 at 1:46 PM, Stefano Stabellini > wrote: >> On Wed, 11 Jan 2017, Dan Streetman wrote: >>> On Tue, Jan 10, 2017 at 8:25 PM, Stefano Stabellini >>> wrote: >>> > On Tue, 10 Jan 201

Re: [PATCH/RESEND v2 5/5] z3fold: add kref refcounting

2017-01-12 Thread Dan Streetman
On Wed, Jan 11, 2017 at 3:51 PM, Vitaly Wool wrote: > On Wed, 11 Jan 2017 13:03:06 -0500 > Dan Streetman wrote: > > >> >>> provided that I take the lock for the headless case above. That will >> >>> work won't it? >> >> >> >&g

Re: [PATCH/RESEND v2 3/5] z3fold: extend compaction function

2017-01-12 Thread Dan Streetman
On Wed, Jan 11, 2017 at 3:52 PM, Vitaly Wool wrote: > On Wed, 11 Jan 2017 17:43:13 +0100 > Vitaly Wool wrote: > >> On Wed, Jan 11, 2017 at 5:28 PM, Dan Streetman wrote: >> > On Wed, Jan 11, 2017 at 10:06 AM, Vitaly Wool wrote: >> >> z3fold_compact_page()

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-11 Thread Dan Streetman
On Wed, Jan 11, 2017 at 1:46 PM, Stefano Stabellini wrote: > On Wed, 11 Jan 2017, Dan Streetman wrote: >> On Tue, Jan 10, 2017 at 8:25 PM, Stefano Stabellini >> wrote: >> > On Tue, 10 Jan 2017, Dan Streetman wrote: >> >> On Tue, Jan 10, 2017 at 2:03

Re: [PATCH/RESEND v2 5/5] z3fold: add kref refcounting

2017-01-11 Thread Dan Streetman
On Wed, Jan 11, 2017 at 12:51 PM, Vitaly Wool wrote: > On Wed, Jan 11, 2017 at 6:39 PM, Dan Streetman wrote: >> On Wed, Jan 11, 2017 at 12:27 PM, Vitaly Wool wrote: >>> On Wed, Jan 11, 2017 at 6:08 PM, Dan Streetman wrote: >>>> On Wed, Jan 11, 2017 at 10:06 AM,

Re: [PATCH/RESEND v2 5/5] z3fold: add kref refcounting

2017-01-11 Thread Dan Streetman
On Wed, Jan 11, 2017 at 12:27 PM, Vitaly Wool wrote: > On Wed, Jan 11, 2017 at 6:08 PM, Dan Streetman wrote: >> On Wed, Jan 11, 2017 at 10:06 AM, Vitaly Wool wrote: >>> With both coming and already present locking optimizations, >>> introducing kref to reference-

Re: [PATCH/RESEND v2 5/5] z3fold: add kref refcounting

2017-01-11 Thread Dan Streetman
On Wed, Jan 11, 2017 at 10:06 AM, Vitaly Wool wrote: > With both coming and already present locking optimizations, > introducing kref to reference-count z3fold objects is the right > thing to do. Moreover, it makes buddied list no longer necessary, > and allows for a simpler handling of headless p

Re: [PATCH/RESEND 5/5] z3fold: add kref refcounting

2017-01-11 Thread Dan Streetman
On Wed, Jan 11, 2017 at 5:52 AM, Vitaly Wool wrote: > On Wed, Jan 4, 2017 at 7:42 PM, Dan Streetman wrote: >> On Sun, Dec 25, 2016 at 7:40 PM, Vitaly Wool wrote: >>> With both coming and already present locking optimizations, >>> introducing kref to reference-count

Re: [PATCH/RESEND v2 4/5] z3fold: use per-page spinlock

2017-01-11 Thread Dan Streetman
een the page and pool locks...but I don't see anything specifically wrong so Reviewed-by: Dan Streetman > --- > mm/z3fold.c | 148 > +++- > 1 file changed, 106 insertions(+), 42 deletions(-) > > diff --git a/mm/z3fo

Re: [PATCH/RESEND v2 3/5] z3fold: extend compaction function

2017-01-11 Thread Dan Streetman
On Wed, Jan 11, 2017 at 10:06 AM, Vitaly Wool wrote: > z3fold_compact_page() currently only handles the situation when > there's a single middle chunk within the z3fold page. However it > may be worth it to move middle chunk closer to either first or > last chunk, whichever is there, if the gap be

Re: [PATCH/RESEND v2 2/5] z3fold: fix header size related issues

2017-01-11 Thread Dan Streetman
f the z3fold header in chunks. > > Fixed also are the calculation of num_free_chunks() and the address to > move the middle chunk to in case of in-page compaction in > z3fold_compact_page(). > > Signed-off-by: Vitaly Wool Acked-by: Dan Streetma

Re: [PATCH/RESEND v2 1/5] z3fold: make pages_nr atomic

2017-01-11 Thread Dan Streetman
On Wed, Jan 11, 2017 at 10:06 AM, Vitaly Wool wrote: > This patch converts pages_nr per-pool counter to atomic64_t. > > Signed-off-by: Vitaly Wool Acked-by: Dan Streetman > --- > mm/z3fold.c | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) &

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-11 Thread Dan Streetman
On Tue, Jan 10, 2017 at 8:25 PM, Stefano Stabellini wrote: > On Tue, 10 Jan 2017, Dan Streetman wrote: >> On Tue, Jan 10, 2017 at 2:03 PM, Stefano Stabellini >> wrote: >> > On Tue, 10 Jan 2017, Dan Streetman wrote: >> >> On Tue, Jan 10, 2017 at 10:57 AM, Dan S

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Dan Streetman
On Tue, Jan 10, 2017 at 2:03 PM, Stefano Stabellini wrote: > On Tue, 10 Jan 2017, Dan Streetman wrote: >> On Tue, Jan 10, 2017 at 10:57 AM, Dan Streetman wrote: >> > On Mon, Jan 9, 2017 at 2:30 PM, Stefano Stabellini >> > wrote: >> >> On Mon, 9 Jan 2017,

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Dan Streetman
On Tue, Jan 10, 2017 at 10:57 AM, Dan Streetman wrote: > On Mon, Jan 9, 2017 at 2:30 PM, Stefano Stabellini > wrote: >> On Mon, 9 Jan 2017, Konrad Rzeszutek Wilk wrote: >>> On Mon, Jan 09, 2017 at 10:42:41AM -0500, Dan Streetman wrote: >>> > On Mon, Jan 9,

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Dan Streetman
On Mon, Jan 9, 2017 at 2:30 PM, Stefano Stabellini wrote: > On Mon, 9 Jan 2017, Konrad Rzeszutek Wilk wrote: >> On Mon, Jan 09, 2017 at 10:42:41AM -0500, Dan Streetman wrote: >> > On Mon, Jan 9, 2017 at 9:59 AM, Boris Ostrovsky >> > wrote: >> > > On 01/

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-09 Thread Dan Streetman
On Mon, Jan 9, 2017 at 9:59 AM, Boris Ostrovsky wrote: > On 01/06/2017 08:06 PM, Konrad Rzeszutek Wilk wrote: >> On Thu, Jan 05, 2017 at 02:28:56PM -0500, Dan Streetman wrote: >>> Do not read a pci device's msi message data to see if a pirq was >>> previously conf

[PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-05 Thread Dan Streetman
use the same pirq that it had before; but that pirq was allocated to controller B, and thus the Xen event channel for controller A's re-used pirq fails to map its irq to that pirq; the hypervisor already has the pirq mapped elsewhere. Signed-off-by: Dan Streetman --- arch/x86/pci/xen.c | 23 +

Re: [PATCH/RESEND 5/5] z3fold: add kref refcounting

2017-01-04 Thread Dan Streetman
On Sun, Dec 25, 2016 at 7:40 PM, Vitaly Wool wrote: > With both coming and already present locking optimizations, > introducing kref to reference-count z3fold objects is the right > thing to do. Moreover, it makes buddied list no longer necessary, > and allows for a simpler handling of headless pa

Re: [PATCH/RESEND 4/5] z3fold: fix header size related issues

2017-01-04 Thread Dan Streetman
On Sun, Dec 25, 2016 at 7:39 PM, Vitaly Wool wrote: > Currently the whole kernel build will be stopped if the size of struct > z3fold_header is greater than the size of one chunk, which is 64 bytes by > default. This patch instead defines the offset for z3fold objects as the > size of the z3fold h

Re: [PATCH/RESEND 3/5] z3fold: use per-page spinlock

2017-01-04 Thread Dan Streetman
On Sun, Dec 25, 2016 at 7:37 PM, Vitaly Wool wrote: > Most of z3fold operations are in-page, such as modifying z3fold page > header or moving z3fold objects within a page. Taking per-pool spinlock > to protect per-page objects is therefore suboptimal, and the idea of > having a per-page spinlock

Re: [PATCH/RESEND 2/5] mm/z3fold.c: extend compaction function

2017-01-04 Thread Dan Streetman
On Sun, Dec 25, 2016 at 7:34 PM, Vitaly Wool wrote: > z3fold_compact_page() currently only handles the situation where there's a > single middle chunk within the z3fold page. However it may be worth it to > move middle chunk closer to either first or last chunk, whichever is > there, if the gap b

  1   2   3   4   5   6   >