Re: [PATCH] thermal: uniphier: Convert to SPDX identifier

2018-12-06 Thread Daniel Lezcano
On 07/12/2018 02:06, Kunihiko Hayashi wrote: > This converts license boilerplate to SPDX identifier, and removes > unnecessary lines. > > Signed-off-by: Kunihiko Hayashi > --- Reviewed-by: Daniel Lezcano > drivers/thermal/uniphier_thermal.c | 13 + > 1 file

Re: [PATCH] clocksource/drivers/timer-imx-tpm: Specify clock name for timer-of

2018-12-06 Thread Daniel Lezcano
On 07/12/2018 07:05, Anson Huang wrote: > i.MX TPM needs "ipg" clock for register access and "per" clock for > timer function, the driver gets "ipg" clock by searching the clock > name, but timer-of initialization will get first clock in device > tree TPM node since no clock name specified in

Re: [PATCH v2] clocksource/drivers/fttmr010: fix invalid interrupt register access

2018-12-06 Thread Daniel Lezcano
On 07/12/2018 02:13, Tao Ren wrote: > On 11/5/18, 11:00 AM, "Tao Ren" wrote: > >> On 11/5/18, 10:51 AM, "Daniel Lezcano" wrote: >>> Oh right, sorry. Should it go to stable also ? Is there a Fixes tag it can >>> apply ? >>> >> P

Re: [PATCH] thermal: stm32: read factory settings inside stm_thermal_prepare

2018-12-06 Thread Daniel Lezcano
fixes this problem as internal > peripheral is well clocked at this stage. > > Signed-off-by: David Hernandez Sanchez > Fixes: 1d693155 ("thermal: add stm32 thermal driver") Same comment as the first patch. Reviewed-by: Daniel Lezcano > diff --git a/drivers/therm

Re: [PATCH] thermal: stm32: Fix stm_thermal_read_factory_settings

2018-12-06 Thread Daniel Lezcano
z Sanchez > Fixes: 1d693155 ("thermal: add stm32 thermal driver") Usually 'Fixes' comes first in the list. Other than that: Reviewed-by: Daniel Lezcano > diff --git a/drivers/thermal/st/stm_thermal.c > b/drivers/thermal/st/stm_thermal.c > index daa1257..bbd73c5 100644

Re: [PATCH] thermal: stm32: read factory settings properly

2018-12-06 Thread Daniel Lezcano
Hi David, On 06/12/2018 10:12, David HERNANDEZ SANCHEZ wrote: > Call stm_thermal_read_factory_settings once > internal peripheral is properly clocked. > > To avoid wrong initialization of fmt0 > (stm_thermal_sensor struct) member add > brackets properly. > > Change-Id:

Re: [PATCH V5 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-12-04 Thread Daniel Lezcano
Hi Dietmar, thanks for the review and spotting this. On 03/12/2018 14:46, Dietmar Eggemann wrote: > Hi Daniel, > > +cc: Russell King > > On 11/27/18 2:24 PM, Daniel Lezcano wrote: >> In the case of asymmetric SoC with the same micro-architecture, we >> have a grou

Re: v4.14 fix for Hikey 960 unbalanced IRQ enablement

2018-12-03 Thread Daniel Lezcano
On 03/12/2018 19:05, Greg KH wrote: > On Mon, Dec 03, 2018 at 10:19:46AM -0500, Sasha Levin wrote: >> On Mon, Dec 03, 2018 at 03:42:41PM +0100, Daniel Lezcano wrote: >>> On 03/12/2018 15:14, Greg KH wrote: >>>> On Mon, Dec 03, 2018 at 11:31:02AM -0200, Rafael David Ti

Re: [PATCH] clocksource: riscv_timer: Provide sched_clock

2018-12-03 Thread Daniel Lezcano
On 03/12/2018 15:50, Anup Patel wrote: > On Mon, Dec 3, 2018 at 6:29 PM Daniel Lezcano > wrote: >> >> On 03/12/2018 13:35, Anup Patel wrote: >>> Currently, we don't have a sched_clock registered for RISC-V systems. >>> This means Linux time kee

Re: v4.14 fix for Hikey 960 unbalanced IRQ enablement

2018-12-03 Thread Daniel Lezcano
On 03/12/2018 15:14, Greg KH wrote: > On Mon, Dec 03, 2018 at 11:31:02AM -0200, Rafael David Tinoco wrote: >> Sasha, could you consider including this cherry-picked patchset in v4.14. >> >> Kernel v4.14 might suffer from the following unbalanced enablement for the >> board Hikey 960: >> >> Nov 5

Re: [PATCH] clocksource: riscv_timer: Provide sched_clock

2018-12-03 Thread Daniel Lezcano
On 03/12/2018 13:35, Anup Patel wrote: > Currently, we don't have a sched_clock registered for RISC-V systems. > This means Linux time keeping will use jiffies (running at HZ) as the > default sched_clock. > > To avoid this, we explicity provide sched_clock using RISC-V rdtime > instruction

[PATCH RESEND] sched/cpufreq: Add the SPDX tags

2018-12-03 Thread Daniel Lezcano
The SPDX tags are not present in cpufreq.c and cpufreq_schedutil.c. Add them and remove the license descriptions Signed-off-by: Daniel Lezcano --- kernel/sched/cpufreq.c | 5 + kernel/sched/cpufreq_schedutil.c | 5 + 2 files changed, 2 insertions(+), 8 deletions(-) diff

Re: [PATCH] sched/cpufreq: Add the SPDX tags

2018-12-03 Thread Daniel Lezcano
On 03/12/2018 11:12, Rafael J. Wysocki wrote: > On Mon, Dec 3, 2018 at 11:07 AM Daniel Lezcano > wrote: >> >> On 18/10/2018 21:55, Daniel Lezcano wrote: >>> The SPDX tags are not present in cpufreq.c and cpufreq_schedutil.c. >>> >>> Add them and remov

Re: [PATCH] sched/cpufreq: Add the SPDX tags

2018-12-03 Thread Daniel Lezcano
On 18/10/2018 21:55, Daniel Lezcano wrote: > The SPDX tags are not present in cpufreq.c and cpufreq_schedutil.c. > > Add them and remove the license descriptions > > Signed-off-by: Daniel Lezcano Hi Rafael, I think this patch passed between the cracks. -- Daniel > -

[PATCH 2/2] thermal/drivers/hisi: Fix number of sensors on hi3660

2018-11-30 Thread Daniel Lezcano
of sensors on the hi3660, we switch back to the previous functionnality. Fixes: 8c6c36846f11 (thermal/drivers/hisi: Add the dual clusters sensors for hi3660) Signed-off-by: Daniel Lezcano --- drivers/thermal/hisi_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/2] thermal/drivers/hisi: Fix wrong platform_get_irq_byname()

2018-11-30 Thread Daniel Lezcano
back to the platform_get_irq() function call. Fixes: 2cffaeff083f (thermal/drivers/hisi: Use platform_get_irq_byname) Signed-off-by: Daniel Lezcano --- drivers/thermal/hisi_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal

Re: [PATCH] thermal/drivers/hisi: Fix bad initialization

2018-11-29 Thread Daniel Lezcano
On 29/11/2018 20:36, Eduardo Valentin wrote: > On Thu, Nov 29, 2018 at 07:26:56PM +0100, Daniel Lezcano wrote: >> Without this patch, the thermal driver on hi6220 and hi3660 is broken. >> >> That is due because part of the posted patchset was merged but a small >> c

Re: [PATCH] thermal/drivers/hisi: Fix bad initialization

2018-11-29 Thread Daniel Lezcano
Sorry typo in Vincent's email address, fixed now. On 29/11/2018 19:26, Daniel Lezcano wrote: > Without this patch, the thermal driver on hi6220 and hi3660 is broken. > > That is due because part of the posted patchset was merged but a small > change in the DT was dropped. >

[PATCH] thermal/drivers/hisi: Fix bad initialization

2018-11-29 Thread Daniel Lezcano
/drivers/hisi: Use platform_get_irq_byname) Signed-off-by: Daniel Lezcano --- drivers/thermal/hisi_thermal.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index c4111a9..3ab0e63 100644 --- a/drivers/thermal

Re: [PATCH V5 1/2] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-29 Thread Daniel Lezcano
On 29/11/2018 10:58, Juri Lelli wrote: > On 29/11/18 10:18, Daniel Lezcano wrote: >> On 29/11/2018 08:04, Juri Lelli wrote: >> >> [ ... ] >> >>>> With or without this patch, it is the case: >>>> &g

Re: [PATCH V5 1/2] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-29 Thread Daniel Lezcano
On 29/11/2018 08:04, Juri Lelli wrote: [ ... ] >> With or without this patch, it is the case: >> >> task1 task2 >> | | >> read("/sys/.../cpu1/cpu_capacity) | >> |

Re: [PATCH V5 1/2] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-28 Thread Daniel Lezcano
On 28/11/2018 12:44, Juri Lelli wrote: > Hi Daniel, > > On 27/11/18 14:24, Daniel Lezcano wrote: >> The mutex protects a per_cpu variable access. The potential race can >> happen only when the cpufreq governor module is loaded and at the same >> time the cpu capac

[PATCH V5 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Daniel Lezcano
-by: Quentin Perret Acked-by: Rob Herring Signed-off-by: Daniel Lezcano --- Documentation/devicetree/bindings/arm/cpu-capacity.txt | 6 ++ drivers/base/arch_topology.c | 9 - 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

[PATCH V5 1/2] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-27 Thread Daniel Lezcano
a task can take the lock and block. Replace the mutex by READ_ONCE / WRITE_ONCE. Signed-off-by: Daniel Lezcano Cc: Sudeep Holla Reviewed-by: Viresh Kumar --- drivers/base/arch_topology.c | 7 +-- include/linux/arch_topology.h | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Daniel Lezcano
On 27/11/2018 04:57, Viresh Kumar wrote: > On 26-11-18, 13:20, Daniel Lezcano wrote: >> diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt >> b/Documentation/devicetree/bindings/arm/cpu-capacity.txt >> index 84262cd..f53a3c9 100644 >> --- a/Documentat

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
Hi Greg, thanks for the review. On 26/11/2018 16:06, Greg Kroah-Hartman wrote: > On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote: >> --- a/drivers/base/arch_topology.c >> +++ b/drivers/base/arch_topology.c >> @@ -243,9 +243,20 @@ static int __init register_

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
On 26/11/2018 13:48, Quentin Perret wrote: > On Monday 26 Nov 2018 at 13:20:43 (+0100), Daniel Lezcano wrote: >> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c >> index fd5325b..e0c5b60 100644 >> --- a/drivers/base/arch_topology.c >> +++ b/d

[PATCH V4 1/2] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-26 Thread Daniel Lezcano
a task can take the lock and block. Replace the mutex by READ_ONCE / WRITE_ONCE. Signed-off-by: Daniel Lezcano Cc: Sudeep Holla Reviewed-by: Viresh Kumar --- drivers/base/arch_topology.c | 7 +-- include/linux/arch_topology.h | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff

[PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
-by: Daniel Lezcano --- Documentation/devicetree/bindings/arm/cpu-capacity.txt | 6 ++ drivers/base/arch_topology.c | 13 - 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt b

Re: [PATCH V3 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
On 26/11/2018 12:09, Quentin Perret wrote: > On Monday 26 Nov 2018 at 15:49:55 (+0530), Viresh Kumar wrote: >> On 26-11-18, 11:08, Daniel Lezcano wrote: >>> On 26/11/2018 10:52, Quentin Perret wrote: >>>> Maybe you want to test 'if (!raw_capacity || cap_pa

Re: [PATCH V3 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
On 26/11/2018 10:52, Quentin Perret wrote: > On Monday 26 Nov 2018 at 09:44:21 (+0100), Daniel Lezcano wrote: >> In the case of asymmetric SoC with the same micro-architecture, we >> have a group of CPUs with smaller OPPs than the other group. One >> example is the 96bo

[PATCH V3 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
758 1024 1024 ... respectively for CPU0, CPU1, CPU2 and CPU3. That reflects the capacity for the max frequencies 1593600 and 2150400. Cc: Chris Redpath Cc: Quentin Perret Cc: Viresh Kumar Cc: Amit Kucheria Cc: Nicolas Dechesne Cc: Niklas Cassel Signed-off-by: Daniel Lezcano

[PATCH V3 1/2] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-26 Thread Daniel Lezcano
a task can take the lock and block. Replace the mutex by READ_ONCE / WRITE_ONCE. Signed-off-by: Daniel Lezcano Cc: Sudeep Holla Reviewed-by: Viresh Kumar --- drivers/base/arch_topology.c | 7 +-- include/linux/arch_topology.h | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff

Re: [PATCH 2/4] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-26 Thread Daniel Lezcano
Hi Juri, On 26/11/2018 09:27, Juri Lelli wrote: > Hi, > > On 23/11/18 17:54, Daniel Lezcano wrote: >> On 23/11/2018 17:20, Sudeep Holla wrote: >>> On Fri, Nov 23, 2018 at 05:04:18PM +0100, Daniel Lezcano wrote: >>>> On 23/11/2018 14:58, Sudeep Holla wrote:

Re: [PATCH v2] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Daniel Lezcano
On 25/11/2018 06:00, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > integrator_ap_timer_init_of() doesn't do that.The pri_node and the > sec_node are used as an identifier to compare against the

Re: [PATCH] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Daniel Lezcano
On 25/11/2018 05:25, Frank Lee wrote: > On Sun, Nov 25, 2018 at 3:49 AM Daniel Lezcano > wrote: >> >> On 24/11/2018 15:58, Frank Lee wrote: >>> On Thu, Nov 22, 2018 at 11:23 PM Yangtao Li wrote: >>>> >>>> of_find_node_by_pa

Re: [PATCH] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-24 Thread Daniel Lezcano
On 24/11/2018 15:58, Frank Lee wrote: > On Thu, Nov 22, 2018 at 11:23 PM Yangtao Li wrote: >> >> of_find_node_by_path() acquires a reference to the node >> returned by it and that reference needs to be dropped by its caller. >> integrator_ap_timer_init_of() doesn't do that, so fix it. >> >>

Re: [PATCH 2/4] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-23 Thread Daniel Lezcano
On 23/11/2018 17:20, Sudeep Holla wrote: > On Fri, Nov 23, 2018 at 05:04:18PM +0100, Daniel Lezcano wrote: >> On 23/11/2018 14:58, Sudeep Holla wrote: >>> On Mon, Oct 29, 2018 at 05:23:18PM +0100, Daniel Lezcano wrote: >>>> The mutex protects a per_cpu variable

Re: [PATCH 2/4] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-23 Thread Daniel Lezcano
On 23/11/2018 14:58, Sudeep Holla wrote: > On Mon, Oct 29, 2018 at 05:23:18PM +0100, Daniel Lezcano wrote: >> The mutex protects a per_cpu variable access. The potential race can >> happen only when the cpufreq governor module is loaded and at the same >> time the cp

Re: [PATCH 05/17] clocksource: bcm2835: Switch to SPDX identifier

2018-11-23 Thread Daniel Lezcano
On 23/11/2018 13:06, Stefan Wahren wrote: > Hi Daniel, > > Am 12.11.2018 um 07:56 schrieb Daniel Lezcano: >> On 10/11/2018 16:28, Stefan Wahren wrote: >>> Adopt the SPDX license identifier headers to ease license compliance >>> management. Also drop the FSF

Re: [PATCH V2 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-23 Thread Daniel Lezcano
On 23/11/2018 11:04, Viresh Kumar wrote: > On 22-11-18, 13:36, Daniel Lezcano wrote: >> In the case of asymmetric SoC with the same micro-architecture, we >> have a group of CPUs with smaller OPPs than the other group. One >> example is the 96boards dragonboard 820c.

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

2018-11-22 Thread Daniel Lezcano
Hi wei, On 23/11/2018 07:15, Wei Ni wrote: > > > On 22/11/2018 9:07 PM, Daniel Lezcano wrote: >> On 22/11/2018 08:10, Wei Ni wrote: >>> >>> >>> On 21/11/2018 8:51 PM, Daniel Lezcano wrote: >>>> On 21/11/2018 11:23, Wei Ni wrote: >>

Re: [PATCH v2 0/2] clocksource/meson6_timer: implement ARM delay timer

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 23:12, Martin Blumenstingl wrote: > Hi Daniel, > > On Sun, Nov 18, 2018 at 2:27 AM Daniel Lezcano > wrote: >> >> On 15/11/2018 23:46, Martin Blumenstingl wrote: >>> While trying to add support for the ARM TWD Timer and the ARM Global >>>

Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 15:48, Frank Lee wrote: > On Thu, Nov 22, 2018 at 10:43 PM Daniel Lezcano > wrote: >> >> On 22/11/2018 15:39, Frank Lee wrote: >>> On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano >>> wrote: >>>> >>>> On 22/11/2018 15

[PATCH] clocksource/drivers/integrator-ap: add of_node_put()

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 15:39, Frank Lee wrote: > On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano > wrote: >> >> On 22/11/2018 15:33, Frank Lee wrote: >>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano >>> wrote: >>>> >>>> On 20/11/2018

Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 15:39, Frank Lee wrote: > On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano > wrote: >> >> On 22/11/2018 15:33, Frank Lee wrote: >>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano >>> wrote: >>>> >>>> On 20/11/2018

Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 15:33, Frank Lee wrote: > On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano > wrote: >> >> On 20/11/2018 14:18, Yangtao Li wrote: >>> use of_node_put() to release the refcount. >>> >>> Signed-off-by: Yangtao Li >> >> Applie

Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()

2018-11-22 Thread Daniel Lezcano
On 20/11/2018 14:18, Yangtao Li wrote: > use of_node_put() to release the refcount. > > Signed-off-by: Yangtao Li Applied, thanks! -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook |

Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 15:22, Linus Walleij wrote: > Acked-by: Linus Walleij > Thanks! -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter |

Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()

2018-11-22 Thread Daniel Lezcano
Hi Yangtao, On 20/11/2018 14:18, Yangtao Li wrote: > use of_node_put() to release the refcount. In future please give a better description. No need to resend, I'll do the change. Linus? I'm about to take this patch. Is it fine for you? > Signed-off-by: Yangtao Li > --- >

Re: [PATCH] clocksource/drivers/timer-imx-tpm: convert the driver to timer-of

2018-11-22 Thread Daniel Lezcano
Hi Anson, On 06/11/2018 06:15, Anson Huang wrote: > Convert the driver to use the timer_of helpers. > This allows to handle timer base, clock and irq using > common timer_of driver and it simplifies the code. Can you do an extra move by passing the timer_of structure around for: -

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 08:10, Wei Ni wrote: > > > On 21/11/2018 8:51 PM, Daniel Lezcano wrote: >> On 21/11/2018 11:23, Wei Ni wrote: >>> >>> >>> On 21/11/2018 4:55 PM, Daniel Lezcano wrote: >>>> On 13/11/2018 11:06, Wei Ni wrote: >>>>&

[PATCH V2 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-22 Thread Daniel Lezcano
... respectively for CPU0, CPU1, CPU2 and CPU3. That reflects the capacity for the max frequencies 1593600 and 2150400. Cc: Chris Redpath Cc: Quentin Perret Cc: Viresh Kumar Cc: Amit Kucheria Cc: Nicolas Dechesne Cc: Niklas Cassel Signed-off-by: Daniel Lezcano --- drivers/base

[PATCH V2 1/2] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE

2018-11-22 Thread Daniel Lezcano
a task can take the lock and block. Replace the mutex by READ_ONCE / WRITE_ONCE. Signed-off-by: Daniel Lezcano Acked-by: Viresh Kumar --- drivers/base/arch_topology.c | 7 +-- include/linux/arch_topology.h | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/base

Re: [PATCH 4/4] base/drivers/topology: Default dmpis-mhz if they are not set in DT

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 11:31, Viresh Kumar wrote: > On 22-11-18, 11:29, Daniel Lezcano wrote: >> Oh ... actually raw_capacity is not needed at all! > > It is required as another routine writes some values to it I believe :) Well actually it is accessed 'later' by topology_normalize_cpu_sc

Re: [PATCH 4/4] base/drivers/topology: Default dmpis-mhz if they are not set in DT

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 11:31, Viresh Kumar wrote: > On 22-11-18, 11:29, Daniel Lezcano wrote: >> Oh ... actually raw_capacity is not needed at all! > > It is required as another routine writes some values to it I believe :) Let's see if I can remove it. -- <http://www.linaro.org/&

Re: [PATCH 4/4] base/drivers/topology: Default dmpis-mhz if they are not set in DT

2018-11-22 Thread Daniel Lezcano
On 22/11/2018 05:29, Viresh Kumar wrote: > On 21-11-18, 23:12, Daniel Lezcano wrote: >> On 30/10/2018 09:58, Viresh Kumar wrote: >>> s/dmpis/dmips/ in $subject >>> >>> On 29-10-18, 17:23, Daniel Lezcano wrote: >>>> In the case of ass

Re: [PATCH 4/4] base/drivers/topology: Default dmpis-mhz if they are not set in DT

2018-11-21 Thread Daniel Lezcano
On 30/10/2018 09:58, Viresh Kumar wrote: > s/dmpis/dmips/ in $subject > > On 29-10-18, 17:23, Daniel Lezcano wrote: >> In the case of assymetric SoC with the same micro-architecture, we > > asymmetric ? > >> have a group of CPUs with smaller

Re: [PATCH] thermal: Fix locking in cooling device sysfs update cur_state

2018-11-21 Thread Daniel Lezcano
On 21/11/2018 20:01, Thara Gopinath wrote: > Sysfs interface to update cooling device cur_state does not > currently hold cooling device lock, leading to stale values > in cur_state especially if getting updated simultanelously > from user space and thermal framework. Adding the proper locking >

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

2018-11-21 Thread Daniel Lezcano
On 21/11/2018 11:23, Wei Ni wrote: > > > On 21/11/2018 4:55 PM, Daniel Lezcano wrote: >> On 13/11/2018 11:06, Wei Ni wrote: >>> Don't bail when a sensor fails to register with the >>> thermal zone and allow other sensors to register. >>> This all

Re: [PATCH 05/14] clocksource/drivers/timer-milbeaut: Add Milbeaut M10V timer

2018-11-21 Thread Daniel Lezcano
Hi Sugaya, On 19/11/2018 02:01, Sugaya Taichi wrote: > Add Milbeaut M10V timer using 32bit timer in peripheral. Give a better description of the timer as it is new timer introduced. > Signed-off-by: Sugaya Taichi > --- > drivers/clocksource/Kconfig | 8 +++ >

Re: [PATCH v3] thermal: qoriq: add multiple sensors support

2018-11-21 Thread Daniel Lezcano
m works, Peter Ziljstra, Ingo Molnar, Thomas Gleixner, have all permissions to commit in the tip tree but they take care of their subsystems. If one is away for vacations or whatever, someone else can take over during the absence. >> -Original Message- >> From: Daniel Lezcano >

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

2018-11-21 Thread Daniel Lezcano
On 13/11/2018 11:06, Wei Ni wrote: > Don't bail when a sensor fails to register with the > thermal zone and allow other sensors to register. > This allows other sensors to register with thermal > framework even if one sensor fails registration. I'm not sure if ignoring the error is really safe.

Re: [PATCH v3] thermal: qoriq: add multiple sensors support

2018-11-21 Thread Daniel Lezcano
@vger.kernel.org; >>> linux-kernel@vger.kernel.org; Andy Tang >>> Subject: [PATCH v3] thermal: qoriq: add multiple sensors support >>> >>> From: Yuantian Tang >>> >>> The QorIQ Layerscape SoC has several thermal sensors but the current >>&g

Re: [PATCH V5 2/2] thermal: imx: save one condition block for normal case of nvmem initialization

2018-11-21 Thread Daniel Lezcano
On 21/11/2018 06:49, Anson Huang wrote: > Put return value checks of calling imx_init_from_nvmem_cells() > into one block to save one condition block for normal case. > > Signed-off-by: Anson Huang Reviewed-by: Daniel Lezcano > --- > drivers/thermal/imx_thermal.c | 5 +++--

Re: [PATCH V5 1/2] thermal: imx: fix for dependency on cpu-freq

2018-11-21 Thread Daniel Lezcano
legacy cooling register/unregister to make > thermal driver probe successfully when CONFIG_CPU_FREQ is NOT set. > > Signed-off-by: Anson Huang Reviewed-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <htt

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Daniel Lezcano
Hi Manivannan, On 19/11/2018 18:09, Manivannan Sadhasivam wrote: > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > and HWTIMER. As it is a new driver, can you elaborate the log and describe the timer. > Signed-off-by: Andreas Färber > Signed-off-by: Manivannan Sadhasivam

Re: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Daniel Lezcano
On 20/11/2018 09:58, Anson Huang wrote: > Hi, Daniel > > Best Regards! > Anson Huang > >> -Original Message- >> From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] >> Sent: 2018年11月20日 16:54 >> To: Anson Huang ; rui.zh...@intel.com; >>

Re: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Daniel Lezcano
On 20/11/2018 09:47, Anson Huang wrote: > Hi, Daniel > > Best Regards! > Anson Huang > >> -Original Message- >> From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] >> Sent: 2018年11月20日 16:45 >> To: Anson Huang ; rui.zh...@intel.com; >>

Re: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Daniel Lezcano
On 24/10/2018 08:39, Anson Huang wrote: > The thermal driver is a standalone driver for monitoring SoC temperature > by enabling thermal sensor, so it can be enabled even when CONFIG_CPU_FREQ > is NOT set. So remove the dependency with CPU_THERMAL. > > Add CONFIG_CPU_FREQ check for cpu-freq

Re: [PATCH v3] clocksource/drivers/arc_timer: Utilize generic sched_clock

2018-11-19 Thread Daniel Lezcano
On 19/11/2018 12:29, Alexey Brodkin wrote: [ ... ] > arch/arc/Kconfig| 1 + > drivers/clocksource/Kconfig | 1 + > drivers/clocksource/arc_timer.c | 22 ++ > 3 files changed, 24 insertions(+) > > diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig Can I

Re: [PATCH v2] clocksource/drivers/arc_timer: Utilize generic sched_clock

2018-11-19 Thread Daniel Lezcano
Hi Alexey, On 19/11/2018 10:55, Alexey Brodkin wrote: > Hi Daniel, [ ... ] >>> In that case do I understand correctly that we may enable >>> GENERIC_SCHED_CLOCK >>> for ARC even before proposed change for arc_timer.c gets merged - i.e. with >>> no >>> special GENERIC_SCHED_CLOCK driver

Re: [PATCH v2] clocksource/drivers/arc_timer: Utilize generic sched_clock

2018-11-19 Thread Daniel Lezcano
On 19/11/2018 10:31, Alexey Brodkin wrote: > Hi Daniel, > > On Sun, 2018-11-18 at 03:17 +0100, Daniel Lezcano wrote: >> On 05/11/2018 15:39, Daniel Lezcano wrote: >>> On 24/10/2018 00:33, Vineet Gupta wrote: >>>> On 10/17/2018 04:30 AM, Alexey Brodkin wrote

Re: [PATCH V2 1/2] clocksource: imx-gpt: add support for ARM64

2018-11-17 Thread Daniel Lezcano
On 05/11/2018 02:10, Anson Huang wrote: > This patch allows building and compile-testing the i.MX > GPT driver also for ARM64. The delay_timer is only > supported on ARMv7. > > Signed-off-by: Anson Huang > --- > no change since V1. Applied, thanks. -- Daniel --

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-17 Thread Daniel Lezcano
Hi Anson, On 06/11/2018 10:12, Anson Huang wrote: [ ... ] Please convert to timer-of API. >>> >>> This patch mainly to fix the potential resource leak issue, for >>> converting to timer-of API, should I add another patch for it? Since >>> it is a different subject. >> >> Actually I was

Re: [RFC v2 5/7] clocksource/drivers/rtl8186: Add RTL8186 timer driver

2018-11-17 Thread Daniel Lezcano
8186 > > Signed-off-by: Yasha Cherikovsky > Cc: Ralf Baechle > Cc: Paul Burton > Cc: James Hogan > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Rob Herring > Cc: Mark Rutland > Cc: linux-m...@linux-mips.org > Cc: devicet...@vger.kernel.org > Cc: l

Re: [PATCH 1/2] clocksource: Demote dbx500 PRCMU clocksource

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 14:32, Linus Walleij wrote: > Demote the DBx500 PRCMU clocksource to quality 100 and > mark it as NONSTOP so it will still be used for > timekeeping across suspend/resume. > > The Nomadik MTU timer which has higher precision will > be used when the system is up and running, thanks

Re: [PATCH v2 0/2] clocksource/meson6_timer: implement ARM delay timer

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 23:46, Martin Blumenstingl wrote: > While trying to add support for the ARM TWD Timer and the ARM Global > Timer on Meson8, Meson8b and Meson8m2 (ARM Cortex-A5 and Cortex-A9 SoCs) > I did a review of the existing driver. > Unfortunately I found it hard to review because the

Re: [PATCH] clockevents/drivers/tegra20: Remove obsolete inclusion of

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 11:00, Geert Uytterhoeven wrote: > As of commit da4a686a2cfb077a ("ARM: smp_twd: convert to use CLKSRC_OF > init"), this header file is no longer used. > > Signed-off-by: Geert Uytterhoeven > --- Applied. Thanks! -- Linaro.org │ Open source software for

Re: [PATCH 1/2] clocksource: meson6_timer: use register names from the datasheet

2018-11-15 Thread Daniel Lezcano
On 15/11/2018 07:23, Martin Blumenstingl wrote: > Hi Daniel, > > thanks for your feedback! > > On Thu, Nov 15, 2018 at 2:35 AM Daniel Lezcano > wrote: >> >> On 28/10/2018 13:55, Martin Blumenstingl wrote: >>> This makes the driver use the names from

Re: [PATCH 1/2] clocksource: meson6_timer: use register names from the datasheet

2018-11-14 Thread Daniel Lezcano
On 28/10/2018 13:55, Martin Blumenstingl wrote: > This makes the driver use the names from S805 datasheet for the > preprocessor #defines. This makes it easier to spot that the driver > currently only supports Timer A (as clockevent with interrupt support) > and Timer E (as clocksource without

Re: [PATCH 05/17] clocksource: bcm2835: Switch to SPDX identifier

2018-11-11 Thread Daniel Lezcano
On 10/11/2018 16:28, Stefan Wahren wrote: > Adopt the SPDX license identifier headers to ease license compliance > management. Also drop the FSF address. > > Cc: Simon Arlott > Signed-off-by: Stefan Wahren > --- Acked-by: Daniel Lezcano -- <http://www.linaro.org/>

Re: [PATCH] irq/timings: Fix model validity

2018-11-08 Thread Daniel Lezcano
On 07/11/2018 14:05, Peter Zijlstra wrote: > On Wed, Nov 07, 2018 at 11:52:31AM +0100, Daniel Lezcano wrote: >>> @@ -146,11 +152,38 @@ static void irqs_update(struct irqt_stat *irqs, u64 >>> ts) >>> */ >>> diff = interval - irqs->avg; >>&g

Re: [PATCH] irq/timings: Fix model validity

2018-11-07 Thread Daniel Lezcano
On 07/11/2018 10:46, Peter Zijlstra wrote: > On Wed, Nov 07, 2018 at 09:59:36AM +0100, Peter Zijlstra wrote: >> On Wed, Nov 07, 2018 at 12:39:31AM +0100, Rafael J. Wysocki wrote: > >>> In general, however, I need to be convinced that interrupts that >>> didn't wake up the CPU from idle are

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-07 Thread Daniel Lezcano
On 07/11/2018 00:39, Rafael J. Wysocki wrote: > On Tue, Nov 6, 2018 at 8:51 PM Peter Zijlstra wrote: >> >> On Tue, Nov 06, 2018 at 07:19:24PM +0100, Rafael J. Wysocki wrote: >>> On Tue, Nov 6, 2018 at 6:04 PM Peter Zijlstra wrote: >> Instead of this detector; why haven't you used the code

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-06 Thread Daniel Lezcano
Hi Anson, On 06/11/2018 02:38, Anson Huang wrote: > Hi, Daniel > > Best Regards! > Anson Huang > >> -Original Message- >> From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] >> Sent: 2018年11月5日 21:35 >> To: Anson Huang ; t...@linutronix.de

Re: [PATCH] MAINTAINERS: add maintainer for C-SKY drivers

2018-11-06 Thread Daniel Lezcano
On 06/11/2018 08:45, Guo Ren wrote: > There are two intc drivers and two clocksource drivers, also include > related dt-bindings' documentations. > > Signed-off-by: Guo Ren Acked-by: Daniel Lezcano > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > &g

Re: [PATCH v2] clocksource/drivers/fttmr010: fix invalid interrupt register access

2018-11-05 Thread Daniel Lezcano
On 05/11/2018 19:43, Tao Ren wrote: > On 10/7/18, 2:03 PM, "Linus Walleij" wrote: >> >> On Wed, Oct 3, 2018 at 11:54 PM Tao Ren wrote: >> >>> TIMER_INTR_MASK register (Base Address of Timer + 0x38) is not designed >>> for masking interrupts on ast2500 chips, and it's not even listed in >>>

Re: [PATCH] sched: Create task_has_idle_policy() helper

2018-11-05 Thread Daniel Lezcano
-off-by: Viresh Kumar Acked-by: Daniel Lezcano [ ... ] -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH v2] clocksource/drivers/arc_timer: Utilize generic sched_clock

2018-11-05 Thread Daniel Lezcano
es # 10.19% of all branches >> >>0.003474829 seconds time elapsed >> >> 0.003519000 seconds user >>0.0 seconds sys >> -->8 >> >> Note how much more meani

Re: [PATCH] clocksource: imx-gpt: remove unnecessary irq protection

2018-11-05 Thread Daniel Lezcano
On 05/11/2018 15:15, Clément Péron wrote: > shutdown and oneshot are already protected against irq interruptions > > Signed-off-by: Clément Péron > --- Applied, thanks! -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-05 Thread Daniel Lezcano
Hi Anson, On 05/11/2018 02:10, Anson Huang wrote: > kfree should be called to free resource in error path > before return. > > Signed-off-by: Anson Huang > --- > drivers/clocksource/timer-imx-gpt.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v7 4/5] clocksource: add driver for i.MX EPIT timer

2018-11-05 Thread Daniel Lezcano
Hi Clément, On 04/11/2018 17:07, Clément Péron wrote: > Hi Daniel, > > Thanks for the review and sorry for the delay. no problem. > On Tue, 10 Jul 2018 at 18:20, Daniel Lezcano > wrote: >> >> On 11/06/2018 17:50, Clément Péron wrote: >>> From: Colin

Re: [GIT PULL] timer for tip/urgent

2018-11-02 Thread Daniel Lezcano
On 02/11/2018 22:01, Thomas Gleixner wrote: > Daniel, > > On Fri, 2 Nov 2018, Daniel Lezcano wrote: > >> this is a late pull request for the c-sky clocksource and clockevent. >> These are new drivers, they passed the review process several times for >> the c-

[PATCH 3/4] clocksource/drivers/c-sky: Add gx6605s SOC system timer

2018-11-02 Thread Daniel Lezcano
is clock source. Signed-off-by: Guo Ren Cc: Daniel Lezcano Cc: Thomas Gleixner Signed-off-by: Daniel Lezcano --- drivers/clocksource/Kconfig | 8 ++ drivers/clocksource/Makefile| 1 + drivers/clocksource/timer-gx6605s.c | 154 3 files changed

[PATCH 4/4] dt-bindings: timer: gx6605s SOC timer

2018-11-02 Thread Daniel Lezcano
From: Guo Ren Dt-bindings doc for gx6605s SOC's system timer. Signed-off-by: Guo Ren Reviewed-by: Rob Herring Signed-off-by: Daniel Lezcano --- .../bindings/timer/csky,gx6605s-timer.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentation

[PATCH 1/4] clocksource/drivers/c-sky: Add C-SKY SMP timer

2018-11-02 Thread Daniel Lezcano
: Daniel Lezcano Cc: Thomas Gleixner Signed-off-by: Daniel Lezcano --- drivers/clocksource/Kconfig | 10 +++ drivers/clocksource/Makefile| 1 + drivers/clocksource/timer-mp-csky.c | 173 include/linux/cpuhotplug.h | 1 + 4 files

[PATCH 2/4] dt-bindings: timer: C-SKY Multi-processor timer

2018-11-02 Thread Daniel Lezcano
From: Guo Ren Dt-bingdings doc for C-SKY SMP system setting. Signed-off-by: Guo Ren Reviewed-by: Rob Herring Signed-off-by: Daniel Lezcano --- .../devicetree/bindings/timer/csky,mptimer.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentation

[GIT PULL] timer for tip/urgent

2018-11-02 Thread Daniel Lezcano
Hi Thomas, this is a late pull request for the c-sky clocksource and clockevent. These are new drivers, they passed the review process several times for the c-sky architecture. - Add the per cpu timer for the c-sky architecture (Guo Ren) - Add the global timer for the c-sky architecture

Re: [PATCH] thermal: broadcom: use devm_thermal_zone_of_sensor_register

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 17:08, Julia Lawall wrote: > Using devm_thermal_zone_of_sensor_register allows to simplify some > error handling code, drop a label, and drop the remove function. > > Signed-off-by: Julia Lawall Reviewed-by: Daniel Lezcano > --- > > This patch is

  1   2   3   4   5   6   7   8   9   10   >