Re: [PATCH 2/2] gpio: xilinx: Add irq support to the driver

2020-04-29 Thread Daniel Mack
Hi Srinivas, Thanks for these patches. We're using them on a custom board, and I have some remarks as they didn't work as intended. See below. On 2/17/20 11:57 AM, Srinivas Neeli wrote: > Allocate single chip for both channels. > Add irq support to the driver. > Supporting rising edge interrupts

Re: [PATCH v2 1/2] uio: uio_pdrv_genirq: Make UIO name controllable via DT node property

2019-08-27 Thread Daniel Mack
Hi Greg, On 15/8/2019 11:28 PM, Daniel Mack wrote: > When probed via DT, the uio_pdrv_genirq driver currently uses the name > of the node and exposes that as name of the UIO device to userspace. > > This doesn't work for systems where multiple nodes with the same name >

[PATCH v2 1/2] uio: uio_pdrv_genirq: Make UIO name controllable via DT node property

2019-08-15 Thread Daniel Mack
s are auto-generated by a third-party tool. This patch adds the possibility to read the UIO name from the optional "linux,uio-name" property. Signed-off-by: Daniel Mack --- drivers/uio/uio_pdrv_genirq.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --gi

[PATCH v2 2/2] uio: Documentation: Add information on using uio_pdrv_genirq with DT

2019-08-15 Thread Daniel Mack
Add a paragraph to describe the use of the "of_id" module parameter, along with the new DT property. Signed-off-by: Daniel Mack --- Documentation/driver-api/uio-howto.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/driver-api/uio-howto.rst b/Documentat

Re: [PATCH] uio: uio_pdrv_genirq: Make UIO name controllable via DT node property

2019-08-15 Thread Daniel Mack
On 15/8/2019 10:56 PM, Greg KH wrote: > On Sun, Aug 11, 2019 at 01:02:13PM +0200, Daniel Mack wrote: >> When probed via DT, the uio_pdrv_genirq driver currently uses the name >> of the node and exposes that as name of the UIO device to userspace. >> >> This doesn't

[PATCH] uio: uio_pdrv_genirq: Make UIO name controllable via DT node property

2019-08-11 Thread Daniel Mack
s are auto-generated by a third-party tool. This patch adds the possibility to read the UIO name from the optional "linux,uio-name" property. Signed-off-by: Daniel Mack --- drivers/uio/uio_pdrv_genirq.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --gi

Re: 5.1.0-rc4: Oops in __rpc_execute() when trying to boot from NFS

2019-04-11 Thread Daniel Mack
Hi Trond, On 11/4/2019 9:50 PM, Trond Myklebust wrote: > On Tue, 2019-04-09 at 19:54 +0200, Daniel Mack wrote: >> On 9/4/2019 6:55 PM, Trond Myklebust wrote: >>> On Tue, 2019-04-09 at 18:25 +0200, Daniel Mack wrote: >>>> On 8/4/2019 8:51 PM, Trond Myklebust wrote:

Re: 5.1.0-rc4: Oops in __rpc_execute() when trying to boot from NFS

2019-04-09 Thread Daniel Mack
On 9/4/2019 6:55 PM, Trond Myklebust wrote: > On Tue, 2019-04-09 at 18:25 +0200, Daniel Mack wrote: >> On 8/4/2019 8:51 PM, Trond Myklebust wrote: >>> On Mon, 2019-04-08 at 19:01 +0200, Daniel Mack wrote: >>>> Hi, >>>> >>>> I'm se

Re: 5.1.0-rc4: Oops in __rpc_execute() when trying to boot from NFS

2019-04-09 Thread Daniel Mack
On 8/4/2019 8:51 PM, Trond Myklebust wrote: > On Mon, 2019-04-08 at 19:01 +0200, Daniel Mack wrote: >> Hi, >> >> I'm seeing the Oops below when trying to boot 5.1.0-rc4 on an ARM >> PXA3xx >> platform. v5.0 did not show this effect with the same cmdline. &g

5.1.0-rc4: Oops in __rpc_execute() when trying to boot from NFS

2019-04-08 Thread Daniel Mack
Hi, I'm seeing the Oops below when trying to boot 5.1.0-rc4 on an ARM PXA3xx platform. v5.0 did not show this effect with the same cmdline. Relevant bits from the config are: CONFIG_NFS_FS=y CONFIG_NFS_V2=y CONFIG_NFS_V3=y # CONFIG_NFS_V3_ACL is not set # CONFIG_NFS_V4 is not set # CONFIG_NFS_SW

Re: [PATCH 08/24] leds: lt3593: Use led_compose_name()

2018-11-08 Thread Daniel Mack
On 7/11/2018 8:49 PM, Jacek Anaszewski wrote: On 11/07/2018 08:37 PM, Daniel Mack wrote: On 6/11/2018 11:07 PM, Jacek Anaszewski wrote: Switch to using generic LED support for composing LED class device name. Thanks for the rework! Signed-off-by: Jacek Anaszewski ---   drivers/leds/leds

Re: [PATCH 08/24] leds: lt3593: Use led_compose_name()

2018-11-07 Thread Daniel Mack
On 6/11/2018 11:07 PM, Jacek Anaszewski wrote: Switch to using generic LED support for composing LED class device name. Thanks for the rework! Signed-off-by: Jacek Anaszewski --- drivers/leds/leds-lt3593.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --

Re: [PATCH v4 1/5] dt-bindings: w1: document generic onewire bindings

2018-07-18 Thread Daniel Mack
On Wednesday, July 11, 2018 05:01 PM, Rob Herring wrote: On Fri, Jul 06, 2018 at 07:35:48AM +0200, Daniel Mack wrote: This patch adds a generic w1 bindings document that describes how w1 slave deviceses are grouped under master nodes. It also augments the existing w1-gpio.txt document a bit

[PATCH v4 2/5] dt-bindings: w1: document bindings for ds2760 battery monitor

2018-07-05 Thread Daniel Mack
This patch adds the devicetree bindings for Maxim's ds2760 battery monitors. Signed-off-by: Daniel Mack --- .../bindings/power/supply/maxim,ds2760.txt| 26 +++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,d

[PATCH v4 1/5] dt-bindings: w1: document generic onewire bindings

2018-07-05 Thread Daniel Mack
This patch adds a generic w1 bindings document that describes how w1 slave deviceses are grouped under master nodes. It also augments the existing w1-gpio.txt document a bit. Signed-off-by: Daniel Mack --- .../devicetree/bindings/w1/w1-gpio.txt| 11 +--- Documentation/devicetree

[PATCH v4 4/5] power: supply: ds2760_battery: merge ds2760 supply driver with its w1 slave companion

2018-07-05 Thread Daniel Mack
can access the same virtual device nodes as before. Note that because the w1 core does not currently have a framework for suspend/resume, the driver now registers a PM notifier callback. Signed-off-by: Daniel Mack --- drivers/power/supply/Kconfig | 2 +- drivers/power/supply/ds2760_batte

[PATCH v4 3/5] w1: core: match sub-nodes of bus masters in devicetree

2018-07-05 Thread Daniel Mack
Once a new slave device is detected, match it against all sub-nodes of the master bus controller. If a match is found, set the slave device's of_node pointer. Signed-off-by: Daniel Mack --- drivers/w1/w1.c| 3 +++ include/linux/w1.h | 2 ++ 2 files changed, 5 insertions(+) diff --

[PATCH v4 5/5] power: supply: ds2760_battery: add devicetree probing

2018-07-05 Thread Daniel Mack
Add a matching table for devicetree probing, and optionally set the module parameter variables from DT properties. Signed-off-by: Daniel Mack --- drivers/power/supply/ds2760_battery.c | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/power

[PATCH v4 0/5] Add devicetree functionality to w1 busses and ds2760

2018-07-05 Thread Daniel Mack
maxim,current-accumulator property * Split 1st patch of v3 in two v2 → v3: * Fixed a typo in the documentation and added more real-world example for the bindings. Pointed out by Rob Herring. Daniel Mack (4): dt-bindings: w1: document generic onewire and DS2760 bindings w1: core: match sub-nod

Re: [PATCH v3 1/4] dt-bindings: w1: document generic onewire and DS2760 bindings

2018-07-05 Thread Daniel Mack
On Friday, July 06, 2018 01:32 AM, Rob Herring wrote: On Wed, Jul 04, 2018 at 06:44:08AM +0200, Daniel Mack wrote: This patch adds a generic w1 bindings document that merely describes how slave deviceses are grouped under master nodes. It also adds a specific binding for the ds2760 battery

[PATCH v3 0/4] Add devicetree functionality to w1 busses and ds2760

2018-07-03 Thread Daniel Mack
n and added more real-world example for the bindings. Pointed out by Rob Herring. Daniel Mack (4): dt-bindings: w1: document generic onewire and DS2760 bindings w1: core: match sub-nodes of bus masters in devicetree power: supply: ds2760_battery: merge ds2760 supply driver with its w1

[PATCH v3 2/4] w1: core: match sub-nodes of bus masters in devicetree

2018-07-03 Thread Daniel Mack
Once a new slave device is detected, match it against all sub-nodes of the master bus controller. If a match is found, set the slave device's of_node pointer. Signed-off-by: Daniel Mack --- drivers/w1/w1.c| 3 +++ include/linux/w1.h | 2 ++ 2 files changed, 5 insertions(+) diff --

[PATCH v3 1/4] dt-bindings: w1: document generic onewire and DS2760 bindings

2018-07-03 Thread Daniel Mack
This patch adds a generic w1 bindings document that merely describes how slave deviceses are grouped under master nodes. It also adds a specific binding for the ds2760 battery monitor. Signed-off-by: Daniel Mack --- .../bindings/power/supply/maxim,ds2760.txt| 29

[PATCH v3 4/4] power: supply: ds2760_battery: add devicetree probing

2018-07-03 Thread Daniel Mack
Add a matching table for devicetree probing, and optionally set the module parameter variables from DT properties. Signed-off-by: Daniel Mack --- drivers/power/supply/ds2760_battery.c | 32 ++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/power

[PATCH v3 3/4] power: supply: ds2760_battery: merge ds2760 supply driver with its w1 slave companion

2018-07-03 Thread Daniel Mack
can access the same virtual device nodes as before. Note that because the w1 core does not currently have a framework for suspend/resume, the driver now registers a PM notifier callback. Signed-off-by: Daniel Mack --- drivers/power/supply/Kconfig | 2 +- drivers/power/supply/ds2760_batte

Re: [PATCH v3 0/4] Add devicetree functionality to w1 busses and ds2760

2018-06-29 Thread Daniel Mack
On Friday, June 29, 2018 07:31 PM, Daniel Mack wrote: This patch set contains four small patches that bring devicetree functionality to w1 bus masters and slaves in general. As an example, the DS2760 driver is made aware of devicetree nodes as an example. Other drivers can easily be ported later

[PATCH v3 1/4] dt-bindings: w1: document generic onewire and DS2760 bindings

2018-06-29 Thread Daniel Mack
This patch add a generic w1 bindings document that merely describes how slave deviceses are grouped under master nodes. It also adds a specific binding for the ds2760 battery monitor. Signed-off-by: Daniel Mack --- .../bindings/power/supply/maxim,ds2760.txt| 29

[PATCH v3 0/4] Add devicetree functionality to w1 busses and ds2760

2018-06-29 Thread Daniel Mack
ch #3 merges the w1 slave and the supply driver for ds2760 Patch #4 makes the ds2760 supply driver aware of DT environments This works fine on a PXA3xx based board with a battery attached to the w1-gpio bus master controller. Daniel Mack (4): dt-bindings: w1: document sub-node bindings for DS2760

[PATCH v3 2/4] w1: core: match sub-nodes of bus masters in devicetree

2018-06-29 Thread Daniel Mack
Once a new slave device is detected, match it against all sub-nodes of the master bus controller. If a match is found, set the slave device's of_node pointer. Signed-off-by: Daniel Mack --- drivers/w1/w1.c| 3 +++ include/linux/w1.h | 2 ++ 2 files changed, 5 insertions(+) diff --

[PATCH v3 4/4] power: supply: ds2760_battery: add devicetree probing

2018-06-29 Thread Daniel Mack
Add a matching table for devicetree probing, and optionally set the module parameter variables from DT properties. Signed-off-by: Daniel Mack --- drivers/power/supply/ds2760_battery.c | 32 ++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/power

[PATCH v3 3/4] power: supply: ds2760_battery: merge ds2760 supply driver with its w1 slave companion

2018-06-29 Thread Daniel Mack
can access the same virtual device nodes as before. Note that because the w1 core does not currently have a framework for suspend/resume, the driver now registers a PM notifier callback. Signed-off-by: Daniel Mack --- drivers/power/supply/Kconfig | 2 +- drivers/power/supply/ds2760_batte

Re: [PATCH v2 4/4] power: ds2760_battery: add device tree glue

2018-06-28 Thread Daniel Mack
On Thursday, June 28, 2018 01:52 PM, Sebastian Reichel wrote: Hi, On Thu, Jun 28, 2018 at 09:55:40AM +0200, Daniel Mack wrote: The w1 slave device used by this driver now has a of_node in case it was matched against a devicetree sub-node of the bus master. This can now be passed down to the

[PATCH v2 2/4] w1: core: match sub-nodes of bus masters in devicetree

2018-06-28 Thread Daniel Mack
Once a new slave device is detected, match it against all sub-nodes of the master bus controller. If a match is found, set the slave device's of_node pointer. Signed-off-by: Daniel Mack --- drivers/w1/w1.c| 3 +++ include/linux/w1.h | 2 ++ 2 files changed, 5 insertions(+) diff --

[PATCH v2 1/4] dt-bindings: w1: document sub-node bindings for DS2760

2018-06-28 Thread Daniel Mack
This patch add a generic w1 bindings document that merely describes how slave deviceses are grouped under master nodes. It also adds a specific binding for the ds2760 battery monitor. Signed-off-by: Daniel Mack --- .../devicetree/bindings/w1/maxim,ds2760.txt| 15

[PATCH v2 3/4] w1: ds2760: add devicetree matching glue

2018-06-28 Thread Daniel Mack
Add an id table for ds2760 so it can be matched by the core. Signed-off-by: Daniel Mack --- drivers/w1/slaves/w1_ds2760.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/w1/slaves/w1_ds2760.c b/drivers/w1/slaves/w1_ds2760.c index 26168abfb8b8..e1726a4e4b1d 100644 --- a

[PATCH v2 4/4] power: ds2760_battery: add device tree glue

2018-06-28 Thread Daniel Mack
The w1 slave device used by this driver now has a of_node in case it was matched against a devicetree sub-node of the bus master. This can now be passed down to the power supply core which will parse more properties from the node, such as 'power-supplies'. Signed-off-by: Daniel Mack --

[PATCH v2 0/4] Add devicetree functionality to w1 busses

2018-06-28 Thread Daniel Mack
ine on a PXA3xx based board with a battery attached to the w1-gpio bus master controller. Daniel Mack (4): dt-bindings: w1: document sub-node bindings for DS2760 w1: core: match sub-nodes of bus masters in devicetree w1: ds2760: add devicetree matching glue power: ds2760_battery: add device t

Re: [PATCH v3 00/14] ARM: pxa: switch to DMA slave maps

2018-06-27 Thread Daniel Mack
On Wednesday, June 27, 2018 05:11 PM, Robert Jarzmik wrote: Mark Brown writes: On Mon, Jun 18, 2018 at 09:56:20PM +0200, Robert Jarzmik wrote: I must insist on "Wednesday", as I need to have one last pass from 0-day kernel checker to be fully covered, and I'd like as well to know which tree

Re: [PATCH RFC 0/4] Adding DT functionality to w1 busses

2018-06-27 Thread Daniel Mack
On Tuesday, June 26, 2018 11:39 PM, Rob Herring wrote: On Tue, Jun 19, 2018 at 3:27 PM, Daniel Mack wrote: In order to fully move battery-supplied devices over to devicetree, the onewire subsystem must get some updates. Currently, the w1 bus system works like this. Device families, such as

[PATCH RFC 2/4] w1: core: match sub-nodes of bus masters in devicetree

2018-06-19 Thread Daniel Mack
duced in the next patch. Signed-off-by: Daniel Mack --- drivers/w1/w1.c| 3 +++ include/linux/w1.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 80a778b02f28..dc73d8c08438 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -26,6 +26,7 @@ #in

[PATCH RFC 0/4] Adding DT functionality to w1 busses

2018-06-19 Thread Daniel Mack
plements the changes for the above in the w1 core. Changing the supply users is left for later when the basics have settlerd, but a helper to reference slave devices through phandles is already provided. Thanks, Daniel Daniel Mack (4): dt-bindings: w1: document sub-node bindings for DS2760 w1

[PATCH RFC 4/4] w1: ds2760: add devicetree matching glue

2018-06-19 Thread Daniel Mack
-off-by: Daniel Mack --- drivers/w1/slaves/w1_ds2760.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2760.c b/drivers/w1/slaves/w1_ds2760.c index 26168abfb8b8..a737a96204ed 100644 --- a/drivers/w1/slaves/w1_ds2760.c +++ b/drivers/w1

[PATCH RFC 1/4] dt-bindings: w1: document sub-node bindings for DS2760

2018-06-19 Thread Daniel Mack
This patch add a generic w1 bindings document that merely describes how slave deviceses are grouped under master nodes. It also adds a specific binding for the ds2760 battery monitor. Signed-off-by: Daniel Mack --- .../devicetree/bindings/w1/w1-ds2760.txt| 9 + .../devicetree

[PATCH RFC 3/4] w1: core: provide helper to look up w1 slaves through devicetree nodes

2018-06-19 Thread Daniel Mack
: Daniel Mack --- drivers/w1/w1.c| 37 + include/linux/w1.h | 11 +++ 2 files changed, 48 insertions(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index dc73d8c08438..693aa9be2cd9 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -1185,6

Re: [PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

2018-05-25 Thread Daniel Mack
more generic function dma_request_slave_channel(). Signed-off-by: Robert Jarzmik Reviewed-by: Daniel Mack --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx-ac97.c | 32 +--- sound/soc/pxa/pxa2xx

Re: [PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation

2018-05-25 Thread Daniel Mack
. is a 1-1 match to ssp., and the channels are either "rx" or "tx". - for device tree platforms, the dma node should be hooked into the pxa2xx-ac97 or pxa-ssp-dai node. Signed-off-by: Robert Jarzmik Acked-by: Daniel Mack We should, however, merge what's left of

Re: [PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

2018-05-23 Thread Daniel Mack
Hi Robert, Please refer to the attached patch instead of the one I sent earlier. I missed to also remove the platform_get_resource(IORESOURCE_DMA) call. Thanks, Daniel On Friday, May 18, 2018 11:31 PM, Daniel Mack wrote: Hi Robert, Thanks for this series. On Monday, April 02, 2018 04:26

Re: [PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

2018-05-18 Thread Daniel Mack
dropped. I attached a version for the new driver which you can pick instead. Thanks, Daniel >From c63bc40bdfe2d596e42919235840109a2f1b2776 Mon Sep 17 00:00:00 2001 From: Daniel Mack Date: Sat, 12 May 2018 21:50:13 +0200 Subject: [PATCH] mtd: rawnand: marvell: remove dmaengine compat code As the

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-10-25 Thread Daniel Mack
Hi Todor, On Wednesday, October 25, 2017 02:07 PM, Todor Tomov wrote: > On 16.10.2017 18:01, Daniel Mack wrote: >> I'd be grateful for any pointer about what I could investigate on. >> > > Everything that you have described seems correct. > > As you say that fr

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-10-16 Thread Daniel Mack
Hi, On 28.08.2017 09:10, Todor Tomov wrote: > On 25.08.2017 17:10, Daniel Mack wrote: >> Could you explain how ISPIF, CSID and CSIPHY are related? >> >> I have a userspace test setup that works fine for USB webcams, but when >> operating on any of the video devices

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-08-29 Thread Daniel Mack
Hi Todor, On 08/28/2017 09:10 AM, Todor Tomov wrote: > On 25.08.2017 17:10, Daniel Mack wrote: >> I have a userspace test setup that works fine for USB webcams, but when >> operating on any of the video devices exposed by this driver, the >> lowlevel functions such as .s_pow

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-08-25 Thread Daniel Mack
Hi Todor, Thanks a lot for working on the upstream support for this! On 08/08/2017 03:30 PM, Todor Tomov wrote: > +The Camera Subsystem hardware found on 8x16 processors and supported by the > +driver consists of: > + > +- 2 CSIPHY modules. They handle the Physical layer of the CSI2 receivers. >

Re: [PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs()

2017-08-12 Thread Daniel Mack
arkus Elfring Acked-by: Daniel Mack > --- > sound/usb/caiaq/audio.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c > index 8f66ba730d69..1f306155e76a 100644 > --- a/sound/usb/caiaq/audio.c > +++ b/sound/usb/c

Re: [PATCH 01/10] Input: eeti_ts - rename eeti_ts_priv to eeti_ts

2017-03-01 Thread Daniel Mack
Hi Dmitry, On 02/28/2017 11:46 PM, Dmitry Torokhov wrote: > Also rename 'priv' variables to eeti. > > Signed-off-by: Dmitry Torokhov > --- > > Hi, > > This is all is not tested as I do not have the hardware, so if anyone > has raumfeld device that would be awesome. I have no access to such ha

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2016-12-20 Thread Daniel Mack
Hi, On 12/20/2016 06:23 PM, Andy Lutomirski wrote: > On Tue, Dec 20, 2016 at 2:21 AM, Daniel Mack wrote: > To clarify, since this thread has gotten excessively long and twisted, > I think it's important that, for hooks attached to a cgroup, you be > able to tell in a ge

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2016-12-20 Thread Daniel Mack
Hi, On 12/20/2016 04:50 AM, Andy Lutomirski wrote: > On Mon, Dec 19, 2016 at 7:18 PM, Alexei Starovoitov > wrote: >> On Mon, Dec 19, 2016 at 04:25:32PM -0800, Andy Lutomirski wrote: >>> I think we're still talking past each other. A big part of the point >>> of changing it is that none of this i

Re: [PATCH v3 0/2] AM335x-ICE: Add support for rotary switch

2016-08-24 Thread Daniel Mack
On 08/24/2016 11:15 AM, Vignesh R wrote: > On Wednesday 24 August 2016 02:05 PM, Daniel Mack wrote: >> On 08/24/2016 09:58 AM, Vignesh R wrote: >>> This series adds support for rotary-switch on AM335x-ICE that is >>> connected to TI PCA9536 I2C GPIO expander. >&

Re: [PATCH v3 0/2] AM335x-ICE: Add support for rotary switch

2016-08-24 Thread Daniel Mack
Hi, On 08/24/2016 09:58 AM, Vignesh R wrote: > This series adds support for rotary-switch on AM335x-ICE that is > connected to TI PCA9536 I2C GPIO expander. > First patch adds new generic driver to read status of group of GPIO > lines and report the value as an input event. The second patch adds D

Re: [PATCH] ARM: pxa: mark raumfeld init functions as __maybe_unused

2015-12-09 Thread Daniel Mack
nector_init' defined > but not used [-Wunused-function] > arm/mach-pxa/raumfeld.c:1082:123: warning: 'raumfeld_speaker_init' defined > but not used [-Wunused-function] > > This marks the functions as __maybe_unused to avoid the warnings. > > Signed-off-by: Arn

Re: [PATCH 07/18] Input: cap11xx - simplify function return logic

2015-10-02 Thread Daniel Mack
oard/cap11xx.c:475:1-6: WARNING: end returns can be > simplified > > Signed-off-by: Javier Martinez Canillas Acked-by: Daniel Mack > --- > > drivers/input/keyboard/cap11xx.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/driver

Re: kdbus: to merge or not to merge?

2015-08-09 Thread Daniel Mack
On 08/09/2015 09:00 PM, Greg Kroah-Hartman wrote: > In chatting with Daniel on IRC, he is writing up a summary of how the > kdbus memory pools work in more detail, and he said he would sent that > out in a day or so, so that everyone can review. Yes, let me quickly describe again how the kdbus poo

Re: kdbus: to merge or not to merge?

2015-08-07 Thread Daniel Mack
On 08/06/2015 08:43 PM, Andy Lutomirski wrote: > Nonetheless, it looks like the slice logic (aside: it looks *way* more > complicated than necessary -- what's wrong with circular buffers) > will, under most (but not all!) workloads, concentrate access to a > smallish fraction of the pool. This is

[PATCH 2/4] kdbus: inform caller about exact updates on NAME_ACQUIRE

2015-08-07 Thread Daniel Mack
: Daniel Mack Signed-off-by: David Herrmann --- include/uapi/linux/kdbus.h | 4 ipc/kdbus/names.c | 38 -- 2 files changed, 32 insertions(+), 10 deletions(-) diff --git a/include/uapi/linux/kdbus.h b/include/uapi/linux/kdbus.h index ecffc6b

[PATCH 3/4] kdbus: never return <0 from ioctls if we changed state

2015-08-07 Thread Daniel Mack
eturns 0 in those cases. User-space still gets the same information (via return_flags), but will no longer be told that the call failed. The tests reflect that and simply check for KDBUS_NAME_ACQUIRED in 'return_flags'. Reviewed-by: Daniel Mack Signed-off-by: David Herrmann ---

[PATCH 4/4] kdbus: selftests: add more name registry tests

2015-08-07 Thread Daniel Mack
Add some more code for testing the name registry state. This can now be used to track the state of queued names and per-name queing settings. Also add new tests to check the newly added KDBUS_NAME_PRIMARY and KDBUS_NAME_ACQUIRED flags and name takeovers. Signed-off-by: Daniel Mack --- tools

[PATCH 1/4] kdbus: restructure name-registry to follow dbus-spec

2015-08-07 Thread Daniel Mack
-spec regarding behavior of name-acquisition perfectly. Hence, the bus-proxy can properly implement backwards-compatibility to dbus1. [1] http://dbus.freedesktop.org/doc/dbus-specification.html Reviewed-by: Daniel Mack Signed-off-by: David Herrmann --- ipc/kdbus/connection.c | 53 ++-- ipc/kdb

[PATCH 0/4] kdbus: name registry cleanup patches

2015-08-07 Thread Daniel Mack
all other command dispatchers follow as well. * The last one adds more selftests for the name registry, covering the newly added flags. None of these patches is critical, and everything has been running well on our machines for a while. Thanks, Daniel Daniel Mack (1): kdbus: selftests: add

Re: kdbus: to merge or not to merge?

2015-08-06 Thread Daniel Mack
On 08/06/2015 05:21 PM, Andy Lutomirski wrote: > Maybe gdbus really does use kdbus already, but on > very brief inspection it looked like it didn't at least on my test VM. No, it's not in any released version yet. The patches for that are being worked on though and look promising. > If the client

Re: kdbus: to merge or not to merge?

2015-08-06 Thread Daniel Mack
On 08/06/2015 05:27 PM, Andy Lutomirski wrote: >> In DBus (both kdbus and DBus1), such matches are installed on the >> > NameOwnerChanged signal, and they can be either specific to a single ID, >> > or broad, which will make them match on any ID. There's actually no >> > reason for applications to

Re: kdbus: to merge or not to merge?

2015-08-06 Thread Daniel Mack
Hi Andy, On 08/05/2015 02:18 AM, Andy Lutomirski wrote: > I added the missing sd_bus_unref call. > > With userspace dbus, my program takes 95% CPU and dbus-daemon takes > 88% CPU or so. > > With kdbus, I see abuse-bus (my test), systemd-journald, > systemd-bus-proxy, auditd, gnome-shell, mission

Re: [RFC 2/8] lsm: smack: Make ipc/kdbus includes visible so smack callbacks could see them

2015-07-08 Thread Daniel Mack
On 07/08/2015 06:25 AM, Paul Osmialowski wrote: > Signed-off-by: Paul Osmialowski > --- > security/smack/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/security/smack/Makefile b/security/smack/Makefile > index ee2ebd5..bd6927c 100644 > --- a/security/smack/Makefile > +++ b/s

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-24 Thread Daniel Mack
Hi, On 04/24/2015 12:50 PM, Borislav Petkov wrote: > On Fri, Apr 24, 2015 at 12:28:54PM +0200, Daniel Mack wrote: >> Sure, for broadcasts, we have to walk the list of peers connected to the >> bus and see which one is interested in a particular message. We do that > > And

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-24 Thread Daniel Mack
Hi, On 04/24/2015 11:04 AM, Borislav Petkov wrote: > On Thu, Apr 23, 2015 at 10:02:52PM -0700, Steven Noonan wrote: >> On Thu, Apr 23, 2015 at 2:41 PM, Borislav Petkov wrote: >>> On Thu, Apr 23, 2015 at 11:22:39PM +0200, David Herrmann wrote: No it's not. O(256) equals O(1). >>> >>> Ok, you'

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-21 Thread Daniel Mack
Hi, On 04/20/2015 08:01 PM, James Bottomley wrote: > On Fri, 2015-04-17 at 16:27 -0400, Havoc Pennington wrote: >> Do you have ideas on how to go about fixing it, whether in userspace >> or kernel dbus? > > Well, I've always suspected the solution would be for dbus to have a > hierarchical names

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-17 Thread Daniel Mack
Hi Havoc, On 04/16/2015 09:01 PM, Havoc Pennington wrote: > On Thu, Apr 16, 2015 at 9:13 AM, Tom Gundersen wrote: >> All types of messages (unicast and broadcast) are directly stored into >> a pool slice of the receiving connection, and this slice is not reused >> by the kernel until userspace is

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-16 Thread Daniel Mack
On 04/16/2015 12:08 AM, One Thousand Gnomes wrote: >> When trying to split apart problems, for dbus it's important to keep >> ordering guarantees. > > Yes I assumed that - minus disconnection/reconnect and running out of > queue space. Some users also want priority queueing (with or without the >

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-16 Thread Daniel Mack
On 04/16/2015 12:11 AM, Andy Lutomirski wrote: > Also, getting the really high performance stuff right would be nice. > Binder has one thing going for it (IIRC -- I've talked about it to > some of the authors, but I've never so much as glanced at the code): > it has a primitive to send and wait for

Re: Sending caps to userspace (Re: [GIT PULL] kdbus for 4.1-rc1)

2015-04-16 Thread Daniel Mack
On 04/15/2015 05:42 PM, Andy Lutomirski wrote: > On Apr 15, 2015 5:00 AM, "Greg Kroah-Hartman" > I looked. AFAICT polkit doesn't use caps. Systemd does (look for > VTABLE_CAP and the associated code) for reasons that escape me. I > have yet to find a single cap-guarded method in the systemd cod

Re: [PATCH] kdbus: uapi: Fix kernel-doc for enum kdbus_send_flags

2015-04-09 Thread Daniel Mack
On 04/09/2015 12:11 PM, Sergei Zviagintsev wrote: > Signed-off-by: Sergei Zviagintsev Acked-by: Daniel Mack > --- > include/uapi/linux/kdbus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/kdbus.h b/include/uapi/linux/kdbus.h &g

Re: [PATCH] Documentation: kdbus: Fix list of KDBUS_CMD_ENDPOINT_UPDATE errors

2015-04-09 Thread Daniel Mack
On 04/09/2015 12:08 PM, Sergei Zviagintsev wrote: > Remove EEXIST. > > Signed-off-by: Sergei Zviagintsev Acked-by: Daniel Mack Thanks again! > --- > Documentation/kdbus/kdbus.endpoint.xml | 7 --- > 1 file changed, 7 deletions(-) > > diff --g

Re: [PATCH] Documentation: kdbus: Fix description of KDBUS_SEND_SYNC_REPLY flag

2015-04-09 Thread Daniel Mack
On 04/09/2015 12:08 PM, Sergei Zviagintsev wrote: > Signed-off-by: Sergei Zviagintsev Acked-by: Daniel Mack > --- > Documentation/kdbus/kdbus.message.xml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kdbus/kdbus.message.xml

Re: [PATCH] Documentation: kdbus: Update list of ioctls which cause writing to receiver's pool

2015-04-09 Thread Daniel Mack
On 04/09/2015 12:08 PM, Sergei Zviagintsev wrote: > Add KDBUS_CMD_BUS_CREATOR_INFO. > > Signed-off-by: Sergei Zviagintsev Acked-by: Daniel Mack > --- > Documentation/kdbus/kdbus.pool.xml | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/k

Re: [PATCH] Documentation: kdbus: Fix typos

2015-04-09 Thread Daniel Mack
On 04/09/2015 12:08 PM, Sergei Zviagintsev wrote: > Signed-off-by: Sergei Zviagintsev Acked-by: Daniel Mack Thanks for spotting those! > --- > Documentation/kdbus/kdbus.bus.xml| 9 - > Documentation/kdbus/kdbus.connection.xml | 10 -- > Docu

Re: [PATCH] samples: kdbus: build kdbus-workers conditionally

2015-04-03 Thread Daniel Mack
Hi Andrew, On 04/01/2015 11:41 PM, Andrew Morton wrote: > On Wed, 1 Apr 2015 14:47:20 +0200 Greg KH wrote: > >> On Tue, Mar 31, 2015 at 03:11:34PM +0200, Daniel Mack wrote: >>> Give the kdbus sample its own config switch and only build it if it's >>> explici

Re: linux-next: Tree for Mar 31 (build failures and culprits)

2015-03-31 Thread Daniel Mack
On 04/01/2015 04:45 AM, Guenter Roeck wrote: > On 03/31/2015 07:24 PM, Guenter Roeck wrote: >> Now I am left with the question if the samples build should be >> masked for alpha and mips, or if I should drop building samples >> from my 'allmodconfig' builds. I think I'll do the latter; >> there se

[PATCH] samples: kdbus: build kdbus-workers conditionally

2015-03-31 Thread Daniel Mack
Give the kdbus sample its own config switch and only build it if it's explicitly switched on. Signed-off-by: Daniel Mack Reviewed-by: David Herrmann Reported-by: Jiri Slaby --- samples/Kconfig| 7 +++ samples/kdbus/Makefile | 2 +- 2 files changed, 8 insertions(+), 1 del

[PATCH] kdbus: Fix CONFIG_KDBUS help text

2015-03-24 Thread Daniel Mack
Drop a left-over from the times when documentation lived in a simple text file, which is no longer the case. Mention the auto-generated man-pages and HTML files instead. Reported-by: Jiri Slaby Signed-off-by: Daniel Mack --- Thanks for reporting this, Jiri! init/Kconfig | 7 --- 1 file

Re: [PATCH 13/14] kdbus: add walk-through user space example

2015-03-24 Thread Daniel Mack
Iusr/include and make each sample opt-in. Alright then. Does the attached patch fix your problem, Jiri? Thanks, Daniel From 56309ab0717720fb086ec3209f1b1fa719072f61 Mon Sep 17 00:00:00 2001 From: Daniel Mack Date: Tue, 24 Mar 2015 19:41:56 +0100 Subject: [PATCH] kdbus: sample: build kdbus-workers co

[PATCH] kdbus: connection: fix handling of failed fget()

2015-03-17 Thread Daniel Mack
hecking for NULL pointers returned from fget(). Reported-by: Dan Carpenter Signed-off-by: Daniel Mack --- ipc/kdbus/connection.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c index e554f1a..ab476fa 100644 --- a/ipc/kdbus/con

Re: [PATCH v2 1/2] dma: mmp_dma: add support for legacy transition

2015-02-19 Thread Daniel Mack
Hi Robert, Thanks for pushing this topic :) On 02/17/2015 09:39 PM, Robert Jarzmik wrote: > In order to achieve smooth transition of pxa drivers from old legacy dma > handling to new dmaengine, introduce a function to "hide" dma physical > channels from dmaengine. > > This is temporary situation

Re: [PATCH RFC 2/2] ARM: pxa: transition to dmaengine phase 1

2015-02-16 Thread Daniel Mack
On 02/16/2015 12:12 PM, robert.jarz...@free.fr wrote: > So far so good. If the mmp_pdma patch is accepted for the transition, it will > open up my path towards dmaengine conversion of all pxa drivers (mmc, nand, > pxa_camera and pxa2xx-pcm-lib). As Daniel has already done most of the work, > and be

Re: [PATCH RFC 2/2] ARM: pxa: transition to dmaengine phase 1

2015-02-16 Thread Daniel Mack
On 02/16/2015 12:14 PM, Vasily Khoruzhick wrote: > What about dropping old PXA DMA code completely? Daniel Mack did port > for most of PXA drivers to dma engine, > I've rebased his patches against 3.17 several months ago and fixed > oopses in pxamci and asoc drivers, but I didn

Re: [PATCH] ARM: pxa: pxa27x skip default device initialization with DT

2015-02-07 Thread Daniel Mack
kip > default device initialization when booting via DT"). > > Signed-off-by: Robert Jarzmik Looks good to me - thanks! Acked-by: Daniel Mack > --- > arch/arm/mach-pxa/pxa27x.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-

Re: [PATCH 01/13] kdbus: add documentation

2015-02-03 Thread Daniel Mack
Hi Andy, On 02/02/2015 09:12 PM, Andy Lutomirski wrote: > On Feb 2, 2015 1:34 AM, "Daniel Mack" wrote: >> That's right, but again - if an application wants to gather this kind of >> information about tasks it interacts with, it can do so today by looking >>

Re: [PATCH 01/13] kdbus: add documentation

2015-02-02 Thread Daniel Mack
Hi Andy, On 01/29/2015 01:09 PM, Andy Lutomirski wrote: > On Jan 29, 2015 6:42 AM, "Daniel Mack" wrote: >> As we explained before, currently, D-Bus peers do collect the same >> information already if they need to have them, but they have to do deal >> with the inh

Re: [PATCH] ARM: pxa: Fix typo in zeus.c

2015-01-31 Thread Daniel Mack
On 01/31/2015 06:49 AM, Masanari Iida wrote: > This patch fix a typo in struct platform_device can_regulator_device. > > Signed-off-by: Masanari Iida Acked-by: Daniel Mack That's a regression from 1ddff7da ("can: mcp251x: Replace power callbacks with regulator API"

Re: [PATCH 01/13] kdbus: add documentation

2015-01-29 Thread Daniel Mack
On 01/29/2015 12:25 PM, Andy Lutomirski wrote: > On Jan 29, 2015 3:53 AM, "Daniel Mack" wrote: >> Also note that if a receiving peer opts in for a certain piece of >> metadata, it should do that that for a good reason, because it needs >> that data to process a req

Re: [PATCH 01/13] kdbus: add documentation

2015-01-29 Thread Daniel Mack
Hi Andy, On 01/27/2015 05:03 PM, Andy Lutomirski wrote: > On Tue, Jan 27, 2015 at 7:05 AM, David Herrmann wrote: >> A 16byte copy does not affect the performance of kdbus message >> transactions in any way that matters. > What are the performance goals of kdbus? How fast is it ever intended >

Re: [PATCH 01/13] kdbus: add documentation

2015-01-27 Thread Daniel Mack
Hi Michael, On 01/27/2015 06:53 PM, Michael Kerrisk (man-pages) wrote: > On 01/27/2015 04:23 PM, David Herrmann wrote: >> I only expect a handful of users to call the ioctls directly. The >> libraries that implement the payload-marshaling, in particular. It's a >> similar situation with netlink.

Re: [PATCH 01/13] kdbus: add documentation

2015-01-21 Thread Daniel Mack
Hi Michael, On 01/21/2015 11:32 AM, Michael Kerrisk (man-pages) wrote: > On 01/20/2015 07:23 PM, Daniel Mack wrote: >> It's rather an optional driver than a core kernel feature. > > Given the various things that I've seen said about kdbus, the > preceding sente

  1   2   3   4   >