Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Daniel Vetter
It's a gpu, any idea of these drivers actually being platform independent is out of the window from the start anyway, so we're ok with tying this to platforms. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH AUTOSEL 4.9 08/17] drm/edid: Add 6 bpc quirk for BOE panel.

2018-11-21 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 10:31 AM Daniel Vetter wrote: > > On Tue, Nov 13, 2018 at 12:52:14AM -0500, Sasha Levin wrote: > > From: "Lee, Shawn C" > > > > [ Upstream commit 922dceff8dc1fb4dafc9af78139ba65671408103 ] > > > > BOE panel (ID: 0x0771) that

Re: [PATCH] kthread: finer-grained lockdep/cross-release completion

2018-10-18 Thread Daniel Vetter
On Fri, Mar 16, 2018 at 12:26 AM Byungchul Park wrote: > > On 3/15/2018 9:41 PM, Peter Zijlstra wrote: > > On Thu, Mar 15, 2018 at 11:31:57AM +0100, Daniel Vetter wrote: > >> Is there any progress on getting cross-release enabled again? > > > > Not yet, I'm st

Re: [PATCH -next] drm: Use PTR_ERR_OR_ZERO in drm_fb_cma_fbdev_init()

2018-10-11 Thread Daniel Vetter
urn PTR_ERR(fbdev_cma); > - > - return 0; > + return PTR_ERR_OR_ZERO(fbdev_cma); > } > EXPORT_SYMBOL_GPL(drm_fb_cma_fbdev_init); > > > > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > h

Re: [PATCH] drm/atomic_helper: Allow DPMS On<->Off changes for unregistered connectors

2018-10-11 Thread Daniel Vetter
est course of > > action would be to just move the unregistered connector checks out of > > update_connector_routing() and into drm_atomic_set_crtc_for_connector(). > > The reason for this being that legacy modesetting isn't going to be > > expecting failures anywhere (at least

Re: [PATCH v7 1/5] drm/atomic_helper: Disallow new modesets on unregistered connectors

2018-10-11 Thread Daniel Vetter
t were just > > removed from the system, without preventing userspace from disabling > > DPMS on those connectors. > > > > Changes since v5: > > - Fix typo in comment, nothing else > > > > Signed-off-by: Lyude Paul > > Reviewed-by: Daniel Vette

Re: [PATCH] drm/drm_vblank: Change EINVAL by the correct errno

2018-10-11 Thread Daniel Vetter
I thought that EOPNOTSUPP could better describe this situation. I think either is an ok choice. EINVAL since afaik upstream never supported this flag, so it's not different from any other flag with on meaning - just another userspace programming bug. > > > + return -EOPNOTSUPP; > > > > > > if (vblwa

Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume()

2018-10-11 Thread Daniel Vetter
On Mon, Oct 08, 2018 at 09:57:52PM +0530, Souptick Joarder wrote: > Hi Laurent, > On Mon, Oct 1, 2018 at 6:12 PM Noralf Trønnes wrote: > > > > > > Den 01.10.2018 13.56, skrev Laurent Pinchart: > > > Hi Daniel, > > > > > > On Monday, 1 October 20

Re: [Ksummit-discuss] [PATCH 0/2] code of conduct fixes

2018-10-07 Thread Daniel Vetter
On Sun, Oct 7, 2018 at 7:40 PM James Bottomley wrote: > > On Sun, 2018-10-07 at 19:11 +0200, Daniel Vetter wrote: > > Hi James, > > > > On Sat, Oct 6, 2018 at 11:36 PM James Bottomley > > wrote: > > > We've had several threads discussing potential cha

Re: [Ksummit-discuss] [PATCH 0/2] code of conduct fixes

2018-10-07 Thread Daniel Vetter
due deliberation. I'm travelling next week, so not the right guy to push this, but I'd be happy to ack such a patch (or something along the same lines). I also believe that this statement is undisputed enough that we can gather widespread support for it in the few days left until 4.19 ships to mak

Re: [Ksummit-discuss] [PATCH 1/2] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-07 Thread Daniel Vetter
g report through a private channel, or at least a channel that hides private address information (like Bugzilla does, albeit sloppily), then you do have to ask for explicit consent to publishing that information. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH] Add a skeleton Travis-CI config

2018-10-04 Thread Daniel Vetter
On Thu, Oct 4, 2018 at 9:11 PM Rob Herring wrote: > > On Thu, Oct 4, 2018 at 3:33 AM Daniel Vetter wrote: > > > > On Thu, Oct 4, 2018 at 12:27 AM Rob Herring wrote: > > > > > > It's convenient to use Travis-CI for doing kernel builds. Doing so > > &

Re: [PATCH] Add a skeleton Travis-CI config

2018-10-04 Thread Daniel Vetter
create mode 100644 .travis.yml > > diff --git a/.travis.yml b/.travis.yml > new file mode 100644 > index ..ba1e59dd44f6 > --- /dev/null > +++ b/.travis.yml > @@ -0,0 +1,23 @@ > +language: c > + > +sudo: false > +dist: trusty > + > +cache: > + apt: tr

Re: [PATCH] qxl: fix null-pointer crash during suspend

2018-10-02 Thread Daniel Vetter
()") Cc: # v4.14+ Reviewed-by: Daniel Vetter I'll let Gerd pick this one up, after some testing. Also adding Laurent. -Daniel > "crtc_funcs->disable" call would crash (resulting in suspend failure). > Fix this by converting the suspend/resume functions to use the > drm_

Re: [PATCH 2/4] vt: Remove vc_panic_force_write

2018-09-11 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 10:59:19AM +0200, Greg Kroah-Hartman wrote: > On Wed, Aug 22, 2018 at 10:54:03AM +0200, Daniel Vetter wrote: > > It was only used by the panic support in fbcon, which is now gone. > > Remove this now dead code too. > > > > Cc: Greg Kroah-Hartman

Re: [RFC PATCH v4 1/2] drm: Add generic colorkey properties for display planes

2018-08-14 Thread Daniel Vetter
bits) \ > > + DIV_ROUND_UP((u16)((ckey64) >> __drm_ckey_ ## comp_name ## _shift), \ > > +1 << (16 - (nbits))) > > As the divisor is a power of two, could we use masking instead of a division > ? > Or do you expect the compiler to optimize it properly ? > > > +#define __DRM_CKEY_CLAMP(value, nbits) \ > > + min_t(u16, (value), (1 << (nbits)) - 1) > > Would the following be simpler to read and a bit more efficient as it avoids > the division ? > > static inline u16 __drm_colorkey_extract_component(u64 ckey64, >unsigned int shift, >unsigned int nbits) > { > u16 mask = (1 << (16 - nbits)) - 1; > > return ((u16)(ckey >> shift) + mask) >> (16 - nbits); > } > > #define drm_colorkey_extract_component(ckey64, comp_name, nbits) \ > __drm_colorkey_extract_component(ckey64, __drm_ckey_ ## comp_name ## > _shift, nbits) > > > #endif > > -- > Regards, > > Laurent Pinchart > > > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 0/2] Fix connector probing deadlocks from RPM bugs

2018-08-06 Thread Daniel Vetter
rm_crtc_helper.h | 7 +++-- > include/drm/drm_fb_helper.h | 5 > 6 files changed, 67 insertions(+), 7 deletions(-) > > -- > 2.17.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] kernel.h: Add for_each_if()

2018-07-10 Thread Daniel Vetter
On Mon, Jul 09, 2018 at 04:30:01PM -0700, Andrew Morton wrote: > On Mon, 9 Jul 2018 18:25:09 +0200 Daniel Vetter > wrote: > > > To avoid compilers complainig about ambigious else blocks when putting > > an if condition into a for_each macro one needs to invert the > >

[PATCH 01/12] kernel.h: Add for_each_if()

2018-07-09 Thread Daniel Vetter
places. Motivated by a discussion with Andy and Yisheng, who want to add another for_each_macro which would benefit from for_each_if() instead of hand-rolling it. Signed-off-by: Daniel Vetter Cc: Gustavo Padovan Cc: Maarten Lankhorst Cc: Sean Paul Cc: David Airlie Cc: Andrew Morton Cc: Kees Cook

[PATCH 04/12] cpufreq: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the inverted condition compared to the open coded version. Signed-off-by: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org --- include/linux/cpufreq.h | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux

Re: [PATCH] drm/cirrus: flip default to 32bpp

2018-07-09 Thread Daniel Vetter
Nobody's using cirrus because they care > about color fidelity and it'll use less CPU to update. There's > precedent here, mgag200 defaults to 16bpp on sufficiently memory- > impaired devices. Yeah nouveau does the same fallback to 16bpp if there's not enough vram. So do a bunch of oth

Re: [PATCH 03/12] drm/dp: add helpers for drm_dp_set_adjust_request_pre_emphasis and drm_dp_set_adjust_request_voltage

2018-07-04 Thread Daniel Vetter
_status[DP_LINK_STATUS_SIZE], > +int lane, u8 volt); > +void drm_dp_set_adjust_request_pre_emphasis(u8 > link_status[DP_LINK_STATUS_SIZE], > + int lane, u8 pre_emphasis); > > #define DP_BRANCH_OUI_HEADER_SIZE

Re: [PATCH v7 00/29] Add support for mediatek SOC MT2712

2018-06-28 Thread Daniel Vetter
On Thu, Jun 28, 2018 at 11:45:37AM +0800, Stu Hsieh wrote: > Hi, Daniel Vetter: > > On Mon, 2018-06-25 at 10:47 +0200, Daniel Vetter wrote: > > On Wed, Jun 20, 2018 at 04:19:02PM +0800, Stu Hsieh wrote: > > > This patch add support for the Mediatek MT2712 DISP subsyst

Re: [PATCH] drm: Fix possible race conditions while unplugging DRM device

2018-05-29 Thread Daniel Vetter
henko > Reported-by: Andrii Chepurnyi > Cc: "Noralf Trønnes" Nice catch. Reviewed-by: Daniel Vetter I think you need to push this to drm-misc-next-fixes to make sure it's on the 4.17 train. -Daniel > --- > drivers/gpu/drm/drm_drv.c | 14 +++--- > 1 file changed,

Re: [PATCH] gpu: drm: drm_vm: Adding new typedef vm_fault_t

2018-05-29 Thread Daniel Vetter
vma; > >> struct drm_file *priv = vma->vm_file->private_data; > >> @@ -326,7 +326,7 @@ static int drm_vm_dma_fault(struct vm_fault *vmf) > >> * > >> * Determine the map offset from the page offset and get it from > >> drm_sg_mem::page

Re: [PATCH v2] drm: udl: Destroy framebuffer only if it was initialized

2018-05-29 Thread Daniel Vetter
ned-off-by: Emil Lundmark You lost the r-b from Sean when resending, I'll leave that to Sean to readd when he merges. Anyway, lgtm now with the more detailed explanation. Acked-by: Daniel Vetter > --- > Changes in v2: > - Updated commit message with explanation from Stéphane Marchesin &

Re: [PATCH] gpu: drm: vgem: Change return type to vm_fault_t

2018-05-29 Thread Daniel Vetter
On Thu, May 24, 2018 at 07:51:40PM +0530, Souptick Joarder wrote: > On Thu, May 24, 2018 at 6:27 PM, Daniel Vetter wrote: > > On Wed, May 23, 2018 at 03:05:35PM +0530, Souptick Joarder wrote: > >> On Mon, May 14, 2018 at 9:56 PM, Daniel Vetter wrote: > >> > On T

Re: [PATCH 7/8] drm/bridge: fix dependency for lvds-encoder

2018-05-28 Thread Daniel Vetter
help >DRM bridge wrapper of DRM panels > > Otherwise you'll potentially have to patch every user of DRM_PANEL_BRIDGE as > done in this patch. Select isn't recursive, so this won't work unfortunately :-/ -Daniel > -- > Regards, > > Laurent Pinchart > > > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH] gpu: drm: vgem: Change return type to vm_fault_t

2018-05-24 Thread Daniel Vetter
On Wed, May 23, 2018 at 03:05:35PM +0530, Souptick Joarder wrote: > On Mon, May 14, 2018 at 9:56 PM, Daniel Vetter <dan...@ffwll.ch> wrote: > > On Thu, May 10, 2018 at 02:51:38PM -0400, Sean Paul wrote: > >> On Thu, May 10, 2018 at 07:58:11PM +0530, Souptick Joard

Re: [PATCH v8 3/3] drm: writeback: Add client capability for exposing writeback connectors

2018-05-24 Thread Daniel Vetter
.h > > > +++ b/include/uapi/drm/drm.h > > > @@ -680,6 +680,15 @@ struct drm_get_cap { > > > */ > > > #define DRM_CLIENT_CAP_ATOMIC3 > > > > > > +/** > > > + * DRM_CLIENT_CAP_WRITEBACK_CONNECTORS > > > + * > > > + * If set to 1, the DRM core will expose special connectors to be used > > > for > > > + * writing back to memory the scene setup in the commit. Depends on > > > client > > > + * also supporting DRM_CLIENT_CAP_ATOMIC > > > + */ > > > +#define DRM_CLIENT_CAP_WRITEBACK_CONNECTORS 4 > > > + > > > /** DRM_IOCTL_SET_CLIENT_CAP ioctl argument type */ > > > struct drm_set_client_cap { > > > __u64 capability; > > > > ~Maarten > > > > -- > > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --- > ¯\_(ツ)_/¯ > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v2] gpu: drm: udl: Adding new typedef vm_fault_t

2018-05-23 Thread Daniel Vetter
_offset]; > >> - ret = vm_insert_page(vma, vmf->address, page); > >> - switch (ret) { > >> - case -EAGAIN: > >> - case 0: > >> - case -ERESTARTSYS: > >> - return VM_FAULT_NOPAGE; > >> - case -ENOMEM: > >> - return VM_FAULT_OOM; > >> - default: > >> - return VM_FAULT_SIGBUS; > >> - } > >> + return vmf_insert_page(vma, vmf->address, page); > >> } > >> > >> int udl_gem_get_pages(struct udl_gem_object *obj) > >> -- > >> 1.9.1 > >> > > > > Any comment on this patch ? > > If no comment, we would like to get this patch in queue > for 4.18. 4.18 is done already, queued up for 4.19 in drm-misc-next. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCHv2] drm/i2c: tda998x: Remove VLA usage

2018-05-23 Thread Daniel Vetter
ng I've already asked David to take, so that > should be a safe route for _this_ patch. Sounds reasonable, applied to drm-misc-next for 4.19 just to make sure it won't get lost. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/gma500: Remove VLA

2018-05-23 Thread Daniel Vetter
struct i2c_msg msgs[args_len + 3]; > > + u8 buf[MAX_ARG_LEN*2 + 2], status; > > + struct i2c_msg msgs[MAX_ARG_LEN + 3]; > > int i, ret; > > > > + if (args_len > MAX_ARG_LEN) { > > + DRM_ERROR("Need to increase arg l

Re: [PATCH 10/14] vgem: separate errno from VM_FAULT_* values

2018-05-16 Thread Daniel Vetter
return VM_FAULT_RETRY; > + case -EFAULT: > + case -EINVAL: > + return VM_FAULT_SIGBUS; > + default: > + WARN_ON(PTR_ERR(page)); > + return VM_FAULT_SIGBUS; > } > - return ret; Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Want me to merge this through drm-misc or plan to pick it up yourself? -Daniel > } > > static const struct vm_operations_struct vgem_gem_vm_ops = { > -- > 2.17.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/bridge: checkpatch strict minor updates

2018-05-16 Thread Daniel Vetter
On Tue, May 15, 2018 at 10:37:36PM +0200, Philippe Cornu wrote: > Minor fixes detected with "scripts/checkpatch.pl --strict" > > Signed-off-by: Philippe Cornu <philippe.co...@st.com> > --- > Detected when merging "drm: clarify adjusted_mode documentation f

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-16 Thread Daniel Vetter
On Tue, May 15, 2018 at 01:09:59PM +0200, Peter Rosin wrote: > On 2018-05-15 12:22, Daniel Vetter wrote: > > On Mon, May 14, 2018 at 10:40 PM, Peter Rosin <p...@axentia.se> wrote: > >> On 2018-05-14 18:28, Daniel Vetter wrote: > >>> On Fri, May 11, 2018 at

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-15 Thread Daniel Vetter
On Mon, May 14, 2018 at 10:40 PM, Peter Rosin <p...@axentia.se> wrote: > On 2018-05-14 18:28, Daniel Vetter wrote: >> On Fri, May 11, 2018 at 09:37:47AM +0200, Peter Rosin wrote: >>> On 2018-05-10 10:10, Andrzej Hajda wrote: >>>> On 04.05.2018 15:52, Peter Rosin

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-14 Thread Daniel Vetter
hip when using "<->", do you have a reference? > But I guess the different arrow notations in math are somewhat overloaded > and that someone at some point must have used "<->" to indicate a > symmetric relationship... Yeah I agree with Andrzej here, for me <-> implies a symmetric relationship. Spelling it out like Andrzej suggested sounds like the better idea. -Daniel > > > Anyway: > > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> > > Thanks! > > Cheers, > Peter > > >  -- > > Regards > > Andrzej > > > >> * @funcs: control functions > >> * @driver_private: pointer to the bridge driver's internal context > >> */ > >> @@ -271,6 +272,7 @@ struct drm_bridge { > >>struct drm_bridge *next; > >>struct list_head list; > >>const struct drm_bridge_timings *timings; > >> + struct device_link *link; > >> > >>const struct drm_bridge_funcs *funcs; > >>void *driver_private; > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] gpu: drm: vgem: Change return type to vm_fault_t

2018-05-14 Thread Daniel Vetter
ails, though, since vm_fault_t doesn't > exist in drm-misc-next yet. vm_fault_t is already in upstream, just needs Maarten to do a backmerge. Which I think he's done by now ... Otherwise nag him more :-) -Daniel > > So, for now, > > Reviewed-by: Sean Paul <seanp...@chromium.org> > > > -- > Sean Paul, Software Engineer, Google / Chromium OS > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 00/13] drm/kms/mode: using helper func drm_display_mode_to/from_videomode for calculating timing parameters

2018-05-13 Thread Daniel Vetter
On Wed, May 9, 2018 at 1:52 PM, Satendra Singh Thakur <satendr...@samsung.com> wrote: > On Thu, May 08, 2018 at 16:28:30 +0530, Satendra Singh Thakur wrote: >> On Thu, May 07, 2018 at 15:46:02 +0200, Daniel Vetter wrote: >> > On Thu, May 03, 2018 at 01:53:55PM +0530, Sat

Re: [PATCH] drm: Fix render node numbering regression from control node removal.

2018-05-12 Thread Daniel Vetter
till looking up at 128. > > Signed-off-by: Eric Anholt <e...@anholt.net> > Fixes: 0d49f303e8a7 ("drm: remove all control node code") > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Sean Paul <seanp...@chromium.org> Oops. > --- > include/drm/drm_f

Re: [Ksummit-discuss] bug-introducing patches

2018-05-09 Thread Daniel Vetter
ome linux-fixes branch for consumption by test bots. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [RFC PATCH] drm: Add per-plane pixel blend mode property

2018-05-09 Thread Daniel Vetter
the other comments too. Also would be good to again point at drm_plane_create_zpos_immutable_property() and related stuff. > + uint16_t pixel_blend_mode; > + > /* Plane rotation */ > unsigned int rotation; > > @@ -459,6 +464,7 @@ enum drm_plane_type { > * @state: current atomic state for this plane > * @zpos_property: zpos property for this plane > * @rotation_property: rotation property for this plane > + * @blend_mode_property: blend mode property for this plane > * @helper_private: mid-layer private data > */ > struct drm_plane { > @@ -506,6 +512,7 @@ struct drm_plane { > > struct drm_property *zpos_property; > struct drm_property *rotation_property; > + struct drm_property *blend_mode_property; > }; > > #define obj_to_plane(x) container_of(x, struct drm_plane, base) > -- > 1.9.1 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v2 10/26] drm/bridge: panel: provide an owner .odev device

2018-05-08 Thread Daniel Vetter
> > > I suggest assigning odev here to NULL or to master drm device itself. > > I'd rather not use NULL, since it is nice to be able to rely on the > .odev being there, and WARN if it isn't. > > Cheers, > Peter > > > Best regards, > > Jyri > > &g

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

2018-05-08 Thread Daniel Vetter
On Mon, May 07, 2018 at 04:24:43PM +0200, Peter Rosin wrote: > On 2018-05-07 15:59, Peter Rosin wrote: > > On 2018-05-07 15:39, Daniel Vetter wrote: > >> On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: > >>> On 2018-05-03 11:06, Daniel Vetter wrote: >

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

2018-05-08 Thread Daniel Vetter
On Mon, May 07, 2018 at 03:59:04PM +0200, Peter Rosin wrote: > On 2018-05-07 15:39, Daniel Vetter wrote: > > On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: > >> On 2018-05-03 11:06, Daniel Vetter wrote: > >>> On Wed, May 02, 2018 at 09:40

Re: [PATCH v2 00/26] device link, bridge supplier <-> drm device

2018-05-07 Thread Daniel Vetter
/rockchip_lvds.c | 2 +- > drivers/gpu/drm/sti/sti_dvo.c | 2 +- > drivers/gpu/drm/sti/sti_hda.c | 1 + > drivers/gpu/drm/sti/sti_hdmi.c | 1 + > include/drm/drm_bridge.h | 8 +++ > 30 files changed, 57 insertions(+), 36 deletions(-) > > -- > 2.11.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-07 Thread Daniel Vetter
m_bridge.h > > index b656e505d11e..804189c63a4c 100644 > > --- a/include/drm/drm_bridge.h > > +++ b/include/drm/drm_bridge.h > > @@ -261,6 +261,7 @@ struct drm_bridge_timings { > > * @list: to keep track of all added bridges > > * @timings: the timing specification for the bridge, if any (may > > * be NULL) > > + * @link: drm consumer <-> bridge supplier > > * @funcs: control functions > > * @driver_private: pointer to the bridge driver's internal context > > */ > > @@ -271,6 +272,7 @@ struct drm_bridge { > > struct drm_bridge *next; > > struct list_head list; > > const struct drm_bridge_timings *timings; > > + struct device_link *link; > > > > const struct drm_bridge_funcs *funcs; > > void *driver_private; > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 00/13] drm/kms/mode: using helper func drm_display_mode_to/from_videomode for calculating timing parameters

2018-05-07 Thread Daniel Vetter
c/tilcdc_crtc.c| 60 +- > 15 files changed, 280 insertions(+), 390 deletions(-) > > -- > 2.7.4 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

2018-05-07 Thread Daniel Vetter
On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: > On 2018-05-03 11:06, Daniel Vetter wrote: > > On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: > >> The more natural approach would perhaps be to add an drm_bridge_add, > >> but there are sever

[PATCH] backlight: remove obsolete comment for ->state

2018-05-03 Thread Daniel Vetter
Jani spotted this when reviewing my earlier patch to remove the driver internal usage of this field in commit 3cf91adaa594e8933af1727942ac560e5c7bc70e Author: Daniel Vetter <daniel.vet...@ffwll.ch> Date: Wed Apr 25 19:42:52 2018 +0200 backlight: Nuke BL_CORE_DRIVER1 Cc: Jani

Re: [PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-03 Thread Daniel Vetter
On Thu, May 03, 2018 at 01:55:03PM +0300, Ville Syrjälä wrote: > On Thu, May 03, 2018 at 11:24:59AM +0200, Daniel Vetter wrote: > > On Thu, May 03, 2018 at 11:19:32AM +0530, Satendra Singh Thakur wrote: > > > In the func drm_atomic_set_crtc_for_plane, with the current c

Re: [PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-03 Thread Daniel Vetter
plane_state->crtc); > -- > 2.7.4 > > _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

2018-05-03 Thread Daniel Vetter
r_sysfs: > - drm_bridge_remove(bridge); > hdmi->drm_connector = NULL; > return -EINVAL; > } > -- > 2.11.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] swiotlb: Fix inversed DMA_ATTR_NO_WARN test

2018-05-02 Thread Daniel Vetter
dev_warn(dev, >> "swiotlb: coherent allocation failed, size=%zu\n", >> size); > > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH] gpu: drm: sti: fix spelling mistake: "initialze" -> "initialize"

2018-05-02 Thread Daniel Vetter
if (res) { > - DRM_ERROR("Can't initialze CRTC\n"); > + DRM_ERROR("Can't initialize CRTC\n"); > return -EINVAL; > } > > -- > 2.17.0 > > ___ > dri-devel mailing list >

Re: [PATCH] input/psmouse: Don't hold the mutex while calling ->disconnect

2018-05-02 Thread Daniel Vetter
On Mon, Apr 30, 2018 at 11:17 PM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > Hi Daniel, > > On Mon, Apr 30, 2018 at 09:56:49PM +0200, Daniel Vetter wrote: >> At least trackpoint_disconnect wants to remove some sysfs files, and >> we can't remove sysfs files

Re: [Ksummit-discuss] bug-introducing patches

2018-05-02 Thread Daniel Vetter
But given the huge scope of the kernel we'll never reach 100%, and oddball regressions will be inevitable. Once a regression has crept through it imo really should get fixed asap, with no unecessary soaking times - get a better CI/kerneltests in place if you feel like you need to soak stuff. -Da

[PATCH] doc: botching-up-ioctls: Make it clearer why structs must be padded

2018-05-02 Thread Daniel Vetter
This came up in discussions when reviewing drm patches. Cc: Eric Anholt <e...@anholt.net> Cc: linux-...@vger.kernel.org Cc: Jonathan Corbet <cor...@lwn.net> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> -- Aside: I wonder whether we shouldn't move this to some other

Re: [PATCH] v3d: fixup for submit alignment and check for zero flags in other ioctls.

2018-05-02 Thread Daniel Vetter
m.h > +++ b/include/uapi/drm/v3d_drm.h > @@ -101,6 +101,9 @@ struct drm_v3d_submit_cl { > > /* Number of BO handles passed in (size is that times 4). */ > __u32 bo_handle_count; > + > + /* Pad, must be zero-filled. */ > + __u32 pad; > }; > > /** > -- > 2.17.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

[PATCH] input/psmouse: Don't hold the mutex while calling ->disconnect

2018-04-30 Thread Daniel Vetter
onnect+0x8f/0x160 serio_disconnect_driver+0x28/0x40 serio_driver_remove+0xc/0x10 device_release_driver_internal+0x15b/0x230 serio_handle_event+0x1c8/0x260 process_one_work+0x215/0x620 worker_thread+0x48/0x3a0 ? _raw_spin_unlock_irqrestore+0x4c/0x60 kthread+0xfb/0x130 ? process_one_work+0x620/0x620 ? _kthre

Re: [PATCH 24/24] drm/bridge: establish a link between the bridge supplier and consumer

2018-04-30 Thread Daniel Vetter
stent bridge supplier. > > Signed-off-by: Peter Rosin <p...@axentia.se> Minus the ->owner bikeshed I brought up in the previous patch I agree with this approach as the best way to move forward for now. Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> One small suggestion below, f

Re: [PATCH 23/24] drm/bridge: require the .owner to be filled in on drm_bridge_attach

2018-04-30 Thread Daniel Vetter
> + > if (previous && (!previous->dev || previous->encoder != encoder)) > return -EINVAL; > > -- > 2.11.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 00/24] device link, bridge supplier <-> drm device

2018-04-30 Thread Daniel Vetter
dmi_bridge.c | 1 + > > drivers/gpu/drm/rcar-du/rcar_lvds.c| 2 +- > > drivers/gpu/drm/sti/sti_dvo.c | 2 +- > > drivers/gpu/drm/sti/sti_hda.c | 1 + > > drivers/gpu/drm/sti/sti_hdmi.c | 1 + > > include/drm/drm_bridge.h | 8 > > 27 files changed, 51 insertions(+), 33 deletions(-) > > > -- > Regards, > > Laurent Pinchart > > > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 0/3] fbdev/drm: sh_mobile: remove unused MERAM support

2018-04-27 Thread Daniel Vetter
/video/sh_mobile_lcdc.h | 3 - >> include/video/sh_mobile_meram.h| 95 >> 15 files changed, 1 insertion(+), 993 deletions(-) >> delete mode 100644 drivers/video/fbdev/sh_mobile_meram.c >> delete mode 100644 include/video/sh_mobile_meram.h &

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-26 Thread Daniel Vetter
7 @@ static int vc4_drm_bind(struct device *dev) > vc4_gem_destroy(drm); > vc4_bo_cache_destroy(drm); > dev_unref: > - drm_dev_unref(drm); > + drm_dev_put(drm); > return ret; > } > > @@ -327,7 +327,7 @@ static void vc4_drm_unbind(struct device *dev) > > drm_mode_config_cleanup(drm); > > - drm_dev_unref(drm); > + drm_dev_put(drm); > } > > static const struct component_master_ops vc4_drm_ops = { > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c > index 2524ff116f00..305f87665499 100644 > --- a/drivers/gpu/drm/vgem/vgem_drv.c > +++ b/drivers/gpu/drm/vgem/vgem_drv.c > @@ -505,7 +505,7 @@ static int __init vgem_init(void) > static void __exit vgem_exit(void) > { > drm_dev_unregister(_device->drm); > - drm_dev_unref(_device->drm); > + drm_dev_put(_device->drm); > } > > module_init(vgem_init); > diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > index 7df8d0c9026a..094b876f6da6 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > +++ b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > @@ -85,6 +85,6 @@ int drm_virtio_init(struct drm_driver *driver, struct > virtio_device *vdev) > return 0; > > err_free: > - drm_dev_unref(dev); > + drm_dev_put(dev); > return ret; > } > diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c > b/drivers/gpu/drm/zte/zx_drm_drv.c > index 6f4205e80378..02ae1caf6e8a 100644 > --- a/drivers/gpu/drm/zte/zx_drm_drv.c > +++ b/drivers/gpu/drm/zte/zx_drm_drv.c > @@ -122,7 +122,7 @@ static int zx_drm_bind(struct device *dev) > component_unbind_all(dev, drm); > out_unregister: > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > return ret; > } > > @@ -136,7 +136,7 @@ static void zx_drm_unbind(struct device *dev) > drm_mode_config_cleanup(drm); > component_unbind_all(dev, drm); > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > } > > static const struct component_master_ops zx_drm_master_ops = { > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index d23dcdd1bd95..c16dd4424b8a 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -622,7 +622,6 @@ void drm_dev_unregister(struct drm_device *dev); > > void drm_dev_get(struct drm_device *dev); > void drm_dev_put(struct drm_device *dev); > -void drm_dev_unref(struct drm_device *dev); > void drm_put_dev(struct drm_device *dev); > void drm_dev_unplug(struct drm_device *dev); > > -- > 2.14.1 > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm: udl: Destroy framebuffer only if it was initialized

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 12:56 AM, Stéphane Marchesin <stephane.marche...@gmail.com> wrote: > On Tue, Apr 24, 2018 at 6:04 AM, Daniel Vetter <dan...@ffwll.ch> wrote: >> On Fri, Apr 20, 2018 at 09:55:32AM -0400, Sean Paul wrote: >>> On Fri, Apr 20, 2018 at 01:50:0

Re: noveau vs arm dma ops

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 11:09 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Wed, Apr 25, 2018 at 11:35:13PM +0200, Daniel Vetter wrote: >> > get_required_mask() is supposed to tell you if you are safe. However >> > we are missing lots of implementations of it

Re: [Linaro-mm-sig] noveau vs arm dma ops

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 11:24 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Thu, Apr 26, 2018 at 11:20:44AM +0200, Daniel Vetter wrote: >> The above is already what we're implementing in i915, at least >> conceptually (it all boils down to clflush instructions

Re: [Linaro-mm-sig] noveau vs arm dma ops

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 12:54 AM, Russell King - ARM Linux <li...@armlinux.org.uk> wrote: > On Wed, Apr 25, 2018 at 08:33:12AM -0700, Christoph Hellwig wrote: >> On Wed, Apr 25, 2018 at 12:04:29PM +0200, Daniel Vetter wrote: >> > - dma api hides the cache flushing require

Re: noveau vs arm dma ops

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 1:26 AM, Russell King - ARM Linux <li...@armlinux.org.uk> wrote: > On Wed, Apr 25, 2018 at 11:35:13PM +0200, Daniel Vetter wrote: >> On arm that doesn't work. The iommu api seems like a good fit, except >> the dma-api tends to get in the way a bit (d

Re: noveau vs arm dma ops

2018-04-25 Thread Daniel Vetter
On Wed, Apr 25, 2018 at 5:33 PM, Christoph Hellwig <h...@infradead.org> wrote: > On Wed, Apr 25, 2018 at 12:04:29PM +0200, Daniel Vetter wrote: >> > Coordinating the backport of a trivial helper in the arm tree is not >> > the end of the world. Really, this cowbo

[PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-04-25 Thread Daniel Vetter
a <meghana.madhyas...@gmail.com> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- include/linux/backlight.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/backlight.h b/include/linux/backlight.h ind

[PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-04-25 Thread Daniel Vetter
: Jingoo Han <jingooh...@gmail.com> Cc: Thomas Petazzoni <thomas.petazz...@free-electrons.com> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- drivers/staging/fbtft/fbtft-core.c | 4 ++-- drivers/staging/fbtft/fb

[PATCH 3/6] backlight/pandora: Stop using BL_CORE_DRIVER1

2018-04-25 Thread Daniel Vetter
Han <jingooh...@gmail.com> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- v2: - Consistently treating PANDORA_WAS_OFF as a non-bitfield - Drop the kfree that I left behind after switching to devm_kmalloc --- driver

[PATCH 6/6] MAINTAINERS: add dri-devel for backlight subsystem patches

2018-04-25 Thread Daniel Vetter
. Cc: Lee Jones <lee.jo...@linaro.org> Cc: Daniel Thompson <daniel.thomp...@linaro.org> Cc: Jingoo Han <jingooh...@gmail.com> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Acked-by: Jingoo Han <jingooh...@gmail.com> Signed-off-by: Daniel Vetter <daniel.vet..

[PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1

2018-04-25 Thread Daniel Vetter
iel.thomp...@linaro.org> Cc: Jingoo Han <jingooh...@gmail.com> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- include/linux/backlight.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/backlight

[PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

2018-04-25 Thread Daniel Vetter
Nothing in the entire tree ever sets this, which means this is dead code. Remove it. Cc: Lee Jones <lee.jo...@linaro.org> Cc: Daniel Thompson <daniel.thomp...@linaro.org> Cc: Jingoo Han <jingooh...@gmail.com> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Sign

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

2018-04-25 Thread Daniel Vetter
On Wed, Apr 25, 2018 at 3:22 PM, Oleg Nesterov <o...@redhat.com> wrote: > On 04/24, Daniel Vetter wrote: >> >> wait_event_killabel doesn't check for fatal_signal_pending before calling >> schedule, so definitely has a nice race there. > > This is fine. See

Re: [PATCH v3 5/5] drm/arm/malidp: Added the late system pm functions

2018-04-25 Thread Daniel Vetter
On Wed, Apr 25, 2018 at 1:26 PM, Liviu Dudau <liviu.du...@arm.com> wrote: > On Wed, Apr 25, 2018 at 09:17:22AM +0200, Daniel Vetter wrote: >> On Tue, Apr 24, 2018 at 07:12:47PM +0100, Ayan Kumar Halder wrote: >> > malidp_pm_suspend_late checks if the runtime status is not

Re: noveau vs arm dma ops

2018-04-25 Thread Daniel Vetter
t; was just enabled unconditionally if it has side-effects that platforms > > don't opt in to but have to explicitly opt out of. > > Agreed on that count. Please send a patch. -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] input/psmouse: Don't hold the mutex while calling ->disconnect

2018-04-25 Thread Daniel Vetter
Ping. -Daniel On Tue, Mar 20, 2018 at 9:51 AM, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > At least trackpoint_disconnect wants to remove some sysfs files, and > we can't remove sysfs files while holding psmouse_mutex: > > ==

Re: [PATCH] drm/virtio: fix mode_valid's return type

2018-04-25 Thread Daniel Vetter
> dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-25 Thread Daniel Vetter
On Wed, Apr 25, 2018 at 12:09:05AM -0700, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 09:02:17AM +0200, Daniel Vetter wrote: > > Can we please not nack everything right away? Doesn't really motivate > > me to show you all the various things we're doing in gpu to make the >

Re: [PATCH v3 5/5] drm/arm/malidp: Added the late system pm functions

2018-04-25 Thread Daniel Vetter
T_LATE_SYSTEM_SLEEP_PM_OPS(malidp_pm_suspend_late, > malidp_pm_resume_early) \ > SET_RUNTIME_PM_OPS(malidp_runtime_pm_suspend, malidp_runtime_pm_resume, > NULL) > }; > > -- > 2.7.4 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

2018-04-25 Thread Daniel Vetter
On Tue, Apr 24, 2018 at 05:37:08PM -0400, Andrey Grodzovsky wrote: > > > On 04/24/2018 05:21 PM, Eric W. Biederman wrote: > > Andrey Grodzovsky <andrey.grodzov...@amd.com> writes: > > > > > On 04/24/2018 03:44 PM, Daniel Vetter wrote: > > > >

Re: [PATCH] drm/udl: fix mode_valid's return type

2018-04-25 Thread Daniel Vetter
ctor *connector) > return 0; > } > > -static int udl_mode_valid(struct drm_connector *connector, > +static enum drm_mode_status udl_mode_valid(struct drm_connector *connector, > struct drm_display_mode *mode) > { > struct udl_device

Re: [PATCH] drm/bridge: adv7511: fix mode_valid's return type

2018-04-25 Thread Daniel Vetter
v7511, struct > drm_connector *connector) > return status; > } > > -static int adv7511_mode_valid(struct adv7511 *adv7511, > +static enum drm_mode_status adv7511_mode_valid(struct adv7511 *adv7511, > struct drm_display_mode *mode) >

Re: [PATCH] drm/ast: fix mode_valid's return type

2018-04-25 Thread Daniel Vetter
atic int ast_mode_valid(struct drm_connector *connector, > +static enum drm_mode_status ast_mode_valid(struct drm_connector *connector, > struct drm_display_mode *mode) > { > struct ast_private *ast = connector->dev->dev_private; > -- > 2.17.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-25 Thread Daniel Vetter
On Wed, Apr 25, 2018 at 8:43 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Wed, Apr 25, 2018 at 08:23:15AM +0200, Daniel Vetter wrote: >> For more fun: >> >> https://www.spinics.net/lists/dri-devel/msg173630.html >> >> Yeah, sometimes we want

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-25 Thread Daniel Vetter
a-buf interface spec. -Daniel > > thanks, > > DW > Thank you, > Oleksandr > > On Tue, Apr 24, 2018 at 02:59:39PM +0300, Oleksandr Andrushchenko wrote: > > > On 04/24/2018 02:54 PM, Daniel Vetter wrote: > > > > On Mon, Apr 23, 2018 at 03:10:35

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-25 Thread Daniel Vetter
On Wed, Apr 25, 2018 at 8:13 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Apr 25, 2018 at 7:48 AM, Christoph Hellwig <h...@infradead.org> wrote: >> On Tue, Apr 24, 2018 at 09:32:20PM +0200, Daniel Vetter wrote: >>> Out of curiosity, how much virtual flu

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-25 Thread Daniel Vetter
On Wed, Apr 25, 2018 at 7:48 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Tue, Apr 24, 2018 at 09:32:20PM +0200, Daniel Vetter wrote: >> Out of curiosity, how much virtual flushing stuff is there still out >> there? At least in drm we've pretty much ignore this, and

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

2018-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2018 at 05:02:40PM -0400, Andrey Grodzovsky wrote: > > > On 04/24/2018 03:44 PM, Daniel Vetter wrote: > > On Tue, Apr 24, 2018 at 05:46:52PM +0200, Michel Dänzer wrote: > > > Adding the dri-devel list, since this is driver independent code. > > >

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

2018-04-24 Thread Daniel Vetter
ill return immediately when there's a signal pending. I think this should be fixed in core code, not papered over in some subsystem. -Daniel > > > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2018 at 8:48 PM, Christoph Hellwig <h...@infradead.org> wrote: > On Fri, Apr 20, 2018 at 05:21:11PM +0200, Daniel Vetter wrote: >> > At the very lowest level they will need to be handled differently for >> > many architectures, the question

Re: [PATCH 0/1] drm: Add crtc_queue_syncobj and crtc_get_syncobj ioctls

2018-04-24 Thread Daniel Vetter
On Mon, Apr 09, 2018 at 11:14:17AM +0200, Daniel Vetter wrote: > On Fri, Apr 06, 2018 at 04:56:48PM -0700, Keith Packard wrote: > > (This is an RFC on whether this pair of ioctls seems reasonable. The > > code compiles, but I haven't tested it as I'm away from home this > > w

Re: [PATCH v2 1/3] drm: Make the prime vmap/vunmap hooks optional.

2018-04-24 Thread Daniel Vetter
On Mon, Apr 23, 2018 at 05:46:08PM -0700, Eric Anholt wrote: > Some drivers leave these unimplemented, so don't make them have > unimplemented stubs. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> > --- > d

Re: [PATCH] drm: udl: Destroy framebuffer only if it was initialized

2018-04-24 Thread Daniel Vetter
> int udl_fbdev_init(struct drm_device *dev) > > -- > > 2.17.0.484.g0c8726318c-goog > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 2/2] drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+

2018-04-24 Thread Daniel Vetter
On Fri, Apr 20, 2018 at 04:42:48PM -0700, Eric Anholt wrote: > Daniel Vetter <dan...@ffwll.ch> writes: > > > On Thu, Apr 19, 2018 at 12:20:35PM -0700, Eric Anholt wrote: > >> This driver will be used to support Mesa on the Broadcom 7268 and 7278 > >> plat

  1   2   3   4   5   6   7   8   9   10   >