[PATCH 2/2] Bluetooth: Do not set cur_adv_instance in adv param MGMT request

2021-04-05 Thread Daniel Winkler
o confirm that it resolves the race condition on registration, and that there is no regression in single- and multi-advertising automated tests. Reviewed-by: Miao-chen Chou Signed-off-by: Daniel Winkler --- net/bluetooth/mgmt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bluetooth/mgm

[PATCH 1/2] Bluetooth: Use ext adv handle from requests in CCs

2021-04-05 Thread Daniel Winkler
ulti-advertising automated tests to confirm callbacks report tx power to the correct advertising handle, etc. Reviewed-by: Miao-chen Chou Signed-off-by: Daniel Winkler --- net/bluetooth/hci_event.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/net/bluetooth/h

[PATCH 0/2] Bluetooth: Avoid centralized adv handle tracking for extended features

2021-04-05 Thread Daniel Winkler
ing automated test scenarios are still successful. Thanks in advance, Daniel Daniel Winkler (2): Bluetooth: Use ext adv handle from requests in CCs Bluetooth: Do not set cur_adv_instance in adv param MGMT request net/bluetooth/hci_event.c | 16 +++- net/bluetooth/mgmt.c | 1 -

Re: [PATCH v2] Bluetooth: Always call advertising disable before setting params

2021-03-29 Thread Daniel Winkler
dvertising active when the disable request is submitted. This patch regresses advertising on these platforms, so I will look into a different approach to solve this race condition. Best, Daniel Winkler On Thu, Mar 25, 2021 at 10:27 AM Daniel Winkler wrote: > > Hi all, > > It looks

Re: [PATCH v2] Bluetooth: Always call advertising disable before setting params

2021-03-25 Thread Daniel Winkler
this race condition, so if the maintainers are happy with it, I can look into changing the test expectations to suit the new scenario. Please advise. Thanks in advance, Daniel On Wed, Mar 24, 2021 at 11:47 AM Daniel Winkler wrote: > > In __hci_req_enable_advertising, the HCI_LE_ADV hde

Re: [PATCH] Bluetooth: Always call advertising disable before setting params

2021-03-24 Thread Daniel Winkler
allowed error, failing the registration. > > > > To resolve the issue, this patch removes the check for the HCI_LE_ADV > > flag, and always queues the "disable" request, since HCI_LE_ADV could be > > very temporarily out-of-sync. According to the spec, there is no harm in >

[PATCH v2] Bluetooth: Always call advertising disable before setting params

2021-03-24 Thread Daniel Winkler
from Any (0x00) > HCI Event: Command Complete (0x0e) plen 4 #232 [hci0]04:06.005 LE Set Advertising Parameters (0x08|0x0006) ncmd 1 Status: Command Disallowed (0x0c) Reviewed-by: Miao-chen Chou Signed-off-by: Daniel Winkler --- Changes in v2: - Added btmon snippet showi

[PATCH] Bluetooth: Always call advertising disable before setting params

2021-03-23 Thread Daniel Winkler
ctive. Reviewed-by: Miao-chen Chou Signed-off-by: Daniel Winkler --- net/bluetooth/hci_request.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c index 8ace5d34b01efe..2b4b99f4cedf21 100644 --- a/net/bluetooth/hci_

[PATCH] Bluetooth: Allow scannable adv with extended MGMT APIs

2021-03-03 Thread Daniel Winkler
and registered it on the hatch chromebook. Without this change, the request fails, and with it will succeed. Reviewed-by: Alain Michaud Reviewed-by: Sonny Sasaka Reviewed-by: Miao-chen Chou Signed-off-by: Daniel Winkler --- include/net/bluetooth/mgmt.h | 1 + net/bluetooth/hci_request.c | 3

Re: [PATCH v6 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-12-03 Thread Daniel Winkler
orrectness of parameters/data in btmon traces, and our automated test > > suite of 25 single- and multi-advertising usage scenarios. > > > > A separate patch series will add support in bluetoothd. Thanks in > > advance for your feedback! > > > > Daniel Winkler >

[PATCH v7 5/5] Bluetooth: Change MGMT security info CMD to be more generic

2020-12-03 Thread Daniel Winkler
power into this newly-named command. The change was tested by manually verifying that the MGMT command returns the tx power range as expected in userspace. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v7: - Rebase onto bluetooth-next/master Changes in v6: - Only populate

[PATCH v7 4/5] Bluetooth: Query LE tx power on startup

2020-12-03 Thread Daniel Winkler
BT5 devices correctly query and receive controller tx power range. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None include/net/bluetooth/hci.h | 7 +++ incl

[PATCH v7 3/5] Bluetooth: Use intervals and tx power from mgmt cmds

2020-12-03 Thread Daniel Winkler
are performed with multiple advertisements simultaneously. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None include/net/bluetooth/hci_core.h | 5 - net/bluetooth

[PATCH v7 2/5] Bluetooth: Break add adv into two mgmt commands

2020-12-03 Thread Daniel Winkler
rrect data and parameters in btmon trace - Verified both for software rotation and extended adv Automatic test suite also run, testing many (25) scenarios of single and multi-advertising for data/parameter correctness. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v7: None Changes i

[PATCH v7 1/5] Bluetooth: Add helper to set adv data

2020-12-03 Thread Daniel Winkler
We wish to handle advertising data separately from advertising parameters in our new MGMT requests. This change adds a helper that allows the advertising data and scan response to be updated for an existing advertising instance. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler

[PATCH v7 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-12-03 Thread Daniel Winkler
nges in v2: - Fixed sparse error in Capabilities MGMT command Daniel Winkler (5): Bluetooth: Add helper to set adv data Bluetooth: Break add adv into two mgmt commands Bluetooth: Use intervals and tx power from mgmt cmds Bluetooth: Query LE tx power on startup Bluetooth: Change MGMT securit

[PATCH v6 1/5] Bluetooth: Add helper to set adv data

2020-11-30 Thread Daniel Winkler
We wish to handle advertising data separately from advertising parameters in our new MGMT requests. This change adds a helper that allows the advertising data and scan response to be updated for an existing advertising instance. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler

[PATCH v6 4/5] Bluetooth: Query LE tx power on startup

2020-11-30 Thread Daniel Winkler
BT5 devices correctly query and receive controller tx power range. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None include/net/bluetooth/hci.h | 7 +++ include/net/blueto

[PATCH v6 5/5] Bluetooth: Change MGMT security info CMD to be more generic

2020-11-30 Thread Daniel Winkler
power into this newly-named command. The change was tested by manually verifying that the MGMT command returns the tx power range as expected in userspace. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v6: - Only populate LE tx power range if controller reports it Changes

[PATCH v6 3/5] Bluetooth: Use intervals and tx power from mgmt cmds

2020-11-30 Thread Daniel Winkler
are performed with multiple advertisements simultaneously. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None include/net/bluetooth/hci_core.h | 5 - net/bluetooth/hci_core.c | 8

[PATCH v6 2/5] Bluetooth: Break add adv into two mgmt commands

2020-11-30 Thread Daniel Winkler
rrect data and parameters in btmon trace - Verified both for software rotation and extended adv Automatic test suite also run, testing many (25) scenarios of single and multi-advertising for data/parameter correctness. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v6: None Cha

[PATCH v6 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-11-30 Thread Daniel Winkler
MT command Daniel Winkler (5): Bluetooth: Add helper to set adv data Bluetooth: Break add adv into two mgmt commands Bluetooth: Use intervals and tx power from mgmt cmds Bluetooth: Query LE tx power on startup Bluetooth: Change MGMT security info CMD to be more generic include/net/bluet

Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-11-24 Thread Daniel Winkler
matting, etc, we > should be able to test, also tester supports the concept of 'not run' > which we can probably use for experimental commands. > > > Thanks, > > Daniel > > > > On Thu, Oct 29, 2020 at 5:04 PM Luiz Augusto von Dentz > > wrote: > > > > &

[PATCH v5 2/5] Bluetooth: Break add adv into two mgmt commands

2020-11-24 Thread Daniel Winkler
rrect data and parameters in btmon trace - Verified both for software rotation and extended adv Automatic test suite also run, testing many (25) scenarios of single and multi-advertising for data/parameter correctness. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v5: - Ensure dat

[PATCH v5 1/5] Bluetooth: Add helper to set adv data

2020-11-24 Thread Daniel Winkler
We wish to handle advertising data separately from advertising parameters in our new MGMT requests. This change adds a helper that allows the advertising data and scan response to be updated for an existing advertising instance. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler

[PATCH v5 4/5] Bluetooth: Query LE tx power on startup

2020-11-24 Thread Daniel Winkler
BT5 devices correctly query and receive controller tx power range. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None include/net/bluetooth/hci.h | 7 +++ include/net/bluetooth/hci_core.h | 2 ++

[PATCH v5 5/5] Bluetooth: Change MGMT security info CMD to be more generic

2020-11-24 Thread Daniel Winkler
power into this newly-named command. The change was tested by manually verifying that the MGMT command returns the tx power range as expected in userspace. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v5: None Changes in v4: - Combine LE tx range into a single EIR field

[PATCH v5 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-11-24 Thread Daniel Winkler
o extended advertising) chromebooks with manual testing verifying correctness of parameters/data in btmon traces, and our automated test suite of 25 single- and multi-advertising usage scenarios. A separate patch series will add support in bluetoothd. Thanks in advance for your feedback! Daniel Winkler

[PATCH v5 3/5] Bluetooth: Use intervals and tx power from mgmt cmds

2020-11-24 Thread Daniel Winkler
are performed with multiple advertisements simultaneously. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None include/net/bluetooth/hci_core.h | 5 - net/bluetooth/hci_core.c | 8 +--- net

[PATCH] Bluetooth: Resume advertising after LE connection

2020-11-06 Thread Daniel Winkler
an advertisement, initiating an LE connection from a remote peer, and verifying that the advertisement is re-activated after the connection is established. This is performed on Hatch and Kukui Chromebooks. Reviewed-by: Abhishek Pandit-Subedi Signed-off-by: Daniel Winkler --- net/bluetooth

Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-11-03 Thread Daniel Winkler
forward? Or can we land the changes based on the testing I have already done and I'll work on these tests in parallel? Thanks, Daniel On Thu, Oct 29, 2020 at 5:04 PM Luiz Augusto von Dentz wrote: > > Hi Daniel, > > On Thu, Oct 29, 2020 at 3:25 PM Daniel Winkler > wrote:

Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-10-29 Thread Daniel Winkler
tested with manual and automated functional testing on our end. Please let me know your thoughts. Thanks, Daniel On Thu, Oct 29, 2020 at 2:45 PM Luiz Augusto von Dentz wrote: > > Hi Daniel, > > On Thu, Oct 29, 2020 at 2:35 PM Daniel Winkler > wrote: > > > > Hell

Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-10-29 Thread Daniel Winkler
for your time! Best regards, Daniel Winkler On Thu, Oct 1, 2020 at 4:04 PM Daniel Winkler wrote: > > Hi Maintainers, > > This patch series defines the new two-call MGMT interface for adding > new advertising instances. Similarly to the hci advertising commands, a > mgmt call

[PATCH v4 3/5] Bluetooth: Use intervals and tx power from mgmt cmds

2020-10-01 Thread Daniel Winkler
are performed with multiple advertisements simultaneously. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v4: None Changes in v3: None Changes in v2: None include/net/bluetooth/hci_core.h | 5 - net/bluetooth/hci_core.c | 8 +--- net/bluetooth/hci_request.c

[PATCH v4 5/5] Bluetooth: Change MGMT security info CMD to be more generic

2020-10-01 Thread Daniel Winkler
power into this newly-named command. The change was tested by manually verifying that the MGMT command returns the tx power range as expected in userspace. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v4: - Combine LE tx range into a single EIR field for MGMT capabilities

[PATCH v4 4/5] Bluetooth: Query LE tx power on startup

2020-10-01 Thread Daniel Winkler
BT5 devices correctly query and receive controller tx power range. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v4: None Changes in v3: None Changes in v2: None include/net/bluetooth/hci.h | 7 +++ include/net/bluetooth/hci_core.h | 2 ++ net/bluetooth/hci_cor

[PATCH v4 2/5] Bluetooth: Break add adv into two mgmt commands

2020-10-01 Thread Daniel Winkler
rrect data and parameters in btmon trace - Verified both for software rotation and extended adv Automatic test suite also run, testing many (25) scenarios of single and multi-advertising for data/parameter correctness. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v4: - Add rema

[PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-10-01 Thread Daniel Winkler
o extended advertising) chromebooks with manual testing verifying correctness of parameters/data in btmon traces, and our automated test suite of 25 single- and multi-advertising usage scenarios. A separate patch series will add support in bluetoothd. Thanks in advance for your feedback! Daniel Winkler

[PATCH v4 1/5] Bluetooth: Add helper to set adv data

2020-10-01 Thread Daniel Winkler
We wish to handle advertising data separately from advertising parameters in our new MGMT requests. This change adds a helper that allows the advertising data and scan response to be updated for an existing advertising instance. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler

[PATCH v3 5/5] Bluetooth: Change MGMT security info CMD to be more generic

2020-09-24 Thread Daniel Winkler
power into this newly-named command. The change was tested by manually verifying that the MGMT command returns the tx power range as expected in userspace. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v3: - Re-using security info MGMT command to carry controller

[PATCH v3 2/5] Bluetooth: Break add adv into two mgmt commands

2020-09-24 Thread Daniel Winkler
rrect data and parameters in btmon trace - Verified both for software rotation and extended adv Automatic test suite also run, testing many (25) scenarios of single and multi-advertising for data/parameter correctness. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v3: - Adding s

[PATCH v3 4/5] Bluetooth: Query LE tx power on startup

2020-09-24 Thread Daniel Winkler
BT5 devices correctly query and receive controller tx power range. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v3: None Changes in v2: None include/net/bluetooth/hci.h | 7 +++ include/net/bluetooth/hci_core.h | 2 ++ net/bluetooth/hci_core.c |

[PATCH v3 1/5] Bluetooth: Add helper to set adv data

2020-09-24 Thread Daniel Winkler
We wish to handle advertising data separately from advertising parameters in our new MGMT requests. This change adds a helper that allows the advertising data and scan response to be updated for an existing advertising instance. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler

[PATCH v3 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-09-24 Thread Daniel Winkler
o extended advertising) chromebooks with manual testing verifying correctness of parameters/data in btmon traces, and our automated test suite of 25 single- and multi-advertising usage scenarios. A separate patch series will add support in bluetoothd. Thanks in advance for your feedback! Daniel Winkler

[PATCH v3 3/5] Bluetooth: Use intervals and tx power from mgmt cmds

2020-09-24 Thread Daniel Winkler
are performed with multiple advertisements simultaneously. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v3: None Changes in v2: None include/net/bluetooth/hci_core.h | 5 - net/bluetooth/hci_core.c | 8 +--- net/bluetooth/hci_request.c | 29

[PATCH v2 2/6] Bluetooth: Break add adv into two mgmt commands

2020-09-17 Thread Daniel Winkler
rrect data and parameters in btmon trace - Verified both for software rotation and extended adv Automatic test suite also run, testing many (25) scenarios of single and multi-advertising for data/parameter correctness. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v2: None i

[PATCH v2 4/6] Bluetooth: Emit tx power chosen on ext adv params completion

2020-09-17 Thread Daniel Winkler
the power requested by the user. This patch is manually verified by ensuring the tx power selected event is signalled and caught by bluetoothd. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v2: None include/net/bluetooth/hci_core.h | 2 ++ include/net/bluetooth/mgmt.h

[PATCH v2 5/6] Bluetooth: Query LE tx power on startup

2020-09-17 Thread Daniel Winkler
BT5 devices correctly query and receive controller tx power range. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v2: None include/net/bluetooth/hci.h | 7 +++ include/net/bluetooth/hci_core.h | 2 ++ net/bluetooth/hci_core.c | 8 net/blueto

[PATCH v2 1/6] Bluetooth: Add helper to set adv data

2020-09-17 Thread Daniel Winkler
We wish to handle advertising data separately from advertising parameters in our new MGMT requests. This change adds a helper that allows the advertising data and scan response to be updated for an existing advertising instance. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler

[PATCH v2 6/6] Bluetooth: Add MGMT command for controller capabilities

2020-09-17 Thread Daniel Winkler
it simply contains LE min and max tx power. The change was tested by manually verifying that the new MGMT command returns the tx power range as expected in userspace. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v2: - Fixed sparse error in Capabilities MGMT command

[PATCH v2 0/6] Bluetooth: Add new MGMT interface for advertising add

2020-09-17 Thread Daniel Winkler
o extended advertising) chromebooks with manual testing verifying correctness of parameters/data in btmon traces, and our automated test suite of 25 single- and multi-advertising usage scenarios. A separate patch series will add support in bluetoothd. Thanks in advance for your feedback! Daniel Winkler

[PATCH v2 3/6] Bluetooth: Use intervals and tx power from mgmt cmds

2020-09-17 Thread Daniel Winkler
are performed with multiple advertisements simultaneously. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- Changes in v2: None include/net/bluetooth/hci_core.h | 5 - net/bluetooth/hci_core.c | 8 +--- net/bluetooth/hci_request.c | 29

[PATCH 1/6] Bluetooth: Add helper to set adv data

2020-09-16 Thread Daniel Winkler
We wish to handle advertising data separately from advertising parameters in our new MGMT requests. This change adds a helper that allows the advertising data and scan response to be updated for an existing advertising instance. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler

[PATCH 0/6] Bluetooth: Add new MGMT interface for advertising add

2020-09-16 Thread Daniel Winkler
o extended advertising) chromebooks with manual testing verifying correctness of parameters/data in btmon traces, and our automated test suite of 25 single- and multi-advertising usage scenarios. A separate patch series will add support in bluetoothd. Thanks in advance for your feedback! Daniel Winkler

[PATCH 3/6] Bluetooth: Use intervals and tx power from mgmt cmds

2020-09-16 Thread Daniel Winkler
are performed with multiple advertisements simultaneously. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- include/net/bluetooth/hci_core.h | 5 - net/bluetooth/hci_core.c | 8 +--- net/bluetooth/hci_request.c | 29 +++-- net/bluetooth/mgmt.c

[PATCH 2/6] Bluetooth: Break add adv into two mgmt commands

2020-09-16 Thread Daniel Winkler
rrect data and parameters in btmon trace - Verified both for software rotation and extended adv Automatic test suite also run, testing many (25) scenarios of single and multi-advertising for data/parameter correctness. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- include/net/bluetooth/hci_co

[PATCH 5/6] Bluetooth: Query LE tx power on startup

2020-09-16 Thread Daniel Winkler
BT5 devices correctly query and receive controller tx power range. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- include/net/bluetooth/hci.h | 7 +++ include/net/bluetooth/hci_core.h | 2 ++ net/bluetooth/hci_core.c | 8 net/bluetooth/hci_event.c|

[PATCH 6/6] Bluetooth: Add MGMT command for controller capabilities

2020-09-16 Thread Daniel Winkler
it simply contains LE min and max tx power. The change was tested by manually verifying that the new MGMT command returns the tx power range as expected in userspace. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- include/net/bluetooth/mgmt.h | 9 + net/bluetooth/mgmt.c

[PATCH 4/6] Bluetooth: Emit tx power chosen on ext adv params completion

2020-09-16 Thread Daniel Winkler
the power requested by the user. This patch is manually verified by ensuring the tx power selected event is signalled and caught by bluetoothd. Reviewed-by: Sonny Sasaka Signed-off-by: Daniel Winkler --- include/net/bluetooth/hci_core.h | 2 ++ include/net/bluetooth/mgmt.h | 6 ++ net

[PATCH] Bluetooth: pause/resume advertising around suspend

2020-09-15 Thread Daniel Winkler
failure to receive all advertisements by remote peer * Exit suspend on DUT * Verify reception of all advertisements by remote peer Signed-off-by: Daniel Winkler Reviewed-by: Abhishek Pandit-Subedi --- net/bluetooth/hci_request.c | 67 +++-- 1 file changed, 57

[PATCH 2/2] bluetooth: Add MGMT capability flags for tx power and ext advertising

2020-08-25 Thread Daniel Winkler
with new flags on hatch chromebook (ext advertising supported). Signed-off-by: Daniel Winkler --- include/net/bluetooth/mgmt.h | 2 ++ net/bluetooth/mgmt.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h index beae5c3980f03b

[PATCH 1/2] bluetooth: Report num supported adv instances for hw offloading

2020-08-25 Thread Daniel Winkler
) and hatch (ext adv) chromebooks by verifying "SupportedInstances" shows 5 (the default) and 6 (slots supported by controller), respectively. Signed-off-by: Daniel Winkler --- net/bluetooth/hci_core.c | 2 +- net/bluetooth/mgmt.c | 6 +++--- 2 files changed, 4 insertions(+), 4

[PATCH 0/2] Bluetooth: Report extended adv capabilities to userspace

2020-08-25 Thread Daniel Winkler
. Daniel Winkler (2): bluetooth: Report num supported adv instances for hw offloading bluetooth: Add MGMT capability flags for tx power and ext advertising include/net/bluetooth/mgmt.h | 2 ++ net/bluetooth/hci_core.c | 2 +- net/bluetooth/mgmt.c | 8 +--- 3 files changed, 8

[PATCH v2] Bluetooth: Add per-instance adv disable/remove

2020-07-14 Thread Daniel Winkler
Add functionality to disable and remove advertising instances, and use that functionality in MGMT add/remove advertising calls. Signed-off-by: Daniel Winkler Reviewed-by: Shyh-In Hwang Reviewed-by: Alain Michaud --- Hi Maintainers, Currently, advertising is globally-disabled, i.e. all

[PATCH v1] Bluetooth: Add per-instance adv disable/remove

2020-07-14 Thread Daniel Winkler
Add functionality to disable and remove advertising instances, and use that functionality in MGMT add/remove advertising calls. Signed-off-by: Daniel Winkler Reviewed-by: Shyh-In Hwang Reviewed-by: Alain Michaud --- net/bluetooth/hci_conn.c| 2 +- net/bluetooth/hci_request.c | 59

Re: [PATCH] serial: 8250_mtk: Fix high-speed baud rates clamping

2020-07-14 Thread Daniel Winkler
() function. After the fixes described above are > implemented in the 8250_mtk.c driver, the Mediatek 8250-port should > get back to normally working with extended baud rates. > > Link: > https://lore.kernel.org/linux-serial/20200701211337.3027448-1-danielwink...@google.c

[PATCH v2 1/1] Revert "serial: 8250: Fix max baud limit in generic 8250 port"

2020-07-01 Thread Daniel Winkler
This reverts commit 7b668c064ec33f3d687c3a413d05e355172e6c92. Fixes: 7b668c064ec3 ("serial: 8250: Fix max baud limit in generic 8250 port") Cc: sta...@vger.kernel.org Signed-off-by: Daniel Winkler --- drivers/tty/serial/8250/8250_port.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH v2 0/1] Revert "serial: 8250: Fix max baud limit in generic 8250 port"

2020-07-01 Thread Daniel Winkler
is 300. Our entire suite of bluetooth tests now fail on this platform due to an apparent failure to sync its firmware on initialization. The driver is in the cros tree at drivers/bluetooth/hci_qca.c and uses the serdev interface. Specifically, this is the QCA_ROME chipset. Daniel Winkler (1

Re: [PATCH] Revert "serial: 8250: Fix max baud limit in generic 8250 port"

2020-07-01 Thread Daniel Winkler
Hello all, Please forgive any omitted information, as this is my first upstreaming experience. I am preparing a second patch that will clarify the requested points. Thanks in advance! Best regards, Daniel Winkler On Wed, Jul 1, 2020 at 6:26 AM Greg Kroah-Hartman wrote: > > On Tue,

[PATCH] Revert "serial: 8250: Fix max baud limit in generic 8250 port"

2020-06-30 Thread Daniel Winkler
This reverts commit 0eeaf62981ecc79e8395ca8caa1570eaf3a12257. The change regresses the QCA6174A-3 bluetooth chip, preventing firmware from being properly loaded. We have verified that without this patch, the chip works as intended. Signed-off-by: Daniel Winkler --- drivers/tty/serial/8250